diff mbox series

[V2] tests/link_status_interrupt: close nic link-down-on-close off

Message ID 1633770025-6422-1-git-send-email-songx.jiale@intel.com (mailing list archive)
State Superseded
Headers
Series [V2] tests/link_status_interrupt: close nic link-down-on-close off |

Commit Message

Jiale, SongX Oct. 9, 2021, 9 a.m. UTC 
  since the link-down-on-close of the tester is turned on, but 
not closed, the subsequent tests are affected.

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_link_status_interrupt.py | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)
diff mbox series

Patch

diff --git a/tests/TestSuite_link_status_interrupt.py b/tests/TestSuite_link_status_interrupt.py
index 5590d94..2ad1559 100755
--- a/tests/TestSuite_link_status_interrupt.py
+++ b/tests/TestSuite_link_status_interrupt.py
@@ -70,22 +70,6 @@  class TestLinkStatusInterrupt(TestCase):
             self.basic_intr_mode = ["msix", "legacy"]
         if self.drivername == "vfio-pci":
             self.basic_intr_mode.append("msi")
-        self.intfs = [self.tester.get_interface(self.tester.get_local_port(i)) for i in self.dut_ports]
-        # check link-down-on-close flag
-        self.flag = "link-down-on-close"
-        for intf in self.intfs:
-            check_flag = "ethtool --show-priv-flags %s" % intf
-            set_flag = "ethtool --set-priv-flags %s %s on" % (intf, self.flag)
-            out = self.tester.send_expect(check_flag, "#")
-            p = re.compile('%s\s+:\s+(\w+)' % self.flag)
-            res = re.search(p, out).group(1)
-            if res == "off":
-                self.tester.send_expect(set_flag, "#")
-                time.sleep(0.5)
-                out = self.tester.send_expect(check_flag, "#")
-                self.verify(re.search(p, out).group(1) == "on", "set %s %s on failed" % (intf, self.flag))
-            elif not res:
-                self.logger.info("NIC %s might not support this case" % intf)
 
     def set_link_status_and_verify(self, dutPort, status):
         """
@@ -210,5 +194,4 @@  class TestLinkStatusInterrupt(TestCase):
         Run after each test suite.
         """
         if self.dut.get_os_type() != 'freebsd':
-            for intf in self.intfs:
-                self.tester.send_expect("ethtool --set-priv-flags %s %s off" % (intf, self.flag), "#", 10)
+            self.tester.send_expect("ethtool --set-priv-flags %s link-down-on-close off" % self.intf, "#", 10)