diff mbox series

[V1] tests/iavf_fdir: optimization script

Message ID 1635823099-219112-1-git-send-email-songx.jiale@intel.com (mailing list archive)
State Superseded
Headers
Series [V1] tests/iavf_fdir: optimization script |

Checks

Context Check Description
ci/Intel-dts-suite-test warning SKIPPED

Commit Message

Jiale, SongX Nov. 2, 2021, 3:18 a.m. UTC 
  initialize PF. because pf is not initialized after case test, other case tests fail

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_iavf_fdir.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
 mode change 100755 => 100644 tests/TestSuite_iavf_fdir.py

Comments

Huang, ZhiminX Nov. 2, 2021, 8:37 a.m. UTC | #1 
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Jiale Song
> Sent: Tuesday, November 2, 2021 11:18 AM
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V1] tests/iavf_fdir: optimization script
> 
> initialize PF. because pf is not initialized after case test, other case tests fail
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>
> ---

Tested-by: Zhimin Huang <zhiminx.huang@intel.com >
Tu, Lijuan Nov. 5, 2021, 1:43 p.m. UTC | #2 
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Jiale Song
> Sent: 2021年11月2日 11:18
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V1] tests/iavf_fdir: optimization script
> 
> initialize PF. because pf is not initialized after case test, other case tests fail

For the reason, self.dut.kill_all() should be removed at the same time.

> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>
diff mbox series

Patch

diff --git a/tests/TestSuite_iavf_fdir.py b/tests/TestSuite_iavf_fdir.py
old mode 100755
new mode 100644
index fab7cc27..5803f5f7
--- a/tests/TestSuite_iavf_fdir.py
+++ b/tests/TestSuite_iavf_fdir.py
@@ -7593,6 +7593,7 @@  class TestIAVFFdir(TestCase):
         """
         Run before each test case.
         """
+        self.dut.restore_interfaces_linux()
         self.setup_2pf_4vf_env()
         time.sleep(1)
         self.launch_testpmd()
@@ -8344,7 +8345,6 @@  class TestIAVFFdir(TestCase):
         create same rules on pf and vf, no conflict
         """
         self.dut.kill_all()
-        self.setup_2pf_4vf_env()
         self.session_secondary = self.dut.new_session()
         self.session_third = self.dut.new_session()
 
@@ -8496,7 +8496,6 @@  class TestIAVFFdir(TestCase):
         create same input set but different action rules on pf and vf, no conflict.
         """
         self.dut.kill_all()
-        self.setup_2pf_4vf_env()
         self.session_secondary = self.dut.new_session()
         self.session_third = self.dut.new_session()