[V2,2/4] tests/vf_vlan: modify code to adapt avx512

Message ID 1636008699-16970-2-git-send-email-xiangx.an@intel.com (mailing list archive)
State Changes Requested
Headers
Series [V2,1/4] tests/kernelpf_iavf: modify code to adapt avx512 |

Commit Message

Xiang An Nov. 4, 2021, 6:51 a.m. UTC
  Based on dpdk commit:4b64ccb328 modify dts code to adapt avx512.

Signed-off-by: Xiang An <xiangx.an@intel.com>
---
 tests/TestSuite_vf_vlan.py | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
  

Comments

Tu, Lijuan Nov. 5, 2021, 12:31 p.m. UTC | #1
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xiang An
> Sent: 2021年11月4日 14:52
> To: dts@dpdk.org
> Cc: An, XiangX <xiangx.an@intel.com>
> Subject: [dts] [PATCH V2 2/4] tests/vf_vlan: modify code to adapt avx512
> 
> Based on dpdk commit:4b64ccb328 modify dts code to adapt avx512.
> 
> Signed-off-by: Xiang An <xiangx.an@intel.com>
> ---
>  tests/TestSuite_vf_vlan.py | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py index
> 127eca3..ff3e13f 100644
> --- a/tests/TestSuite_vf_vlan.py
> +++ b/tests/TestSuite_vf_vlan.py
> @@ -35,7 +35,7 @@ import time
> 
>  from framework.packet import Packet
>  from framework.pmd_output import PmdOutput -from framework.settings
> import get_nic_name
> +from framework.settings import get_nic_name, load_global_setting,
> +DPDK_RXMODE_SETTING
>  from framework.test_case import TestCase  from framework.virt_common
> import VM
> 
> @@ -346,7 +346,10 @@ class TestVfVlan(TestCase):
>          self.vm0_dut_ports = self.vm_dut_0.get_ports('any')
> 
>          self.vm0_testpmd = PmdOutput(self.vm_dut_0)
> -        self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
> +        if load_global_setting(DPDK_RXMODE_SETTING) == 'avx512':
> +            self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--enable-rx-cksum')
> +        else:
> +            self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
>          self.vm0_testpmd.execute_cmd('set fwd rxonly')
>          self.vm0_testpmd.execute_cmd('set verbose 1')
>          self.vm0_testpmd.execute_cmd('vlan set strip on 0') @@ -417,7 +420,10
> @@ class TestVfVlan(TestCase):
>          if self.kdriver == "i40e":
>              self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '')
>          else:
> -            self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
> +            if load_global_setting(DPDK_RXMODE_SETTING) == 'avx512':
> +                self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--enable-rx-
> cksum')
> +            else:
> +                self.vm0_testpmd.start_testpmd(VM_CORES_MASK)

AVX512 should have the same behavior with other path,  is this a know issue in dpdk21.11 ? if not, please submit a bug to dpdk.
  

Patch

diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py
index 127eca3..ff3e13f 100644
--- a/tests/TestSuite_vf_vlan.py
+++ b/tests/TestSuite_vf_vlan.py
@@ -35,7 +35,7 @@  import time
 
 from framework.packet import Packet
 from framework.pmd_output import PmdOutput
-from framework.settings import get_nic_name
+from framework.settings import get_nic_name, load_global_setting, DPDK_RXMODE_SETTING
 from framework.test_case import TestCase
 from framework.virt_common import VM
 
@@ -346,7 +346,10 @@  class TestVfVlan(TestCase):
         self.vm0_dut_ports = self.vm_dut_0.get_ports('any')
 
         self.vm0_testpmd = PmdOutput(self.vm_dut_0)
-        self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
+        if load_global_setting(DPDK_RXMODE_SETTING) == 'avx512':
+            self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--enable-rx-cksum')
+        else:
+            self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
         self.vm0_testpmd.execute_cmd('set fwd rxonly')
         self.vm0_testpmd.execute_cmd('set verbose 1')
         self.vm0_testpmd.execute_cmd('vlan set strip on 0')
@@ -417,7 +420,10 @@  class TestVfVlan(TestCase):
         if self.kdriver == "i40e":
             self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '')
         else:
-            self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
+            if load_global_setting(DPDK_RXMODE_SETTING) == 'avx512':
+                self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--enable-rx-cksum')
+            else:
+                self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
         self.vm0_testpmd.execute_cmd('set fwd rxonly')
         self.vm0_testpmd.execute_cmd('set verbose 1')
         self.vm0_testpmd.execute_cmd('start')