| Message ID | 1638792242-1615-1-git-send-email-juraj.linkes@pantheon.tech (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1] framework/config: fix pylama errors | expand |
| Context | Check | Description |
|---|---|---|
| ci/Intel-dts-suite-test | fail | Testing issues |
> -----Original Message----- > From: Juraj Linkeš <juraj.linkes@pantheon.tech> > Sent: 2021年12月6日 20:04 > To: Tu, Lijuan <lijuan.tu@intel.com>; ohilyard@iol.unh.edu > Cc: dts@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech> > Subject: [PATCH v1] framework/config: fix pylama errors > > Pylama found the following errors: > framework/config.py:303: [E] E1133 Non-iterable value sections is used in an > iterating context [pylint] > framework/config.py:405: [E] E1133 Non-iterable value sections is used in an > iterating context [pylint] > framework/config.py:446: [E] E1133 Non-iterable value sections is used in an > iterating context [pylint] > framework/config.py:500: [E] E0602 Undefined variable 'IxiaConf' [pylint] > - remove usage of nonexistent class > > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech> Applied
diff --git a/framework/config.py b/framework/config.py index d0e63bfd..3d7c4936 100644 --- a/framework/config.py +++ b/framework/config.py @@ -75,7 +75,7 @@ class UserConf(): def get_sections(self): if self.conf is None: - return None + return [] return self.conf.sections() @@ -496,10 +496,6 @@ if __name__ == '__main__': crbsconf = CrbsConf(CRBCONF) print(crbsconf.load_crbs_config()) - # example for ixia configuration file - ixiaconf = IxiaConf(IXIACONF) - print(ixiaconf.load_ixia_config()) - # example for suite configure file suiteconf = SuiteConf("suite_sample") print(suiteconf.load_case_config("case1"))
Pylama found the following errors: framework/config.py:303: [E] E1133 Non-iterable value sections is used in an iterating context [pylint] framework/config.py:405: [E] E1133 Non-iterable value sections is used in an iterating context [pylint] framework/config.py:446: [E] E1133 Non-iterable value sections is used in an iterating context [pylint] framework/config.py:500: [E] E0602 Undefined variable 'IxiaConf' [pylint] - remove usage of nonexistent class Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech> --- Lijuan, please add additional people to review if needed. --- framework/config.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)