diff mbox series

[V1] tests/packet_capture: fix testpmd file-prefix for pdump

Message ID 20200813073346.41991-1-qimaix.xiao@intel.com (mailing list archive)
State Accepted
Headers show
Series [V1] tests/packet_capture: fix testpmd file-prefix for pdump | expand

Commit Message

Xiao, QimaiX Aug. 13, 2020, 7:33 a.m. UTC
*. pdump depends on same file prefix with testpmd,
 as start_testpmd method in pmd_output module will attach pid and timestamp in file-prefix by default,
 need set fixed_prefix to True.

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 tests/TestSuite_packet_capture.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Xiao, QimaiX Aug. 14, 2020, 8:35 a.m. UTC | #1
Tested-by: Xiao Qimai <qimaix.xiao@intel.com>

Regards,
Xiao Qimai

> -----Original Message-----
> From: Xiao Qimai <qimaix.xiao@intel.com>
> Sent: Thursday, August 13, 2020 3:34 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts][PATCH V1]tests/packet_capture: fix testpmd file-prefix for
> pdump
> 
> *. pdump depends on same file prefix with testpmd,  as start_testpmd
> method in pmd_output module will attach pid and timestamp in file-prefix by
> default,  need set fixed_prefix to True.
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_packet_capture.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_packet_capture.py
> b/tests/TestSuite_packet_capture.py
> index 6a6a5ea..9c2a309 100644
> --- a/tests/TestSuite_packet_capture.py
> +++ b/tests/TestSuite_packet_capture.py
> @@ -451,7 +451,7 @@ class TestPacketCapture(TestCase):
>                  "rm -fr {0}/*".format(self.pdump_log), "# ", 10)
>          param_opt = "--port-topology=chained"
>          eal_param = '--file-prefix=test'
> -        self.testpmd.start_testpmd("Default", param=param_opt,
> +        self.testpmd.start_testpmd("Default", param=param_opt,
> + fixed_prefix=True,
>                                     eal_param=eal_param)
>          self.testpmd.execute_cmd("set fwd io")
>          self.testpmd.execute_cmd("start")
> --
> 2.25.1
Tu, Lijuan Aug. 21, 2020, 2:50 a.m. UTC | #2
> *. pdump depends on same file prefix with testpmd,  as start_testpmd method in
> pmd_output module will attach pid and timestamp in file-prefix by default,  need
> set fixed_prefix to True.
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>

Applied
diff mbox series

Patch

diff --git a/tests/TestSuite_packet_capture.py b/tests/TestSuite_packet_capture.py
index 6a6a5ea..9c2a309 100644
--- a/tests/TestSuite_packet_capture.py
+++ b/tests/TestSuite_packet_capture.py
@@ -451,7 +451,7 @@  class TestPacketCapture(TestCase):
                 "rm -fr {0}/*".format(self.pdump_log), "# ", 10)
         param_opt = "--port-topology=chained"
         eal_param = '--file-prefix=test'
-        self.testpmd.start_testpmd("Default", param=param_opt,
+        self.testpmd.start_testpmd("Default", param=param_opt, fixed_prefix=True,
                                    eal_param=eal_param)
         self.testpmd.execute_cmd("set fwd io")
         self.testpmd.execute_cmd("start")