From patchwork Wed Sep 9 21:16:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Owen Hilyard X-Patchwork-Id: 77090 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D029AA04B5; Wed, 9 Sep 2020 23:16:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A4B6E1BE0C; Wed, 9 Sep 2020 23:16:52 +0200 (CEST) Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by dpdk.org (Postfix) with ESMTP id E78AC1DB8 for ; Wed, 9 Sep 2020 23:16:51 +0200 (CEST) Received: by mail-qk1-f175.google.com with SMTP id w186so3958957qkd.1 for ; Wed, 09 Sep 2020 14:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+hGd1DYZOVpIZi/M/1LA1VqqBM5vC/oXBVO2qGyxBAs=; b=QR0vDSejzQBShfQ4kLEwMGYhylGtRv3e9VLFlEALrs9g8SS1XXl7ECDR6WasNNQQud rDlVlAi1R/XmVKEYDAFBBisVlzddN7ADWu9E9WbQwoo3WNwc4urKvIaso6YJMjf53pqp fl+Y/7xSl6hZFLpZKNCc+yqHDyMKuEebtKfMM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+hGd1DYZOVpIZi/M/1LA1VqqBM5vC/oXBVO2qGyxBAs=; b=nN68yZxKCU4xCYibd2EQGKw/izjqJs0E6/pxDAQ8wk42Vb/Qry06Da37A1pc+XqjP/ 7BScwz8FyyewrWXPqgmE6SFG+Lb7Nb1fwx8aGR7XOgf6AYpvMBvseI2wsBU9WucaXe46 EBPpk9Cw4P7c9LUfYE9MSPWecXmtIKQRLVpZwOQ5EPxGhMuMKLysoiVHPD4V0h9Qb9T0 lb3+MVvrrAkLW3/WokXiYIpOvamXTD1XQMM90iSEK9gZoTkdGiCAYG85Djal5FM3m0KB hZMJjKiVv30N66RwcCZNjrYlMxBGIh1xqzRDn8YeC02HcmxOkiKfx8jgRb82dirXuy8f x8Aw== X-Gm-Message-State: AOAM532tN0Xc+R7L/jOr1NYKKDK205kJRpMPZ7A8UUqUT8lV/Hes6wlU Ya8E1vEPYb1PvjM3UztYF4KfO2RZY6KSFrZFm9Yd90+3FpmJs83PDyOq5opFFrdg/ykSNxzSfCh mhXgfSV1WpTy9cAGZ4JC1XiSsECriGz+m9LqDTICmtpEUb7IsNgHnHP0UZA== X-Google-Smtp-Source: ABdhPJy3HwDnSD8NeNShBYgnm2urKonI7Xw2Veyjlso0RFGn5pmoNm97Ie1OnthG2dhV3KKWjlh2yg== X-Received: by 2002:a37:e305:: with SMTP id y5mr5008260qki.315.1599686210972; Wed, 09 Sep 2020 14:16:50 -0700 (PDT) Received: from ohilyard-Alienware-m17.unh.edu (nt-238-68.w4.unh.edu. [132.177.238.68]) by smtp.googlemail.com with ESMTPSA id q7sm4465127qte.95.2020.09.09.14.16.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 14:16:50 -0700 (PDT) From: Owen Hilyard To: dts@dpdk.org, lihongx.ma@intel.com Cc: ohilyard@iol.unh.edu, lylavoie@iol.unh.edu Date: Wed, 9 Sep 2020 17:16:47 -0400 Message-Id: <20200909211648.55773-1-ohilyard@iol.unh.edu> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Subject: [dts] [PATCH V1] tests/checksum_offload: Bugfix for bug 529 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" added missing quote in template for scapy packets. rearraged closing down scapy and testpmd to avoid issues with other test cases. Signed-off-by: Owen Hilyard --- tests/TestSuite_checksum_offload.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py index c4a877d..f2e9878 100644 --- a/tests/TestSuite_checksum_offload.py +++ b/tests/TestSuite_checksum_offload.py @@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase): def replay_pcap_file_on_tester(self, iface, packet_file_path): self.tester.send_expect("scapy", ">>>") self.scapy_exec(f"packets = rdpcap('{packet_file_path}')") - self.scapy_exec(f"sendp(packets, iface={iface})") + self.scapy_exec(f"sendp(packets, iface='{iface}')") self.tester.send_expect("quit()", "# ") def validate_packet_list_checksums(self, packets): @@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase): for l4 in l4_protos: for chksum in "", "chksum=0xf": vf = self.send_pkt_expect_good_bad_from_flag_catch_failure( - f"eth/IP({chksum})/{l4}()/(X'*50)", + f"eth/IP({chksum})/{l4}()/('X'*50)", "PKT_RX_IP_CKSUM_", f"{l4}", should_pass=(chksum == "")) if vf is not None: @@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase): # if vf is not None: # verification_errors.append(vf) - # tunneled inner + self.tester.send_expect("quit", "#") + self.dut.send_expect("stop", "testpmd>") for err in verification_errors: self.logger.error(str(err)) self.verify(len(verification_errors) == 0, "See previous output") - self.tester.send_expect("quit", "#") - self.dut.send_expect("stop", "testpmd>") def test_hardware_checksum_check_l4_tx(self): self.checksum_enablehw(self.dut_ports[0]) @@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase): error_messages = self.validate_packet_list_checksums(captured_packets) + self.tester.send_expect("quit", "#") self.dut.send_expect("stop", "testpmd>") + if len(error_messages) != 0: for error_msg in error_messages: self.logger.error(error_msg)