[V1] tests/rte_flow_common modify iavf_fdir queue verify method

Message ID 20201111113754.12739-1-qinx.sun@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] tests/rte_flow_common modify iavf_fdir queue verify method |

Commit Message

Sun, QinX Nov. 11, 2020, 11:37 a.m. UTC
  create a fdir rule, send mismatch packet, sometimes queue id may hit the defaule value set in the rule, 

so can not just compared the queue value to judgle the case failed.

Now,use 'verify_iavf_fdir_directed_by_rss' to check queue is correctly or not after mark id is verifed.


Signed-off-by: sunqin <qinx.sun@intel.com>
---
 tests/rte_flow_common.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Sun, QinX Nov. 11, 2020, 3:10 a.m. UTC | #1
Tested-by: Sun, QinX <qinx.sun@intel.com>
 
Regards,
Sun Qin

> -----Original Message-----
> From: sunqin <qinx.sun@intel.com>
> Sent: Wednesday, November 11, 2020 7:38 PM
> To: dts@dpdk.org
> Cc: Sun, QinX <qinx.sun@intel.com>
> Subject: [dts] [PATCH V1] tests/rte_flow_common modify iavf_fdir queue
> verify method
  
Tu, Lijuan Nov. 11, 2020, 6:51 a.m. UTC | #2
> create a fdir rule, send mismatch packet, sometimes queue id may hit the
> defaule value set in the rule,
> 
> so can not just compared the queue value to judgle the case failed.
> 
> Now,use 'verify_iavf_fdir_directed_by_rss' to check queue is correctly or not
> after mark id is verifed.
> 
> 
> Signed-off-by: sunqin <qinx.sun@intel.com>

Applied
  

Patch

diff --git a/tests/rte_flow_common.py b/tests/rte_flow_common.py
index 43c0eab..e0a378f 100644
--- a/tests/rte_flow_common.py
+++ b/tests/rte_flow_common.py
@@ -454,7 +454,7 @@  def check_iavf_fdir_queue(out, pkt_num, check_param, stats=True):
                 raise Exception("wrong queue value, expect int or list")
         else:
             if isinstance(queue, int):
-                verify(not any(q == queue for q in res_queue), "fail: queue id should not matched, expect queue %s, got %s" % (queue, res_queue))
+                verify_iavf_fdir_directed_by_rss(out, rxq=CVL_TXQ_RXQ_NUMBER, stats=True)
                 print((GREEN("pass: queue id %s not matched" % res_queue)))
             elif isinstance(queue, list):
                 verify_iavf_fdir_directed_by_rss(out, rxq=CVL_TXQ_RXQ_NUMBER, stats=True)