diff mbox series

bugfix: Fixed a timeout with mlx5_core on ARM

Message ID 20210211214415.1454192-1-ohilyard@iol.unh.edu (mailing list archive)
State Accepted
Headers show
Series bugfix: Fixed a timeout with mlx5_core on ARM | expand

Commit Message

Owen Hilyard Feb. 11, 2021, 9:44 p.m. UTC
From: Owen Hilyard <ohilyard@iol.unh.edu>

The time to unbind this driver has been increasing with DPDK releases, to
the point that it is now about 14 seconds. This means that, with the
default timeout of 15 seconds, there isn't much room for any kind of
disruption during testing. DTS throwing a timeout error here is not
indicative of an acutal problem, and as such I have increased the timeout
to allow continued stable functioning. The new 30 second timeout should
have minimal affect on the detection speed of any real error.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
 framework/dut.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tu, Lijuan Feb. 19, 2021, 6:58 a.m. UTC | #1
> The time to unbind this driver has been increasing with DPDK releases, to the
> point that it is now about 14 seconds. This means that, with the default timeout
> of 15 seconds, there isn't much room for any kind of disruption during testing.
> DTS throwing a timeout error here is not indicative of an acutal problem, and as
> such I have increased the timeout to allow continued stable functioning. The
> new 30 second timeout should have minimal affect on the detection speed of
> any real error.
> 
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>

Applied, thanks
diff mbox series

Patch

diff --git a/framework/dut.py b/framework/dut.py
index bef0d15f..21f72e98 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -447,7 +447,7 @@  class Dut(Crb):
                 port = GetNicObj(self, domain_id, bus_id, devfun_id)
 
                 self.send_expect('echo %s > /sys/bus/pci/devices/%s\:%s\:%s/driver/unbind'
-                                 % (pci_bus, domain_id, bus_id, devfun_id), '# ')
+                                 % (pci_bus, domain_id, bus_id, devfun_id), '# ', timeout=30)
                 # bind to linux kernel driver
                 self.send_expect('modprobe %s' % driver, '# ')
                 self.send_expect('echo %s > /sys/bus/pci/drivers/%s/bind'