From patchwork Wed Mar 3 01:37:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng, Yuan" X-Patchwork-Id: 88416 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3633BA055D; Wed, 3 Mar 2021 09:37:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2FE3940683; Wed, 3 Mar 2021 09:37:45 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 605494067B for ; Wed, 3 Mar 2021 09:37:43 +0100 (CET) IronPort-SDR: DtpSixgGmO4hGVLdFsSYrfxTczwdqT5GOEWVC2oHpvnnSdKYDO3T+e9xVTcknsN8rFZ5wwYdqc nWrlcBOt18OQ== X-IronPort-AV: E=McAfee;i="6000,8403,9911"; a="251190974" X-IronPort-AV: E=Sophos;i="5.81,219,1610438400"; d="scan'208";a="251190974" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2021 00:37:41 -0800 IronPort-SDR: vrs0VFHAsoJSx2ab1ZZIivFPUIS565GUXJgPesuIIkXEkWz3RutlEDNkJ0kK/c7K08x7u7oDS3 BsTcL0izUTgA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,219,1610438400"; d="scan'208";a="399615696" Received: from pengyuan-dpdk.sh.intel.com ([10.67.117.236]) by fmsmga008.fm.intel.com with ESMTP; 03 Mar 2021 00:37:40 -0800 From: Peng Yuan To: dts@dpdk.org Cc: Peng Yuan Date: Wed, 3 Mar 2021 01:37:01 +0000 Message-Id: <20210303013701.67025-1-yuan.peng@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dts] [PATCH v4]test_plans: rule lost after port stop X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" switch rule, ACL rule and fdir rule are removed after port stop/start The related test plans are as below: cvl_dcf_switch_filter_test_plan.rst dcf_lifecycle_test_plan.rst iavf_fdir_test_plan.rst Signed-off-by: Peng Yuan diff --git a/test_plans/cvl_dcf_switch_filter_test_plan.rst b/test_plans/cvl_dcf_switch_filter_test_plan.rst index 3b63c041..d6e29984 100644 --- a/test_plans/cvl_dcf_switch_filter_test_plan.rst +++ b/test_plans/cvl_dcf_switch_filter_test_plan.rst @@ -4549,13 +4549,7 @@ Subcase 1: DCF stop/DCF start tetspmd> port stop 0 testpmd> port start 0 -4. check the rule list:: - - testpmd> flow list 0 - - check the rule is still there. - -5. send matched packets, port 1 can still receive the packets. +4. send matched packets, port 1 can't receive the packets. Test case: Drop action test =========================== diff --git a/test_plans/dcf_lifecycle_test_plan.rst b/test_plans/dcf_lifecycle_test_plan.rst index 1e5fcecd..ba45a7ef 100644 --- a/test_plans/dcf_lifecycle_test_plan.rst +++ b/test_plans/dcf_lifecycle_test_plan.rst @@ -950,9 +950,8 @@ TC30: DCF enabled, DCF VF reset port start 0 start -4. check the rule still be listed. - send the packet with new mac address of VF1 again, check the packet still be dropped by VF1. - the rule still take effect. +4. send the packet with new mac address of VF1 again, check the packet not dropped by VF1. + the rule is removed. DCF mode and any ACL filters (not added by DCF) shall be mutually exclusive =========================================================================== diff --git a/test_plans/iavf_fdir_test_plan.rst b/test_plans/iavf_fdir_test_plan.rst index 6de28d2c..f210751f 100644 --- a/test_plans/iavf_fdir_test_plan.rst +++ b/test_plans/iavf_fdir_test_plan.rst @@ -4077,9 +4077,9 @@ Subcase 1: port stop/port start testpmd> port stop 0 testpmd> port start 0 -4. show the rule list, the rule is still there. +4. show the rule list, there is no rule listed. -5. verify matched packet can be still redirected to queue 1 with FDIR matched ID=0x0. +5. verify matched packet is distributed by RSS without FDIR matched ID. Subcase 2: delete rules ----------------------- @@ -4182,8 +4182,9 @@ Subcase 3: VF port reset and create a new rule the port can be stop/reset/start normally without error message. -4. check the rule still be listed, - send matched packet to vf0, check the packet is redirected by RSS without FDIR matched ID. +4. check there is not rule listed on port 0. + the rule of port 1 is still be listed. + send matched packet to vf0, check the packet is distributed by RSS. send matched packet to vf1, check the packet is redirected to queue 5 with FDIR matched ID=0x0. 5. create rule 0 on port 0 again, the rule can be created successfully. @@ -4210,18 +4211,18 @@ Subcase 4: VF port reset and delete the rule 3. vf reset:: - port stop 0 - port reset 0 - port start 0 + port stop 1 + port reset 1 + port start 1 the port can be stop/reset/start normally without error message. -4. check the rule still be listed, - send matched packet to vf0, check the packet is redirected by RSS without FDIR matched ID. - send matched packet to vf1, check the packet is redirected to queue 5 with FDIR matched ID=0x0. +4. check there is not rule listed on port 1. + the rule of port 0 is still be listed. + send matched packet to vf0, check the packet is redirected to queue 5 with FDIR matched ID=0x0. + send matched packet to vf1, check the packet is distributed by RSS. -5. destroy rule 0 of vf0, report error, but no core dump. - destroy rule 0 of vf1 successfully. +5. destroy rule 0 of vf0 successfully. send matched packet to vf0, check the packet is redirected by RSS without FDIR matched ID. send matched packet to vf1, check the packet is redirected by RSS without FDIR matched ID. @@ -4260,7 +4261,7 @@ Subcase 5: PF reset VF and create a new rule the port can be stop/reset/start normally without error message. -5. check the rule of vf0 still be listed, +5. check there is not rule listed on vf0. send matched packet to vf0 with new mac address, check the packet is redirected by RSS without FDIR matched ID. send matched packet to vf1, check the packet is redirected to queue 5 with FDIR matched ID=0x0. @@ -4291,27 +4292,27 @@ Subcase 6: PF reset VF and delete the rule 3. pf trigger vf reset:: - ip link set enp134s0f0 vf 0 mac 00:11:22:33:44:56 + ip link set enp134s0f0 vf 1 mac 00:11:22:33:44:56 4. testpmd shows:: - Port 0: reset event + Port 1: reset event then vf reset:: - port stop 0 - port reset 0 - port start 0 + port stop 1 + port reset 1 + port start 1 the port can be stop/reset/start normally without error message. -5. destroy rule 0 of vf0, report error, but no core dump. - destroy rule 0 of vf1 successfully. +5. check there is not rule listed on vf1. + destroy rule 0 of vf0 successfully. send matched packet to vf0, check the packet is redirected by RSS without FDIR matched ID. send matched packet to vf1, check the packet is redirected by RSS without FDIR matched ID. -6. create rule 0 on port 0 again, the rule can be created successfully. - send matched packet to port 0, the packet can be redirected to queue 5 with FDIR matched ID=0x0. +6. create rule 1 on port 1 again, the rule can be created successfully. + send matched packet to port 1, the packet can be redirected to queue 5 with FDIR matched ID=0x0. 7. quit and relaunch testpmd, then create same rules successfully.