diff mbox series

[V1] tests/pmdrssreta:updated the rx-offloads for foxville_nic

Message ID 20210305174444.368732-1-linglix.chen@intel.com (mailing list archive)
State Changes Requested
Headers show
Series [V1] tests/pmdrssreta:updated the rx-offloads for foxville_nic | expand

Commit Message

Chen, LingliX March 5, 2021, 5:44 p.m. UTC
From: ChenLingli <linglix.chen@intel.com>

updated the rx-offloads for foxville_nic

Signed-off-by: ChenLingli <linglix.chen@intel.com>
---
 tests/TestSuite_pmdrssreta.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Chen, LingliX March 5, 2021, 9:49 a.m. UTC | #1
> -----Original Message-----
> From: Chen, LingliX
> Sent: Saturday, March 6, 2021 1:45 AM
> To: dts@dpdk.org
> Cc: Chen, LingliX <linglix.chen@intel.com>
> Subject: [dts][PATCH V1] tests/pmdrssreta:updated the rx-offloads for
> foxville_nic
> 
 > Signed-off-by: ChenLingli <linglix.chen@intel.com>

Tested-by: Chen Lingli <linglix.chen@intel.com>
Lijuan Tu March 10, 2021, 6:02 a.m. UTC | #2
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Chen Lingli
> Sent: 2021年3月6日 1:45
> To: dts@dpdk.org
> Cc: Chen, LingliX <linglix.chen@intel.com>
> Subject: [dts] [PATCH V1] tests/pmdrssreta:updated the rx-offloads for
> foxville_nic
> 
> From: ChenLingli <linglix.chen@intel.com>
> 
> updated the rx-offloads for foxville_nic
> 
> Signed-off-by: ChenLingli <linglix.chen@intel.com>
> ---
>  tests/TestSuite_pmdrssreta.py | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_pmdrssreta.py b/tests/TestSuite_pmdrssreta.py index
> 4dd3a5a5..09dd2f55 100644
> --- a/tests/TestSuite_pmdrssreta.py
> +++ b/tests/TestSuite_pmdrssreta.py
> @@ -215,8 +215,12 @@ class TestPmdrssreta(TestCase):
>                  self.pmdout.start_testpmd(
>                      "all", "--rxq=%d --txq=%d --rx-offloads=0x00080000 " % (queue,
> queue), socket=self.ports_socket)
>              else:
> -                self.pmdout.start_testpmd(
> -                    "all", "--mbcache=128 --rxq=%d --txq=%d --rx-
> offloads=0x00080000" % (queue, queue), socket=self.ports_socket)
> +                if self.nic == 'foxville':
> +                    self.pmdout.start_testpmd(
> +                        "all", "--mbcache=128 --rxq=%d --txq=%d --rx-
> offloads=0x00032a0f" % (queue, queue), socket=self.ports_socket)

What does the offload mean ?

> +                else:
> +                    self.pmdout.start_testpmd(
> +                        "all", "--mbcache=128 --rxq=%d --txq=%d
> + --rx-offloads=0x00080000" % (queue, queue), socket=self.ports_socket)
> 
>              for iptype, rsstype in list(iptypes.items()):
>                  self.dut.send_expect("set verbose 8", "testpmd> ")
> --
> 2.25.1
Chen, BoX C March 22, 2021, 8:40 a.m. UTC | #3
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Tu, Lijuan
> Sent: March 10, 2021 14:03
> To: Chen, LingliX <linglix.chen@intel.com>; dts@dpdk.org
> Cc: Chen, LingliX <linglix.chen@intel.com>
> Subject: Re: [dts] [PATCH V1] tests/pmdrssreta:updated the rx-offloads for
> foxville_nic
> 
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Chen Lingli
> > Sent: 2021年3月6日 1:45
> > To: dts@dpdk.org
> > Cc: Chen, LingliX <linglix.chen@intel.com>
> > Subject: [dts] [PATCH V1] tests/pmdrssreta:updated the rx-offloads for
> > foxville_nic
> >
> > From: ChenLingli <linglix.chen@intel.com>
> >
> > updated the rx-offloads for foxville_nic
> >
> > Signed-off-by: ChenLingli <linglix.chen@intel.com>
> > ---
> >  tests/TestSuite_pmdrssreta.py | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/TestSuite_pmdrssreta.py
> > b/tests/TestSuite_pmdrssreta.py index
> > 4dd3a5a5..09dd2f55 100644
> > --- a/tests/TestSuite_pmdrssreta.py
> > +++ b/tests/TestSuite_pmdrssreta.py
> > @@ -215,8 +215,12 @@ class TestPmdrssreta(TestCase):
> >                  self.pmdout.start_testpmd(
> >                      "all", "--rxq=%d --txq=%d
> > --rx-offloads=0x00080000 " % (queue, queue), socket=self.ports_socket)
> >              else:
> > -                self.pmdout.start_testpmd(
> > -                    "all", "--mbcache=128 --rxq=%d --txq=%d --rx-
> > offloads=0x00080000" % (queue, queue), socket=self.ports_socket)
> > +                if self.nic == 'foxville':
> > +                    self.pmdout.start_testpmd(
> > +                        "all", "--mbcache=128 --rxq=%d --txq=%d --rx-
> > offloads=0x00032a0f" % (queue, queue), socket=self.ports_socket)
> 
> What does the offload mean ?
> 

offloads=0x80000 is a feature added later, the igc pmd did not do relevant adaptation.
It's DPDK bug, please reject this patch.

> > +                else:
> > +                    self.pmdout.start_testpmd(
> > +                        "all", "--mbcache=128 --rxq=%d --txq=%d
> > + --rx-offloads=0x00080000" % (queue, queue),
> > + socket=self.ports_socket)
> >
> >              for iptype, rsstype in list(iptypes.items()):
> >                  self.dut.send_expect("set verbose 8", "testpmd> ")
> > --
> > 2.25.1
diff mbox series

Patch

diff --git a/tests/TestSuite_pmdrssreta.py b/tests/TestSuite_pmdrssreta.py
index 4dd3a5a5..09dd2f55 100644
--- a/tests/TestSuite_pmdrssreta.py
+++ b/tests/TestSuite_pmdrssreta.py
@@ -215,8 +215,12 @@  class TestPmdrssreta(TestCase):
                 self.pmdout.start_testpmd(
                     "all", "--rxq=%d --txq=%d --rx-offloads=0x00080000 " % (queue, queue), socket=self.ports_socket)
             else:
-                self.pmdout.start_testpmd(
-                    "all", "--mbcache=128 --rxq=%d --txq=%d --rx-offloads=0x00080000" % (queue, queue), socket=self.ports_socket)
+                if self.nic == 'foxville':
+                    self.pmdout.start_testpmd(
+                        "all", "--mbcache=128 --rxq=%d --txq=%d --rx-offloads=0x00032a0f" % (queue, queue), socket=self.ports_socket)
+                else:
+                    self.pmdout.start_testpmd(
+                        "all", "--mbcache=128 --rxq=%d --txq=%d --rx-offloads=0x00080000" % (queue, queue), socket=self.ports_socket)
 
             for iptype, rsstype in list(iptypes.items()):
                 self.dut.send_expect("set verbose 8", "testpmd> ")