diff mbox series

[V1] tests/vhost_user_live_migration:delete invalid code

Message ID 20210315100136.27966-1-weix.ling@intel.com (mailing list archive)
State Superseded
Headers
Series [V1] tests/vhost_user_live_migration:delete invalid code |

Commit Message

Ling, WeiX March 15, 2021, 10:01 a.m. UTC 
  Delete self.stop_send_pkts_on_tester() step in tear_down,
because of framework will auto stop pktgen.

Signed-off-by: Ling Wei <weix.ling@intel.com>
---
 tests/TestSuite_vhost_user_live_migration.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ling, WeiX March 16, 2021, 1:37 a.m. UTC | #1 
> -----Original Message-----
> From: Ling, WeiX <weix.ling@intel.com>
> Sent: Monday, March 15, 2021 06:02 PM
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts][PATCH V1] tests/vhost_user_live_migration:delete invalid
> code

Tested-by: Wei Ling <weix.ling@intel.com>
Zhao, HaiyangX March 16, 2021, 2:30 a.m. UTC | #2 
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Ling Wei
> Sent: Monday, March 15, 2021 18:02
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts] [PATCH V1] tests/vhost_user_live_migration:delete invalid
> code
> 
> Delete self.stop_send_pkts_on_tester() step in tear_down, because of
> framework will auto stop pktgen.
> 
> Signed-off-by: Ling Wei <weix.ling@intel.com>
> ---
>  tests/TestSuite_vhost_user_live_migration.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vhost_user_live_migration.py
> b/tests/TestSuite_vhost_user_live_migration.py
> index 915fa596..d5d1af65 100644
> --- a/tests/TestSuite_vhost_user_live_migration.py
> +++ b/tests/TestSuite_vhost_user_live_migration.py
> @@ -449,7 +449,7 @@ class TestVhostUserLiveMigration(TestCase):
>      def tear_down(self):
>          self.destroy_vm_env()
>          # stop send packet on tester
> -        self.stop_send_pkts_on_tester()
> +        # self.stop_send_pkts_on_tester()

Hi, wei,
If the code should removed, just delete it instead of commentting it, and the comments should be removed too.
diff mbox series

Patch

diff --git a/tests/TestSuite_vhost_user_live_migration.py b/tests/TestSuite_vhost_user_live_migration.py
index 915fa596..d5d1af65 100644
--- a/tests/TestSuite_vhost_user_live_migration.py
+++ b/tests/TestSuite_vhost_user_live_migration.py
@@ -449,7 +449,7 @@  class TestVhostUserLiveMigration(TestCase):
     def tear_down(self):
         self.destroy_vm_env()
         # stop send packet on tester
-        self.stop_send_pkts_on_tester()
+        # self.stop_send_pkts_on_tester()
         self.duts[0].send_expect('killall -s INT qemu-system-x86_64', '#')
         self.duts[1].send_expect('killall -s INT qemu-system-x86_64', '#')
         pass