diff mbox series

[V2] tests/generic_flow_api: Amend the queue list

Message ID 20210408103024.18906-1-yanx.xia@intel.com (mailing list archive)
State Accepted
Headers
Series [V2] tests/generic_flow_api: Amend the queue list |

Commit Message

Yan Xia April 8, 2021, 10:30 a.m. UTC 
  origin: Collect the queue for flow rule validate & create and leave it for later validation
now: only collect flow rule create for later verification, the queue during validate does not need to be verified

Signed-off-by: Xia Yan <yanx.xia@intel.com>
---
 tests/TestSuite_generic_flow_api.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tu, Lijuan April 12, 2021, 5:46 a.m. UTC | #1 
> origin: Collect the queue for flow rule validate & create and leave it for later
> validation
> now: only collect flow rule create for later verification, the queue during
> validate does not need to be verified
> 
> Signed-off-by: Xia Yan <yanx.xia@intel.com>

Applied
diff mbox series

Patch

diff --git a/tests/TestSuite_generic_flow_api.py b/tests/TestSuite_generic_flow_api.py
index 6822f8ab..e8171589 100644
--- a/tests/TestSuite_generic_flow_api.py
+++ b/tests/TestSuite_generic_flow_api.py
@@ -241,11 +241,11 @@  class TestGeneric_flow_api(TestCase):
         for flow_action in basic_flow_actions:
             # generate the flow rule and corresponding packet.
             flow_process = self.generate_random_command(**flow_action)
-            expected_queue.append(flow_process['queue'])
             # caculate the rule number created.
             rule_created = self.flow_test_process(flow_process, flow_action)
             if rule_created:
                 rule_num += 1
+                expected_queue.append(flow_process['queue'])
                 extra_packet.append(flow_process['extrapacket'])
         # Configure a return value.
         extrapkt_rulenum = {'extrapacket': extra_packet, 'rulenum': rule_num, 'queue': expected_queue}