diff mbox series

[V1] tests/enable_package_download_in_ice_driver:adapt testpmd output info

Message ID 20210713130133.445-1-zhiminx.huang@intel.com (mailing list archive)
State Superseded
Headers
Series [V1] tests/enable_package_download_in_ice_driver:adapt testpmd output info |

Commit Message

Huang, ZhiminX July 13, 2021, 1:01 p.m. UTC 
  *.fix code to adapt testpmd output infomation

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
 tests/TestSuite_enable_package_download_in_ice_driver.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Huang, ZhiminX July 13, 2021, 4:31 a.m. UTC | #1 
> -----Original Message-----
> From: Huang, ZhiminX <zhiminx.huang@intel.com>
> Sent: Tuesday, July 13, 2021 9:02 PM
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V1]
> tests/enable_package_download_in_ice_driver:adapt testpmd output info
> 

Tested-by: Zhimin Huang <zhiminx.huang@intel.com >
Tu, Lijuan July 13, 2021, 6:49 a.m. UTC | #2 
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Zhimin Huang
> Sent: 2021年7月13日 21:02
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V1] tests/enable_package_download_in_ice_driver:adapt
> testpmd output info
> 
> *.fix code to adapt testpmd output information

Could you please explain more details? Sorry, I can't get the key point.

Btw, I see the similar handle in tests/TestSuite_iavf_package_driver_error_handle.py
> 
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
> ---
>  tests/TestSuite_enable_package_download_in_ice_driver.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_enable_package_download_in_ice_driver.py
> b/tests/TestSuite_enable_package_download_in_ice_driver.py
> index b57eb794..8bf21d18 100644
> --- a/tests/TestSuite_enable_package_download_in_ice_driver.py
> +++ b/tests/TestSuite_enable_package_download_in_ice_driver.py
> @@ -99,11 +99,11 @@ class
> TestEnable_Package_Download_In_Ice_Driver(TestCase):
>          out = self.dut_testpmd.start_testpmd("all", "--nb-cores=8 --rxq=%s --
> txq=%s --port-topology=chained" % (self.PF_QUEUE, self.PF_QUEUE),
> eal_param=self.eal_param)
>          if ice_pkg == "false":
>              if safe_mode_support == "true":
> -                error_messages = ["ice_load_pkg(): failed to allocate buf of size 0 for
> package", \
> +                error_messages = ["ice_load_pkg(): ice_copy_and_init_hw
> + failed: -1", \
>                      "ice_dev_init(): Failed to load the DDP package,Entering Safe Mode",
> \
>                      "ice_init_rss(): RSS is not supported in safe mode"]
>              if safe_mode_support == "false":
> -                error_messages = ["ice_load_pkg(): failed to allocate buf of size 0 for
> package", \
> +                error_messages = ["ice_load_pkg(): ice_copy_and_init_hw
> + failed: -1", \
>                      "ice_dev_init(): Failed to load the DDP package,Use safe-mode-
> support=1 to enter Safe Mode"]
>              for error_message in error_messages:
>                  self.verify(error_message in out, "There should be error messages in
> out: %s" % out) @@ -291,7 +291,7 @@ class
> TestEnable_Package_Download_In_Ice_Driver(TestCase):
>          self.use_correct_ice_pkg(flag="false")
>          cmd = self.path + "-c 0x7 -n 4 -- -i --nb-cores=8 --rxq=%s --txq=%s --port-
> topology=chained" % (self.PF_QUEUE, self.PF_QUEUE)
>          out = self.dut.send_expect(cmd, "#", 60)
> -        error_messages = ["ice_load_pkg(): failed to allocate buf of size 0 for
> package", \
> +        error_messages = ["ice_load_pkg(): ice_copy_and_init_hw failed:
> + -1", \
>                  "ice_dev_init(): Failed to load the DDP package,Use safe-mode-
> support=1 to enter Safe Mode"]
>          for error_message in error_messages:
>              self.verify(error_message in out, "There should be '%s' in out: %s" %
> (error_message, out))
> --
> 2.17.1
Huang, ZhiminX July 13, 2021, 8:19 a.m. UTC | #3 
Hi lijuan,

The error log has changed by start testpmd with wrong pkg.

21.05:
ice_load_pkg(): failed to allocate buf of size 0 for package
ice_dev_init(): Failed to load the DDP package,Use safe-mode-support=1 to enter Safe Mode
21.08:
ice_load_pkg(): ice_copy_and_init_hw failed: -1
ice_dev_init(): Failed to load the DDP package,Use safe-mode-support=1 to enter Safe Mode

TestSuite_iavf_package_driver_error_handle.py only have this method but not used.


Regards,
HuangZhiMin


> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: Tuesday, July 13, 2021 2:49 PM
> To: Huang, ZhiminX <zhiminx.huang@intel.com>; dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: RE: [dts] [PATCH V1]
> tests/enable_package_download_in_ice_driver:adapt testpmd output info
> 
> 
> 
> > -----Original Message-----
> > From: dts <mailto:dts-bounces@dpdk.org> On Behalf Of Zhimin Huang
> > Sent: 2021年7月13日 21:02
> > To: mailto:dts@dpdk.org
> > Cc: Huang, ZhiminX <mailto:zhiminx.huang@intel.com>
> > Subject: [dts] [PATCH V1]
> > tests/enable_package_download_in_ice_driver:adapt
> > testpmd output info
> >
> > *.fix code to adapt testpmd output information
> 
> Could you please explain more details? Sorry, I can't get the key point.
> 
> Btw, I see the similar handle in
> tests/TestSuite_iavf_package_driver_error_handle.py
> >
> > Signed-off-by: Zhimin Huang <mailto:zhiminx.huang@intel.com>
> > ---
> >  tests/TestSuite_enable_package_download_in_ice_driver.py | 6
> +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/tests/TestSuite_enable_package_download_in_ice_driver.py
> > b/tests/TestSuite_enable_package_download_in_ice_driver.py
> > index b57eb794..8bf21d18 100644
> > --- a/tests/TestSuite_enable_package_download_in_ice_driver.py
> > +++ b/tests/TestSuite_enable_package_download_in_ice_driver.py
> > @@ -99,11 +99,11 @@ class
> > TestEnable_Package_Download_In_Ice_Driver(TestCase):
> >          out = self.dut_testpmd.start_testpmd("all", "--nb-cores=8
> > --rxq=%s -- txq=%s --port-topology=chained" % (self.PF_QUEUE,
> > self.PF_QUEUE),
> > eal_param=self.eal_param)
> >          if ice_pkg == "false":
> >              if safe_mode_support == "true":
> > -                error_messages = ["ice_load_pkg(): failed to allocate
> buf of size 0 for
> > package", \
> > +                error_messages = ["ice_load_pkg():
> > + ice_copy_and_init_hw
> > + failed: -1", \
> >                      "ice_dev_init(): Failed to load the DDP
> > package,Entering Safe Mode", \
> >                      "ice_init_rss(): RSS is not supported in safe
> mode"]
> >              if safe_mode_support == "false":
> > -                error_messages = ["ice_load_pkg(): failed to allocate
> buf of size 0 for
> > package", \
> > +                error_messages = ["ice_load_pkg():
> > + ice_copy_and_init_hw
> > + failed: -1", \
> >                      "ice_dev_init(): Failed to load the DDP
> > package,Use safe-mode-
> > support=1 to enter Safe Mode"]
> >              for error_message in error_messages:
> >                  self.verify(error_message in out, "There should be
> > error messages in
> > out: %s" % out) @@ -291,7 +291,7 @@ class
> > TestEnable_Package_Download_In_Ice_Driver(TestCase):
> >          self.use_correct_ice_pkg(flag="false")
> >          cmd = self.path + "-c 0x7 -n 4 -- -i --nb-cores=8 --rxq=%s
> > --txq=%s --port- topology=chained" % (self.PF_QUEUE, self.PF_QUEUE)
> >          out = self.dut.send_expect(cmd, "#", 60)
> > -        error_messages = ["ice_load_pkg(): failed to allocate buf of
> size 0 for
> > package", \
> > +        error_messages = ["ice_load_pkg(): ice_copy_and_init_hw
> failed:
> > + -1", \
> >                  "ice_dev_init(): Failed to load the DDP package,Use
> > safe-mode-
> > support=1 to enter Safe Mode"]
> >          for error_message in error_messages:
> >              self.verify(error_message in out, "There should be '%s'
> > in out: %s" % (error_message, out))
> > --
> > 2.17.1
>
diff mbox series

Patch

diff --git a/tests/TestSuite_enable_package_download_in_ice_driver.py b/tests/TestSuite_enable_package_download_in_ice_driver.py
index b57eb794..8bf21d18 100644
--- a/tests/TestSuite_enable_package_download_in_ice_driver.py
+++ b/tests/TestSuite_enable_package_download_in_ice_driver.py
@@ -99,11 +99,11 @@  class TestEnable_Package_Download_In_Ice_Driver(TestCase):
         out = self.dut_testpmd.start_testpmd("all", "--nb-cores=8 --rxq=%s --txq=%s --port-topology=chained" % (self.PF_QUEUE, self.PF_QUEUE), eal_param=self.eal_param)
         if ice_pkg == "false":
             if safe_mode_support == "true":
-                error_messages = ["ice_load_pkg(): failed to allocate buf of size 0 for package", \
+                error_messages = ["ice_load_pkg(): ice_copy_and_init_hw failed: -1", \
                     "ice_dev_init(): Failed to load the DDP package,Entering Safe Mode", \
                     "ice_init_rss(): RSS is not supported in safe mode"]
             if safe_mode_support == "false":
-                error_messages = ["ice_load_pkg(): failed to allocate buf of size 0 for package", \
+                error_messages = ["ice_load_pkg(): ice_copy_and_init_hw failed: -1", \
                     "ice_dev_init(): Failed to load the DDP package,Use safe-mode-support=1 to enter Safe Mode"]
             for error_message in error_messages:
                 self.verify(error_message in out, "There should be error messages in out: %s" % out)
@@ -291,7 +291,7 @@  class TestEnable_Package_Download_In_Ice_Driver(TestCase):
         self.use_correct_ice_pkg(flag="false")
         cmd = self.path + "-c 0x7 -n 4 -- -i --nb-cores=8 --rxq=%s --txq=%s --port-topology=chained" % (self.PF_QUEUE, self.PF_QUEUE)
         out = self.dut.send_expect(cmd, "#", 60)
-        error_messages = ["ice_load_pkg(): failed to allocate buf of size 0 for package", \
+        error_messages = ["ice_load_pkg(): ice_copy_and_init_hw failed: -1", \
                 "ice_dev_init(): Failed to load the DDP package,Use safe-mode-support=1 to enter Safe Mode"]
         for error_message in error_messages:
             self.verify(error_message in out, "There should be '%s' in out: %s" % (error_message, out))