diff mbox series

[V1] tests/vxlan:Vxlan ipv6 checksum offload add set outer-udp

Message ID 20211111142754.18841-1-leweix.yang@intel.com (mailing list archive)
State Accepted
Headers show
Series [V1] tests/vxlan:Vxlan ipv6 checksum offload add set outer-udp | expand

Checks

Context Check Description
ci/Intel-dts-doc-test success Testing OK
ci/Intel-dts-suite-test success Testing OK

Commit Message

Lewei Yang Nov. 11, 2021, 2:27 p.m. UTC 
From: YangLewei <leweix.yang@intel.com>

According to dpdk commit 8cc79a1636cd("net/i40e: fix forward outer IPv6 VXLAN"),
this patch added outer UDP checksum,so need set csum hw outer-udp to forward outer IPv6 VXLAN packets.

Signed-off-by: YangLewei <leweix.yang@intel.com>
---
 test_plans/vxlan_test_plan.rst | 1 +
 tests/TestSuite_vxlan.py       | 1 +
 2 files changed, 2 insertions(+)

Comments

Lijuan Tu Nov. 22, 2021, 2:15 p.m. UTC | #1 
> -----Original Message-----
> From: Lewei Yang <leweix.yang@intel.com>
> Sent: 2021年11月11日 22:28
> To: dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add set outer-udp
> 
> From: YangLewei <leweix.yang@intel.com>
> 
> According to dpdk commit 8cc79a1636cd("net/i40e: fix forward outer IPv6
> VXLAN"), this patch added outer UDP checksum,so need set csum hw outer-udp
> to forward outer IPv6 VXLAN packets.
> 
> Signed-off-by: YangLewei <leweix.yang@intel.com>

Only test plan changed, or forgot test script ?
Yu Jiang Nov. 23, 2021, 6:20 a.m. UTC | #2 
> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: Monday, November 22, 2021 10:16 PM
> To: Yang, LeweiX <leweix.yang@intel.com>; dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: RE: [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add set
> outer-udp
> 
> > -----Original Message-----
> > From: Lewei Yang <leweix.yang@intel.com>
> > Sent: 2021年11月11日 22:28
> > To: dts@dpdk.org
> > Cc: Yang, LeweiX <leweix.yang@intel.com>
> > Subject: [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add set
> > outer-udp
> >
> > From: YangLewei <leweix.yang@intel.com>
> >
> > According to dpdk commit 8cc79a1636cd("net/i40e: fix forward outer
> > IPv6 VXLAN"), this patch added outer UDP checksum,so need set csum hw
> > outer-udp to forward outer IPv6 VXLAN packets.
> >
> > Signed-off-by: YangLewei <leweix.yang@intel.com>
> 
> Only test plan changed, or forgot test script ?
Test plan and test suite both have been changed in this patch. Pls double check and merge them if possible. Thanks a lot.
Lijuan Tu Nov. 23, 2021, 1:51 p.m. UTC | #3 
> -----Original Message-----
> From: Jiang, YuX <yux.jiang@intel.com>
> Sent: 2021年11月23日 14:21
> To: Tu, Lijuan <lijuan.tu@intel.com>; Yang, LeweiX <leweix.yang@intel.com>;
> dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: RE: [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add set outer-
> udp
> 
> > -----Original Message-----
> > From: Tu, Lijuan <lijuan.tu@intel.com>
> > Sent: Monday, November 22, 2021 10:16 PM
> > To: Yang, LeweiX <leweix.yang@intel.com>; dts@dpdk.org
> > Cc: Yang, LeweiX <leweix.yang@intel.com>
> > Subject: RE: [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add
> > set outer-udp
> >
> > > -----Original Message-----
> > > From: Lewei Yang <leweix.yang@intel.com>
> > > Sent: 2021年11月11日 22:28
> > > To: dts@dpdk.org
> > > Cc: Yang, LeweiX <leweix.yang@intel.com>
> > > Subject: [PATCH V1] tests/vxlan:Vxlan ipv6 checksum offload add set
> > > outer-udp
> > >
> > > From: YangLewei <leweix.yang@intel.com>
> > >
> > > According to dpdk commit 8cc79a1636cd("net/i40e: fix forward outer
> > > IPv6 VXLAN"), this patch added outer UDP checksum,so need set csum
> > > hw outer-udp to forward outer IPv6 VXLAN packets.
> > >
> > > Signed-off-by: YangLewei <leweix.yang@intel.com>
> >
> > Only test plan changed, or forgot test script ?
> Test plan and test suite both have been changed in this patch. Pls double check
> and merge them if possible. Thanks a lot.

Applied
diff mbox series

Patch

diff --git a/test_plans/vxlan_test_plan.rst b/test_plans/vxlan_test_plan.rst
index 8af3d8b4..1db5b488 100644
--- a/test_plans/vxlan_test_plan.rst
+++ b/test_plans/vxlan_test_plan.rst
@@ -240,6 +240,7 @@  Enable IP,UDP,TCP,SCTP,VXLAN checksum offload::
     csum set tcp hw 0
     csum set stcp hw 0
     csum set outer-ip hw 0
+    csum set outer-udp hw 0
 
 Send ipv6 packet with valid checksum and check there's no chksum error counter
 increased.
diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py
index 1442578d..75b890ee 100644
--- a/tests/TestSuite_vxlan.py
+++ b/tests/TestSuite_vxlan.py
@@ -754,6 +754,7 @@  class TestVxlan(TestCase):
         self.dut.send_expect("set fwd csum", "testpmd>", 10)
         self.csum_set_type('outer-ip', self.recv_port)
         self.csum_set_type('udp', self.recv_port)
+        self.csum_set_type('outer-udp', self.recv_port)
         self.csum_set_type('tcp', self.recv_port)
         self.csum_set_type('sctp', self.recv_port)
         self.dut.send_expect("csum parse-tunnel on %d" %