From patchwork Wed Nov 17 16:26:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Owen Hilyard X-Patchwork-Id: 104483 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D63CBA0C41; Wed, 17 Nov 2021 17:26:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F2EC40687; Wed, 17 Nov 2021 17:26:38 +0100 (CET) Received: from mail-pl1-f226.google.com (mail-pl1-f226.google.com [209.85.214.226]) by mails.dpdk.org (Postfix) with ESMTP id 1299D40040 for ; Wed, 17 Nov 2021 17:26:37 +0100 (CET) Received: by mail-pl1-f226.google.com with SMTP id p18so2587875plf.13 for ; Wed, 17 Nov 2021 08:26:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GAsLMSvtcUFChh4PGg3T8wBWnRXv0Z5QvmHnlhnZHuQ=; b=AogJV2dL29JQKvoAvMoi6xCF7zvS0c4SFBBAOa07fFV5ZbJlTPHaKGzbK1una4Dc7k BRsJIVlYIDxIvjG7Q1q2InserZENfUpaz+XBspGyCXQpJPv1RvG6OUXZOnDm3qq0VgGE wVZnLhWwW2BQtfUtzPB+X/2q9xPgmnWGAVhFk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GAsLMSvtcUFChh4PGg3T8wBWnRXv0Z5QvmHnlhnZHuQ=; b=CuP9uZj7cZWkxcT0hFtxjmaBMWw9mM1rNxPuN7xmLEG1/FEuHTF0LW97jGS9TjeHdi +fAmvMWseikr0UNqrTwjoxxgUtPiufLthXPa8b3Ssvc+ux9WFHH0x1iaLa0ZBVn52EaE zRAQLBaZUGToX7ZV7fbJHM3Y29udxvfcq7lZBlPL2VJABNT7Fr7cunZctmRoAI2x2j89 WD25EszbLJtYk3l7utErJyDekTLBtQvwjxprJaX751/AeEvNuX22VHZHvdrX+DFIcbot RUQ/Qq4Q0I/tjDrIlVMNpLhtua7Cw2IUEnd6mSQCpVn7KmuXCSzJfeYQUkVtRQBeWT5b svDQ== X-Gm-Message-State: AOAM531LDi92aIagy5FsP6XvJP2F0Be99leihCWQqvwcDb0SloyCobmG 1aXeYxP9KM1d1fsJz74tHW2Lf1UHyndNec+78JbUu3Lfaq93HSKjTErkr1KP8NO1WOmTW6A3/rP /7bky/uFGw4eQM4Nwuokg/Ai5oKoX7QsBr5y4xSrjB0YtkNTij98Ssnrm6xPVzUnCijNnUyc+bA == X-Google-Smtp-Source: ABdhPJz+fcVAkJKrvkJeNn4okjoaC3JwwT7UP4lmP/+0gSFI88Hnhjj/BLO9uRSRYKHEwPpybXJgUlzwdyDk X-Received: by 2002:a17:902:e842:b0:142:dbc:bade with SMTP id t2-20020a170902e84200b001420dbcbademr57862843plg.45.1637166396043; Wed, 17 Nov 2021 08:26:36 -0800 (PST) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84]) by smtp-relay.gmail.com with ESMTPS id q13sm65990pjg.7.2021.11.17.08.26.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Nov 2021 08:26:36 -0800 (PST) X-Relaying-Domain: iol.unh.edu Received: from iol.unh.edu (unknown [IPv6:2606:4100:3880:1257::105d]) by postal.iol.unh.edu (Postfix) with ESMTP id 2FFBD605247D; Wed, 17 Nov 2021 11:26:35 -0500 (EST) From: ohilyard@iol.unh.edu To: dts@dpdk.org Cc: lijuan.tu@intel.com, Owen Hilyard Subject: [PATCH v2] framework: Advise against using root passwords Date: Wed, 17 Nov 2021 11:26:26 -0500 Message-Id: <20211117162625.26582-1-ohilyard@iol.unh.edu> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org From: Owen Hilyard Added messages to notify the user that a blank password field will use ssh keys, and that using root passwords is insecure. Signed-off-by: Owen Hilyard --- conf/crbs.cfg | 4 ++-- tools/setup.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/conf/crbs.cfg b/conf/crbs.cfg index b6c0a9af..a12e60a4 100644 --- a/conf/crbs.cfg +++ b/conf/crbs.cfg @@ -2,10 +2,10 @@ #[DUT IP] # dut_ip: DUT ip address # dut_user: Login DUT username -# dut_passwd: Login DUT password +# dut_passwd: [INSECURE] Login DUT password, leaving this blank will force using SSH keys # os: operation system type linux or freebsd # tester_ip: Tester ip address -# tester_passwd: Tester password +# tester_passwd: [INSECURE] Tester password, leaving this blank will force using SSH keys # pktgen_group: packet generator group name: ixia/trex/ixia_network # channels: Board channel number # bypass_core0: Whether by pass core0 diff --git a/tools/setup.py b/tools/setup.py index 3873a884..c70730c7 100755 --- a/tools/setup.py +++ b/tools/setup.py @@ -105,7 +105,7 @@ def config_crbs(): passwd_option = {'prompt': 'DUT root password', 'type': 'string', - 'help': 'Please input password of DUT crb', + 'help': '[INSECURE] Please input password of DUT crb (leave blank to use preconfigured SSH keys)', 'default': ''} opt = Option(**passwd_option) dut_pass = opt.parse_input() @@ -120,7 +120,7 @@ def config_crbs(): passwd_option = {'prompt': 'Tester root password', 'type': 'string', - 'help': 'Please input password of Tester crb', + 'help': '[INSECURE] Please input password of Tester crb (leave blank to use preconfigured SSH keys)', 'default': ''} opt = Option(**passwd_option) tester_pass = opt.parse_input()