From patchwork Fri Nov 19 16:59:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lewei Yang X-Patchwork-Id: 104530 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 397F2A0C4B; Fri, 19 Nov 2021 09:28:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1422B40143; Fri, 19 Nov 2021 09:28:49 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id B56FF40140 for ; Fri, 19 Nov 2021 09:28:47 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10172"; a="234211626" X-IronPort-AV: E=Sophos;i="5.87,246,1631602800"; d="scan'208";a="234211626" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2021 00:28:46 -0800 X-IronPort-AV: E=Sophos;i="5.87,246,1631602800"; d="scan'208";a="537038370" Received: from unknown (HELO DPDK-CVL-tetser102.icx.intel.com) ([10.240.183.102]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2021 00:28:45 -0800 From: Lewei Yang To: dts@dpdk.org Cc: Lewei Yang Subject: [dts][PATCH V1] tests/unit_tests_eal:remove unnecessary test commands Date: Fri, 19 Nov 2021 16:59:21 +0000 Message-Id: <20211119165921.30672-1-leweix.yang@intel.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org According to dpdk commit 81169a01ff2e("test: remove unnecessary test commands"), Nothing is referencing eal_flags_autotest and rwlock_autotest anymore,since we dropped the python wrapper. Signed-off-by: Lewei Yang --- test_plans/unit_tests_eal_test_plan.rst | 21 --------------------- tests/TestSuite_unit_tests_eal.py | 23 ----------------------- 2 files changed, 44 deletions(-) diff --git a/test_plans/unit_tests_eal_test_plan.rst b/test_plans/unit_tests_eal_test_plan.rst index 4cb9d6b9..f4aacb67 100644 --- a/test_plans/unit_tests_eal_test_plan.rst +++ b/test_plans/unit_tests_eal_test_plan.rst @@ -111,27 +111,6 @@ Spinlock for each core, in the correct order. The autotest script checks that this order is correct. -Rwlock -====== - -- There is a global rwlock and a table of rwlocks (one per lcore). - -- The test function takes all of these locks and launches the - ``test_rwlock_per_core()`` function on each core (except the master). - - - The function takes the global write lock, display something, - then releases the global lock. - - Then, it takes the per-lcore write lock, display something, and - releases the per-core lock. - - Finally, a read lock is taken during 100 ms, then released. - -- The main function unlocks the per-lcore locks sequentially and - waits between each lock. This triggers the display of a message - for each core, in the correct order. - - Then, it tries to take the global write lock and display the last - message. The autotest script checks that the message order is correct. - Atomic Variables ================ diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py index 8096183c..db2579ce 100644 --- a/tests/TestSuite_unit_tests_eal.py +++ b/tests/TestSuite_unit_tests_eal.py @@ -286,16 +286,6 @@ class TestUnitTestsEal(TestCase): self.dut.send_expect("quit", "# ") self.verify("Test OK" in out, "Test failed") - def test_rwlock(self): - """ - Run rwlock autotest. - """ - - self.dut.send_expect(self.test_app_cmdline, "R.*T.*E.*>.*>", self.start_test_time) - out = self.dut.send_expect("rwlock_autotest", "RTE>>", self.run_cmd_time) - self.dut.send_expect("quit", "# ") - self.verify("Test OK" in out, "Test failed") - def test_prefetch(self): """ Run prefetch autotest. @@ -356,19 +346,6 @@ class TestUnitTestsEal(TestCase): self.dut.send_expect("quit", "# ") self.verify("Test OK" in out, "Test failed") - def test_flags(self): - """ - Run eal flags autotest. - """ - - self.dut.unbind_interfaces_linux() - self.dut.send_expect(self.test_app_cmdline + ' -m 64', "R.*T.*E.*>.*>", self.start_test_time) - # on FreeBSD need more time than other OS - out = self.dut.send_expect("eal_flags_autotest", "RTE>>", 600) - self.dut.send_expect("quit", "# ") - self.dut.bind_interfaces_linux(driver=self.drivername) - self.verify("Test OK" in out, "Test failed") - def test_alarm(self): """ Run alarm autotest.