[V2] framework/crb: Add functions of check and wait specified link status

Message ID 20220125070809.1810-1-junx.dong@intel.com (mailing list archive)
State Accepted
Headers
Series [V2] framework/crb: Add functions of check and wait specified link status |

Checks

Context Check Description
ci/Intel-dts-suite-test success Testing OK

Commit Message

Jun Dong Jan. 25, 2022, 7:08 a.m. UTC
  Signed-off-by: DongJunX <junx.dong@intel.com>
---
 framework/crb.py | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
  

Comments

Yu Jiang Jan. 26, 2022, 3:18 a.m. UTC | #1
> -----Original Message-----
> From: DongJunX <junx.dong@intel.com>
> Sent: Tuesday, January 25, 2022 3:08 PM
> To: dts@dpdk.org
> Cc: Tu, Lijuan <lijuan.tu@intel.com>; Sun, QingX <qingx.sun@intel.com>;
> Dong, JunX <junx.dong@intel.com>
> Subject: [DTS][V2] framework/crb: Add functions of check and wait specified
> link status
> 
> Signed-off-by: DongJunX <junx.dong@intel.com>
> ---
Tested-by: Yu Jiang <YuX.Jiang@intel.com>

>  framework/crb.py | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/framework/crb.py b/framework/crb.py index bd4f565d..7875510f
> 100755
> --- a/framework/crb.py
> +++ b/framework/crb.py
> @@ -907,3 +907,33 @@ class Crb(object):
>          else:
>              self.logger.info("NIC %s may be not find %s" % (intf, flag))
>              return False
> +
> +    def is_interface_up(self, intf, timeout=15):
> +        """
> +        check and wait port link status up until timeout
> +        """
> +        for i in range(timeout):
> +            link_status = self.get_interface_link_status(intf)
> +            if link_status == 'Up':
> +                return True
> +            time.sleep(1)
> +        self.logger.error(f"check and wait {intf} link up timeout")
> +        return False
> +
> +    def is_interface_down(self, intf, timeout=15):
> +        """
> +        check and wait port link status down until timeout
> +        """
> +        for i in range(timeout):
> +            link_status = self.get_interface_link_status(intf)
> +            if link_status == 'Down':
> +                return True
> +            time.sleep(1)
> +        self.logger.error(f"check and wait {intf} link down timeout")
> +        return False
> +
> +    def get_interface_link_status(self, intf):
> +        out = self.send_expect(f"ethtool {intf}", "#")
> +        link_status_matcher = r'Link detected: (\w+)'
> +        link_status = re.search(link_status_matcher, out).groups()[0]
> +        return 'Up' if link_status == 'yes' else 'Down'
> --
> 2.33.1.windows.1
  
Tu, Lijuan Jan. 29, 2022, 3:12 a.m. UTC | #2
> > Subject: [DTS][V2] framework/crb: Add functions of check and wait
> > specified link status
> >
> > Signed-off-by: DongJunX <junx.dong@intel.com>
> > ---
> Tested-by: Yu Jiang <YuX.Jiang@intel.com>

Applied
  

Patch

diff --git a/framework/crb.py b/framework/crb.py
index bd4f565d..7875510f 100755
--- a/framework/crb.py
+++ b/framework/crb.py
@@ -907,3 +907,33 @@  class Crb(object):
         else:
             self.logger.info("NIC %s may be not find %s" % (intf, flag))
             return False
+
+    def is_interface_up(self, intf, timeout=15):
+        """
+        check and wait port link status up until timeout
+        """
+        for i in range(timeout):
+            link_status = self.get_interface_link_status(intf)
+            if link_status == 'Up':
+                return True
+            time.sleep(1)
+        self.logger.error(f"check and wait {intf} link up timeout")
+        return False
+
+    def is_interface_down(self, intf, timeout=15):
+        """
+        check and wait port link status down until timeout
+        """
+        for i in range(timeout):
+            link_status = self.get_interface_link_status(intf)
+            if link_status == 'Down':
+                return True
+            time.sleep(1)
+        self.logger.error(f"check and wait {intf} link down timeout")
+        return False
+
+    def get_interface_link_status(self, intf):
+        out = self.send_expect(f"ethtool {intf}", "#")
+        link_status_matcher = r'Link detected: (\w+)'
+        link_status = re.search(link_status_matcher, out).groups()[0]
+        return 'Up' if link_status == 'yes' else 'Down'