From patchwork Wed Jan 26 12:39:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yu Jiang X-Patchwork-Id: 106528 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67ADBA0352; Wed, 26 Jan 2022 05:39:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E118B426D3; Wed, 26 Jan 2022 05:39:39 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 99CD14069D for ; Wed, 26 Jan 2022 05:39:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643171978; x=1674707978; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MMifA4AYvrfaQjblC/EvJk2gs+SEC5yR5P9vp6sjT3I=; b=TxGpX3ofKtE74hasWUtiCp6/VyV0PysN9yZ2gvmvqA7FH7KzW0pyLc4Q c35A9pNQXFDekP6X2KNQ45QJWKXx+O3SCJkq1O9KaZphk/RAtRYxX5fAM PXkxdj2wBObvm4q3kTfb249yOhrFJ+p3WLlGmzQf0yz4hvtQmXqxDteYo WsLXm+Rqg0WcYxp9VB+RnvGdr/WNJ07X83fquNSBdUzIQs8uPYCjqiQHC BCpXsW3Ce8Akz3YQ6pQuKo8N1SM7ovf9AWWLPy5ASuD35kMNrZwORpQkz ImNCt5/NcZJP5euUBmReoBVxnnx4bZV6hkqQ0/eiB+g7cZOEaoNMaq/4Z g==; X-IronPort-AV: E=McAfee;i="6200,9189,10238"; a="246259133" X-IronPort-AV: E=Sophos;i="5.88,316,1635231600"; d="scan'208";a="246259133" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2022 20:39:38 -0800 X-IronPort-AV: E=Sophos;i="5.88,316,1635231600"; d="scan'208";a="535037975" Received: from unknown (HELO localhost.localdomain) ([10.239.251.226]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2022 20:39:36 -0800 From: Yu Jiang To: lijuan.tu@intel.com, dts@dpdk.org Cc: Yu Jiang Subject: [dts][PATCH V1 1/2] tests/hotplug_mp: wait for interface up Date: Wed, 26 Jan 2022 12:39:28 +0000 Message-Id: <20220126123929.2256052-2-yux.jiang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220126123929.2256052-1-yux.jiang@intel.com> References: <20220126123929.2256052-1-yux.jiang@intel.com> MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org use new method: is_interface_up to replace redundant code, ensure link up. Signed-off-by: Yu Jiang --- tests/TestSuite_hotplug_mp.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/TestSuite_hotplug_mp.py b/tests/TestSuite_hotplug_mp.py index 11f58d3c..ce7de869 100644 --- a/tests/TestSuite_hotplug_mp.py +++ b/tests/TestSuite_hotplug_mp.py @@ -54,7 +54,7 @@ class TestHotplugMp(TestCase): self.intf0 = self.dut.ports_info[0]['intf'] self.pci0 = self.dut.ports_info[0]['pci'] out = self.dut.build_dpdk_apps("./examples/multi_process/hotplug_mp") - self.app_path=self.dut.apps_name['hotplug_mp'] + self.app_path = self.dut.apps_name['hotplug_mp'] self.verify('Error' not in out, "Compilation failed") # Start one new session to run primary process self.session_pri = self.dut.new_session() @@ -221,9 +221,7 @@ class TestHotplugMp(TestCase): """ if not iface: self.dut.send_expect("ifconfig %s up" % self.intf0, "#") - time.sleep(5) - out = self.dut.send_expect("ethtool %s" % self.intf0, "#") - self.verify("Link detected: yes" in out, "Wrong link status") + self.verify(self.dut.is_interface_up(intf=self.intf0), "Wrong link status") self.multi_process_setup() for i in range(test_loop): @@ -359,7 +357,7 @@ class TestHotplugMp(TestCase): """ vdev = "net_virtio_user0" self.path = "/home/vhost-net" - pmd_path=self.dut.apps_name['test-pmd'] + pmd_path = self.dut.apps_name['test-pmd'] self.session_vhost.send_expect("rm -rf %s" % self.path, "#") eal_param = self.dut.create_eal_parameters(no_pci=True, prefix='vhost',vdevs=["eth_vhost0,iface=%s" % self.path]) param = ' -- -i'