diff mbox series

[V1,1/2] tests/flow_classify*: wait for interface up

Message ID 20220224152851.1511890-2-yux.jiang@intel.com (mailing list archive)
State Accepted
Headers
Series optimize script: wait for interface up |

Commit Message

Yu Jiang Feb. 24, 2022, 3:28 p.m. UTC 
  optimize script: flow_classify/flow_classify_softnic,
1, use new method: is_interface_up to to ensure iface's link status before send_packets
2, wait_link_status_up for all ports after start testpmd

Signed-off-by: Yu Jiang <yux.jiang@intel.com>
---
 tests/TestSuite_flow_classify.py         | 1 +
 tests/TestSuite_flow_classify_softnic.py | 9 ++++++---
 2 files changed, 7 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/tests/TestSuite_flow_classify.py b/tests/TestSuite_flow_classify.py
index 200d39e0..5b28b884 100644
--- a/tests/TestSuite_flow_classify.py
+++ b/tests/TestSuite_flow_classify.py
@@ -253,6 +253,7 @@  class TestFlowClassify(TestCase):
         tx_iface = config.get('tx_intf')
         cmd = "ifconfig {0} up".format(tx_iface)
         self.tester.send_expect(cmd, '# ', 30)
+        self.verify(self.tester.is_interface_up(intf=tx_iface), "Wrong link status, should be up")
         pkts = config.get('stream')
         # stream config
         stream_configs = config.get('stream configs')
diff --git a/tests/TestSuite_flow_classify_softnic.py b/tests/TestSuite_flow_classify_softnic.py
index 7b6642d0..c5004f16 100644
--- a/tests/TestSuite_flow_classify_softnic.py
+++ b/tests/TestSuite_flow_classify_softnic.py
@@ -179,12 +179,15 @@  class TestFlowClassifySoftnic(TestCase):
         Sent pkts that read from the pcap_file.
         Return the sniff pkts.
         """
-        self.pmdout.wait_link_status_up(self.dut_ports[0])
+        self.pmdout.wait_link_status_up('all')
         tx_port = self.tester.get_local_port(self.dut_ports[from_port%self.port_num])
         rx_port = self.tester.get_local_port(self.dut_ports[to_port%self.port_num])
 
         tx_interface = self.tester.get_interface(tx_port)
         rx_interface = self.tester.get_interface(rx_port)
+        # check tester's link status before send packet
+        for iface in [tx_interface, rx_interface]:
+            self.verify(self.tester.is_interface_up(intf=iface), "Wrong link status, should be up")
 
         self.tcpdump_start_sniff(rx_interface, filters)
 
@@ -284,9 +287,9 @@  class TestFlowClassifySoftnic(TestCase):
         """
         Sends continuous packets.
         """
-        self.pmdout.wait_link_status_up(self.dut_ports[0])
+        self.pmdout.wait_link_status_up('all')
+        self.verify(self.tester.is_interface_up(intf=itf), "Wrong link status, should be up")
         self.tester.scapy_foreground()
-        time.sleep(2)
         if src_dst == "src":
             if ptype == "ipv4":
                 var = src_addr.split(".")