diff mbox series

[V1,2/2] tests/short_live: wait for interface up

Message ID 20220224154221.1516892-3-yux.jiang@intel.com (mailing list archive)
State Accepted
Headers
Series optimize script: wait for interface up |

Checks

Context Check Description
ci/Intel-dts-suite-test success Testing OK

Commit Message

Yu Jiang Feb. 24, 2022, 3:42 p.m. UTC 
  optimize script short_live:
1, use new method: is_interface_up to ensure iface's link status.
2, when launch example frequently, need wait for more than 0.5s to
restart example after kill example abnormally.

Signed-off-by: Yu Jiang <yux.jiang@intel.com>
---
 tests/TestSuite_short_live.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Tu, Lijuan Feb. 27, 2022, 2:20 p.m. UTC | #1 
> -----Original Message-----
> From: Jiang, YuX <yux.jiang@intel.com>
> Sent: 2022年2月24日 23:42
> To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
> Cc: Jiang, YuX <yux.jiang@intel.com>
> Subject: [dts][PATCH V1 2/2] tests/short_live: wait for interface up
> 
> optimize script short_live:
> 1, use new method: is_interface_up to ensure iface's link status.
> 2, when launch example frequently, need wait for more than 0.5s to restart
> example after kill example abnormally.
> 
> Signed-off-by: Yu Jiang <yux.jiang@intel.com>

Series applied.
diff mbox series

Patch

diff --git a/tests/TestSuite_short_live.py b/tests/TestSuite_short_live.py
index 1b8fbb94..556728b9 100644
--- a/tests/TestSuite_short_live.py
+++ b/tests/TestSuite_short_live.py
@@ -106,7 +106,8 @@  class TestShortLiveApp(TestCase):
         # rx and tx packet are list
         if (txPort == rxPort):
             count = 2
-
+        # ensure tester's link up
+        self.verify(self.tester.is_interface_up(intf=rxitf), "Wrong link status, should be up")
         filter_list = [{'layer': 'ether', 'config': {'type': 'not IPv6'}}, {'layer': 'userdefined', 'config': {'pcap-filter': 'not udp'}}]
         inst = self.tester.tcpdump_sniff_packets(rxitf, count=count,filters=filter_list)
 
@@ -135,6 +136,8 @@  class TestShortLiveApp(TestCase):
                 time.sleep(1)
                 delay = delay + 1
             else:
+                # need wait for 1s to restart example after kill example abnormally.
+                time.sleep(1)
                 break
         self.verify(delay < delay_max, "Failed to kill the process within %s seconds" % delay_max)
 
@@ -144,7 +147,6 @@  class TestShortLiveApp(TestCase):
         """
         #dpdk start
         self.dut.send_expect("./%s %s -- -i --portmask=0x3" % (self.app_testpmd, self.eal_para()), "testpmd>", 120)
-        time.sleep(5)
         self.dut.send_expect("set fwd mac", "testpmd>")
         self.dut.send_expect("set promisc all off", "testpmd>")
         self.dut.send_expect("start", "testpmd>")