diff mbox series

[V1,5/5] tests/TestSuite_stats_checks: fix pylama errors

Message ID 20220311020022.6678-6-junx.dong@intel.com (mailing list archive)
State Accepted
Headers
Series fix pylama errors |

Checks

Context Check Description
ci/Intel-dts-suite-test fail Testing issues

Commit Message

Jun Dong March 11, 2022, 2 a.m. UTC 
  Pylama found the following errors:
tests/TestSuite_stats_checks.py:265: [E] E0102 method already defined line 65 [pylint]
tests/TestSuite_stats_checks.py:271: [E] E0102 method already defined line 71 [pylint]

Signed-off-by: Jun Dong <junx.dong@intel.com>
---
 tests/TestSuite_stats_checks.py | 22 ----------------------
 1 file changed, 22 deletions(-)

Comments

Tu, Lijuan March 11, 2022, 5:14 a.m. UTC | #1 
> -----Original Message-----
> From: Dong, JunX <junx.dong@intel.com>
> Sent: 2022年3月11日 10:00
> To: dts@dpdk.org; ohilyard@iol.unh.edu
> Cc: Tu, Lijuan <lijuan.tu@intel.com>; Sun, QingX <qingx.sun@intel.com>; Dong,
> JunX <junx.dong@intel.com>
> Subject: [dts] [V1 5/5] tests/TestSuite_stats_checks: fix pylama errors
> 
> Pylama found the following errors:
> tests/TestSuite_stats_checks.py:265: [E] E0102 method already defined line 65
> [pylint]
> tests/TestSuite_stats_checks.py:271: [E] E0102 method already defined line 71
> [pylint]
> 
> Signed-off-by: Jun Dong <junx.dong@intel.com>

Series applied.
diff mbox series

Patch

diff --git a/tests/TestSuite_stats_checks.py b/tests/TestSuite_stats_checks.py
index ab120010..e72a67ab 100644
--- a/tests/TestSuite_stats_checks.py
+++ b/tests/TestSuite_stats_checks.py
@@ -48,7 +48,6 @@  from framework.test_case import TestCase
 
 ETHER_HEADER_LEN = 18
 IP_HEADER_LEN = 20
-ETHER_STANDARD_MTU = 1518
 RANDOM_IP_POOL = ['192.168.10.222/0']
 prefix_list = ['rx_good_packets', 'tx_good_packets', 'rx_good_bytes', 'tx_good_bytes']
 
@@ -62,21 +61,6 @@  class TestStatsChecks(TestCase):
     # of TestCase. This was done because the current test system doesn't support
     # inheritance.
     #
-    def tear_down(self):
-        """
-        Run after each test case.
-        """
-        self.dut.kill_all()
-
-    def tear_down_all(self):
-        """
-        When the case of this test suite finished, the environment should
-        clear up.
-        """
-        self.tester.send_expect(f"ifconfig {self.tester.get_interface(self.tester.get_local_port(self.rx_port))} " +
-                                f"mtu {ETHER_STANDARD_MTU}", "# ")
-        super().tear_down_all()
-
     def exec(self, command: str) -> str:
         """
         An abstraction to remove repeated code throughout the subclasses of this class
@@ -275,12 +259,6 @@  class TestStatsChecks(TestCase):
         """
         self.dut.kill_all()
 
-    #
-    #
-    #
-    # Test cases.
-    #
-
     def test_stats_checks(self):
         self.pmdout.start_testpmd("Default")
         self.exec("port start all")