diff mbox series

[V2] tests/pmdpcap: Remove makefile build that changed source code

Message ID 20220317015817.1703-1-junx.dong@intel.com (mailing list archive)
State Accepted
Headers
Series [V2] tests/pmdpcap: Remove makefile build that changed source code |

Checks

Context Check Description
ci/Intel-dts-suite-test success Testing OK

Commit Message

Jun Dong March 17, 2022, 1:58 a.m. UTC 
  V2:
- Remove snippet of changing source code in tear_down_all

V1:
- Remove snippet of changing source code in set_up_all

Signed-off-by: Jun Dong <junx.dong@intel.com>
---
 tests/TestSuite_pmdpcap.py | 33 ---------------------------------
 1 file changed, 33 deletions(-)

Comments

Tu, Lijuan March 23, 2022, 7:11 a.m. UTC | #1 
> -----Original Message-----
> From: Dong, JunX <junx.dong@intel.com>
> Sent: 2022年3月17日 9:58
> To: dts@dpdk.org
> Cc: Tu, Lijuan <lijuan.tu@intel.com>; Sun, QingX <qingx.sun@intel.com>; Dong,
> JunX <junx.dong@intel.com>
> Subject: [dts] [V2] tests/pmdpcap: Remove makefile build that changed source
> code
> 
> V2:
> - Remove snippet of changing source code in tear_down_all
> 
> V1:
> - Remove snippet of changing source code in set_up_all
> 
> Signed-off-by: Jun Dong <junx.dong@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/tests/TestSuite_pmdpcap.py b/tests/TestSuite_pmdpcap.py
index 9ffe1d76..a638df2a 100644
--- a/tests/TestSuite_pmdpcap.py
+++ b/tests/TestSuite_pmdpcap.py
@@ -54,15 +54,6 @@  class TestPmdPcap(TestCase):
 
         self.memory_channel = self.dut.get_memory_channels()
 
-        # Enable PCAP features and rebuild the package
-        self.pcap_config = self.get_pcap_compile_config()
-        self.dut.send_expect(
-            "sed -i 's/CONFIG_RTE_LIBRTE_PMD_PCAP=n$/CONFIG_RTE_LIBRTE_PMD_PCAP=y/' config/%s"
-            % self.pcap_config,
-            "# ",
-        )
-        self.dut.build_install_dpdk(self.target)
-
         # make sure there is no interface to bind
         # because if there is any interface bonded to igb_uio,
         # it will result in packet transmitting failed
@@ -72,24 +63,6 @@  class TestPmdPcap(TestCase):
             self.dut.send_expect("kldload contigmem", "#", 20)
         self.path = self.dut.apps_name["test-pmd"]
 
-    def get_pcap_compile_config(self):
-        config_head = "common_"
-        os_type = self.dut.get_os_type()
-        if os_type == "linux":
-            config_tail = os_type + "app"
-        elif os_type == "freebsd":
-            config_tail = "bsdapp"
-        else:
-            raise Exception(
-                "Unknow os type, please check to make sure pcap can work in OS [ %s ]"
-                % os_type
-            )
-        out = self.dut.send_command("cat config/%s" % (config_head + config_tail))
-        if "CONFIG_RTE_LIBRTE_PMD_PCAP" in out:
-            return config_head + config_tail
-        else:
-            return config_head + "base"
-
     def create_pcap_file(self, filename, number_of_packets):
         flow = []
         for pkt_id in range(number_of_packets):
@@ -220,10 +193,4 @@  class TestPmdPcap(TestCase):
         )
 
     def tear_down_all(self):
-        # Disable PCAP feature and rebuild the package
-        self.dut.send_expect(
-            "sed -i 's/CONFIG_RTE_LIBRTE_PMD_PCAP=y$/CONFIG_RTE_LIBRTE_PMD_PCAP=n/' config/%s"
-            % self.pcap_config,
-            "# ",
-        )
         self.dut.set_target(self.target)