[v1,1/2] stats_reporter: properly use iterable in for cycle

Message ID 20220427074152.4144881-1-juraj.linkes@pantheon.tech (mailing list archive)
State Accepted
Headers
Series [v1,1/2] stats_reporter: properly use iterable in for cycle |

Commit Message

Juraj Linkeš April 27, 2022, 7:41 a.m. UTC
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
 framework/stats_reporter.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Jun Dong April 28, 2022, 3:15 a.m. UTC | #1
Acked-by: Jun Dong <junx.dong@intel.com>

> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: Wednesday, April 27, 2022 3:42 PM
> To: Dong, JunX <junx.dong@intel.com>; Tu, Lijuan <lijuan.tu@intel.com>;
> ohilyard@iol.unh.edu
> Cc: dts@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> Subject: [PATCH v1 1/2] stats_reporter: properly use iterable in for cycle
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
>  framework/stats_reporter.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/framework/stats_reporter.py b/framework/stats_reporter.py
> index 80ac942c..1c1ab3fd 100644
> --- a/framework/stats_reporter.py
> +++ b/framework/stats_reporter.py
> @@ -70,7 +70,7 @@ class StatsReporter(object):
>                  "dpdk_version =
> {}\n".format(self.result.current_dpdk_version(duts[0]))
>              )
>          else:
> -            for dut in duts():
> +            for dut in duts:
>                  dpdk_version = self.result.current_dpdk_version(dut)
>                  self.stats_file.write(
>                      "{}.dpdk_version = {}\n".format(dut, dpdk_version)
> --
> 2.20.1
  

Patch

diff --git a/framework/stats_reporter.py b/framework/stats_reporter.py
index 80ac942c..1c1ab3fd 100644
--- a/framework/stats_reporter.py
+++ b/framework/stats_reporter.py
@@ -70,7 +70,7 @@  class StatsReporter(object):
                 "dpdk_version = {}\n".format(self.result.current_dpdk_version(duts[0]))
             )
         else:
-            for dut in duts():
+            for dut in duts:
                 dpdk_version = self.result.current_dpdk_version(dut)
                 self.stats_file.write(
                     "{}.dpdk_version = {}\n".format(dut, dpdk_version)