diff mbox series

[V1] tests/multiprocess: modify dut build dpdk app all

Message ID 20220428115853.4615-1-linglix.chen@intel.com (mailing list archive)
State Changes Requested
Headers show
Series [V1] tests/multiprocess: modify dut build dpdk app all | expand

Checks

Context Check Description
ci/Intel-dts-suite-test success Testing OK
ci/Intel-dts-format-test fail Testing issues
ci/Intel-dts-pylama-test fail Testing issues

Commit Message

Lingli Chen April 28, 2022, 11:58 a.m. UTC
on Fedora35 and RHEL dut build dpdk app symmetric_mp will replace simple_mp, so not found simple_mp.
Solution: dut build dpdk app all.

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
 tests/TestSuite_multiprocess.py | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

Comments

Huang, ChenyuX April 29, 2022, 2:28 a.m. UTC | #1
> -----Original Message-----
> From: Lingli Chen <linglix.chen@intel.com>
> Sent: Thursday, April 28, 2022 7:59 PM
> To: dts@dpdk.org
> Cc: Chen, LingliX <linglix.chen@intel.com>
> Subject: [dts][PATCH V1] tests/multiprocess: modify dut build dpdk app all

Tested-by: Chenyu Huang <chenyux.huang@intel.com>
Tu, Lijuan May 5, 2022, 6:36 a.m. UTC | #2
> -----Original Message-----
> From: Lingli Chen <linglix.chen@intel.com>
> Sent: 2022年4月28日 19:59
> To: dts@dpdk.org
> Cc: Chen, LingliX <linglix.chen@intel.com>
> Subject: [dts][PATCH V1] tests/multiprocess: modify dut build dpdk app all
> 
> on Fedora35 and RHEL dut build dpdk app symmetric_mp will replace simple_mp, so not found simple_mp.
> Solution: dut build dpdk app all.

What's the consideration of building all examples, why not replacing  simple_mp with symmetric_mp?

If you are going to build examples/multi_process together, suggest to configure:

-Dexamples='multi_process/client_server_mp/mp_server,multi_process/client_server_mp/mp_client,multi_process/hotplug_mp,multi_process/simple_mp,multi_process/symmetric_mp'

thanks

> 
> Signed-off-by: Lingli Chen <linglix.chen@intel.com>
> ---
>  tests/TestSuite_multiprocess.py | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
> 
> diff --git a/tests/TestSuite_multiprocess.py b/tests/TestSuite_multiprocess.py index 33c13022..1e3ffee9
> 100644
> --- a/tests/TestSuite_multiprocess.py
> +++ b/tests/TestSuite_multiprocess.py
> @@ -61,19 +61,7 @@ class TestMultiprocess(TestCase):
>          self.dut_ports = self.dut.get_ports()
>          self.socket = self.dut.get_numa_id(self.dut_ports[0])
> 
> -        out = self.dut.build_dpdk_apps(
> -            "./examples/multi_process/client_server_mp/mp_client"
> -        )
> -        self.verify("Error" not in out, "Compilation mp_client failed")
> -        out = self.dut.build_dpdk_apps(
> -            "./examples/multi_process/client_server_mp/mp_server"
> -        )
> -        self.verify("Error" not in out, "Compilation mp_server failed")
> -        out = self.dut.build_dpdk_apps("./examples/multi_process/simple_mp")
> -        self.verify("Error" not in out, "Compilation simple_mp failed")
> -        out = self.dut.build_dpdk_apps("./examples/multi_process/symmetric_mp")
> -        self.verify("Error" not in out, "Compilation symmetric_mp failed")
> -
> +        self.dut.build_install_dpdk(target=self.target,
> + extra_options="-Dexamples=all")
>          self.app_mp_client = self.dut.apps_name["mp_client"]
>          self.app_mp_server = self.dut.apps_name["mp_server"]
>          self.app_simple_mp = self.dut.apps_name["simple_mp"]
> --
> 2.17.1
diff mbox series

Patch

diff --git a/tests/TestSuite_multiprocess.py b/tests/TestSuite_multiprocess.py
index 33c13022..1e3ffee9 100644
--- a/tests/TestSuite_multiprocess.py
+++ b/tests/TestSuite_multiprocess.py
@@ -61,19 +61,7 @@  class TestMultiprocess(TestCase):
         self.dut_ports = self.dut.get_ports()
         self.socket = self.dut.get_numa_id(self.dut_ports[0])
 
-        out = self.dut.build_dpdk_apps(
-            "./examples/multi_process/client_server_mp/mp_client"
-        )
-        self.verify("Error" not in out, "Compilation mp_client failed")
-        out = self.dut.build_dpdk_apps(
-            "./examples/multi_process/client_server_mp/mp_server"
-        )
-        self.verify("Error" not in out, "Compilation mp_server failed")
-        out = self.dut.build_dpdk_apps("./examples/multi_process/simple_mp")
-        self.verify("Error" not in out, "Compilation simple_mp failed")
-        out = self.dut.build_dpdk_apps("./examples/multi_process/symmetric_mp")
-        self.verify("Error" not in out, "Compilation symmetric_mp failed")
-
+        self.dut.build_install_dpdk(target=self.target, extra_options="-Dexamples=all")
         self.app_mp_client = self.dut.apps_name["mp_client"]
         self.app_mp_server = self.dut.apps_name["mp_server"]
         self.app_simple_mp = self.dut.apps_name["simple_mp"]