diff mbox series

[V1] tests/eeprom_dump: fix script

Message ID 20220507153106.19508-1-songx.jiale@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] tests/eeprom_dump: fix script |

Checks

Context Check Description
ci/Intel-dts-suite-test warning SKIPPED

Commit Message

Jiale, SongX May 7, 2022, 3:31 p.m. UTC 
  fix 2 issues:
    1. with '#' in the echo, it will interfere with the test results
    2. after the case test, the port should be tied back to the dpdk driver

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_eeprom_dump.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Huang, ZhiminX May 7, 2022, 11:09 a.m. UTC | #1 
> -----Original Message-----
> From: Jiale Song <songx.jiale@intel.com>
> Sent: Saturday, May 7, 2022 11:31 PM
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V1] tests/eeprom_dump: fix script
> 
> fix 2 issues:
>     1. with '#' in the echo, it will interfere with the test results
>     2. after the case test, the port should be tied back to the dpdk driver
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>
> ---
Tested-by: Zhimin Huang <zhiminx.huang@intel.com >
Tu, Lijuan May 9, 2022, 7:45 a.m. UTC | #2 
On Sat,  7 May 2022 23:31:06 +0800, Jiale Song <songx.jiale@intel.com> wrote:
> fix 2 issues:
>     1. with '#' in the echo, it will interfere with the test results
>     2. after the case test, the port should be tied back to the dpdk driver
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>


Applied, thanks
diff mbox series

Patch

diff --git a/tests/TestSuite_eeprom_dump.py b/tests/TestSuite_eeprom_dump.py
index c1a5b4ea..b220316b 100644
--- a/tests/TestSuite_eeprom_dump.py
+++ b/tests/TestSuite_eeprom_dump.py
@@ -144,7 +144,7 @@  class TestEEPROMDump(TestCase):
                 "#",
             )
             portinfo["ethout"] = self.dut.send_expect(
-                f"cat ethtool_{testname}_hex_{port}.txt", "#"
+                f"cat ethtool_{testname}_hex_{port}.txt", "# ", trim_whitespace=False
             )
 
             self.dump_to_file(
@@ -171,6 +171,7 @@  class TestEEPROMDump(TestCase):
         Run after each test case.
         """
         self.dut.kill_all()
+        self.dut.bind_interfaces_linux(self.drivername)
 
     def tear_down_all(self):
         """