diff mbox series

[V1,1/6] test_plans/dpdk_gro_lib_test_plan: delete modify dpdk code by dpdk change

Message ID 20220624053120.2831964-1-weix.ling@intel.com (mailing list archive)
State Accepted
Headers show
Series delete modify dpdk code by dpdk change | expand

Commit Message

Wei Ling June 24, 2022, 5:31 a.m. UTC
According to the dpdk commit 1945c64674(app/testpmd: perform SW IP
checksum for GRO/GSO packets) and commit 8ba1723783(net/vhost:
perform SW checksum in Tx path), no need to modify DPDK code to test.

Signed-off-by: Wei Ling <weix.ling@intel.com>
---
 test_plans/dpdk_gro_lib_test_plan.rst | 46 ---------------------------
 1 file changed, 46 deletions(-)

Comments

Tu, Lijuan June 29, 2022, 1:53 a.m. UTC | #1
> -Test flow
> -=========
> -
> -NIC2(In kernel) -> NIC1(DPDK) -> testpmd(csum fwd) -> Vhost -> Virtio-net
> -

It seems you did a little more? I wonder the reason of removing this .
Wei Ling June 29, 2022, 6:27 a.m. UTC | #2
> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: Wednesday, June 29, 2022 9:54 AM
> To: Ling, WeiX <weix.ling@intel.com>; dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: RE: [dts][PATCH V1 1/6] test_plans/dpdk_gro_lib_test_plan: delete
> modify dpdk code by dpdk change
> 
> > -Test flow
> > -=========
> > -
> > -NIC2(In kernel) -> NIC1(DPDK) -> testpmd(csum fwd) -> Vhost -> Virtio-
> net
> > -
> 
> It seems you did a little more? I wonder the reason of removing this .

Lijuan, the Test flow has already exist in the front of the Test Case1, so remove it from this place.
diff mbox series

Patch

diff --git a/test_plans/dpdk_gro_lib_test_plan.rst b/test_plans/dpdk_gro_lib_test_plan.rst
index e8c2472f..e36550d2 100644
--- a/test_plans/dpdk_gro_lib_test_plan.rst
+++ b/test_plans/dpdk_gro_lib_test_plan.rst
@@ -41,47 +41,6 @@  also cover lightmode and heavymode test.
 Prerequisites
 =============
 
-Modify the testpmd code as following::
-
-    --- a/app/test-pmd/csumonly.c
-    +++ b/app/test-pmd/csumonly.c
-    @@ -693,10 +693,12 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)
-                     * and inner headers */
-     
-                    eth_hdr = rte_pktmbuf_mtod(m, struct ether_hdr *);
-    +#if 0
-                    ether_addr_copy(&peer_eth_addrs[fs->peer_addr],
-                                    &eth_hdr->d_addr);
-                    ether_addr_copy(&ports[fs->tx_port].eth_addr,
-                                    &eth_hdr->s_addr);
-    +#endif
-                    parse_ethernet(eth_hdr, &info);
-                    l3_hdr = (char *)eth_hdr + info.l2_len;
-
-Modify the dpdk code as following::
-
-   diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
-   index b38a4b6b1..573250dbe 100644
-   --- a/drivers/net/vhost/rte_eth_vhost.c
-   +++ b/drivers/net/vhost/rte_eth_vhost.c
-   @@ -1071,8 +1071,14 @@ eth_dev_info(struct rte_eth_dev *dev,
-     dev_info->min_rx_bufsize = 0;
-
-     dev_info->tx_offload_capa = DEV_TX_OFFLOAD_MULTI_SEGS |
-   -       DEV_TX_OFFLOAD_VLAN_INSERT;
-   - dev_info->rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP;
-   +       DEV_TX_OFFLOAD_VLAN_INSERT |
-   +       DEV_TX_OFFLOAD_UDP_CKSUM |
-   +       DEV_TX_OFFLOAD_TCP_CKSUM |
-   +       DEV_TX_OFFLOAD_IPV4_CKSUM |
-   +       DEV_TX_OFFLOAD_TCP_TSO;
-   + dev_info->rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP |
-   +       DEV_RX_OFFLOAD_TCP_CKSUM |
-   +       DEV_RX_OFFLOAD_UDP_CKSUM |
-   +       DEV_RX_OFFLOAD_IPV4_CKSUM |
-   +       DEV_RX_OFFLOAD_TCP_LRO;
-    }
-
 Test flow
 =========
 
@@ -321,11 +280,6 @@  Vxlan topology
 Test Case5: DPDK GRO test with 2 queues using tcp/ipv4 traffic
 ==============================================================
 
-Test flow
-=========
-
-NIC2(In kernel) -> NIC1(DPDK) -> testpmd(csum fwd) -> Vhost -> Virtio-net
-
 1. Connect two nic port directly, put nic2 into another namesapce and turn on the tso of this nic port by below cmds::
 
     ip netns del ns1