diff mbox series

[V2,1/2] tests/dual_vlan: optimize script case vlan_tpid_config add check tpid

Message ID 20220908055348.32751-1-weiyuanx.li@intel.com (mailing list archive)
State Accepted
Headers show
Series [V2,1/2] tests/dual_vlan: optimize script case vlan_tpid_config add check tpid | expand

Commit Message

Weiyuan Li Sept. 8, 2022, 5:53 a.m. UTC
Optimize script case vlan_tpid_config add check tpid.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---

v2:
-Patch conflict modification

 tests/TestSuite_dual_vlan.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Fu, Qi Sept. 20, 2022, 7:42 a.m. UTC | #1
> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Thursday, September 8, 2022 1:54 PM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V2 1/2] tests/dual_vlan: optimize script case
> vlan_tpid_config add check tpid
> 
> Optimize script case vlan_tpid_config add check tpid.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---
> 
> v2:
> -Patch conflict modification
> 
>  tests/TestSuite_dual_vlan.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
Acked-by: Fu, Qi <qi.fu@intel.com>
diff mbox series

Patch

diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
index 15d6f2b2..87c5325b 100644
--- a/tests/TestSuite_dual_vlan.py
+++ b/tests/TestSuite_dual_vlan.py
@@ -502,7 +502,7 @@  class TestDualVlan(TestCase):
 
     def test_vlan_tpid_config(self):
         """
-        Configure receive port out vlan TPID
+        Configure receive port inner VLAN TPID
         """
         self.verify(
             self.nic
@@ -524,6 +524,7 @@  class TestDualVlan(TestCase):
         self.vlan_send_packet(outvlan, invlan)
 
         out = self.get_tcpdump_package()
+        self.verify("0x8100" in out, "tpid is error: " + out)
         self.verify("vlan %s" % outvlan in out, "vlan tpid disable error: " + out)
         self.verify("vlan %s" % invlan in out, "vlan tpid disable error: " + out)
 
@@ -531,6 +532,7 @@  class TestDualVlan(TestCase):
         self.vlan_send_packet(outvlan, invlan)
 
         out = self.get_tcpdump_package()
+        self.verify("0x8100" in out, "tpid is error: " + out)
         self.verify(
             out is not None and "vlan" not in out, "vlane tpid enable error: " + out
         )