From patchwork Tue Sep 20 17:04:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jiale, SongX" X-Patchwork-Id: 116476 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 375E2A00C5; Tue, 20 Sep 2022 10:51:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20E3A41156; Tue, 20 Sep 2022 10:51:15 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 51C894069B for ; Tue, 20 Sep 2022 10:51:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663663873; x=1695199873; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=xGARs60zKNvPa8NFbuwQP9MOai4c6iOEIAy7Y9gVZJw=; b=AnJY+ofdu3gRr8OKs1+zSbK4E54m+qo1LXkdQsY1i9CtBdlWI8vjgX83 R8hO+bHk9cYt+cUUojLi66M2DjN8BK3KtwPZ7cMukmSWPmb6/6DYaDZFV szCpTsAQpfPMS/ThfedFXw3PQyN0pTIxHPre3X1m3CyDZyYC6J1Di92rz 3QRHoALyXPUH97ZRXXEJOeKwPkgHBp2IlxeWSFZrdBOZeWfPB6b2cqnHM GmeabXH5hXuAr7l30c5XZlXq0HU2aAopgE/jq0leyyXDQ3iipPt7dHv5M CllI3EUgk/Edj4YyaiZi2Y5sJLiwdRDloQOnuwtYWUdYLFIdpvx9H/me6 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10475"; a="286687669" X-IronPort-AV: E=Sophos;i="5.93,330,1654585200"; d="scan'208";a="286687669" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2022 01:51:12 -0700 X-IronPort-AV: E=Sophos;i="5.93,330,1654585200"; d="scan'208";a="618834780" Received: from unknown (HELO cvl_tetser_105.icx.intel.com) ([10.239.252.94]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2022 01:51:11 -0700 From: Song Jiale To: dts@dpdk.org Cc: Song Jiale Subject: [dts] [PATCH V2 2/2] tests/ice_dcf_switch_filter_pppoe: optimization script Date: Tue, 20 Sep 2022 17:04:02 +0000 Message-Id: <20220920170402.14146-2-songx.jiale@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220920170402.14146-1-songx.jiale@intel.com> References: <20220920170402.14146-1-songx.jiale@intel.com> X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org 1.add timeout 2.the "testpmd_status" is the wrong status when launch app timeout, it will affect other cases test.therefore, add "kill_all" to ensure that all dpdk processes are closed. Signed-off-by: Song Jiale Acked-by: Lijuan Tu --- tests/TestSuite_ice_dcf_switch_filter_pppoe.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) v2: -redesign optimization scheme. diff --git a/tests/TestSuite_ice_dcf_switch_filter_pppoe.py b/tests/TestSuite_ice_dcf_switch_filter_pppoe.py index 7b974e01..9cd6cf9b 100644 --- a/tests/TestSuite_ice_dcf_switch_filter_pppoe.py +++ b/tests/TestSuite_ice_dcf_switch_filter_pppoe.py @@ -867,8 +867,7 @@ class ICEDCFSwitchFilterPPPOETest(TestCase): time.sleep(5) def reload_ice(self): - self.dut.send_expect("rmmod ice", "# ", 15) - self.dut.send_expect("modprobe ice", "# ", 15) + self.dut.send_expect("rmmod ice && modprobe ice", "# ", 60) def set_up(self): """ @@ -896,7 +895,7 @@ class ICEDCFSwitchFilterPPPOETest(TestCase): launch testpmd with the command """ command = self.create_testpmd_command() - out = self.dut.send_expect(command, "testpmd> ", 15) + out = self.dut.send_expect(command, "testpmd> ", 30) self.testpmd_status = "running" self.dut.send_expect("set portlist 1", "testpmd> ", 15) self.dut.send_expect("set fwd rxonly", "testpmd> ", 15) @@ -1266,14 +1265,14 @@ class ICEDCFSwitchFilterPPPOETest(TestCase): self.dut.send_expect("flow flush 0", "testpmd> ", 15) self.dut.send_expect("clear port stats all", "testpmd> ", 15) self.dut.send_expect("quit", "#", 15) - # kill all DPDK application - self.dut.kill_all() # destroy vfs for port_id in self.dut_ports: self.dut.destroy_sriov_vfs_by_port(port_id) - self.testpmd_status = "close" + self.testpmd_status = "close" if getattr(self, "session_secondary", None): self.dut.close_session(self.session_secondary) + # kill all DPDK application + self.dut.kill_all() def tear_down_all(self): """