| Message ID | 20221017051651.21306-1-weiyuanx.li@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [V1] tests/port_control: Optimize script check the port status after restarting the port | expand |
| Context | Check | Description |
|---|---|---|
| ci/Intel-dts-format-test | success | Testing OK |
| ci/Intel-dts-pylama-test | success | Testing OK |
| ci/Intel-dts-suite-test | success | Testing OK |
> -----Original Message----- > From: Weiyuan Li <weiyuanx.li@intel.com> > Sent: Monday, October 17, 2022 1:17 PM > To: dts@dpdk.org > Cc: Li, WeiyuanX <weiyuanx.li@intel.com> > Subject: [dts][PATCH V1] tests/port_control: Optimize script check the port > status after restarting the port > > The port status should be checked when the port is stopped and restarted, > not after the pmd is started. > > Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com> > --- Tested-by: Song Jiale <songx.jiale@intel.com >
> -----Original Message----- > From: Weiyuan Li <weiyuanx.li@intel.com> > Sent: Monday, October 17, 2022 1:17 PM > To: dts@dpdk.org > Cc: Li, WeiyuanX <weiyuanx.li@intel.com> > Subject: [dts][PATCH V1] tests/port_control: Optimize script check the port > status after restarting the port > > The port status should be checked when the port is stopped and restarted, not > after the pmd is started. > > Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com> > --- Acked-by: Zhimin Huang <zhiminx.huang@intel.com >
On Mon, 17 Oct 2022 13:16:51 +0800, Weiyuan Li <weiyuanx.li@intel.com> wrote: > The port status should be checked when the port is stopped and > restarted, not after the pmd is started. > > Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com> Applied, thanks
diff --git a/tests/TestSuite_port_control.py b/tests/TestSuite_port_control.py index bdb1b0ad..71b2ed87 100644 --- a/tests/TestSuite_port_control.py +++ b/tests/TestSuite_port_control.py @@ -124,9 +124,9 @@ class TestPortControl(TestCase): def start_pmd_port(self, terminal): terminal.execute_cmd("port start all") + terminal.wait_link_status_up("all") terminal.execute_cmd("start") time.sleep(5) - terminal.wait_link_status_up("all", timeout=5) ret = terminal.get_port_link_status(self.port_id_0) self.verify(ret == "up", "port not up!")
The port status should be checked when the port is stopped and restarted, not after the pmd is started. Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com> --- tests/TestSuite_port_control.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)