[V1,2/2] tests/ice_limit_value_test: optimize scripts
Checks
Commit Message
1. when the dpdk testpmd exits abnormally, the port will not be initialized, and sometimes
the other test cases will be affected. therefore, after the test, should use quit to
close the dpdk testpmd normally to avoid the impact between cases.
2. the object named "self.session_third" is undefined, delete useless code.
Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
tests/TestSuite_ice_limit_value_test.py | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
Comments
On Wed, 21 Dec 2022 17:18:40 +0000, Song Jiale <songx.jiale@intel.com> wrote:
> 1. when the dpdk testpmd exits abnormally, the port will not be initialized, and sometimes
> the other test cases will be affected. therefore, after the test, should use quit to
> close the dpdk testpmd normally to avoid the impact between cases.
> 2. the object named "self.session_third" is undefined, delete useless code.
>
> Signed-off-by: Song Jiale <songx.jiale@intel.com>
Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Series applied, thanks
@@ -1256,13 +1256,10 @@ class TestICELimitValue(TestCase):
def tear_down(self):
# destroy all flow rule on port 0
- self.dut.kill_all()
- self.destroy_env()
if getattr(self, "session_secondary", None):
self.dut.close_session(self.session_secondary)
- if getattr(self, "session_third", None):
- self.dut.close_session(self.session_third)
+ self.destroy_env()
+ self.dut.kill_all()
def tear_down_all(self):
self.dut.kill_all()
- self.destroy_env()