[V1] tests/dpdk_gro_lib: optimize bonding NIC ports step

Message ID 20230104015353.15919-1-dukaix.yuan@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] tests/dpdk_gro_lib: optimize bonding NIC ports step |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-suite-test warning SKIPPED

Commit Message

Yuan, DukaiX Jan. 4, 2023, 1:53 a.m. UTC
  1.Optimize bonding NIC ports step.
2.Remove invalid script code.

Signed-off-by: Dukai Yuan <dukaix.yuan@intel.com>
---
 tests/TestSuite_dpdk_gro_lib.py | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)
  

Comments

Tu, Lijuan Jan. 5, 2023, 2:29 p.m. UTC | #1
On Wed,  4 Jan 2023 09:53:53 +0800, Dukai Yuan <dukaix.yuan@intel.com> wrote:
> 1.Optimize bonding NIC ports step.
> 2.Remove invalid script code.
> 
> Signed-off-by: Dukai Yuan <dukaix.yuan@intel.com>


Applied, thanks
  

Patch

diff --git a/tests/TestSuite_dpdk_gro_lib.py b/tests/TestSuite_dpdk_gro_lib.py
index 1d3f809b..eaaf757e 100644
--- a/tests/TestSuite_dpdk_gro_lib.py
+++ b/tests/TestSuite_dpdk_gro_lib.py
@@ -20,18 +20,6 @@  from framework.virt_common import VM
 
 class TestDPDKGROLib(TestCase):
     def set_up_all(self):
-        # This suite will not use the port config in ports.cfg
-        # it will use the port config in vhost_peer_conf.cfg
-        # And it need two interface reconnet in DUT
-
-        # unbind the port which config in ports.cfg
-        self.dut_ports = self.dut.get_ports()
-        self.def_driver = self.dut.ports_info[self.dut_ports[0]][
-            "port"
-        ].get_nic_driver()
-        for i in self.dut_ports:
-            port = self.dut.ports_info[i]["port"]
-            port.bind_driver()
         # get and bind the port in config file
         self.pci = peer.get_pci_info()
         self.pci_drv = peer.get_pci_driver_info()
@@ -46,7 +34,7 @@  class TestDPDKGROLib(TestCase):
         )
         bind_script_path = self.dut.get_dpdk_bind_script()
         self.dut.send_expect(
-            "%s --bind=%s %s" % (bind_script_path, self.def_driver, self.pci), "# "
+            "%s --bind=%s %s" % (bind_script_path, self.drivername, self.pci), "# "
         )
         self.path = self.dut.apps_name["test-pmd"]
         self.testpmd_name = self.path.split("/")[-1]
@@ -76,7 +64,6 @@  class TestDPDKGROLib(TestCase):
         else:
             self.socket_mem = "1024,1024"
         self.base_dir = self.dut.base_dir.replace("~", "/root")
-        self.ports_socket = self.dut.get_numa_id(self.dut_ports[0])
 
     def set_up(self):
         #
@@ -425,9 +412,6 @@  class TestDPDKGROLib(TestCase):
         """
         Run after each test suite.
         """
-        for i in self.dut_ports:
-            port = self.dut.ports_info[i]["port"]
-            port.bind_driver(self.def_driver)
         self.dut.send_expect("ip netns del ns1", "# ", 30)
         self.dut.send_expect("./usertools/dpdk-devbind.py -u %s" % (self.pci), "# ", 30)
         self.dut.send_expect(