diff mbox series

[V1] vf_vlan/vf_vlan_rx:modify code to adapt avx2 and avx512 on vlan offload

Message ID 20230113130533.982024-1-zhiminx.huang@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] vf_vlan/vf_vlan_rx:modify code to adapt avx2 and avx512 on vlan offload |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-doc-test success Testing OK
ci/Intel-dts-suite-test success Testing OK

Commit Message

Huang, ZhiminX Jan. 13, 2023, 1:05 p.m. UTC 
  base on dts commit 92e12676d29341695d86ef8ee8e36d4014d56e98,missing
vf_vlan_rx test case modification.

add parameter "--enable-hw-vlan" in testpmd.
the dpdk commit 5cbfb386aa3f4c49b3cd9579e4e928cc5ab08d35 fixed avx2 not support this parameter.
the avx2 behavior is not appropriate,it has gap between avx2 and avx512,
this feature will be implemetned in the future.
so we add parameter "enable-hw-vlan" in testpmd,there is no gap in avx2 and avx512 to test vlan strip.

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
 test_plans/vf_vlan_test_plan.rst | 17 +++++++++--------
 tests/TestSuite_vf_vlan.py       |  3 ++-
 2 files changed, 11 insertions(+), 9 deletions(-)

Comments

Tu, Lijuan Jan. 13, 2023, 7:58 a.m. UTC | #1 
On Fri, 13 Jan 2023 13:05:33 +0000, Zhimin Huang <zhiminx.huang@intel.com> wrote:
> base on dts commit 92e12676d29341695d86ef8ee8e36d4014d56e98,missing
> vf_vlan_rx test case modification.
> 
> add parameter "--enable-hw-vlan" in testpmd.
> the dpdk commit 5cbfb386aa3f4c49b3cd9579e4e928cc5ab08d35 fixed avx2 not support this parameter.
> the avx2 behavior is not appropriate,it has gap between avx2 and avx512,
> this feature will be implemetned in the future.
> so we add parameter "enable-hw-vlan" in testpmd,there is no gap in avx2 and avx512 to test vlan strip.
> 
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>


Applied, thanks
diff mbox series

Patch

diff --git a/test_plans/vf_vlan_test_plan.rst b/test_plans/vf_vlan_test_plan.rst
index 8612bd84..0cf946d0 100644
--- a/test_plans/vf_vlan_test_plan.rst
+++ b/test_plans/vf_vlan_test_plan.rst
@@ -68,7 +68,13 @@  Prerequisites
      testpmd> set verbose 1
      testpmd> start
 
- if test DCF, set VF port to dcf and start up::
+.. note::
+   according to dpdk commit 5cbfb386aa3f4c49b3cd9579e4e928cc5ab08d35,if not add parameter "enable-hw-vlan", the vlan
+   offload should be disable.the avx2 behavior is not appropriate, the avx2 and avx512 shouldn't have gap on vlan
+   offload.this feature will be implemetned in the future.so add parameter "--enable-hw-vlan" in testpmd to test vlan
+   strip.
+
+if test DCF, set VF port to dcf and start up::
 
    Enable kernel trust mode:
 
@@ -155,7 +161,7 @@  Test case4: VF tagged vlan rx
 
 1. Make sure port based vlan disabled on VF0 and VF1
 
-2. Start testpmd with rxonly mode::
+2. Start testpmd with rxonly mode and parameter "--enable-hw-vlan"::
 
      testpmd> set fwd rxonly
      testpmd> set verbose 1
@@ -186,12 +192,7 @@  Test case4: VF tagged vlan rx
 Test case5: VF Vlan strip test
 ==============================
 
-.. note::
-   according to dpdk commit 5cbfb386aa3f4c49b3cd9579e4e928cc5ab08d35,if not add parameter "enable-hw-vlan", the vlan
-   offload should be disable.the avx2 behavior is not appropriate, the avx2 and avx512 shouldn't have gap on vlan
-   offload. so add parameter "--enable-hw-vlan" in testpmd to test vlan strip.
-
-1. Start testpmd with mac forward mode::
+1. Start testpmd with mac forward mode and parameter "--enable-hw-vlan"::
 
      testpmd> set fwd mac
      testpmd> set verbose 1
diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py
index 14c675c7..563d06b6 100644
--- a/tests/TestSuite_vf_vlan.py
+++ b/tests/TestSuite_vf_vlan.py
@@ -344,7 +344,8 @@  class TestVfVlan(TestCase):
         self.vm0_dut_ports = self.vm_dut_0.get_ports("any")
 
         self.vm0_testpmd = PmdOutput(self.vm_dut_0)
-        self.launch_testpmd(dcf_flag=self.dcf_mode)
+        param = "--enable-hw-vlan" if not self.dcf_mode else ""
+        self.launch_testpmd(dcf_flag=self.dcf_mode, param=param)
         self.vm0_testpmd.execute_cmd("set fwd rxonly")
         self.vm0_testpmd.execute_cmd("set verbose 1")
         self.vm0_testpmd.execute_cmd("vlan set strip on 0")