add Intel cpfl to supported NICs

Message ID 20230314020759.1445151-1-mingxia.liu@intel.com (mailing list archive)
State Superseded
Headers
Series add Intel cpfl to supported NICs |

Commit Message

Liu, Mingxia March 14, 2023, 2:07 a.m. UTC
  This driver is for Intel® IPU E2100 (Device ID: 0x1453).
And this driver is added at DPDK 23.03 release.

Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>
---
 content/supported/nics/intel.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

Xing, Beilei March 14, 2023, 4:06 a.m. UTC | #1
> -----Original Message-----
> From: Liu, Mingxia <mingxia.liu@intel.com>
> Sent: Tuesday, March 14, 2023 10:08 AM
> To: thomas@monjalon.net
> Cc: web@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Liu, Mingxia
> <mingxia.liu@intel.com>
> Subject: [PATCH] add Intel cpfl to supported NICs
> 
> This driver is for Intel® IPU E2100 (Device ID: 0x1453).
> And this driver is added at DPDK 23.03 release.
> 
> Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>
> ---
>  content/supported/nics/intel.md | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/content/supported/nics/intel.md
> b/content/supported/nics/intel.md index 1564d33..e4bf0c1 100644
> --- a/content/supported/nics/intel.md
> +++ b/content/supported/nics/intel.md
> @@ -1,9 +1,10 @@
>  +++
>  title = "Intel"
> -description = "e1000, ixgbe, i40e, ice, idpf, fm10k, ipn3ke, ifc, igc"
> +description = "cpfl, e1000, ixgbe, i40e, ice, idpf, fm10k, ipn3ke, ifc, igc"

It's better to add cpfl after idpf.

>  hidden = true
>  +++
> 
> +- [cpfl](//doc.dpdk.org/guides/nics/cpfl.html) (IPU E2100)
Ditto.

>  - [e1000](//doc.dpdk.org/guides/nics/e1000em.html) (82540, 82545, 82546)
>  - [e1000e](//git.dpdk.org/dpdk/tree/drivers/net/e1000/) (82571, 82572,
> 82573, 82574, 82583, ICH8, ICH9, ICH10, PCH, PCH2, I217, I218, I219)
>  - [igb](//doc.dpdk.org/guides/nics/igb.html) (82573, 82576, 82580, I210, I211,
> I350, I354, DH89xx)
> --
> 2.25.1
  
Liu, Mingxia March 14, 2023, 5:39 a.m. UTC | #2
> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Tuesday, March 14, 2023 12:07 PM
> To: Liu, Mingxia <mingxia.liu@intel.com>; thomas@monjalon.net
> Cc: web@dpdk.org
> Subject: RE: [PATCH] add Intel cpfl to supported NICs
> 
> 
> 
> > -----Original Message-----
> > From: Liu, Mingxia <mingxia.liu@intel.com>
> > Sent: Tuesday, March 14, 2023 10:08 AM
> > To: thomas@monjalon.net
> > Cc: web@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Liu, Mingxia
> > <mingxia.liu@intel.com>
> > Subject: [PATCH] add Intel cpfl to supported NICs
> >
> > This driver is for Intel® IPU E2100 (Device ID: 0x1453).
> > And this driver is added at DPDK 23.03 release.
> >
> > Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>
> > ---
> >  content/supported/nics/intel.md | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/content/supported/nics/intel.md
> > b/content/supported/nics/intel.md index 1564d33..e4bf0c1 100644
> > --- a/content/supported/nics/intel.md
> > +++ b/content/supported/nics/intel.md
> > @@ -1,9 +1,10 @@
> >  +++
> >  title = "Intel"
> > -description = "e1000, ixgbe, i40e, ice, idpf, fm10k, ipn3ke, ifc, igc"
> > +description = "cpfl, e1000, ixgbe, i40e, ice, idpf, fm10k, ipn3ke, ifc, igc"
> 
> It's better to add cpfl after idpf.
> 
[Liu, Mingxia] ok, v2 sent.
> >  hidden = true
> >  +++
> >
> > +- [cpfl](//doc.dpdk.org/guides/nics/cpfl.html) (IPU E2100)
> Ditto.
> 
> >  - [e1000](//doc.dpdk.org/guides/nics/e1000em.html) (82540, 82545,
> > 82546)
> >  - [e1000e](//git.dpdk.org/dpdk/tree/drivers/net/e1000/) (82571,
> > 82572, 82573, 82574, 82583, ICH8, ICH9, ICH10, PCH, PCH2, I217, I218,
> > I219)
> >  - [igb](//doc.dpdk.org/guides/nics/igb.html) (82573, 82576, 82580,
> > I210, I211, I350, I354, DH89xx)
> > --
> > 2.25.1
  
Thomas Monjalon March 14, 2023, 9:47 a.m. UTC | #3
14/03/2023 03:07, Mingxia Liu:
> This driver is for Intel® IPU E2100 (Device ID: 0x1453).
> And this driver is added at DPDK 23.03 release.
> 
> Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>
> ---
>  content/supported/nics/intel.md | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/content/supported/nics/intel.md b/content/supported/nics/intel.md
> index 1564d33..e4bf0c1 100644
> --- a/content/supported/nics/intel.md
> +++ b/content/supported/nics/intel.md
> @@ -1,9 +1,10 @@
>  +++
>  title = "Intel"
> -description = "e1000, ixgbe, i40e, ice, idpf, fm10k, ipn3ke, ifc, igc"
> +description = "cpfl, e1000, ixgbe, i40e, ice, idpf, fm10k, ipn3ke, ifc, igc"

What is the sorting here? It there a logic?

>  hidden = true
>  +++
>  
> +- [cpfl](//doc.dpdk.org/guides/nics/cpfl.html) (IPU E2100)
>  - [e1000](//doc.dpdk.org/guides/nics/e1000em.html) (82540, 82545, 82546)
>  - [e1000e](//git.dpdk.org/dpdk/tree/drivers/net/e1000/) (82571, 82572, 82573, 82574, 82583, ICH8, ICH9, ICH10, PCH, PCH2, I217, I218, I219)
>  - [igb](//doc.dpdk.org/guides/nics/igb.html) (82573, 82576, 82580, I210, I211, I350, I354, DH89xx)
>
  
Stephen Hemminger March 14, 2023, 5:59 p.m. UTC | #4
On Tue, 14 Mar 2023 05:39:43 +0000
"Liu, Mingxia" <mingxia.liu@intel.com> wrote:

> > > -description = "e1000, ixgbe, i40e, ice, idpf, fm10k, ipn3ke, ifc, igc"
> > > +description = "cpfl, e1000, ixgbe, i40e, ice, idpf, fm10k, ipn3ke, ifc, igc"  
> > 
> > It's better to add cpfl after idpf.
> >   
> [Liu, Mingxia] ok, v2 sent.

Alphabetic sort would make more sense to user.
Current order seems to be based on Intel release date.
  
Liu, Mingxia March 15, 2023, 7:12 a.m. UTC | #5
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday, March 15, 2023 2:00 AM
> To: Liu, Mingxia <mingxia.liu@intel.com>
> Cc: Xing, Beilei <beilei.xing@intel.com>; thomas@monjalon.net;
> web@dpdk.org
> Subject: Re: [PATCH] add Intel cpfl to supported NICs
> 
> On Tue, 14 Mar 2023 05:39:43 +0000
> "Liu, Mingxia" <mingxia.liu@intel.com> wrote:
> 
> > > > -description = "e1000, ixgbe, i40e, ice, idpf, fm10k, ipn3ke, ifc, igc"
> > > > +description = "cpfl, e1000, ixgbe, i40e, ice, idpf, fm10k, ipn3ke, ifc,
> igc"
> > >
> > > It's better to add cpfl after idpf.
> > >
> > [Liu, Mingxia] ok, v2 sent.
> 
> Alphabetic sort would make more sense to user.
> Current order seems to be based on Intel release date.
[Liu, Mingxia] I will update them to alphabetic sort.
  

Patch

diff --git a/content/supported/nics/intel.md b/content/supported/nics/intel.md
index 1564d33..e4bf0c1 100644
--- a/content/supported/nics/intel.md
+++ b/content/supported/nics/intel.md
@@ -1,9 +1,10 @@ 
 +++
 title = "Intel"
-description = "e1000, ixgbe, i40e, ice, idpf, fm10k, ipn3ke, ifc, igc"
+description = "cpfl, e1000, ixgbe, i40e, ice, idpf, fm10k, ipn3ke, ifc, igc"
 hidden = true
 +++
 
+- [cpfl](//doc.dpdk.org/guides/nics/cpfl.html) (IPU E2100)
 - [e1000](//doc.dpdk.org/guides/nics/e1000em.html) (82540, 82545, 82546)
 - [e1000e](//git.dpdk.org/dpdk/tree/drivers/net/e1000/) (82571, 82572, 82573, 82574, 82583, ICH8, ICH9, ICH10, PCH, PCH2, I217, I218, I219)
 - [igb](//doc.dpdk.org/guides/nics/igb.html) (82573, 82576, 82580, I210, I211, I350, I354, DH89xx)