From patchwork Fri Sep 11 05:45:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joyce Kong X-Patchwork-Id: 77324 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E28BFA04B5; Fri, 11 Sep 2020 07:45:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DE4361C0CD; Fri, 11 Sep 2020 07:45:55 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id 1C8801C0CC for ; Fri, 11 Sep 2020 07:45:54 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 94D5C106F; Thu, 10 Sep 2020 22:45:53 -0700 (PDT) Received: from net-arm-thunderx2-03.shanghai.arm.com (net-arm-thunderx2-03.shanghai.arm.com [10.169.210.123]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 641743F68F; Thu, 10 Sep 2020 22:45:51 -0700 (PDT) From: Joyce Kong To: thomas@monjalon.net, honnappa.nagarahalli@arm.com, phil.yang@arm.com, ruifeng.wang@arm.com Cc: dev@dpdk.org, nd@arm.com Date: Fri, 11 Sep 2020 13:45:31 +0800 Message-Id: <20200911054534.55378-2-joyce.kong@arm.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200911054534.55378-1-joyce.kong@arm.com> References: <20200911054534.55378-1-joyce.kong@arm.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/4] eal/ticketlock: remove experimental tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" As rte_ticketlock was introduced in 19.05 release and there were no changes in its public API since 19.11 release, it should be mature enough to remove the experimental tag. Signed-off-by: Joyce Kong Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang --- lib/librte_eal/include/generic/rte_ticketlock.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/lib/librte_eal/include/generic/rte_ticketlock.h b/lib/librte_eal/include/generic/rte_ticketlock.h index c295ae7f7..c1b8808f5 100644 --- a/lib/librte_eal/include/generic/rte_ticketlock.h +++ b/lib/librte_eal/include/generic/rte_ticketlock.h @@ -48,7 +48,6 @@ typedef union { * @param tl * A pointer to the ticketlock. */ -__rte_experimental static inline void rte_ticketlock_init(rte_ticketlock_t *tl) { @@ -61,7 +60,6 @@ rte_ticketlock_init(rte_ticketlock_t *tl) * @param tl * A pointer to the ticketlock. */ -__rte_experimental static inline void rte_ticketlock_lock(rte_ticketlock_t *tl) { @@ -75,7 +73,6 @@ rte_ticketlock_lock(rte_ticketlock_t *tl) * @param tl * A pointer to the ticketlock. */ -__rte_experimental static inline void rte_ticketlock_unlock(rte_ticketlock_t *tl) { @@ -91,7 +88,6 @@ rte_ticketlock_unlock(rte_ticketlock_t *tl) * @return * 1 if the lock is successfully taken; 0 otherwise. */ -__rte_experimental static inline int rte_ticketlock_trylock(rte_ticketlock_t *tl) { @@ -116,7 +112,6 @@ rte_ticketlock_trylock(rte_ticketlock_t *tl) * @return * 1 if the lock is currently taken; 0 otherwise. */ -__rte_experimental static inline int rte_ticketlock_is_locked(rte_ticketlock_t *tl) { @@ -148,7 +143,6 @@ typedef struct { * @param tlr * A pointer to the recursive ticketlock. */ -__rte_experimental static inline void rte_ticketlock_recursive_init(rte_ticketlock_recursive_t *tlr) { @@ -163,7 +157,6 @@ rte_ticketlock_recursive_init(rte_ticketlock_recursive_t *tlr) * @param tlr * A pointer to the recursive ticketlock. */ -__rte_experimental static inline void rte_ticketlock_recursive_lock(rte_ticketlock_recursive_t *tlr) { @@ -182,7 +175,6 @@ rte_ticketlock_recursive_lock(rte_ticketlock_recursive_t *tlr) * @param tlr * A pointer to the recursive ticketlock. */ -__rte_experimental static inline void rte_ticketlock_recursive_unlock(rte_ticketlock_recursive_t *tlr) { @@ -201,7 +193,6 @@ rte_ticketlock_recursive_unlock(rte_ticketlock_recursive_t *tlr) * @return * 1 if the lock is successfully taken; 0 otherwise. */ -__rte_experimental static inline int rte_ticketlock_recursive_trylock(rte_ticketlock_recursive_t *tlr) { From patchwork Fri Sep 11 05:45:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joyce Kong X-Patchwork-Id: 77325 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77D5FA04B5; Fri, 11 Sep 2020 07:46:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 173EB1C0D4; Fri, 11 Sep 2020 07:46:01 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id B52A81C0D2 for ; Fri, 11 Sep 2020 07:45:59 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 42674106F; Thu, 10 Sep 2020 22:45:59 -0700 (PDT) Received: from net-arm-thunderx2-03.shanghai.arm.com (net-arm-thunderx2-03.shanghai.arm.com [10.169.210.123]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1101F3F68F; Thu, 10 Sep 2020 22:45:56 -0700 (PDT) From: Joyce Kong To: thomas@monjalon.net, honnappa.nagarahalli@arm.com, phil.yang@arm.com, ruifeng.wang@arm.com Cc: dev@dpdk.org, nd@arm.com Date: Fri, 11 Sep 2020 13:45:32 +0800 Message-Id: <20200911054534.55378-3-joyce.kong@arm.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200911054534.55378-1-joyce.kong@arm.com> References: <20200911054534.55378-1-joyce.kong@arm.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 2/4] eal/mcslock: remove experimental tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since rte_mcslock APIs were introduced in 19.08 release, it is now possible to remove the experimental tag from: rte_mcslock_lock() rte_mcslock_unlock() rte_mcslock_trylock() rte_mcslock_is_locked() Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by: Phil Yang --- MAINTAINERS | 2 +- lib/librte_eal/include/generic/rte_mcslock.h | 16 ---------------- 2 files changed, 1 insertion(+), 17 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3003852b5..0e43a28bf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -264,7 +264,7 @@ M: Cristian Dumitrescu F: lib/librte_eal/include/rte_bitmap.h F: app/test/test_bitmap.c -MCSlock - EXPERIMENTAL +MCSlock M: Phil Yang F: lib/librte_eal/include/generic/rte_mcslock.h F: app/test/test_mcslock.c diff --git a/lib/librte_eal/include/generic/rte_mcslock.h b/lib/librte_eal/include/generic/rte_mcslock.h index 2bef28351..78b0df295 100644 --- a/lib/librte_eal/include/generic/rte_mcslock.h +++ b/lib/librte_eal/include/generic/rte_mcslock.h @@ -32,9 +32,6 @@ typedef struct rte_mcslock { } rte_mcslock_t; /** - * @warning - * @b EXPERIMENTAL: This API may change without prior notice - * * Take the MCS lock. * * @param msl @@ -45,7 +42,6 @@ typedef struct rte_mcslock { * A pointer to a new node of MCS lock. Each CPU/thread acquiring the * lock should use its 'own node'. */ -__rte_experimental static inline void rte_mcslock_lock(rte_mcslock_t **msl, rte_mcslock_t *me) { @@ -85,9 +81,6 @@ rte_mcslock_lock(rte_mcslock_t **msl, rte_mcslock_t *me) } /** - * @warning - * @b EXPERIMENTAL: This API may change without prior notice - * * Release the MCS lock. * * @param msl @@ -95,7 +88,6 @@ rte_mcslock_lock(rte_mcslock_t **msl, rte_mcslock_t *me) * @param me * A pointer to the node of MCS lock passed in rte_mcslock_lock. */ -__rte_experimental static inline void rte_mcslock_unlock(rte_mcslock_t **msl, rte_mcslock_t *me) { @@ -126,9 +118,6 @@ rte_mcslock_unlock(rte_mcslock_t **msl, rte_mcslock_t *me) } /** - * @warning - * @b EXPERIMENTAL: This API may change without prior notice - * * Try to take the lock. * * @param msl @@ -138,7 +127,6 @@ rte_mcslock_unlock(rte_mcslock_t **msl, rte_mcslock_t *me) * @return * 1 if the lock is successfully taken; 0 otherwise. */ -__rte_experimental static inline int rte_mcslock_trylock(rte_mcslock_t **msl, rte_mcslock_t *me) { @@ -159,9 +147,6 @@ rte_mcslock_trylock(rte_mcslock_t **msl, rte_mcslock_t *me) } /** - * @warning - * @b EXPERIMENTAL: This API may change without prior notice - * * Test if the lock is taken. * * @param msl @@ -169,7 +154,6 @@ rte_mcslock_trylock(rte_mcslock_t **msl, rte_mcslock_t *me) * @return * 1 if the lock is currently taken; 0 otherwise. */ -__rte_experimental static inline int rte_mcslock_is_locked(rte_mcslock_t *msl) { From patchwork Fri Sep 11 05:45:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joyce Kong X-Patchwork-Id: 77326 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA3C7A04B5; Fri, 11 Sep 2020 07:46:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 64EFB1C0DA; Fri, 11 Sep 2020 07:46:04 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id 5BF111C0CC for ; Fri, 11 Sep 2020 07:46:03 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D46B8106F; Thu, 10 Sep 2020 22:46:02 -0700 (PDT) Received: from net-arm-thunderx2-03.shanghai.arm.com (net-arm-thunderx2-03.shanghai.arm.com [10.169.210.123]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A405E3F68F; Thu, 10 Sep 2020 22:46:00 -0700 (PDT) From: Joyce Kong To: thomas@monjalon.net, honnappa.nagarahalli@arm.com, phil.yang@arm.com, ruifeng.wang@arm.com Cc: dev@dpdk.org, nd@arm.com Date: Fri, 11 Sep 2020 13:45:33 +0800 Message-Id: <20200911054534.55378-4-joyce.kong@arm.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200911054534.55378-1-joyce.kong@arm.com> References: <20200911054534.55378-1-joyce.kong@arm.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 3/4] rcu: remove experimental tag from QSBR mechanism X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" RCU library supporting quiescent state was introduced in 19.05 release and has been around 4 releases, it should be mature enough to remove the experimental tag. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- MAINTAINERS | 2 +- lib/librte_rcu/rte_rcu_qsbr.h | 52 ------------------------------ lib/librte_rcu/rte_rcu_version.map | 11 +++++-- 3 files changed, 10 insertions(+), 55 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0e43a28bf..12f088b62 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1449,7 +1449,7 @@ M: Olivier Matz F: lib/librte_kvargs/ F: app/test/test_kvargs.c -RCU - EXPERIMENTAL +RCU M: Honnappa Nagarahalli F: lib/librte_rcu/ F: app/test/test_rcu* diff --git a/lib/librte_rcu/rte_rcu_qsbr.h b/lib/librte_rcu/rte_rcu_qsbr.h index a98e8f0f8..5905c53a5 100644 --- a/lib/librte_rcu/rte_rcu_qsbr.h +++ b/lib/librte_rcu/rte_rcu_qsbr.h @@ -202,9 +202,6 @@ struct rte_rcu_qsbr_dq_parameters { struct rte_rcu_qsbr_dq; /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Return the size of the memory occupied by a Quiescent State variable. * * @param max_threads @@ -215,14 +212,10 @@ struct rte_rcu_qsbr_dq; * Possible rte_errno codes are: * - EINVAL - max_threads is 0 */ -__rte_experimental size_t rte_rcu_qsbr_get_memsize(uint32_t max_threads); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Initialize a Quiescent State (QS) variable. * * @param v @@ -237,14 +230,10 @@ rte_rcu_qsbr_get_memsize(uint32_t max_threads); * - EINVAL - max_threads is 0 or 'v' is NULL. * */ -__rte_experimental int rte_rcu_qsbr_init(struct rte_rcu_qsbr *v, uint32_t max_threads); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Register a reader thread to report its quiescent state * on a QS variable. * @@ -264,14 +253,10 @@ rte_rcu_qsbr_init(struct rte_rcu_qsbr *v, uint32_t max_threads); * the QS variable. thread_id is a value between 0 and (max_threads - 1). * 'max_threads' is the parameter passed in 'rte_rcu_qsbr_init' API. */ -__rte_experimental int rte_rcu_qsbr_thread_register(struct rte_rcu_qsbr *v, unsigned int thread_id); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Remove a reader thread, from the list of threads reporting their * quiescent state on a QS variable. * @@ -286,14 +271,10 @@ rte_rcu_qsbr_thread_register(struct rte_rcu_qsbr *v, unsigned int thread_id); * Reader thread with this thread ID will stop reporting its quiescent * state on the QS variable. */ -__rte_experimental int rte_rcu_qsbr_thread_unregister(struct rte_rcu_qsbr *v, unsigned int thread_id); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Add a registered reader thread, to the list of threads reporting their * quiescent state on a QS variable. * @@ -318,7 +299,6 @@ rte_rcu_qsbr_thread_unregister(struct rte_rcu_qsbr *v, unsigned int thread_id); * Reader thread with this thread ID will report its quiescent state on * the QS variable. */ -__rte_experimental static __rte_always_inline void rte_rcu_qsbr_thread_online(struct rte_rcu_qsbr *v, unsigned int thread_id) { @@ -358,9 +338,6 @@ rte_rcu_qsbr_thread_online(struct rte_rcu_qsbr *v, unsigned int thread_id) } /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Remove a registered reader thread from the list of threads reporting their * quiescent state on a QS variable. * @@ -380,7 +357,6 @@ rte_rcu_qsbr_thread_online(struct rte_rcu_qsbr *v, unsigned int thread_id) * rte_rcu_qsbr_check API will not wait for the reader thread with * this thread ID to report its quiescent state on the QS variable. */ -__rte_experimental static __rte_always_inline void rte_rcu_qsbr_thread_offline(struct rte_rcu_qsbr *v, unsigned int thread_id) { @@ -399,9 +375,6 @@ rte_rcu_qsbr_thread_offline(struct rte_rcu_qsbr *v, unsigned int thread_id) } /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Acquire a lock for accessing a shared data structure. * * This is implemented as a lock-free function. It is multi-thread @@ -421,7 +394,6 @@ rte_rcu_qsbr_thread_offline(struct rte_rcu_qsbr *v, unsigned int thread_id) * @param thread_id * Reader thread id */ -__rte_experimental static __rte_always_inline void rte_rcu_qsbr_lock(__rte_unused struct rte_rcu_qsbr *v, __rte_unused unsigned int thread_id) @@ -436,9 +408,6 @@ rte_rcu_qsbr_lock(__rte_unused struct rte_rcu_qsbr *v, } /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Release a lock after accessing a shared data structure. * * This is implemented as a lock-free function. It is multi-thread @@ -458,7 +427,6 @@ rte_rcu_qsbr_lock(__rte_unused struct rte_rcu_qsbr *v, * @param thread_id * Reader thread id */ -__rte_experimental static __rte_always_inline void rte_rcu_qsbr_unlock(__rte_unused struct rte_rcu_qsbr *v, __rte_unused unsigned int thread_id) @@ -477,9 +445,6 @@ rte_rcu_qsbr_unlock(__rte_unused struct rte_rcu_qsbr *v, } /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Ask the reader threads to report the quiescent state * status. * @@ -492,7 +457,6 @@ rte_rcu_qsbr_unlock(__rte_unused struct rte_rcu_qsbr *v, * - This is the token for this call of the API. This should be * passed to rte_rcu_qsbr_check API. */ -__rte_experimental static __rte_always_inline uint64_t rte_rcu_qsbr_start(struct rte_rcu_qsbr *v) { @@ -511,9 +475,6 @@ rte_rcu_qsbr_start(struct rte_rcu_qsbr *v) } /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Update quiescent state for a reader thread. * * This is implemented as a lock-free function. It is multi-thread safe. @@ -525,7 +486,6 @@ rte_rcu_qsbr_start(struct rte_rcu_qsbr *v) * @param thread_id * Update the quiescent state for the reader with this thread ID. */ -__rte_experimental static __rte_always_inline void rte_rcu_qsbr_quiescent(struct rte_rcu_qsbr *v, unsigned int thread_id) { @@ -683,9 +643,6 @@ __rte_rcu_qsbr_check_all(struct rte_rcu_qsbr *v, uint64_t t, bool wait) } /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Checks if all the reader threads have entered the quiescent state * referenced by token. * @@ -716,7 +673,6 @@ __rte_rcu_qsbr_check_all(struct rte_rcu_qsbr *v, uint64_t t, bool wait) * - 1 if all reader threads have passed through specified number * of quiescent states. */ -__rte_experimental static __rte_always_inline int rte_rcu_qsbr_check(struct rte_rcu_qsbr *v, uint64_t t, bool wait) { @@ -740,9 +696,6 @@ rte_rcu_qsbr_check(struct rte_rcu_qsbr *v, uint64_t t, bool wait) } /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Wait till the reader threads have entered quiescent state. * * This is implemented as a lock-free function. It is multi-thread safe. @@ -760,14 +713,10 @@ rte_rcu_qsbr_check(struct rte_rcu_qsbr *v, uint64_t t, bool wait) * on this QS variable (i.e. the calling thread is also part of the * readside critical section). If not, pass RTE_QSBR_THRID_INVALID. */ -__rte_experimental void rte_rcu_qsbr_synchronize(struct rte_rcu_qsbr *v, unsigned int thread_id); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Dump the details of a single QS variables to a file. * * It is NOT multi-thread safe. @@ -782,7 +731,6 @@ rte_rcu_qsbr_synchronize(struct rte_rcu_qsbr *v, unsigned int thread_id); * Possible rte_errno codes are: * - EINVAL - NULL parameters are passed */ -__rte_experimental int rte_rcu_qsbr_dump(FILE *f, struct rte_rcu_qsbr *v); diff --git a/lib/librte_rcu/rte_rcu_version.map b/lib/librte_rcu/rte_rcu_version.map index dfac88a37..e40850350 100644 --- a/lib/librte_rcu/rte_rcu_version.map +++ b/lib/librte_rcu/rte_rcu_version.map @@ -1,5 +1,5 @@ -EXPERIMENTAL { - global: +DPDK_21 { + global: rte_rcu_log_type; rte_rcu_qsbr_dump; @@ -8,6 +8,13 @@ EXPERIMENTAL { rte_rcu_qsbr_synchronize; rte_rcu_qsbr_thread_register; rte_rcu_qsbr_thread_unregister; + + local: *; +}; + +EXPERIMENTAL { + global: + rte_rcu_qsbr_dq_create; rte_rcu_qsbr_dq_enqueue; rte_rcu_qsbr_dq_reclaim; From patchwork Fri Sep 11 05:45:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joyce Kong X-Patchwork-Id: 77327 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E08DA04B5; Fri, 11 Sep 2020 07:46:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A95D1C10F; Fri, 11 Sep 2020 07:46:09 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id 0543C1C115 for ; Fri, 11 Sep 2020 07:46:07 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 84EDC106F; Thu, 10 Sep 2020 22:46:06 -0700 (PDT) Received: from net-arm-thunderx2-03.shanghai.arm.com (net-arm-thunderx2-03.shanghai.arm.com [10.169.210.123]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 53EF63F68F; Thu, 10 Sep 2020 22:46:04 -0700 (PDT) From: Joyce Kong To: thomas@monjalon.net, honnappa.nagarahalli@arm.com, phil.yang@arm.com, ruifeng.wang@arm.com Cc: dev@dpdk.org, nd@arm.com Date: Fri, 11 Sep 2020 13:45:34 +0800 Message-Id: <20200911054534.55378-5-joyce.kong@arm.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200911054534.55378-1-joyce.kong@arm.com> References: <20200911054534.55378-1-joyce.kong@arm.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 4/4] eal/pause: remove experimental tag from wait until equal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_wait_until_equal_xx APIs were introduced in 19.11 release and there were no changes in the public APIs since then, it should be mature enough to remove the experimental tag. Signed-off-by: Joyce Kong Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang Acked-by: Stephen Hemminger --- lib/librte_eal/include/generic/rte_pause.h | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/lib/librte_eal/include/generic/rte_pause.h b/lib/librte_eal/include/generic/rte_pause.h index 7422785f1..668ee4a18 100644 --- a/lib/librte_eal/include/generic/rte_pause.h +++ b/lib/librte_eal/include/generic/rte_pause.h @@ -28,9 +28,6 @@ static inline void rte_pause(void); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Wait for *addr to be updated with a 16-bit expected value, with a relaxed * memory ordering model meaning the loads around this API can be reordered. * @@ -44,15 +41,11 @@ static inline void rte_pause(void); * C++11 memory orders with the same names, see the C++11 standard or * the GCC wiki on atomic synchronization for detailed definition. */ -__rte_experimental static __rte_always_inline void rte_wait_until_equal_16(volatile uint16_t *addr, uint16_t expected, int memorder); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Wait for *addr to be updated with a 32-bit expected value, with a relaxed * memory ordering model meaning the loads around this API can be reordered. * @@ -66,15 +59,11 @@ rte_wait_until_equal_16(volatile uint16_t *addr, uint16_t expected, * C++11 memory orders with the same names, see the C++11 standard or * the GCC wiki on atomic synchronization for detailed definition. */ -__rte_experimental static __rte_always_inline void rte_wait_until_equal_32(volatile uint32_t *addr, uint32_t expected, int memorder); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Wait for *addr to be updated with a 64-bit expected value, with a relaxed * memory ordering model meaning the loads around this API can be reordered. * @@ -88,7 +77,6 @@ rte_wait_until_equal_32(volatile uint32_t *addr, uint32_t expected, * C++11 memory orders with the same names, see the C++11 standard or * the GCC wiki on atomic synchronization for detailed definition. */ -__rte_experimental static __rte_always_inline void rte_wait_until_equal_64(volatile uint64_t *addr, uint64_t expected, int memorder);