From patchwork Tue Nov 3 15:23:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lingli Chen X-Patchwork-Id: 83490 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E7AAA0521; Tue, 3 Nov 2020 08:23:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 280F5BE87; Tue, 3 Nov 2020 08:23:36 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 0D9AEBE7D for ; Tue, 3 Nov 2020 08:23:32 +0100 (CET) IronPort-SDR: 4tBqh+cduoniPN6t1MRvDySP3AgJwhLA6X5A+xzo5vbxvqQxCRLaheZPhSl+2rH4ub/+EOahWN HauUqbCfeT+Q== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="148865994" X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="148865994" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 23:23:30 -0800 IronPort-SDR: dBHbA0kB7jTwnThUP7AZ/KExzrckC1w46Y+K8a965IJv94J8BtLc8ZWjvZ2fHoYXlSmssfrGGQ qNZo5zFpiC4Q== X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="538366172" Received: from unknown (HELO localhost.localdomain) ([10.240.183.77]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 23:23:29 -0800 From: Chen Linglix To: dts@dpdk.org Cc: Chen Linglix Date: Tue, 3 Nov 2020 15:23:43 +0000 Message-Id: <20201103152344.1677878-2-linglix.chen@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201103152344.1677878-1-linglix.chen@intel.com> References: <20201103152344.1677878-1-linglix.chen@intel.com> MIME-Version: 1.0 Subject: [dts] [dts 1/2] conf/test_case_checklist:change_thresholds:CVL and FVL not support this case(DPDK-24129) X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" change_thresholds:CVL and FVL not support this case(DPDK-24129) Signed-off-by: Chen Linglix --- conf/test_case_checklist.json | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json index 74dade7a..79100e2a 100644 --- a/conf/test_case_checklist.json +++ b/conf/test_case_checklist.json @@ -3515,5 +3515,27 @@ "Bug ID": "", "Comments": "the nic not support this case" } + ], + "change_thresholds": [ + { + "OS": [ + "ALL" + ], + "NIC": [ + "columbiaville_100g", + "columbiaville_25g", + "fortville_eagle", + "fortville_spirit", + "fortpark_TLV", + "fortpark_BASE-T", + "fortville_25g", + "carlsville" + ], + "Target": [ + "ALL" + ], + "Bug ID": "DPDK-24129", + "Comments": "CVL and FVL not support this case" + } ] } From patchwork Tue Nov 3 15:23:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lingli Chen X-Patchwork-Id: 83491 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04C0AA0524; Tue, 3 Nov 2020 08:23:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 633B1BE9F; Tue, 3 Nov 2020 08:23:36 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 43784BE87 for ; Tue, 3 Nov 2020 08:23:34 +0100 (CET) IronPort-SDR: 8AaYe5ZMBnE36Frz/gWXtrgg9AjPRSNw+U9TaWPB7brDUq6aK5PxD1QVEP2lBtEaxvwTcCDNB5 rwHpOV2gQiHQ== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="148865995" X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="148865995" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 23:23:32 -0800 IronPort-SDR: 2POQyRYcSqqyk4e1O+zO0TQAW1MTPKogITCBwaGyYYRpG6R3zZod7ECLHSAtSFbI1nJLDfwT0Z iYp4CN1vCH+Q== X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="538366206" Received: from unknown (HELO localhost.localdomain) ([10.240.183.77]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 23:23:31 -0800 From: Chen Linglix To: dts@dpdk.org Cc: Chen Linglix Date: Tue, 3 Nov 2020 15:23:44 +0000 Message-Id: <20201103152344.1677878-3-linglix.chen@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201103152344.1677878-1-linglix.chen@intel.com> References: <20201103152344.1677878-1-linglix.chen@intel.com> MIME-Version: 1.0 Subject: [dts] [dts 2/2] tests/TestSuite_shutdown_api:change_thresholds:Ixgbe not support rx, only support tx X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" DPDK-24129:1.Ixgbe not support rx, only support tx. 2.foxville, powerville and springville not support txfree and txrs 3.foxville--eth_igc_tx_queue_setup(): To improve 2.5G driver performance, consider setting the TX WTHRESH value to 4, 8, or 16. Signed-off-by: Chen Linglix --- tests/TestSuite_shutdown_api.py | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py index edd1dcfa..1e98c640 100644 --- a/tests/TestSuite_shutdown_api.py +++ b/tests/TestSuite_shutdown_api.py @@ -706,34 +706,40 @@ class TestShutdownApi(TestCase): def test_change_thresholds(self): """ Change RX/TX thresholds + DPDK-24129:1.CVL and FVL not support tx and rx + 2.Ixgbe not support rx, only support tx. + 3.foxville, powerville and springville not support txfree and txrs """ self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket) self.dut.send_expect("set promisc all off", "testpmd>") self.dut.send_expect("port stop all", "testpmd> ", 100) - self.dut.send_expect("port config all txfreet 32", "testpmd> ") - self.dut.send_expect("port config all txrst 32", "testpmd> ") + if self.nic in ["sagepond","sageville","twinpond","niantic"]: + self.dut.send_expect("port config all txfreet 32", "testpmd> ") + self.dut.send_expect("port config all txrst 32", "testpmd> ") self.dut.send_expect("port config all rxfreet 32", "testpmd> ") self.dut.send_expect("port config all txpt 64", "testpmd> ") self.dut.send_expect("port config all txht 64", "testpmd> ") - self.dut.send_expect("port config all txwt 0", "testpmd> ") - self.dut.send_expect("port config all rxpt 64", "testpmd> ") - self.dut.send_expect("port config all rxht 64", "testpmd> ") - self.dut.send_expect("port config all rxwt 64", "testpmd> ") + if self.nic in ["foxville"]: + self.dut.send_expect("port config all txwt 16", "testpmd> ") + else: + self.dut.send_expect("port config all txwt 0", "testpmd> ") + self.dut.send_expect("port start all", "testpmd> ", 100) out = self.dut.send_expect("show config rxtx", "testpmd> ") self.verify("RX free threshold=32" in out, "RX descriptor not reconfigured properly") - self.verify("TX free threshold=32" in out, + if self.nic in ["sagepond","sageville","twinpond","niantic"]: + self.verify("TX free threshold=32" in out, "TX descriptor not reconfigured properly") - self.verify("TX RS bit threshold=32" in out, + self.verify("TX RS bit threshold=32" in out, "TX descriptor not reconfigured properly") self.verify("pthresh=64" in out, "TX descriptor not reconfigured properly") self.verify("hthresh=64" in out, "TX descriptor not reconfigured properly") - self.verify("wthresh=64" in out, "TX descriptor not reconfigured properly") - self.verify("pthresh=64" in out, "TX descriptor not reconfigured properly") - self.verify("hthresh=64" in out, "TX descriptor not reconfigured properly") - self.verify("wthresh=64" in out, "TX descriptor not reconfigured properly") + if self.nic in ["foxville"]: + self.verify("wthresh=16" in out, "TX descriptor not reconfigured properly") + else: + self.verify("wthresh=0" in out, "TX descriptor not reconfigured properly") self.dut.send_expect("set fwd mac", "testpmd>") self.dut.send_expect("start", "testpmd> ") self.check_forwarding()