From patchwork Fri Feb 5 16:47:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sun, QinX" X-Patchwork-Id: 87793 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DA45A0524; Fri, 5 Feb 2021 09:16:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0214D40682; Fri, 5 Feb 2021 09:16:55 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id EE6DB4067B for ; Fri, 5 Feb 2021 09:16:52 +0100 (CET) IronPort-SDR: EjylRpauzfdzv9iKa0zgPG18zqvlqATZ75MwM4u7wiihc+eNA+amLY2Hr0h6bLD4l2kdaNnrkA 2QMsLv+VLzng== X-IronPort-AV: E=McAfee;i="6000,8403,9885"; a="180625270" X-IronPort-AV: E=Sophos;i="5.81,154,1610438400"; d="scan'208";a="180625270" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2021 00:16:51 -0800 IronPort-SDR: 1JeqqkoSLEBs0bkgyl5vTxpSVCVMCx2ZNLyCBbJDxDdl5gZ4kzrAMiLDn6+rcwV6E+WChF2nMT hTksa2vhDQqA== X-IronPort-AV: E=Sophos;i="5.81,154,1610438400"; d="scan'208";a="393757138" Received: from unknown (HELO dpdk-wenjielx-tetser203.icx.intel.com) ([10.240.183.105]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2021 00:16:50 -0800 From: sunqin To: dts@dpdk.org Cc: sunqin Date: Fri, 5 Feb 2021 16:47:09 +0000 Message-Id: <20210205164709.31384-1-qinx.sun@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dts] [PATCH V1] tests/cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp: remove invalid case X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" duplicated_rules confirmed as an invalid case,so remove it from test plan and suite. Signed-off-by: sunqin --- ..._pppoe_vlan_esp_ah_l2tp_pfcp_test_plan.rst | 23 ++++--------------- ...dvanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp.py | 7 ------ 2 files changed, 4 insertions(+), 26 deletions(-) diff --git a/test_plans/cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp_test_plan.rst b/test_plans/cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp_test_plan.rst index 52702686..f60c9ec7 100644 --- a/test_plans/cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp_test_plan.rst +++ b/test_plans/cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp_test_plan.rst @@ -6024,22 +6024,7 @@ Subcase 1: wrong hash input set there is no listed. -Subcase 2: duplicated rules (not supported in 20.08) ----------------------------------------------------- - -1. create a PFCP rule:: - - testpmd> flow create 0 ingress pattern eth / ipv4 / udp / pfcp / end actions rss types pfcp end key_len 0 queues end / end - - the rule is created successfully. - -2. create the same rule again, Failed to create flow, report message:: - - Add rule failed.: Operation not permitted - -3. check only the first rule exists in the list. - -Subcase 3: void action +Subcase 2: void action ---------------------- 1. validate a rule with void action:: @@ -6064,7 +6049,7 @@ Subcase 3: void action there is no rule listed. -Subcase 4: delete a non-existing rule +Subcase 3: delete a non-existing rule ------------------------------------- 1. show the rule list of port 0:: @@ -6085,7 +6070,7 @@ Subcase 4: delete a non-existing rule There is no error message reported. -Subcase 5: unsupported pattern with OS default package +Subcase 4: unsupported pattern with OS default package ------------------------------------------------------ 1. load os default package and launch testpmd as step 3-5 in Prerequisites. @@ -6114,7 +6099,7 @@ Subcase 5: unsupported pattern with OS default package there is no rule listed. -Subcase 6: invalid port +Subcase 5: invalid port ----------------------- 1. create a rule with invalid port:: diff --git a/tests/TestSuite_cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp.py b/tests/TestSuite_cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp.py index acde66b2..bf5422d9 100644 --- a/tests/TestSuite_cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp.py +++ b/tests/TestSuite_cvl_advanced_rss_pppoe_vlan_esp_ah_l2tp_pfcp.py @@ -5590,13 +5590,6 @@ class Advanced_rss_pppoe_vlan_ah_l2tp_pfcp(TestCase): self.rsspro.validate_rule(rule, check_stats=False, check_msg='Invalid argument') self.rsspro.create_rule(rule, check_stats=False, msg='Invalid argument') - def test_duplicated_rules(self): - self.switch_testpmd(symmetric=True) - rule = 'flow create 0 ingress pattern eth / ipv4 / udp / pfcp / end actions rss types pfcp end key_len 0 queues end / end' - self.rsspro.create_rule(rule) - self.rsspro.create_rule(rule, check_stats=False, msg='Operation not permitted') - self.rsspro.check_rule(rule_list=[rule]) - def test_void_action(self): self.switch_testpmd(symmetric=True) rule = 'flow create 0 ingress pattern eth / ipv4 / udp / pfcp / end actions end'