From patchwork Wed May 12 02:30:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jiang, Cheng1" X-Patchwork-Id: 93173 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6751A0A0E; Wed, 12 May 2021 04:44:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57BD2410DE; Wed, 12 May 2021 04:44:42 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id A359D4003E for ; Wed, 12 May 2021 04:44:40 +0200 (CEST) IronPort-SDR: 1nLfMGVdvbjNYpljuggrMmTSRyuASUUvMvBZMrUpdW3LBR4qNVkLsvMMFxuxwCXfqKPNk9xojy u8SIPzpqNL5Q== X-IronPort-AV: E=McAfee;i="6200,9189,9981"; a="199651756" X-IronPort-AV: E=Sophos;i="5.82,292,1613462400"; d="scan'208";a="199651756" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 19:44:39 -0700 IronPort-SDR: buWvT2DBlA7/qKMvNiubsKFHZ0HWrqUGTfw57V66Zm1xukijokqtNXZCrEyDXM09X3xwbf8JXY I9kwBSXU7/YA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,292,1613462400"; d="scan'208";a="469197638" Received: from dpdk_jiangcheng.sh.intel.com ([10.67.119.112]) by fmsmga002.fm.intel.com with ESMTP; 11 May 2021 19:44:38 -0700 From: Cheng Jiang To: maxime.coquelin@redhat.com, chenbo.xia@intel.com Cc: dev@dpdk.org, Cheng Jiang Date: Wed, 12 May 2021 02:30:56 +0000 Message-Id: <20210512023056.30558-1-cheng1.jiang@intel.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] vhost: fix unintended sign extension in async packed ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Change the variable type in store_dma_desc_info_packed() to fix suspicious implicit sign extension. Coverity issue: 370608, 370610, 370612 Fixes: 873e8dad6f49 (vhost: support packed ring in async datapath) Signed-off-by: Cheng Jiang Reviewed-by: Chenbo Xia --- lib/vhost/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c index 9137a9923b..abfd67d38c 100644 --- a/lib/vhost/virtio_net.c +++ b/lib/vhost/virtio_net.c @@ -1491,7 +1491,7 @@ store_dma_desc_info_packed(struct vring_used_elem_packed *s_ring, struct vring_used_elem_packed *d_ring, uint16_t ring_size, uint16_t s_idx, uint16_t d_idx, uint16_t count) { - uint16_t elem_size = sizeof(struct vring_used_elem_packed); + size_t elem_size = sizeof(struct vring_used_elem_packed); if (d_idx + count <= ring_size) { rte_memcpy(d_ring + d_idx, s_ring + s_idx, count * elem_size);