From patchwork Thu Jun 10 01:01:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SunChengLian X-Patchwork-Id: 94062 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4CD9A0C47; Thu, 10 Jun 2021 03:02:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 250FA40F35; Thu, 10 Jun 2021 03:02:09 +0200 (CEST) Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by mails.dpdk.org (Postfix) with ESMTP id D75974003C; Thu, 10 Jun 2021 03:02:07 +0200 (CEST) Received: from loongson.loongson.cn (unknown [10.50.122.80]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9DxD0OKZMFgoyAOAA--.17888S2; Thu, 10 Jun 2021 09:02:04 +0800 (CST) From: SunChengLian To: dev@dpdk.org Cc: SunChengLian , stable@dpdk.org, Bruce Richardson Date: Thu, 10 Jun 2021 09:01:59 +0800 Message-Id: <20210610010159.1813398-1-sunchenglian@loongson.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: AQAAf9DxD0OKZMFgoyAOAA--.17888S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtFWDKF4DZr4fCr15Aw1kZrb_yoWxZFX_G3 Z5K3yrWrZ8GF4DKry0gFZ5X348Kw18C3W7G3y2ywnxt3WDXws3KFWkA3Z3Wr17uF17Ga43 JrySyrykAr4xAjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbV8FF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v26F4UJV W0owAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VAC jcxG62k0Y48FwI0_Jr0_Gr1lYx0E2Ix0cI8IcVAFwI0_JF0_Jw1lYx0Ex4A2jsIE14v26r 1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAq YI8I648v4I1lc2xSY4AK6svPMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r 4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF 67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2I x0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_WFyUJVCq3wCI42IY 6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvj DU0xZFpf9x0JUaiifUUUUU= X-CM-SenderInfo: pvxquxxhqjzxtdq6z05rqj20fqof0/1tbiAQAIDl3QvNby1QAAsH Subject: [dpdk-dev] [PATCH] examples/l2fwd: fix l2fwd long options parse issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Readd other long options case in l2fwd_parse_args function to ensure all long options will work well. Fixes: fa19eb20d2126d8bc63acc8f336a353dfaf8c354 ("examples/l2fwd: add forwarding port mapping option") Cc: stable@dpdk.org Signed-off-by: SunChengLian --- examples/l2fwd/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index ffb67bb901..3215ec3806 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -502,6 +502,9 @@ l2fwd_parse_args(int argc, char **argv) } break; + case 0: + break; + default: l2fwd_usage(prgname); return -1; From patchwork Fri Jun 11 10:27:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SunChengLian X-Patchwork-Id: 94087 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB20FA0C4A; Fri, 11 Jun 2021 12:28:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BBE73410FE; Fri, 11 Jun 2021 12:28:15 +0200 (CEST) Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by mails.dpdk.org (Postfix) with ESMTP id B7C55410F9; Fri, 11 Jun 2021 12:28:13 +0200 (CEST) Received: from lenovo.loongson.cn (unknown [223.104.42.78]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9Dx70OxOsNgxjgPAA--.16279S2; Fri, 11 Jun 2021 18:28:10 +0800 (CST) From: SunChengLian To: dev@dpdk.org, sunchenglian@loongson.cn Cc: bruce.richardson@intel.com, stable@dpdk.org, david.marchand@redhat.com Date: Fri, 11 Jun 2021 18:27:41 +0800 Message-Id: <20210611102741.389045-2-sunchenglian@loongson.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210610010159.1813398-1-sunchenglian@loongson.cn> References: <20210610010159.1813398-1-sunchenglian@loongson.cn> MIME-Version: 1.0 X-CM-TRANSID: AQAAf9Dx70OxOsNgxjgPAA--.16279S2 X-Coremail-Antispam: 1UD129KBjvJXoWruw4DZrWUGr18tFyrArWkWFg_yoW8JrW5pr y5WwnrWFn0vw1Utw4Ut34rWw1rJFW3JwsxArZ5Za43t3WUJan3Wr40kr1DZr1DCFWvvrZr Zw1fZrWfG3W5Aa7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkv14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkIecxEwVAFwVW8twCF 04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r 18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vI r41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr 1lIxAIcVCF04k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF 0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUgiSdUUUUU= X-CM-SenderInfo: pvxquxxhqjzxtdq6z05rqj20fqof0/1tbiAQAJDl3QvNcZkQADsr Subject: [dpdk-dev] [PATCH v2 2/2] examples/l2fwd: remove mac-updating option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The "mac-updating" option can be removed since the associated mac_updating variable is set to 1 by default. Signed-off-by: SunChengLian Reviewed-by: David Marchand --- examples/l2fwd/main.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index a8fa091842..65b290291d 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -434,13 +434,11 @@ enum { /* first long only option value must be >= 256, so that we won't * conflict with short options */ - CMD_LINE_OPT_MAC_UPDATING_NUM = 256, - CMD_LINE_OPT_NO_MAC_UPDATING_NUM, + CMD_LINE_OPT_NO_MAC_UPDATING_NUM=256, CMD_LINE_OPT_PORTMAP_NUM, }; static const struct option lgopts[] = { - { CMD_LINE_OPT_MAC_UPDATING, no_argument, 0, CMD_LINE_OPT_MAC_UPDATING_NUM}, { CMD_LINE_OPT_NO_MAC_UPDATING, no_argument, 0, CMD_LINE_OPT_NO_MAC_UPDATING_NUM}, { CMD_LINE_OPT_PORTMAP_CONFIG, 1, 0, CMD_LINE_OPT_PORTMAP_NUM}, {NULL, 0, 0, 0} @@ -503,10 +501,6 @@ l2fwd_parse_args(int argc, char **argv) } break; - case CMD_LINE_OPT_MAC_UPDATING_NUM: - mac_updating = 1; - break; - case CMD_LINE_OPT_NO_MAC_UPDATING_NUM: mac_updating = 0; break;