From patchwork Mon Sep 6 13:02:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 98081 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29565A0C43; Mon, 6 Sep 2021 15:02:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A49BE410EF; Mon, 6 Sep 2021 15:02:46 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 172C0410ED for ; Mon, 6 Sep 2021 15:02:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630933364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CM1HPErWbvgmGp/FMjQRNs0HXdheCfxwb9G3ViGh/T0=; b=RYyPMamw8XJr1LTZg+H5mIzMPegaEbQ2GbqEdotlveX674e3vO5H0qwJYMwCKDs1pNXtjV Ht0cqBZ4Gps7/e4kf8XsNMTK0XqUf8Y2pYK6GaASpF7/kA7PqY1RKN8ia3IGaz9PQWsII4 l6CJB48G8Mrq2+UPVLWhaQps4cHhLxc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-321-EHqreWUEOqum5iZW2ghdVw-1; Mon, 06 Sep 2021 09:02:32 -0400 X-MC-Unique: EHqreWUEOqum5iZW2ghdVw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B31C6835DE2; Mon, 6 Sep 2021 13:02:30 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.192.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4A5896788D; Mon, 6 Sep 2021 13:02:28 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Ray Kinsella Date: Mon, 6 Sep 2021 15:02:20 +0200 Message-Id: <20210906130220.6756-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH] ethdev: promote sibling iterators to stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This API saw no update since its introduction and will help applications like OVS ([1] and [2]) that currently look at rte_eth_devices[] to achieve the same. 1: https://github.com/openvswitch/ovs/blob/master/lib/netdev-dpdk.c#L1285 2: https://github.com/openvswitch/ovs/blob/master/lib/netdev-dpdk.c#L1476 Signed-off-by: David Marchand Acked-by: Andrew Rybchenko Acked-by: Ray Kinsella --- lib/ethdev/rte_ethdev.h | 8 -------- lib/ethdev/version.map | 6 ++---- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index d2b27c351f..e888836471 100644 --- a/lib/ethdev/rte_ethdev.h +++ b/lib/ethdev/rte_ethdev.h @@ -1894,9 +1894,6 @@ uint16_t rte_eth_find_next(uint16_t port_id); RTE_ETH_FOREACH_DEV_OWNED_BY(p, RTE_ETH_DEV_NO_OWNER) /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice. - * * Iterates over ethdev ports of a specified device. * * @param port_id_start @@ -1907,7 +1904,6 @@ uint16_t rte_eth_find_next(uint16_t port_id); * Next port id of the device, possibly port_id_start, * RTE_MAX_ETHPORTS if there is none. */ -__rte_experimental uint16_t rte_eth_find_next_of(uint16_t port_id_start, const struct rte_device *parent); @@ -1926,9 +1922,6 @@ rte_eth_find_next_of(uint16_t port_id_start, port_id = rte_eth_find_next_of(port_id + 1, parent)) /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice. - * * Iterates over sibling ethdev ports (i.e. sharing the same rte_device). * * @param port_id_start @@ -1939,7 +1932,6 @@ rte_eth_find_next_of(uint16_t port_id_start, * Next sibling port id, possibly port_id_start or ref_port_id itself, * RTE_MAX_ETHPORTS if there is none. */ -__rte_experimental uint16_t rte_eth_find_next_sibling(uint16_t port_id_start, uint16_t ref_port_id); diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map index 3eece75b72..c52720851a 100644 --- a/lib/ethdev/version.map +++ b/lib/ethdev/version.map @@ -71,7 +71,9 @@ DPDK_22 { rte_eth_dev_vlan_filter; rte_eth_devices; rte_eth_find_next; + rte_eth_find_next_of; rte_eth_find_next_owned_by; + rte_eth_find_next_sibling; rte_eth_iterator_cleanup; rte_eth_iterator_init; rte_eth_iterator_next; @@ -157,10 +159,6 @@ EXPERIMENTAL { rte_eth_dev_rx_intr_ctl_q_get_fd; rte_flow_conv; - # added in 19.05 - rte_eth_find_next_of; - rte_eth_find_next_sibling; - # added in 19.08 rte_eth_read_clock;