From patchwork Thu Sep 9 04:16:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qiming Chen X-Patchwork-Id: 98399 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8319BA0547; Thu, 9 Sep 2021 06:17:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 442214003E; Thu, 9 Sep 2021 06:17:50 +0200 (CEST) Received: from mail-m972.mail.163.com (mail-m972.mail.163.com [123.126.97.2]) by mails.dpdk.org (Postfix) with ESMTP id 154D14003C for ; Thu, 9 Sep 2021 06:17:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=JsEkG wWX+J1YemqzbZ9eZBW7m6soAXXlvkmkX0/m/ec=; b=IDHzkYuPgDU0r5G3XOQR0 utuRkDbUnUvg4Ki9jLxpa9XRFpMLGc6nExdjDeUOVT2PJws4pcGWd3R4vY6RuSe8 YDaJRlhpZA5qv2eN7Sf1l5gimfGBr82rNbFbHx5MXtSfzLHV++BdwmG+LD77ofYQ xeyiIePUwv3suHb+UZQJV4= Received: from localhost.localdomain (unknown [124.160.214.74]) by smtp2 (Coremail) with SMTP id GtxpCgAXnPjkijlhuqioSA--.83S2; Thu, 09 Sep 2021 12:17:44 +0800 (CST) From: Qiming Chen To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Qiming Chen Date: Thu, 9 Sep 2021 12:16:58 +0800 Message-Id: <20210909041658.10123-1-chenqiming_huawei@163.com> X-Mailer: git-send-email 2.30.1.windows.1 In-Reply-To: <20210909024531.10009-1-chenqiming_huawei@163.com> References: <20210909024531.10009-1-chenqiming_huawei@163.com> MIME-Version: 1.0 X-CM-TRANSID: GtxpCgAXnPjkijlhuqioSA--.83S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxGw1rWF1DCF1kWw47ZF4ktFb_yoW5CrykpF ZxKa47t3y7XFZrG3sxGFWrZr1DG3y7Kr4xWFZ7G34Ykas0kFyYgryUKFWjvF92kayDC3W3 Aw4DJFWDCayUGFUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j5pnPUUUUU= X-Originating-IP: [124.160.214.74] X-CM-SenderInfo: xfkh01xlpl0w5bkxt4lhl6il2tof0z/1tbiQAgJoFSIkBAoKAAAs9 Subject: [dpdk-dev] [PATCH v4] net/pcap: improve rx statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In the receiving direction, if alloc mbuf or jumbo process failed, there is no err_pkts count, which makes it difficult to locate the problem. Because alloc mbuf failed, the rx_nombuf field is counted. Signed-off-by: Qiming Chen --- v2: Clear coding style issues. v3: 1) Send direction does not release mbuf. 2) Failed to alloc mbuf is counted to the rx_nombuf field. v4: Add rx_nombuf field. --- drivers/net/pcap/pcap_ethdev.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c index a8774b7a43..47db6b9b33 100644 --- a/drivers/net/pcap/pcap_ethdev.c +++ b/drivers/net/pcap/pcap_ethdev.c @@ -51,6 +51,7 @@ struct queue_stat { volatile unsigned long pkts; volatile unsigned long bytes; volatile unsigned long err_pkts; + volatile unsigned long rx_nombuf; }; struct queue_missed_stat { @@ -297,8 +298,10 @@ eth_pcap_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) break; mbuf = rte_pktmbuf_alloc(pcap_q->mb_pool); - if (unlikely(mbuf == NULL)) - break; + if (unlikely(mbuf == NULL)) { + pcap_q->rx_stat.rx_nombuf++; + continue; + } if (header.caplen <= rte_pktmbuf_tailroom(mbuf)) { /* pcap packet will fit in the mbuf, can copy it */ @@ -311,6 +314,7 @@ eth_pcap_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) mbuf, packet, header.caplen) == -1)) { + pcap_q->rx_stat.rx_nombuf++; rte_pktmbuf_free(mbuf); break; } @@ -742,7 +746,7 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) { unsigned int i; unsigned long rx_packets_total = 0, rx_bytes_total = 0; - unsigned long rx_missed_total = 0; + unsigned long rx_missed_total = 0, rx_nombuf = 0; unsigned long tx_packets_total = 0, tx_bytes_total = 0; unsigned long tx_packets_err_total = 0; const struct pmd_internals *internal = dev->data->dev_private; @@ -751,6 +755,7 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) i < dev->data->nb_rx_queues; i++) { stats->q_ipackets[i] = internal->rx_queue[i].rx_stat.pkts; stats->q_ibytes[i] = internal->rx_queue[i].rx_stat.bytes; + rx_nombuf += internal->rx_queue[i].rx_stat.rx_nombuf; rx_packets_total += stats->q_ipackets[i]; rx_bytes_total += stats->q_ibytes[i]; rx_missed_total += queue_missed_stat_get(dev, i); @@ -771,6 +776,7 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) stats->opackets = tx_packets_total; stats->obytes = tx_bytes_total; stats->oerrors = tx_packets_err_total; + stats->rx_nombuf = rx_nombuf; return 0; } @@ -784,6 +790,8 @@ eth_stats_reset(struct rte_eth_dev *dev) for (i = 0; i < dev->data->nb_rx_queues; i++) { internal->rx_queue[i].rx_stat.pkts = 0; internal->rx_queue[i].rx_stat.bytes = 0; + internal->rx_queue[i].rx_stat.err_pkts = 0; + internal->rx_queue[i].rx_stat.rx_nombuf = 0; queue_missed_stat_reset(dev, i); }