From patchwork Fri Sep 17 08:23:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 99078 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BB51A0C46; Fri, 17 Sep 2021 10:23:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EBCC7410EA; Fri, 17 Sep 2021 10:23:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B16C540689 for ; Fri, 17 Sep 2021 10:23:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631867014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z/j6TCIJoRrEZSdba11MJ+yi7uqX1wgSiOz78FEsToA=; b=MDayo6nzqgjqY8XrVAA4XWqkNkaShnmiuk7IjROw5fDYw82Q18qJtNWdQ/YR7GO/hOe4z4 SrSminU+jSrVbJddWKAzsyZwVZ16SJM8SL56wNJbnr2JIN/2ocOW0pa62/Fe9IB67Q3DIm E/JDe5wORMhVn3OVYQsvt36nMKJNRC0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-340-vfbh-I6kOXe24Aabw21cjw-1; Fri, 17 Sep 2021 04:23:31 -0400 X-MC-Unique: vfbh-I6kOXe24Aabw21cjw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4D5B0801B3D; Fri, 17 Sep 2021 08:23:30 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.192.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6EDEF60C9F; Fri, 17 Sep 2021 08:23:28 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: aconole@redhat.com, zhihongx.peng@intel.com, stable@dpdk.org, Stephen Hemminger , Long Li Date: Fri, 17 Sep 2021 10:23:11 +0200 Message-Id: <20210917082313.21934-2-david.marchand@redhat.com> In-Reply-To: <20210917082313.21934-1-david.marchand@redhat.com> References: <20210917082313.21934-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH 1/3] bus/vmbus: fix leak on device scan X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Caught running ASAN. The device name is leaked on scan. rte_device name field being a const, use the private vmbus struct to store the device name and point at it. Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Cc: stable@dpdk.org Signed-off-by: David Marchand --- drivers/bus/vmbus/linux/vmbus_bus.c | 5 ++++- drivers/bus/vmbus/rte_bus_vmbus.h | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/bus/vmbus/linux/vmbus_bus.c b/drivers/bus/vmbus/linux/vmbus_bus.c index 3c924eee14..d8eb07d398 100644 --- a/drivers/bus/vmbus/linux/vmbus_bus.c +++ b/drivers/bus/vmbus/linux/vmbus_bus.c @@ -242,7 +242,7 @@ vmbus_scan_one(const char *name) return -1; dev->device.bus = &rte_vmbus_bus.bus; - dev->device.name = strdup(name); + dev->device.name = dev->name = strdup(name); if (!dev->device.name) goto error; @@ -261,6 +261,7 @@ vmbus_scan_one(const char *name) /* skip non-network devices */ if (rte_uuid_compare(dev->class_id, vmbus_nic_uuid) != 0) { + free(dev->name); free(dev); return 0; } @@ -312,6 +313,7 @@ vmbus_scan_one(const char *name) } else { /* already registered */ VMBUS_LOG(NOTICE, "%s already registered", name); + free(dev->name); free(dev); } return 0; @@ -322,6 +324,7 @@ vmbus_scan_one(const char *name) error: VMBUS_LOG(DEBUG, "failed"); + free(dev->name); free(dev); return -1; } diff --git a/drivers/bus/vmbus/rte_bus_vmbus.h b/drivers/bus/vmbus/rte_bus_vmbus.h index 4cf73ce815..438eb481fc 100644 --- a/drivers/bus/vmbus/rte_bus_vmbus.h +++ b/drivers/bus/vmbus/rte_bus_vmbus.h @@ -65,6 +65,7 @@ struct rte_vmbus_device { TAILQ_ENTRY(rte_vmbus_device) next; /**< Next probed VMBUS device */ const struct rte_vmbus_driver *driver; /**< Associated driver */ struct rte_device device; /**< Inherit core device */ + char *name; /**< Device name */ rte_uuid_t device_id; /**< VMBUS device id */ rte_uuid_t class_id; /**< VMBUS device type */ uint32_t relid; /**< id for primary */ From patchwork Fri Sep 17 08:23:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 99079 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B48CA0C46; Fri, 17 Sep 2021 10:23:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5753B410FF; Fri, 17 Sep 2021 10:23:39 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 74310410FE for ; Fri, 17 Sep 2021 10:23:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631867017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f3BE9J/aWgcRSCBsqj5iYq9vd15toZMdCwivUESQd9U=; b=CFJcx+ySJ8CIpdnfl8a/d1PTrmgb+6/KzNCFNsRaMy2JLWMk4+ryQ5wzbUYlGs3ylTHBMy /8oxT8QydVL2Qlyw3K/OD9VH5mN+2F2tz5b4ORMX9kP0fyxVv1GjAhZaePnjL/B3CIl5C4 zr3aj24qp/NHiJAsyF5FWSn/988h2y8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-477-TW1t34B3MpGq8hsrloBdvA-1; Fri, 17 Sep 2021 04:23:36 -0400 X-MC-Unique: TW1t34B3MpGq8hsrloBdvA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6B923A40C1; Fri, 17 Sep 2021 08:23:35 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.192.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id 48C3C60CCC; Fri, 17 Sep 2021 08:23:33 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: aconole@redhat.com, zhihongx.peng@intel.com, stable@dpdk.org, Reshma Pattan , Naga Suresh Somarowthu Date: Fri, 17 Sep 2021 10:23:12 +0200 Message-Id: <20210917082313.21934-3-david.marchand@redhat.com> In-Reply-To: <20210917082313.21934-1-david.marchand@redhat.com> References: <20210917082313.21934-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH 2/3] test/latencystats: fix incorrect loop boundary X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Caught running ASAN. lat_stats_strings[] is an array containing NUM_STATS strings. Fixes: 1e3676a06e4c ("test/latency: add unit tests for latencystats library") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Reshma Pattan --- app/test/test_latencystats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_latencystats.c b/app/test/test_latencystats.c index 427339904d..724acbc315 100644 --- a/app/test/test_latencystats.c +++ b/app/test/test_latencystats.c @@ -80,7 +80,7 @@ static int test_latencystats_get_names(void) /* Success Test: Valid names and size */ size = NUM_STATS; ret = rte_latencystats_get_names(names, size); - for (i = 0; i <= NUM_STATS; i++) { + for (i = 0; i < NUM_STATS; i++) { if (strcmp(lat_stats_strings[i].name, names[i].name) == 0) printf(" %s\n", names[i].name); else From patchwork Fri Sep 17 08:23:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 99082 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DA51A0C46; Fri, 17 Sep 2021 10:23:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 06C6F410EE; Fri, 17 Sep 2021 10:23:49 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 118B8410EF for ; Fri, 17 Sep 2021 10:23:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631867026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N93q44dDRnENYlp8e+XcI0WH5QfYtx/JQCMtlbTNuZ4=; b=R/PeY6tW3Xm05WmQgfNJdny5df6JgXubMXGKW1qCOaEjdUBGvYEwg9kxQzCQempNx0gY1K kWkGKbl3x9gl4+3FEXvQyeHy2qQTp8ZtBCPEUCRFY18dM+aS0eLtb5iQZ+X7J8/HZsyc46 3lIfUoGwX7uU6T1fAbohVUIFMDPVe18= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-193-z7E-3w_8O8aJ4kFOZKL0NA-1; Fri, 17 Sep 2021 04:23:43 -0400 X-MC-Unique: z7E-3w_8O8aJ4kFOZKL0NA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 62769800FF4; Fri, 17 Sep 2021 08:23:42 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.192.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1BFD660C82; Fri, 17 Sep 2021 08:23:37 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: aconole@redhat.com, zhihongx.peng@intel.com, Michael Santana Date: Fri, 17 Sep 2021 10:23:13 +0200 Message-Id: <20210917082313.21934-4-david.marchand@redhat.com> In-Reply-To: <20210917082313.21934-1-david.marchand@redhat.com> References: <20210917082313.21934-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH 3/3] ci: run unit tests with ASAN X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Enable ASAN for clang jobs. This can greatly help identify leaks and buffer overflows. This patch is more a fyi, as some unit tests stil have issues. Signed-off-by: David Marchand --- .ci/linux-build.sh | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index 91e43a975b..a961d9b92d 100755 --- a/.ci/linux-build.sh +++ b/.ci/linux-build.sh @@ -79,7 +79,14 @@ fi OPTS="$OPTS -Dmachine=default" OPTS="$OPTS --default-library=$DEF_LIB" -OPTS="$OPTS --buildtype=debugoptimized" + +if [ "$CC" != "${CC%%clang}" ] && [ "$RUN_TESTS" = 'true' ]; then + # Let's run tests with ASAN + OPTS="$OPTS -Db_sanitize=address -Db_lundef=false --buildtype=debug" +else + OPTS="$OPTS --buildtype=debugoptimized" +fi + OPTS="$OPTS -Dcheck_includes=true" meson build --werror $OPTS ninja -C build