From patchwork Tue Oct 5 15:54:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xueming Li X-Patchwork-Id: 100526 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88519A0C4C; Tue, 5 Oct 2021 17:55:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20B8C413E9; Tue, 5 Oct 2021 17:55:19 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2054.outbound.protection.outlook.com [40.107.102.54]) by mails.dpdk.org (Postfix) with ESMTP id 1CE15413DC for ; Tue, 5 Oct 2021 17:55:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EasavLz9XhblGl6qIKtDe/XPiBXbh8+y2W8yxCguYN7VVrkfXPCOcqn7ZQhmf4vUKpzv8lTVyn9wqi2AMhVi12AjmA9ttasxDy5KJpG9vTwu87WsniFsozftldmFm18/xjEwuwsBcymNYpxmV4vn0Z3L3Iw0ldse9XBybxdB8pd8t3t4VReA2EcwZRtlAtMz1UmAISnXF5wTGB2n+QdMGfiZc0k3pwFjIhjZPEmYiJ7umH6gTJlxeUirmlRhG7ZmzIWUVq03/7EHV1aL+4W/CyYTXl+TvP7JVdIlnt2nHkkSbWMvwrkCyrhhiDnn0MwQMJAbUYUNmQkQi5fH9LPnrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sg7/RnavcRaI39PstSKuvtlICr4z+e9rtvy44p2Z3FE=; b=lDVr6gRIIU+GSfSWXD4J6S0dRDUTxvMuXTuBcOPsx+DeqdzePcA6VAz0A7J8823jz5oy7+Kl3Co0bYtK7940HMiMr5oMB+ekVhTPMWDFcE/jvdrGgdkvTq5AhHBOhDN/imXwAo9KBOnbVG2aaoqSsc9dbivHeNZ+gD3hTeQCSgZ/Sq71GhhAlJCMyxsIt3uDqjUKDzHHSlT5ZpfAaqZ2Ls3vZvM3c9HR0tntdq6kq0Oiz3rdYgiFS5f8s19bh5shAbCufAsoaCm1K3Hh9jQ6dvEKD4xja+HN4gzzEnRTnJzVumBCDqmz0Fb6ebKKL/iRm22OK9ywuRxcD+6azSO5rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sg7/RnavcRaI39PstSKuvtlICr4z+e9rtvy44p2Z3FE=; b=EqD5sYNkNKItl+CvosQpPaT+Uu0wr8zCW9BwlWzsHj9G5cy7bP8+AfrCc9ZQCo5b7A1P9b7Jhfmr32Se+e95gakXM92KVLqfKrtOTOxtLb254GosqFf8JhjWqh03iGnjwbSRt9yjD5cYS9qOyaeFXQDu1/SQuH5Gq0HAZBS1l5h9q22GS2GvU0BY3kjQXDsF5EG73ne/+4KxzBcBMyBg+NiMTlEHXsXv7bSDOkYONwDXRU2X2mE3p20u+mDMatxVdRomiI6Z18CC6mnvxebnUxIz0XzRun4RH56hLTIODqru4/gD83XFr+PYusycbJ/g1H7PBuxrh76ZEIOHHp6lQQ== Received: from MWHPR04CA0061.namprd04.prod.outlook.com (2603:10b6:300:6c::23) by BN6PR12MB1763.namprd12.prod.outlook.com (2603:10b6:404:107::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Tue, 5 Oct 2021 15:55:12 +0000 Received: from CO1NAM11FT032.eop-nam11.prod.protection.outlook.com (2603:10b6:300:6c:cafe::a5) by MWHPR04CA0061.outlook.office365.com (2603:10b6:300:6c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 5 Oct 2021 15:55:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT032.mail.protection.outlook.com (10.13.174.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 15:55:11 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 5 Oct 2021 15:55:09 +0000 From: Xueming Li To: CC: , Thomas Monjalon , "David Marchand" Date: Tue, 5 Oct 2021 23:54:33 +0800 Message-ID: <20211005155435.279043-2-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211005155435.279043-1-xuemingl@nvidia.com> References: <20211005123012.264727-1-xuemingl@nvidia.com> <20211005155435.279043-1-xuemingl@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3c33886e-6fdb-4788-3a5e-08d98818839a X-MS-TrafficTypeDiagnostic: BN6PR12MB1763: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2449; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IT7JrBFHOJrF7ZRXvYPp+cO08WkvKEoWRJFQIVCMPVdy8q+nMjjonqJzhDG3JZ/YaUC/s+BE5Dt1awgbqBFRFTwn8MWtrgt+zq5re71YgN2Ga0qYQuYzQM1dTmTKKgL6+Imi3su/dbRiJms2JhOtJJEjJ1CW06iyetvjO9LzTP8e97g5qNlCsYUfCuSSF7wttx3fYwOPP9n4sEBGwU5KmA8TwZ8TRRU1jxQXHnd2cEusTwcN6WxJzcui0QYGDQLu3/9FecPbycNMTjRYjgiHyA1EeKNmpSFupHdtdYq3d/PGjFoWOEHxW3SN46LnSeqpd8O9CbReB6U6liOLlBkhZcrf8nvOUSoK4gL9q85K8rGSGdNkUAWTColuYxipaaDU0hwMl8SSXtaE1sxNq+T5uTISxXDmAJB69AsQO5TIunES6O3NxGlUhjSmKK/8XvWZ6hEvMqNX30zOnr6b3J1UhoR9fYgFoRpq/wuETOoCiyHg4BJjeFPlxVKJHYmyBERv+rgXTJEtX6OR2BCDdeB18z3iw+/mkmKVHcnBysm/F2ey07LxXnkeNzfKPQQIxzjpnzcYIk4oW9f5M34GJweYg5Ruqo9BVs598wvRj697YG2yKt8WoC/MPQUbG0NIf0OaAhppD9nUBPKrInxpzFYkY68JzfTQHzTLDeQlLXDq/yhDWSe9Z2gz3WSvB0ZiZRpJZjETpMghgmN4dlckUHh1DQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(5660300002)(7636003)(8676002)(54906003)(47076005)(70586007)(16526019)(7696005)(356005)(508600001)(186003)(55016002)(36756003)(70206006)(26005)(36860700001)(4326008)(2616005)(6916009)(8936002)(83380400001)(316002)(86362001)(336012)(2906002)(6666004)(6286002)(1076003)(82310400003)(426003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 15:55:11.6871 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c33886e-6fdb-4788-3a5e-08d98818839a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT032.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1763 Subject: [dpdk-dev] [PATCH v1 1/3] devargs: support path value for global device arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Slash is used to split global device arguments. To support path value which contains slash, this patch parses devargs by locating both slash and layer name key: bus=a,name=/some/path/class=b,k1=v1/driver=c,k2=v2 "/class=" and "/driver" are valid start of a layer. Signed-off-by: Xueming Li Reviewed-by: Gaetan Rivet --- lib/eal/common/eal_common_devargs.c | 117 ++++++++++------------------ 1 file changed, 43 insertions(+), 74 deletions(-) diff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c index 7ab9e71b2a3..e3786c6c02a 100644 --- a/lib/eal/common/eal_common_devargs.c +++ b/lib/eal/common/eal_common_devargs.c @@ -29,18 +29,6 @@ TAILQ_HEAD(rte_devargs_list, rte_devargs); static struct rte_devargs_list devargs_list = TAILQ_HEAD_INITIALIZER(devargs_list); -static size_t -devargs_layer_count(const char *s) -{ - size_t i = s ? 1 : 0; - - while (s != NULL && s[0] != '\0') { - i += s[0] == '/'; - s++; - } - return i; -} - /* Resolve devargs name from bus arguments. */ static int devargs_bus_parse_default(struct rte_devargs *devargs, @@ -77,23 +65,13 @@ rte_devargs_layers_parse(struct rte_devargs *devargs, { RTE_DEVARGS_KEY_DRIVER "=", NULL, NULL, }, }; struct rte_kvargs_pair *kv = NULL; - struct rte_class *cls = NULL; - struct rte_bus *bus = NULL; - const char *s = devstr; - size_t nblayer; - size_t i = 0; + struct rte_kvargs *bus_kvlist = NULL; + char *s; + size_t nblayer = 0; + size_t i; int ret = 0; bool allocated_data = false; - /* Split each sub-lists. */ - nblayer = devargs_layer_count(devstr); - if (nblayer > RTE_DIM(layers)) { - RTE_LOG(ERR, EAL, "Invalid format: too many layers (%zu)\n", - nblayer); - ret = -E2BIG; - goto get_out; - } - /* If the devargs points the devstr * as source data, then it should not allocate * anything and keep referring only to it. @@ -106,33 +84,41 @@ rte_devargs_layers_parse(struct rte_devargs *devargs, goto get_out; } allocated_data = true; - s = devargs->data; } + s = devargs->data; while (s != NULL) { - if (i >= RTE_DIM(layers)) { - RTE_LOG(ERR, EAL, "Unrecognized layer %s\n", s); - ret = -EINVAL; + if (nblayer > RTE_DIM(layers)) { + ret = -E2BIG; goto get_out; } - /* - * The last layer is free-form. - * The "driver" key is not required (but accepted). - */ - if (strncmp(layers[i].key, s, strlen(layers[i].key)) && - i != RTE_DIM(layers) - 1) - goto next_layer; - layers[i].str = s; - layers[i].kvlist = rte_kvargs_parse_delim(s, NULL, "/"); - if (layers[i].kvlist == NULL) { + layers[nblayer].str = s; + + /* Locate next layer starts with valid layer key. */ + while (s != NULL) { + s = strchr(s, '/'); + if (s == NULL) + break; + for (i = 0; i < RTE_DIM(layers); i++) { + if (strncmp(s + 1, layers[i].key, + strlen(layers[i].key)) == 0) { + *s = '\0'; + break; + } + } + s++; + if (i < RTE_DIM(layers)) + break; + } + + layers[nblayer].kvlist = rte_kvargs_parse + (layers[nblayer].str, NULL); + if (layers[nblayer].kvlist == NULL) { ret = -EINVAL; goto get_out; } - s = strchr(s, '/'); - if (s != NULL) - s++; -next_layer: - i++; + + nblayer++; } /* Parse each sub-list. */ @@ -143,52 +129,35 @@ rte_devargs_layers_parse(struct rte_devargs *devargs, if (kv->key == NULL) continue; if (strcmp(kv->key, RTE_DEVARGS_KEY_BUS) == 0) { - bus = rte_bus_find_by_name(kv->value); - if (bus == NULL) { + bus_kvlist = layers[i].kvlist; + devargs->bus_str = layers[i].str; + devargs->bus = rte_bus_find_by_name(kv->value); + if (devargs->bus == NULL) { RTE_LOG(ERR, EAL, "Could not find bus \"%s\"\n", kv->value); ret = -EFAULT; goto get_out; } } else if (strcmp(kv->key, RTE_DEVARGS_KEY_CLASS) == 0) { - cls = rte_class_find_by_name(kv->value); - if (cls == NULL) { + devargs->cls_str = layers[i].str; + devargs->cls = rte_class_find_by_name(kv->value); + if (devargs->cls == NULL) { RTE_LOG(ERR, EAL, "Could not find class \"%s\"\n", kv->value); ret = -EFAULT; goto get_out; } } else if (strcmp(kv->key, RTE_DEVARGS_KEY_DRIVER) == 0) { - /* Ignore */ + devargs->drv_str = layers[i].str; continue; } } - /* Fill devargs fields. */ - devargs->bus_str = layers[0].str; - devargs->cls_str = layers[1].str; - devargs->drv_str = layers[2].str; - devargs->bus = bus; - devargs->cls = cls; - - /* If we own the data, clean up a bit - * the several layers string, to ease - * their parsing afterward. - */ - if (devargs->data != devstr) { - char *s = devargs->data; - - while ((s = strchr(s, '/'))) { - *s = '\0'; - s++; - } - } - /* Resolve devargs name. */ - if (bus != NULL && bus->devargs_parse != NULL) - ret = bus->devargs_parse(devargs); - else if (layers[0].kvlist != NULL) - ret = devargs_bus_parse_default(devargs, layers[0].kvlist); + if (devargs->bus != NULL && devargs->bus->devargs_parse != NULL) + ret = devargs->bus->devargs_parse(devargs); + else if (bus_kvlist != NULL) + ret = devargs_bus_parse_default(devargs, bus_kvlist); get_out: for (i = 0; i < RTE_DIM(layers); i++) { From patchwork Tue Oct 5 15:54:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xueming Li X-Patchwork-Id: 100525 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04152A0C4C; Tue, 5 Oct 2021 17:55:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4C9F413DF; Tue, 5 Oct 2021 17:55:16 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2071.outbound.protection.outlook.com [40.107.92.71]) by mails.dpdk.org (Postfix) with ESMTP id 91043413DC; Tue, 5 Oct 2021 17:55:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MpyFUeQFbsp+RSjDGajO9LEWn/PpjdU4WQ/J+I0dsrRnIcDwWHjudS7fjWsY5f741kVSMFr74q4NOC5bNrxAtwq2T0S4O5iKKIN3utPWUHq+3MlaRgOadWyDfY10TWP4SB8bKHFnabawn9IalMyme6P3A5+WQGw4SrG6bhqq/W4BOm7P3DlUSvhoPpf2c7UAPeee3+cmlWIAyeyWn8xH4ALm56eA4NnylN2olz2bKwUd23JkVdPvxy0zYb/RL1A7lYcE2YDHtksnXehtFCQrKnpabgts1Q947qEGnf4Cze74L975b+/s75tozGwgrlxtXrFBQhVFkIwjlSlVqG10fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VNMiCvRuHzlWIOIZLFBxHRFlYh/Hdi5AU91tIz6MXhc=; b=SGttT9CNAwmuZjNu3+slGh9Y+O9vHXQuGEuSDPh17e3RxBK/ETimxqkdXFUWHxeEGH9gYVganoc+up6UBdyW4DVPInBrsCrav4dHmMeI+3FZRGjkkrdMLGO34UIfPN9bhYONe0V7WTATJfmZ8Cu7eLteETsKyGilWjB7SzKJh0QB//f8HK3NZPjGz30l+TDJKQAGMZyRQXnUw3WP+hYgPQU0mfep9raOXw5y4uEb/j6ku9emoILBmFvPpf3Dyrvwp2E0R14r5tXrOH9KAso5U/UIhfpv3ePiG/BR7+cAlzjMSM6R9BdvPYppq4aqdORMb3ORH2s4xrHH3gSDwO8A7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VNMiCvRuHzlWIOIZLFBxHRFlYh/Hdi5AU91tIz6MXhc=; b=Piht1rm2kXKFhCaMW/WlxzLh7s1BnO9N4sYFLl5cjMzxpO3WUBOBR1k2fv8BmkpPDF+OtcYIjbaPVGEbFGO6T9kMVm73w7PW1bAEYFlC+WFesiNtkErHkGbygK6SH+pihnCQ046lQXwhleFIOuJitey05QOO2RzOmkbfET63D+993Wx8iXoG0qwUmYQyzEsZbcQYAihr8fdc4e38D1EL/Tb7m45YGvie9rGk7vTDbGw2Sw7AQuq6U1h65uAag4Yi5AHIFJTeZUVdtS05Q50pcsm+pWvfCSa2fzZuibWKU1I9iceeKSed6K0apyuniEuhKRFTw2Q8+W1JU4B9Bcw8fQ== Received: from MWHPR04CA0070.namprd04.prod.outlook.com (2603:10b6:300:6c::32) by DM6PR12MB4356.namprd12.prod.outlook.com (2603:10b6:5:2aa::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.17; Tue, 5 Oct 2021 15:55:14 +0000 Received: from CO1NAM11FT032.eop-nam11.prod.protection.outlook.com (2603:10b6:300:6c:cafe::6b) by MWHPR04CA0070.outlook.office365.com (2603:10b6:300:6c::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.17 via Frontend Transport; Tue, 5 Oct 2021 15:55:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT032.mail.protection.outlook.com (10.13.174.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 15:55:13 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 5 Oct 2021 15:55:11 +0000 From: Xueming Li To: CC: , Thomas Monjalon , "David Marchand" , , Gaetan Rivet Date: Tue, 5 Oct 2021 23:54:34 +0800 Message-ID: <20211005155435.279043-3-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211005155435.279043-1-xuemingl@nvidia.com> References: <20211005123012.264727-1-xuemingl@nvidia.com> <20211005155435.279043-1-xuemingl@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ded85c27-5669-4584-947f-08d9881884e0 X-MS-TrafficTypeDiagnostic: DM6PR12MB4356: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1443; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J64a3ZEZ6ozS/t3706BHGe94bb9d7XjXBfqHZRY5qpv/vQS4HSFpQscnqB3yshLXGF0qVIQ5eCEL8JA6Qv4R9xJKl9ZN9CvI/TDxwga/cNGRVV5M6K6d1Rnw8mgXGSq0Q0dZ18Peqru0uP8n2LmuYMoWbP5+qYisEjwUkmMNe4NN3YeD1ldLIovWiG78meLGadVJc46WBhvQZIr2nFElTvOcGJ0zyvTyk3HAvc5pui0LMpN8pLF0/HSOfQ4v0JvQ59wjpdcwYydVpWifQZhMR+CoAc5zMJDy0Sv5FGHsKdpBp9N4PM0wjZ9qgZ4sA/tl3sX07Jj5Pjhtj8x7k5DsbBAX0y0OYgEWDTGfKZM6YkCLx6R0iXiKWtZRlDQyrdTqyFe3EfLBFUID6M+95nicFyODcxjZVeczHV2zVWY9xF9k8E7RdmlILBffa2rHZ8Kt7aqNJcWEdLNxYwr80Fge407FXGIeESapKJ/E6OAZADvVTdMHpwoAN2l3QhJ+k2jQa7VlA3FAl0hIdK5+WLri4z16hsGaSnljolpylCdsaFstltwyeUr8kTJVGbsYuFF26zAiu84FSEVfW9W3fQRvu3h/rED3plNtcED7I4g+nBsu2wAlsJKPwnFCGHLb6iPUvMojk5E38EvP+W9fBMSlsQ9V42tWZuO8vdXoFAV3/YxY91lFfxn5zORe8b1LuAYpqvNT5hKefdYjCA9wFPITPA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(426003)(26005)(70586007)(54906003)(6916009)(83380400001)(186003)(16526019)(4326008)(2616005)(316002)(86362001)(508600001)(1076003)(70206006)(336012)(82310400003)(8936002)(6286002)(2906002)(47076005)(8676002)(36860700001)(6666004)(356005)(7696005)(5660300002)(7636003)(36756003)(55016002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 15:55:13.7920 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ded85c27-5669-4584-947f-08d9881884e0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT032.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4356 Subject: [dpdk-dev] [PATCH v1 2/3] devargs: make bus key parsing optional X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Global devargs syntax is used as device iteration filter like "class=vdpa", a devargs without bus args is valid from parsing perspective. This patch makes bus args optional. Fixes: d2a66ad79480 ("bus: add device arguments name parsing") Cc: stable@dpdk.org Signed-off-by: Xueming Li Reviewed-by: Gaetan Rivet --- drivers/bus/pci/pci_params.c | 8 +++----- lib/eal/common/eal_common_devargs.c | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/bus/pci/pci_params.c b/drivers/bus/pci/pci_params.c index 691b5ea0180..f6fa3a5d6ce 100644 --- a/drivers/bus/pci/pci_params.c +++ b/drivers/bus/pci/pci_params.c @@ -85,11 +85,10 @@ rte_pci_devargs_parse(struct rte_devargs *da) struct rte_kvargs *kvargs; const char *addr_str; struct rte_pci_addr addr; - int ret; + int ret = 0; - if (da == NULL) + if (da == NULL || da->bus_str == NULL) return 0; - RTE_ASSERT(da->bus_str != NULL); kvargs = rte_kvargs_parse(da->bus_str, NULL); if (kvargs == NULL) { @@ -101,9 +100,8 @@ rte_pci_devargs_parse(struct rte_devargs *da) addr_str = rte_kvargs_get(kvargs, pci_params_keys[RTE_PCI_PARAM_ADDR]); if (addr_str == NULL) { - RTE_LOG(ERR, EAL, "No PCI address specified using '%s=' in: %s\n", + RTE_LOG(DEBUG, EAL, "No PCI address specified using '%s=' in: %s\n", pci_params_keys[RTE_PCI_PARAM_ADDR], da->bus_str); - ret = -ENODEV; goto out; } diff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c index e3786c6c02a..616cf77f229 100644 --- a/lib/eal/common/eal_common_devargs.c +++ b/lib/eal/common/eal_common_devargs.c @@ -39,7 +39,7 @@ devargs_bus_parse_default(struct rte_devargs *devargs, /* Parse devargs name from bus key-value list. */ name = rte_kvargs_get(bus_args, "name"); if (name == NULL) { - RTE_LOG(INFO, EAL, "devargs name not found: %s\n", + RTE_LOG(DEBUG, EAL, "devargs name not found: %s\n", devargs->data); return 0; } From patchwork Tue Oct 5 15:54:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xueming Li X-Patchwork-Id: 100527 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECC24A0C4C; Tue, 5 Oct 2021 17:55:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35E03413ED; Tue, 5 Oct 2021 17:55:20 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2086.outbound.protection.outlook.com [40.107.236.86]) by mails.dpdk.org (Postfix) with ESMTP id 502CA413E8 for ; Tue, 5 Oct 2021 17:55:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QDs0irOvWmdQjB1mj39HAQe0UMYintkT2o9KwEwW6/rNHcA8wtJ8G5mo+DF96QyVOs1z1Hrrrn9NkzhNDBUxVYUUFlHp1bPWxeotm47k2iqba8k9ruAUORlu9d9qn9au1kUneRZPs7a/5QHbh6JTzxTB/5kALRcNdeQ6+1cQyz2ZNS4a5EAJgF49WITxoXxVnWq19G4Wkrc+JmvVUovhNitqHbDEjNA9cy/LLz78PLIP5vYh5Ie6O0Ck+SvYQRc9kpr+vEun5G7LTbvZNlFH49Q8E/lTPpGy9S4lfTJxALAzyqmsUKEOCxBv5VaEjKMYam/25icK98znNm8YO9Mi4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yhfThV8GIu8rXRVcOgbqSgj/1qSnvZKaGqBpKC161Sc=; b=f4QMULnb0ICUl2sIW6qHN779uUE8V3DHPH8m+nn1yfRGvxGy6peyinAO2799OwkgJVaxEsS2hedOkt8FTiEQ0qDDZXuim8Bx/vnk73DRNUxVzGV1V6VfEdDjEeMAsQeaB3XcbUg9W3dnN90NudA1oC8ys0UQGLkc3CTQtK11DOghA5Gox/LaQTQmXqnc347OSK/7sPGNtAWtKj/ZerQyHdA2BbiiD0s/PejKz7ucOgc4V+uCabctF6YDgXH7mNERm+4rx4gJoI7QC2qT2kTuc9j+IFPTDEJwodhMDxns3kbNPMxlaEUOSWp53KV12umgaXez2Dom/3VSn/mdxv4BZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yhfThV8GIu8rXRVcOgbqSgj/1qSnvZKaGqBpKC161Sc=; b=Dom6DriRFURGp/u0TvDcm1ix1tUNOEfQNlSAQdWdPclHj5IZIk7b1rCE/Mdwc2DP18gocmgEZCKYsS3Jckv4G/lG8SAJVAZzW722kOD7h7DBAPM2hoJc3xyUrSXlDCdGNGLFL7Gk4ru4IkuSCIqfPYTUSZmvLr4Y4ct7P8XxJPW/rcsxK9ejcX23jdlNlZgA2IIqA6c1EvcQa2+ENbxec1D0GQT0URHvdswqN10yJ+2YMEzX69xrWfxlLC7urt28EhVREoJ1UmJ8GlP4KyBXvp/9MQwAZZqUVLIJt2se8D3VwGaaCrcdJipMkCZSBQ3+Bzmy5cA+Oxp2w6znHYhVBQ== Received: from MWHPR04CA0065.namprd04.prod.outlook.com (2603:10b6:300:6c::27) by BN9PR12MB5099.namprd12.prod.outlook.com (2603:10b6:408:118::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Tue, 5 Oct 2021 15:55:17 +0000 Received: from CO1NAM11FT032.eop-nam11.prod.protection.outlook.com (2603:10b6:300:6c:cafe::69) by MWHPR04CA0065.outlook.office365.com (2603:10b6:300:6c::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 5 Oct 2021 15:55:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT032.mail.protection.outlook.com (10.13.174.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 15:55:16 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 5 Oct 2021 15:55:13 +0000 From: Xueming Li To: CC: , Thomas Monjalon , "David Marchand" Date: Tue, 5 Oct 2021 23:54:35 +0800 Message-ID: <20211005155435.279043-4-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211005155435.279043-1-xuemingl@nvidia.com> References: <20211005123012.264727-1-xuemingl@nvidia.com> <20211005155435.279043-1-xuemingl@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b1d4c211-5a90-4144-2335-08d98818865e X-MS-TrafficTypeDiagnostic: BN9PR12MB5099: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:376; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HPSIeB//twqLEEsteGD4MqqeD9a/KAs3dTrDgUpSoPDDBpBD6p9U5zxrliz8UPtXbDO1z2aVrzgov2q2dhEHG8hl/pu/ZA5odj+hfJInNahmydkORExgFqQxp0k1tudsbXkj0LHa9e+VI+02PHBjAf6Sx5iCfPLqoPhmslCd1zrQXZLe2Km3QrIP3XonWqZDmAFqkixJKVCde+VBWjFd7hUnBqF4lNjBat8bAhkaWfnevYdmNHI53BIKMld1PFdWDj9IFVE7knW3HzzgxhUm2d52hNDjnkBauXCVUs+Pg4fzOPw3/sTWPCyAR9C7VWhOn4n2eLTNySni/IrZvgHjAd4u7uWtCEgrw1p1N9xJJPMY0WQ7tIc+5E4AWMbx3b/HFPeBEXiSq/94sOoZ+c5w1sypZ7Jt9Y7muZeMpH/U01x6COUoJlg3HJtomJ6DQp7kNrfjLFq3ikcmvmvoXn09WzM64gnOi/wBoZmWt+X88svwky8xY/EyDldb5JJcJF7VyqQqI7zBIfqn/IYFGXg2+19pff/TQjMEQ8tVECUO1L6pDAXuZSvUjxT6QrYPIKA6WGoCZ/umqpyJIv7Dv7CStkp6WO8wD5IT6ViXBPOsGYrDzhhTbIjDE/C2BbznqFUIvjookzJCGTjcJb+dyezo2XSli6oFg125c4HMw6VmQqfn/SVkeMWk6666/DWJdQoNDAptiEQoILu6+sPiNKdXHg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(2906002)(86362001)(356005)(70206006)(36860700001)(7636003)(82310400003)(70586007)(26005)(7696005)(8936002)(5660300002)(1076003)(55016002)(426003)(6286002)(186003)(316002)(54906003)(508600001)(47076005)(83380400001)(336012)(36756003)(16526019)(2616005)(6916009)(8676002)(4326008)(6666004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 15:55:16.3335 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b1d4c211-5a90-4144-2335-08d98818865e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT032.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5099 Subject: [dpdk-dev] [PATCH v1 3/3] test/devargs: add devargs test cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Initial version to test Global devargs syntax. Signed-off-by: Xueming Li --- app/test/autotest_data.py | 6 ++ app/test/meson.build | 2 + app/test/test_devargs.c | 147 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 155 insertions(+) create mode 100644 app/test/test_devargs.c diff --git a/app/test/autotest_data.py b/app/test/autotest_data.py index 302d6374c16..3b841e71918 100644 --- a/app/test/autotest_data.py +++ b/app/test/autotest_data.py @@ -785,6 +785,12 @@ "Func": default_autotest, "Report": None, }, + { + "Name": "Devargs autotest", + "Command": "devargs_autotest", + "Func": default_autotest, + "Report": None, + }, # # Please always make sure that ring_perf is the last test! # diff --git a/app/test/meson.build b/app/test/meson.build index f144d8b8ed6..de8540f6119 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -42,6 +42,7 @@ test_sources = files( 'test_cryptodev_security_pdcp.c', 'test_cycles.c', 'test_debug.c', + 'test_devargs.c', 'test_distributor.c', 'test_distributor_perf.c', 'test_eal_flags.c', @@ -201,6 +202,7 @@ fast_tests = [ ['common_autotest', true], ['cpuflags_autotest', true], ['debug_autotest', true], + ['devargs_autotest', true], ['eal_flags_c_opt_autotest', false], ['eal_flags_main_opt_autotest', false], ['eal_flags_n_opt_autotest', false], diff --git a/app/test/test_devargs.c b/app/test/test_devargs.c new file mode 100644 index 00000000000..8a173368347 --- /dev/null +++ b/app/test/test_devargs.c @@ -0,0 +1,147 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright (c) 2021 NVIDIA Corporation & Affiliates + */ + +#include +#include +#include + +#include +#include +#include + +#include "test.h" + +/* Check layer arguments. */ +static int +test_args(const char *devargs, const char *layer, const char *args, const int n) +{ + struct rte_kvargs *kvlist; + + if (n == 0) { + if (args != NULL && strlen(args) > 0) { + printf("rte_devargs_parse(%s) %s args parsed (not expected)\n", + devargs, layer); + return -1; + } else { + return 0; + } + } + if (args == NULL) { + printf("rte_devargs_parse(%s) %s args not parsed\n", + devargs, layer); + return -1; + } + kvlist = rte_kvargs_parse(args, NULL); + if (kvlist == NULL) { + printf("rte_devargs_parse(%s) %s_str: %s not parsed\n", + devargs, layer, args); + return -1; + } + if ((int)kvlist->count != n) { + printf("rte_devargs_parse(%s) %s_str: %s kv number %u, not %d\n", + devargs, layer, args, kvlist->count, n); + return -1; + } + return 0; +} + +/* Test several valid cases */ +static int +test_valid_devargs(void) +{ + static const struct { + const char *devargs; + int bus_kv; + int class_kv; + int driver_kv; + } list[] = { + /* Global devargs syntax: */ + { "bus=pci", 1, 0, 0 }, + { "class=eth", 0, 1, 0 }, + { "bus=pci,addr=1:2.3/class=eth/driver=abc,k0=v0", 2, 1, 2 }, + { "bus=vdev,name=/dev/file/name/class=eth", 2, 1, 0 }, + /* Legacy devargs syntax: */ + { "1:2.3", 0, 0, 0 }, + { "pci:1:2.3,k0=v0", 0, 0, 1 }, + { "net_virtio_user0,iface=test,path=/dev/vhost-net,queues=1", + 0, 0, 3 }, + }; + struct rte_devargs da; + uint32_t i; + int ret; + int fail = 0; + + for (i = 0; i < RTE_DIM(list); i++) { + memset(&da, 0, sizeof(da)); + ret = rte_devargs_parse(&da, list[i].devargs); + if (ret < 0) { + printf("rte_devargs_parse(%s) returned %d (but should not)\n", + list[i].devargs, ret); + goto fail; + } + if (list[i].bus_kv > 0 && da.bus == NULL) { + printf("rte_devargs_parse(%s) bus not parsed\n", + list[i].devargs); + goto fail; + } + if (test_args(list[i].devargs, "bus", da.bus_str, + list[i].bus_kv) != 0) + goto fail; + if (list[i].class_kv > 0 && da.cls == NULL) { + printf("rte_devargs_parse(%s) class not parsed\n", + list[i].devargs); + goto fail; + } + if (test_args(list[i].devargs, "class", da.cls_str, + list[i].class_kv) != 0) + goto fail; + if (test_args(list[i].devargs, "driver", da.drv_str, + list[i].driver_kv) != 0) + goto fail; + goto cleanup; +fail: + fail = -1; +cleanup: + rte_devargs_reset(&da); + } + return fail; +} + +/* Test several invalid cases */ +static int +test_invalid_devargs(void) +{ + static const char * const list[] = { + "bus=wrong-bus", + "class=wrong-class"}; + struct rte_devargs da; + uint32_t i; + int ret; + int fail = 0; + + for (i = 0; i < RTE_DIM(list); i++) { + ret = rte_devargs_parse(&da, list[i]); + if (ret >= 0) { + printf("rte_devargs_parse(%s) returned %d (but should not)\n", + list[i], ret); + fail = ret; + } + rte_devargs_reset(&da); + } + return fail; +} + +static int +test_devargs(void) +{ + printf("== test valid case ==\n"); + if (test_valid_devargs() < 0) + return -1; + printf("== test invalid case ==\n"); + if (test_invalid_devargs() < 0) + return -1; + return 0; +} + +REGISTER_TEST_COMMAND(devargs_autotest, test_devargs);