From patchwork Sat Oct 23 06:55:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 102704 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9F20A0C4C; Sat, 23 Oct 2021 08:56:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 974C241124; Sat, 23 Oct 2021 08:56:16 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6FE2440150 for ; Sat, 23 Oct 2021 08:56:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634972175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tw0/F+1UgPxwnk1mPjK2fHk1O0tkSA366y8Db5w4dX8=; b=fVIihcetGYG4M6nOI2JplIYb93gHJTBZkaLDXEaYWYdW1e4AU+T2VQz7bD7KeGQSRyX9xx tbtD+ZFm3bOoSeNJSu0xo4N1XJnmEuBVrZKgX4UdoLPfBMEV302GPl5o8fERHn8nlNmTpK KPK0J51V6chiOHOh/znXsBIdS7mNtmA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-320-ScBCcX39OgG8xuM223gExQ-1; Sat, 23 Oct 2021 02:56:13 -0400 X-MC-Unique: ScBCcX39OgG8xuM223gExQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C2CC0801FCE; Sat, 23 Oct 2021 06:56:11 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.192.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 12E1419D9B; Sat, 23 Oct 2021 06:56:07 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, Bruce Richardson , Kevin Laatz , Chengwen Feng , Conor Walsh Date: Sat, 23 Oct 2021 08:55:58 +0200 Message-Id: <20211023065558.818-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH] dma/idxd: fix build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Windows compilation gives us a splat: In file included from ../drivers/dma/idxd/idxd_pci.c:10: In file included from ..\drivers\dma\idxd/idxd_internal.h:11: ..\drivers\dma\idxd/idxd_hw_defs.h:46:21: error: expected member name or ';' after declaration specifiers uint16_t __reserved[13]; ~~~~~~~~ ^ 1 error generated. Ironically, __reserved is probably a reserved token. Some drivers that build fine on Windows have structs with a "reserved" field, let's go with this. Fixes: 82147042d062 ("dma/idxd: add datapath structures") Signed-off-by: David Marchand --- drivers/dma/idxd/idxd_hw_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/idxd/idxd_hw_defs.h b/drivers/dma/idxd/idxd_hw_defs.h index 55ca9f7f52..2a219c1312 100644 --- a/drivers/dma/idxd/idxd_hw_defs.h +++ b/drivers/dma/idxd/idxd_hw_defs.h @@ -43,7 +43,7 @@ struct idxd_hw_desc { uint16_t intr_handle; /* completion interrupt handle */ /* remaining 26 bytes are reserved */ - uint16_t __reserved[13]; + uint16_t reserved[13]; } __rte_aligned(64); #define IDXD_COMP_STATUS_INCOMPLETE 0