From patchwork Wed Nov 17 17:01:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Owen Hilyard X-Patchwork-Id: 104484 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 320FAA0C41; Wed, 17 Nov 2021 18:07:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDE3D40687; Wed, 17 Nov 2021 18:07:23 +0100 (CET) Received: from mail-oi1-f225.google.com (mail-oi1-f225.google.com [209.85.167.225]) by mails.dpdk.org (Postfix) with ESMTP id E4DBC40040 for ; Wed, 17 Nov 2021 18:07:22 +0100 (CET) Received: by mail-oi1-f225.google.com with SMTP id bj13so7834957oib.4 for ; Wed, 17 Nov 2021 09:07:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GAsLMSvtcUFChh4PGg3T8wBWnRXv0Z5QvmHnlhnZHuQ=; b=g7hsKXpVa140nJv65V4XPKZNJucui2Z0Vmaf7WuZ3N45eJLLO8pFEaaKtIQi2Pxu0a kIcFaIR4F89/VZB52Qa7RxKR1+k4rz7oFOgWszpylZK9P+K6cdac0W5gLE1nF8bv95Hw cnf6vVqxui4Yyru0g1Oml+eD4cnuQ1Cwx4TsM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GAsLMSvtcUFChh4PGg3T8wBWnRXv0Z5QvmHnlhnZHuQ=; b=jQkJst1VBYaFwKY65G4jAo1yT4vXcz+oZwhrswPCBM4S02GeYCvX8rlrDuw1zJB+KP Zx1/N3EErRAbDtP/RD8VScQczUXOmIURj8pK0n4NHA3+2nUgf0nQ6bw0dYDmpd/VHDZp nyHvNGJxXH0SakyGpBQDq4UKlPucbzW3G84wBD0lD8rqXjGh1w9nrC0GkBAGlPR6n1iy tjjdHY+4cfmrcXUgYeqYdKJ6RJ6xFePIfHliHp+ws6+/vhnIw7luYQmMNOt+3MjXXzDP TL1DLOXtrQM1RmZn1/Nj8GS/yT+hUPpB0O4RIeygazIrJ2hLvb/jIg4vTYEuCZ/Q2iNj 7peg== X-Gm-Message-State: AOAM53330aNoWvwSxl2xJfo49JidOF3Vzon3l7Lvn3EEaND3hVn2ZVh9 gTkJKstZjwLWiSGnh3byl+flYX45yueOjxRLGT9pInBAYvLmYmUQkTTMCXhuIE1CE8BAnGcuium 1dMYQD5avHtoP3ye5lWQPU1v0EOFIUCePkCs1ex3HFPY6mgQ/vmNb238N4Sf10/btyxOFhyCvAg tC2fKi+YLEe36Zpg== X-Google-Smtp-Source: ABdhPJzWgUHunVrgc8Ayj+pSIzkFiHQ+6VvtEygu0vO8bKH5hAf+rgcWQHMKm2grpm99DxNl9qiY9eOWz/zR X-Received: by 2002:a54:4515:: with SMTP id l21mr1102070oil.15.1637168469417; Wed, 17 Nov 2021 09:01:09 -0800 (PST) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id c8sm126178otu.1.2021.11.17.09.01.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Nov 2021 09:01:09 -0800 (PST) X-Relaying-Domain: iol.unh.edu Received: from iol.unh.edu (unknown [IPv6:2606:4100:3880:1257::105d]) by postal.iol.unh.edu (Postfix) with ESMTP id EB5CB605247D; Wed, 17 Nov 2021 12:01:08 -0500 (EST) From: ohilyard@iol.unh.edu To: dts@dpdk.org Cc: lijuan.tu@intel.com, Owen Hilyard Subject: [PATCH v2] framework: Advise against using root passwords Date: Wed, 17 Nov 2021 12:01:07 -0500 Message-Id: <20211117170107.30162-1-ohilyard@iol.unh.edu> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211117162330.25896-1-ohilyard@iol.unh.edu> References: <20211117162330.25896-1-ohilyard@iol.unh.edu> MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org From: Owen Hilyard Added messages to notify the user that a blank password field will use ssh keys, and that using root passwords is insecure. Signed-off-by: Owen Hilyard Acked-by: Juraj Linkeš --- conf/crbs.cfg | 4 ++-- tools/setup.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/conf/crbs.cfg b/conf/crbs.cfg index b6c0a9af..a12e60a4 100644 --- a/conf/crbs.cfg +++ b/conf/crbs.cfg @@ -2,10 +2,10 @@ #[DUT IP] # dut_ip: DUT ip address # dut_user: Login DUT username -# dut_passwd: Login DUT password +# dut_passwd: [INSECURE] Login DUT password, leaving this blank will force using SSH keys # os: operation system type linux or freebsd # tester_ip: Tester ip address -# tester_passwd: Tester password +# tester_passwd: [INSECURE] Tester password, leaving this blank will force using SSH keys # pktgen_group: packet generator group name: ixia/trex/ixia_network # channels: Board channel number # bypass_core0: Whether by pass core0 diff --git a/tools/setup.py b/tools/setup.py index 3873a884..c70730c7 100755 --- a/tools/setup.py +++ b/tools/setup.py @@ -105,7 +105,7 @@ def config_crbs(): passwd_option = {'prompt': 'DUT root password', 'type': 'string', - 'help': 'Please input password of DUT crb', + 'help': '[INSECURE] Please input password of DUT crb (leave blank to use preconfigured SSH keys)', 'default': ''} opt = Option(**passwd_option) dut_pass = opt.parse_input() @@ -120,7 +120,7 @@ def config_crbs(): passwd_option = {'prompt': 'Tester root password', 'type': 'string', - 'help': 'Please input password of Tester crb', + 'help': '[INSECURE] Please input password of Tester crb (leave blank to use preconfigured SSH keys)', 'default': ''} opt = Option(**passwd_option) tester_pass = opt.parse_input()