From patchwork Fri Dec 3 07:54:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Ehrhardt X-Patchwork-Id: 104847 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD913A0548; Fri, 3 Dec 2021 08:54:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC6D84014F; Fri, 3 Dec 2021 08:54:20 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 6B4C240041 for ; Fri, 3 Dec 2021 08:54:19 +0100 (CET) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 46F164003F for ; Fri, 3 Dec 2021 07:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638518059; bh=btuBD8y3q75nPLokDQATYRpJIXLPnVDO5JmvhyjWgns=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=o2MO3yXMgAQfQHB7m9bzkkRvd4Hw4HJYvc7YINNuVyLuCzbJmZSvzp298w9vVjnTN JB7Y9TwTwNMKXpbETasre/JUjmt64WDDnYX+S/LDbmRwXEPMd0z8F2jnvQnfFXZjr3 lYkPJlYpyDiRIkMrszk/+Aqc4Lfmrv97Ldg19oGImRx1D2KpSi/8n3NgHCI3wgRBph 93NT6tiDTVg15rD/igzJLLVL+w/FutjoZBYOM5ui5VVGZpY0vElMoAMbmsAmoRvcaN 7xea6I9yjSmd5lxPWr+SG726OCmRgWslfxHfmcXFCu9WsJfAEiDZ4ApzTn2ObT+1Vm wGVR4tviDVY3g== Received: by mail-ed1-f70.google.com with SMTP id b15-20020aa7c6cf000000b003e7cf0f73daso1791226eds.22 for ; Thu, 02 Dec 2021 23:54:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=btuBD8y3q75nPLokDQATYRpJIXLPnVDO5JmvhyjWgns=; b=UvvTLikSsdqWxX5nm8rJN/Cr4awGjuFDRYCAdwZb4oDqH996w7tqB1YHAHkzDFEvkv hn0yoB1TD5O4i7KJDEqHa27tsTHWa8/3LQSVbdhTOavstPeNQBny/C+/Pni+/rlUrv/p buoFtm6LqQ/ohY7v7xAfRlXor2OdxG97yad2GgTyO+PGG523tAQxv0K1FfEbdCouGbN7 8JA4ck3LyWJ8QbtBsmrqmCUem5owcgaXBIYt35VXtbliRrGZglF2RUhuzmMS+JKXl7SH M1+tLafv6sc53bXeBGIUD9CP1fe1wqgMYBAWCE4QLL3V0qc/wPJeiH9VSRUqWXfpxQ9N QEpQ== X-Gm-Message-State: AOAM531YG+/POXav6oEFYEAXaiZ3LNVDCS/JwHOcYe7qwKea00LHahJx TFjSX/FCou9dlg329T+olSTpS2oEGrMOwHu1FSaxta9FenB8wcWRrGw1EJQVjopz1kWZ1wk4tB3 lVMeMvqbQHrBURaLfHsxl X-Received: by 2002:a50:955c:: with SMTP id v28mr24937560eda.293.1638518058809; Thu, 02 Dec 2021 23:54:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJxPjHiplE5l77W/rplCZfh6txR3zoh+tMPtINAKHW6/vVSfiusEKjDikOTXeR2yqHSMsUtGjA== X-Received: by 2002:a50:955c:: with SMTP id v28mr24937528eda.293.1638518058592; Thu, 02 Dec 2021 23:54:18 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id gt18sm1430632ejc.46.2021.12.02.23.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Dec 2021 23:54:18 -0800 (PST) From: christian.ehrhardt@canonical.com To: dev , Thomas Monjalon , Luca Boccassi , Xueming Li , David Marchand , Kevin Traynor , Maxime Coquelin Cc: Christian Ehrhardt Subject: [PATCH v2 1/2] devtools: don't include headline "fix" in backports Date: Fri, 3 Dec 2021 08:54:14 +0100 Message-Id: <20211203075415.4083502-1-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Christian Ehrhardt It was important in the past to select anything with "fix" in the headline, but recently more often created false positives and work to sort tihngs out than identifying many helpful patches. The community and processes aroudn DPDK matured enough that developers (rightfully) expect to rely on "Fixes:" and "stable@" marking for backprots. Therefore do no more include patches that just include the word fix in the backport candidate list. Signed-off-by: Christian Ehrhardt Acked-by: Luca Boccassi Acked-by: Kevin Traynor Acked-by: Xueming Li --- devtools/git-log-fixes.sh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh index 210c8dcf25..27ec9088d4 100755 --- a/devtools/git-log-fixes.sh +++ b/devtools/git-log-fixes.sh @@ -13,7 +13,7 @@ print_help () cat <<- END_OF_HELP Find fixes to backport on previous versions. - It looks for the word "fix" in the headline or a tag "Fixes" or "Reverts". + It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.org. The oldest bug origin is printed as well as partially fixed versions. END_OF_HELP } @@ -109,8 +109,7 @@ while read id headline ; do origins=$(origin_filter $id) stable=$(stable_tag $id) fixes=$(fixes_tag $id) - [ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || \ - echo "$headline" | grep -q fix || continue + [ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || continue version=$(commit_version $id) if [ -n "$origins" ] ; then origver="$(origin_version $origins)" From patchwork Fri Dec 3 07:54:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Ehrhardt X-Patchwork-Id: 104848 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08CACA0548; Fri, 3 Dec 2021 08:54:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B21CC42701; Fri, 3 Dec 2021 08:54:22 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 1FEAE406FF for ; Fri, 3 Dec 2021 08:54:21 +0100 (CET) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id F04EB3F1F8 for ; Fri, 3 Dec 2021 07:54:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638518060; bh=bHGHQCQ7vyUumUAa0N8dTIcMvGwLtsTurdnmisV49KA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=TFE9mCinBhyVKA3azBtD5BJvePQcz75awSKWNA+UsehXOKmPeNC0awwKWGrr3BeCC fnI2LwqaKFQSq0BiUN8fI77Ow2WXtCu09usV+kyqFUzUucaPiUMe+0Tz6EwS3MbFXA raz3EKKgREt4iih15QkgNF0IMttYx1Uj4oQYs0SjqDW43dGcKPhjr3Rv9bkC0McwhL 3KWWRTDL5sdJyGBUGSSW4zb1KavrA0pc3sgybEBxIId6C1zCXTkAkCsLa8yDtWVo2w XuF5tqxTk5aAVSnK0gmqVtr6mWdyHUyTGTZnL4FF2akI6rOq1yCVJX0aAapFzZHMmJ ejF4FPNaDmeOg== Received: by mail-ed1-f69.google.com with SMTP id c1-20020aa7c741000000b003e7bf1da4bcso1787978eds.21 for ; Thu, 02 Dec 2021 23:54:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bHGHQCQ7vyUumUAa0N8dTIcMvGwLtsTurdnmisV49KA=; b=x4QZwnGgMMTl4Oqm3mZ2r+GjKOspXOdVhkccECZfneYYKZKlneWg9zzqjerb6mygg9 IfPYnvmOFfA6Q+dNdgAJWKqUdMJj3WH6V1uk+erTU0CAphXwAB4ZdEzf8PMiYN338E/3 PPU1lCc5HB9sHCX3Z6kLOjlVUJhD9Wt2GQ6wzotNrBj7JiX++ZjiroQkuSVVkzstotiN AqihMcBuwphognD7kDIsIbfWimRHtcRpIy39qgQQbkjOgURLu4LhmjTSxFeV5SEECYkJ xT2M+zV3JvY26X8Kgfia2g/vMWg2n6Pjx1WByzwAaaIYRYIuU2XMXhzAGCIHfG6joa+3 t1Vw== X-Gm-Message-State: AOAM531GLoXLpXAiMpch1MBmZpI83ftCw8KLzBW3Ja9UewyCyODAUrgz A59/zeiJnnHdCkB+76SppdkO66QdOQTqCZvR2PYA73QJAPHjHFUXCoj/gOzSUNOWzUpM20UJWM8 XpkDMYNzqCPmEFKtb379m X-Received: by 2002:a17:906:5653:: with SMTP id v19mr21420614ejr.360.1638518059939; Thu, 02 Dec 2021 23:54:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJz7SOv0qvR61WDIrCKEdb95CqVtjFwzPQs8XqcgUYa+JeeX/Y+X8RR0BpVG04eUUaZO4X+izg== X-Received: by 2002:a17:906:5653:: with SMTP id v19mr21420591ejr.360.1638518059798; Thu, 02 Dec 2021 23:54:19 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4ad]) by smtp.gmail.com with ESMTPSA id gt18sm1430632ejc.46.2021.12.02.23.54.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Dec 2021 23:54:19 -0800 (PST) From: christian.ehrhardt@canonical.com To: dev , Thomas Monjalon , Luca Boccassi , Xueming Li , David Marchand , Kevin Traynor , Maxime Coquelin Cc: Christian Ehrhardt Subject: [PATCH v2 2/2] devtools: report commit id on partial fixes Date: Fri, 3 Dec 2021 08:54:15 +0100 Message-Id: <20211203075415.4083502-2-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211203075415.4083502-1-christian.ehrhardt@canonical.com> References: <20211203075415.4083502-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Christian Ehrhardt The candidate list for backports lists partial fixes like: "(21.02 (partially fixed in 21.08))" That is useful to identify fixes menat for later releases, but indirectly applying to older ones as well. While the devscript has no access to the stable tree to fully check if the respective interim commit is present there, reporting the commit id will still help to check it later - because only if the interim commit id is in the stable tree, then also the new fix is a real candidate for backporting. The above would become "(21.02 (partially fixed in c30751afc360 @ 21.08))" Signed-off-by: Christian Ehrhardt Acked-by: Luca Boccassi Acked-by: Kevin Traynor Acked-by: Xueming Li --- devtools/git-log-fixes.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh index 27ec9088d4..a1b548948a 100755 --- a/devtools/git-log-fixes.sh +++ b/devtools/git-log-fixes.sh @@ -76,7 +76,7 @@ origin_version () # ... # look chained fix of fix recursively local rootver="$(origin_version $roothashes)" [ -n "$rootver" ] || continue - echo "$rootver (partially fixed in $origver)" + echo "$rootver (partially fixed in $origin @ $origver)" else echo "$origver" fi