From patchwork Mon Jan 24 00:03:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106240 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CF3AA04A6; Mon, 24 Jan 2022 01:05:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1417427AF; Mon, 24 Jan 2022 01:05:25 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 62FDB40040 for ; Mon, 24 Jan 2022 01:05:23 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id c9so13905876plg.11 for ; Sun, 23 Jan 2022 16:05:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lITO3Kqqs+aJDmQXmNqdZndLVIM4kiX6U7jq5x2Qwgc=; b=EOHdMVYMsbn6ap0AslbU8ne2uWLq+K9Nb2W5sd3sQOVeARbRrK6iRTfvFmUyMFi6NM 6qLz10IFNDQiBjl42E1SgFLPaEGZ8Ts9VshIQgehxz7NEHNjqMBbsAZi1OhMAtP/jpxx HVn/QfG2L4ENz1GXTTgRlvRtB55UzQxxbWNVVux41jDD3zdsrUtnGoinu6VOq+F8Y8qi ytpuMkUC+0ON8Ty6ae8n6DPfKy30TMMtsyuZvL4NxIjhBG3IEpP2lJ9wnHKQE/h7tfQ1 NqAQfSmxcJmGJkN6Kc8hf6w357VZYklOXrzyzbGc5/dAPKlWzciSP6qv7AOm8pwRs11F ETKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lITO3Kqqs+aJDmQXmNqdZndLVIM4kiX6U7jq5x2Qwgc=; b=5bvYg7HxnmqWByql+NY8PGZEQMg/hE1S+DIG6WuyhB8U6eGgSrlhg8KD5HB7WHB/4N 4Sl8fVjAts4TticgTDjyr7HH1RKv9S+EROxuC+hZ3DaBzmn1Xa9WsKo6NdrKqliC6xpU 6kcWSWrDAlWgJWWGjxGH+JeTDByxvWOEImDBpiu20/YPtoOrpLGGP/r7RcNGaYjj8WOy Fc71g1+ff+DPN1URYq5ELFoVFrufAnu0ogBnLSCVCruEC4OAdN8UVN53DcqWe15o9d8q nZLl3JayIO5untKVkfpPSPX7YXXGGHTXCGry2btOJrgUZBZ75NeXcJQtJmeMejQRtxa0 SXWA== X-Gm-Message-State: AOAM532c9ZLBrGr5xTnmw+TxXoBAyVA4JRhvl1RuMpq3mi5YnZVZvzey mJa+FMrxb6kcjLIVrGhxrwQTTEkRQ/ZJ1Q== X-Google-Smtp-Source: ABdhPJySqdU4whKgC/pqWH93q0F12el9SXaDti4Jh1sUaN5LbE9t/nwqwQ/svp9ojzB/Tz+D1VaaAg== X-Received: by 2002:a17:90b:1909:: with SMTP id mp9mr6802970pjb.53.1642982722356; Sun, 23 Jan 2022 16:05:22 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:21 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 01/82] devtools/cocci: add script to fix unnecessary null checks Date: Sun, 23 Jan 2022 16:03:57 -0800 Message-Id: <20220124000518.319850-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This script is based on the idea of the nullfree script in the Linux kernel. It finds cases where a check for null pointer is done, but is unneccessary because the function already handles NULL pointer. Basic example: if (x->buf) rte_free(x->buf); can be reduced to: rte_free(x->buf); Signed-off-by: Stephen Hemminger --- devtools/cocci/nullfree.cocci | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 devtools/cocci/nullfree.cocci diff --git a/devtools/cocci/nullfree.cocci b/devtools/cocci/nullfree.cocci new file mode 100644 index 000000000000..363b6149ac28 --- /dev/null +++ b/devtools/cocci/nullfree.cocci @@ -0,0 +1,33 @@ +// +// Remove unnecessary NULL pointer checks before free functions +// All these functions work like libc free which allows +// free(NULL) as a no-op. +// +@@ +expression E; +@@ +( +- if (E != NULL) free(E); ++ free(E); +| +- if (E != NULL) rte_bitmap_free(E); ++ rte_bitmap_free(E); +| +- if (E != NULL) rte_free(E); ++ rte_free(E); +| +- if (E != NULL) rte_hash_free(E); ++ rte_hash_free(E); +| +- if (E != NULL) rte_ring_free(E); ++ rte_ring_free(E); +| +- if (E != NULL) rte_pktmbuf_free(E); ++ rte_pktmbuf_free(E); +| +- if (E != NULL) rte_mempool_free(E); ++ rte_mempool_free(E); +| +- if (E != NULL) rte_kvargs_free(E); ++ rte_kvargs_free(E); +) From patchwork Mon Jan 24 00:03:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106241 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4D2CA04A6; Mon, 24 Jan 2022 01:05:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C2D2427B8; Mon, 24 Jan 2022 01:05:26 +0100 (CET) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id 75A8740040 for ; Mon, 24 Jan 2022 01:05:24 +0100 (CET) Received: by mail-pj1-f43.google.com with SMTP id s61-20020a17090a69c300b001b4d0427ea2so18757874pjj.4 for ; Sun, 23 Jan 2022 16:05:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TNFTY4lice/dZPTBYg9Avv4Lr9A8xdw/ptuoLV9oUuo=; b=WCno3oN6jWVoA2MTmqLEMukEXE/TbbB+rSIzazHhasoToTBO+cVeau8PLm8ZwVF/dQ 99atH59YaiF7PL1ojgNuQXrLndIRYz/c8CrV+SmAafYdle03IIxAhbQVXAgSsp7WO3V2 nh6rSR1ELr9ruQOHNm+FYX28UHKb6QUqEjOF30vvyS/WxnYi39LlWfNH7A1Sqn6V/vD6 /xayUxoVeBG78/FWN3MEy5Qbbb32NLGfb/6KxwPmrMb4TOqLxbu+4LIhpbNZiJSLGaWb sz72CBsfvPmuANl9M6AG17jDg9y86G3NAs8ziA/r3WXDLwUwOCRhyzefncCRW3+urrWo CnnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TNFTY4lice/dZPTBYg9Avv4Lr9A8xdw/ptuoLV9oUuo=; b=aFIaK+eTAAPYpq6IiWezj3W2oEEG8n55NOab3bVdmhOzIPl1Ec60nn2jcefN+XV3tF 73XqACXmzU2bmtaXuFHfHgXVUPRNsxZnp5GgnSF7GD6wDj2+IEshvgq/3qLyX9YjLQAv eE2t9aw4Fs2ZU47AZpwA6ucMvUJ38lKHOiZ9tDe8Oq57Q51GRLdj9iNhU/Kddq+5Rcqy 1K4sEJFN66UBbUcVMfNcuJEF0vdEa0ZnqYLMkXcSDo9+SyVfHDg5V38RP0vo07TA68I+ U6QmnN2NA9UnEHlyPyNObDsaTvXGu2zCtzFZtb/7FhrqrWRRBzEJwMPxXSw08XNMmx+O emVg== X-Gm-Message-State: AOAM531MLot5fZ3sBjIKtaZ09h+N83Y49+4Ds+49O0PnABVr2yL63bD+ mW0FXDq48di1pHPWXIquhny9Yclz5cau5A== X-Google-Smtp-Source: ABdhPJw1cLLJ/PRgXz8Hzd2Lvr+nMIklXUWA7f+HOBXbh3dzLy647wSxoe57wUKd9mPnVHbmzeAh4A== X-Received: by 2002:a17:90a:d596:: with SMTP id v22mr10723297pju.87.1642982723439; Sun, 23 Jan 2022 16:05:23 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:22 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Anatoly Burakov , Jerin Jacob , Sunil Kumar Kori , Bruce Richardson Subject: [PATCH 02/82] eal: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:03:58 -0800 Message-Id: <20220124000518.319850-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Functions like free() already handle NULL pointer so the checks here are not necessary. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_devargs.c | 6 ++---- lib/eal/common/eal_common_memzone.c | 3 +-- lib/eal/common/eal_common_options.c | 9 +++------ lib/eal/common/eal_common_trace_ctf.c | 6 ++---- lib/eal/freebsd/eal.c | 4 +--- lib/eal/linux/eal.c | 10 +++------- 6 files changed, 12 insertions(+), 26 deletions(-) diff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c index 8c7650cf6c27..69004b0a2d2f 100644 --- a/lib/eal/common/eal_common_devargs.c +++ b/lib/eal/common/eal_common_devargs.c @@ -161,8 +161,7 @@ rte_devargs_layers_parse(struct rte_devargs *devargs, get_out: for (i = 0; i < RTE_DIM(layers); i++) { - if (layers[i].kvlist) - rte_kvargs_free(layers[i].kvlist); + rte_kvargs_free(layers[i].kvlist); } if (ret != 0) { if (allocated_data) { @@ -285,8 +284,7 @@ rte_devargs_reset(struct rte_devargs *da) { if (da == NULL) return; - if (da->data) - free(da->data); + free(da->data); da->data = NULL; } diff --git a/lib/eal/common/eal_common_memzone.c b/lib/eal/common/eal_common_memzone.c index ecde9441ee90..9a0c5309ac7e 100644 --- a/lib/eal/common/eal_common_memzone.c +++ b/lib/eal/common/eal_common_memzone.c @@ -300,8 +300,7 @@ rte_memzone_free(const struct rte_memzone *mz) rte_rwlock_write_unlock(&mcfg->mlock); - if (addr != NULL) - rte_free(addr); + rte_free(addr); rte_eal_trace_memzone_free(name, addr, ret); return ret; diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c index 1cfdd75f3b79..09b7b17ffa06 100644 --- a/lib/eal/common/eal_common_options.c +++ b/lib/eal/common/eal_common_options.c @@ -1962,12 +1962,9 @@ compute_ctrl_threads_cpuset(struct internal_config *internal_cfg) int eal_cleanup_config(struct internal_config *internal_cfg) { - if (internal_cfg->hugefile_prefix != NULL) - free(internal_cfg->hugefile_prefix); - if (internal_cfg->hugepage_dir != NULL) - free(internal_cfg->hugepage_dir); - if (internal_cfg->user_mbuf_pool_ops_name != NULL) - free(internal_cfg->user_mbuf_pool_ops_name); + free(internal_cfg->hugefile_prefix); + free(internal_cfg->hugepage_dir); + free(internal_cfg->user_mbuf_pool_ops_name); return 0; } diff --git a/lib/eal/common/eal_common_trace_ctf.c b/lib/eal/common/eal_common_trace_ctf.c index 33e419aac7fb..3b83bcdf57fd 100644 --- a/lib/eal/common/eal_common_trace_ctf.c +++ b/lib/eal/common/eal_common_trace_ctf.c @@ -52,8 +52,7 @@ meta_copy(char **meta, int *offset, char *str, int rc) return rc; free_str: - if (str) - free(str); + free(str); return -ENOMEM; } @@ -291,8 +290,7 @@ trace_metadata_create(void) return 0; fail: - if (meta) - free(meta); + free(meta); return -EBADF; } diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index a1cd2462db1b..00ba32f1d664 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -544,9 +544,7 @@ eal_parse_args(int argc, char **argv) RTE_LOG(ERR, EAL, "Could not store mbuf pool ops name\n"); else { /* free old ops name */ - if (internal_conf->user_mbuf_pool_ops_name != - NULL) - free(internal_conf->user_mbuf_pool_ops_name); + free(internal_conf->user_mbuf_pool_ops_name); internal_conf->user_mbuf_pool_ops_name = ops_name; diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 60b49248388e..f8e39b7e4277 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -730,8 +730,7 @@ eal_parse_args(int argc, char **argv) RTE_LOG(ERR, EAL, "Could not store hugepage directory\n"); else { /* free old hugepage dir */ - if (internal_conf->hugepage_dir != NULL) - free(internal_conf->hugepage_dir); + free(internal_conf->hugepage_dir); internal_conf->hugepage_dir = hdir; } break; @@ -743,8 +742,7 @@ eal_parse_args(int argc, char **argv) RTE_LOG(ERR, EAL, "Could not store file prefix\n"); else { /* free old prefix */ - if (internal_conf->hugefile_prefix != NULL) - free(internal_conf->hugefile_prefix); + free(internal_conf->hugefile_prefix); internal_conf->hugefile_prefix = prefix; } break; @@ -804,9 +802,7 @@ eal_parse_args(int argc, char **argv) RTE_LOG(ERR, EAL, "Could not store mbuf pool ops name\n"); else { /* free old ops name */ - if (internal_conf->user_mbuf_pool_ops_name != - NULL) - free(internal_conf->user_mbuf_pool_ops_name); + free(internal_conf->user_mbuf_pool_ops_name); internal_conf->user_mbuf_pool_ops_name = ops_name; From patchwork Mon Jan 24 00:03:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106242 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C06EA04A6; Mon, 24 Jan 2022 01:05:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B18A427C4; Mon, 24 Jan 2022 01:05:28 +0100 (CET) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 846CC427AB for ; Mon, 24 Jan 2022 01:05:25 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id d5so12234348pjk.5 for ; Sun, 23 Jan 2022 16:05:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OgIanIgFtHcdHoFnpNWsa8XIcvgA8wPsembFoHuQzfg=; b=qkrmeDnhk44ygwVEF1zMOau1P8ij0Mw/12WsagZrmkf5tlI/LDMODRk3Wh6jfg7SGH 6b8iEI7ElK4VnTMNQjmYERRA5z0F+i3XuAmRylbu8NZ0NE5i6bq+rfzprExh/wjDlMjg fIeCV5b2KPyCA6D5p6ij2c9DbWdwF8vw44s4WNz2U+JigG1+2gHyY60NnpIHXT/tva9O cHqAc7UdmFjQIgAzoiJ8rWnyESdIUbqMDQ33vh1zTi7MPqzCGyy4FGPUykg1+nqTMiOQ iswFFPMn1h7W8eGBWFsnZBvIiwZYmwbmsrMQlITLe5XIdUH9goJ78/oNejtTfQ4lC+Yw GMEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OgIanIgFtHcdHoFnpNWsa8XIcvgA8wPsembFoHuQzfg=; b=lJLocnTmW6iT3LPD+/v2d7xJ1zghWXbL9GtDWvIy/4KVNZFM9fvlDddVe7E6vyJkY0 ARephL4VMTcJWDbNhrhowEMX5hkog7XyX7VyhP8XcGSLXochTFzOMgnBOHqlrLYtRd9M QU5NjHB6SdTyZl7hpXjtQzDhHT13d1oar5ft3u1UvHPI2XCn07/lvN6WWPVXP+TowBM1 heVZoS8KKlysT7t7KssrR76CKoyXTNVWgTrB4ivA7dnsghthfoQL6IgWt4oYlgk9EDyl 2d2HksEDbaQhpbG2NCnIrqyPEtSVW4g5IqvoRHp1c7ygG6xJ6kwqfLSH8VJtZJHprpVT mZbQ== X-Gm-Message-State: AOAM53331BAXelxqgzwB43pVIeUt+5Cn8SSTo3ix8RrJOQqK7F2luAvR W3zEGEa7/cyLDnumAwcj1hxeBb6NxKYLiQ== X-Google-Smtp-Source: ABdhPJzv0A2WRnc2x1t6AGWOMrEY9TMqoYeA7Or4wzPQYqozc5P5EsL5vInvhGu2bIhkh1b4jpXDXA== X-Received: by 2002:a17:902:a5c6:b0:149:c926:7c31 with SMTP id t6-20020a170902a5c600b00149c9267c31mr12439719plq.141.1642982724528; Sun, 23 Jan 2022 16:05:24 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:24 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Subject: [PATCH 03/82] eal/windows: remove unnecessary NULL checks before free Date: Sun, 23 Jan 2022 16:03:59 -0800 Message-Id: <20220124000518.319850-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Calling free/rte_free/rte_mempool_free,... with NULL pointer is allowed; so remove unnecessary NULL checks. Signed-off-by: Stephen Hemminger --- lib/eal/windows/eal_alarm.c | 3 +-- lib/eal/windows/eal_memory.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/windows/eal_alarm.c b/lib/eal/windows/eal_alarm.c index 103c1f909da3..51fe752c16d4 100644 --- a/lib/eal/windows/eal_alarm.c +++ b/lib/eal/windows/eal_alarm.c @@ -162,8 +162,7 @@ rte_eal_alarm_set(uint64_t us, rte_eal_alarm_callback cb_fn, void *cb_arg) fail: if (timer != NULL) CloseHandle(timer); - if (ap != NULL) - free(ap); + free(ap); exit: rte_eal_trace_alarm_set(us, cb_fn, cb_arg, ret); diff --git a/lib/eal/windows/eal_memory.c b/lib/eal/windows/eal_memory.c index 2fd37d97085e..215d768e2c57 100644 --- a/lib/eal/windows/eal_memory.c +++ b/lib/eal/windows/eal_memory.c @@ -190,8 +190,7 @@ eal_mem_virt2iova_init(void) ret = 0; exit: - if (detail != NULL) - free(detail); + free(detail); if (list != INVALID_HANDLE_VALUE) SetupDiDestroyDeviceInfoList(list); From patchwork Mon Jan 24 00:04:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106243 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8130A04A6; Mon, 24 Jan 2022 01:05:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 562D9427CA; Mon, 24 Jan 2022 01:05:29 +0100 (CET) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id 8DFAB427BB for ; Mon, 24 Jan 2022 01:05:26 +0100 (CET) Received: by mail-pg1-f179.google.com with SMTP id h23so13608942pgk.11 for ; Sun, 23 Jan 2022 16:05:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZF5DH4WTjbSkV2F/G0r3/VYP0G2BxRN5oK/2+qTsXtY=; b=hM2xwqPqbzCTds31CbfEiY7MmhoPr5GFnbPlqRhzY9QFIybSZcEL5kppES+N9UGSsk eezrrSRq2zeadmNMwT9y9fRnfLXnchUt35q8SotJzmIzoxy9ZVGndwz8fKu39DwzAPRp Gz4MczYrjJQKtK5sRG9Pc40O/jzIrBzGJwWOZtts0UAAMMeZWOzWsPUy7W2U6AHW1Nl0 stPZ6lBMyeJzeaVva9v2j7N7ySgWHTZQWjKvexOBZ0izfhZl7ULVsq7Bnkqz4hk15IVl oAEOPqZEIRjlbNCySJBd6UY4Fh1HAx8ogxpoy0Kj52D9eTCnn2r0fkKCBTbRjL/DkSAl 7snA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZF5DH4WTjbSkV2F/G0r3/VYP0G2BxRN5oK/2+qTsXtY=; b=XNpktKzDyEhPIB/LUu6uXnRPiPYsLJg398ZbbZuR0o8l8/AXXOGgNNn0gN3JveJAAd YgKBz/8AHBYow74bBy7hLYyfjufw4dpyo+qXF5wvzRyw1tMYfZh0XhU5zcyk+KQvJj1g g/nnqDUS95nLMVR2LAPjTvVzcipzcroSSKstL7juo2WLu13bL7Uq0JfcyOxRDAEd3M1d C20kJFQvU84QI0SghueoFXrZ1/piRU49W7byuulpJYr78/HIWlKrUSehXHqdoU6pnWwC vFdLKV8hiyF8dzvbgbt07hvGyHwFozT2zlM89AU25zG7M6pONurzI+Oh3bfmgM8edjQR ++Wg== X-Gm-Message-State: AOAM532L02FwEhYSe8NhB04RVeCqyoWG+iPwILK2h9ORR+YnjZNQsjP3 qdYHPirrh4Lrt7Q1BabgHVo027EPBtd9iA== X-Google-Smtp-Source: ABdhPJyce6WDf4mN1HhEjlt41XnYA8ehGtF2tsd66iiBCNOaWXkQMYnHarneD3AObrzUfH4aFthkUg== X-Received: by 2002:a63:b30b:: with SMTP id i11mr10106746pgf.457.1642982725566; Sun, 23 Jan 2022 16:05:25 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:25 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Marko Kovacevic Subject: [PATCH 04/82] examples/fips_validation: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:00 -0800 Message-Id: <20220124000518.319850-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- examples/fips_validation/fips_dev_self_test.c | 18 ++++------ examples/fips_validation/fips_validation.c | 3 +- examples/fips_validation/main.c | 36 +++++++------------ 3 files changed, 19 insertions(+), 38 deletions(-) diff --git a/examples/fips_validation/fips_dev_self_test.c b/examples/fips_validation/fips_dev_self_test.c index b4eab05a9851..076e9de099c0 100644 --- a/examples/fips_validation/fips_dev_self_test.c +++ b/examples/fips_validation/fips_dev_self_test.c @@ -1396,8 +1396,7 @@ check_aead_result(struct rte_crypto_op *op, if (!mbuf) return -1; - if (op->sym->aead.aad.data) - rte_free(op->sym->aead.aad.data); + rte_free(op->sym->aead.aad.data); if (dir == self_test_dir_enc_auth_gen) { src = vec->output.data; @@ -1523,18 +1522,13 @@ static void fips_dev_auto_test_uninit(uint8_t dev_id, struct fips_dev_auto_test_env *env) { - if (env->mbuf) - rte_pktmbuf_free(env->mbuf); + rte_pktmbuf_free(env->mbuf); if (env->op) rte_crypto_op_free(env->op); - if (env->mpool) - rte_mempool_free(env->mpool); - if (env->op_pool) - rte_mempool_free(env->op_pool); - if (env->sess_pool) - rte_mempool_free(env->sess_pool); - if (env->sess_priv_pool) - rte_mempool_free(env->sess_priv_pool); + rte_mempool_free(env->mpool); + rte_mempool_free(env->op_pool); + rte_mempool_free(env->sess_pool); + rte_mempool_free(env->sess_priv_pool); rte_cryptodev_stop(dev_id); } diff --git a/examples/fips_validation/fips_validation.c b/examples/fips_validation/fips_validation.c index 52a7bf952d46..94253eaee8bf 100644 --- a/examples/fips_validation/fips_validation.c +++ b/examples/fips_validation/fips_validation.c @@ -344,8 +344,7 @@ fips_test_clear(void) fclose(info.fp_rd); if (info.fp_wr) fclose(info.fp_wr); - if (info.one_line_text) - free(info.one_line_text); + free(info.one_line_text); if (info.nb_vec_lines) { uint32_t i; diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c index dc40bffe7d97..e06ae37567fd 100644 --- a/examples/fips_validation/main.c +++ b/examples/fips_validation/main.c @@ -143,12 +143,9 @@ cryptodev_fips_validate_app_int(void) error_exit: rte_mempool_free(env.mpool); - if (env.sess_mpool) - rte_mempool_free(env.sess_mpool); - if (env.sess_priv_mpool) - rte_mempool_free(env.sess_priv_mpool); - if (env.op_pool) - rte_mempool_free(env.op_pool); + rte_mempool_free(env.sess_mpool); + rte_mempool_free(env.sess_priv_mpool); + rte_mempool_free(env.op_pool); return ret; } @@ -523,8 +520,7 @@ prepare_data_mbufs(struct fips_val *val) uint16_t nb_seg; int ret = 0; - if (env.mbuf) - rte_pktmbuf_free(env.mbuf); + rte_pktmbuf_free(env.mbuf); if (total_len > RTE_MBUF_MAX_NB_SEGS) { RTE_LOG(ERR, USER1, "Data len %u too big\n", total_len); @@ -598,8 +594,7 @@ prepare_data_mbufs(struct fips_val *val) return 0; error_exit: - if (head) - rte_pktmbuf_free(head); + rte_pktmbuf_free(head); return ret; } @@ -656,8 +651,7 @@ prepare_auth_op(void) if (ret < 0) return ret; - if (env.digest) - rte_free(env.digest); + rte_free(env.digest); env.digest = rte_zmalloc(NULL, vec.cipher_auth.digest.len, RTE_CACHE_LINE_SIZE); @@ -705,8 +699,7 @@ prepare_aead_op(void) if (ret < 0) return ret; - if (env.digest) - rte_free(env.digest); + rte_free(env.digest); env.digest = rte_zmalloc(NULL, vec.aead.digest.len, RTE_CACHE_LINE_SIZE); if (!env.digest) { @@ -1430,8 +1423,7 @@ fips_mct_tdes_test(void) } } - if (val.val) - free(val.val); + free(val.val); return 0; } @@ -1510,8 +1502,7 @@ fips_mct_aes_ecb_test(void) } } - if (val.val) - free(val.val); + free(val.val); return 0; } @@ -1619,8 +1610,7 @@ fips_mct_aes_test(void) memcpy(vec.iv.val, val.val, AES_BLOCK_SIZE); } - if (val.val) - free(val.val); + free(val.val); return 0; } @@ -1706,8 +1696,7 @@ fips_mct_sha_test(void) rte_free(vec.pt.val); - if (val.val) - free(val.val); + free(val.val); return 0; } @@ -1851,8 +1840,7 @@ fips_test_one_file(void) rte_free(env.digest); env.digest = NULL; } - if (env.mbuf) - rte_pktmbuf_free(env.mbuf); + rte_pktmbuf_free(env.mbuf); return ret; } From patchwork Mon Jan 24 00:04:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106244 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 250B9A04A6; Mon, 24 Jan 2022 01:05:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67669427CE; Mon, 24 Jan 2022 01:05:30 +0100 (CET) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id 94624427C0 for ; Mon, 24 Jan 2022 01:05:27 +0100 (CET) Received: by mail-pg1-f171.google.com with SMTP id z131so2613283pgz.12 for ; Sun, 23 Jan 2022 16:05:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m9Fhm5t+AxyhwGNqtgJo7EQpKlSWzjNFbTcX1SJZ86I=; b=pLWv0c9sT2qNA+s3P88Lq9ExeY10VBr6Tw4THLP6o5Xw/9KZ+WnAmWSQhMx5m4dxUf oz2MpxjsrpGqVg/NeCIzzNoOkvPU61WxNg3HCXTMOvhYtAA7Pw2LysR0aaKxJlIIZ5YG D2SmCYSNztZ5BvZUZ6y75jVJgnvh4UoMjM7Zu+8idHHnKj4oobrc5AYLYDymLLnpg9xv pP/SqkdyGATWzKxhkpVXtg1IvctPnzwQCxP4MOhl8d5IHoqK7JS2HxiiNAqSwB/W7rZI BZHGF1XPqkFfAbAP8PXLcKn+OL4HDnVR5gHNxylYwEQOVvY75njDUWa9uk88XfGL6nGH OEZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m9Fhm5t+AxyhwGNqtgJo7EQpKlSWzjNFbTcX1SJZ86I=; b=DW9ilkrYWyqZU/c47c/xNwwxA4GIsv5JsNs1e+ZtFKoI1MsPhiWYPon55rQ5/Milax ayAOLPKY5kuWYvxtY8naz+BuissFBsCWC27WVRb/f/bDSePX2MjVT0Gh9LU3ymSVKt/i khXfByKiqsyWWEJUXwKp5kk0v/JhO/ODKm5ms/VLvGQoCrnSbZKAc08VEnR45uwrigU5 kvx4+VLv2iNFiDNBgV2AkGxZH6PZjD7b9etUWnvPg05bfSEKwN3jo1Z2QMsELNTZiDwa sEZfgPMs3Nct56GRTz292zAEcQFSCHV8edECvA4925epkpzxpPxforv3KQi1k4lcnR7+ 35Ow== X-Gm-Message-State: AOAM533t2IJSOxZbQ6gS3pCSOWoXaBbw+kzBGvK18GQocdM0eQGe6WBM WUJvJU57Zyta5MLSRAMhEaAW2/cCzOqd/g== X-Google-Smtp-Source: ABdhPJzzO5hjrtgxPHlLX0NiWDg9zmbeIE3FxvYFmIcnnMXEuo5iZnotc0992pESPieQU8YBKgN4oQ== X-Received: by 2002:a63:4e58:: with SMTP id o24mr9907609pgl.525.1642982726607; Sun, 23 Jan 2022 16:05:26 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:26 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Cristian Dumitrescu Subject: [PATCH 05/82] examples/ip_pipeline: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:01 -0800 Message-Id: <20220124000518.319850-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- examples/ip_pipeline/cli.c | 12 ++++-------- examples/ip_pipeline/cryptodev.c | 6 ++---- examples/ip_pipeline/thread.c | 6 ++---- 3 files changed, 8 insertions(+), 16 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index 0c372675a919..c918f30e06f3 100644 --- a/examples/ip_pipeline/cli.c +++ b/examples/ip_pipeline/cli.c @@ -3773,10 +3773,8 @@ parse_free_sym_crypto_param_data(struct rte_table_action_sym_crypto_params *p) switch (xform[i]->type) { case RTE_CRYPTO_SYM_XFORM_CIPHER: - if (p->cipher_auth.cipher_iv.val) - free(p->cipher_auth.cipher_iv.val); - if (p->cipher_auth.cipher_iv_update.val) - free(p->cipher_auth.cipher_iv_update.val); + free(p->cipher_auth.cipher_iv.val); + free(p->cipher_auth.cipher_iv_update.val); break; case RTE_CRYPTO_SYM_XFORM_AUTH: if (p->cipher_auth.auth_iv.val) @@ -3785,10 +3783,8 @@ parse_free_sym_crypto_param_data(struct rte_table_action_sym_crypto_params *p) free(p->cipher_auth.cipher_iv_update.val); break; case RTE_CRYPTO_SYM_XFORM_AEAD: - if (p->aead.iv.val) - free(p->aead.iv.val); - if (p->aead.aad.val) - free(p->aead.aad.val); + free(p->aead.iv.val); + free(p->aead.aad.val); break; default: continue; diff --git a/examples/ip_pipeline/cryptodev.c b/examples/ip_pipeline/cryptodev.c index 9997d974563f..cd0f9c3d4eac 100644 --- a/examples/ip_pipeline/cryptodev.c +++ b/examples/ip_pipeline/cryptodev.c @@ -151,10 +151,8 @@ cryptodev_create(const char *name, struct cryptodev_params *params) return cryptodev; error_exit: - if (cryptodev->mp_create) - rte_mempool_free(cryptodev->mp_create); - if (cryptodev->mp_init) - rte_mempool_free(cryptodev->mp_init); + rte_mempool_free(cryptodev->mp_create); + rte_mempool_free(cryptodev->mp_init); free(cryptodev); diff --git a/examples/ip_pipeline/thread.c b/examples/ip_pipeline/thread.c index b2e97327052f..82d5f87c384c 100644 --- a/examples/ip_pipeline/thread.c +++ b/examples/ip_pipeline/thread.c @@ -92,11 +92,9 @@ thread_free(void) continue; /* MSGQs */ - if (t->msgq_req) - rte_ring_free(t->msgq_req); + rte_ring_free(t->msgq_req); - if (t->msgq_rsp) - rte_ring_free(t->msgq_rsp); + rte_ring_free(t->msgq_rsp); } } From patchwork Mon Jan 24 00:04:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106245 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EDDFA04A6; Mon, 24 Jan 2022 01:06:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6CB1B427D6; Mon, 24 Jan 2022 01:05:31 +0100 (CET) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 91E1B427C7 for ; Mon, 24 Jan 2022 01:05:28 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id d15-20020a17090a110f00b001b4e7d27474so14837709pja.2 for ; Sun, 23 Jan 2022 16:05:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LthoC/aG80CawrgBqgZJqzxV3JgQQrhY5x+zkNuvJwE=; b=C1oKNPtb27Igm7T4DTkVAsM6JHKtvCV19uwFNiEdJBWVBjBzv+JCUNiKFofV64zrtm AIZLiwt13s+TdS1bLm4y5LjTR28g401Ee/aBgVEJEOY+LopuUfa91W4PijvCaGO63iXQ ONQTwy7bukGDfXmqZ78HlOZGfxAaqAZuCU7308X6ZFoqZ2pI/P5dhmAuZiPX2s9z1lxk mejEyvKMXq58eO7y9vJm8CEbYm8YNZ6YPBw+DVhqa+vlTsPjBI5d/d/Kb9h9AwJojPLZ lCwWPZmpEsZRbB8+ThJYKU/9IYgrOvdpjOtaMpCTav4kKpPZ2JZVfqQKuO4c54A+XLeo xJOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LthoC/aG80CawrgBqgZJqzxV3JgQQrhY5x+zkNuvJwE=; b=gzL9shNwuH3hPZQJdLmvMY+Tv6eWKPpDS+HXrfhCxOmdOv9hqiPZzNerxXYO91ehzj j8DVoMHDL5gLjtXeJlbuxw0IzZaAX91w0qOiwgDWDokST74lIGJlIq1xgQKHTcl8HBe8 g1UlwomjRvwj+UtD/8uQfUo/6CQMZbEZ+2iqHUT9CUAbiB/4sfwICD569alA0qlSukJX pGCnrxcvZhfZh2FeweSWrzxpY7IrB+C3441Il1V7gF684NydhtoTZcl4LyzBcSCWrfSd IzjREPq+Q9JXQrDSV2iHginFcTsJqES5CT8+xUwIqasRASYx0V4zphrVlkfyCQXcJ8Dd chnQ== X-Gm-Message-State: AOAM531uN/qDI1nLNddA7nqrAl+6NLwgz7GIfy70Q0iuVSVGvtYqrb5B QR2wpNm6Y4XEABxuXaGC9Q7kn7gvVseQPQ== X-Google-Smtp-Source: ABdhPJwmQNEz7tXkm2zr+HwcKxj6CRRLDBzq56t7NzIgLzsCALMpWQN/m5/wRnB52kZoxsLE3VImcA== X-Received: by 2002:a17:902:8649:b0:149:f37a:9255 with SMTP id y9-20020a170902864900b00149f37a9255mr12510497plt.116.1642982727627; Sun, 23 Jan 2022 16:05:27 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:27 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Cristian Dumitrescu Subject: [PATCH 06/82] examples/pipeline/thread: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:02 -0800 Message-Id: <20220124000518.319850-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- examples/pipeline/thread.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/examples/pipeline/thread.c b/examples/pipeline/thread.c index bf11e6144b75..5fe7eae00eb6 100644 --- a/examples/pipeline/thread.c +++ b/examples/pipeline/thread.c @@ -89,11 +89,9 @@ thread_free(void) continue; /* MSGQs */ - if (t->msgq_req) - rte_ring_free(t->msgq_req); + rte_ring_free(t->msgq_req); - if (t->msgq_rsp) - rte_ring_free(t->msgq_rsp); + rte_ring_free(t->msgq_rsp); } } From patchwork Mon Jan 24 00:04:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106246 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AD6BA04A6; Mon, 24 Jan 2022 01:06:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D622427DC; Mon, 24 Jan 2022 01:05:32 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id AC207427BC for ; Mon, 24 Jan 2022 01:05:29 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id b1-20020a17090a990100b001b14bd47532so14858989pjp.0 for ; Sun, 23 Jan 2022 16:05:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FX1lbRFpgXCJQC7p1TcjAoI5WAe9NNrSSKSl+pJehBw=; b=oXqxcPU6EAoBODnn9JR4Fv8NewGhIFiEry8teyr/W5jNzfSlrMnCGXpQlg8TzHUrdt NGiSfFPwg5/HynOuDUCgvykE8ITAVVIBwyCdsUNJljD3wpCBZm+YGqPpbBdG24EbySNp AQMwsX7xDyOOhW0JttrlZUQuawk1g3JqesVV0YWYfXpwB+9lqgNzG4Tpy0ugSRCHkuaD p3/mWZmJLV2oiUBD/3NLZwTj2hOv2m3hkLmnRhjhrJR/FqWGc0HPgIgBKHbxDTfp9f1r 6gI+e7efUrJPzqlwISDG+kGV7W8qmA8iBJQjY9YJ+pzmaw6mbE+Tx/KKwmfFlwkfrUdF s3Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FX1lbRFpgXCJQC7p1TcjAoI5WAe9NNrSSKSl+pJehBw=; b=2Bxens+lsm81v1zxRhE+s8+rlTc9AYap3s3PTzpF1q6n06qWmL1pv2fOwvt3A9rMAa I5ty3RWXtpxRCcm7w7gplTIZRDY46l0ZcWxEaKa9vfj4h6CxwcZVBOSWAcItU/oWJmDt KAMt+QLPhAk/DovrzIPukUMQzRUzq9x2BE60n1En+m2debGCanR5kuESwIAc5EEKibdg 1QuKKe9Qb9X5rp/HeYFnnnEAykr8TzB3RIuQljoPIwjMd6CmxTHdPs3vKqd7E1HoceHd vveXJIn7V/MkmOIS0wlACDFlPd7M/EAfPAl8bXfc+Ht9ptc68WZXh7yqLqGX5M5gQQEJ j/SQ== X-Gm-Message-State: AOAM531cPd5oGWtx18TZ+YFuAXhuWCQ9k4Th/Hh1QUo9RH89i68/Rubp bQjGsmb32xMtJDHTJ4/alYxYCHPxmHhjvg== X-Google-Smtp-Source: ABdhPJzX5xTKox4Pg2bhyYRTLmlLvFAhwmKhGgHJe0PGKtCdlHp+dbHFO24CDO+gsa08eG9bb14cvg== X-Received: by 2002:a17:90a:470a:: with SMTP id h10mr10650064pjg.25.1642982728670; Sun, 23 Jan 2022 16:05:28 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:28 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tomasz Kantecki Subject: [PATCH 07/82] examples/l2fwd-cat: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:03 -0800 Message-Id: <20220124000518.319850-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- examples/l2fwd-cat/cat.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/examples/l2fwd-cat/cat.c b/examples/l2fwd-cat/cat.c index 502c6b32780e..77154c8b7e61 100644 --- a/examples/l2fwd-cat/cat.c +++ b/examples/l2fwd-cat/cat.c @@ -872,8 +872,7 @@ cat_fini(void) #if PQOS_VERSION <= 103 memset(m_sockets, 0, sizeof(m_sockets)); #else - if (m_sockets != NULL) - free(m_sockets); + free(m_sockets); #endif m_sock_count = 0; memset(m_config, 0, sizeof(m_config)); From patchwork Mon Jan 24 00:04:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106247 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DA80A04A6; Mon, 24 Jan 2022 01:06:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA96C427E8; Mon, 24 Jan 2022 01:05:33 +0100 (CET) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id CBF37427D3 for ; Mon, 24 Jan 2022 01:05:30 +0100 (CET) Received: by mail-pg1-f179.google.com with SMTP id e16so4333304pgn.4 for ; Sun, 23 Jan 2022 16:05:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+E32WGsBAf6jw7FOSwCo+w81VRzmciXgJ29ENrL+4k0=; b=Kxdzujw8Ywucyxhcf+s4nlW00u/dIFc1fH9bwH+Mkoa9UJvh1JWn5cNF3sI/fEpbgv 2AH9EN+dd+9TD/7BxsWDZkr6WcIIbYrU4RO+mUInrEOECX1WVQltUQFDWlP2TMWuUQ/g FhvhoVauD5bJz6TrRKebM+hsfyei6rzxKoPSY/UjRpc2Qep3Taqb7l4zNJOOaX9EfIeL PHli651GV9h3H8cLeriCPrH4h5TW0R8EnPb9fCj/jkzJn4rumVBrf1fqezXL4gb+/uoo q3qxu3EOXzsA/uDLZmq1gTeZiLfs02t1FNnA5Lgb7ev+aZW0ApTIduVt0FjLbqRMfguG /BxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+E32WGsBAf6jw7FOSwCo+w81VRzmciXgJ29ENrL+4k0=; b=MSiD/sTEz16HqrYAhBV46KINCpj5PKo4COYwPulVkzkHtgiuWE9q8QLiD08XbOzr+F MvNdAYZKt8iDaSkcPQK6WrlZ7sAa4FtD224ZjH2DeUKp1LeqibnCYHe5cBdURLl+PUs+ qkeVS8IcVv12nRWFFPtdAEBTKETJp6ZjjXdK/Ny3/HepBi0udgaCe3usMmeLxFJMJcHx PsfAELTg78yDUwg4NXe2OPCu9Eh2kB3R3XiI1VyA237zlyRdjFoHfPpanPhHrQYyTBKP r3usC/7RTJfTPHmxgwIhV9WvfKF+fPpNqNRaO+zA0k2/QpzzBTo+DJnQqs8i+giVS6aj EKJQ== X-Gm-Message-State: AOAM530LyeyJIO3T/s6RKN5gH1JY9LIxfMSllMfGZk4ah73T3aG9nfKB 93z1QRhdv7dtyyYUrjyOMHWWctBsdR1CPA== X-Google-Smtp-Source: ABdhPJzJVMcc2khhBJO1pgeCYp1I1N+ie1pUHvW57p+95GzfsWOz5EZYHnoe+afCd8m3zkYdeieadA== X-Received: by 2002:a05:6a00:2444:b0:4a3:239f:d58a with SMTP id d4-20020a056a00244400b004a3239fd58amr11824079pfj.85.1642982729795; Sun, 23 Jan 2022 16:05:29 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:29 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Maxime Coquelin , Chenbo Xia Subject: [PATCH 08/82] lib/vhost: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:04 -0800 Message-Id: <20220124000518.319850-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/vhost/iotlb.c | 3 +-- lib/vhost/vhost_crypto.c | 6 ++---- lib/vhost/vhost_user.c | 9 +++------ 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/lib/vhost/iotlb.c b/lib/vhost/iotlb.c index 82bdb84526ea..d6b8c0a396b5 100644 --- a/lib/vhost/iotlb.c +++ b/lib/vhost/iotlb.c @@ -315,8 +315,7 @@ vhost_user_iotlb_init(struct virtio_net *dev, int vq_index) /* If already created, free it and recreate */ vq->iotlb_pool = rte_mempool_lookup(pool_name); - if (vq->iotlb_pool) - rte_mempool_free(vq->iotlb_pool); + rte_mempool_free(vq->iotlb_pool); vq->iotlb_pool = rte_mempool_create(pool_name, IOTLB_CACHE_SIZE, sizeof(struct vhost_iotlb_entry), 0, diff --git a/lib/vhost/vhost_crypto.c b/lib/vhost/vhost_crypto.c index 926b5c0bd94a..012e0cefdeba 100644 --- a/lib/vhost/vhost_crypto.c +++ b/lib/vhost/vhost_crypto.c @@ -1498,10 +1498,8 @@ rte_vhost_crypto_create(int vid, uint8_t cryptodev_id, return 0; error_exit: - if (vcrypto->session_map) - rte_hash_free(vcrypto->session_map); - if (vcrypto->mbuf_pool) - rte_mempool_free(vcrypto->mbuf_pool); + rte_hash_free(vcrypto->session_map); + rte_mempool_free(vcrypto->mbuf_pool); rte_free(vcrypto); diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c index 5eb1dd681231..23a0e3fb3600 100644 --- a/lib/vhost/vhost_user.c +++ b/lib/vhost/vhost_user.c @@ -489,8 +489,7 @@ vhost_user_set_vring_num(struct virtio_net **pdev, } if (vq_is_packed(dev)) { - if (vq->shadow_used_packed) - rte_free(vq->shadow_used_packed); + rte_free(vq->shadow_used_packed); vq->shadow_used_packed = rte_malloc_socket(NULL, vq->size * sizeof(struct vring_used_elem_packed), @@ -502,8 +501,7 @@ vhost_user_set_vring_num(struct virtio_net **pdev, } } else { - if (vq->shadow_used_split) - rte_free(vq->shadow_used_split); + rte_free(vq->shadow_used_split); vq->shadow_used_split = rte_malloc_socket(NULL, vq->size * sizeof(struct vring_used_elem), @@ -516,8 +514,7 @@ vhost_user_set_vring_num(struct virtio_net **pdev, } } - if (vq->batch_copy_elems) - rte_free(vq->batch_copy_elems); + rte_free(vq->batch_copy_elems); vq->batch_copy_elems = rte_malloc_socket(NULL, vq->size * sizeof(struct batch_copy_elem), RTE_CACHE_LINE_SIZE, vq->numa_node); From patchwork Mon Jan 24 00:04:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106248 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04961A04A6; Mon, 24 Jan 2022 01:06:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB525427EC; Mon, 24 Jan 2022 01:05:34 +0100 (CET) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id CE2E1427B9 for ; Mon, 24 Jan 2022 01:05:31 +0100 (CET) Received: by mail-pg1-f172.google.com with SMTP id e16so4333330pgn.4 for ; Sun, 23 Jan 2022 16:05:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AKvZb0jmjUHFdNWvNQO2+9sswUBriBoXY4swBNrp1IM=; b=ofbUeNgETO6k/iF7S5IrupUNU73QUeu56FKYT/Jv1DQTSGNjyr/h5px6elKEplMdoi ryEBUjhXl1VlnclxXbVqPzfLluUKeeZ5GdDNq5t7vqZXvCbDu8W11DSSckG75oTKj3pF 66QSwfNH8QtArSlUXBXxKssEhVdWSPRaenl1M6kMjz/cOLGq+FNys7+MPSIA8GQGWR4j anAi7rpIWHeTSxi2EO3zmjag9uhufNBv4d+FRqH9t7PX1JfQbbUY6KXl26ABgwoGaHV9 bSCJHQyrMHC+s9dIE62WQNZ+Smm9DFWP7qJkrY0oFzsNBacdvFyNFQUxfeXlf81MHk9d BQ9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AKvZb0jmjUHFdNWvNQO2+9sswUBriBoXY4swBNrp1IM=; b=dqa5WV31Ko+/WKPyY7jtlIOUnyhWc8UJO2Xm3Y5WTL5gXc26nV4kEl0XI+qPagFnHj mT/8QQLGZMm8fnzxOl6WfH8RRq8wtKXKGfdxu/UEGmYOa6i/HjF1ihRfL4RJPl3c/Exy yx6LzmMowHX83BJztYqGo2OGaRpAVZBVAhP7vbWZWBn5wsc7FGbhNBbJi2rIlXrwteTq egMkhlmmUXy4n6/Q2rL7P4fA9FXqsAw0Q5UJPD2FfIMVRYZryw/bbNNzedZ8/eKCO9qT FZi0nluieviHdL2szYXnrEmjqayNv/aycuznU52RmbEi3IkssemTD+FXjEo1UEYCW/YO pF1Q== X-Gm-Message-State: AOAM533iXXXAepYFtyQFsJ3mPonkXWe34dmEls91KH/7FQq2EBaIQD3V Vc29ph1uEvgEm4M399a0RKRBtqhn/xjCKw== X-Google-Smtp-Source: ABdhPJzY6IrGnMAh7gQXKBckXtxMl7XiWlTHfX8yuJK9d3+k+FFtPQeEFx38SfokjFmDjBhisNSxtA== X-Received: by 2002:aa7:84cf:0:b0:4c8:7234:e6ca with SMTP id x15-20020aa784cf000000b004c87234e6camr5290955pfn.35.1642982730844; Sun, 23 Jan 2022 16:05:30 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:30 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Maxime Coquelin , Chenbo Xia Subject: [PATCH 09/82] examples/vhost_blk: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:05 -0800 Message-Id: <20220124000518.319850-10-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- examples/vhost_blk/vhost_blk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/vhost_blk.c index feadacc62ee5..2cab1e6994fe 100644 --- a/examples/vhost_blk/vhost_blk.c +++ b/examples/vhost_blk/vhost_blk.c @@ -849,8 +849,7 @@ static void vhost_blk_ctrlr_destroy(struct vhost_blk_ctrlr *ctrlr) { if (ctrlr->bdev != NULL) { - if (ctrlr->bdev->data != NULL) - rte_free(ctrlr->bdev->data); + rte_free(ctrlr->bdev->data); rte_free(ctrlr->bdev); } From patchwork Mon Jan 24 00:04:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106249 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 556EEA04A6; Mon, 24 Jan 2022 01:06:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C544C427F2; Mon, 24 Jan 2022 01:05:35 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id E9995427E0 for ; Mon, 24 Jan 2022 01:05:32 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id e28so9785136pfj.5 for ; Sun, 23 Jan 2022 16:05:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=n1kdZY9bsWP4eeWLNwDfXRD5X13ceHgxBOZuNjBt+3c=; b=QZ29NIJ9f5Izf20iX8wqfIEwMeuGO9TaZrXEOvm3Ld/1SyUhQp1HLiiwI8MGPxj6L7 X/51oGw7F66zdB7wQ//0QXyNH621m8POjg0L7Eoh7ugJYOASKdkPv/qpceh3/SyoM8sJ FbCqsRzKFPumDmQnTojOf2TVcbFcaZWSjRIa1s2MlmT0xOrvqe+4DedtXRM9GG2FJfNf 5oASu7Pmd2ScHEt8FwxHe6OnVj+kNIqT9QFqLAP5su7LjuIZ+q7Yol68lIOjHKonS07i /HyMjuuW4wtO+qJGPIw3GARSZZN/aiTgJuAHhxfIlRO0XzllH1Qu38oSvMCjXq6PU7mC AlWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=n1kdZY9bsWP4eeWLNwDfXRD5X13ceHgxBOZuNjBt+3c=; b=q7fCjGkYFy4RWSpjGtFbmT6CKtn2WhMBR8iwHZLAHOG971tFzX7T3U2bBiNkrt/H6l zjnrb77RMe2qxv4+uCIkSGSor5e8XR06Y9PqfyjChBN5MR5Bl7XpFDZ6BqMga4mT4LZD 7oC/X8a91uY4crsL11v80UM2r3N7RB46E/03MEiSQH4M2kIyIoHsJ84OlDdFbxAAGRx8 QeW+OXxVKGIuHELtUgQGVMiKubX6Ygy0anQQ0ZS4yAD1d8SaJIRWqM7Vtfy2vPCpHrTR 4zQ5rriX2b79rumMW3QNZYUUBtHjwLzHkv4WLGhNtN0YhDznW8ScEIxpW+ufR4ZFButQ kFUQ== X-Gm-Message-State: AOAM533FWwXS6zlGs3QTjLyKtavEEw02z2MX+SZTTp6flufU6lV4DO8Y Mp3IVjDt63frtutic9ARSsbZGtP8aMQxog== X-Google-Smtp-Source: ABdhPJw1qyYc2b4ys76muD6lQwZ8SSr3Joc5BxQfasT97ltup7zzqpuaXh1sJ8fVH2oHATBLAmyH1A== X-Received: by 2002:a05:6a00:8cc:b0:4a8:262:49e1 with SMTP id s12-20020a056a0008cc00b004a8026249e1mr11696547pfu.28.1642982731863; Sun, 23 Jan 2022 16:05:31 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:31 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Reshma Pattan Subject: [PATCH 10/82] app/pdump: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:06 -0800 Message-Id: <20220124000518.319850-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- app/pdump/main.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index 46f9d25db004..04a38e891119 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -502,14 +502,11 @@ cleanup_rings(void) for (i = 0; i < num_tuples; i++) { pt = &pdump_t[i]; - if (pt->device_id) - free(pt->device_id); + free(pt->device_id); /* free the rings */ - if (pt->rx_ring) - rte_ring_free(pt->rx_ring); - if (pt->tx_ring) - rte_ring_free(pt->tx_ring); + rte_ring_free(pt->rx_ring); + rte_ring_free(pt->tx_ring); } } From patchwork Mon Jan 24 00:04:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106250 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93223A04A6; Mon, 24 Jan 2022 01:06:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6D65427F7; Mon, 24 Jan 2022 01:05:36 +0100 (CET) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id E33F5427EA for ; Mon, 24 Jan 2022 01:05:33 +0100 (CET) Received: by mail-pg1-f169.google.com with SMTP id 133so13677210pgb.0 for ; Sun, 23 Jan 2022 16:05:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fSHQYaOQEm+SSuFf74z6AI2xRnXvYuH1R3TLe7EfB9M=; b=FL0VyfZtU3gQ6GSzWzM9xjSzMUSWj3Ms7HcvTFWO/HXsMustrKw6eNOQCHJzwUUNeT X+aoga8UrvHxlW2mJSWkuyL5Qh6Yo+vHHLBs8lF1f76gfpcbo24QMhahjRTNhzSY2Wgd ztXygxYD1WqSIWt0zNOyQNakk4Vvx8LogqtyiGUkDrSFA0qQPzdNLTRcI/s+A1KgtAi/ nCUFa4pzJXY2TD0zugzYcRg7Z3B2EWq6mSUx7qEFygviJcjSVpDIg8Xz87yHB7Nr6h8J JpQTI/l8pM7IpRVpuoZOa+6MUVJFnQYJLoiHSpo+NBOFc3VawHdGnpePC+Q3YVm2PSax MM7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fSHQYaOQEm+SSuFf74z6AI2xRnXvYuH1R3TLe7EfB9M=; b=3gGG4VZK++9HeRo+6+OR6c6/JZuDAjVYZrWmtprPnqxN/aTOvqa1AS34ZOUc+Z2QJR N0GX4AUDKBG8g3Z+kJ+Pz2h3wgRwtSsbnJ/mgy4qdnTe/6sWPH6ZSp/Buai7oA8sPXzK mFbU7tfigleiAUx/FNL69DaywF9Tq48sCBc9p6E+pwK4AnYDmw+jVs2oa61nibFHtKH6 nM94pjDdQQTx1cWr1yfoNvVX+8W8ZmidSrQpb6wX0vh9n8EAgV7Vr3F2yycGCHtRYKlu +Xtn8/RyWdm8UeJToXSN/qjrhiDVg7GRiBvdvRzcHmvaH8xbQv1tq1CBXXvgqoc4FDNw x3eA== X-Gm-Message-State: AOAM5319VdFTic1Ef0Ppsts/j1goRuvtgJJSBTTwqiPAy6cqup6odUES jurUQGhKZf/ZCkW90+HnHTnRVdL1rCJLSg== X-Google-Smtp-Source: ABdhPJwt7078QlAZQ3Ni4hfkZVxbIfg8eHSledL7NBSYTvr7kyQwilUYJhHeP9hLifcnqK+d44jrhg== X-Received: by 2002:a63:556:: with SMTP id 83mr1537724pgf.187.1642982732943; Sun, 23 Jan 2022 16:05:32 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:32 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Declan Doherty , Ciara Power Subject: [PATCH 11/82] app/test-crypto-perf: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:07 -0800 Message-Id: <20220124000518.319850-12-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Ciara Power --- app/test-crypto-perf/cperf_test_latency.c | 3 +-- app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 9 +++------ app/test-crypto-perf/cperf_test_throughput.c | 3 +-- app/test-crypto-perf/cperf_test_vector_parsing.c | 6 ++---- app/test-crypto-perf/cperf_test_verify.c | 3 +-- 5 files changed, 8 insertions(+), 16 deletions(-) diff --git a/app/test-crypto-perf/cperf_test_latency.c b/app/test-crypto-perf/cperf_test_latency.c index ce49feaba9f3..4c7bc72eb5fd 100644 --- a/app/test-crypto-perf/cperf_test_latency.c +++ b/app/test-crypto-perf/cperf_test_latency.c @@ -49,8 +49,7 @@ cperf_latency_test_free(struct cperf_latency_ctx *ctx) rte_cryptodev_sym_session_free(ctx->sess); } - if (ctx->pool) - rte_mempool_free(ctx->pool); + rte_mempool_free(ctx->pool); rte_free(ctx->res); rte_free(ctx); diff --git a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c index 5842f29d43e2..6b4d09e623eb 100644 --- a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c +++ b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c @@ -79,14 +79,11 @@ cperf_pmd_cyclecount_test_free(struct cperf_pmd_cyclecount_ctx *ctx) } } - if (ctx->pool) - rte_mempool_free(ctx->pool); + rte_mempool_free(ctx->pool); - if (ctx->ops) - rte_free(ctx->ops); + rte_free(ctx->ops); - if (ctx->ops_processed) - rte_free(ctx->ops_processed); + rte_free(ctx->ops_processed); rte_free(ctx); } diff --git a/app/test-crypto-perf/cperf_test_throughput.c b/app/test-crypto-perf/cperf_test_throughput.c index 51512af2ad81..51fad5a05505 100644 --- a/app/test-crypto-perf/cperf_test_throughput.c +++ b/app/test-crypto-perf/cperf_test_throughput.c @@ -57,8 +57,7 @@ cperf_throughput_test_free(struct cperf_throughput_ctx *ctx) rte_cryptodev_sym_session_free(ctx->sess); } } - if (ctx->pool) - rte_mempool_free(ctx->pool); + rte_mempool_free(ctx->pool); rte_free(ctx); } diff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c b/app/test-crypto-perf/cperf_test_vector_parsing.c index 1e9dfcfff087..87f3a90055aa 100644 --- a/app/test-crypto-perf/cperf_test_vector_parsing.c +++ b/app/test-crypto-perf/cperf_test_vector_parsing.c @@ -551,10 +551,8 @@ parse_file(struct cperf_test_vector *vector, struct cperf_options *opts) err: if (fp) fclose(fp); - if (line) - free(line); - if (entry) - rte_free(entry); + free(line); + rte_free(entry); return -1; } diff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c index 496eb0de00f0..c031330afcfe 100644 --- a/app/test-crypto-perf/cperf_test_verify.c +++ b/app/test-crypto-perf/cperf_test_verify.c @@ -42,8 +42,7 @@ cperf_verify_test_free(struct cperf_verify_ctx *ctx) rte_cryptodev_sym_session_free(ctx->sess); } - if (ctx->pool) - rte_mempool_free(ctx->pool); + rte_mempool_free(ctx->pool); rte_free(ctx); } From patchwork Mon Jan 24 00:04:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106251 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52823A04A6; Mon, 24 Jan 2022 01:06:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1B67427E2; Mon, 24 Jan 2022 01:05:37 +0100 (CET) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id DFAF7427ED for ; Mon, 24 Jan 2022 01:05:34 +0100 (CET) Received: by mail-pg1-f171.google.com with SMTP id t32so13625081pgm.7 for ; Sun, 23 Jan 2022 16:05:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Bqx1QikgD2/KxHs/wk6/R5yXCp85ron8ncDQ9vvSGQU=; b=iU6Uws9YPG0HJIUF10Yscv8Xzg2IabQ6/V0jJ3meB1fGlQ4auxfyceErPU1mBrkcDH RTPH/qogAlPkwzCXSJ3QJ7/0mxxIpDvyTtzkI7iFn30UNc7QdXWrLGZsgqodaW22d8bc /+HWbl2v6E72PaZ7thlhZntAfvVEd/4E9pRs4lfi7KfSczMWqbIhUpp7qQJpg4p/XAH+ ZMjilWxNtz5CeoLerORbb5zl1eH9b4Ccvu1vn+B/AMU/peeAfsct00wYCCeQjBf4PixP 5hKYPnwAb7QxLou59qJHBksw//2AL8gB/55Xjj9KeLQi3GAhdDiqUJhdp14FXHnHrBvm xO3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Bqx1QikgD2/KxHs/wk6/R5yXCp85ron8ncDQ9vvSGQU=; b=kMFsh7+fk7tjmgrpRPbBmo/8Ulhhz5O8SrX0AP6OvifQzdbIzCcO8Ed8FMlq9rPc1n rGqJ8SxkR3V8OYTl68hgWQcozt45dukufE38O2X/NeOa2/5FOJHSjPi0ykQiICliM37d ACMJHzCNx1Uos5TZjn1k6EuIiMeqHUZkcLryT8A0uoxKu8sZ0UVz5JnBOw4J1aie6iJ9 SN2nLpKvqOYQdTPM5iVHF3xM3yrcqDrdV0N75xX+gvOvWKLPtrWvH32HSS0r6NPptrmL Cs1bzunbk3oAmA1tmZBpMq+DI7rA1wnT80m2/pGrNb5vmoigtMg/UdkmCjveXnFDKvS8 x36w== X-Gm-Message-State: AOAM533aF4+hAJQ8yj51BO8/2/Z2gXkA8nyFRqNTVEQ/gy3O9y1XQmQ3 VfIimEG2KopBF03SQjUylO3EgH7YyNPzPQ== X-Google-Smtp-Source: ABdhPJzy/uXOxnIrRybC8zV8Ig/2AcsLKuUr/RRRcCbGX94TCTM/l+07SFewwtNIAp2Erlqi75ee0w== X-Received: by 2002:a63:2a51:: with SMTP id q78mr10177600pgq.25.1642982733945; Sun, 23 Jan 2022 16:05:33 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:33 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Xiaoyun Li , Aman Singh , Yuying Zhang Subject: [PATCH 12/82] app/test-pmd: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:08 -0800 Message-Id: <20220124000518.319850-13-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- app/test-pmd/cmd_flex_item.c | 3 +-- app/test-pmd/cmdline.c | 3 +-- app/test-pmd/testpmd.c | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmd_flex_item.c b/app/test-pmd/cmd_flex_item.c index 908bcb3f47f8..9050825a81d7 100644 --- a/app/test-pmd/cmd_flex_item.c +++ b/app/test-pmd/cmd_flex_item.c @@ -364,8 +364,7 @@ flex_item_create(portid_t port_id, uint16_t flex_id, const char *filename) flow_error.message ? flow_error.message : ""); } out: - if (fp) - free(fp); + free(fp); } #else /* RTE_HAS_JANSSON */ diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index e626b1c7d9ee..298a594e709b 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -14696,8 +14696,7 @@ cmd_ddp_info_parsed( ret = 0; no_print_return: - if (proto) - free(proto); + free(proto); #endif if (ret == -ENOTSUP) fprintf(stderr, "Function not supported in PMD\n"); diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 6c387bde84e5..31efa0fe61e5 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -902,8 +902,7 @@ create_extmem(uint32_t nb_mbufs, uint32_t mbuf_sz, struct extmem_param *param, return 0; fail: - if (iovas) - free(iovas); + free(iovas); if (addr) munmap(addr, mem_sz); From patchwork Mon Jan 24 00:04:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106252 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66BADA04A6; Mon, 24 Jan 2022 01:06:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B01842806; Mon, 24 Jan 2022 01:05:39 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 03B7C427E0 for ; Mon, 24 Jan 2022 01:05:36 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id c3so13925855pls.5 for ; Sun, 23 Jan 2022 16:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m5u8SZbeHnKwO+LR0Tf92LX8t/vOCtPZna+YbxalHH8=; b=V3m6Mv9U/X7u9AdRsmbkhTq0qmBB7TQjJdLk1H9Ux5iqz8BJeT171THzv+etFptqFt Bsktr5RRD5Wfcqrh6clx/CwALc7t0UYt/av7IPIDCjvDK6pxgjqrLVN2uVoTdMg1NgbS a+jgdkmxqNYCWSir0SBep95ZLEETzSjBXn3AN+Kh2AZ7MXWGhitrgTKwacMyhnhqhV/z AjRAY0YGOKU8g2vxdOV6q/J1rm/6VNJ51mz3xGEHc9vDhJXg60SYpkCAd04TOTSE9O7H trpeY5rjaRW4kyR5ZJsf2tpEpMhQrkp/+K6NKOc4A7Qy/cgdG+QZRHhy39yIILgckf2a 5VZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m5u8SZbeHnKwO+LR0Tf92LX8t/vOCtPZna+YbxalHH8=; b=QkXBePV7VnBUJhmATWyU3HeuFgigc9j8lhQcydR4A2/xmGlBmIFPXWPvbVbOcMnLhz n0Wqv6Vgo4HAeJpfrluMjkUmTT5pM08a1oNylw+NF+9GCidfJo8naJU15Tf+5pRGMjcY pR1sjLXeYnbxUZRjqLAyMGOXw8hw+PioKfPwRju+YsAvPlmSE747VZ1H9bIOuZgmq8GB no2ODMnUkt4sBbStZmyeMZUX7g1wTvj4mgTCFTav0dJkdw4PBjrxSZ7dKSWJDzpZ3ZpA HIeSuTEQkJjLd13PropIzVqsvHf+6Q9tG6xMjtQujYpoGXOSUJpV9HqRpHg33Qb5Xc6S N82g== X-Gm-Message-State: AOAM532d/hAW3uQCMgdhiLnLY8CRoiVOmYpSMUVFisCTdSAVeQdoh4qZ KR5gJ9iTBjYHvlwtwiKBB9Vsup0PdqpqRg== X-Google-Smtp-Source: ABdhPJxBFYa/XfdOSy5RYg0DFHakroSC/Jj8LicgMR7TqYNtacYgbJ/rtgP7zYfAf3F6g4J81FIk1A== X-Received: by 2002:a17:902:9a0a:b0:149:7da0:af27 with SMTP id v10-20020a1709029a0a00b001497da0af27mr12188318plp.49.1642982734943; Sun, 23 Jan 2022 16:05:34 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:34 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ori Kam Subject: [PATCH 13/82] app/test-regex: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:09 -0800 Message-Id: <20220124000518.319850-14-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- app/test-regex/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/app/test-regex/main.c b/app/test-regex/main.c index 8e665df73ce0..ab8a3e56e774 100644 --- a/app/test-regex/main.c +++ b/app/test-regex/main.c @@ -210,8 +210,7 @@ read_file(char *file, char **buf) printf("Error, can't open file %s\n, err = %d", file, res); if (fp) fclose(fp); - if (*buf) - rte_free(*buf); + rte_free(*buf); return -res; } @@ -299,8 +298,7 @@ init_port(uint16_t *nb_max_payload, char *rules_file, uint8_t *nb_max_matches, rte_free(rules); return 0; error: - if (rules) - rte_free(rules); + rte_free(rules); return res; } @@ -367,8 +365,7 @@ regex_create_segmented_mbuf(struct rte_mempool *mbuf_pool, int pkt_len, return mbuf; fail: - if (mbuf) - rte_pktmbuf_free(mbuf); + rte_pktmbuf_free(mbuf); return NULL; } @@ -612,8 +609,7 @@ run_regex(void *args) rte_free(qp->buf); qp->buf = NULL; } - if (mbuf_mp) - rte_mempool_free(mbuf_mp); + rte_mempool_free(mbuf_mp); rte_free(qps); return res; } From patchwork Mon Jan 24 00:04:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106253 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BEDA1A04A6; Mon, 24 Jan 2022 01:06:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07C494280C; Mon, 24 Jan 2022 01:05:40 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 7F1BB427F9 for ; Mon, 24 Jan 2022 01:05:37 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id j16so3364714plx.4 for ; Sun, 23 Jan 2022 16:05:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hUi3jdycirbvMNlR/2jM4YhZ1CLXWJRlA9QQxRgryBs=; b=1K7lyI06wg/MQWz65eJooIylsgTzmF7peQ+8dD1y95RPRVnPwO8N/DDO1yTwgEa/kE TZ5aG9Da9X5DYmLl3wMVB85xqA9sE7skAIbo6yaToKCHZW1CaUJV4gV3bhP/OZ2FOUAc xyKClYtQwwcAR8ZWVEoWCP8QfGvfOoO4dnmFJL9aWRoOe9h9HgaZlhcrqcfaGIaIVNpV 3ODfqk+iSP+Y9SfvFJ+tlqnbNCtSovTeeJrMIiUmrz+xdGSs/0N1VA3gsmuzgpEQAVNU x7PrasPJY8HxO1PGeGcSIgzzQZN7FkPzjrbK8FeuHeQFc40fDHG/qnB+3VDQCyDCigJf Bwaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hUi3jdycirbvMNlR/2jM4YhZ1CLXWJRlA9QQxRgryBs=; b=QfxxejNUveqC//yF5uBcTHa4nHiY/FH2x90GP/tCeVnl7zFgmMDIMiN+heRQLfOqq9 eRYuru0V8gxC17KpA9bYmOpOpn+gMGVflbOOUXr6PdychV0hRZNRpTIu5Xu3scTjXwWU bmUz1alzgG0PPaCiGSiFIWjbhv4bpfz8OsalbS1W/cYwPvO/0VN5+XhPo9rN6juYUsy1 6jxAWTxjudCNWlYTyxZjqPcEP6rCATOhD/DauuLlQtWuhvsqBq+GcFzhZAgMxoPSS79Z OvXi5ktAG7SZ27tWb08UzBiM73G1czzk1GSkUydfBQwMbKqlNFjQKyrQY6awCGsGYvcF XzGw== X-Gm-Message-State: AOAM531fgpUR/W9na3/N+H1DwTetJkENLfa3EoE4Q4opAboJOGZTlmvt 11cSKefRSmU6twBgbavxN9BXKHF9pdeMsw== X-Google-Smtp-Source: ABdhPJxJaruFxEFt1NpIN2sjFNitd8TwTgPhnFEiM7OVeJDh3d98H9CdDiuL0BfsuuA/5DCiXPCrOw== X-Received: by 2002:a17:902:74c1:b0:14a:d9fa:d8a3 with SMTP id f1-20020a17090274c100b0014ad9fad8a3mr12476988plt.119.1642982736372; Sun, 23 Jan 2022 16:05:36 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:35 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Olivier Matz , Fan Zhang , Ashish Gupta , Akhil Goyal , Declan Doherty , Honnappa Nagarahalli , Konstantin Ananyev , Anatoly Burakov , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , Andrew Rybchenko , Chas Williams , "Min Hu (Connor)" , Reshma Pattan Subject: [PATCH 14/82] app/test: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:10 -0800 Message-Id: <20220124000518.319850-15-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- app/test/test_cksum.c | 3 +- app/test/test_compressdev.c | 3 +- app/test/test_cryptodev.h | 3 +- app/test/test_cryptodev_asym.c | 3 +- app/test/test_cryptodev_blockcipher.c | 12 +++---- app/test/test_func_reentrancy.c | 15 +++------ app/test/test_hash.c | 15 +++------ app/test/test_hash_perf.c | 7 +---- app/test/test_link_bonding.c | 9 ++---- app/test/test_link_bonding_mode4.c | 3 +- app/test/test_malloc.c | 5 ++- app/test/test_mbuf.c | 45 +++++++++------------------ app/test/test_pcapng.c | 3 +- app/test/test_reorder.c | 15 +++------ app/test/virtual_pmd.c | 3 +- 15 files changed, 47 insertions(+), 97 deletions(-) diff --git a/app/test/test_cksum.c b/app/test/test_cksum.c index cd983d7c01ce..6c15de9a9312 100644 --- a/app/test/test_cksum.c +++ b/app/test/test_cksum.c @@ -218,8 +218,7 @@ test_l4_cksum(struct rte_mempool *pktmbuf_pool, const char *pktdata, size_t len) return 0; fail: - if (m) - rte_pktmbuf_free(m); + rte_pktmbuf_free(m); return -1; } diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c index 57c566aa9229..fbecaf9aaad4 100644 --- a/app/test/test_compressdev.c +++ b/app/test/test_compressdev.c @@ -2144,8 +2144,7 @@ test_deflate_comp_decomp(const struct interim_data_params *int_data, if (stream != NULL) rte_compressdev_stream_free(0, stream); - if (all_decomp_data != NULL) - rte_free(all_decomp_data); + rte_free(all_decomp_data); /* Free compress private xforms */ for (i = 0; i < test_priv_data.num_priv_xforms; i++) { diff --git a/app/test/test_cryptodev.h b/app/test/test_cryptodev.h index 70f23a3f67d0..29a7d4db2b10 100644 --- a/app/test/test_cryptodev.h +++ b/app/test/test_cryptodev.h @@ -230,8 +230,7 @@ create_segmented_mbuf(struct rte_mempool *mbuf_pool, int pkt_len, return mbuf; fail: - if (mbuf) - rte_pktmbuf_free(mbuf); + rte_pktmbuf_free(mbuf); return NULL; } diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index 68f4d8e7a6f9..8c68a12d74b2 100644 --- a/app/test/test_cryptodev_asym.c +++ b/app/test/test_cryptodev_asym.c @@ -518,8 +518,7 @@ test_cryptodev_asym_op(struct crypto_testsuite_params_asym *ts_params, if (op != NULL) rte_crypto_op_free(op); - if (result != NULL) - rte_free(result); + rte_free(result); return status; } diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/test_cryptodev_blockcipher.c index 5688a45377b2..127e2a53d379 100644 --- a/app/test/test_cryptodev_blockcipher.c +++ b/app/test/test_cryptodev_blockcipher.c @@ -805,20 +805,16 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t, rte_cryptodev_sym_session_clear(dev_id, sess); rte_cryptodev_sym_session_free(sess); } - if (cipher_xform) - rte_free(cipher_xform); - if (auth_xform) - rte_free(auth_xform); + rte_free(cipher_xform); + rte_free(auth_xform); } if (op) rte_crypto_op_free(op); - if (obuf) - rte_pktmbuf_free(obuf); + rte_pktmbuf_free(obuf); - if (ibuf) - rte_pktmbuf_free(ibuf); + rte_pktmbuf_free(ibuf); return status; } diff --git a/app/test/test_func_reentrancy.c b/app/test/test_func_reentrancy.c index ce40c3ce9631..64f27e20370f 100644 --- a/app/test/test_func_reentrancy.c +++ b/app/test/test_func_reentrancy.c @@ -89,15 +89,13 @@ ring_clean(unsigned int lcore_id) int i; rp = rte_ring_lookup("fr_test_once"); - if (rp != NULL) - rte_ring_free(rp); + rte_ring_free(rp); for (i = 0; i < MAX_ITER_MULTI; i++) { snprintf(ring_name, sizeof(ring_name), "fr_test_%d_%d", lcore_id, i); rp = rte_ring_lookup(ring_name); - if (rp != NULL) - rte_ring_free(rp); + rte_ring_free(rp); } } @@ -152,15 +150,13 @@ mempool_clean(unsigned int lcore_id) int i; mp = rte_mempool_lookup("fr_test_once"); - if (mp != NULL) - rte_mempool_free(mp); + rte_mempool_free(mp); for (i = 0; i < MAX_ITER_MULTI; i++) { snprintf(mempool_name, sizeof(mempool_name), "fr_test_%d_%d", lcore_id, i); mp = rte_mempool_lookup(mempool_name); - if (mp != NULL) - rte_mempool_free(mp); + rte_mempool_free(mp); } } @@ -215,8 +211,7 @@ hash_clean(unsigned lcore_id) int i; handle = rte_hash_find_existing("fr_test_once"); - if (handle != NULL) - rte_hash_free(handle); + rte_hash_free(handle); for (i = 0; i < MAX_ITER_MULTI; i++) { snprintf(hash_name, sizeof(hash_name), "fr_test_%d_%d", lcore_id, i); diff --git a/app/test/test_hash.c b/app/test/test_hash.c index b99e8de1db71..d522cb7f8cbf 100644 --- a/app/test/test_hash.c +++ b/app/test/test_hash.c @@ -1654,8 +1654,7 @@ test_hash_add_delete_jhash2(void) ret = 0; fail_jhash2: - if (handle != NULL) - rte_hash_free(handle); + rte_hash_free(handle); return ret; } @@ -1689,8 +1688,7 @@ test_hash_add_delete_2_jhash2(void) ret = 0; fail_2_jhash2: - if (handle != NULL) - rte_hash_free(handle); + rte_hash_free(handle); return ret; } @@ -1754,8 +1752,7 @@ test_hash_add_delete_jhash_1word(void) ret = 0; fail_jhash_1word: - if (handle != NULL) - rte_hash_free(handle); + rte_hash_free(handle); return ret; } @@ -1789,8 +1786,7 @@ test_hash_add_delete_jhash_2word(void) ret = 0; fail_jhash_2word: - if (handle != NULL) - rte_hash_free(handle); + rte_hash_free(handle); return ret; } @@ -1824,8 +1820,7 @@ test_hash_add_delete_jhash_3word(void) ret = 0; fail_jhash_3word: - if (handle != NULL) - rte_hash_free(handle); + rte_hash_free(handle); return ret; } diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c index 76cdac5d5320..287f486316f1 100644 --- a/app/test/test_hash_perf.c +++ b/app/test/test_hash_perf.c @@ -106,12 +106,7 @@ create_table(unsigned int with_data, unsigned int table_index, ut_params.key_len = hashtest_key_lens[table_index]; ut_params.socket_id = rte_socket_id(); h[table_index] = rte_hash_find_existing(name); - if (h[table_index] != NULL) - /* - * If table was already created, free it to create it again, - * so we force it is empty - */ - rte_hash_free(h[table_index]); + rte_hash_free(h[table_index]); h[table_index] = rte_hash_create(&ut_params); if (h[table_index] == NULL) { printf("Error creating table\n"); diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index dc6fc46b9c93..82a9b8e01a82 100644 --- a/app/test/test_link_bonding.c +++ b/app/test/test_link_bonding.c @@ -1639,8 +1639,7 @@ test_roundrobin_rx_burst_on_single_slave(void) /* free mbufs */ for (i = 0; i < MAX_PKT_BURST; i++) { - if (rx_pkt_burst[i] != NULL) - rte_pktmbuf_free(rx_pkt_burst[i]); + rte_pktmbuf_free(rx_pkt_burst[i]); } @@ -1722,8 +1721,7 @@ test_roundrobin_rx_burst_on_multiple_slaves(void) /* free mbufs */ for (i = 0; i < MAX_PKT_BURST; i++) { - if (rx_pkt_burst[i] != NULL) - rte_pktmbuf_free(rx_pkt_burst[i]); + rte_pktmbuf_free(rx_pkt_burst[i]); } /* Clean up and remove slaves from bonded device */ @@ -2010,8 +2008,7 @@ test_roundrobin_verify_slave_link_status_change_behaviour(void) /* free mbufs */ for (i = 0; i < MAX_PKT_BURST; i++) { - if (rx_pkt_burst[i] != NULL) - rte_pktmbuf_free(rx_pkt_burst[i]); + rte_pktmbuf_free(rx_pkt_burst[i]); } /* Clean up and remove slaves from bonded device */ diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c index 351129de2f9b..d9b9c323c7f8 100644 --- a/app/test/test_link_bonding_mode4.c +++ b/app/test/test_link_bonding_mode4.c @@ -194,8 +194,7 @@ free_pkts(struct rte_mbuf **pkts, uint16_t count) uint16_t i; for (i = 0; i < count; i++) { - if (pkts[i] != NULL) - rte_pktmbuf_free(pkts[i]); + rte_pktmbuf_free(pkts[i]); } } diff --git a/app/test/test_malloc.c b/app/test/test_malloc.c index 6d9249f831be..d424d7808af3 100644 --- a/app/test/test_malloc.c +++ b/app/test/test_malloc.c @@ -812,7 +812,7 @@ test_zero_aligned_alloc(void) err_return: /*clean up */ - if (p1) rte_free(p1); + rte_free(p1); return -1; } @@ -865,8 +865,7 @@ test_malloc_bad_params(void) err_return: /* clean up pointer */ - if (bad_ptr) - rte_free(bad_ptr); + rte_free(bad_ptr); return -1; } diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index f54d1d7c006a..daebf09d44b7 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -304,8 +304,7 @@ test_one_pktmbuf(struct rte_mempool *pktmbuf_pool) return 0; fail: - if (m) - rte_pktmbuf_free(m); + rte_pktmbuf_free(m); return -1; } @@ -416,12 +415,9 @@ testclone_testupdate_testdetach(struct rte_mempool *pktmbuf_pool, return 0; fail: - if (m) - rte_pktmbuf_free(m); - if (clone) - rte_pktmbuf_free(clone); - if (clone2) - rte_pktmbuf_free(clone2); + rte_pktmbuf_free(m); + rte_pktmbuf_free(clone); + rte_pktmbuf_free(clone2); return -1; } @@ -572,12 +568,9 @@ test_pktmbuf_copy(struct rte_mempool *pktmbuf_pool, return 0; fail: - if (m) - rte_pktmbuf_free(m); - if (copy) - rte_pktmbuf_free(copy); - if (copy2) - rte_pktmbuf_free(copy2); + rte_pktmbuf_free(m); + rte_pktmbuf_free(copy); + rte_pktmbuf_free(copy2); return -1; } @@ -679,12 +672,9 @@ test_attach_from_different_pool(struct rte_mempool *pktmbuf_pool, return 0; fail: - if (m) - rte_pktmbuf_free(m); - if (clone) - rte_pktmbuf_free(clone); - if (clone2) - rte_pktmbuf_free(clone2); + rte_pktmbuf_free(m); + rte_pktmbuf_free(clone); + rte_pktmbuf_free(clone2); return -1; } @@ -722,8 +712,7 @@ test_pktmbuf_pool(struct rte_mempool *pktmbuf_pool) } /* free them */ for (i=0; i X-Patchwork-Id: 106254 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 341E1A04A6; Mon, 24 Jan 2022 01:06:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F27114280F; Mon, 24 Jan 2022 01:05:40 +0100 (CET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 71953427F9 for ; Mon, 24 Jan 2022 01:05:38 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id e28so9785267pfj.5 for ; Sun, 23 Jan 2022 16:05:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Bgx/O/LgDBwfpZvv8sHETKfu+pFk8tRr98NibVIB3lI=; b=HacNJJBDw7Nco+J60x2SxuHCG5g/2z6osY9ewO85LnWOOyt+zEumVrrONi0i1vi/Lm 8WmsP4k6ZkAElo1Y++M4yOVKgShXz7IGuqanEem8xtdMlbOZxPLm9C0xuYz96ckAgD38 JZVZ6gORiqmiIBveg4+m74SBcJS/O/QpJZmtD5DGi7TSGO+ZQMjMXBBA4BKtOUYPo/5s 9PgOasMWhEvAm1AyjeExtt35vJwcfHKB0j1YqANkm7+rCYB4/KqxJS3TLbV318pZD6lV rPZsEIc0zVXCq1E8ZhWKuZC8wJ0F2uDvK7JaOlMBQ+7daCmhfYRxlfX3/Pw+PxPPDbr6 G/BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Bgx/O/LgDBwfpZvv8sHETKfu+pFk8tRr98NibVIB3lI=; b=QRe2Mav6gI58PIfi7mTDhsjUkyxfuLBThUcMhFO5096waG2+ScWcKmS5YWTc0yABr3 0BUo4d8NaFeEVq53DVMyUvzrC0puoXMDbLwpnO4uOYQRASWq6hNbLVQ2puADI/vJGhi3 yUdEeYYRpDodlF2EC5C1JRi6e3POt4RI7mKIkZWpjGWBZTd+SqUmDveYM6tjKBzo5Dv/ 0CvXTpwwkVckS6BIsOT6pEHv7ZliRZTfxhCKcJGR+dM6ziz5qmkBe6kqvgoZaQIawBRG cGq/ahLX74o0G8svnYCGO2EBxOWAyGit0HX8ahH2HpySf7W4ZgtgQDASQDAeHHgts6u2 PgvA== X-Gm-Message-State: AOAM530HzTjlvWRpEvAsCoBXFIDzETiq/H+0jtTf/fK2gEFEnsnw/SFH 5MVxXXnnkinEMU1j2zx8FKabgjTFLbtOfQ== X-Google-Smtp-Source: ABdhPJy0sUN8EptdY3SSb3FIvNvL/iGx/mhIxvpmn3Fa6GDoGB6HAOeZgSUMo2Q5GaY1pNxZNz6CKg== X-Received: by 2002:aa7:928e:0:b0:4ba:fa67:d87 with SMTP id j14-20020aa7928e000000b004bafa670d87mr11823468pfa.41.1642982737461; Sun, 23 Jan 2022 16:05:37 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:36 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nicolas Chautru Subject: [PATCH 15/82] baseband/acc100 remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:11 -0800 Message-Id: <20220124000518.319850-16-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/baseband/acc100/rte_acc100_pmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c index 1c6080f2f895..f86474f7e099 100644 --- a/drivers/baseband/acc100/rte_acc100_pmd.c +++ b/drivers/baseband/acc100/rte_acc100_pmd.c @@ -4402,8 +4402,7 @@ poweron_cleanup(struct rte_bbdev *bbdev, struct acc100_device *d, } printf("Number of 5GUL engines %d\n", numEngines); - if (d->sw_rings_base != NULL) - rte_free(d->sw_rings_base); + rte_free(d->sw_rings_base); usleep(ACC100_LONG_WAIT); } From patchwork Mon Jan 24 00:04:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106255 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7AB1A04A6; Mon, 24 Jan 2022 01:06:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0D9A427D7; Mon, 24 Jan 2022 01:05:42 +0100 (CET) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id 74CBD42809 for ; Mon, 24 Jan 2022 01:05:39 +0100 (CET) Received: by mail-pg1-f181.google.com with SMTP id 187so13438490pga.10 for ; Sun, 23 Jan 2022 16:05:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gR25GlvqrugHFDSHpGwRK+o2yAldZ0whYHwtH3VJk1Q=; b=bvIlh+UR/OiVmztIheGA5jR0bjGSFhjHzs155PiGBY4QywOTMKEh/pW99nFeNWXn3x saFNCzUxc8P+KFRt+ks5R99WqaU8hS+flZbKn3P0ULF5kd62M/FWcWWQE34+BL8g8SzA zIPhO2rbT5sSJIvlIeaZIKf5Fnlgj902Kkd7DgAShQkZ3xc8og9tGnHCk8IzMp3MAw3I bETWV7ZMeUZYIJYJzWr6BkOwJPFFlg6J8yzcjt6vOmyEhqCu/NT0fpzJHYNAc5or9ljJ K1oidzOGDvqSpq2sH3lTRLcR1UD0rs5VOTQuK/7pPI8tkeJJ7DVusZkk1OBpu6wpDqD9 gXYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gR25GlvqrugHFDSHpGwRK+o2yAldZ0whYHwtH3VJk1Q=; b=t39UTwufHr6FRZdbjWOtHiYF1TiRydv7br73ecxR+aVAVsCk6nzmWJaBK+YcD3E1zy /mzaVNm8e1MJ2XB03BeCMKpKn/K+XlnUGypobsGsrsU3VOLtRtLtIR4jCggcC7PjD/5f Yg8twFJLReL6VEYKTriiogwhaEbtvU59d5YH26g6AyXKQNvjpb1ETUwBOuzFSK1G7YIF G7K2/pZCOht+VT6xAoOwsPC81bDUYixsGl8x2o6Gj+vs+d7FVjNdANM7+OVq008c6z/0 JGdLMhQI18363zq+ZD3tm1z2TBGsq8FNDA4WfsA2uJVZ134tY/0PCFM7CcUm8MLfZfbm 1egQ== X-Gm-Message-State: AOAM532BzQxsCYfirqavp6QwxJT1oFVtc30worCfbUpJp8S8fIe/QmBK xZeHJXJLD6p7MpuLTeXOuk7IjY6VUELI4g== X-Google-Smtp-Source: ABdhPJxaP63b6hSSh0klms1ROKGLlA+Smhz96zf4BvtKLURl13jMhQKybo7BA5AVhLqJFbNXb1x8Rg== X-Received: by 2002:aa7:914a:0:b0:4c6:c181:5251 with SMTP id 10-20020aa7914a000000b004c6c1815251mr12138137pfi.41.1642982738472; Sun, 23 Jan 2022 16:05:38 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:38 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nipun Gupta , Hemant Agrawal , Nicolas Chautru Subject: [PATCH 16/82] baseband/la12xx remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:12 -0800 Message-Id: <20220124000518.319850-17-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/drivers/baseband/la12xx/bbdev_la12xx.c index 4b05b5d3f2a6..4d1bd16751fe 100644 --- a/drivers/baseband/la12xx/bbdev_la12xx.c +++ b/drivers/baseband/la12xx/bbdev_la12xx.c @@ -975,8 +975,7 @@ parse_bbdev_la12xx_params(struct bbdev_la12xx_params *params, } exit: - if (kvlist) - rte_kvargs_free(kvlist); + rte_kvargs_free(kvlist); return ret; } From patchwork Mon Jan 24 00:04:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106256 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21BE8A04A6; Mon, 24 Jan 2022 01:07:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE3ED42815; Mon, 24 Jan 2022 01:05:43 +0100 (CET) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id 771384280E for ; Mon, 24 Jan 2022 01:05:40 +0100 (CET) Received: by mail-pg1-f172.google.com with SMTP id e9so13659390pgb.3 for ; Sun, 23 Jan 2022 16:05:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7dLcdElfzX+mIIMFYvrzIDGxa7M6PkJIWm7Sq0z15pQ=; b=xFwLBWKlsZwxpwk5crNjD2vqfpV8S4bPSWmjbJzQiDoNPL7F8TungYFyxBJT1YO8iP E0IA4+cYR0Z6uI04E4pV12PEKorsgIJ/UW3dMDJkktEzdXQpo961QDU86bsQcnqcYgrH NVl50DkivI9FuAonZWlTF2yJRySWwmosZyx1F/7zrahnSsVMwln3TfbFdLsNPEyFYA8l 66wFbHWWTNhVQTYbyQ7ELo94u4z1cq+JoCKMTEmpiCCK3wQArJjC0lAb5Bl/A7muImRf fSiTJhNn7nF7v6JQUaD4dz7/+a+f3WR18xx93tGjXlfWgZcxWl6cmOxUPctfjdnDp4a4 Fs/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7dLcdElfzX+mIIMFYvrzIDGxa7M6PkJIWm7Sq0z15pQ=; b=1GoH6xu2bdYFgOmYG200+fFpTtYMjzCqDM/Qm+lYXiaS3r+SHW/NvtG2pQRNF30AC2 GQwlpeygNraGoWGsic4g5Znc0OQ28yh22EvyFJW7FcLo0dyjZHn/lm9Qt/9H7tC8mndy Es6iKrC595BovqI9+1GNCB3cRxhYuIOLyX9ulyGgQP5ZbAQHA/50bDEdIzpI3aTV6lrq 4lbuM5EmZn5gJ+rMYMzboqXPQMLFEpB4DImQkRIu0vAiI4GydTZudVnZRVVQswmqSKrA HhMXNackFbVFVdwJAuJY9HEXJBlkrl6utNxi6HyjnVc0DEdem6TXrFfXbTdqp75+MHgE 8xoA== X-Gm-Message-State: AOAM533HOtv70mnutUsX5GVvswycWbEoGNebQj1LeJS+B9JjA55cMS+n Nfu2N3NpUDLcQ+v24n9yohBmEOuf7l6b6Q== X-Google-Smtp-Source: ABdhPJzI+OJBOlDYl4v2vxqySk5C5++PPYBpqCp7IKgFk013mt0U4A9FPFEQVLxEijYjpM8EZ+iFJw== X-Received: by 2002:a05:6a00:994:b0:4c9:d2a4:c5af with SMTP id u20-20020a056a00099400b004c9d2a4c5afmr1012262pfg.73.1642982739483; Sun, 23 Jan 2022 16:05:39 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:39 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nicolas Chautru Subject: [PATCH 17/82] baseband/null remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:13 -0800 Message-Id: <20220124000518.319850-18-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/baseband/null/bbdev_null.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/baseband/null/bbdev_null.c b/drivers/baseband/null/bbdev_null.c index 08cff582b99d..248e12987f03 100644 --- a/drivers/baseband/null/bbdev_null.c +++ b/drivers/baseband/null/bbdev_null.c @@ -251,8 +251,7 @@ parse_bbdev_null_params(struct bbdev_null_params *params, } exit: - if (kvlist) - rte_kvargs_free(kvlist); + rte_kvargs_free(kvlist); return ret; } From patchwork Mon Jan 24 00:04:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106257 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5035DA04A6; Mon, 24 Jan 2022 01:07:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6A8F42819; Mon, 24 Jan 2022 01:05:44 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 7807342812 for ; Mon, 24 Jan 2022 01:05:41 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id c9so13906298plg.11 for ; Sun, 23 Jan 2022 16:05:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MpFsvUFrmqYboBcYsmcff/+YsakMY6WvobYk700vFdw=; b=qeLocHVSieMlExrHmvcUDRpkdR91C1DNl9Q/bjZYbs0Zvi07x+rB7Ek6bTtc4PpHEp weZYT9oeFHNCLND5uFYoFHQK/79vKMeULBd5CEq4cUfNkYaToqJQ7DZPLMExW2NazDUe INbTk8ZA3seGmsgOlevIlHbO7vpTJLwOnOGq/XwlglSNzi/5k63IpMY06H19BrMj4hou vFaoNTdhvRB6zUXj0g8kDL+hw4oXq+DPfxzNDvl3U4kemUs39jVUy6d8mhHIXuTVfPRi jI7qjKXwK5ds/IH6zJeS5yrPiCWHeDTAwAyQNB3u91qCl574QRk2RHmnKsHJnyZbYTCJ IvMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MpFsvUFrmqYboBcYsmcff/+YsakMY6WvobYk700vFdw=; b=cJUz3iZRHAwhh1ulYFfq7vD5qpRIqg688ogujJVBUAQEqllKvPERzr45tovIwQQGmr FpPRmv8uCBGvG9Dmp6iNRQaK2BNVFWEJhm3maoxazLqIM3gV9JsUzGr1G7RD+bau8Sbc qUO+5brRI4v//KSeEOdsgkW2zBJL9QGUDVXQx2jagu9v5vfsZhKDQZlmrJw2hMMmU8oI gIj7n7iWz6MyEF+TEjBKYmvSYzeiLRXiwShuOs21q1KcoiCHj8Z85CVZvy1ZnZjuqx6r W90Lh8E7bLlQshtwvbEWpUKMkpLBiJs+HfUTg9M6/qSROw5f0kvorjsalJBEYmx/OXK6 fxGw== X-Gm-Message-State: AOAM532LGCbba3CiimIgZWXpYftEaAfdLg/VhHRe/xKkPzH1Nn122PNI +pX1l4Mdev2/F9VPp6ThdA56eXI7wKdP7w== X-Google-Smtp-Source: ABdhPJwnZJtdMKgRsSw7IKVJhGKYYCtLh+On6YKPEdfWd9ln/s41nI0FqW/3t4i/6Q8tvDOotuNvIA== X-Received: by 2002:a17:902:e5c9:b0:14a:8379:bb9f with SMTP id u9-20020a170902e5c900b0014a8379bb9fmr12639846plf.142.1642982740515; Sun, 23 Jan 2022 16:05:40 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:40 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nicolas Chautru Subject: [PATCH 18/82] baseband/turbo_sw remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:14 -0800 Message-Id: <20220124000518.319850-19-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c index c6b1eb8679cb..af7bc416f92e 100644 --- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c +++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c @@ -1918,8 +1918,7 @@ parse_turbo_sw_params(struct turbo_sw_params *params, const char *input_args) } exit: - if (kvlist) - rte_kvargs_free(kvlist); + rte_kvargs_free(kvlist); return ret; } From patchwork Mon Jan 24 00:04:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106258 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9FDFA04A6; Mon, 24 Jan 2022 01:07:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC5ED42823; Mon, 24 Jan 2022 01:05:45 +0100 (CET) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by mails.dpdk.org (Postfix) with ESMTP id 7EB73427B4 for ; Mon, 24 Jan 2022 01:05:42 +0100 (CET) Received: by mail-pg1-f182.google.com with SMTP id 187so13438573pga.10 for ; Sun, 23 Jan 2022 16:05:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h7EyV8cgqNiWY7nRhIizAuJh6uZENLxeigzoOpNoMSk=; b=Urs46/e9Z4VGUtpyt8qGzCr7OnbUv4mEUFdfSegpTfAGRXAnOGEEAkLW/JMm32IXvn FDAwowDy86fL2Gyll7uKKxfLedVOS+J5AdPE0zNWFmQWFuXOBIhPpeSL5PnAvWxJU+++ e/b+9Gx+7Wf0Ff3lo+dZPIEa02ERade+JLDlqoSrUSpM4XbnZ2cqsumzZoqfGmRvK14p ll4A4UtXBYZBLyOnwX/LCff96UUWSDyvVt04VLF50m5DVRKEGJM+DSyfKQvW0vSaW0Qy mJLvDjpH7GhclLOn+QpQbmF3v10FuCsUMQVXvY83ru7frMQUJJaH74qnEWO61kp894wn b23A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h7EyV8cgqNiWY7nRhIizAuJh6uZENLxeigzoOpNoMSk=; b=sh3mxIcBCluvdYNKqRpgnF/OYmoYhic4nqVVU7Alry6T5nkE40phjgpVmzCoevMGmp dayt1z5n85jV/TiMAF7twosd+8tIduUBTXdAZNtqq0WbbE5IpC0hHY6r2Iv8c0Iq1qXp 6snj75ZG0ZIw0yprFzFztQkp/x3xl0w1YF6dtjVdfQlitsWoc9TTFxnjMJpIly1XelxW px8qjihpIJapN79FID3vYDVTgMjggdavsCgkEGLLontk73ZYmeSE9qP0t03ntB6U6j8R pITgjft1/VEEfec7ANg8+k2KcZGrm092ubaXIrJUaXmpLbrYXw4rdTCG82qaKd2bujnR o69g== X-Gm-Message-State: AOAM530le6iTDPoWIl6MJkRwvL6ao959Vo8bkZMMliaNFX9GxF0tfrSX x7Pvs1KX2hmhISzq/waVYeBR6eNkzhyu7w== X-Google-Smtp-Source: ABdhPJxm17D7/Af8Fmxnla3wBOVylFHli1KSsPFEnSpKvmMQwEgyKFu9RyBGrdYdMIIbJHaIvWqq4Q== X-Received: by 2002:a05:6a00:21c2:b0:4bc:fb2d:4b6f with SMTP id t2-20020a056a0021c200b004bcfb2d4b6fmr11827978pfj.62.1642982741510; Sun, 23 Jan 2022 16:05:41 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:41 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH 19/82] bus/fslmc: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:15 -0800 Message-Id: <20220124000518.319850-20-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_bus.c | 6 ++---- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c index 53fd75539e98..30d019516b91 100644 --- a/drivers/bus/fslmc/fslmc_bus.c +++ b/drivers/bus/fslmc/fslmc_bus.c @@ -223,13 +223,11 @@ scan_one_fslmc_device(char *dev_name) insert_in_device_list(dev); /* Don't need the duplicated device filesystem entry anymore */ - if (dup_dev_name) - free(dup_dev_name); + free(dup_dev_name); return 0; cleanup: - if (dup_dev_name) - free(dup_dev_name); + free(dup_dev_name); if (dev) { rte_intr_instance_free(dev->intr_handle); free(dev); diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c index 52605ea2c32c..943fadee4816 100644 --- a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c +++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c @@ -149,8 +149,7 @@ dpaa2_affine_dpio_intr_to_respective_core(int32_t dpio_id, int cpu_id) if (!token) { DPAA2_BUS_WARN("Failed to get interrupt id for dpio.%d", dpio_id); - if (temp) - free(temp); + free(temp); fclose(file); return; } @@ -574,8 +573,7 @@ dpaa2_free_dq_storage(struct queue_storage_info_t *q_storage) int i = 0; for (i = 0; i < NUM_DQS_PER_QUEUE; i++) { - if (q_storage->dq_storage[i]) - rte_free(q_storage->dq_storage[i]); + rte_free(q_storage->dq_storage[i]); } } From patchwork Mon Jan 24 00:04:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106259 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A759A04A6; Mon, 24 Jan 2022 01:07:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EEED442829; Mon, 24 Jan 2022 01:05:46 +0100 (CET) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by mails.dpdk.org (Postfix) with ESMTP id 8F15F42813 for ; Mon, 24 Jan 2022 01:05:43 +0100 (CET) Received: by mail-pg1-f182.google.com with SMTP id p125so13661222pga.2 for ; Sun, 23 Jan 2022 16:05:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JsSGuL3hE0Kx6NbddGKHLMFrZW0o8WLTr/PaEiefI4o=; b=m6ukpPXGzMMkDwQfe3FB0t01WoHlsm0yvsUMJPP59MKD2E63axOvddxMY7gPLSvsfb 6EEmpn3QAKQFCv/bVJUg/RDjyExB/I2TqECXU2ORpL9Q/vmundnE1TgqoOB1iW25DWM1 fpnEeJXoe7dSa1X4fLSc2+oGnpJIzoZXePTgJKk2KfjGIa6JxH04tb5wYN8qVjuS2Yce ild66AgMekAOSGqovfKXTMU7lL2ojZLTSIOEfKoI3CWrnE08s3F/LixEo9vBJ1y6LdHb nGXbQQDkIuuoUSoJGMuMP6a8K0eQAQEE/xvLbyEFkeLd8F1Vw5mlEo8nVHT5tdp0bQRS wl+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JsSGuL3hE0Kx6NbddGKHLMFrZW0o8WLTr/PaEiefI4o=; b=yh7FBzaDttWBD6urB0DD6hzpI1v5z0fcwf2qw4dk3eiubAPYsBFcrrMjvhxz13Rta9 sjwk4QJmH+GP08j+/4/0zfYZxGJ3Zx4lsFf8g3QqoGRfmIMg3cddHItO8N8ltXPUhI6R 6EBqMEuay/n9kViwdJCmvg5orXTKC3eAYhG8UtUmYj3uiPS0icn4B0vKd41XFBSLogCs Wz2CMLiCGplZs6oWA4Dst1UjPr7ZRrfrMSEG0YnWOggdnHgpXoMNuKb3zpdv/a/pSW6A 1R0w1FByUNevAkZAXaHBzt1B1jyig6YuyIUgN84YaNyoUWTCNlSmJRQKMvXIr82GhPAn kbBg== X-Gm-Message-State: AOAM532quBki3JTDMszla73v67+uHLzaUC09lDyJhQt1teEVFzbb+N1q F9Ym9Tj9gFBLyxqYcXYdV8T+5qhuw4QwZQ== X-Google-Smtp-Source: ABdhPJxOaJPoFGKUNTjzpeqFTQv2xuV94UbDcPQw/W4FQJ9DIjWKVf9ScwTy1aYLmB7mqLT0ViVWYA== X-Received: by 2002:a62:7ecb:0:b0:4c8:6137:6f39 with SMTP id z194-20020a627ecb000000b004c861376f39mr5255386pfc.43.1642982742549; Sun, 23 Jan 2022 16:05:42 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:42 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rosen Xu Subject: [PATCH 20/82] bus/ifpga: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:16 -0800 Message-Id: <20220124000518.319850-21-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/bus/ifpga/ifpga_bus.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c index c5c8bbd57219..e005f2cb70b3 100644 --- a/drivers/bus/ifpga/ifpga_bus.c +++ b/drivers/bus/ifpga/ifpga_bus.c @@ -191,10 +191,8 @@ ifpga_scan_one(struct rte_rawdev *rawdev, return afu_dev; end: - if (kvlist) - rte_kvargs_free(kvlist); - if (path) - free(path); + rte_kvargs_free(kvlist); + free(path); if (afu_dev) { rte_intr_instance_free(afu_dev->intr_handle); free(afu_dev); @@ -254,10 +252,8 @@ ifpga_scan(void) } end: - if (kvlist) - rte_kvargs_free(kvlist); - if (name) - free(name); + rte_kvargs_free(kvlist); + free(name); return 0; } From patchwork Mon Jan 24 00:04:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106260 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1C56A04A6; Mon, 24 Jan 2022 01:07:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07DF44282F; Mon, 24 Jan 2022 01:05:48 +0100 (CET) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mails.dpdk.org (Postfix) with ESMTP id A646242800 for ; Mon, 24 Jan 2022 01:05:44 +0100 (CET) Received: by mail-pg1-f174.google.com with SMTP id t32so13625366pgm.7 for ; Sun, 23 Jan 2022 16:05:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DgkzBQTE1eMonz+N2UqWyLc7Hrzi1Ajc+itxrE9HTe0=; b=JGrvAxcLtSCyA1mI7JXRQTsJ1IrcKLgErQlGdUwfk2eveZWqimbJ1V8GSUVuZ72+Ei GaussXL6YkuyFrnbjhjnyQrFjr/7u7HG+nVaqPd4AvjRK2Fzg9OExICqj1y6yjtMim+Q c+k9pxO+Wi/mZy7LbvJ/+dyd6UDpAtBgH1Qi4biktY8TCWmEuL53d1LsiX2JP92x9U9I 4QF7vc5bJCF8+C9Z6/ruM+Wy7k/pL8EatJEk+a+SmfBNzVdEyv4cQH/syec9/qsVu806 Z2lEi8UekolWnzAOG7z09Jn9Uo1FaWAFLMCp834/vECk59kbumOzx4Kz20qZBXqYwy9T C6lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DgkzBQTE1eMonz+N2UqWyLc7Hrzi1Ajc+itxrE9HTe0=; b=xVl4sIKR3BpDHjDFqv/+000bMDolQAgwvTN3Z1ARpfBkmUCTxwr6UqBsB0yDk03CQT wAnX7qsVE3JFqDbmB01sSdEkBqd7kh7eWqo8UBxlPq3m2mVsG68cihmnf0cnQfuO4LcX Vwcm59KdshN36C2MZUdcyO08MvnzFucgJJUI6rPVetVY0lT+iY/903oZZy4Pozed0IUv QuUrMkgCfgVPegB6SPSBZFRuDri8jXXgrmo0I+oflydSjzavki7z+co0L8xmJEezThmn IFSKkqy237s/7cYwhs9EgEI3xSh1dVya09hnbykMrrpC7is1NlLvSXByp5IgfUJGvwWu ZVAg== X-Gm-Message-State: AOAM5334mgJQT/Ex7C/Z9RZYxeBMnrwTiTC4ExxI9DaO6sjwMaYT8Zs9 axB4EpKYBY57feoUe0g0t+MXycBaUDSELQ== X-Google-Smtp-Source: ABdhPJynqO+a1q7+d1DWzgBdN3edrDQy2fwQnSj+1b/PZJAZ4QQ9KnWJ2qEyVflvQETGgcTzxfqGGA== X-Received: by 2002:a05:6a00:1988:b0:4c3:b9cd:f09a with SMTP id d8-20020a056a00198800b004c3b9cdf09amr12177911pfl.2.1642982743629; Sun, 23 Jan 2022 16:05:43 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:43 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 21/82] bus/pci: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:17 -0800 Message-Id: <20220124000518.319850-22-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/bus/pci/pci_params.c | 3 +-- drivers/bus/pci/windows/pci.c | 3 +-- drivers/bus/pci/windows/pci_netuio.c | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/bus/pci/pci_params.c b/drivers/bus/pci/pci_params.c index 60b424b8297e..61a868707f16 100644 --- a/drivers/bus/pci/pci_params.c +++ b/drivers/bus/pci/pci_params.c @@ -117,8 +117,7 @@ rte_pci_devargs_parse(struct rte_devargs *da) rte_pci_device_name(&addr, da->name, sizeof(da->name)); out: - if (kvargs != NULL) - rte_kvargs_free(kvargs); + rte_kvargs_free(kvargs); if (ret != 0) rte_errno = -ret; return ret; diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c index 39ba31be7d38..7bf091158ba2 100644 --- a/drivers/bus/pci/windows/pci.c +++ b/drivers/bus/pci/windows/pci.c @@ -418,8 +418,7 @@ pci_scan_one(HDEVINFO dev_info, PSP_DEVINFO_DATA device_info_data) return 0; end: - if (dev) - free(dev); + free(dev); return ret; } diff --git a/drivers/bus/pci/windows/pci_netuio.c b/drivers/bus/pci/windows/pci_netuio.c index a0b175a8fca0..5460399eea5f 100644 --- a/drivers/bus/pci/windows/pci_netuio.c +++ b/drivers/bus/pci/windows/pci_netuio.c @@ -180,8 +180,7 @@ get_netuio_device_info(HDEVINFO dev_info, PSP_DEVINFO_DATA dev_info_data, CloseHandle(netuio); } - if (dev_ifx_detail) - free(dev_ifx_detail); + free(dev_ifx_detail); if (di_set != INVALID_HANDLE_VALUE) SetupDiDestroyDeviceInfoList(di_set); From patchwork Mon Jan 24 00:04:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106261 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A300A04A6; Mon, 24 Jan 2022 01:07:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF9CB42832; Mon, 24 Jan 2022 01:05:48 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id A60464281F for ; Mon, 24 Jan 2022 01:05:45 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id j16so3364889plx.4 for ; Sun, 23 Jan 2022 16:05:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ad25wPM5/3bGAKrapK+uGim/jbE+T1hChvcLxmfP2LM=; b=RR/FIqC4COH8qNmyguiRigka//SaLca1ePP6u1TGaNUvifbMSLmaHXA+CZL2iF8+S4 OkXUvwl3fdt084vczj1FN0tk8YN0gi/9IKpDXTq4zC2MD9sKQusdRdmjD8n33z1eGB6M hptCfhAaE3E+HrnqwLIkag2c4IdMyiOLdbpbpAV7TNjHsnEyXlrt0QRM9GKZ6whizpas KdVxRXP9RNXXPqrHQ/KLNrmm8U5iE7SrW8mlXP2RTcIqqmVsBQScrPnyTTWpVAn5fi2J 8p55LCOeE7ybiQVAXkAvsYcgUYR9VAKUvoyUZTAGFbCLtrhnst3h97qiXVYAWVfGCmeX MFmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ad25wPM5/3bGAKrapK+uGim/jbE+T1hChvcLxmfP2LM=; b=Y31gmximU8SY/x+zhE+JTecD3wPKmhEg4i7CspweRuy33fUGc+7TV+1/MXek2BaT6z VHzGgOjaZQooZscbLlGTxFwNNm7jMJk1kYebzpBYajgaBtG+0KJOM0HzZI0DfgDCsVtz pLaXI13SV+gQjZDY1VGwmVXxdxLACOQERiZF2Tnp4ZO1W1a0qDcvonVHVTPZ87P6YPWY ToXRn+YcInVTARirf1vgh16tu2xTbYCxL8yKbq16SyxZC2xYZF1GlzXCKh65jm49ma0g X3LRalRHQ+AN4x2Gz8Je+RbvExBbOsrLM/4yMGOofuMhldkYMT+RrndWIl7+SurpaNZF jEZg== X-Gm-Message-State: AOAM530UPDatzKsO4YNoqZJPhlm4qPhOsqFBDFRvJyRaEsmvj177zykv xCifDcAhKIB5+t4k1LayYith0URYXs8QqA== X-Google-Smtp-Source: ABdhPJwm2yy8xztCueBkqphQxC5m4BJRDEGLYLSp1BtrLuI6KRfQR5SmDK5fc5evmyz2U0ZZJTi9bQ== X-Received: by 2002:a17:90a:1b25:: with SMTP id q34mr10794779pjq.104.1642982744686; Sun, 23 Jan 2022 16:05:44 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:44 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Anoob Joseph Subject: [PATCH 22/82] common/cpt: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:18 -0800 Message-Id: <20220124000518.319850-23-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/common/cpt/cpt_ucode_asym.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/common/cpt/cpt_ucode_asym.h b/drivers/common/cpt/cpt_ucode_asym.h index f0b5dddd8cdf..f5d91f2583bd 100644 --- a/drivers/common/cpt/cpt_ucode_asym.h +++ b/drivers/common/cpt/cpt_ucode_asym.h @@ -192,13 +192,11 @@ cpt_free_asym_session_parameters(struct cpt_asym_sess_misc *sess) switch (sess->xfrm_type) { case RTE_CRYPTO_ASYM_XFORM_RSA: rsa = &sess->rsa_ctx; - if (rsa->n.data) - rte_free(rsa->n.data); + rte_free(rsa->n.data); break; case RTE_CRYPTO_ASYM_XFORM_MODEX: mod = &sess->mod_ctx; - if (mod->modulus.data) - rte_free(mod->modulus.data); + rte_free(mod->modulus.data); break; case RTE_CRYPTO_ASYM_XFORM_ECDSA: /* Fall through */ From patchwork Mon Jan 24 00:04:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106262 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37BBCA04A6; Mon, 24 Jan 2022 01:07:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E002C42816; Mon, 24 Jan 2022 01:05:49 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id A3EE242827 for ; Mon, 24 Jan 2022 01:05:46 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id q63so9997004pja.1 for ; Sun, 23 Jan 2022 16:05:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6kHUYjHGPzaVjF61Z0vG8E/yxaEieN8nyYlr8bY65z8=; b=BO3AqzVVc3DmnAjMeswbBoiBeYsZpyffC4GKJ+J74uWDRtpPmf7ZzfjmzG8+8/yZ/j bGfXmMsQpCWpIdMB/G1aR3XcnbT2y5O0Qw8k47G7OoLQzjIML99+Gw5f1Cg8DiLpXc43 FsF73VqCPspDs51XhaTgya1ixcU8r5uR7yxrgjxGQniVpMRcrDnoRP3cixaVJjJEq3+C CCfrYguF0NQoretV4DsaVG10LztKxjd0tTMSlWW/afUrWMalPGI+Hj1fNpWbr+gwlRTD bixctduIiSZNKWdQZHFpT2dd6pOm6I38KeeiDBmIQJuO2Ce03ixze+HbMfp1XUIDR9PJ AF8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6kHUYjHGPzaVjF61Z0vG8E/yxaEieN8nyYlr8bY65z8=; b=VsVXBnGDIt0ufF+VsAm/s1hMjP6OJqBmbu9Hob+eD+ZokpVb/LbVYZLJI4G2h61Mve QLBBn9QrADg/PLjL8/I9Va0imyJfBBDhQ5/bYnu7ErqsnwFvbE/xEzybNh+KN6aWBABF Y1MyQNtGa1H8NKzyRW1hpDRuZ8fXT9dv88rWg89Jy3ktxXPny2hofuUHE/rvXKhXuYPu 5h5M6FiBEJQXmpCcijYegOq0qWJaf7hV5X4v//dywQmnTHH7H8HJLAiHKraofkvxDAdd SttauWXH2tobAPhfAzXM9QW7XiEKkhvpMsPF5oN8oUDZ2V7A6B6NnCqWnJszYEPAfQAJ VopA== X-Gm-Message-State: AOAM533jIPua5ba3Bji2+kfh09YMjEtmV5Xrcs2upGWXmPUcksWY9xXd 85vO76ZIZTfdOkaftpcDZy5mZoYX1MkVLw== X-Google-Smtp-Source: ABdhPJzLSqeA7bXOyS8kwFgwbT0vCwVuifIc+i/NIdnw4QBhAar/7ZcaO8Yp2YBgFZD1bQPSlhtzUQ== X-Received: by 2002:a17:90a:e17:: with SMTP id v23mr10785191pje.130.1642982745694; Sun, 23 Jan 2022 16:05:45 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:45 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH 23/82] common/dpaax: simplify kernel compat macros Date: Sun, 23 Jan 2022 16:04:19 -0800 Message-Id: <20220124000518.319850-24-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The compat wrapper had unnecessary NULL check and also the emulation of kzalloc() should just use equivalent rte_zmalloc(). Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/common/dpaax/compat.h | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/common/dpaax/compat.h b/drivers/common/dpaax/compat.h index 7166f8cceb41..cbabc1588b21 100644 --- a/drivers/common/dpaax/compat.h +++ b/drivers/common/dpaax/compat.h @@ -339,16 +339,9 @@ static inline void copy_bytes(void *dest, const void *src, size_t sz) /* Allocator stuff */ #define kmalloc(sz, t) rte_malloc(NULL, sz, 0) +#define kzalloc(sz, t) rte_zmalloc(NULL, sz, 0) #define vmalloc(sz) rte_malloc(NULL, sz, 0) -#define kfree(p) { if (p) rte_free(p); } -static inline void *kzalloc(size_t sz, gfp_t __foo __rte_unused) -{ - void *ptr = rte_malloc(NULL, sz, 0); - - if (ptr) - memset(ptr, 0, sz); - return ptr; -} +#define kfree(p) rte_free(p) static inline unsigned long get_zeroed_page(gfp_t __foo __rte_unused) { From patchwork Mon Jan 24 00:04:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106263 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59603A04A6; Mon, 24 Jan 2022 01:07:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE8BC4283A; Mon, 24 Jan 2022 01:05:50 +0100 (CET) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id 22B7E42832 for ; Mon, 24 Jan 2022 01:05:48 +0100 (CET) Received: by mail-pg1-f178.google.com with SMTP id e9so13659631pgb.3 for ; Sun, 23 Jan 2022 16:05:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XQ8I6+YgMTuR5SdNcCmgWKROtA0UZVrH8etryIV5X+o=; b=17GHwTQ6O6FJHD1CzhrykCCKE4ozLoVb2ith96X7NybTTqtekxg65Bp6jiSsiIrrs+ tA9gLTv7ApupOgELK6rk130q6nfQMYPbnSegduBdsm4AAM/Zi55YUTwbEyo9MYz+eQE0 dG/5+WD90IlBM481uCOxKf/iG+TGwAn3WpuCsGSf7hfAAZDKnIMY7ZeAE6FMnGBxdPYa px0Hn3xDt+QV7ATnkl1gcPF7E1y0l+5vjtaZwrX+uJBq6caj5icPZ3vY/OxKsIM7gM2G KDNULVm1eRmUO+jrRg+l7pBdv5uKHN2dS8Qj0ZwjskzR6XLnYAjOpAeKxaJI4xQwYMjh mRTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XQ8I6+YgMTuR5SdNcCmgWKROtA0UZVrH8etryIV5X+o=; b=a7ZNf1XOwP1OfFp+yD3LKqeH9vr2qihCz/BNlrBChfd1tQt/Hb3xBC4k3Ex8vs/rAP 6aqFlGY+MfDBSeRB/1xyTVKJoezVwigNDFjaSq0YfEO4QGv8X2+6ChPaZNg0T5yJz5jf PmLc9ELcB6HXQnakdSuFHAdRG0r9K1AJ5unXRzoF40j9hOgh4MOGdjupLdqKuGBuOAqH OmiqRtGxCAq//PoPdIXkvoEc9LtyvECMm6hynD3Zhnu8lfqIu2FLvril+DHLwLjo7KZ/ nzGStlwSSL3IeUVlU/VUXF59usyQ9GQkmpk5q/QvlAKAb0yfamxjVeD4JrqB4/4OeakD LG6A== X-Gm-Message-State: AOAM532HraPVqr0XPQNWalpWNcz38EF6hIxu8q6Wv2WbMqv2vr+kUfvz tVwKUPkLyBci7+/RAAANSPEd8F30HJ9lsw== X-Google-Smtp-Source: ABdhPJzf6wPiNhjGfCVsmP9UTSK080USMqz1Mu6Ab4qLt4j5zbY45CxDOqpvBGEL4e6lnFiDdI944w== X-Received: by 2002:a63:4f0c:: with SMTP id d12mr10146954pgb.133.1642982746806; Sun, 23 Jan 2022 16:05:46 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:46 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH 24/82] common/mlx5: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:20 -0800 Message-Id: <20220124000518.319850-25-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/common/mlx5/mlx5_common_mr.c | 3 +-- drivers/common/mlx5/mlx5_common_pci.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/common/mlx5/mlx5_common_mr.c b/drivers/common/mlx5/mlx5_common_mr.c index 1537b5d42879..07f76a10655f 100644 --- a/drivers/common/mlx5/mlx5_common_mr.c +++ b/drivers/common/mlx5/mlx5_common_mr.c @@ -516,8 +516,7 @@ mlx5_mr_free(struct mlx5_mr *mr, mlx5_dereg_mr_t dereg_mr_cb) return; DRV_LOG(DEBUG, "freeing MR(%p):", (void *)mr); dereg_mr_cb(&mr->pmd_mr); - if (mr->ms_bmp != NULL) - rte_bitmap_free(mr->ms_bmp); + rte_bitmap_free(mr->ms_bmp); mlx5_free(mr); } diff --git a/drivers/common/mlx5/mlx5_common_pci.c b/drivers/common/mlx5/mlx5_common_pci.c index 8b38091d8741..458630351cd1 100644 --- a/drivers/common/mlx5/mlx5_common_pci.c +++ b/drivers/common/mlx5/mlx5_common_pci.c @@ -97,8 +97,7 @@ pci_ids_table_update(const struct rte_pci_id *driver_id_table) updated_table[i].vendor_id = 0; mlx5_common_pci_driver.id_table = updated_table; mlx5_pci_id_table = updated_table; - if (old_table) - free(old_table); + free(old_table); return 0; } From patchwork Mon Jan 24 00:04:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106264 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFBE8A04A6; Mon, 24 Jan 2022 01:07:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9D0942840; Mon, 24 Jan 2022 01:05:51 +0100 (CET) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id B82CE427B3 for ; Mon, 24 Jan 2022 01:05:48 +0100 (CET) Received: by mail-pg1-f179.google.com with SMTP id 187so13438788pga.10 for ; Sun, 23 Jan 2022 16:05:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X1J0QmXruFq87E8wAPFLKFy3yvEdi4WKgxvgj4zkKRs=; b=pIuWqsDy9M2R+/ybwxSazMQsQVg3/qI/Hl3r37/eWzxEyUfat81qsocbcRO+rkUKRE C0hYs+a8K8+SVXCrxRLl+aFLioUo25z0jDLA/XNcLbNYnhrmet/sntOBlq5pNsjQ4b8b y/8j73M2wTpFHW30Qr4K7zRB4nc1YQ8yt0BR5G5kWDj4t3BaKKQFyWT40NB5ovWqNAp5 RzRd4suvwomsU/3G0RZjj40E2l3L/bnU4+JPK2FnOBC5Vfw6xp7Dki+isdTwfB94QOXg b3fUI/pfp/0u02vpGqdnh7eHBuHMw9J6wa8wxoDTVFlmNZq2+4z3ptnUOzHFWVEE7I3G VPRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X1J0QmXruFq87E8wAPFLKFy3yvEdi4WKgxvgj4zkKRs=; b=rof3IYLN2n+2FeTEBdyrdDJPPnwWOmn+J4Qdk6q23T2dqb35uOJY4dwv0p9wWsoIRi /PX3WYaZO2IkSNaAsvRYEhW2cahSfJz8QQnckvxHM5vkf9OL7V7KAmRu51Ru9cQXC+2w F/caBNcOFEQhFyaneWbLG8djJ+8C3lYqdstIftGeBXO3NQ67a1JUDzZOyml/S+2CBX0f iBc1YTzAkMYwhfwzXf7TStrXjPdybCeyE7vO2ObEtMQ4aztdwJDGZJVE4TlnXw51hbb9 27omIh/ydcTU8uO0TglO2wAQhbvRU3TtvpuFtxQ0HCkEjycE55vvEJx4ywHDT2uvCE1Y OEnQ== X-Gm-Message-State: AOAM530E1n4JH2ZdSD9lyup6A5JeUq+qOYwmdrz3Pn/p95iZvYYsJGX6 Afk6IaSDkotxQ6yMWb+HYsmJhkCSqvBpHw== X-Google-Smtp-Source: ABdhPJx209WawBLcw2JNxJQLnKfkIiTwXIMs5WyZeuD1KOBLfZjo5R8YNCQ3KH8YPHRoJ12PVdX7Ig== X-Received: by 2002:a63:204a:: with SMTP id r10mr9981199pgm.502.1642982747790; Sun, 23 Jan 2022 16:05:47 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:47 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , John Griffin , Fiona Trahe , Deepak Kumar Jain Subject: [PATCH 25/82] common/qat: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:21 -0800 Message-Id: <20220124000518.319850-26-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/common/qat/qat_qp.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c index cde421eb7716..57ac8fefca3d 100644 --- a/drivers/common/qat/qat_qp.c +++ b/drivers/common/qat/qat_qp.c @@ -175,11 +175,9 @@ qat_qp_setup(struct qat_pci_device *qat_dev, create_err: if (qp) { - if (qp->op_cookie_pool) - rte_mempool_free(qp->op_cookie_pool); + rte_mempool_free(qp->op_cookie_pool); - if (qp->op_cookies) - rte_free(qp->op_cookies); + rte_free(qp->op_cookies); rte_free(qp); } @@ -329,8 +327,7 @@ qat_qp_release(enum qat_device_gen qat_dev_gen, struct qat_qp **qp_addr) for (i = 0; i < qp->nb_descriptors; i++) rte_mempool_put(qp->op_cookie_pool, qp->op_cookies[i]); - if (qp->op_cookie_pool) - rte_mempool_free(qp->op_cookie_pool); + rte_mempool_free(qp->op_cookie_pool); rte_free(qp->op_cookies); rte_free(qp); From patchwork Mon Jan 24 00:04:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106265 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E720A04A6; Mon, 24 Jan 2022 01:07:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7280542849; Mon, 24 Jan 2022 01:05:53 +0100 (CET) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 2B06842837 for ; Mon, 24 Jan 2022 01:05:50 +0100 (CET) Received: by mail-pj1-f54.google.com with SMTP id nn16-20020a17090b38d000b001b56b2bce31so3902877pjb.3 for ; Sun, 23 Jan 2022 16:05:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SVEXLdTcsVppg5dFgNaFR63Y9RESnOdSyfFIOefb5jw=; b=2gu02u3iw0OcuV+vTPVyhNL050WmMODMAWctVEaseFjLJ0DRdTqJOSscpNI3DO7ewZ PSujHyGCtN1id1uFLsEdhLSeOY5wJXcbkNMb0LbeKuZHFSIfMtXp+4FbRxM2XHNPQg7t xseBvdD/Pe34Z7pAwgN0PHUUXohq1RMbglY1kC4AjhCNCOiF7LwhhFvofmOXvsBVCa6K Ur+sW1I0eehz1fkhjO6eK7DRrCtrYFYvSefpWhqJrai9dClHqRWgVCpHoQKjgQHI7qu7 I5GTxszpcwlT2UYLEMHloDtYrRASsSoc4B/QMIyLnRNVNIbAtImjsxIXseJHxlYVPnz0 NZug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SVEXLdTcsVppg5dFgNaFR63Y9RESnOdSyfFIOefb5jw=; b=YFRz/VwV6XxSxEqA9xOCsnhdVvj40AXxdJ/7oHKtzSiPHWC0eguPIAqDmwCzg11WO8 Tg9WpqlLdHvsCsJFLOEcBK5ukHoJlfwcvZNQBLyERuCWhQ8SyugYePDhNCCDPirO8S22 85GjVjg6D2Io2Sx43kM4eAzM+APtuDWI3aN07VHJqrje31Fk2jTkX3oiFilXmaIvdo30 fVOPb/L9wJu3MVAMMdgcb1M+PZ4gu3ZyIpoJdFceXlh3NTgYutW61ztKPG5W7ynznEOf ibSz61d+m44OxrDTMLYfd2kXsxC/odYL6QcMZ/ynHhK9x2iJu6xKNjPoEQHaDKdH16Ss safg== X-Gm-Message-State: AOAM533Twr/hMF4PQ1Q6DHj84eW93Ydtgl1/G+pZfu9lt+/65naQ37Gn RpfzbIp/o2Hln1okE3HAYcBGHGwTz8zwrQ== X-Google-Smtp-Source: ABdhPJxLzdEenUYaCa7DTfNPzGlZgBEw2Xk8GBsqzsks71VOZOJtemhmVmtP5KqlMPxibskSeJdrig== X-Received: by 2002:a17:90a:3f09:: with SMTP id l9mr10666569pjc.38.1642982748796; Sun, 23 Jan 2022 16:05:48 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:48 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Matan Azrad , Fan Zhang , Ashish Gupta Subject: [PATCH 26/82] compress/mlx5: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:22 -0800 Message-Id: <20220124000518.319850-27-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/compress/mlx5/mlx5_compress.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c index 82b871bd860a..b12951da8b51 100644 --- a/drivers/compress/mlx5/mlx5_compress.c +++ b/drivers/compress/mlx5/mlx5_compress.c @@ -146,8 +146,7 @@ mlx5_compress_qp_release(struct rte_compressdev *dev, uint16_t qp_id) void *opaq = qp->opaque_mr.addr; mlx5_common_verbs_dereg_mr(&qp->opaque_mr); - if (opaq != NULL) - rte_free(opaq); + rte_free(opaq); } mlx5_mr_btree_free(&qp->mr_ctrl.cache_bh); rte_free(qp); From patchwork Mon Jan 24 00:04:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106266 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51615A04A6; Mon, 24 Jan 2022 01:07:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 639294284C; Mon, 24 Jan 2022 01:05:54 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id D5CB64283B for ; Mon, 24 Jan 2022 01:05:50 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id c9so13906492plg.11 for ; Sun, 23 Jan 2022 16:05:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XzlxU2voULKxhb3UlVmpeThkHqlmJu0fxudZRiVGg9k=; b=iz14jQuw0SNYm/amAoZomoYo+ZEnbfbXp+uo/C5uo3VNP2R9GnSYnThaSh/hOBoWwC xALvLb7/w+ladNJDnHj/0SJ4Gdx7K5MqrQ7HBvsvrzNutR6iZyXb3gwP6vNXVhvRnVPk uUeomvkPl0wxueidSQxH59WlwPpagxDHevFUxuE0vWupCcLLz4FzSGNzuUb3P+1wnSCe Rx+ahAkpaVLuGcI/W151oMOcvHBXutrMrBykywK8FAKe5aly6a7gMry1DbZwWHUDQbJt Wunx8oP7JAnBD22L9Cd98gUswzJgtAJCMXxPnYEhE2/B5WUptsyHCfQWN2HgIyis5Z22 dQXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XzlxU2voULKxhb3UlVmpeThkHqlmJu0fxudZRiVGg9k=; b=wraxN0Ch3QtSLenNRNz1L2TR1iygqgUBkm05YzQ2OjAOjWONgJAqJdIOnpfZm3WZuk XF2nwgLwjjXj2DCP0UUYIvszBR8kPT+vuMOUWmv61hIT9ZgMQmsVlDSWKoXRRAg0BHnX 1PtXZ/RozQHVdx2ZtSV5cNpirkq73CW7PHGi3enL8Iqij7Al1yFtN3E/HZYslQYnSjEq 4JP+Rz8gqnKaevapDUiRUGBgDyr4CLdR1Y13qfNSGpCqrcZROnJoSr62eL6s3z6iOiBM iOlMPdsV1eugMcYPkV5Q5sJxSFzMMLDzcUzxsrsfgddhULozvnB2T92BRPmumO3Wf5Y2 zQOw== X-Gm-Message-State: AOAM5318mT+/Fm3YjqarXygSEoKBrngTzL3GCvpPVDAHMU0l6bvY9F95 Xc9fU0AERFw0j7PUF9nkLic+sqWfRgtdDQ== X-Google-Smtp-Source: ABdhPJw0UhckkZwEeEVLLORXcIRaDnmVkAAakmBVG0VXUhsbVPqq4/PAZaCDrC2Mi3A2WS+Zs9YcQA== X-Received: by 2002:a17:902:7681:b0:149:bb15:c53f with SMTP id m1-20020a170902768100b00149bb15c53fmr12421754pll.159.1642982749895; Sun, 23 Jan 2022 16:05:49 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:49 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ashish Gupta , Fan Zhang Subject: [PATCH 27/82] compress/octeontx: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:23 -0800 Message-Id: <20220124000518.319850-28-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/compress/octeontx/otx_zip_pmd.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/compress/octeontx/otx_zip_pmd.c b/drivers/compress/octeontx/otx_zip_pmd.c index dd62285b863e..26cdce60a859 100644 --- a/drivers/compress/octeontx/otx_zip_pmd.c +++ b/drivers/compress/octeontx/otx_zip_pmd.c @@ -337,8 +337,7 @@ zip_pmd_qp_release(struct rte_compressdev *dev, uint16_t qp_id) if (qp != NULL) { zipvf_q_term(qp); - if (qp->processed_pkts) - rte_ring_free(qp->processed_pkts); + rte_ring_free(qp->processed_pkts); rte_free(qp); dev->data->queue_pairs[qp_id] = NULL; @@ -423,10 +422,8 @@ zip_pmd_qp_setup(struct rte_compressdev *dev, uint16_t qp_id, return 0; qp_setup_cleanup: - if (qp->processed_pkts) - rte_ring_free(qp->processed_pkts); - if (qp) - rte_free(qp); + rte_ring_free(qp->processed_pkts); + rte_free(qp); return -1; } From patchwork Mon Jan 24 00:04:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106267 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC4EBA04A7; Mon, 24 Jan 2022 01:08:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC3BE42853; Mon, 24 Jan 2022 01:05:55 +0100 (CET) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id CFDCF42841 for ; Mon, 24 Jan 2022 01:05:51 +0100 (CET) Received: by mail-pg1-f178.google.com with SMTP id j10so1502679pgc.6 for ; Sun, 23 Jan 2022 16:05:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Sg02TriqmdTUIJ8/c8rOF6gxigxkF8bQzUURLn3oxNU=; b=1DShaW5JYoa9sPZExDc7SkoH/5b7Yt+AHP3I/dnb1Y2IUazzIViKqAjVjZOteCau7n L4d6tm5+kZfgi6kTzZxVeGaQoL0OFne9fmfUbeHi15aO0yu7875GFhL4ELP8ztuFN00M v/w+/vcc43sTXyDhodKiPsXhzX9LnMtNbgBiZ4Veb+qUxtFrVwuLRFxWEu8XnN19tpWH 6PZVIn2A5WYXyo6oyeBPd7gohO3sJPHiCGiDkkrVBHoIXNxW3/9uPpRfKj/TnykmP4H4 rOsdELFICLlYChrlYK3RncJi+QfCNKb9w/Qag1qkpQqYzvDourPqnG4FuLYkYK7IudEC 8FxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Sg02TriqmdTUIJ8/c8rOF6gxigxkF8bQzUURLn3oxNU=; b=toUcqSSnNrOCqSwxzXo9saOkQCelKrxgUb9hcoQ2tchghrKkh1EbqFkQp7IpyYUTeh kdfJbYyVkNjD1RN0hCxfdRcYWtu4YnZp8MnXgq3evvUbsnxwiGoEqSvLlRYgjgJq0rT+ PoG96cPhMnyM1AcbLD029afP/QL2Rl6CXLaQSwppwiDUWgIEeWTnZIiAmcx2K7cnjUBG 8rZUFIUZAjjgM6l5w3r0LpoYox/f8r6k9+KW4J0FqMq1iVl1oHGyJOlZ3cnQE2fbol/8 grZmNNwkeErmlB7d68CiCBQJO0a26mvmKOzPwYEbQ+Y28RIMVp0nM1GxNU4Eh7BlWGse fucA== X-Gm-Message-State: AOAM5330aUMiiHldXjXYdk6QLojTMwya4S20x6Bu48z2HejsLcIQrOrg wp5C3KiVdy57tfrGQYrym98+f73arFh0+Q== X-Google-Smtp-Source: ABdhPJz7dj/PQqFIsGlYxtwL1AcG3B9LJjzXIVqGLpl7pirbAHPLp/4zcql5EeUcapMi9GbLAX2yng== X-Received: by 2002:a63:36ca:: with SMTP id d193mr9995267pga.88.1642982750894; Sun, 23 Jan 2022 16:05:50 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:50 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ruifeng Wang Subject: [PATCH 28/82] crypto/armv8: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:24 -0800 Message-Id: <20220124000518.319850-29-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Ruifeng Wang --- drivers/crypto/armv8/rte_armv8_pmd_ops.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/armv8/rte_armv8_pmd_ops.c b/drivers/crypto/armv8/rte_armv8_pmd_ops.c index 1b2749fe62c6..c07ac0489e57 100644 --- a/drivers/crypto/armv8/rte_armv8_pmd_ops.c +++ b/drivers/crypto/armv8/rte_armv8_pmd_ops.c @@ -251,8 +251,7 @@ armv8_crypto_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, return 0; qp_setup_cleanup: - if (qp) - rte_free(qp); + rte_free(qp); return -1; } From patchwork Mon Jan 24 00:04:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106268 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76843A04A6; Mon, 24 Jan 2022 01:08:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7EAB42856; Mon, 24 Jan 2022 01:05:56 +0100 (CET) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id EA13B427C2 for ; Mon, 24 Jan 2022 01:05:52 +0100 (CET) Received: by mail-pj1-f45.google.com with SMTP id l16so14650585pjl.4 for ; Sun, 23 Jan 2022 16:05:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hAtFWarg54jQoemb5xH5gxWjRimoG/VgzXzbglTnerg=; b=KfJxcfk2OwKdySkbfNRuWkyDCDBV+SR2eMnZUhGOAU8t+Wun3NQOltLWIwdZAZNIan r+KUhv8SvnNBt1//Axab4Se2iLf+XoMnlE9a93sgRCyTU4MzqE/RWSr7v4oHLOk6qSiW gPoT3V3SRMAS52QUxFY6VImo2Hqlse+mf9WZ4OeJZhL/hZIHDG/y1Mencp+le0bvlh3q lyWPYyRjQ3WwoVgGT80sd9MdVYbFmQNsugziLVJD45lcdUiec6nswvOLRrX/ZRlAXiWq aExTvEKrby1JDaB5QSyMqfVkag9Rv2NM/UkqvJxE360GmebSqdCq+TtDs87XYDWo4oM0 HVFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hAtFWarg54jQoemb5xH5gxWjRimoG/VgzXzbglTnerg=; b=P8WvROgnNCycfy/H7DgtofT7lpr70z88OuuWc/N2nGXXv7/Fy7ATLrudbPl9dO3CPP jqL/6/sMYLlytRhsLkmss7FSdzDO01ZtWB2W5cpV/+sPGw2WSqJ+7nLByq8vTewMnQvH pY6PeY5n8QKbk/d6WEYtLa9VChQayVyfI7m8uFlkCMpqLC+zCK5BrsUsCYIzQfcyHr4E gsGbh5rdE/LWKFgqXYpJvWe+nuD+StG2xCx6Nzsk7Fjr2VcYw/RNw9MZQrFRtIj8SkhY F2tETMqqaoT4s11iBhuNmtuZshgWIGBFKSSPfdfAslDd/kkQ+7fweSlQ0szPFPdayUeu A75g== X-Gm-Message-State: AOAM5307ZZQIzK3Y63pO6YkfKhRQCgICu1VWt7EJwxSfYhMXJgJhRB0H crDyXUxrIN+91I7K94Z8Zi4Dr64FdFl4AQ== X-Google-Smtp-Source: ABdhPJy3wuSS82+XWHiDLMQwWRgwEhP5EPvUKKvzTwqAojCtAoPojyDXzgQvbrIueSTGll2D5U7I5w== X-Received: by 2002:a17:902:9a83:b0:14a:a893:f7ff with SMTP id w3-20020a1709029a8300b0014aa893f7ffmr12388116plp.6.1642982751893; Sun, 23 Jan 2022 16:05:51 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:51 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Chandubabu Namburu Subject: [PATCH 29/82] crypto/ccp: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:25 -0800 Message-Id: <20220124000518.319850-30-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/ccp/ccp_dev.c | 3 +-- drivers/crypto/ccp/ccp_pmd_ops.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ccp/ccp_dev.c b/drivers/crypto/ccp/ccp_dev.c index 0eb1b0328ef0..424ead82c3aa 100644 --- a/drivers/crypto/ccp/ccp_dev.c +++ b/drivers/crypto/ccp/ccp_dev.c @@ -673,8 +673,7 @@ ccp_probe_device(int ccp_type, struct rte_pci_device *pci_dev) CCP_LOG_ERR("CCP Device probe failed"); if (uio_fd >= 0) close(uio_fd); - if (ccp_dev) - rte_free(ccp_dev); + rte_free(ccp_dev); return -1; } diff --git a/drivers/crypto/ccp/ccp_pmd_ops.c b/drivers/crypto/ccp/ccp_pmd_ops.c index 0d615d311c9b..1b600e81ad5c 100644 --- a/drivers/crypto/ccp/ccp_pmd_ops.c +++ b/drivers/crypto/ccp/ccp_pmd_ops.c @@ -744,8 +744,7 @@ ccp_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, qp_setup_cleanup: dev->data->queue_pairs[qp_id] = NULL; - if (qp) - rte_free(qp); + rte_free(qp); return -1; } From patchwork Mon Jan 24 00:04:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106269 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E5C1A04A6; Mon, 24 Jan 2022 01:08:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 893CE4285B; Mon, 24 Jan 2022 01:05:57 +0100 (CET) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id 02A074284C for ; Mon, 24 Jan 2022 01:05:54 +0100 (CET) Received: by mail-pf1-f175.google.com with SMTP id i65so14225176pfc.9 for ; Sun, 23 Jan 2022 16:05:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v6oHjltU17sKMlDqBS4DiHlqms74CbqMv0yAWufZ2pE=; b=3knzJiI5fac1WvWMGWRyLe65HYNAZ6DNmeqw4KfSd7vuSpIqfsvobLjVL8bY+sl3xy wSDjLYTNDzC7bc0Ad5Tu58noKwX5bOWxz28s2TZDYpIiG1w47AIukluauX/jgNrq465g em4hzpAvNPIY7Tz+YS9WJyjSLS/ya3mBsjHRhfIhDC/FEJsPsquK0X+x82yImm2WWtHl Z2ujz+MrYAesVHCswaU3dwJEayEeRrLqwSYyS8Nnytrar58wvpF80rd1Zhq4HTD/lpHz /uMwabTZkbN2HK/egOTbT2zxAaoQiKAnbVylTrenVMPP0KRdJPxsqodvt4hDI73gGES5 RUWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v6oHjltU17sKMlDqBS4DiHlqms74CbqMv0yAWufZ2pE=; b=TIU6oCmUkIs05yaHL75CCe6/MKoTMxk5FwPi4QRpgSUooES4czeZ2ksOs/NPi1ttAn dNS3h0SLMWUEK/dimSsfAqb6CDNKono6RCzLZexv+CRkiKywUrsZ97D1cmRWtRndNB7C o2154VrTFicfD8w9DTcymw6vGHRaUxRPjIPMFiMLFvSLiRgaF/oXv9lB1Kv4Arqyh21d eMd/j3EFY7NSBjD+IX/4cDUvye04Zy910j2Ytx56lY7ybCCEXVEvGOLsF8VqAs3pIDkw 90LWQSvLnWBaxuWpLY2bglSzZSJmJ0rNizLMjjwlIzpNoD3N81eoAtGL8GHVNb57CRP2 ehoQ== X-Gm-Message-State: AOAM532tZtl42YH1GQxv1TM/LcgZLtWGteRuGSGBdpaZdNWuQiZfxqLp nBk+O+D+Og7hBUxaNTjUcRAu++LROFpNvg== X-Google-Smtp-Source: ABdhPJx33UON3+kjAxKuNWkfUID87gYNDfw0AA22cMyojiMJO+eY3jFu8ezdxdCdAljaT6EtbOG7Ug== X-Received: by 2002:a63:8749:: with SMTP id i70mr10060698pge.41.1642982752973; Sun, 23 Jan 2022 16:05:52 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:52 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ankur Dwivedi , Anoob Joseph , Tejasree Kondoj Subject: [PATCH 30/82] crypto/cnxk: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:26 -0800 Message-Id: <20220124000518.319850-31-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/cnxk/cnxk_ae.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_ae.h b/drivers/crypto/cnxk/cnxk_ae.h index 6222171fe603..01ccfcd33432 100644 --- a/drivers/crypto/cnxk/cnxk_ae.h +++ b/drivers/crypto/cnxk/cnxk_ae.h @@ -196,13 +196,11 @@ cnxk_ae_free_session_parameters(struct cnxk_ae_sess *sess) switch (sess->xfrm_type) { case RTE_CRYPTO_ASYM_XFORM_RSA: rsa = &sess->rsa_ctx; - if (rsa->n.data) - rte_free(rsa->n.data); + rte_free(rsa->n.data); break; case RTE_CRYPTO_ASYM_XFORM_MODEX: mod = &sess->mod_ctx; - if (mod->modulus.data) - rte_free(mod->modulus.data); + rte_free(mod->modulus.data); break; case RTE_CRYPTO_ASYM_XFORM_ECDSA: /* Fall through */ From patchwork Mon Jan 24 00:04:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106270 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14B0DA04A6; Mon, 24 Jan 2022 01:08:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79C5B42861; Mon, 24 Jan 2022 01:05:58 +0100 (CET) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 0780B42850 for ; Mon, 24 Jan 2022 01:05:55 +0100 (CET) Received: by mail-pg1-f173.google.com with SMTP id q75so13646412pgq.5 for ; Sun, 23 Jan 2022 16:05:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NMDYOBW94oD7LiU+bA7rZElZJGIO2nROgMHnOqTiJ24=; b=k/sUkqw87/TGjBZ4/y/dm9B2NQEVKk3NSzxyu/unlzWCYILLf5fd2QXeUpdedO+X7C Btu1YfB2qn6PoZehvFG8/QQeDPcHbwZcMrulyDmM/JH7RibM8fCEBP1m8KPVOPNn3CcX ZgmkD9ZsZvXmpebgioIbVSCp0w01OzxhL7FzT3uLw+l0cjmEwSgYi2K1URxomxGfNhoE K7j4AIAPu4ZkHaEXZ0xiOoSlbUDZLYQfOtJK0G/WkLg792YSkpkjUIjetc9Fm1ikJTsy cD7UvlLf78We/dUQf0/o+DXpcEhDIjASNRtzhoIe37XYBJmpk8jRMGKd393Y40RTC/2z JyHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NMDYOBW94oD7LiU+bA7rZElZJGIO2nROgMHnOqTiJ24=; b=ojgpJpnh8q34yKiq6GNTgONZ8WCfbXbt44vTUoiszAgbgEqCKYt3lJxqIcxylrMB/p CPWMcYgLYP1Z3DgaX9xmZybYWSRsvjDp/u9WVzD5+5RZQepd2KYRX+CLI242li/j14Cz CyYJVXv8XmOH5tMmmH/tkbiVXCx8+2d6kVd7egK6zFBgzFMX0KikYZhnpQWJo/nvAwmb BbViZJL7d6BegN/noI4l5SaBE6t3ce4gdchTvnRTolcGyCKP9G8dFGFffbRJzZ3P7aGP rDcqdJEv/PUEcpugpLei9WaPy2lcJC/mHAD7S9HtiKocEtsd7QA2kvnXY1gQfO7jG20p ztOg== X-Gm-Message-State: AOAM533voLMjriPmBOmENg4OS46qVLAhFx01Mb1E8+0gM9fhjx6xuSa4 zRLqY+qzk4YrnnRjOfP3kQttfKnSQmfyRQ== X-Google-Smtp-Source: ABdhPJzVhNBfpkeyoXHDf+2y04/9TKlYPcuTL9Og/3oIRQsvolhtiUm4Y2krSBrHHrmxv8U36/7dRQ== X-Received: by 2002:a65:4482:: with SMTP id l2mr9970157pgq.141.1642982754038; Sun, 23 Jan 2022 16:05:54 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:53 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Fan Zhang , Pablo de Lara Subject: [PATCH 31/82] crypto/ipsec_mb: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:27 -0800 Message-Id: <20220124000518.319850-32-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c index 189262c4ad52..f808da9edf89 100644 --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c @@ -102,8 +102,7 @@ ipsec_mb_qp_release(struct rte_cryptodev *dev, uint16_t qp_id) if (qp != NULL && rte_eal_process_type() == RTE_PROC_PRIMARY) { r = rte_ring_lookup(qp->name); - if (r) - rte_ring_free(r); + rte_ring_free(r); #if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM if (qp->mb_mgr) @@ -291,8 +290,7 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, if (qp->mb_mgr_mz) rte_memzone_free(qp->mb_mgr_mz); #endif - if (qp) - rte_free(qp); + rte_free(qp); return ret; } From patchwork Mon Jan 24 00:04:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106271 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C9EEA04A6; Mon, 24 Jan 2022 01:08:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5807F42866; Mon, 24 Jan 2022 01:05:59 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 10C3E42850 for ; Mon, 24 Jan 2022 01:05:56 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id y17so3567331plg.7 for ; Sun, 23 Jan 2022 16:05:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e+qY8seeWaYoQVrTUghY5Eb0w7nKmf1/blL1bLaw3rU=; b=3aM2e5eb/IwlkD9bYUpl3kwyLp9grZGTN5Il6cc3ptKmfWb4JSE2SgW1mMMUWS8vgB VJ/9Czuhpv8uvg1CDmvoFIbN4bZSlpesyEty9QgUyx0qoA74P96cybgZCbZCBbxY6/ld wkn6l2v7I4FTiXF+JMHtnrhYas2i+ZoHli2CQ4JaFXWAccCzbS1gJ2kI80uhyDF9M/s/ Ij+Zixq/hJI9pJy54BStZfacA+wLDw930V0Pb9HxDlqXZ0lVTOW/HhZHli4LVD8HXcCG lHQMJl/igxMqh4h8PWgFuJWk+L9Y3CeZQ68rweOZuZ9n2Nq2x4P6wOq3jEhaO89+AMKs 6+Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e+qY8seeWaYoQVrTUghY5Eb0w7nKmf1/blL1bLaw3rU=; b=5cHlJu/Nx6z5jWd6m5cqXM96beeoJ87b/FOHE7iY/Q3/NeQ2Pet0NcOPe7GFWjqolU 3EnVuoQxr7KLc1n8ZZOxP3vqbwIPNPO9G62di8jUj6m9eomQQmDeX/omht/TILOMzHb2 SbqpxNqWQMLZfKPcBReeOc/VIcHH6jxgFzXKIPcXl9M43X8wInnuKxjlNTxLGOlD/zX8 nbUlq4lJ82h08WbrtFO0FXpgyRA60Ud4kE6mKfplfCHSlyenM6axdECJCz4/l6wn7vhN JmmG9CpPfH+0MMbsVg3hJCR765ntLGyRRT+kVsip3wP+XFYo3VOqbD2KQCZ487iL4V1D dAoA== X-Gm-Message-State: AOAM532LrTqZfPb6ir22hOpEpNYZ6OiSaUycBIoSmIrrpq0F8L1EwEGQ y7wrBbGzxFabpxouG6IOQqEn1JdgwPmdWg== X-Google-Smtp-Source: ABdhPJzbmGoGbmxrI8IWh6/64pQtfCGYQTD6bDr964QcuLiN9g00jvACgnY8sRYkagJyMqYWgYseQw== X-Received: by 2002:a17:902:d682:b0:14a:ec57:26fb with SMTP id v2-20020a170902d68200b0014aec5726fbmr12425052ply.114.1642982755049; Sun, 23 Jan 2022 16:05:55 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:54 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Michael Shamis , Liron Himi Subject: [PATCH 32/82] crypto/mvsam: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:28 -0800 Message-Id: <20220124000518.319850-33-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Liron Himi Signed-off-by: Stephen Hemminger --- drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c index 3064b1f136fe..f828dc9db5f6 100644 --- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c +++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c @@ -774,10 +774,8 @@ mrvl_crypto_pmd_sym_session_configure(__rte_unused struct rte_cryptodev *dev, } /* free the keys memory allocated for session creation */ - if (mrvl_sess->sam_sess_params.cipher_key != NULL) - free(mrvl_sess->sam_sess_params.cipher_key); - if (mrvl_sess->sam_sess_params.auth_key != NULL) - free(mrvl_sess->sam_sess_params.auth_key); + free(mrvl_sess->sam_sess_params.cipher_key); + free(mrvl_sess->sam_sess_params.auth_key); return 0; } From patchwork Mon Jan 24 00:04:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106272 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1941A04A6; Mon, 24 Jan 2022 01:08:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4489D4286B; Mon, 24 Jan 2022 01:06:00 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 0693342859 for ; Mon, 24 Jan 2022 01:05:57 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id u11so13911956plh.13 for ; Sun, 23 Jan 2022 16:05:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=llBygSanMW5E+5xDHm7JWnwIOrSI9+QEhb8JdIMleRw=; b=Nden/EbwKZS0mWwlZXiEWCAGhp0UdvI/FvyhMEWnPFv6xw96OYwrabMVqklhLeezpm CAO/y3D9ch1TvQvtlj0N4EGDnoxJd1Bksc6uuDPbqhW2DnYnu5E0iZfqc5xGsFR9N0lc XbH3IZuA4Yq3/v77o4BfpzBRkp/3jYTHdPkY7ezzXJnWKhsQn/TOkhkRw2kDVr7vX1B8 1lat7VVnRO/cNhOw/GzzT/gyYO7HQiics6vVrmAdQ88UHu/QlT0dyi1Arvc74tTStpMf gIxbneYgUsD/bfSmEG1ZhgFFhXrqHljLX5taFLrdQUxineKYTPXLUP1NwgSwE9iAlc0i vPDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=llBygSanMW5E+5xDHm7JWnwIOrSI9+QEhb8JdIMleRw=; b=eXTWHEjSjvEo/TsbgF5/fDlSl3yG+h3SdZZgA8UBw7fwR74WqopQEIFtK8QJlER/MA LRnKg8SEqQ+E6dVvJzr4pNEsmQ13ZHTGFGQQcV8qfeHrBPztNY9AvE9/7gCZXOIvPRvr PB4j/81FuoRBz1d+MXSLfs7mMnQ8fJhFQiV7E0l3FKMPvY4Qw5aVZJm+azoz2vIh26tX dOLSZZ+iQG2rxxpqafUKlluEOstxA5bZMzifVL8rkj3qJXo7Ap/dJfCrjeo++oQCpi9A 5wOiEbRWK4EB3m9jjC8RjnCwRSkPY5SYgFZKGZRQrU6ZvEjAvKXrQti8FJdTo5ELQNfV 6KTg== X-Gm-Message-State: AOAM531N2PDOV1okC9btMg6w6nxxZXyP7txOrZPxmLq3BssTR9rKENeq tDKPf5md7m+8ZYLTfy2+CNB2/4zZvdaZNQ== X-Google-Smtp-Source: ABdhPJxdHQZyuHIuxr5MFwUGNoCnNHLx343ykcqa+FoxbNDuuM+JH5wTGsmaehnPRUEcEMJw7RyEmQ== X-Received: by 2002:a17:902:ab09:b0:14b:2640:6432 with SMTP id ik9-20020a170902ab0900b0014b26406432mr9478519plb.45.1642982756056; Sun, 23 Jan 2022 16:05:56 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:55 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Declan Doherty Subject: [PATCH 33/82] crypto/null: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:29 -0800 Message-Id: <20220124000518.319850-34-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/null/null_crypto_pmd_ops.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/null/null_crypto_pmd_ops.c b/drivers/crypto/null/null_crypto_pmd_ops.c index a8b5a06e7f4e..90a675dfffe0 100644 --- a/drivers/crypto/null/null_crypto_pmd_ops.c +++ b/drivers/crypto/null/null_crypto_pmd_ops.c @@ -135,8 +135,7 @@ null_crypto_pmd_qp_release(struct rte_cryptodev *dev, uint16_t qp_id) if (dev->data->queue_pairs[qp_id] != NULL) { struct null_crypto_qp *qp = dev->data->queue_pairs[qp_id]; - if (qp->processed_pkts) - rte_ring_free(qp->processed_pkts); + rte_ring_free(qp->processed_pkts); rte_free(dev->data->queue_pairs[qp_id]); dev->data->queue_pairs[qp_id] = NULL; @@ -241,8 +240,7 @@ null_crypto_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, return 0; qp_setup_cleanup: - if (qp) - rte_free(qp); + rte_free(qp); return -1; } From patchwork Mon Jan 24 00:04:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106273 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E12C8A04A6; Mon, 24 Jan 2022 01:08:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 914C942875; Mon, 24 Jan 2022 01:06:01 +0100 (CET) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id 1B1D942860 for ; Mon, 24 Jan 2022 01:05:58 +0100 (CET) Received: by mail-pj1-f53.google.com with SMTP id my12-20020a17090b4c8c00b001b528ba1cd7so9830486pjb.1 for ; Sun, 23 Jan 2022 16:05:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tcc+pf7RWRS9XlLi6yUpiW4SL86hMusm5V+NE97dykY=; b=GByoc0kLDdooGe3aBMTnPmOfONOQccnzb5ZSbf0Fk6VibLGy3vxF1CoIqJpfL0zgSs l24mftkcpjMeqT0WhUXk7BU+zJLAZh4iCZBn/iA/YzDyLA6Lbo7hEmYt+INCXlOtQ2sG kUwrm9/pgRJ6EF2c1Qx7XEF9wShQXgHhGaLFkFohq62RIdQhQCncPH0lsIDEVhgn/C5i vX3zg0k/l0txb/Tqcb2OwWR1Bwpr5MfhtWnuJKS1qSpGeEr7yejBYKOmRRHatgfrDiTR G27J+fHMtFVdrYTD2lGyCXzyF5Vk+iNwq3KpIi+pAOY2RMvOlL6WvTNc6DEzqMLETo7h LlWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tcc+pf7RWRS9XlLi6yUpiW4SL86hMusm5V+NE97dykY=; b=vI24lleT7nyJKWZz1pfnJd/OIbQ+YwXuiUDd8bM1GNDBIYYm5gG8X0rWqVwzq0D2cY 4iOL1lD85u+RpVGYfoiP/oL4u/uOWyyg6Jhp8NyUazW5iadgAxKJTvSya0M7FPTyPUV8 J7R17qG2WQQtsrsEC+KFU9Uu2uH1fIQ2z+5GGyEgENtHFoJT9cGFRsEfo6AzwmkQKtVR gsgcC5Du/sP96nKanQt0E8noolhW4q+cFxCgQM2rOit6JJPLR6PflIYVU/9Y48Zzs43W tHjqZw6VtUnWJSI+Hn/eNsDGMqNP67VVCxhJBpT0RllnhN6Fo/c460bay2r337lXOMSc 7QVQ== X-Gm-Message-State: AOAM532RSESSDiiq+X/qX+x4d14cY1rry+rqRLWDuksMvNHIoB8zXX8u n7LBagdWqOcgKdEvsC/BxQj9zIzUJ8r6Ig== X-Google-Smtp-Source: ABdhPJwmfCplkgyOdJcQXiwNN7FeMIm/Vlse9cIkQJUgXM+G3+goHVAbwVnomM6JhmrQMr7TZIpF/g== X-Received: by 2002:a17:902:c40d:b0:14a:96a4:1044 with SMTP id k13-20020a170902c40d00b0014a96a41044mr12548353plk.50.1642982757040; Sun, 23 Jan 2022 16:05:57 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:56 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Anoob Joseph Subject: [PATCH 34/82] crypto/octeontx: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:30 -0800 Message-Id: <20220124000518.319850-35-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/octeontx/otx_cryptodev_ops.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c b/drivers/crypto/octeontx/otx_cryptodev_ops.c index f7ca8a8a8e90..f1aae481c3c6 100644 --- a/drivers/crypto/octeontx/otx_cryptodev_ops.c +++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c @@ -335,8 +335,7 @@ sym_session_clear(int driver_id, struct rte_cryptodev_sym_session *sess) misc = priv; ctx = SESS_PRIV(misc); - if (ctx->auth_key != NULL) - rte_free(ctx->auth_key); + rte_free(ctx->auth_key); memset(priv, 0, cpt_get_session_size()); From patchwork Mon Jan 24 00:04:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106274 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC820A04A6; Mon, 24 Jan 2022 01:08:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8943D4287B; Mon, 24 Jan 2022 01:06:02 +0100 (CET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id 107D242865 for ; Mon, 24 Jan 2022 01:05:59 +0100 (CET) Received: by mail-pl1-f173.google.com with SMTP id l17so7722228plg.1 for ; Sun, 23 Jan 2022 16:05:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hETS2FMWtkgnpp1IU7jhzCtiLY7P91TgJUmKY6LlPVg=; b=2V2mYIJ1Qs816uped/Tj/sg7L9iFX99FwWmodfeIpzBu6fOnboDyvho96vPYh35AZv enQ8j4GrNnpPMXEb2JHcFDd+4AQ3XVqrpHUwBdbf/NE9VvxuKJXjb0YnMc1GDktzEazu g+aLCU2r2s0O7lAe1d+1dS8aAHHzu7v6JWi3liXWVBITxjVrTWx0wUbasQl67ysbeGsd xU8VOwKIJnREwd5UtvzzNTH6staSs1Ssei9wFH8mYlEYR7kDUFz/a0lKayTqtAL9/LMe yoqjknW21aQ0XdURkOlT7SPdUBkGB2RPebCv6WLCAsXvmCiVXRZIINCk74kJXeykeeOS 0KCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hETS2FMWtkgnpp1IU7jhzCtiLY7P91TgJUmKY6LlPVg=; b=ytONp7gp/R6o5ZSxWiKivBagDreWcHgYtE1CdCKAEdHT0w1Oq4EBbHQ4MfWWPuSJug okELd1J0Bkm64W17hccS5cA9CtCeHkj6icMfyHtZU6oa9yPGu9R8+3MVK/bgO7FuG19G JtFA3FYpyV2xTjW60ek7OhMXP2GPlGUT0OFca9UJGBzx9j7p9ifGQs9pIYi23DaO2R3K 9ddibZmDv5d7E5Jl6O6iSbt0y89f0pAmKHEsIzOPPVCRSb1XNbMRyr8vhpFxaHhJE3pj UthojljHTLdjUFcxNU0oDxfr7/U0BuCLx0pXUc5UpTpzqfn0Slmq4RUjvba9IvQQRqvr 4XPA== X-Gm-Message-State: AOAM532O0LD1qc74WDjjcbCoEUf00ZlFBJYTGyHhfS3FwusjPA3kdIcy KbPsJn/DQTDlIaq8x0AT9Xfcyemz9c0ZHw== X-Google-Smtp-Source: ABdhPJzUEADK+VDB4ZiiCb8heGNTM5VofInC2I2flJkMXf9ND68aCY8n+t5zqiD1LmUL8SQx0+mkQA== X-Received: by 2002:a17:902:d4ca:b0:14b:5c6d:fc16 with SMTP id o10-20020a170902d4ca00b0014b5c6dfc16mr747047plg.24.1642982757997; Sun, 23 Jan 2022 16:05:57 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:57 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Declan Doherty Subject: [PATCH 35/82] crypto/openssl: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:31 -0800 Message-Id: <20220124000518.319850-36-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c index 52715f86f84a..b1c0b14fefd2 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c +++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c @@ -659,8 +659,7 @@ openssl_pmd_qp_release(struct rte_cryptodev *dev, uint16_t qp_id) if (dev->data->queue_pairs[qp_id] != NULL) { struct openssl_qp *qp = dev->data->queue_pairs[qp_id]; - if (qp->processed_ops) - rte_ring_free(qp->processed_ops); + rte_ring_free(qp->processed_ops); rte_free(dev->data->queue_pairs[qp_id]); dev->data->queue_pairs[qp_id] = NULL; @@ -748,8 +747,7 @@ openssl_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, return 0; qp_setup_cleanup: - if (qp) - rte_free(qp); + rte_free(qp); return -1; } From patchwork Mon Jan 24 00:04:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106275 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2A77A04A6; Mon, 24 Jan 2022 01:08:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A622942884; Mon, 24 Jan 2022 01:06:03 +0100 (CET) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id 0B13542869 for ; Mon, 24 Jan 2022 01:06:00 +0100 (CET) Received: by mail-pf1-f174.google.com with SMTP id u10so9694012pfg.10 for ; Sun, 23 Jan 2022 16:05:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F7D6wuAznDOFZ2sEbMzVSYJuoXX5dzlpWYuMPiHdWD8=; b=x4oPYbczQUHsZNmyQU5bKWg4vVGkyec52aa2vMh9+BXVhUr2T5+irTlJd2BAuB77by UMFHOWg7zP6xPJhrLHMf8SBZ31EWYLSU5bpns7weiK2+jTD64N+uzwUOe5mBClL0HrXL DOc7CUHbKXvUH3VfUwrBuh1RyEW4wDRf3qYKd2VihZcaBJ93w5IlWQEGhUdnD50qIMR8 xTrCeX7KvsLkYIg7RjaVP0v3bKSIeMvVLhpWi8JDuJFmKe1tclFbpDqt/r4hZeksYCOc cQZGARtXNm+3tqdK0ilo2ItgshwCAT+c1aqJYDAqt0IhlGV3Yyp//VAcp4rh5yFZwUTj /yXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F7D6wuAznDOFZ2sEbMzVSYJuoXX5dzlpWYuMPiHdWD8=; b=QuwBjd3MhJayn2R41X1CBkP3ihsHBBDkO+GxZoWfCxCEWgAo2QxnVhLqz1/g2sd4VB mRXbkF7MRN+XtgCaOxZ5JFQmBhQsRL5vGNyDIDTvt3lFTdsdQB8lKvlzUFJUz/vyQ+zw fNQHEykX1nXDfbH4kzQDhTyDSYXwv0eKDwc43xcO6QkpAGDKUf1gSM2PKZEKb16jaX2r JxVbRc29o12ohAx+Fl4lMQDfqyFwR/vZhCTbe54ltVa2/yUtNcv5JRWyRNPQvpAE6tKD 4EuIEcay3S0sZ6NmQi3yapdnxRMCXXhGHD0YAcrwrfKU27Grq2WQHzuI0ZEHKPmHpKnb gYXw== X-Gm-Message-State: AOAM5338QNYAOI3CZCRS3oaexYPnAeECfQLy5mmhRKqVavwsW/7Rar+N Fsthg+d4rNgtPmZWsoLM26O/aKksQiVHmw== X-Google-Smtp-Source: ABdhPJx6Y4TFbkZTaHvs9QifaTcLd4UbS4xY525vebw0TKu+L+Cx8TOSHLFxDU+HZvF76ydvTOLoSQ== X-Received: by 2002:a63:1562:: with SMTP id 34mr9923919pgv.15.1642982759063; Sun, 23 Jan 2022 16:05:59 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:58 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Fan Zhang Subject: [PATCH 36/82] crypto/scheduler: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:32 -0800 Message-Id: <20220124000518.319850-37-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/scheduler/scheduler_pmd_ops.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/scheduler/scheduler_pmd_ops.c b/drivers/crypto/scheduler/scheduler_pmd_ops.c index f61640c9d646..f3a1bd626c6f 100644 --- a/drivers/crypto/scheduler/scheduler_pmd_ops.c +++ b/drivers/crypto/scheduler/scheduler_pmd_ops.c @@ -371,10 +371,8 @@ scheduler_pmd_qp_release(struct rte_cryptodev *dev, uint16_t qp_id) if (!qp_ctx) return 0; - if (qp_ctx->order_ring) - rte_ring_free(qp_ctx->order_ring); - if (qp_ctx->private_qp_ctx) - rte_free(qp_ctx->private_qp_ctx); + rte_ring_free(qp_ctx->order_ring); + rte_free(qp_ctx->private_qp_ctx); rte_free(qp_ctx); dev->data->queue_pairs[qp_id] = NULL; From patchwork Mon Jan 24 00:04:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106276 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3B84A04A6; Mon, 24 Jan 2022 01:08:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CA114288A; Mon, 24 Jan 2022 01:06:04 +0100 (CET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 0AB30427BC for ; Mon, 24 Jan 2022 01:06:01 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id e28so9785762pfj.5 for ; Sun, 23 Jan 2022 16:06:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6V9Q1x1ay+tYytT9xq7nAcA525Y1BSrTieqlJ955eIs=; b=UxCZBqyu6MSvf11X954JLN/1HKU1fI1b43AVJgVJ5k1F4c9XeVN2QKzd4fSJOL8+A6 bwhSNyElTS27srZMhUgopjqKkjYzPfEDVTY9j5G+h6jCCJNG6dVwWXFhb28QsxfQbhH7 KGtDOr9Y0DebmOLLQ6ilLJcm78SxY+SRjhbvpgsweLCWfCTIA7YYDRMCeGVJChZlOafC FJBq4c3FS1bOvolBX9jUeHJQjm5j2kVTUPZF/wiyPUDjVUCx2nJiFqDToy0YJp3SpGgp T8cAdPK5cVU0Gfm4TIJpImFG1ZcvHPl6mOe573W8avjEWNRdtr/T/PtEFF7m9RYjOU6z YwIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6V9Q1x1ay+tYytT9xq7nAcA525Y1BSrTieqlJ955eIs=; b=FBm8tnAYrXJQwVYfWz6N7GtToDTw753wR247sOEEWfIe+C/71kbdv1fqw+Kl1WQPD+ GqaW+hy4GSNF6LfihAMvJQCIwR4sl9tQUjgZUDlMgV92GBXaF+5Dw3U8c9FwlH7u5B/n ubo7GPnmZ/OAjG5ixzEstFGUTjjuBhCsi50E6vHHdQWmnAbB+SMZ6G7EP4GwsiPER0D/ Qv9Bac5vo4e7mF+Hkk4YZXJZKBWpzeBxyOft8gDmlTP1fLlUeegyPf4lpBnxOv+YkHog C/tVhToZmANlN8VTc+TB3OBNAw1Eqq7TqREql86ts87TN2TZNwwXEhWCBa/ExIzFV1Gn Ztvw== X-Gm-Message-State: AOAM530AnsAEErfvMjoXg/xzdDJMHmb0LjWICQpHGTmUwLWyTqg//Pke 9oHuik3LQrPSf+4tMHyw3vU5VPr1HQIjLQ== X-Google-Smtp-Source: ABdhPJxtPPXHFhaNMfQHRJOFqEv93JPTXfFiWmsgfOigCDVgtejZNK1QSWnl9eRsJ31kws/hHZP/sw== X-Received: by 2002:a62:7506:0:b0:4c7:cf2b:81b5 with SMTP id q6-20020a627506000000b004c7cf2b81b5mr8143238pfc.54.1642982760048; Sun, 23 Jan 2022 16:06:00 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:05:59 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jay Zhou Subject: [PATCH 37/82] crypto/virtio: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:33 -0800 Message-Id: <20220124000518.319850-38-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/virtio/virtqueue.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/virtio/virtqueue.c b/drivers/crypto/virtio/virtqueue.c index fd8be581c996..3e2db1ebd250 100644 --- a/drivers/crypto/virtio/virtqueue.c +++ b/drivers/crypto/virtio/virtqueue.c @@ -32,10 +32,8 @@ virtqueue_detatch_unused(struct virtqueue *vq) for (idx = 0; idx < vq->vq_nentries; idx++) { cop = vq->vq_descx[idx].crypto_op; if (cop) { - if (cop->sym->m_src) - rte_pktmbuf_free(cop->sym->m_src); - if (cop->sym->m_dst) - rte_pktmbuf_free(cop->sym->m_dst); + rte_pktmbuf_free(cop->sym->m_src); + rte_pktmbuf_free(cop->sym->m_dst); rte_crypto_op_free(cop); vq->vq_descx[idx].crypto_op = NULL; } From patchwork Mon Jan 24 00:04:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106277 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26457A04A6; Mon, 24 Jan 2022 01:08:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FCDE42892; Mon, 24 Jan 2022 01:06:05 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 0B6FD42879 for ; Mon, 24 Jan 2022 01:06:02 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id u11so13912054plh.13 for ; Sun, 23 Jan 2022 16:06:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b9RGmpF2C2wCCBfC5oLCxPoLV/E07bsYUzvcP+VGLAU=; b=outJIQzehyVGsUcxsnDMPZpoBIYFmRWhqXy6Y1+Kcuwc9zaCrBnr9B4w7yzrIj+KCx tV8HIjaZkx9EXxykZcKNyD1DY7C0EpJQ9rSvF7uzBiPu19mopnuPM65xM1TDhRA+BSFm 7TMyv21bf4WfeYFTu+DvXdpRqVVb5UTRNI+dYTd7yg2g806MEvbpAE0CxUlZrMtY4yxT aKkonSwpO1du2CV0RM9a1LIF0LBsRxNWYuj6QureG3geMGlkwdMyciFHa7LalksKyguZ pf7F7FA3qApOPOCM9j/vOIXzlUUo9wAza71gzyyp5sQ1CmMYDD1vPmLpsQ3UmL4gHpim JX9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b9RGmpF2C2wCCBfC5oLCxPoLV/E07bsYUzvcP+VGLAU=; b=0PDnZ5JLtDSfTTpqPlE3IHnbLFwsL8Liba9MxBEfwtKPTYo4LxyU0TC0C5RrE6pZlJ YQUW+AUYOEYtB+EKqdP0Ijdg7ii9ieaVe3t7ggkEWNnxAPi41PUkiOq1Sr9tMXu5beg6 9cfW+1N/aNLVpfPBHih4IrTgHzIGeiogQCEPCHnepT1grtWkEpJhEy3N+F+VWLncVHx0 0v7Ec+jrSyy4wjdqSwBeu0goKZsOHFWjSqtdcWSb/ffDFRFAb+w265RsnZRtLDwk1PCb ioSmJi5MKMfx/SXtrKAQ6Nb21lb1A+oU7X6R/s+8mN2kopSP/AqncsBBqvfjCRUK3Ei/ Ouhg== X-Gm-Message-State: AOAM531JvTB2CGzf56M41c7PJ91Hk6fi6bMLC+F9z0Wz342ZuRhFmuJh +Ao3lbytcb0dMfzAN1jGi9VXQJyaxnwB8A== X-Google-Smtp-Source: ABdhPJzxr/2d4Zl8MqBDr6iWf2K/ZoEYltkBrNfFDnvx+Kmjf2xa57XkTjjLk/DKJ6F7D9aRxJeSlw== X-Received: by 2002:a17:90b:30c9:: with SMTP id hi9mr10513349pjb.68.1642982761054; Sun, 23 Jan 2022 16:06:01 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:00 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Harry van Haaren Subject: [PATCH 38/82] event/sw: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:34 -0800 Message-Id: <20220124000518.319850-39-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/event/sw/sw_evdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index 6ae613e0f2e7..ba82a80385b6 100644 --- a/drivers/event/sw/sw_evdev.c +++ b/drivers/event/sw/sw_evdev.c @@ -526,8 +526,7 @@ sw_dev_configure(const struct rte_eventdev *dev) * IQ chunk references were cleaned out of the QIDs in sw_stop(), and * will be reinitialized in sw_start(). */ - if (sw->chunks) - rte_free(sw->chunks); + rte_free(sw->chunks); sw->chunks = rte_malloc_socket(NULL, sizeof(struct sw_queue_chunk) * From patchwork Mon Jan 24 00:04:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106278 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C9E6A04A6; Mon, 24 Jan 2022 01:09:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9944942895; Mon, 24 Jan 2022 01:06:06 +0100 (CET) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id 07B514287F for ; Mon, 24 Jan 2022 01:06:03 +0100 (CET) Received: by mail-pg1-f169.google.com with SMTP id 133so13678115pgb.0 for ; Sun, 23 Jan 2022 16:06:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BLI65pAkl2Uesd7NXA66nH3tfFeFOpHNaRIG+fzMF3I=; b=Op7nZXJSCiJprNkPnxwVU6+YcPIoovxqdS2VG+r/J4Voda5ALl8diDaIAI9GS34XS+ yGigD7XxMrdBpz4SV2C9Q0wiyG0FTRfxw9mDYoEilMcrzBRG0h3QhxUZWjncx0JMaJyr KLqOzwDGlFWlofk29qcCf80R1/XDKMjTmOkHG+yduaq3jyfV/RdnteOoArTs+PbKE3eb o3/F4tfPd9ev6dUsHAHBH7rIsZ0ZWBFeJdl4C5kWlWvnT9fGHAFkAIJVHnUfdM9lyMmq etYcHxCgOjCN1buon1Y886VM3GRKQuLNTgpUbN7ylKoD+wtBI/bbam8JSx33VeU9cWTE Z0kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BLI65pAkl2Uesd7NXA66nH3tfFeFOpHNaRIG+fzMF3I=; b=zMWBuegcqDA7iX+3MXCMaVYbRMIYiP/XjzSrHD5SgQ+9lt2sKScAxAXZqaqhK79tf4 r3sjwrBmrQO9p1/pnEjkJMU3Sz4vLZxXqFuo9G7lRQx1rxh3RcjGMljy+Qn0qnUovkjQ 4vB3ikfKBmTu58Iuz3j5NKNhkmQNCFtGgqaRLagEFqmN0ryWt2N+ySM5D+dUvydk8O/e zJVBv1teYNtxOyzpWCdtEybBW2eB+l4ggNvv79PQfRHGWRRNQAOfkbxqeeP1Pz4SkXd1 1AKGWQcPjt7gCUY9lzLSJj7lTQIBRYtiyfqcCQ8LcAhGcVv+eCs5xltTE9kl+QGd244p Rg3Q== X-Gm-Message-State: AOAM533MQNxknjPSzWt661YSBErGuiT4GTcR+q2CLFlAMweF/hRwG3T/ f226r2vUMVVQ+aO4ifHby/OXGpPBJtYUhg== X-Google-Smtp-Source: ABdhPJy0/yuYY6AAOQ0tRwFSwO48Ne+iH5bBCX+N9mlxJcQBt8ydmQioyVphXb+/nYYk/74SzvE8Dw== X-Received: by 2002:a05:6a00:1896:b0:4c9:6027:e847 with SMTP id x22-20020a056a00189600b004c96027e847mr2084878pfh.15.1642982761981; Sun, 23 Jan 2022 16:06:01 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:01 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Chandubabu Namburu Subject: [PATCH 39/82] net/axgbe: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:35 -0800 Message-Id: <20220124000518.319850-40-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/axgbe/axgbe_rxtx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c index 6bd41d3002bf..f38bb64fab6b 100644 --- a/drivers/net/axgbe/axgbe_rxtx.c +++ b/drivers/net/axgbe/axgbe_rxtx.c @@ -22,8 +22,7 @@ axgbe_rx_queue_release(struct axgbe_rx_queue *rx_queue) sw_ring = rx_queue->sw_ring; if (sw_ring) { for (i = 0; i < rx_queue->nb_desc; i++) { - if (sw_ring[i]) - rte_pktmbuf_free(sw_ring[i]); + rte_pktmbuf_free(sw_ring[i]); } rte_free(sw_ring); } @@ -507,8 +506,7 @@ static void axgbe_tx_queue_release(struct axgbe_tx_queue *tx_queue) sw_ring = tx_queue->sw_ring; if (sw_ring) { for (i = 0; i < tx_queue->nb_desc; i++) { - if (sw_ring[i]) - rte_pktmbuf_free(sw_ring[i]); + rte_pktmbuf_free(sw_ring[i]); } rte_free(sw_ring); } From patchwork Mon Jan 24 00:04:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106279 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 839D5A04A6; Mon, 24 Jan 2022 01:09:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 93638426DB; Mon, 24 Jan 2022 01:06:07 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 1A7DB42888 for ; Mon, 24 Jan 2022 01:06:04 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id y17so3567501plg.7 for ; Sun, 23 Jan 2022 16:06:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iMkK/DcRMDPcFADA5l0+rEuzH5/Li3lybppd2h3tuz4=; b=aaavHR8NVfeGBT5HmA7OP+wVIFy5KRmejQ7RMQBDoR+vxMQknT14kyVh4HYiMa9O6K jG0z+bK+/VY9yhCnYRYxveLbx0ZUtyi3JHfsNUnRmdHFW+d23pU8aL+7Rq0kGG02X2KM ME29RvCXJfvjRW0KTK/m0hdjk1JYr0u9ERQbyWOKqQRUAEyqRL5b1mldx7OGYQlwhm8r DFDGr3561vlOlX5d/P4iDYq1VeV5nP50ecf7+hPLx8f46xYiU0xovWw2Jm0xQwcs8QjQ EztVFSyqMnbHZvVdo6Ngc25SC63mjszwPTGf8Zxj4/kTrR/UL1QdC6o0vMc+PweQi80t nCAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iMkK/DcRMDPcFADA5l0+rEuzH5/Li3lybppd2h3tuz4=; b=gQTd463D8ci1u4DTVS/kZTZaALpvEO76vJ/nQB7reEOHEWJrPbS4XrBJkqmg4vbxro bwWwYZ24es+oG7/DniFKv4jXoxflSY3ImKnRVMS5oTazZOM6yS8t6i++QK5Q/T6QVugc 8RTLnaSVJ7D6SPB8SlGy5tYRIvPKNAlBjCcMKuL/QX0kRntONqFq6IdQnAmvqKABNtqt wmMV4+XeyUK0QE/QLHLhKb9A6by7/ZAgWjwTIeJuTHnU55zvdwgqbzmqfOUlVsn/vvyN Lu4t+fKpGuxMkQ4zxnsXXIMehTvBSt0skivDygUMFtKoMBG4f770wsb3ViSEx8d3xhVX KyHg== X-Gm-Message-State: AOAM530b7xd63WX8R1txjGvcqy+67xC1C22dyfF1q8dfUJ/m2IP23aVP JrFwDDbg1n0h0vjIwt1cq8jS6SqHq/3U1A== X-Google-Smtp-Source: ABdhPJxkPYZrdJ2RbUzvufbaEZKGf+TlU5Jha77cGaaZsukZzcwa1wzGGdrGE0WLrN5Sv4k+YnYSwg== X-Received: by 2002:a17:90a:4593:: with SMTP id v19mr1872788pjg.67.1642982763060; Sun, 23 Jan 2022 16:06:03 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:02 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rasesh Mody , Shahed Shaikh Subject: [PATCH 40/82] net/bnx2x: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:36 -0800 Message-Id: <20220124000518.319850-41-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x_rxtx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c index 66b0512c8695..00ddccf151fd 100644 --- a/drivers/net/bnx2x/bnx2x_rxtx.c +++ b/drivers/net/bnx2x/bnx2x_rxtx.c @@ -27,8 +27,7 @@ bnx2x_rx_queue_release(struct bnx2x_rx_queue *rx_queue) sw_ring = rx_queue->sw_ring; if (NULL != sw_ring) { for (i = 0; i < rx_queue->nb_rx_desc; i++) { - if (NULL != sw_ring[i]) - rte_pktmbuf_free(sw_ring[i]); + rte_pktmbuf_free(sw_ring[i]); } rte_free(sw_ring); } @@ -172,8 +171,7 @@ bnx2x_tx_queue_release(struct bnx2x_tx_queue *tx_queue) sw_ring = tx_queue->sw_ring; if (NULL != sw_ring) { for (i = 0; i < tx_queue->nb_tx_desc; i++) { - if (NULL != sw_ring[i]) - rte_pktmbuf_free(sw_ring[i]); + rte_pktmbuf_free(sw_ring[i]); } rte_free(sw_ring); } From patchwork Mon Jan 24 00:04:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106280 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC28BA04A6; Mon, 24 Jan 2022 01:09:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58907428A8; Mon, 24 Jan 2022 01:06:09 +0100 (CET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 85B2942890 for ; Mon, 24 Jan 2022 01:06:05 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id 192so10784403pfz.3 for ; Sun, 23 Jan 2022 16:06:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=idSv0Xois/xOCqYAQfLwmkXZmbscIETT3rWLZhL0AOU=; b=V5O9G76eYoYZxyqBGDiGlB1gEXW35OlQfSey4vEwQu+hgZkTt4k0CjltR6ErMkotcA FQ7iQkdm7HAfu7I/uDeS9ryaNLlQcPZEVgw8v0yNcQZwgU78DnhTN+s2tHq8c0T/Brhh ZVbLWzNOa0ygWEOtgjQekxPYZmSu6FPyQ+mmAniwwYpwYFXGdX4VkyfejSVXsr0z+cjk wAEkCXyUfmB8Zj241zLTmkCFYi47BCP1CY7BNOhaB4Ii4sPgAChF2Hh8B38jOlho3/VT 2vDGdWPkS/spbz2JgRKWfFTPjiMVMUWXbUNIb6rADwdJERVXeUV1larxfhx3PLplgS2j obmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=idSv0Xois/xOCqYAQfLwmkXZmbscIETT3rWLZhL0AOU=; b=hoXysmgelsEIaK+/SKVz/mfxCwYMXNkw6RoIeJvDPE+8yqXp9h/MNNzGQbcEu62wBq kzS6v0mOYWatzyaU9LJQjrsHT/NND97KoMU0x0uh6Ps722iJ7yxAHXXIO9QQdQ7VshEA SmFBFK/VsXqOdviXWoWhc+9SqZpY0brMM7KsRMMqHDQok245hoKqOOeQVVyBAtdVnJFT PwuXIZxc0QtIBy+iD0O9lMzAgTk3mm3ysdqGSEJ3Bs/YL59Qrct8RQDh4KVWk8TldDce KP5gomXk6+9qvlZAYn84dC8JSPuqvC8UEjU8IzHCo9mEwWItGZMoMSPEFiUJZ3JCO7RD /6nA== X-Gm-Message-State: AOAM531FMOeJb1k12nH1IKzg9+SyPRNNMHq49IrzSogB/KvmF0EqGP5d NJ7V1EWKLfCCH9Mfk0wsn+hjBPbB8l0vfQ== X-Google-Smtp-Source: ABdhPJxEV0YxF8Mfoqp9JTelNNmVXoAOZDOGg/3Ie3W20OjB5AFja/QyaH1eJoKcS2vrZK+gkQml/A== X-Received: by 2002:a63:ce4c:: with SMTP id r12mr10010593pgi.21.1642982764556; Sun, 23 Jan 2022 16:06:04 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:03 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ajit Khaparde , Somnath Kotur Subject: [PATCH 41/82] net/bnxt: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:37 -0800 Message-Id: <20220124000518.319850-42-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index f79f33ab4e17..78339d43674d 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -5833,8 +5833,7 @@ static void bnxt_free_ctx_mem_buf(struct bnxt_ctx_mem_buf_info *ctx) if (!ctx) return; - if (ctx->va) - rte_free(ctx->va); + rte_free(ctx->va); ctx->va = NULL; ctx->dma = RTE_BAD_IOVA; From patchwork Mon Jan 24 00:04:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106281 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E6E2A04A6; Mon, 24 Jan 2022 01:09:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C349428AD; Mon, 24 Jan 2022 01:06:10 +0100 (CET) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id 9228242890 for ; Mon, 24 Jan 2022 01:06:06 +0100 (CET) Received: by mail-pf1-f173.google.com with SMTP id 128so14218796pfe.12 for ; Sun, 23 Jan 2022 16:06:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zkr0ICvLVL2t/HP9KwQdbKbxig7p/kOYPIjwjT/68u8=; b=RNi3fmxujnuBoRUQ3SYV9fJWG4t0bUlxKeLDLI86g7vfj+7x7nGNUwGqrBmkYy4eWu r8Pb2KtAhKC2Sl8Yg8SHc2g72HFSQTaNBk6OxpCgKi5/UUcYGTsNMUOn3M/maGimBcSF Sd7KUf9S/D2333sSpYjONoJGeSFh7w2I0PlptgQuyBjxNNI0qzkGv0BpeNLuGoPYt56i cAlP/eqdFzqB0RKlpENRHBW7iBJVKObM1AHIlBV2FzfVHYKTE2Wjx4nok0ZGsiwYNAv4 Q1S6JiplGWEdxK6pkJRCCcxlFlZscSBB1ul0+p1DivIRyteY08NqOqtbgKP15OLITdzf 2vCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zkr0ICvLVL2t/HP9KwQdbKbxig7p/kOYPIjwjT/68u8=; b=zVgjv0l/FR1Z/EWxMAzyNgfa9mz7XlExQzivYKiiNveKeIFzESvxoNNhClf7M27taQ 0sHP5r3mhp5o/kMXN01Ug/M/SmOWrqqV438h0ohVltWcQj3ylUa5Q0+SpCpjadLEeGi8 VAwExcvzekTkC4ir7N7ouJUy5MN0lw/k6lm2frhozyzO6rCBjBNLt9B8ur39Jg9PRFsv l74yDkmHLWPnHQ6lCSbwZyXTO3bi8m2He/EAQ6VbVhtkWHf5OHd12sBt93+fi9pud821 /NLWtghccfBOqqzfRkntxWt+OpEUjFm0aVZWqpfUwiJcVMPab5KSRMv5orWIBz4nO0Je L/HA== X-Gm-Message-State: AOAM5318LkvHojiXX2gIsoX1D/UkCnzDesgTo61/HKUUvMbEjfYLt015 oGtiaiCsjM3JyH/A5w5NGhkMNih69HNDYw== X-Google-Smtp-Source: ABdhPJwHUqe5E6Re6nuH6mFnrfPvmKEC+y9QphmSDKO4KhdqJxoIyfkjO5GFDNqsQSrSP0gI/+sh6g== X-Received: by 2002:a65:6705:: with SMTP id u5mr1272806pgf.158.1642982765562; Sun, 23 Jan 2022 16:06:05 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:05 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Chas Williams , "Min Hu (Connor)" Subject: [PATCH 42/82] net/bonding: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:38 -0800 Message-Id: <20220124000518.319850-43-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_pmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 84f4900ee52c..963280828a65 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -2148,8 +2148,7 @@ bond_ethdev_close(struct rte_eth_dev *dev) */ rte_mempool_free(internals->mode6.mempool); - if (internals->kvlist != NULL) - rte_kvargs_free(internals->kvlist); + rte_kvargs_free(internals->kvlist); return 0; } From patchwork Mon Jan 24 00:04:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106282 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67DFFA04A6; Mon, 24 Jan 2022 01:09:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27978428B2; Mon, 24 Jan 2022 01:06:11 +0100 (CET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id 233EA427D1 for ; Mon, 24 Jan 2022 01:06:09 +0100 (CET) Received: by mail-pl1-f173.google.com with SMTP id x11so8143076plg.6 for ; Sun, 23 Jan 2022 16:06:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wDg5SMDcUa1LIz/hXRZsYHoriVWc+RGAiy3a0kXoYGQ=; b=1QAT4UTU1ERqmwUqRmUAuAmPrAhMJ5BSDfMwC84ndldXZ5MTlWT6rXf/ljNIP/lh3K yIEmCB56iXiwr3xotePdXaDjSsm4WguzAqSFnCWO+sXqQMiU/jx71xuDgviiiSfqfYZi nhCfHu44IYVGtjQFVtQjknVLjRP8lL3z4mHEthbYkxEYhzcoFLfBjoIOtFArGZCMSBOI /kpszHgDP2NaJCi7Hzigs/lMZ1OqMkbvW8y/GrJXwL3OqRhKcWaQkD6S23uIkzIUP5xB YNVd1ppnKFyDNzi41kE4zxn4kiQtLroWOCdBih0Iuxf1f8ekp6XnaU6VghEgyDUonTGh J0KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wDg5SMDcUa1LIz/hXRZsYHoriVWc+RGAiy3a0kXoYGQ=; b=vGt/qsDds9YQQkcCHbNaKLVQOvMCBlFqpi9tebwUEEfE4cnrwvoZShf3B+gDQNfNyH B7uiM6Wk5hxzo0sWNk3hQqfMoLwniYe6RxfsQeQTp5WiLotNG5WKI4K+ehcJ9WFS205q 8WZKUqTygrLB+tWq+6pWXiDXG738PiM0+Kxh7vUuZU35zZgY3XMgiMQ9SMiGrQkJdFpU lsV7fukI0RlVAGHYOiKGNaPSmKMd+AT58LCvsfymZ7NxbaySx8KsMbLqN7TU1JhG2Kio UA+LgOlhlZzX7FTWjmZta87DnkUT/prNMys8ADJ7cvDvl0qTZMq35QAo5njHAR8uUNhi Eotw== X-Gm-Message-State: AOAM530498WyPEyN4zQUBXurDvFyx8glHiy6VGvb+rQttzvuRl1e7u2u ocT5dum2JqJmz/sOTFfHhoq2yYtA7Ha00g== X-Google-Smtp-Source: ABdhPJzzyTnQiNbQ1+HhnyRzl4tbcq5mmrFQdBrLo8SnCUtRsq9MfVimIJRspGqPMBdb9iqpfoq2aA== X-Received: by 2002:a17:903:2288:b0:14b:2764:8ff9 with SMTP id b8-20020a170903228800b0014b27648ff9mr9239892plh.105.1642982766611; Sun, 23 Jan 2022 16:06:06 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:06 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Subject: [PATCH 43/82] net/cnxk: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:39 -0800 Message-Id: <20220124000518.319850-44-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cnxk/cnxk_ethdev.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c index 74f625553df4..d679a1f78501 100644 --- a/drivers/net/cnxk/cnxk_ethdev.c +++ b/drivers/net/cnxk/cnxk_ethdev.c @@ -934,10 +934,8 @@ nix_restore_queue_cfg(struct rte_eth_dev *eth_dev) for (i = 0; i < eth_dev->data->nb_tx_queues; i++) dev_ops->tx_queue_release(eth_dev, i); fail: - if (tx_qconf) - free(tx_qconf); - if (rx_qconf) - free(rx_qconf); + free(tx_qconf); + free(rx_qconf); return rc; } From patchwork Mon Jan 24 00:04:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106283 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E9A0A04A6; Mon, 24 Jan 2022 01:09:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66C644288D; Mon, 24 Jan 2022 01:06:12 +0100 (CET) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id E59BB427CC for ; Mon, 24 Jan 2022 01:06:08 +0100 (CET) Received: by mail-pj1-f46.google.com with SMTP id d5so12235453pjk.5 for ; Sun, 23 Jan 2022 16:06:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ePoBxhFnXpor/e/eN5ziI+XeClUhfT+oxa/W25G3HY0=; b=Rugm/ZSu4Tn5Wm95/SlucI/8xWTelpTBkerJTX67M2Wc5qMMgWZC4f1Paktupku2Os Zmx+J/MAprH13DobFt+Y+r3VBG6AH1YYrov0Wp6JdNmKVaTHhFLSEB8sLpl4MDsO5HGE zFZ9E1glrsikaiGYLod7F1i7+TgTDSXY5NMalWS0YmF/oeiwKJhVofo0XcPbLTn0fSve RUs4CLe/oQiqcy685/WSD48NPyV4FuUVBNFRoGqRW2S7i6WzjYQmE3AHFff0JoEi1jCz 7cQNfmuh6b30cIPEjss2bxudXM5LrjSd+pydh5jdukCjC2wQWH+sEWLeJ7aOK+kYI7+M 4g+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ePoBxhFnXpor/e/eN5ziI+XeClUhfT+oxa/W25G3HY0=; b=oc7uh7/Khw7ynwB8ztN2vWVQ5rx5Dv/w9qBSHopeFjD7+a+KtVbiKOZpMIWg2Dg6iv ThIcDSzKEQzUxMMCHx1hITh0vITeZlPYTyfOzeAd55v/s9wtdskKYrHWrKtYVrQw5irF gq/fHCS7F9KkwADIE9jlVAr3h+jHoX5ITau/QMFk88bswD5A7OHCVGVbTXr9F0wRdGz3 xU3VghJ/BHgt1VdYRAwdxZD6J3DdU2JdOu+pNQ4HQiSe7B+wHg5U/risYRaBUN4BRyAM EeHO+ISaS7iT07V8/cSPLRU4VoLcWMNwaBToqXHpqq5qGDGCYGyNa00WTnaJkI4Wv0Gq 4G3Q== X-Gm-Message-State: AOAM530l4anrhSChSEMPhan1kkBKRh2zz9LfOaqp0KXNUOO+8y33E72/ VI6RL90+W7qf8vHjJ32ElMzktiXmVrrO5A== X-Google-Smtp-Source: ABdhPJySVKwAZoXxWmRTMljR53beM2tUikZwf8zd39XfmL+HdYRSu5Ajr+sMd5ZMZ9O+z8ISd7pQHg== X-Received: by 2002:a17:902:ea0d:b0:14b:4c26:f42f with SMTP id s13-20020a170902ea0d00b0014b4c26f42fmr2823166plg.125.1642982767578; Sun, 23 Jan 2022 16:06:07 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:07 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rahul Lakkireddy Subject: [PATCH 44/82] net/cxgbe: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:40 -0800 Message-Id: <20220124000518.319850-45-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/cxgbe_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c index f1ac32270961..ab06e30a5e0f 100644 --- a/drivers/net/cxgbe/cxgbe_main.c +++ b/drivers/net/cxgbe/cxgbe_main.c @@ -463,8 +463,7 @@ void cxgbe_insert_tid(struct tid_info *t, void *data, unsigned int tid, static void tid_free(struct tid_info *t) { if (t->tid_tab) { - if (t->ftid_bmap) - rte_bitmap_free(t->ftid_bmap); + rte_bitmap_free(t->ftid_bmap); if (t->ftid_bmap_array) t4_os_free(t->ftid_bmap_array); From patchwork Mon Jan 24 00:04:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106284 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5F3DA04A6; Mon, 24 Jan 2022 01:09:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66E9E4289D; Mon, 24 Jan 2022 01:06:13 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 997E1428A9 for ; Mon, 24 Jan 2022 01:06:09 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id a8so8884046pfa.6 for ; Sun, 23 Jan 2022 16:06:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gcywuAvsRBzYcqxW8NyRl7w7+GW1d4SBgXQVz1wk4c8=; b=SDNhgjlLRRiz3hW+k/dE/sBv73GQveXkMXS7hHKjkTowUNZxdHJPuu0IUJgrH/17sz 39wlGLTY5Do0sdGcorDiK7fgKlWxbEzhEhIkb17gBBIzuMIth4s3rPmqBnAlQfD64ESW HdirBR/6GHCnV3B6C5jWsc9cHaITzaCskxhpx9Ha7sIWLRf5y2AsCNSK9OcNeMgaNujs W2IxAG/Idau17QvfGgWkx9o/kQZ6y5Z4tPNErBfIcgaWsRdAFQSSOEOtU3/U712xKEiQ AcYlZZHWjR6D4P4M9QFz+vZ97SMpCYZ0KEXrNTBqxZ7cr0chXR9Y4KA+1tmRSZgK8MB6 qBgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gcywuAvsRBzYcqxW8NyRl7w7+GW1d4SBgXQVz1wk4c8=; b=pido6n512auROxvJCc8jAHKWUNvd0O5ptaSfb8FazHksh1DEx46ZX4Q3WUXzQgVUTm 79kmQiHnEcyewb4JNecym0Eg6UjJNp1XEFTJpGp5WJRqj1A3LxFHJWDnpwChEsC5e6pD 9/yzfCBqQ1G2e0VY0leAJ25EbVBYdX1tYIU+9OQvxlllpQ6UztyV5DpLcXF4tkRjSa/d 9Gp0W9+xoVCKDoEZN2WbRapGSfUN8mPeFM5b2vYZv0MoJQTc5tdNDQF8wtJFtWNU8I9x KVsN0HK/233cIyeanfodXOHZ93QHbsTDBIlqfkSyLPNimFgUcWlJWfjtMdBi7Piv6f0S Do5w== X-Gm-Message-State: AOAM531wQLtXdtQYGjJx8W6AOMFUm+WqkaKrTKWsejLs0CQIAlfEinTW WjSA3iNOpFjb5v82VQXJIEnk5qIvyXi0Vw== X-Google-Smtp-Source: ABdhPJyr1TMzgAG0QrkjAtmZwl6geRRdoO6yimpVmciedP9oYDlTumU4mZM6wwHM8Lw0kreJn7T5DA== X-Received: by 2002:a63:aa46:: with SMTP id x6mr10236783pgo.10.1642982768589; Sun, 23 Jan 2022 16:06:08 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:08 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH 45/82] net/dpaa: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:41 -0800 Message-Id: <20220124000518.319850-46-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 3 +-- drivers/net/dpaa/fmlib/fm_lib.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 2c2c4e4ebb5d..90208a31de26 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -463,8 +463,7 @@ static int dpaa_eth_dev_close(struct rte_eth_dev *dev) } /* release configuration memory */ - if (dpaa_intf->fc_conf) - rte_free(dpaa_intf->fc_conf); + rte_free(dpaa_intf->fc_conf); /* Release RX congestion Groups */ if (dpaa_intf->cgr_rx) { diff --git a/drivers/net/dpaa/fmlib/fm_lib.c b/drivers/net/dpaa/fmlib/fm_lib.c index 0d1ca12378d8..1d6816050c2f 100644 --- a/drivers/net/dpaa/fmlib/fm_lib.c +++ b/drivers/net/dpaa/fmlib/fm_lib.c @@ -408,8 +408,7 @@ fm_port_close(t_handle h_fm_port) _fml_dbg("Calling...\n"); close(p_dev->fd); - if (p_dev->h_user_priv) - free(p_dev->h_user_priv); + free(p_dev->h_user_priv); free(p_dev); _fml_dbg("Finishing.\n"); From patchwork Mon Jan 24 00:04:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106285 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E1AAA04A6; Mon, 24 Jan 2022 01:09:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB989428B7; Mon, 24 Jan 2022 01:06:14 +0100 (CET) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id A5871428A2 for ; Mon, 24 Jan 2022 01:06:10 +0100 (CET) Received: by mail-pg1-f178.google.com with SMTP id i8so13593986pgt.13 for ; Sun, 23 Jan 2022 16:06:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Hh4/1zquMB27nawFN14YTg0HzkWoq//klYDRDVFoYNs=; b=kNZBqp0FRzeS7ikUANYMwxXcFBfpAkj4AeD9cYvJaFk5RdCsf8WTIYrRRXkjfX48nz k27dcBA6N2r3JWvQlcn+0Mhw+GBoxZOGVAAY8dzQZ+9Z96LBqEglybjxTwFi6QsSLA8z otPAfpdMFpmzejzs/nx7HSGxyy0RXhO+6TyuPOTJCaVFm2xCB9CYk8oP7kwNUDUz9syk ij7/oXxvXSLk7Kj8k0Xyj0Ofz0ON2OLkUosSfOqZolID6RiqdAMExm/1n/jQ8Lgxyb2T NVw2P86/jEkczPqIgW6EK8eiw0+Oj1cTQ7T8o/6FifzgMnZuseBzV5ipN5dlpAtlq/cO eefw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Hh4/1zquMB27nawFN14YTg0HzkWoq//klYDRDVFoYNs=; b=JrZHI3CclIu+Qk5gKDm8zX9Gd+qR1L85CQoBmj6HYPlKBBrsPE+iNq/HC2YZ1u4bb3 QVYdVQ2LX41a5n6XZMeLKOk1gj/WQu5lJwGKI80K2bBBQQF24rrvz/bRgenoZ3qIOuCZ FuKmSz+aZqqZqiCrP/hWE8FIbYawGtHdCFG+d9K0lv2lofXo4+bVGRpk4tMFyQjwefK2 csoxPioY8PxbbPM5A+OVJIQZfvANCsNyxEOlK8iJVGvIJjquyDm94ZSXhc016z3nIKvM 5v4f+33qqtgY5OOyAjXXwAUAt57/o8b+0wyxBqrm2wVg3jMS4HaobFiPLfWkJ+9T+eJg HWcQ== X-Gm-Message-State: AOAM530BZyN9MyIr7HZdEDQA3IyLZ32G1fdb3EjsWD/BDAgCaaPb2zuc VQnGrihjW1jjL6fgPDZgPFTuxPY9MfUPCw== X-Google-Smtp-Source: ABdhPJzYdHqq7dnxyLiGNvO90mpkNJbqGcMbs5gPGOn8ps6p/do1P3RbAaaoCysQqZ9+XNvQOaEjQA== X-Received: by 2002:a63:4e58:: with SMTP id o24mr9909323pgl.525.1642982769668; Sun, 23 Jan 2022 16:06:09 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:09 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH 46/82] net/dpaa2: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:42 -0800 Message-Id: <20220124000518.319850-47-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 3 +-- drivers/net/dpaa2/dpaa2_mux.c | 3 +-- drivers/net/dpaa2/dpaa2_ptp.c | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 2b04f1416853..6b85b7740cfa 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -504,8 +504,7 @@ dpaa2_free_rx_tx_queues(struct rte_eth_dev *dev) /* cleaning up queue storage */ for (i = 0; i < priv->nb_rx_queues; i++) { dpaa2_q = (struct dpaa2_queue *)priv->rx_vq[i]; - if (dpaa2_q->q_storage) - rte_free(dpaa2_q->q_storage); + rte_free(dpaa2_q->q_storage); } /* cleanup tx queue cscn */ for (i = 0; i < priv->nb_tx_queues; i++) { diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/net/dpaa2/dpaa2_mux.c index cd2f7b8aa544..bd4596b89149 100644 --- a/drivers/net/dpaa2/dpaa2_mux.c +++ b/drivers/net/dpaa2/dpaa2_mux.c @@ -353,8 +353,7 @@ dpaa2_create_dpdmux_device(int vdev_fd __rte_unused, return 0; init_err: - if (dpdmux_dev) - rte_free(dpdmux_dev); + rte_free(dpdmux_dev); return -1; } diff --git a/drivers/net/dpaa2/dpaa2_ptp.c b/drivers/net/dpaa2/dpaa2_ptp.c index 8d79e392445a..5fcc36abe7b0 100644 --- a/drivers/net/dpaa2/dpaa2_ptp.c +++ b/drivers/net/dpaa2/dpaa2_ptp.c @@ -168,8 +168,7 @@ dpaa2_create_dprtc_device(int vdev_fd __rte_unused, return 0; init_err: - if (dprtc_dev) - rte_free(dprtc_dev); + rte_free(dprtc_dev); return -1; } From patchwork Mon Jan 24 00:04:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106286 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA1FBA04A6; Mon, 24 Jan 2022 01:09:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B97C8428A5; Mon, 24 Jan 2022 01:06:16 +0100 (CET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id A40394288D for ; Mon, 24 Jan 2022 01:06:11 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id x37so10266380pfh.8 for ; Sun, 23 Jan 2022 16:06:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EEz+Js5g3V8LrOBQCU9G8QIGXyNA7B4fE0VPNx667uo=; b=1+mg7fDHo0p0RDzSG56PyNXiAlAzYBIbsG4++h4nJdMfceyqVB8w5ZLalzK0hDxxK/ 9lYbsWdRYpkosTJ1JWXr4XAUSsXanZLattCAkGdUH+bbj7KcRqHszXDsUubt78D595+G 7+7z9QNr4V6TIvRZeMMKuxxn0VoiW54s+r31Hh4KlUGOK+gTQWz83hPR1HoqJeZu7zx0 q2asowBQNLbv+TeSeTttoOvMiDkkBiCa0N0tOJBQFgbkwcmKznIeh8k0KhlJRKE68sa1 FlIEahqyWdZkGEbXYw4DVMW96z5DAm1t6qu+nwuakwwsPbaLjjXUMtvV1c99I+vKfOqf RuWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EEz+Js5g3V8LrOBQCU9G8QIGXyNA7B4fE0VPNx667uo=; b=oNh4ZMFQlFeamWElxUJjzc5qi058AUl7GI7gwdUX4MHSWdPFNkm0DLKiDAsOAtAPsw f0xs2+z5mEgi7/U1QlY7PbbHRwjopvUQ/TVysaOyhTYn66gHw7ydI8BuNPujEkSBJXWJ HXUiI3nioIVwvW/668O0vZRZqi5mXS+jVoJ1sKI0TCalmuJR/nstbQoyM+qotQwAuef9 Dsp3Pi8MhtUIOKmyyHDa6zNziXZ96DiZbrk0ofQoUKWQ7iSW0YCn32SPhq0fFcKwnu1r xcc1EhvmAD6EQW4S28o8aD/cYhXjTztIPdcGLnRAcY4vUi3Klu2VQ/8mtNjlfuZexm4Y sFCg== X-Gm-Message-State: AOAM532xod79ARHn1dKp1pK8hqDfXZ9welsd+c7uqAh+8zmC+tGONjBI rB5nDSLPIz3PjQOJOyeEarBa3zpvLzkbGQ== X-Google-Smtp-Source: ABdhPJzRlLyeec3cJS2GmrMPego6bKolGfRpJt4gEoVvrnBESXX2qIu3ol3+eNmocWbnIbOkg89/wg== X-Received: by 2002:a05:6a00:8cc:b0:4a8:262:49e1 with SMTP id s12-20020a056a0008cc00b004a8026249e1mr11698216pfu.28.1642982770698; Sun, 23 Jan 2022 16:06:10 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:10 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin Subject: [PATCH 47/82] net/ena: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:43 -0800 Message-Id: <20220124000518.319850-48-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ena/ena_ethdev.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index dce26cfa48cf..db2b5ec8e77b 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -567,16 +567,13 @@ static void ena_rx_queue_release(struct rte_eth_dev *dev, uint16_t qid) struct ena_ring *ring = dev->data->rx_queues[qid]; /* Free ring resources */ - if (ring->rx_buffer_info) - rte_free(ring->rx_buffer_info); + rte_free(ring->rx_buffer_info); ring->rx_buffer_info = NULL; - if (ring->rx_refill_buffer) - rte_free(ring->rx_refill_buffer); + rte_free(ring->rx_refill_buffer); ring->rx_refill_buffer = NULL; - if (ring->empty_rx_reqs) - rte_free(ring->empty_rx_reqs); + rte_free(ring->empty_rx_reqs); ring->empty_rx_reqs = NULL; ring->configured = 0; @@ -590,14 +587,11 @@ static void ena_tx_queue_release(struct rte_eth_dev *dev, uint16_t qid) struct ena_ring *ring = dev->data->tx_queues[qid]; /* Free ring resources */ - if (ring->push_buf_intermediate_buf) - rte_free(ring->push_buf_intermediate_buf); + rte_free(ring->push_buf_intermediate_buf); - if (ring->tx_buffer_info) - rte_free(ring->tx_buffer_info); + rte_free(ring->tx_buffer_info); - if (ring->empty_tx_reqs) - rte_free(ring->empty_tx_reqs); + rte_free(ring->empty_tx_reqs); ring->empty_tx_reqs = NULL; ring->tx_buffer_info = NULL; From patchwork Mon Jan 24 00:04:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106287 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37F6AA04A6; Mon, 24 Jan 2022 01:09:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB291428C0; Mon, 24 Jan 2022 01:06:17 +0100 (CET) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id 9B441427B9 for ; Mon, 24 Jan 2022 01:06:12 +0100 (CET) Received: by mail-pf1-f177.google.com with SMTP id i65so14225593pfc.9 for ; Sun, 23 Jan 2022 16:06:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PtGwKFlFN1UZntsSRkxw8yKwwbyOM2mNPtc3IrzMgQk=; b=2L9qmTqKfT2RJdIIo5A2hVCEKWtRrRPiV47crq+kj06wBS+hEtXtK/3JdloI7Y9niT 4o5zUMNGf+e5sRpig9/J8GXKNlojGqj4afF8AdMhSGpv8OrEma0O+gHMD4HXXhe9kT5I ok/WF+tMe26JHWAWsh+pirPV52w6qXvpWR01ZLBn62ZJuaYYNW8i+zS9QPrTEb8S2Kva e6ykXbKDPWdO9nelivhfdP65MCf+zCtVWc52I6AOHQ4t5Z3y2IA2bUx2Gnfuk7N2sAQ4 r6Tll6/2AbMFWAPOuoQtyWBgDhHJZfi3KmwGYZzC2XZQ0SCLpMplQtPZrWgcStxAcYjJ kZ3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PtGwKFlFN1UZntsSRkxw8yKwwbyOM2mNPtc3IrzMgQk=; b=ELvIgiRNQ30b4VaJyfUMvqu/FRec2v4yN5t9lA9UUADFZ3PmnFu7XeQCP+BCQs9YTz fEwzH5WrKyF98V5iU7enK+6fM3w9/L1+gp0VksBfjcrqmEVVNc2HgR93EQV5V8XoVuUo j+uu6PNGYJZPnyosA92wo7Z0raFXEtzaeQMvuMLHloYpnqRqoq8YcGaljs+zJTYBfooE narqejB1jXpxkNTdAfpL6E4wv1aXkX0ElKGbnl517XfO2Wn72m9KyGqpYKus7fXg7Si2 crhTuZwXT1KtgOQ0es3tZFL2Geu4nl31fEmKTDVeSGbJvEdzBwmax9QxctH3xzHqqzh0 iO7Q== X-Gm-Message-State: AOAM5333Xj8oI6Fi/MhQpmxUc4y4M7vaqx8eQU8MDIuPnSdtpzW1QvMQ n6+PvQ2QXEWX3LBNyCv9jiSns6sc/bsyGw== X-Google-Smtp-Source: ABdhPJwZCxO83dXy1vKAOUQ6ImNaM1jrTWT+QVF2hwtX/X1tmhSKF18+9N43TLEzm+xd+KeBcPm3aw== X-Received: by 2002:a63:8941:: with SMTP id v62mr5938231pgd.389.1642982771688; Sun, 23 Jan 2022 16:06:11 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:11 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou Subject: [PATCH 48/82] net/hinic: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:44 -0800 Message-Id: <20220124000518.319850-49-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/hinic/hinic_pmd_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c index e8d9aaba84a6..35788f46eb4c 100644 --- a/drivers/net/hinic/hinic_pmd_ethdev.c +++ b/drivers/net/hinic/hinic_pmd_ethdev.c @@ -2662,8 +2662,7 @@ static int hinic_copy_mempool_init(struct hinic_nic_dev *nic_dev) static void hinic_copy_mempool_uninit(struct hinic_nic_dev *nic_dev) { - if (nic_dev->cpy_mpool != NULL) - rte_mempool_free(nic_dev->cpy_mpool); + rte_mempool_free(nic_dev->cpy_mpool); } static int hinic_init_sw_rxtxqs(struct hinic_nic_dev *nic_dev) From patchwork Mon Jan 24 00:04:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106288 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D18C1A04A6; Mon, 24 Jan 2022 01:09:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AB86428AB; Mon, 24 Jan 2022 01:06:18 +0100 (CET) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id A041642833 for ; Mon, 24 Jan 2022 01:06:13 +0100 (CET) Received: by mail-pg1-f173.google.com with SMTP id i8so13594053pgt.13 for ; Sun, 23 Jan 2022 16:06:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uq4mzrlmF3RpJdeURax9LN0/y4tfKaEL8B92rJsdSgA=; b=DvKyGS3tiRlrDqa2EMzk7/KmN4z8mwi0IpkPP1kC0REgTdFSYATfRVCdOt6rs+T1Dg 0I9mmqlj+NyKb3hF5GsK3f1YoVRHoCm3cNNBewRwQmmK7Kp04Or0x5YS/rzjejGijWtJ r0M8dBmtcLJZtviRZW4AvR72wtN/67D4oOXOevvrRQNJQVlM0t3TXgjNGvi8s6mhZKq/ 7SNpyMH08PkXVv2CISDEM1XDIr9rer+7z3ys3q6kMETKzhw7CPeUHjQYTn4QmUlJzXU9 B0CJ09Rr7kldBt4Qz0a5L58KypiV0eOURNspqlvuKRSPTVTkxiTSmBBJzR8xNJevIFAz H4zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uq4mzrlmF3RpJdeURax9LN0/y4tfKaEL8B92rJsdSgA=; b=Y5HkIT2hVHcxv29wwaCGcQh698hUGogaO1hPVHiTKw/V04g69wXq5+gObzsmIBgG8p +KS3/m6MG+/O5UW2d8KHBJ+qggAuPSb/s77hvqNy7HjI1vPFsXMN1kDpY2nofpIAL6hh IIR4Xo5OEzsEJz0gVrawaXxV9lz/legbQ6yRythMSoyhYcZ5IeWt8cZ4ewX6Of7m8Klw cmlQzVUso0Ew+9NMcgdNeWCRtfDzViPP0LWG9hjaOpqbo+8/vlFPpm7fnwhBtiwloHAH uu6eUeWO0Pnal7jzAHR9U01n61/cXFj3E7npTs+09aD6s+8evHA7bWT50dMRHNsvh7vV LtIQ== X-Gm-Message-State: AOAM532oz5WJVl5rgR5KvsaMiAIgKRflHDX/vtpcV3SZgLJY04usKrR/ fQPHWWdeO0pDTjfk0HyHOX+XnhdUPrbIZQ== X-Google-Smtp-Source: ABdhPJzepO22D1wm+54rqrO8xXOSFONOyS0XrhdnqNJBiDbUvGqFjqMXE473o5CEwPGbX8OPp5MJiw== X-Received: by 2002:a63:3d0e:: with SMTP id k14mr9860773pga.484.1642982772695; Sun, 23 Jan 2022 16:06:12 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:12 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou Subject: [PATCH 49/82] net/hns3: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:45 -0800 Message-Id: <20220124000518.319850-50-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/hns3/hns3_rxtx.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index d240e36e6a86..8a428f88f48e 100644 --- a/drivers/net/hns3/hns3_rxtx.c +++ b/drivers/net/hns3/hns3_rxtx.c @@ -86,8 +86,7 @@ hns3_rx_queue_release(void *queue) hns3_rx_queue_release_mbufs(rxq); if (rxq->mz) rte_memzone_free(rxq->mz); - if (rxq->sw_ring) - rte_free(rxq->sw_ring); + rte_free(rxq->sw_ring); rte_free(rxq); } } @@ -100,10 +99,8 @@ hns3_tx_queue_release(void *queue) hns3_tx_queue_release_mbufs(txq); if (txq->mz) rte_memzone_free(txq->mz); - if (txq->sw_ring) - rte_free(txq->sw_ring); - if (txq->free) - rte_free(txq->free); + rte_free(txq->sw_ring); + rte_free(txq->free); rte_free(txq); } } From patchwork Mon Jan 24 00:04:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106289 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87E52A04A6; Mon, 24 Jan 2022 01:09:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 94554428BD; Mon, 24 Jan 2022 01:06:19 +0100 (CET) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mails.dpdk.org (Postfix) with ESMTP id ADBE842833 for ; Mon, 24 Jan 2022 01:06:14 +0100 (CET) Received: by mail-pg1-f177.google.com with SMTP id e16so4334627pgn.4 for ; Sun, 23 Jan 2022 16:06:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OUYCORe2vUmTo5U+aHVAc4mtCYCEHhtpbL/FAZv929Y=; b=YKeitL3n7s9DXaM3vIzdLgX9DQ5O+KIWTCxS9ttkgI9uWgzpl/N2Ekvqe8PQ0LwdTy DSKG7K0pAQ4sHfPU+x+63tauVreYUoi604FVf8rHtgtDDRTvOr1T99/ymz2Kat4QzRiH e54YkSdgkdOXnqCEzTbh6nNWIAREd27AXaRSsTMBWQbv+0a1ayh8M8xEFQqeZlzIe1Q+ 0+tIB5JEjY2D84ej+ZzSDyrbGtYtun4Gus9R3zrMgj8RpLKQ5La4iVo2SkFUyAAjZTym 3hDdTyLciaGCqQRz9m+EsCZOi7i+5XWEUsWG+r3EDCsZwmMDfXHEXakGXOEXxVboluUC ELhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OUYCORe2vUmTo5U+aHVAc4mtCYCEHhtpbL/FAZv929Y=; b=GW5uOZFdMezagAYB8UodVlalrcC2AWSVZjyKNRgROpV5X8P8Zm1OZxxHZeEjZOHi3D jP/fvnEoGugHJhGpLktfi596CFQ/g33Q9YzrxhXPojet+0Fu3JSN27elj9YX87cM8qQR OfAfrO73Exb7B+/mtiHVS/yH1yvbP/owJKQftEJMS5lQwa1M7rm0s4O4jVrcEfGXzYhJ KEgYZkbun5sRz78NOVt+W1qflmcOuXiNvYS/A5URCMnEBPFs98AGK284S74hz1bAfjxV mWmUr2ifQsOGaJxLWgcoAhu5vzwfxi2jw7kgWJ1GyiXaDTYjAQhTyBf/I/m1PdcQQoEb 14Og== X-Gm-Message-State: AOAM5306LEfSa8vIwWMX0yw/QzzkzRbLbLdxMxeicYM8KdXZoxp5CAqU Y3iw63JjGkfC0jFq/LKoAUnRpRF/+JunDw== X-Google-Smtp-Source: ABdhPJzXL1ozizXd/i0WTHaWR/FUV67kqb+LrnIrrTBZP9M0O0VLfQPppIQaWDbBdknTlrhvqHvmVQ== X-Received: by 2002:a63:fb41:: with SMTP id w1mr3454820pgj.293.1642982773722; Sun, 23 Jan 2022 16:06:13 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:13 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Beilei Xing Subject: [PATCH 50/82] net/i40e: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:46 -0800 Message-Id: <20220124000518.319850-51-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_ethdev.c | 27 +++++++++------------------ drivers/net/i40e/i40e_rxtx.c | 3 +-- 2 files changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 1d417dbf8ad7..ecfa3c94db44 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -1781,10 +1781,8 @@ i40e_rm_ethtype_filter_list(struct i40e_pf *pf) ethertype_rule = &pf->ethertype; /* Remove all ethertype filter rules and hash */ - if (ethertype_rule->hash_map) - rte_free(ethertype_rule->hash_map); - if (ethertype_rule->hash_table) - rte_hash_free(ethertype_rule->hash_table); + rte_free(ethertype_rule->hash_map); + rte_hash_free(ethertype_rule->hash_table); while ((p_ethertype = TAILQ_FIRST(ðertype_rule->ethertype_list))) { TAILQ_REMOVE(ðertype_rule->ethertype_list, @@ -1801,10 +1799,8 @@ i40e_rm_tunnel_filter_list(struct i40e_pf *pf) tunnel_rule = &pf->tunnel; /* Remove all tunnel director rules and hash */ - if (tunnel_rule->hash_map) - rte_free(tunnel_rule->hash_map); - if (tunnel_rule->hash_table) - rte_hash_free(tunnel_rule->hash_table); + rte_free(tunnel_rule->hash_map); + rte_hash_free(tunnel_rule->hash_table); while ((p_tunnel = TAILQ_FIRST(&tunnel_rule->tunnel_list))) { TAILQ_REMOVE(&tunnel_rule->tunnel_list, p_tunnel, rules); @@ -1833,16 +1829,11 @@ i40e_fdir_memory_cleanup(struct i40e_pf *pf) fdir_info = &pf->fdir; /* flow director memory cleanup */ - if (fdir_info->hash_map) - rte_free(fdir_info->hash_map); - if (fdir_info->hash_table) - rte_hash_free(fdir_info->hash_table); - if (fdir_info->fdir_flow_pool.bitmap) - rte_free(fdir_info->fdir_flow_pool.bitmap); - if (fdir_info->fdir_flow_pool.pool) - rte_free(fdir_info->fdir_flow_pool.pool); - if (fdir_info->fdir_filter_array) - rte_free(fdir_info->fdir_filter_array); + rte_free(fdir_info->hash_map); + rte_hash_free(fdir_info->hash_table); + rte_free(fdir_info->fdir_flow_pool.bitmap); + rte_free(fdir_info->fdir_flow_pool.pool); + rte_free(fdir_info->fdir_filter_array); } void i40e_flex_payload_reg_set_default(struct i40e_hw *hw) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index 9a00a9b71e2c..25a28ecea22c 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -2573,8 +2573,7 @@ i40e_reset_rx_queue(struct i40e_rx_queue *rxq) rxq->rx_tail = 0; rxq->nb_rx_hold = 0; - if (rxq->pkt_first_seg != NULL) - rte_pktmbuf_free(rxq->pkt_first_seg); + rte_pktmbuf_free(rxq->pkt_first_seg); rxq->pkt_first_seg = NULL; rxq->pkt_last_seg = NULL; From patchwork Mon Jan 24 00:04:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106290 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD4ABA034F; Mon, 24 Jan 2022 01:10:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2A5F428CF; Mon, 24 Jan 2022 01:06:20 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id CCBA4428BB for ; Mon, 24 Jan 2022 01:06:15 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id c9so13906965plg.11 for ; Sun, 23 Jan 2022 16:06:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DQv7enFJ6ztV7XCoRJU9M8z1Krc32VCDmmDK8E4865I=; b=UmTiF1B9PQa2/lnAVg0ghXbYrxNe5HI4gHtnGCJJL7VvvoCxPWspHAG1vnQlSl54N2 N479CgwwJiTyPkodt1oWB1W3Z0zKl6RgfE82lu7qVCKNNHBVVyKVuJ0WCJsLSqrXohx/ ES3JfpRwAriQpGbd+FkHYcT88xSUn+czrtBBhbebYfYWTTZlplVZkAX4aWy8O7mmjwcw sJalKyke85Q3VlMIpSnHqZDq8tKEaR4AI5++ntC6JK5ZB7YS+PwIO602eCzRmLv9tjUz D3wAv4SWjCyrRpGcpyd0IDyiX4fE24z14t2HubRd8uehOoea8X65R9+F5uVbN8sQQyzJ bpvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DQv7enFJ6ztV7XCoRJU9M8z1Krc32VCDmmDK8E4865I=; b=mIDAgLR2oYOQiP87zP+LRPpx/iFE1MNEfGaX/AUI8vjRmBPzYEJzL2Zu2exT8R28rk /wPKF09ZK8Hh87QcmCluQAGj/+R3eQXWySrtB9xwn7/Iehktc8ZBUD7pwaCG2wAggmng +4kMLTm0wy4LrzgShtSjsmY9WBn0ujI4ihiWC06MJdn8BPicISHcHaU+L3uKfvefERsD 0rQ3MDBuM/hETJHbIosKJ53r/mNUEUn4s1e72OpHt9XGQpxAHi0Q78ajiKpE2qf1OBob qqUYv//zNDd5NMqWRgaS5VGzpHoMtfOB3rHxBzxsWTmBE/7rekVMen7nEUoyKXJT8MHY L0zg== X-Gm-Message-State: AOAM533ZqeFutLIv18ZnhlUaEUsoGQm21o3uIh8EnK9EptwNcVNlYgZv kVWL8THpR3ogZdof3J9cOKK8WbkBpgLEVw== X-Google-Smtp-Source: ABdhPJyY3K/G/QYzcTAEJMD0FeGUxDOtkwlt2T/BYM5hfzrn79WMfJ+wYj1bPB5Vyow8rWjCXGSmwg== X-Received: by 2002:a17:90a:4042:: with SMTP id k2mr10583589pjg.88.1642982774781; Sun, 23 Jan 2022 16:06:14 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:14 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jingjing Wu , Beilei Xing Subject: [PATCH 51/82] net/iavf: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:47 -0800 Message-Id: <20220124000518.319850-52-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/iavf/iavf_rxtx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 59623ac82094..dabe8cba7561 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -230,8 +230,7 @@ reset_rx_queue(struct iavf_rx_queue *rxq) rxq->rx_tail = 0; rxq->nb_rx_hold = 0; - if (rxq->pkt_first_seg != NULL) - rte_pktmbuf_free(rxq->pkt_first_seg); + rte_pktmbuf_free(rxq->pkt_first_seg); rxq->pkt_first_seg = NULL; rxq->pkt_last_seg = NULL; From patchwork Mon Jan 24 00:04:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106291 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95FB9A034F; Mon, 24 Jan 2022 01:10:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB78B428D3; Mon, 24 Jan 2022 01:06:21 +0100 (CET) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id CFDE8428BC for ; Mon, 24 Jan 2022 01:06:16 +0100 (CET) Received: by mail-pj1-f45.google.com with SMTP id s61-20020a17090a69c300b001b4d0427ea2so18759413pjj.4 for ; Sun, 23 Jan 2022 16:06:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=skn4RezxA6fzdblvvu4Dbyud7yUiw8Oo0uSoBCpx7wE=; b=B2YRUVns06S8yIkJJHcCQ2gZhUFkAgqrq+qwOeqvrgJFzaKCh1ifvjkq1CIMkQPYjF mj6qw/lfnQRTqEUGT/hwIIF/e7D190bba3QIfKh3AVm0tuD4Zq/6zjlMw5TXwVU/gyPu gl74vKLGxWo+k3jTOjua2y20tq2ZBbt6GTwXFrIpyupJW/OTgs9otesgzi4T6L6wajGo DVDlNF62hp8tIm5qTFx6vWt1EkTyVGf3hDRbliBhzRI35rE+L8AGbKjFYoCc98jqlSeG pG3zT5xQHe7HYlRc0KkXbLvV4tT1uGvHAGfXoo+C40XRdfQAuOvcGwsNgtBGStQzMd4n F+ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=skn4RezxA6fzdblvvu4Dbyud7yUiw8Oo0uSoBCpx7wE=; b=CwcvBkQnKcIea5BVuDyz6UIEYc05Cj++pfH6z1DrdtKjFJHFYBX+cjoNZVmJETSrMj 6zRmxPL8usAeJHyvT8JC19G2b6AAw0xcCGQnqFSD2yJSZwdMIq0KFnmYbtPgT3WSW3cW y3JQG873+ZRw3cMrxFHmoOM93ol8tXW3bJ8DJiGNLRhU56W/iJWd+YU6DeOhxqbEQDgf dyKiMai4DT1rnDeGx7zeK4RBQELSRHFsIAqJ7RIQnuEhiuCm4J/n74uZiGYfS2FQ2GNS IS13NFbMio94F9SU+eJVsK7dS4jcltIIV5zOuBGszV+L7Mp6iyKw+7eKS3C2/Lq/X0d7 GCBQ== X-Gm-Message-State: AOAM532RwTzC7+70vV3Zj9GG2jz8cL4Tomtzfmi1t87JTCLIqtIrLJ1s dBEgppyYXTjZULXR9Tao/Z8EBykxWMm78A== X-Google-Smtp-Source: ABdhPJzTDvXjvxp8VN9Khr/K1dfApkQo6FX0wcxs51tQPIM4oDlLNSNGA6gQ5MMY9cghjn5HBwNkiQ== X-Received: by 2002:a17:90a:5d83:: with SMTP id t3mr10552469pji.159.1642982775855; Sun, 23 Jan 2022 16:06:15 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:15 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Qiming Yang , Qi Zhang Subject: [PATCH 52/82] net/ice: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:48 -0800 Message-Id: <20220124000518.319850-53-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ice/ice_fdir_filter.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c index 13a2ac42df87..3fce8e1e6253 100644 --- a/drivers/net/ice/ice_fdir_filter.c +++ b/drivers/net/ice/ice_fdir_filter.c @@ -421,10 +421,8 @@ ice_fdir_release_filter_list(struct ice_pf *pf) { struct ice_fdir_info *fdir_info = &pf->fdir; - if (fdir_info->hash_map) - rte_free(fdir_info->hash_map); - if (fdir_info->hash_table) - rte_hash_free(fdir_info->hash_table); + rte_free(fdir_info->hash_map); + rte_hash_free(fdir_info->hash_table); fdir_info->hash_map = NULL; fdir_info->hash_table = NULL; From patchwork Mon Jan 24 00:04:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106292 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5073FA034F; Mon, 24 Jan 2022 01:10:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF68D428D7; Mon, 24 Jan 2022 01:06:22 +0100 (CET) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id D8AE9428C3 for ; Mon, 24 Jan 2022 01:06:17 +0100 (CET) Received: by mail-pj1-f46.google.com with SMTP id n16-20020a17090a091000b001b46196d572so14811877pjn.5 for ; Sun, 23 Jan 2022 16:06:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4e0zeGJiziv50Z5VPCtWWft+qdFSllPtblXUEw0LgiU=; b=137u+BS4SZzv+uKYWjjxbRn+QltsQXi+K4Bx7g4AsmLLJ+MnlOBvq2Uc3PHJT4GjJP +QA3/Z5mU3SMe4s2+Hs7tn4PIBt/9yWoffkukzgXOYdQhBVxb4/xesLzT34aGpBZpnUc eNPaEnM0uaCrZjA7XtCVlT79NQQjODhig4+fpfUMat+dEnnMW+FswU7CPizxP8vPo9k0 8dnh+xwWYzobrRozbv4csumQHgp78zTpFzYtnjbn/N5yd7Gd46fscrvWjot6NgbHpbye Uc85ucEOKnRZmzsVMnL81pRMggDHuZ7FNM/2Oi8cLyJyJHRgHbCSPG1soN1wNrRPzIbl jk8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4e0zeGJiziv50Z5VPCtWWft+qdFSllPtblXUEw0LgiU=; b=y7PoLXkviDCnBCcg2L/wUnn36+yv0EFDBM+Q9nA8VEKl/R/b6w/NcbhldEj+owduGn TA65x02Ovm1MbBpVjA+UAx0zriNgFvUI20xaklrGRi0H4dn7zDpddavi7XhsJYXl81eO bt7QWh3i6RCtC8zTebxO5xeDlfSj6hdI7W2qTDwsk8IeVHAoCpTQ6hOr1xMoDPEtoeVZ XL2MohtRh1E34uD31X63jBjeMMJCDoiTnCXhx+p50cPEokVuN1Kj+X2BMbTuD1lTZmBc M1zComU1lHZ+tznCB7mLjIMp9uA8P1mk8YHFLQ9yiQ0OcnryVQ3DvSJyNZbeCHk08+u3 oxTQ== X-Gm-Message-State: AOAM532Q//1RhZrtE+ktqV6YytmVJHz8g6GcQySizV05MFjZ3jhfYdZR VrLQF8QCdJdVrgO89beCusYRSLWBDDvyzw== X-Google-Smtp-Source: ABdhPJwkE/dkyxjghjKuHxKSPyE7Zy+2OJoEPCe6iY29mQdYFL2QUKoaVRb6UIQ/YcvdxDOI911A6A== X-Received: by 2002:a17:90b:3110:: with SMTP id gc16mr10618228pjb.108.1642982776875; Sun, 23 Jan 2022 16:06:16 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:16 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Haiyue Wang Subject: [PATCH 53/82] net/igc: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:49 -0800 Message-Id: <20220124000518.319850-54-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/igc/igc_flow.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/igc/igc_flow.c b/drivers/net/igc/igc_flow.c index 66053060af5a..88978ee0e849 100644 --- a/drivers/net/igc/igc_flow.c +++ b/drivers/net/igc/igc_flow.c @@ -776,8 +776,7 @@ igc_flow_create(struct rte_eth_dev *dev, if (ret) { /* check and free the memory */ - if (flow) - rte_free(flow); + rte_free(flow); rte_flow_error_set(error, -ret, RTE_FLOW_ERROR_TYPE_HANDLE, NULL, From patchwork Mon Jan 24 00:04:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106293 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B4DDA034F; Mon, 24 Jan 2022 01:10:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD776428DC; Mon, 24 Jan 2022 01:06:23 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 1D3954285C for ; Mon, 24 Jan 2022 01:06:19 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id w12-20020a17090a528c00b001b276aa3aabso19114702pjh.0 for ; Sun, 23 Jan 2022 16:06:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tpchy6wepQlqev+R7Ezt6aGM3ua5K4iRFgPL0yJtdMI=; b=lldH8/wKUJ1rYgEdQnPoAhuWqV9NZnn6Wd8lYxIgC8t0ebe3IAvjmKpTe6dm+JGTE/ VLeky53yxeJi1apB5SjYp+cIQk0/+7fHelye7qK7XCNCLX5GvcKMYlnEc3bvgHFH6TtC yshwG1M8swi0KlCZFdykoYzmTL3jWZleqTs7IlzxQWmqTYZAXJxmYV2MFqeNQb+UtbUp cjQXjSg0jk1J5J/nAfnrZHhoU+ca26HZWNkLNl22+MCEvbz1Dna+hdoBdoRzVRcK4IYW gwr9xDHmTEaqnPhIz9Iz3MYN7SkUzOsin61vKw0ipu1mK8i8gQIRN7fTXLfw9nI5jVvo X22Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tpchy6wepQlqev+R7Ezt6aGM3ua5K4iRFgPL0yJtdMI=; b=vaojGagipTduO4JF0N4K+rwesjbuVrqbQv6X6PnLfRyWWmaJ1xu+YSlD1Fm28A5Gc3 BPpZEu1Oh37XzqNEgUKoWwqILJEhDpeNb3pPRy5142dPqs5qDTzWPmkJyTxsZf9vcWVh 7QY4Ekzmq6h/msbi1X7hjvJRA5SJ27CHOoLP5ytAfMOsGhCJJLpBJY/4uG25Jxn4Xa5c 7g5ByqC1pXwVIsJmz/F2xjdEY9DXFA84Dc/3ZveoeURC8ft6MJPcOsyhZmXQs0BTFzGB iwlTzbtkoeAHMQrhiJh4+2x+l04dOe9RQNNkOiZqHZtl7ucfrCWz/DhY7bxuOhuthSqu Q5iw== X-Gm-Message-State: AOAM531cJ7zWGUY5hdj8CmSM715PkKGWCmpHQ6M50jhnjiUUUCH/oY58 gx8kHDnr3T5I2FYN4I/Iel9ZBtdokZYDZg== X-Google-Smtp-Source: ABdhPJySagq8gGyH2YNHIDZDYgiXrxOSp0K718xpxgxZbST2evBkvmEjbR9sysDK8IeczJQs54F1yw== X-Received: by 2002:a17:90a:8807:: with SMTP id s7mr10524255pjn.223.1642982778091; Sun, 23 Jan 2022 16:06:18 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:17 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Haiyue Wang Subject: [PATCH 54/82] net/ixgbe: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:50 -0800 Message-Id: <20220124000518.319850-55-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ethdev.c | 10 +++------- drivers/net/ixgbe/ixgbe_rxtx.c | 3 +-- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index c8f0460440c0..840509ddd460 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -1322,10 +1322,8 @@ static int ixgbe_fdir_filter_uninit(struct rte_eth_dev *eth_dev) IXGBE_DEV_PRIVATE_TO_FDIR_INFO(eth_dev->data->dev_private); struct ixgbe_fdir_filter *fdir_filter; - if (fdir_info->hash_map) rte_free(fdir_info->hash_map); - if (fdir_info->hash_handle) - rte_hash_free(fdir_info->hash_handle); + rte_hash_free(fdir_info->hash_handle); while ((fdir_filter = TAILQ_FIRST(&fdir_info->fdir_list))) { TAILQ_REMOVE(&fdir_info->fdir_list, @@ -1343,10 +1341,8 @@ static int ixgbe_l2_tn_filter_uninit(struct rte_eth_dev *eth_dev) IXGBE_DEV_PRIVATE_TO_L2_TN_INFO(eth_dev->data->dev_private); struct ixgbe_l2_tn_filter *l2_tn_filter; - if (l2_tn_info->hash_map) - rte_free(l2_tn_info->hash_map); - if (l2_tn_info->hash_handle) - rte_hash_free(l2_tn_info->hash_handle); + rte_free(l2_tn_info->hash_map); + rte_hash_free(l2_tn_info->hash_handle); while ((l2_tn_filter = TAILQ_FIRST(&l2_tn_info->l2_tn_list))) { TAILQ_REMOVE(&l2_tn_info->l2_tn_list, diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index 99e928a2a971..9e8ea366a506 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -2983,8 +2983,7 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter, struct ixgbe_rx_queue *rxq) rxq->rx_tail = 0; rxq->nb_rx_hold = 0; - if (rxq->pkt_first_seg != NULL) - rte_pktmbuf_free(rxq->pkt_first_seg); + rte_pktmbuf_free(rxq->pkt_first_seg); rxq->pkt_first_seg = NULL; rxq->pkt_last_seg = NULL; From patchwork Mon Jan 24 00:04:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106294 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08700A034F; Mon, 24 Jan 2022 01:10:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C76334287C; Mon, 24 Jan 2022 01:06:24 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 2623F428C7 for ; Mon, 24 Jan 2022 01:06:20 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id u11so13912470plh.13 for ; Sun, 23 Jan 2022 16:06:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8uCh2fmiVJ0Fv7CxbxcyCYgCxrp8a63KW8vHU+YPmcU=; b=3dryniEWDqdUVLWYzIAKOoYfcL6UWtPzYEAYIRgZn5y+vKHtCaNYPJLDz5ktbh+T6G ytx2/LGgzProohbDYeXKHAc0ousMPUfAkS5FabcFKTwEpBHD/v0GNkdVWyhkURsSoXNQ rIjth8QiZdocipikZ+gmgtFooIz37YXMkOCVinEt2zBnUtpr452z4Hm0VEDQy21MVl7R Y43XuoUSSte2PmmZGaf9G+vMYxV75OVpvLfksT5ZRRbc9b+EcmMgI4nVXBD/4zrkjE+g DJvMd+fPkpI5htvON/CghZV9emlOh/IPPWj42+sbrSknTZuZEvzg49600V1KYfmoSNfs 1isQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8uCh2fmiVJ0Fv7CxbxcyCYgCxrp8a63KW8vHU+YPmcU=; b=XE0DQHmdOGnZbqP1w1oaGLDTpSeEqb/5oEACaNM0+49cD0NDmJzRTG8O4av/v1ZjJX 9ebN0pyeDhMfyHfDm9skNqDr/B/0G3k4UUoESEuWLesd08bsqrhABx11ZGcwQVxIbfOB pW7dwFwNT5Aea99cz/Edj1qYGVApfM5aeQA/dxdm2kG69PcSsySJTD8e8FsNyoC815lg TbB89QP9BnkCxD+rBwRuFbFiBeKDorJ8dDBfcHtcSd+eQdVCzl27pnaDtRt70wdKJMB0 aabNLamUc2pCPjdT4bU6wS3S3P5ZYm52duijlLWoEjzpQ4IbtADeMipZZIlu7tNw+oZr SUVA== X-Gm-Message-State: AOAM533+HUIN1Y8ylLFJZ9n4TsNJVaxh2dH9W987z2zdlCtRN110T6la 166/9UZEnSHezzFyiL0toH9RY9Sgf2Eaog== X-Google-Smtp-Source: ABdhPJzkYyLEDFFgBag3nHogN58Jm1et2ndY+2Vx8l+9jKnGCayU+kTgrSJ2D4hwiW9CLAtIpw/leQ== X-Received: by 2002:a17:90a:a90:: with SMTP id 16mr10506179pjw.125.1642982779143; Sun, 23 Jan 2022 16:06:19 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:18 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jakub Grajciar Subject: [PATCH 55/82] net/memif: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:51 -0800 Message-Id: <20220124000518.319850-56-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/memif/rte_eth_memif.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index 59cb5a82a23f..5c2203f5270b 100644 --- a/drivers/net/memif/rte_eth_memif.c +++ b/drivers/net/memif/rte_eth_memif.c @@ -1731,8 +1731,7 @@ memif_check_socket_filename(const char *filename) ret = -EINVAL; } - if (dir != NULL) - rte_free(dir); + rte_free(dir); return ret; } @@ -1903,8 +1902,7 @@ rte_pmd_memif_probe(struct rte_vdev_device *vdev) log2_ring_size, pkt_buffer_size, secret, ether_addr); exit: - if (kvlist != NULL) - rte_kvargs_free(kvlist); + rte_kvargs_free(kvlist); return ret; } From patchwork Mon Jan 24 00:04:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106295 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71360A034F; Mon, 24 Jan 2022 01:10:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF3E9428E3; Mon, 24 Jan 2022 01:06:25 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 2F976427C8 for ; Mon, 24 Jan 2022 01:06:21 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id j16so3365548plx.4 for ; Sun, 23 Jan 2022 16:06:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7hhwjPnMALvxaQCfeixtjfBr7PvHCUrqcbBPLp2YFe4=; b=oF6ok7qz3XDZZ58NiRKXfbQdwpULoncQhGqnc087yW6/SXKL0/hR+/uJ1HAdXscRss vJvyX9eQXdw6Sg4UkOW3Id/38P3lc1QusHd9yRAlbaEXOREzA83VrztJ5aWXp+Lme7xV 4P79vv/8WjgMu+TqgwQMhSlx2QfdOelpJ2MY9wc9on/Ac2faTopYYLVfNZBB/k8Rt7Zq dyIsrHltKZHJnGiFqQfamo93kiz2soYG1U013SDljipAE5+FIq9xNAo1YOiaNW3U1n4d 4zRctfDfLyembUK7lAkGNezxFWFzbal4QPQRVDaBoRvDZ+RS1DFUTFtRpcT23a4MUM4n hDQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7hhwjPnMALvxaQCfeixtjfBr7PvHCUrqcbBPLp2YFe4=; b=lnFZWKF3vUCPtQnUqrwpeqEdasHgFF2fh0C4+QecEEzlSkRRnnyusn+DWkgR6pzuAX Qku9dxgc4dU/07rd5j2QPwaOLvAemobmF9b+mntY3+NQmQVt8nJ19EDGCHll302n6jAK 4r+szf++ODmaRBCsa7b8f89c3ZRWcM498OVok7yUg5zXDew6SQ0Dj6h9IEToybCtGanG jsaFcCySzb9EMQcaZ2hUv1TS+VMC/6Qsw5SEfHpTT+GepxmKjnu/5Wa/+NQY/9NG0ibi AXjcOJPzVO45OuR69GinXWs4XlyQYJ7RD9xILq8jJ/1ycZhAfS1JUSUp4Z3Pv91DG9St xN6w== X-Gm-Message-State: AOAM530ni2LL5arNqQiDdYpXNCv5I89Vpd71g65SMklbdeoc3td7hJe8 R2x0iwnPj5b6wiWBWMHCmX6wmi38oAdexw== X-Google-Smtp-Source: ABdhPJwynkBg8mp4OfS0uGzX5hK/UbwJ5KaEsWICIvN53sI8hajelEejXThFj7DeHuqh5j/CIg3I3g== X-Received: by 2002:a17:90b:1909:: with SMTP id mp9mr6806028pjb.53.1642982780201; Sun, 23 Jan 2022 16:06:20 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:19 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH 56/82] net/mlx4: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:52 -0800 Message-Id: <20220124000518.319850-57-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/mlx4/mlx4_mr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mlx4/mlx4_mr.c b/drivers/net/mlx4/mlx4_mr.c index 2274b5df1950..e95f45aa3e95 100644 --- a/drivers/net/mlx4/mlx4_mr.c +++ b/drivers/net/mlx4/mlx4_mr.c @@ -471,8 +471,7 @@ mr_free(struct mlx4_mr *mr) DEBUG("freeing MR(%p):", (void *)mr); if (mr->ibv_mr != NULL) claim_zero(mlx4_glue->dereg_mr(mr->ibv_mr)); - if (mr->ms_bmp != NULL) - rte_bitmap_free(mr->ms_bmp); + rte_bitmap_free(mr->ms_bmp); rte_free(mr); } From patchwork Mon Jan 24 00:04:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106296 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC6FBA04A6; Mon, 24 Jan 2022 01:10:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69924428EE; Mon, 24 Jan 2022 01:06:27 +0100 (CET) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mails.dpdk.org (Postfix) with ESMTP id 2B825428C8 for ; Mon, 24 Jan 2022 01:06:22 +0100 (CET) Received: by mail-pg1-f176.google.com with SMTP id e16so4334840pgn.4 for ; Sun, 23 Jan 2022 16:06:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dlkTRiPlJteixPbAsLxpIIe6vqw6XBxuk3//t0LHTFA=; b=tEAiqMOJEhD4X2zF2/Yhqd88SDKJeNMLABaxJu+r6c2RhawZaPHL0Y2AWtCWftnG/m QXuBw7tzjXz/QBO3vjGzvxGDjlqDKXiy85jh5zABS5CuTQmM3sqdG98U0i/6g2vRbPAA 71xWBqjdwF+JKB/sj82G6gwY6Qph68KxmsxUyHxTw7Lm56U6henY+8fzEQD+/nsfZ6Oq XwNv/ZeXpw/fYw7XxCu+aTIYSpsVnj/nXuxoMfsRVYWSx3L+PN9Mxoqf5cZTiWi8jIpV C7aWTfN1116UcklpT1IdIRsngPFI9H2sEwWGHPM6kTzO2iPUAZdpO/se+dE1F2vufM9c oFiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dlkTRiPlJteixPbAsLxpIIe6vqw6XBxuk3//t0LHTFA=; b=cUvUC1Xk5tS5LEEmu6mJx0hvnmMWGlsMGFsdV4Iv0fVaMfkJksgqNufdBJCuh1fR79 wgwTMV69jPvzjRnOP5s3OTRX/Be0kTlkv7XAyKdIQCuaxwfBgnwITMAzGtw/qVvPT8aA T6/f8ZdUHw/uGWGkEbDxY3zk/ekoD41iJubptOsA/xGXngkQT8g4DeHOVIyhQyaSmG/V GKeUeEmskzXOWmdpMDQQ/PeRwk8IbLMQpmoF57IXyGzRJHV+v+KjKEeGUXPSckfUc2i8 va7Fh9NEkIfZAGq7/KLFTEPY95DfeVWCnzpcfOvBXN9++ypvnrHPeuJJKdJJG6D4CAXh wk3Q== X-Gm-Message-State: AOAM532N0jUD7j1ZDWXX6QF71Vg2dip/ekz+wez2X00GDFrXvTeB8+F/ 5iCeBC2xrPZA+3u7YvF9HHYrF66rOCGBvQ== X-Google-Smtp-Source: ABdhPJyxVtINqM9Hl4KF+mh7uGHoGs75olefQoImk++H7kfpRn3coqwziAHk2BeNFwvK6rk1Ehv78Q== X-Received: by 2002:a65:604a:: with SMTP id a10mr6331434pgp.357.1642982781217; Sun, 23 Jan 2022 16:06:21 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:20 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH 57/82] net/mlx5: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:53 -0800 Message-Id: <20220124000518.319850-58-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/mlx5/mlx5_flow.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index b7cf4143d5a1..c718dbdb3dc7 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -6990,8 +6990,7 @@ flow_alloc_thread_workspace(void) data->rssq_num = MLX5_RSSQ_DEFAULT_NUM; return data; err: - if (data->rss_desc.queue) - free(data->rss_desc.queue); + free(data->rss_desc.queue); free(data); return NULL; } From patchwork Mon Jan 24 00:04:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106297 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DCB5A04A8; Mon, 24 Jan 2022 01:10:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EC6F428F2; Mon, 24 Jan 2022 01:06:28 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 32245428DA for ; Mon, 24 Jan 2022 01:06:23 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id n8so13939896plc.3 for ; Sun, 23 Jan 2022 16:06:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X0KYvnhqPS0AwyvpQRsz4f0giuWmYu2qJVVxxofx+Og=; b=usrViEQa8QIPh0nvfrjDKYudlAceGajjlwmzRMQY8QfBgNpGe1JeXWk1iTgcOFhHzt 1232utGFAfOdu1axLIPdGpv/i8rsMCFZM2jRoQRMCtVcqlyB85ALWAsi5PETtLoxPlLe t3B7CgQgTcjVfE2e91CVZ2kKqblP4vFdKxGcpH6RGanbq1/8RLvbAQygWKirhyEJDhiU qnoNjt6LbRciYKI29ChpeBgJWmEM5TDKwp3SFXf3eb/ejYUUnFfOO+Q3rwXO+Pgcv6Ea /CfWrTppH9c2SY0spzYATtWFyLYcjUmHx0FOSEDNsKAKMPpbrF/kDnQ2/gO95+Fnx35K 32NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X0KYvnhqPS0AwyvpQRsz4f0giuWmYu2qJVVxxofx+Og=; b=2aasBZpgFPDr10uvzJmitZ5kecyzYxwk3CXVcuOPQKYW7CIFnsp6nm2hWw/USowjOM 7+AbbcdsSJ+lKfbODVcwYCnTy8IZIdmWjk7FhnxTYcduK+oKSFCK2JEt7kqHA0vcO0t7 fVUTxutof4qbPTlr9S6YPFu1sDLjTH7WbMK37F1KIsarVYVGs5IklEKN2IFWf/GaI29H r0cZlPDj9isF7OSFVK+GTE7ZlouyTWavwmlrMYnCzwdTM2NLRwod7UM/7WUFJecRj5Ur A8mEF0Xo8m4kOHQh0bi3B9+NLDOsK/oqIneSBSHQnzVuwg7gTOgwlz1MYZG/HbvW2/f9 tR8w== X-Gm-Message-State: AOAM533kZv+ANeaSl8fr5OMKnSP2Svgrw8kwAdVnH8vY+zg0dsKY8bOi swHhs9EmpQcxcQZbizQO+Z9q2WjpXIDB8Q== X-Google-Smtp-Source: ABdhPJxfLu8GtV7sZSls5y3AdMGxix/IH1CEfnXntyVUu17mhrSlekA0zDIteTkbZjYLN8/YRzNn9Q== X-Received: by 2002:a17:90a:d596:: with SMTP id v22mr10726437pju.87.1642982782182; Sun, 23 Jan 2022 16:06:22 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:21 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Liron Himi Subject: [PATCH 58/82] net/mvpp2: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:54 -0800 Message-Id: <20220124000518.319850-59-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Liron Himi Signed-off-by: Stephen Hemminger --- drivers/net/mvpp2/mrvl_qos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c index 99f0ee56d1a7..f43217bc589c 100644 --- a/drivers/net/mvpp2/mrvl_qos.c +++ b/drivers/net/mvpp2/mrvl_qos.c @@ -945,8 +945,7 @@ setup_tc(struct pp2_ppio_tc_params *param, uint8_t inqs, param->num_in_qs = inqs; /* Release old config if necessary. */ - if (param->inqs_params) - rte_free(param->inqs_params); + rte_free(param->inqs_params); param->inqs_params = inq_params; From patchwork Mon Jan 24 00:04:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106298 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73B32A04A6; Mon, 24 Jan 2022 01:10:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6466E428E9; Mon, 24 Jan 2022 01:06:29 +0100 (CET) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id 39381428DF for ; Mon, 24 Jan 2022 01:06:24 +0100 (CET) Received: by mail-pf1-f170.google.com with SMTP id e28so9786256pfj.5 for ; Sun, 23 Jan 2022 16:06:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Gr9VBJf1wriPszZUgTxGzBXtWstZYad04nolY1GAl+k=; b=a5oMhYXkWxs/5CpiZdNGt4d4fewjf35rewQRjNBBDBzamXof4YE3FG+60Rio6Hs4rx ioX/vIY0NswdESeStJq9I0TUT/7Z0tsnpt9dc1KAH51D3tcvLLHmLlCpqQtJs05Y8ld5 TZkyeogqck1/p8i2272ZqeCZyS683qxolufgTQyu+ahkJsnyCjLOy3xZNUokil6SO3ap sK0HtPWkySrK4p3KeUiX3q/42yGBsbdXI4TG5Fge88eVTl4y83MCN4ILheOo3iOOb6Cb elUUzEE4EJGdpLrFzbQTQvGbbDBnwQj87D4svewfXO9v6sfyTX16zVgw/rU5YxPTc4SP zFaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Gr9VBJf1wriPszZUgTxGzBXtWstZYad04nolY1GAl+k=; b=SXNu2asfwvoEKNOLOEt/q0B7yashvcOk+/73pyTVV0lCZJCVB2/wPJObf/5HsdbUJq M9++qdwvo9XgZYPt6/qI/Gw/OMvf/DGX8eIQ7TjUtw7S0P9M8My8QHmlP3r1hraigauV TEOD/3SaKMBnyLn+s24QmbV5+XsSMfOuKUiCCLzqdJN4iRCl4Nxg9QvCZY8fdIlCaD79 Bih5FQ8rK/BOv75ZYfsmPXzzhBgZse5rqPpH7fLbAo8D3xSGobtsu+mpl/9kNAKj5seo x0OQvDofF/w8HFqaxJ6xrNfCWN17FGmhLWlU1yLoM1eF6fharWLoJXW84HBo9d+GZMyI 5xig== X-Gm-Message-State: AOAM531N4zFl2Yf0MeOxGLzyyCRx0csuql6pSwNxDxFHK1lKwryFW4KJ 1h0Tcl/wf3kFzb0Wiol2Ia6HeVOSWItOgA== X-Google-Smtp-Source: ABdhPJzZ3toT8XENrhqIytxRNEMHNtanwWgo6X4pu2OosBBLjHNPKyAlkSrMqnCyN2tdFOUXlkPzPA== X-Received: by 2002:a63:4f0c:: with SMTP id d12mr10148557pgb.133.1642982783202; Sun, 23 Jan 2022 16:06:23 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:22 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Stephen Hemminger , Long Li Subject: [PATCH 59/82] net/netvsc: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:55 -0800 Message-Id: <20220124000518.319850-60-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Long Li --- drivers/net/netvsc/hn_rxtx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c index 50ca1710ef3e..3e3488f1b87a 100644 --- a/drivers/net/netvsc/hn_rxtx.c +++ b/drivers/net/netvsc/hn_rxtx.c @@ -315,8 +315,7 @@ hn_dev_tx_queue_setup(struct rte_eth_dev *dev, } error: - if (txq->txdesc_pool) - rte_mempool_free(txq->txdesc_pool); + rte_mempool_free(txq->txdesc_pool); rte_memzone_free(txq->tx_rndis_mz); rte_free(txq); return err; @@ -365,8 +364,7 @@ hn_dev_tx_queue_release(struct rte_eth_dev *dev, uint16_t qid) if (!txq) return; - if (txq->txdesc_pool) - rte_mempool_free(txq->txdesc_pool); + rte_mempool_free(txq->txdesc_pool); rte_memzone_free(txq->tx_rndis_mz); rte_free(txq); From patchwork Mon Jan 24 00:04:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106299 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E070A04A6; Mon, 24 Jan 2022 01:10:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 443D9428F8; Mon, 24 Jan 2022 01:06:30 +0100 (CET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 4870A428E2 for ; Mon, 24 Jan 2022 01:06:25 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id 192so10784830pfz.3 for ; Sun, 23 Jan 2022 16:06:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pmG6yMayEtiph+FrBafMWrazhYRcXID3b2Oxjkc6Zrs=; b=2aSrUwdTb7NDuZVQw60S4b3sN7MJ3P0E85CxbSRUcxq7dPKdlVKzj4ShHwH1wPtZWg 25qLGX0PGKQT0fH4/YsWf8+Pj3nN9CJSZFyh6kkuoro/BMsuV8aG3mymeXGDM/669i47 BPcU2G8NGi+/4T/+1A1/qpkRfZ6B/+aRpYCBfmX5QQJ2PP9nOrufGdGUt2VxmtQkVUGL eXIhqVQyC3kU+db9vDCMCZL8SeSPrIZ1d4AoRfWn/bfgxjFxYbIIdBat25C/FEdUfelT YOKM2LtTqV86G0O02z9VeY6VICXDjnekX2PVBuNmviOHwDv0iWnorsqXorF8zLJHmK4O TDiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pmG6yMayEtiph+FrBafMWrazhYRcXID3b2Oxjkc6Zrs=; b=XuMr9q5C+6A/Nt5qXI3s88jqKtUTCtzkxxRT0XYhVnwecNDAkM74FpzBZwDDeSSS2Z HH0axhvKhAZxWq0k11o+crfvKX8tQphfr3jnezCqUkA1QsAoveRV0s1YR5om75uJupnC vr2KrS8xrK+Y1XLsdlpZx8ticFkF5lSfmERvjkmR1gd076Gz8OUn1Rd309U3W0e4LaDr xufD9rNI6r7fnOt751olayhBRvQSATNT3gRgFqIhUzmqtJjzGbjUrSQUfRibfPwu+3pi ZdBbPtIRuEy8YMITVWEg+Q7OQQH5aYjf700kPwwKYi1EliH+laMRjDenXTrspkq+lj2N 6t5Q== X-Gm-Message-State: AOAM532GAO1mgupMGLkghqb63wx9r5vIBJt/p12Od/sEMrI7F+xURADZ 7HZ+KV67dQDp/nX6vqeyet83DYXvX5I9zA== X-Google-Smtp-Source: ABdhPJzT1daxZ+8euizAryE/8AjditbDk8fVcl73d8fnxy1dXCsKZU9ckPrjjOBIRnQ0zQMvUDbuNQ== X-Received: by 2002:a63:204a:: with SMTP id r10mr9982612pgm.502.1642982784272; Sun, 23 Jan 2022 16:06:24 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:23 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tetsuya Mukawa Subject: [PATCH 60/82] net/null: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:56 -0800 Message-Id: <20220124000518.319850-61-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/null/rte_eth_null.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index ca03469d0e6d..bb89c1abc4a2 100644 --- a/drivers/net/null/rte_eth_null.c +++ b/drivers/net/null/rte_eth_null.c @@ -717,8 +717,7 @@ rte_pmd_null_probe(struct rte_vdev_device *dev) ret = eth_dev_null_create(dev, &args); free_kvlist: - if (kvlist) - rte_kvargs_free(kvlist); + rte_kvargs_free(kvlist); return ret; } From patchwork Mon Jan 24 00:04:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106300 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EAB0A04A6; Mon, 24 Jan 2022 01:10:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F4C0428FE; Mon, 24 Jan 2022 01:06:31 +0100 (CET) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id 5EE2C428E7 for ; Mon, 24 Jan 2022 01:06:26 +0100 (CET) Received: by mail-pf1-f182.google.com with SMTP id e28so9786309pfj.5 for ; Sun, 23 Jan 2022 16:06:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aM7tNyASPlh+DnGyAiA3m15Y+BufQ2gncxDDkMNTg48=; b=UXimnap9R6M54YseHO4lTZ0QYwas3be+xIChpOE5GCV/4tNZb/DkJtqccPnTlli+BY rqcEM+gAiE3g1fR0tesC2BFjT2MHe1jXZn4kLemsddpEIs/15SwPMR9MaD0dAeKs2RrU BqkMyBjOJYCa23OMzxdcd6sKLhkkqtolI6IymHrD4Sgm9S7LTz3LEAP/+vSMXsTSxv64 lpGy2V2bA+KMrr2j5KLrW7l85i/gVAoMezVadS1r2U9iovJ4AtoFpB1hjtZUPRiBrSS2 deBgwvjhYYObqtFXd3VexmCJojVKwzJad/0QegXCHgYKAd9c5NB36dGoJr4YxmETfNgU OG2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aM7tNyASPlh+DnGyAiA3m15Y+BufQ2gncxDDkMNTg48=; b=E47cyS2wg/0Y2sLfxM5fy/PhkEhRNUuQ4xP5XEu4UDlgphv2pSEozy1dsFhHMiGBa1 YSw7r5lwJD+Jf9sxnkaTVUFdDwqFbxMc3/cQkQSoURPF2hpZbh2TE9vxLPfjQCipNrVR xrbDU8YBxZY7xlSpVshupfCIOfzqZ1puOXDufc2XIhiPFFYCJly21yEVVkNVwKogitL7 sttX87tOB7SWmZ30mobu7Xt/1nTdRxVjdLHFpG5+2OpieIFQXT/BK09UNHKq6XPTdGZ9 Y4HnFJVhoAbbScEYJ7VPKdkrS9RrRPbGZxfvX/mLSSU9ONjQJjoNBed8QCgrMlFZ7OLo Jg/g== X-Gm-Message-State: AOAM530rFWh/WAbO5cuUceGqwv5K1KX56ei0xLEX/pHhKhaZVIlv7VXS lih+3CDw6fbseRipD5IJwNJBeyhfrD7+Gg== X-Google-Smtp-Source: ABdhPJwYBqn2WBaAkSXhWHJeMLaymuJm5PloJ4O3CFu61BG5/wPV9LfymTDv+HlihwPQjKOKMN6hLA== X-Received: by 2002:a63:8b42:: with SMTP id j63mr8523766pge.501.1642982785347; Sun, 23 Jan 2022 16:06:25 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:24 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Harman Kalra Subject: [PATCH 61/82] net/octeontx: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:57 -0800 Message-Id: <20220124000518.319850-62-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/octeontx/octeontx_ethdev.c | 3 +-- drivers/net/octeontx/octeontx_ethdev_ops.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c index b47472ebbd93..f5ea9de8efe5 100644 --- a/drivers/net/octeontx/octeontx_ethdev.c +++ b/drivers/net/octeontx/octeontx_ethdev.c @@ -1037,8 +1037,7 @@ octeontx_dev_tx_queue_setup(struct rte_eth_dev *dev, uint16_t qidx, return res; err: - if (txq) - rte_free(txq); + rte_free(txq); return res; } diff --git a/drivers/net/octeontx/octeontx_ethdev_ops.c b/drivers/net/octeontx/octeontx_ethdev_ops.c index 6ec2b71b0672..0b22e28a5625 100644 --- a/drivers/net/octeontx/octeontx_ethdev_ops.c +++ b/drivers/net/octeontx/octeontx_ethdev_ops.c @@ -108,8 +108,7 @@ octeontx_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on) if (rc != 0) { octeontx_log_err("Fail to configure vlan filter entry " "for port %d", nic->port_id); - if (entry) - rte_free(entry); + rte_free(entry); goto done; } From patchwork Mon Jan 24 00:04:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106301 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71D60A04A6; Mon, 24 Jan 2022 01:10:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A61142904; Mon, 24 Jan 2022 01:06:32 +0100 (CET) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id 6759F428ED for ; Mon, 24 Jan 2022 01:06:27 +0100 (CET) Received: by mail-pg1-f179.google.com with SMTP id h23so13610680pgk.11 for ; Sun, 23 Jan 2022 16:06:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ge/FJhu17ijyXcd3XG2ocB4hhvAimFOCzaaCeUqhKgw=; b=thYpsjYl0E1X1k+1rn/zROdYNc0fDNlWfaUsBDTg7KH7BOtDGBl3Iw+Pw6DVE1GpO6 VNT0RyUjqA01gWOai+NidyKRAEgm+VuvgKJMimdl1FTsAvNBW+OkOV4AJRA1g+86Y6my xRxVApLolk1I207yvnIelU5qNSO8SNp03rlDQoj1e/XWULxgF5cViuQ4jHEITMuxx7Iz OjrrIB1ESHENgwtIzBBLJ+GF5xULwITpXFmB1h8XKFoowITIfPfL29MX+p/BTVW32Mx9 YXQzvPL0DyIZM0HZlAVr0EwIDJq73tz5637bYfhEF6OE54qpe+M5kl1I8O3jZFuct5OB CLSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ge/FJhu17ijyXcd3XG2ocB4hhvAimFOCzaaCeUqhKgw=; b=2zhuHq+4Rni5six/93a1YTrD8mbQhdVrRvan70sP3DskY1wdNb3Qdd5E5WXfjXb+BF sLCzDnKvzKGbBOUJa+49AxUaJ3s5D+qhkiGrMl1NVNj8ZoFhRXObFFe/qukNNCOrblb7 xa4YajyzlBHAbEBYNudITetif1gPZ0p25fkbxR8f325NBvm6n/MIOcnNRnWaecdgf593 7ZrwqNYz49JARtoitaQWlcqMPpoHmAtjPcwTqb6mec886kvKoZ4L1GZVO+OLaJMfNHIh 5RRBDj7AM1YDUF5CSrhtI4oKIbVnHUVaf49QMP3lHLIHnHSMxCsBXBe9STFNM68hbht7 tBfw== X-Gm-Message-State: AOAM532stbdUwjKlMCWcwgZpk8TUzVVBZyQ8bXB2D46ZbR5HaJ0ov0Pd firWsKXl1cygeIaZH3vmTh2AsJpv4tAdzA== X-Google-Smtp-Source: ABdhPJzdcU8DEB28dMSsAqSouDnkPEcEcUmbB1++6U9qCJKJv0ixC6VPsdySlCXNaH4VXQZcHaa9mQ== X-Received: by 2002:a63:36ca:: with SMTP id d193mr9996656pga.88.1642982786396; Sun, 23 Jan 2022 16:06:26 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:25 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rasesh Mody , Devendra Singh Rawat Subject: [PATCH 62/82] net/qede: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:58 -0800 Message-Id: <20220124000518.319850-63-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/qede/qede_main.c | 3 +-- drivers/net/qede/qede_rxtx.c | 6 ++---- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c index 2d1f70693a3d..ad101194d613 100644 --- a/drivers/net/qede/qede_main.c +++ b/drivers/net/qede/qede_main.c @@ -335,8 +335,7 @@ static int qed_slowpath_start(struct ecore_dev *edev, err: #ifdef CONFIG_ECORE_BINARY_FW if (IS_PF(edev)) { - if (edev->firmware) - rte_free(edev->firmware); + rte_free(edev->firmware); edev->firmware = NULL; } #endif diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index 7088c57b501d..1c0a6ba5f1bf 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -706,12 +706,10 @@ void qede_dealloc_fp_resc(struct rte_eth_dev *eth_dev) } } - if (qdev->fp_array) - rte_free(qdev->fp_array); + rte_free(qdev->fp_array); qdev->fp_array = NULL; - if (qdev->fp_array_cmt) - rte_free(qdev->fp_array_cmt); + rte_free(qdev->fp_array_cmt); qdev->fp_array_cmt = NULL; } From patchwork Mon Jan 24 00:04:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106302 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C30DA04A6; Mon, 24 Jan 2022 01:11:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54FC94290F; Mon, 24 Jan 2022 01:06:33 +0100 (CET) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id 9468B4289A for ; Mon, 24 Jan 2022 01:06:28 +0100 (CET) Received: by mail-pf1-f173.google.com with SMTP id n32so5132864pfv.11 for ; Sun, 23 Jan 2022 16:06:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lx2bqkBQ3SPk3ET4LLPF+ZmKB1ZAk6/Mtv2wfAKRtr0=; b=44DVBZB5LVDZNSKsTLSzHlDITBiE8wjbkTYKrxJNevLoL+NXFjn+QAfH3pwslMiHCM x2pBrB/ARraH5vJsPNBF7FMoesGlV0xytelzlOu2P4hG9A6A8kY3SO8URwxOCashj/Fn QYvdXNZ/aE1k3c27FRT53F4qMtnbZIguaqh2FOAA7DKhIqAIn/L7MR+pZHlyZcHKdpeV DZU2MbCUa/RM+LI0HU+K4tMPNA0yP9+V7pVTJhfsT12Vz06IQ2Jq2Wck1SnYkMuitH0d PrzLXmcmsqV9bsYktO8nY9j5lWPW3I7nrVQ5r2w/LEJO877GeAHqtOPG8yDJDsovOGu9 0aNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lx2bqkBQ3SPk3ET4LLPF+ZmKB1ZAk6/Mtv2wfAKRtr0=; b=Q/trLopJx3QpDy0Mb8XL6ggo1bLgOhgG0PkKMyCpzATiTUn+vziLhWhnsbAW3LUXVm pe/ovOMMvNqxi0Z+TZ9JPubLv05y9Aa1QvQwqYxeiANiyUYlF5NHcScLULOJBO1j8TEz 2lNxjFtdkOS4Jhq2ivt6svZqzK23C28b/H5KglF9IbZZ8tRhNZ3jQfiqMEZjWjvI4fI0 vGcrOBxpRmavEXoiYv5jlgYts6e1z/lo5JHROMNFnIOc89jx3nWEOGAjM8FwynS8H/Ut MVEujlAIik8spsjkUql0JwHp3aV90UCrGPA8aUxAZQbw4tIGb0UP6RliG6wyZngcCaDh f7jA== X-Gm-Message-State: AOAM53018jgU2decLBdDUlJ045T2creznVFto0CKNyf3H+sFptfJcUPB qejgkBtfzjgjxaWzEfdn4jwQ2WgYPdcxzA== X-Google-Smtp-Source: ABdhPJzSerGZJMjMBUpS71SUdjTkBSDvVaZde8bNl7RKuGpNaD7YjqI1bjPcn//krLiHGfHDviaZgw== X-Received: by 2002:a63:6906:: with SMTP id e6mr9978883pgc.170.1642982787437; Sun, 23 Jan 2022 16:06:27 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:27 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jasvinder Singh , Cristian Dumitrescu Subject: [PATCH 63/82] net/softnic: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:04:59 -0800 Message-Id: <20220124000518.319850-64-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/softnic/rte_eth_softnic_cli.c | 12 ++++-------- drivers/net/softnic/rte_eth_softnic_cryptodev.c | 6 ++---- drivers/net/softnic/rte_eth_softnic_thread.c | 6 ++---- 3 files changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/net/softnic/rte_eth_softnic_cli.c b/drivers/net/softnic/rte_eth_softnic_cli.c index b04e78c6e0af..7acbeecae7a2 100644 --- a/drivers/net/softnic/rte_eth_softnic_cli.c +++ b/drivers/net/softnic/rte_eth_softnic_cli.c @@ -4482,10 +4482,8 @@ parse_free_sym_crypto_param_data(struct rte_table_action_sym_crypto_params *p) switch (xform[i]->type) { case RTE_CRYPTO_SYM_XFORM_CIPHER: - if (p->cipher_auth.cipher_iv.val) - free(p->cipher_auth.cipher_iv.val); - if (p->cipher_auth.cipher_iv_update.val) - free(p->cipher_auth.cipher_iv_update.val); + free(p->cipher_auth.cipher_iv.val); + free(p->cipher_auth.cipher_iv_update.val); break; case RTE_CRYPTO_SYM_XFORM_AUTH: if (p->cipher_auth.auth_iv.val) @@ -4494,10 +4492,8 @@ parse_free_sym_crypto_param_data(struct rte_table_action_sym_crypto_params *p) free(p->cipher_auth.cipher_iv_update.val); break; case RTE_CRYPTO_SYM_XFORM_AEAD: - if (p->aead.iv.val) - free(p->aead.iv.val); - if (p->aead.aad.val) - free(p->aead.aad.val); + free(p->aead.iv.val); + free(p->aead.aad.val); break; default: continue; diff --git a/drivers/net/softnic/rte_eth_softnic_cryptodev.c b/drivers/net/softnic/rte_eth_softnic_cryptodev.c index 9a7d006f1a09..e4754055e90b 100644 --- a/drivers/net/softnic/rte_eth_softnic_cryptodev.c +++ b/drivers/net/softnic/rte_eth_softnic_cryptodev.c @@ -159,10 +159,8 @@ softnic_cryptodev_create(struct pmd_internals *p, return cryptodev; error_exit: - if (cryptodev->mp_create) - rte_mempool_free(cryptodev->mp_create); - if (cryptodev->mp_init) - rte_mempool_free(cryptodev->mp_init); + rte_mempool_free(cryptodev->mp_create); + rte_mempool_free(cryptodev->mp_init); free(cryptodev); diff --git a/drivers/net/softnic/rte_eth_softnic_thread.c b/drivers/net/softnic/rte_eth_softnic_thread.c index a8c26a5b2377..1b3b3c33c175 100644 --- a/drivers/net/softnic/rte_eth_softnic_thread.c +++ b/drivers/net/softnic/rte_eth_softnic_thread.c @@ -29,11 +29,9 @@ softnic_thread_free(struct pmd_internals *softnic) struct softnic_thread *t = &softnic->thread[i]; /* MSGQs */ - if (t->msgq_req) - rte_ring_free(t->msgq_req); + rte_ring_free(t->msgq_req); - if (t->msgq_rsp) - rte_ring_free(t->msgq_rsp); + rte_ring_free(t->msgq_rsp); } } From patchwork Mon Jan 24 00:05:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106303 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88284A04A6; Mon, 24 Jan 2022 01:11:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F4E742916; Mon, 24 Jan 2022 01:06:34 +0100 (CET) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 90221428F8 for ; Mon, 24 Jan 2022 01:06:29 +0100 (CET) Received: by mail-pf1-f181.google.com with SMTP id a8so8884462pfa.6 for ; Sun, 23 Jan 2022 16:06:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SgZdxQ/v/3DIRfFsYYu4kKYbFgzbBEnlT/pyFLbih4s=; b=b9jw1J71s9zw/fuVmyhIBu2aVfyg1gq0gQmkhwG9jfOSi6thU0rpNaa5dACAaYLhVb JZIKnylK0cqw4jmgSUir2dOzxIy1P8TSrA/14ojfcY3q7UiRX2Rh+zvnHi7jsqxOG3D6 dBKqnjX5YfVBMTscMFGvD/pw/BDdbvLu1IJ6ZBFMADV3NLxBnryOdd7OaeqP7wg2ms4M qp91PifBSQ9DDw8G4hhcTPKCFsYMc8c3Q/P0F3hEdizJ1ngIWoIm5RbIAApDdUsto7G4 OAMgKxgC0i2EmBWavEBvs+g0NipqG9EHu/v26Xynq+VYBbX4QkhkbXT9ATOJlwpmeOXJ LsZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SgZdxQ/v/3DIRfFsYYu4kKYbFgzbBEnlT/pyFLbih4s=; b=5UvvzPv5ps43BwqrEnu0s+nSuD8h7AtkUxGw7xJDx7Ga6pPkg35ygh8cdo9C4uXRny G7wormsIWwheWXoaO+4HJoPLwm2vE4wG77oM1aQtqCx125yDQIxZIG24ePWeGxJ/HzOy oUmDYgXCghWVjsZxwj65M0KPsdiUghcRU1bGJecqyniLyshq5EwU7zBbk8FQBc12Bwoo ymhxJSXaG71Az3fz1+iOluMgzxPEIdJefV7Q1HSIk+6tUA+F9LjPPlp20c/yvtlL3l8r r+r4eSTs1ZFw3lkDq3ouqG1gZ1Tz1qc/2rNrkvMUksVhYLFggs0MfgStYGMtGQPCQ0t+ avVA== X-Gm-Message-State: AOAM531ImRI8yWqAJ0Q1CT9c/yIwVrU36snI6mkibooAudM6PdWde3Ac R0yJpnXtB4tRqwHPc6F3o4sBPbFIvuTWVQ== X-Google-Smtp-Source: ABdhPJxSC29klCaimTvn9XE4LrlLOyIrGmQcrK2wBYz3FXnTkEj+l6z1sWdiTiZxVsoVKuq8m0HCoA== X-Received: by 2002:a62:64d4:0:b0:4c9:6871:59b2 with SMTP id y203-20020a6264d4000000b004c9687159b2mr1991385pfb.31.1642982788539; Sun, 23 Jan 2022 16:06:28 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:28 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Keith Wiles Subject: [PATCH 64/82] net/tap: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:00 -0800 Message-Id: <20220124000518.319850-65-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_flow.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index 76738239458a..a9a55e439efc 100644 --- a/drivers/net/tap/tap_flow.c +++ b/drivers/net/tap/tap_flow.c @@ -1465,8 +1465,7 @@ tap_flow_create(struct rte_eth_dev *dev, } return flow; fail: - if (remote_flow) - rte_free(remote_flow); + rte_free(remote_flow); if (flow) tap_flow_free(pmd, flow); return NULL; @@ -1541,8 +1540,7 @@ tap_flow_destroy_pmd(struct pmd_internals *pmd, } } end: - if (remote_flow) - rte_free(remote_flow); + rte_free(remote_flow); tap_flow_free(pmd, flow); return ret; } @@ -1764,8 +1762,7 @@ int tap_flow_implicit_create(struct pmd_internals *pmd, success: return 0; fail: - if (remote_flow) - rte_free(remote_flow); + rte_free(remote_flow); return -1; } From patchwork Mon Jan 24 00:05:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106304 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2ED3CA04A6; Mon, 24 Jan 2022 01:11:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B6B642917; Mon, 24 Jan 2022 01:06:35 +0100 (CET) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id 94777428FC for ; Mon, 24 Jan 2022 01:06:30 +0100 (CET) Received: by mail-pg1-f178.google.com with SMTP id j10so1503804pgc.6 for ; Sun, 23 Jan 2022 16:06:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E96ft4qyO/eqoKsfrx/yiUbkbGpU8voQmEFSYUalvxw=; b=0qzc6tYBUDvGbX0d7IjTXJGUbbrHfxajx+iwVi9yQbB/v8geG0rRDNT/WpSaIqekMT Z6LUgbNWOhEHGHYzu5NUtc5Eglbj+NETyFVqQT7LVyGwb81F41ZdotczgPu4B5HgGKzM QZDyKGn5brpQlO6PWJkEQcG8nsbbC1tCA5F3y7Lm/rkaLr/fZb0tRzN7mh126/1WmrTA x6JFPvnwhbSktUfM5zA7LHdyJn5+CBHrEqQfIR8xEZMEy97g8kALlVpUiWkhjaXqMkSt Yy3RAj20obqm1J9KT2TW35GnlEN5XnajWwq7PqAOZFu5BV13waLze1h1F3hpyJ3Gv/3A NQBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E96ft4qyO/eqoKsfrx/yiUbkbGpU8voQmEFSYUalvxw=; b=mgRDuxfOmMM+sMbUDTSW21fQZImH+kuHvfsm/z7sEGZPtMIW2rhYFAo6llMmC5vewP ifW3kLT/NYsV7POxMWCzspcPueWjAR2q/EznkMMqBCPfu3E5Vu4tM64HAigjUfbhHLb9 u3ybdLSl2xdJmTcXdwv/8eYEbuuZ6n513YrnfQMrIW0AyTh6WyrayHmmmgLsRi7+8Se6 j0Jrfk9Q37BtD/Don2gUcq8fUgzAF9O72k/sMIR/q+EaSBexJgyV5CkouWgRY9Rmikrg j7iu1ZL4b05vR0/MZA0quqYkFtj+bBBaMEuGdwh2n04ptgXmkgEXBOtCH7U2I6MwqnrP sdgw== X-Gm-Message-State: AOAM5327M7RqbJ1T7x+BLbsKtUbpjDDCSpJ4OzDhbIo4FFeHOO5rLJKR CDPBwnIo2ZdgtIBoGiwgfNsu1ro+hq1d2A== X-Google-Smtp-Source: ABdhPJwqMUo1+jf3uu6NQzZGM+MXuDKnXJfp6e1R6utju7P6XB4UsGxrIbJ3N54azYsMxGIiVUvoYw== X-Received: by 2002:a63:6ac1:: with SMTP id f184mr5717409pgc.455.1642982789574; Sun, 23 Jan 2022 16:06:29 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:29 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jiawen Wu , Jian Wang Subject: [PATCH 65/82] net/txgbe: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:01 -0800 Message-Id: <20220124000518.319850-66-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/txgbe/txgbe_ethdev.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index ac4d4e08f407..6024397072c8 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -821,10 +821,8 @@ static int txgbe_fdir_filter_uninit(struct rte_eth_dev *eth_dev) struct txgbe_hw_fdir_info *fdir_info = TXGBE_DEV_FDIR(eth_dev); struct txgbe_fdir_filter *fdir_filter; - if (fdir_info->hash_map) - rte_free(fdir_info->hash_map); - if (fdir_info->hash_handle) - rte_hash_free(fdir_info->hash_handle); + rte_free(fdir_info->hash_map); + rte_hash_free(fdir_info->hash_handle); while ((fdir_filter = TAILQ_FIRST(&fdir_info->fdir_list))) { TAILQ_REMOVE(&fdir_info->fdir_list, @@ -841,10 +839,8 @@ static int txgbe_l2_tn_filter_uninit(struct rte_eth_dev *eth_dev) struct txgbe_l2_tn_info *l2_tn_info = TXGBE_DEV_L2_TN(eth_dev); struct txgbe_l2_tn_filter *l2_tn_filter; - if (l2_tn_info->hash_map) - rte_free(l2_tn_info->hash_map); - if (l2_tn_info->hash_handle) - rte_hash_free(l2_tn_info->hash_handle); + rte_free(l2_tn_info->hash_map); + rte_hash_free(l2_tn_info->hash_handle); while ((l2_tn_filter = TAILQ_FIRST(&l2_tn_info->l2_tn_list))) { TAILQ_REMOVE(&l2_tn_info->l2_tn_list, From patchwork Mon Jan 24 00:05:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106305 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8B94A04A6; Mon, 24 Jan 2022 01:11:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4FE234291D; Mon, 24 Jan 2022 01:06:36 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 80FB542901 for ; Mon, 24 Jan 2022 01:06:31 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id n8so13940089plc.3 for ; Sun, 23 Jan 2022 16:06:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cJ0M+HCDv986gQbgz0ZRF2GNeTtogQcsh34js/wezAs=; b=cfbneRSC6g4rJB19F4JRScLg3ih/uUOYHo84LduedtPUt6aollVdPcE5Qt6b9duC4X dw78WK0D3PkYMowmmg24vQPrNn2ry+n7LPZ63hc81h17LDmfb16sWWAm8onFDHyRydmJ u250aTPXe80T2h21GvVB13LPB+EQE3RMzaGBNom8zEXGlJ/D0qquGKQuZlOyqq77DgSE Eg+M4o5WOFC8UDdi55Xaf1MHNvffkSJx7/OsLhFWb5LZPmXJz5cpjI4Mc7HyFoqzCG2o xgdzEtDlxJ9c+b43S6xZnlJuvT4ziZ9LT2RrqUUzTTJJv1XKnfug26kUVsMLcoETjErv gogQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cJ0M+HCDv986gQbgz0ZRF2GNeTtogQcsh34js/wezAs=; b=OC5eaZ1U9kflnU95P6Hbyo7MYG7hxjz8SANH/2UTZCrSGiaaBaxf92BxCelr9JxCFH c9WUEAZ9ZSQ5kZ1q4WItxBQVP+tq9QJyKydDMGX+flDjHVJpNClDevAXRG1KYrHhLbIf YIJDGepqau7HcpU8RTjaqnAA/D0mcVjRpKvh5B/IyqwdXCOTkZn12IJEM8PSADL3He/d CSMTORsCqydyGk0sfOVVOdJc3LRkszoPojhBxAunoVjMEKTcmMk94fDoj3T/hUuzSVIq fMgiHsBbFwqBt1WyjTY7c+ThcKRVV618YnklvWTk/iq5IAN8+wNQdu8XpT1jDdpRxiiD ulug== X-Gm-Message-State: AOAM530bmdCzaojEnPGf8NPJWdOp81RlX+iW7wu6DDNpXxVQLWdFyQtt lvnVzYWLww5xiBHGZ/oHU2TD2wdzrk5iuw== X-Google-Smtp-Source: ABdhPJzYoGo0PN/a037Bo924hyza6xDVsJN9y/4MKlBTCJup7QGzbhIXCHV/Y2A8R2I70ZeE38DrCQ== X-Received: by 2002:a17:90b:3a83:: with SMTP id om3mr1049499pjb.101.1642982790525; Sun, 23 Jan 2022 16:06:30 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:30 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Matan Azrad Subject: [PATCH 66/82] net/vdev_netvsc: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:02 -0800 Message-Id: <20220124000518.319850-67-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/vdev_netvsc/vdev_netvsc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index 55f2a342c5ae..25871951685c 100644 --- a/drivers/net/vdev_netvsc/vdev_netvsc.c +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c @@ -717,8 +717,7 @@ vdev_netvsc_vdev_probe(struct rte_vdev_device *dev) error: ++vdev_netvsc_ctx_inst; ignore: - if (kvargs) - rte_kvargs_free(kvargs); + rte_kvargs_free(kvargs); /* Reset alarm if there are device context created */ if (vdev_netvsc_ctx_count) { ret = rte_eal_alarm_set(VDEV_NETVSC_PROBE_MS * 1000, From patchwork Mon Jan 24 00:05:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106306 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DEA4A04A6; Mon, 24 Jan 2022 01:11:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 377DF42922; Mon, 24 Jan 2022 01:06:37 +0100 (CET) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id 8511742907 for ; Mon, 24 Jan 2022 01:06:32 +0100 (CET) Received: by mail-pf1-f182.google.com with SMTP id x37so10266799pfh.8 for ; Sun, 23 Jan 2022 16:06:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JoXl9Uk1M4K/Z8qQv8SBHuUcSVhoJbVr0MBB/3TJed4=; b=YCLkZviYnaiiFihgMfaUySPerMN98zMPCw5ZG4jjPB4XsrJLuTbbgRMVjtguOKO575 txr2etIPBVhRUEvPX/+Ybh0CoGZ2qICdEXGwtnm+nR20tlH3Ms7qL1aAkN/iiLHyjwPV jrOgDtm818V7XKcmmgVJ1jY+cYzHTFF5ZZ5/WCF4E8ixNKvq/cb6JuVJ3ifk1NIKP6vt ro3Ov9bZgBYXNc8IL/hXJcboMWpH/rRDgxmAqKKQUUwHEUveoqIbSZmxyLxCS3IdEZYq jamZzVqzgu06NNNfzVJti76Yi9zOpiFEsXTwFiYT0D/92xh3lyn8PpLznMmF5t4zwVBg ND+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JoXl9Uk1M4K/Z8qQv8SBHuUcSVhoJbVr0MBB/3TJed4=; b=8QRlPmV4OecsWXM96Io0kygIq0tVTeiQOu5nnJE6utWTWjnvz5YQcXgxnPKNiXrpCU Ak2mEF32nAVRkwZqIts1zpUCA4MR+cwf1EgPQx7mMRABvxBZfs5nPQFzhwCfSSt6d8ww pqA1hFhRLAGMErQmGjmDz/4vorDdc2gXrBUfo9/Ffrc/2D9c3QbEomppUnuqzCx0jez4 YIdcR+ByZMzJcR27UpYEZi64yuQWgQ9DDBBzwHN6eXhEItw6ptMqZIGt3DgMvVTQag++ RQl7ZmY0YXJXdabDRAjo4XfLG1mZOyLFiWR2jfcoBZbjsOq6Bqj7uxNBho7f7M2ajmBS jQcg== X-Gm-Message-State: AOAM530gPcqz1wGxnolM9krAVWkKB6Ivp3mm1zRvmkHuqyKaBjZ4E1i9 CkSPmyqcRPTccaEBJtcjX4l4EoH6ID3xxA== X-Google-Smtp-Source: ABdhPJyimOWzQNjotahbxiMgZEPN55iVPNwqfa4AHgfQLmoolrkApI5mdPaGsb14qqgSnen1DWkIQg== X-Received: by 2002:a65:6093:: with SMTP id t19mr9968621pgu.566.1642982791552; Sun, 23 Jan 2022 16:06:31 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:31 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Maxime Coquelin , Chenbo Xia Subject: [PATCH 67/82] net/virtio: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:03 -0800 Message-Id: <20220124000518.319850-68-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_user_ethdev.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index 0271098f0da0..f6288fd0c492 100644 --- a/drivers/net/virtio/virtio_user_ethdev.c +++ b/drivers/net/virtio/virtio_user_ethdev.c @@ -688,14 +688,10 @@ virtio_user_pmd_probe(struct rte_vdev_device *vdev) ret = 0; end: - if (kvlist) - rte_kvargs_free(kvlist); - if (path) - free(path); - if (mac_addr) - free(mac_addr); - if (ifname) - free(ifname); + rte_kvargs_free(kvlist); + free(path); + free(mac_addr); + free(ifname); return ret; } From patchwork Mon Jan 24 00:05:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106307 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CA42A04A6; Mon, 24 Jan 2022 01:11:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CA04428A9; Mon, 24 Jan 2022 01:06:38 +0100 (CET) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id 7FD8042913 for ; Mon, 24 Jan 2022 01:06:33 +0100 (CET) Received: by mail-pg1-f169.google.com with SMTP id p125so13662598pga.2 for ; Sun, 23 Jan 2022 16:06:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GlREKbjXyKAwHax47U0uz3XIHjJfrZMl9DEn8u7nkFU=; b=3tNDHuNrfQRgtrp0C5cQv+RZYw/FGeR0PeDSwSDZ7xoVboIntbEH4KYy4aoGetvo0k Rt1L8WYgke5Z9Xun5RDxaFabgSlL/sdRKl2eCgUg7QQu4B8zkh04EuaskPJZEL4j097h c7V+ErxmhE2JR+m42dWKxEn+MxrMFrBz2Qmofe12YicfwIkJEk/Qw5FB67saltsVTAKC NVUHVI9UedyUyyZMlYs1mP79Y6ylP2GsjX/r3+Ra2yMZPSEA9rOnpj8+mYhTtObBk8VO hFhrqAEyYbZGeJewmoDyJKyJdzxF763j7caZx5avyx+X3iC5OogCrg0oOK0Ti0jmRI02 n2Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GlREKbjXyKAwHax47U0uz3XIHjJfrZMl9DEn8u7nkFU=; b=EH6AmDcGuIgIJg8JifXFNFP1IKJ1ruqlcgNSj8lKwRv05lkPAyn2dX2uqXsaMnFakF O/XKjd51Wyi9HDeW41OmE4GzEaka7TEmd3Kw5MdAGTPBak1gr5w5vwy8yPMODyH6h3mJ 7pCMr9VnIdh5WygQRWopWi8Sj2vsN3Ngd7DR9OWxK2p98EmvW9l5ew0TKSkiTI1+81T6 Pc8QdZS4f7/YMB4hvdEoyysc8pjJb5CVae7KCHETS3fFGnyDSR1M5h95oCS1lMeAnino +gLSA8uLmp8d6CY/wB6yLqnH9nTCK09GJNPME61aXQrzi2Rlq2mOeRw05dNInmJIJuhE +rQA== X-Gm-Message-State: AOAM531Fq1PqMIgYdQd6jUTcHiceWqiv11DEkSO4Q70JWCP7SLUyEzuR jg2AZWDnHeT6badfZgTu3BDZoNJWJ4RRnw== X-Google-Smtp-Source: ABdhPJy+fNRuNECptEY7PqHWt87DV/Lt3GBXi+v2pIFdSGAdEzi+rldn1hOOaYdpdIEPg8chxMYoSw== X-Received: by 2002:a65:68d7:: with SMTP id k23mr465105pgt.596.1642982792566; Sun, 23 Jan 2022 16:06:32 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:32 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jakub Palider , Tomasz Duszynski Subject: [PATCH 68/82] raw/cnxk_bphy: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:04 -0800 Message-Id: <20220124000518.319850-69-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c index 0b694e1c03c3..169cbc785531 100644 --- a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c +++ b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c @@ -233,8 +233,7 @@ cnxk_bphy_cgx_fini_queues(struct cnxk_bphy_cgx *cgx) unsigned int i; for (i = 0; i < cgx->num_queues; i++) { - if (cgx->queues[i].rsp) - rte_free(cgx->queues[i].rsp); + rte_free(cgx->queues[i].rsp); } cgx->num_queues = 0; From patchwork Mon Jan 24 00:05:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106308 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E907A04A6; Mon, 24 Jan 2022 01:11:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 072714292B; Mon, 24 Jan 2022 01:06:39 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 8BC2642917 for ; Mon, 24 Jan 2022 01:06:34 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id c3so13927123pls.5 for ; Sun, 23 Jan 2022 16:06:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3xQB82pDVCLStvS40zRK/t4hyC32t5+bJoM1P8wqznc=; b=hZb9KJfqzi1TcMrc4sCQyvi7xWxyHSRL6DkhEH8OiA3q54jG4Rw01xSGVVTlMf9Ob0 NRurHDGgEWAvGCrR7KAE+ZmtwA4EHbX3ZBMjYI/UDvoshsrcxzZqg06i/c6jp+D0CwJZ V5bBHTWNjMkiC02iPkjT5JOXuz4pZBKtFw1NnHuTmU70lKv9im/08L/HhDVOELB/jx9B l7ObGG22TGAxv8de+NqKKMq1jPQB42n03iY1G6DAPZfXV826I4/SgRzlXXKVSDBEM9J3 7CPU/6Y700f7fcBvV/P9r5H2zwqrFv/5uzKlqWkjlLrugXt/oYX0E04y9AqUgqYy3Wiq 17/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3xQB82pDVCLStvS40zRK/t4hyC32t5+bJoM1P8wqznc=; b=TbQqLGUkxWslR9jgkPB0O8q/U63z81m3mDMGysQDjLVWiL8SeaS7YQlGZdPzPmisJU lEudLczmASy5M63jhw6593JP1J964xh/Bqdr5sTgd/mFJSkTkxqDUf1PRobEfWUpPXaU 67I20d5uFwl6nloxsRh7228GmM0NJDEDmX9lALkXZa+9R0BLNWxnr+FMqAkIYgc+kW1Y KkevYilBWorEACfO154MtQDLUZ3VDJpm3aZ7vQUTH2m2UyTfrb0Blm947irws8fl6U/9 A6ZHJhILm4QtKwYhHRtp/AbgZEgxmfwtO/J/GQhWGsBbX0AHbIZN6RNfdFqxd+VhMy8N F+4A== X-Gm-Message-State: AOAM533Ilw39PD7D7tmTs+QVo8t9lYbwbTB0RaV8sefGmn/f18yprp/c b85gLAkIm/H8iw2r0asjok9s+Ph9FVUmVQ== X-Google-Smtp-Source: ABdhPJwgmO/o1F5rETb4KokD5VGTAANvNqAT5TVBFF2/hzJ7JnlLcM7xsCMIjSvxqpiLJENSq0fumg== X-Received: by 2002:a17:90b:702:: with SMTP id s2mr10679100pjz.117.1642982793562; Sun, 23 Jan 2022 16:06:33 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:33 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nipun Gupta Subject: [PATCH 69/82] raw/dpaa2_qdma: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:05 -0800 Message-Id: <20220124000518.319850-70-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c index ebc2cd5d0ddc..b2260439a4ef 100644 --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c @@ -1115,11 +1115,9 @@ dpaa2_qdma_reset(struct rte_rawdev *rawdev) /* Reset and free virtual queues */ for (i = 0; i < qdma_dev->max_vqs; i++) { - if (qdma_dev->vqs[i].status_ring) - rte_ring_free(qdma_dev->vqs[i].status_ring); + rte_ring_free(qdma_dev->vqs[i].status_ring); } - if (qdma_dev->vqs) - rte_free(qdma_dev->vqs); + rte_free(qdma_dev->vqs); qdma_dev->vqs = NULL; /* Reset per core info */ @@ -1314,8 +1312,7 @@ dpaa2_qdma_queue_setup(struct rte_rawdev *rawdev, if (qdma_dev->vqs[i].hw_queue == NULL) { DPAA2_QDMA_ERR("No H/W queue available for VQ"); - if (qdma_dev->vqs[i].status_ring) - rte_ring_free(qdma_dev->vqs[i].status_ring); + rte_ring_free(qdma_dev->vqs[i].status_ring); qdma_dev->vqs[i].status_ring = NULL; rte_spinlock_unlock(&qdma_dev->lock); return -ENODEV; @@ -1516,14 +1513,12 @@ dpaa2_qdma_queue_release(struct rte_rawdev *rawdev, if (qdma_vq->exclusive_hw_queue) free_hw_queue(qdma_vq->hw_queue); else { - if (qdma_vq->status_ring) - rte_ring_free(qdma_vq->status_ring); + rte_ring_free(qdma_vq->status_ring); put_hw_queue(qdma_vq->hw_queue); } - if (qdma_vq->fle_pool) - rte_mempool_free(qdma_vq->fle_pool); + rte_mempool_free(qdma_vq->fle_pool); memset(qdma_vq, 0, sizeof(struct qdma_virt_queue)); From patchwork Mon Jan 24 00:05:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106309 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CCBAA04A6; Mon, 24 Jan 2022 01:11:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EFF9E4292F; Mon, 24 Jan 2022 01:06:39 +0100 (CET) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id 8B7564291C for ; Mon, 24 Jan 2022 01:06:35 +0100 (CET) Received: by mail-pf1-f174.google.com with SMTP id n32so5133012pfv.11 for ; Sun, 23 Jan 2022 16:06:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PVNto2xv4wjyh/dpNuE2+eGz0mBChs+YqMwWd+Xh0h4=; b=zVSHYZW62mwLsKvkosj8mQmTwpqrwFQjxLpfftJYAqYl6+RLBcYqiWSwVtPRhJLMo5 tJJaHF8K3LfzztqORrYC8YxAMCgUWAfehWgzS202UM8LwRpSgRmMYRuLnDCJ8Id3ex1s lAiEqXhOegMSavkbwc1GLFimtGHC/awajJ865rOki0vSGJRjAr6B2ePdSt5Cmq2OdmzA tmTh01rYuhlDNJNv3UY1VHD40HOATgtOADBe2Z+Er87OCfCh/JiH71fdT12FITAAfJXa 2GfxaJxCaxfzqHqC5F1i4FR1svKn1+IwfwtP23kgmFH7k3ZVWahXIdSu81nGlB0V6Ei5 S3xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PVNto2xv4wjyh/dpNuE2+eGz0mBChs+YqMwWd+Xh0h4=; b=VtTrQmgAAVL22NOqLSmlmgeFde5Ve4wnrVXSS0sM5SU4KVklc98lla/wBTtl7dBR/w BAZVg4hBaJOa59kND5zaJchxOx3kHo2maV51c+5wBSw8+/67FrfU8KsV7D+ITJ/ASJ3D ihbQ+3dnnmkBQtCLp7R+BDqhPwOKTZvnKiGOd9TQ2Gur6VMVrVrLC1H6wJhYTWo8SgF6 Ci4Gwt4JEBFKjn9U+DCDl/iuYJCEtBf6DQ3wq42xSy5oqn81yaiejBActd8r45sqT2rx r5/aSkMeuoA3AReXLfHC2nY5fWYY+ajwBPZnF6w+LI/mMY7MbkMV02E7mtNgSYC3yfXx lRhA== X-Gm-Message-State: AOAM533jrUxZFiNnLFz/P+Zs5o1qRL9seeZ7c4Apz2wp7SWk1F7SW7FD ZD7jR5AM0qdrn113+aZkymb5OGmjoB1vzQ== X-Google-Smtp-Source: ABdhPJysJy6uq9DuVlAaRblGejhug+T2HcfEAOJcACNpvlAvpyQSIpB++ncs9GmYyaAUbVkAe9k3Zw== X-Received: by 2002:a63:8748:: with SMTP id i69mr10367883pge.422.1642982794596; Sun, 23 Jan 2022 16:06:34 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:34 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rosen Xu , Tianfei zhang Subject: [PATCH 70/82] raw/ifpga: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:06 -0800 Message-Id: <20220124000518.319850-71-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/raw/ifpga/ifpga_rawdev.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c index 0eae0c9477b6..c68e378dc3ce 100644 --- a/drivers/raw/ifpga/ifpga_rawdev.c +++ b/drivers/raw/ifpga/ifpga_rawdev.c @@ -836,8 +836,7 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int port_id, } free_buffer: - if (buf_to_free) - rte_free(buf_to_free); + rte_free(buf_to_free); close_fd: close(file_fd); file_fd = 0; @@ -1739,10 +1738,8 @@ ifpga_cfg_probe(struct rte_vdev_device *dev) ret = rte_eal_hotplug_add(RTE_STR(IFPGA_BUS_NAME), dev_name, devargs->args); end: - if (kvlist) - rte_kvargs_free(kvlist); - if (name) - free(name); + rte_kvargs_free(kvlist); + free(name); return ret; } From patchwork Mon Jan 24 00:05:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106310 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 776E7A04A6; Mon, 24 Jan 2022 01:11:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BAF34293B; Mon, 24 Jan 2022 01:06:41 +0100 (CET) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mails.dpdk.org (Postfix) with ESMTP id 923BB427DF for ; Mon, 24 Jan 2022 01:06:36 +0100 (CET) Received: by mail-pg1-f177.google.com with SMTP id e9so13661066pgb.3 for ; Sun, 23 Jan 2022 16:06:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mF1O2ovl9ENpq45EkliXSoAk6DMa6GvfSkvDRawMqIM=; b=LrZPp5/MG/kK0CtEh05ZQvHUyCK/VT0emhvVgKeiRiXRJDOdJO+38lCgEJUtHqpMF1 g0SRMbInZYMmdpp+VTX4q9PBBbZHElZn1yq2ICr5xN0nJxiuC3s85F4iuJ1R10UDnUQo TIU7eRyz53jIdJ5Q2TYQJ3ZGL6tGvBVfXuhgqN6dcsVG/M8h2vHSSkkDpCalUrUYwe+g nF4G0anrqmzXKlintSdT6UeNvTLoztPBqnDTnsl0beiLEhYnxWixaguZj37iupWyeg5e PIvIJTQ+XCn2+vCVUNvwyTZ6MyW9Ssaes5fn07xWarYmq2u81xBeqB8MmMOrhD5PPUat bkxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mF1O2ovl9ENpq45EkliXSoAk6DMa6GvfSkvDRawMqIM=; b=48pkOEOl7bwgUhcB3IJ4oNDIM4KQh3nJr1H7qEhAGYgRFIPK2tuS7FYQYcqhr4FoKi rcwhX8e2jxwa+X57msz+sfnotIBbby0twvIyYeEmiCvu257JNsJN6PYp2KLf+fQ7Hpym eQwYAHauq75de2ARzk4I+XeFVMbtvhopjeBQIPnwTxQkoHYVgy9QWKb4LgyJ0UpzL4Gy fkjTCI2B5rWuQKUa6Xv19cdc/bCgeULYJaT2sekgmmmIpKLqr/cnrYgYJSX0wI4nuRYR E3538Mina6jhn0NbFxDR5YB/+x2obHNYtqlJFZQb/gTTX70m5Rrk5s+kPgm19PAPv1WC ALpw== X-Gm-Message-State: AOAM531+bFUIA89cztzUWwmWWwvi8eSIhiaiFF54glCMgjEEq0j3nyXL SSZXi2ewHIviwGBSntrBoiVKMKJGDViIZw== X-Google-Smtp-Source: ABdhPJzVy8oLr7KrL6fV/CSnSehASWHOL4vFsjazkQtyZnqg2JpHwUWGvbDg0Ddqj9IKhCbylirYFg== X-Received: by 2002:a63:646:: with SMTP id 67mr10132415pgg.122.1642982795578; Sun, 23 Jan 2022 16:06:35 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:35 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nipun Gupta , Hemant Agrawal Subject: [PATCH 71/82] raw/skeleton: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:07 -0800 Message-Id: <20220124000518.319850-72-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/raw/skeleton/skeleton_rawdev_test.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/raw/skeleton/skeleton_rawdev_test.c b/drivers/raw/skeleton/skeleton_rawdev_test.c index 484468eeb460..693b24c415de 100644 --- a/drivers/raw/skeleton/skeleton_rawdev_test.c +++ b/drivers/raw/skeleton/skeleton_rawdev_test.c @@ -395,13 +395,11 @@ test_rawdev_enqdeq(void) RTE_TEST_ASSERT_EQUAL((unsigned int)ret, count, "Unable to dequeue buffers"); - if (deq_buffers) - free(deq_buffers); + free(deq_buffers); return TEST_SUCCESS; cleanup: - if (buffers[0].buf_addr) - free(buffers[0].buf_addr); + free(buffers[0].buf_addr); return TEST_FAILED; } From patchwork Mon Jan 24 00:05:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106311 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35FF4A04A6; Mon, 24 Jan 2022 01:11:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 287724293F; Mon, 24 Jan 2022 01:06:42 +0100 (CET) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id 8FBF842876 for ; Mon, 24 Jan 2022 01:06:37 +0100 (CET) Received: by mail-pf1-f180.google.com with SMTP id y27so10095771pfa.0 for ; Sun, 23 Jan 2022 16:06:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/N7Veby+xkF8KLtKEHfcbxhJiNWlFaaT38sXLrh3ndg=; b=PigCbOfQ5Rxa2IJFE55TZe1saenQ+4iXQ8zr7779P+TGM4OVrLnzfnWlrvEuI+DfFc Zg85Xx3x4qGfHFSdRneLRXVKj0eB3XpHtF6AiEgvroF071FYcoD+P9l1AIRRwfNnXa02 GFNE5tvWyfbhg8UfUJgTBV8ZQPeXVwpYn5gs2/StLkPSF7K9ZlpA6Fkg2QeMaKLDosRj id09e2VNfqGQc3j8J4uZex9e+L/RWYVGTCfUZ/xND4SrQ8DnJSUA9p/vXBEqE00kk7DJ wlmjk8vilkMUoUCawK6zKMK4bIwzqlcK5NeA9gfgcf/kdQVirCQr3UQPIkkiBb3x1PDT FpqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/N7Veby+xkF8KLtKEHfcbxhJiNWlFaaT38sXLrh3ndg=; b=hN021xRSbVBzGPidrFqK+AgEmSKqiVW23b7GeNJxAM8aviv0E7sYI7vSKGj8Z+uWqc TiVDEkCSw1WWlwycbOz+ZS/qiDKWjMXoHsRb+XBy4htLBjZIsuv7xsDchhJ62V7yKCi6 VKjO1DPzbIyHZo/qYJhIGlO4q7GDN6vgiISqUH+G2OnYVVk3MxNDGtJEK15JXc5KExsw WDTsLEDu9rytRWbfk1iEkafMRC6G6P/3/RbMY3S8nl6c9AgJw5RhjbrfGXj6A3aGmjIE +WT/j3/1xeYR8R4waKa5FnH57lHLaqfceH8D15hKG16K9TzOT5jZ/fxysr/VRA9fUKyI paOg== X-Gm-Message-State: AOAM533yZROB+rlAQs8HnIWI0nCUx0xX/9uxsv6NfEH8OiPQeKXmTvjH c9rYPpWY9LNyUgOCl6XfoQAUTBZ1afsozA== X-Google-Smtp-Source: ABdhPJzr4L7AToWzN5Yrq6dUaBYvmIRiuOIO5L10pBjORSiPsu+xmFauUpMGggi/qsPH0JXFnluKgw== X-Received: by 2002:a63:1562:: with SMTP id 34mr9925393pgv.15.1642982796599; Sun, 23 Jan 2022 16:06:36 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:36 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Liron Himi Subject: [PATCH 72/82] regex/cn9k: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:08 -0800 Message-Id: <20220124000518.319850-73-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Liron Himi Signed-off-by: Stephen Hemminger --- drivers/regex/cn9k/cn9k_regexdev.c | 6 ++---- drivers/regex/cn9k/cn9k_regexdev_compiler.c | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/regex/cn9k/cn9k_regexdev.c b/drivers/regex/cn9k/cn9k_regexdev.c index 32d20c1be82b..56c862c5a76c 100644 --- a/drivers/regex/cn9k/cn9k_regexdev.c +++ b/drivers/regex/cn9k/cn9k_regexdev.c @@ -256,10 +256,8 @@ ree_dev_fini(struct rte_regexdev *dev) cn9k_err("Could not detach queues"); /* TEMP : should be in lib */ - if (data->queue_pairs) - rte_free(data->queue_pairs); - if (data->rules) - rte_free(data->rules); + rte_free(data->queue_pairs); + rte_free(data->rules); roc_ree_dev_fini(vf); diff --git a/drivers/regex/cn9k/cn9k_regexdev_compiler.c b/drivers/regex/cn9k/cn9k_regexdev_compiler.c index 935b8a53b459..60f1c1b4c4d8 100644 --- a/drivers/regex/cn9k/cn9k_regexdev_compiler.c +++ b/drivers/regex/cn9k/cn9k_regexdev_compiler.c @@ -214,8 +214,7 @@ cn9k_ree_rule_db_compile_prog(struct rte_regexdev *dev) rxp_free_structs(NULL, NULL, NULL, NULL, NULL, &rof, NULL, &rofi, NULL, 1); - if (rule_db) - rte_free(rule_db); + rte_free(rule_db); return ret; } From patchwork Mon Jan 24 00:05:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106312 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30862A04A6; Mon, 24 Jan 2022 01:11:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1358A42942; Mon, 24 Jan 2022 01:06:43 +0100 (CET) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id A3A4D42929 for ; Mon, 24 Jan 2022 01:06:38 +0100 (CET) Received: by mail-pf1-f172.google.com with SMTP id a8so8884681pfa.6 for ; Sun, 23 Jan 2022 16:06:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FoY92Tvbw9/KTzBEb5Yi+2WvocRLnZaw6NxOxkmY39I=; b=bf/0DFpx8QeYdoHIewUo8kVFk8V+0RfgAysbEAot7eGrurYp1ePZXK35/PD1hEWJI1 4xBCfOPmzQ3c1syoFOi1nfvBURI0t3tzsIUjZ7AVei6Tw+ADcNjA1/K2MA9eySo68Im4 CN/sWiaXAc9eAcVnxCCsR95RVRGXeyNvlpCNxA0A594661X0yWEooPTxIBDKPTeXvBWd EcGxk4klF0UMrBHpFKZcmK5+hB2mgxTOQOF1ULuareseNQwoAsUJucwqTZWEH1/JnAjP 607QmyYdylNQW7utTNYVFqSEGrRv9rhGojHx7FlDH/eGcA6DI+4mxo6QmcgiHkNKhXtX wyOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FoY92Tvbw9/KTzBEb5Yi+2WvocRLnZaw6NxOxkmY39I=; b=SMtWVP2lb0iepkvDKd+mZ96LxxA6JMDXDbZXSFBRpq/vlyBhq1WAsy9TZWi/j9R0ei o6XibWhFS24+PvrBDrHgZGWe3p9djPtMYUe4egmGnR6vFOan+wPUS0ELDk8fzJRvWqXy DS2Dv8TDqEV1vJQ4CJwq0v0k+ZGqRxU7Aiep68hQF+a9tknQl+XlwuOGYLjisGGMz+4m /gM4yBcTzLG6CF3aZFLD8SdlBUa53XPJeVHLGx7kXOXr+oy28EqR7s8s2sbYFg/bfBZ+ 1pVjDA2Z6xhX/trjXmhb0o7w4nkiSNB6XCtBHmRQLd+eP8Yxrqv1r1nl+CKoI/B3vX/h 1EhA== X-Gm-Message-State: AOAM530KmhVSMJ7Z9gXYOM/RueZlZpc7vKx6yy/2rKfClStfKHX7nCIw FFagKefrPppRDDorTSb3DsdhIjzA5wuzqQ== X-Google-Smtp-Source: ABdhPJyVBAVVlxRRdqUzGzh1QJv84p3exkxqExnVxTJqthMLvDbUphs/uRJgbcM6Jqygxkf65y/Z4w== X-Received: by 2002:a63:c009:: with SMTP id h9mr10015006pgg.36.1642982797609; Sun, 23 Jan 2022 16:06:37 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:37 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ori Kam Subject: [PATCH 73/82] regex/mlx5: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:09 -0800 Message-Id: <20220124000518.319850-74-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/regex/mlx5/mlx5_regex.c | 3 +-- drivers/regex/mlx5/mlx5_rxp.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c index e5a12fb3cc4d..48e39f6b8844 100644 --- a/drivers/regex/mlx5/mlx5_regex.c +++ b/drivers/regex/mlx5/mlx5_regex.c @@ -127,8 +127,7 @@ mlx5_regex_dev_probe(struct mlx5_common_device *cdev) if (priv->regexdev) rte_regexdev_unregister(priv->regexdev); dev_error: - if (priv) - rte_free(priv); + rte_free(priv); return -rte_errno; } diff --git a/drivers/regex/mlx5/mlx5_rxp.c b/drivers/regex/mlx5/mlx5_rxp.c index 5ead3ca341ad..99db1e4a865c 100644 --- a/drivers/regex/mlx5/mlx5_rxp.c +++ b/drivers/regex/mlx5/mlx5_rxp.c @@ -166,7 +166,6 @@ mlx5_regex_configure(struct rte_regexdev *dev, DRV_LOG(DEBUG, "Regex config without rules programming!"); return 0; configure_error: - if (priv->qps) - rte_free(priv->qps); + rte_free(priv->qps); return -rte_errno; } From patchwork Mon Jan 24 00:05:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106313 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8823CA04A6; Mon, 24 Jan 2022 01:11:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04F51428CA; Mon, 24 Jan 2022 01:06:44 +0100 (CET) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id B87544292E for ; Mon, 24 Jan 2022 01:06:39 +0100 (CET) Received: by mail-pj1-f44.google.com with SMTP id o64so14665731pjo.2 for ; Sun, 23 Jan 2022 16:06:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5EQ9EclMKZF7bm0DCKVP8jt8Ph49KzbE4XPBP6y6DqU=; b=M7PmrkHnDgSAM2Qw3T75xRxeGp8uZJbs42qhM3TrszNQU3q1reWAFqi8KiiE/jHwh9 Tfba7X2rcx6fXheKuPZfrj98r1y0855pfAsFc+vxCP3dBXh/aUzL57JI8H5NLWfdossf P3pAiW0y0mFj4zLOwyt880d+dmSkvCErDyUp07Il1EVXG2GbmqSklAa0NNvjF3eNeZgt kwj7M0EqxiBXmHnU7GsI1/1vGnbZPMWmKEQagpPEmRXrXSHV2CcsQajnqEPVC7sla1Tp m6pz61TEYrV6K6wHKFGW+I6Og3Hc9qtCc4Z4TR3A58bHOxsUgWm2HVf8NCH3vX2T6aFH CUTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5EQ9EclMKZF7bm0DCKVP8jt8Ph49KzbE4XPBP6y6DqU=; b=UHBWMmT0IEWicYUOn9+F2nxj9QtiIYGpEWkuYb9jo/FmtAJBByUElC8ggAXVc2+3fm Es6VjhDWV5GBsM3m8FxE78Df6eYhndEbTqfWoKNy/Vd0wOe+B5gzBWkGOj23TWGKZUCe 2asKoGV7np4dsMGMbK567NKbj8UslbzmEpI1f/spI2RKuXFNNlGAkRdD7ykjDl+9t/F/ ErpuEZGaOHy4VOTenufyaaskz1vTCu8lcYdhYAOTpyMfmYvvhaH4oTyFZ+xE9pXP+YeW bN7fJqlqAsClp9qE5zLuhlP4nufuF/h/RDZx44XF+ren7N9LDZ0eOkVNMPDJRbhT6Qbb CF1g== X-Gm-Message-State: AOAM531eMMiXxwdLwW7OgcXcNnYjfe8PLPjHW03kv+EW4HzchlZ0zqwo UFsr1ngvn4FzstwitM27Wvl99YmWkJEeHA== X-Google-Smtp-Source: ABdhPJwbg5HvLgBmV1uk2sE8EiiHemXpHyblwvwu+6unsEOYGbtQ2I4GzWrrxsXxOUId0Few+0vblQ== X-Received: by 2002:a17:902:8649:b0:149:f37a:9255 with SMTP id y9-20020a170902864900b00149f37a9255mr12513493plt.116.1642982798672; Sun, 23 Jan 2022 16:06:38 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:38 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Xiao Wang Subject: [PATCH 74/82] vdpa/ifc: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:10 -0800 Message-Id: <20220124000518.319850-75-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/vdpa/ifc/ifcvf_vdpa.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c index 3853c4cf7e85..9f05595b6b34 100644 --- a/drivers/vdpa/ifc/ifcvf_vdpa.c +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c @@ -226,8 +226,7 @@ ifcvf_dma_map(struct ifcvf_internal *internal, bool do_map) } exit: - if (mem) - free(mem); + free(mem); return ret; } @@ -253,8 +252,7 @@ hva_to_gpa(int vid, uint64_t hva) } exit: - if (mem) - free(mem); + free(mem); return gpa; } @@ -661,8 +659,7 @@ m_ifcvf_start(struct ifcvf_internal *internal) error: for (i = 0; i < nr_vring; i++) - if (internal->m_vring[i].desc) - rte_free(internal->m_vring[i].desc); + rte_free(internal->m_vring[i].desc); return -1; } From patchwork Mon Jan 24 00:05:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106314 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44CBBA04A6; Mon, 24 Jan 2022 01:11:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E97F24294C; Mon, 24 Jan 2022 01:06:44 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id D29704289F for ; Mon, 24 Jan 2022 01:06:40 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id u10so9694917pfg.10 for ; Sun, 23 Jan 2022 16:06:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GRDAuxuSBVGu0f5cksd8Yr7OU7H6KcL7WM0YksWYbK0=; b=6uzNHq9fVRQ0e3duWn711jKJV14QHyZmjgKL2zvQlh6pyOtl/W5Q7XLPDxhYK0F//1 UaU3RItJLkEWNdJKcMG1l7Jgva2IH7e86v6zuJR8YJ3iINkt3VQjsLMoWXtQQJMz6cXC Dj+lC74/kp8bgdta8kuSd2odz3oi9Vr8tdfOajr/JP+fg7KAwIbFMIKhzuJfkrEuHzjK nGCDJ6dyxv9+OtObW56HXDBAA7SzXSXq5SHxta2XZ6dtwWJIrgjC0Jy/bbiG2p9zOHlm BGYoYAVWLBKa0KwIsam4DsrbMAxHL93CjTOvxNq5Z4WeSYOQlS30ZbzCn3pwC2jgOZAU eUVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GRDAuxuSBVGu0f5cksd8Yr7OU7H6KcL7WM0YksWYbK0=; b=IUhLzqclug/KNT5kVt6Sroejc+XqklcT5rPsp2MN9VAcg1ulXqaXx7fU+JzLFN0uGs JqrLHgOlwEDnbxKBgdAopECP/1GHq3XvWc798CX1ZZ576xH7LMfHCanSVP/eVocifP/Z NS3Sa7jIgkgtBhSPAg8h7a2Bcu8z8UlQ+sS87i2emjTgX5Tcy4DXf0qQ9Gtl8R3O4DDD wLyX/wDiaUauLnEkOym1ab4jQ5srUmaHdMyNeuElL1pWaAGajWjp+6YfBKJ6XMQOcvAV g6j3lCG3yFLSE8KMnX/uBz5iOa8nl5dXvS+ijFwZNdfiOjV8B4bshd85OjnMox7EBsHd OpqA== X-Gm-Message-State: AOAM531mDm00/LtvMVrWiKfmRAeZ+8F2x+OXBE/m6XhHp4T/J0VzQ5bV Touwj4v5e3BtAoRhPzIw6IrobjgmPJq8/Q== X-Google-Smtp-Source: ABdhPJyLB0y5FuPFihDDGCROwJPa4o73BKFexsaSBI82O8SHo3uoKOYWjr7uijDuS8D8q0nIfFTqBQ== X-Received: by 2002:aa7:928e:0:b0:4ba:fa67:d87 with SMTP id j14-20020aa7928e000000b004bafa670d87mr11826208pfa.41.1642982799799; Sun, 23 Jan 2022 16:06:39 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:39 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH 75/82] vdpa/mlx5: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:11 -0800 Message-Id: <20220124000518.319850-76-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/vdpa/mlx5/mlx5_vdpa_mem.c | 3 +-- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_mem.c b/drivers/vdpa/mlx5/mlx5_vdpa_mem.c index 130d201a85f5..599079500b03 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa_mem.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa_mem.c @@ -283,8 +283,7 @@ mlx5_vdpa_mem_register(struct mlx5_vdpa_priv *priv) priv->gpa_mkey_index = entry->mkey->id; return 0; error: - if (entry) - rte_free(entry); + rte_free(entry); mlx5_vdpa_mem_dereg(priv); rte_errno = -ret; return ret; diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c index 2f32aef67fbc..3416797d289c 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c @@ -91,8 +91,7 @@ mlx5_vdpa_virtq_unset(struct mlx5_vdpa_virtq *virtq) if (virtq->umems[i].obj) claim_zero(mlx5_glue->devx_umem_dereg (virtq->umems[i].obj)); - if (virtq->umems[i].buf) - rte_free(virtq->umems[i].buf); + rte_free(virtq->umems[i].buf); } memset(&virtq->umems, 0, sizeof(virtq->umems)); if (virtq->eqp.fw_qp) From patchwork Mon Jan 24 00:05:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106315 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DE2DA04A6; Mon, 24 Jan 2022 01:12:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D69CB42950; Mon, 24 Jan 2022 01:06:45 +0100 (CET) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id D9DD6428EA for ; Mon, 24 Jan 2022 01:06:41 +0100 (CET) Received: by mail-pj1-f50.google.com with SMTP id s2-20020a17090ad48200b001b501977b23so14074616pju.2 for ; Sun, 23 Jan 2022 16:06:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1DAoQzlpVAiLi7M5ZMRpDmNBblIj0lzrgX6o7y42vtw=; b=aV0mnIszHl1E9GeHjB1uuwUUMAJKjaech/u1UsgQ8qzYVgiA2Zgtk9QGVIJ+F6HH6R XXBJRNUUju+a1anoL7mFO43x7m/SJsPs4QsFpe2VslXk9w8qd+I3spZI5YNPJ2O57l6s jIjmO2NbFyvBVb/Z7II5Ur83M40I/3HawRALKuPmK+ubs5yH0P/W/zkIzCDgv3V9jetZ P92595za30GL3jL006dJdmDhTah1UYesZ/IduoZuwIJK5OVBQTkJulJCeTAnOYILupyg uJzswHMBE3iLblF7DlxT8qkJxucE48LxpDPsMiH8zGxZ/MntbbngKevpyJ2aWCYQDNBP qd1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1DAoQzlpVAiLi7M5ZMRpDmNBblIj0lzrgX6o7y42vtw=; b=H3HSTFUiGx9H414hZfPXYPHbYGecmUaQKJ60JywLqBEqRK3AT4iPz5YJg9UEo6YWsO w22+836wg2CH7a92KarVQyRo/Njz7htGgUsE7JgJNs2Rmc6+4hfWv6QDLByyzZiEYFht xDfgUnItBvZfua9P1yjQnVT3E803hZL/O/N/gPlfWJ+X6lbLBOJLEOJR1ppXOOBWUDPA KkaDWeafOAAH1oFgH1K7mpjfoCV3XuzOtRNnCFW45vfvzaj5MWqATmRSfG1r2aXmGnzC Rzz5cYvqWs+rOCdqcAu5u7bi1toyypTMwDV8hnX7dgPHmimso6NPBojpE6XB+4VE0bL1 5ezQ== X-Gm-Message-State: AOAM532QU7i7zCHzcafMhaMB5QpD7ZMamb8+HdR7LAnm9deCnVv/CKR3 jWgjd0zrFvCeRcM4hX9fRi8GoCN3nBGdRA== X-Google-Smtp-Source: ABdhPJyC9xm9wZ8KaZTsl8VlzYL6hshVYcTV9OiUVsyrkwp5MqJ5qg5XvVt0i09AbNJN1BrS/U9MiA== X-Received: by 2002:a17:903:124b:b0:149:b7bf:a2ad with SMTP id u11-20020a170903124b00b00149b7bfa2admr12769584plh.53.1642982800856; Sun, 23 Jan 2022 16:06:40 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:40 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Fan Zhang , Ashish Gupta Subject: [PATCH 76/82] compressdev: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:12 -0800 Message-Id: <20220124000518.319850-77-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/compressdev/rte_compressdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/compressdev/rte_compressdev.c b/lib/compressdev/rte_compressdev.c index 2e9218af68f6..d4f7d4d3daf2 100644 --- a/lib/compressdev/rte_compressdev.c +++ b/lib/compressdev/rte_compressdev.c @@ -405,8 +405,7 @@ rte_compressdev_queue_pairs_release(struct rte_compressdev *dev) return ret; } - if (dev->data->queue_pairs != NULL) - rte_free(dev->data->queue_pairs); + rte_free(dev->data->queue_pairs); dev->data->queue_pairs = NULL; dev->data->nb_queue_pairs = 0; From patchwork Mon Jan 24 00:05:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106316 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42AE5A04A6; Mon, 24 Jan 2022 01:12:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B96BE42956; Mon, 24 Jan 2022 01:06:46 +0100 (CET) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id E33EF42942 for ; Mon, 24 Jan 2022 01:06:42 +0100 (CET) Received: by mail-pf1-f176.google.com with SMTP id u10so9694981pfg.10 for ; Sun, 23 Jan 2022 16:06:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KiInXPZrusCXymjxT5rHhqr72dWr3KdKDt0AAlYKOgg=; b=GyIyRr2ulBCflb0xZF3reEG9g0Zi8UQOhWshFdnV4OtXnJW4980VZnM/zl7dgQNZe1 Wt8Ku59j3gfZLX8fra2Zx4gQ5V26rufQnrqGFifOpUOyxj+nvURZUUTVNXWyqNILI9cN rn9BbgZ50A8FZiVd2hI/mAzoVeQGEJTBUMHoYpllcHRC4TKKd9J4hMNpc9YrMV6wbO6B RC7SvfYkUJyWhJb2SB2HAc42nz3kkQZo3+/I+rsQqS09XVam6HAWYsnwkrsQr1cibt1+ D+f3tEgUeLBp2tfXBdPw+UTRahaYz596wB5A95r0w+8FAv+arGtkOejrgPruajJsAGJN DbbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KiInXPZrusCXymjxT5rHhqr72dWr3KdKDt0AAlYKOgg=; b=WijOU5ewlrGIAInrMZWbHuM/VE/rUXteshbJ1u766pC02s0WPBErI5hiONo4UOrEm8 8LqW3BQROyITi5mIbhh1itUcFEiZU7tuVl3ACiNfP1pq/rjDRbM0B8D9hefEgsqiOYcv azSaMDf4oQxRPn8JN8avHnAECcb6K1Z+ClnpkWHuu4BIk+oDUpjttF13sQU5IMQuw11v 2QTZyu56ZmmhHDxQUr3iPhBuaDm2c8UdJe6Qh0ya/izO0kO5tN3RcaYHQkj8SfMyDTEE bHOxIxpn3ho9X7jF4AXhZOPOphwYd8NYs6/5QiCXU3/tD1WXvF5evL8336nazVzb/Zg2 bnrw== X-Gm-Message-State: AOAM533xeO94i4QryxSBgoB1oYPaRtJsbbZhV0/odu150B9KpG5rn4LF RK6NMT9SxVe9xOzSp7yRdHt7kzxO2rUofQ== X-Google-Smtp-Source: ABdhPJwXiahiXQrrfo1Xi50zfh3QiZ3dOrFfy1174VT6rmq3PwlB1fHl03aI4U8ssq0hX+YhiBEcOw== X-Received: by 2002:aa7:914a:0:b0:4c6:c181:5251 with SMTP id 10-20020aa7914a000000b004c6c1815251mr12140812pfi.41.1642982801941; Sun, 23 Jan 2022 16:06:41 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:41 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko Subject: [PATCH 77/82] ethdev: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:13 -0800 Message-Id: <20220124000518.319850-78-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/ethdev/rte_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index a1d475a29295..98312fa157f6 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -6036,8 +6036,7 @@ rte_eth_devargs_parse(const char *dargs, struct rte_eth_devargs *eth_da) } parse_cleanup: - if (args.str) - free(args.str); + free(args.str); return result; } From patchwork Mon Jan 24 00:05:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106317 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECB0BA04A6; Mon, 24 Jan 2022 01:12:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 068F34295F; Mon, 24 Jan 2022 01:06:48 +0100 (CET) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mails.dpdk.org (Postfix) with ESMTP id E658142948 for ; Mon, 24 Jan 2022 01:06:43 +0100 (CET) Received: by mail-pg1-f174.google.com with SMTP id v3so8362334pgc.1 for ; Sun, 23 Jan 2022 16:06:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SNwpG3frGNXXYttKmqH6tfoJ/7BWDNsqwVHnDJXpTaM=; b=XXRDBnKteLRr9io8+9fACZqBCMemboEaIzHJTY2s8ITU6M00qcTKh/PG4p6otbf7Br bqtVrDhBMUaUJcV+XVlArMDYoYQJsgro+V+f/yWHGCfezlJZTUENY8mqs15kpMWCyJ9a lqxhDsPdclDAN8bdMJ8X1e5tb88pgsx5VrdkkWwLTmdN731BWAiWNxCttsHFeq4xGpdZ ECS8ix0wEWRo8jSf6gXMf9KRbj+oR9TqnNN22PaHOWjrMfrMDvA3FbtUcKT4UpeaQMrJ BRNGBUUyelj6zf1QXxkCDTgVJSYOnIu3QQHQIZTMLqmr9jwu7FBMdSB2q2WVHl5Wbl1d OJhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SNwpG3frGNXXYttKmqH6tfoJ/7BWDNsqwVHnDJXpTaM=; b=VMM16+bokh9k9TVw76yCGTwG3i2sHVqLTl/dyLimryaYE3sEYPKmdgD8/i4OKNMvG2 BaaB7oePwG4GFXRCNWRT8GCxxkglksgCwjk4bremzyl6UovPu9kM12Grz0LacVBpduLC XUMy0pGdmf2M3Rg8qzUdSkgry/Ml9/1HffCgLblRfBAz3nDvJbd2W03F+jLZxkGQ9jGa HcbYBMcq5X2VaLZVNk7/WUJABqI0DNsMEtQkR9XzC5IBpuOjmNOF5m1S79Wj67x/dup8 XYLC7Wuymd0o+4XhnDutFMQVGo9jjO58F7t0iTZ7JqMuFsZd+XjPhwKMPwkFUfB8+FLR ELqg== X-Gm-Message-State: AOAM5315pWWT26wqMRhQ46Z2W3q74wlJai/+b1ZvkAyauH1ag8Scopi4 suF/U0c6MtdgORBajYJgpkWqUdTppEIXQg== X-Google-Smtp-Source: ABdhPJyoc7X65z7Nsw59odavMxNipYPkBi0tkG9lEopSi4i/61jimit8MobpbknjMmTFV5JsWb2R4g== X-Received: by 2002:a63:7906:: with SMTP id u6mr9920705pgc.28.1642982802932; Sun, 23 Jan 2022 16:06:42 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:42 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram Subject: [PATCH 78/82] graph: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:14 -0800 Message-Id: <20220124000518.319850-79-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/graph/graph_stats.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c index aa70929dc32e..65e12d46a313 100644 --- a/lib/graph/graph_stats.c +++ b/lib/graph/graph_stats.c @@ -233,8 +233,7 @@ cluster_add(struct cluster *cluster, struct graph *graph) static void cluster_fini(struct cluster *cluster) { - if (cluster->graphs) - free(cluster->graphs); + free(cluster->graphs); } static int From patchwork Mon Jan 24 00:05:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106318 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B66C0A04A6; Mon, 24 Jan 2022 01:12:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0F2B42964; Mon, 24 Jan 2022 01:06:48 +0100 (CET) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id E60744294B for ; Mon, 24 Jan 2022 01:06:44 +0100 (CET) Received: by mail-pj1-f52.google.com with SMTP id my12-20020a17090b4c8c00b001b528ba1cd7so9831702pjb.1 for ; Sun, 23 Jan 2022 16:06:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ACG2GULbo70icFSXGiZ3Z6qsdoKq1S0d5ObGSsVkXTs=; b=7CgSMYhxsW3lUlXcI7xwfe932xda5uEDr7VeljSXWbcUPqG3Tq4Yia3e4rotxdrKgq yfH2x7PkuBlt+8gdFX0q2f4vNC5xOPP3HWMbs0iS5TAmuTcIdVex7/t/qFlesguYe2yW g4Fv+auF11q/PNSdEXt5PZrQjryTJvies+M46Pz42Z8dRlZRUW81xtXbxx3fWx/NQJCH cHSQmG2Mg/3KKm0PTzzYMmxSJnjjP50KRbfqeda9W2AbaPl9JYm4A2tK9sf4Pp9tOeVF 2xNXvJgYy4nFQZZsiaZg7Br29FBlc1o+MTldkC+C2OOGjCEKdRRiMHHmlpv0fngiGfGF 8PTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ACG2GULbo70icFSXGiZ3Z6qsdoKq1S0d5ObGSsVkXTs=; b=PyHDz+rIghbMFRadoXX/PZ5bWX0ulbDyTxr7ugiCRT3CK1ysHNWr0oycgHNgYSlr6o pOEYPyom36A7Ak7dMBGAKRIfNksdoitIHC8pkvXX2JQlZFHJXsGJ2XqCnHMjKJVylskR g4wPvMmsFIRdeP+Njx+ow/WkZpfHt6LKGIsH8blPmWnczS2LGE3EH3ROuT282KR2J0Fz W70xmRQglcACxWFOh/bAXsr82scSX2NlMiQUoZErPEDMiCoSvVLvqjt0GDLPlPmig8Y9 ENlPnVgTLzkugPqWfoj4kNUbvo7nYIQFSd8nrc1COaTZSFHJaJlkIDwhew9tBocNbWkV IFIw== X-Gm-Message-State: AOAM5339WGuuntMwm6vz987q9EJwdSZsaVD3KsKZQbqnxcciEp2qQkQb m8bvbcxjnyIMsltp+HF1lE3IcHSqYoHDwQ== X-Google-Smtp-Source: ABdhPJw3EKcEhzq3fKqQiVq4Ku12owWMdYZC2ah89Vtk+AV6xwYhZSIPCSghcjTgDZpUo8hJLG/JbA== X-Received: by 2002:a17:902:74c1:b0:14a:d9fa:d8a3 with SMTP id f1-20020a17090274c100b0014ad9fad8a3mr12479770plt.119.1642982803949; Sun, 23 Jan 2022 16:06:43 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:43 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Konstantin Ananyev , Bernard Iremonger , Vladimir Medvedkin Subject: [PATCH 79/82] ipsec: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:15 -0800 Message-Id: <20220124000518.319850-80-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/ipsec/ipsec_sad.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/ipsec/ipsec_sad.c b/lib/ipsec/ipsec_sad.c index 531e1e323cdc..af4b1ce757d2 100644 --- a/lib/ipsec/ipsec_sad.c +++ b/lib/ipsec/ipsec_sad.c @@ -440,8 +440,7 @@ rte_ipsec_sad_destroy(struct rte_ipsec_sad *sad) rte_hash_free(sad->hash[RTE_IPSEC_SAD_SPI_DIP]); rte_hash_free(sad->hash[RTE_IPSEC_SAD_SPI_DIP_SIP]); rte_free(sad); - if (te != NULL) - rte_free(te); + rte_free(te); } /* From patchwork Mon Jan 24 00:05:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106319 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDB66A04A6; Mon, 24 Jan 2022 01:12:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D971D42968; Mon, 24 Jan 2022 01:06:49 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 3B80942953 for ; Mon, 24 Jan 2022 01:06:46 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d7so13905149plr.12 for ; Sun, 23 Jan 2022 16:06:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=su+2iWKTkbFtsNLGM+VLfZiV8t8YMaoSIC5oWYs3dcg=; b=s0ticvjFqYCwnXaVJWO/fT0bx2W4Cci40EBZJmll8paB1rPOoC7HfJkinbD6Dt9KAx xwTClQTLINCKiiVhIlEgV6tmjceZ0BoeYV7IwCHmrMZGKc+jVTp7nQ1psH/EtF47e1HU jvezDYO3k0SOcleWvDqvtNhBKdPoLvbeSsuYLs++HW3VenFV5P2EsSOVt+WtEVcX3i+x 6RcJ17lc1zEpdf2/169Nysy/vxM9kkQO8OpHVmI63Wn5LeQsPmBpfaDD/GAT+Vx1BJd4 U3nqf+2F800OGNjpZOPzKErpeAb2JAwCcH9mlTk6mxpxF4BkiwumBzX7AFlK3bRlC6D/ lCQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=su+2iWKTkbFtsNLGM+VLfZiV8t8YMaoSIC5oWYs3dcg=; b=vtAHeJVLV6x/39eOFO5cUigpI2qv5883RBYS2GQ/B3Gwxj2elZEh/4jiWF57MbcnmP 4YL8lv+6RJJTduhYlVq4oBa4OH5NuaKwglsg+ynkgqQtmmBpxkFkVuYVT5eaLzSXYA8Q WZ/UZ1HmVqwq2zNl6zn8JLJMHo9JspHp7KhcJOg2OLs7opw0/kyVZRnzu49vfcjnaPe5 s+laNI6XGsA9M7dYUPlKIidiPIbqrmsbI6IXQV6LjfMSBo5xCTOkHODavkLBYb6tLvWs WcuHTf8LvxtXTCkNgPn25XAk49ur2PKY+DeAYWY2lxu50iZ0cP187eFYaNVidtw2lHVW P3eg== X-Gm-Message-State: AOAM533krn3LGvriLRh3giEYgUZoYaMNg9WNRpP/IJMjsmOP8Yn2a4EP roKXldCjUH6e8dtgLJbEQdhx0NJslEPByQ== X-Google-Smtp-Source: ABdhPJxGpdvt6Ef6pj216pz2V3JYF+IRegylYMSNbBfb1aQq/nctayLQ6pnCl9L+qSbSqN9vcRNjQQ== X-Received: by 2002:a17:90a:5e0d:: with SMTP id w13mr10523007pjf.235.1642982804965; Sun, 23 Jan 2022 16:06:44 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:44 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Cristian Dumitrescu Subject: [PATCH 80/82] port: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:16 -0800 Message-Id: <20220124000518.319850-81-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/port/rte_port_source_sink.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/lib/port/rte_port_source_sink.c b/lib/port/rte_port_source_sink.c index 68575c98338d..79042d13ff66 100644 --- a/lib/port/rte_port_source_sink.c +++ b/lib/port/rte_port_source_sink.c @@ -163,14 +163,10 @@ pcap_source_load(struct rte_port_source *port, return 0; error_exit: - if (pkt_len_aligns) - rte_free(pkt_len_aligns); - if (port->pkt_len) - rte_free(port->pkt_len); - if (port->pkts) - rte_free(port->pkts); - if (port->pkt_buff) - rte_free(port->pkt_buff); + rte_free(pkt_len_aligns); + rte_free(port->pkt_len); + rte_free(port->pkts); + rte_free(port->pkt_buff); return -1; } @@ -242,12 +238,9 @@ rte_port_source_free(void *port) if (p == NULL) return 0; - if (p->pkt_len) - rte_free(p->pkt_len); - if (p->pkts) - rte_free(p->pkts); - if (p->pkt_buff) - rte_free(p->pkt_buff); + rte_free(p->pkt_len); + rte_free(p->pkts); + rte_free(p->pkt_buff); rte_free(p); From patchwork Mon Jan 24 00:05:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106320 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7AF96A04A6; Mon, 24 Jan 2022 01:12:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5E414296E; Mon, 24 Jan 2022 01:06:50 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 00B7442959 for ; Mon, 24 Jan 2022 01:06:47 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id j16so3366071plx.4 for ; Sun, 23 Jan 2022 16:06:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BD/62vUpe6M1CCDtT9zTuTpgci3yYRAHi5TUuvAGKPg=; b=SS6Q98k/6roX5/Kw1dy2it1oNEzx/sohH40MQoKSfS7PGYYDC1DR7EVPwo3cOVtpO3 ODBTGFXJd3KwEi2fFU60qqyUaM06NqId0s+l+Y1+BVejteDxvUdt00unM/y20gsrxrJS j2l1xytQcD3WN2VIFBiWrRZETlpO8rsTn1YmO/IiZYbfLkKpBwmhwMMaPFBzN72uyo2M ssfsTvfcNOWsT/8MAavH8Z1zNN0PGzj8zwgGvvcU5XWmSTcxX3289dRnWRY7SjHCoM7d 23fU6ANCvn0UJvH+u+UrM9IsjIdOzr2F1a0N0fYeBD9EIqu6nFVnbZVIxj/moOCRBLZw vpZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BD/62vUpe6M1CCDtT9zTuTpgci3yYRAHi5TUuvAGKPg=; b=724KbEcSCjbisjUgl9WKoEALUobCeycDdMdW3XqDEOaPq5l9nBMqRMTFjhbOuQR2BX OW8vnQHhMg3wnAGjmkw11zGSeXMEIm0T/yzahYbQW0cI2CzVm+EavXh6/SGhLhhWiDD3 gl9JKg73+8dmX6ljUDLnloj3jKr0wTJ2bI6xcvA0PSHSig6lxUk3cy1Ajthe+LQ+PYDN cIVqqrZuoTUys2BlSVaNN22mExY52BKGBxf6oDRtsS3bWruz3rhOP2fTnG8WCpYNju6T DJdgXeeT5kQLmyCDA7WuAbO07qZ7NlQAsaCFOJLMJkdaP4VdXS0MyLbz8TnIZBGMSpi1 MO1A== X-Gm-Message-State: AOAM532ZBN84KOJHJJQem7hws8KDgKtECPljr5t2GWt0OlPPGwsPqOhl YRauiCaiGCy3+e1GQPtbMR097ZdSBoMFyQ== X-Google-Smtp-Source: ABdhPJwGx2wekl2J/xeEO+ZHMVCW9IO2+zmXPKa9TrRY2o37Hh2zecJ/dqY7ogjSHhGBxcAmhl/v3w== X-Received: by 2002:a17:90a:470a:: with SMTP id h10mr10654100pjg.25.1642982806028; Sun, 23 Jan 2022 16:06:46 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:45 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , David Hunt Subject: [PATCH 81/82] power: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:17 -0800 Message-Id: <20220124000518.319850-82-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/power/rte_power_empty_poll.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/power/rte_power_empty_poll.c b/lib/power/rte_power_empty_poll.c index c4b5de9601cf..2261ce7820f6 100644 --- a/lib/power/rte_power_empty_poll.c +++ b/lib/power/rte_power_empty_poll.c @@ -457,8 +457,7 @@ rte_power_empty_poll_stat_free(void) RTE_LOG(INFO, POWER, "Close the Empty Poll\n"); - if (ep_params != NULL) - rte_free(ep_params); + rte_free(ep_params); } int From patchwork Mon Jan 24 00:05:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106321 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81A9FA04A6; Mon, 24 Jan 2022 01:12:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD2EB42973; Mon, 24 Jan 2022 01:06:51 +0100 (CET) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id 09F0E42960 for ; Mon, 24 Jan 2022 01:06:48 +0100 (CET) Received: by mail-pg1-f181.google.com with SMTP id i8so13594976pgt.13 for ; Sun, 23 Jan 2022 16:06:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4JbSYjjocmCv0cQNMjUL6E2+zoHDau5GvbwOfL56L7k=; b=qy0to2JhQwg7cxSTJgFmq3MXBLeIcjMtoc9V+ispCWS3AQNJLeIMtjshzXbnc7ZIQo KvpWJWAKHXeumTjk8kjU1tbUkp5hHkjV8f/CKi6FDejp4EPwAi3mkRmeJCRVgowrE0Z8 qcCoff3M8X+gUY00ObDBxoTQL+gGY8eA0BX/iOIEtO0YnVlQkIO9SFYmWsKhD+oKZUoJ ehrsARv6oOouhIlviAcVHN1lkyXh4XbkhRuS2kl+9eM65lfS8EffdnBGGua5tXomK1JO O3btCWvkETzmFSzCYIs6tfrVd6EdS6EcTaZCGjPGHWsQB48bnIzFGRdQ74RqNFoBxmz+ 6l0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4JbSYjjocmCv0cQNMjUL6E2+zoHDau5GvbwOfL56L7k=; b=GnSpB8b0NF39j9dGw6V+zPkVUNWeyx8zxzOClVm17iULPc6wlQD3TOkmFzlau2nhqF nScZrOaYp9o2VyVIpHpiyJ5KbXC4wll/sgrDsVYPJum0JT0gvE7XG8k/R3orsZpQB4t9 quhZPzQE3GB7IglIW7RMvNXSFWS+qXxMk28WfBeGdMubCCq3CnzMByYH7el3KguhAU2q vupotSlsVKRi99Iz/wsdMPT9JdXS2ZtxmMO4XN7jizpy1ad6eyoWeqXlLx9g8zSQvO2L RIZeGozvPG74h3y1j0hp/S2HA2YOQFVN4zug5gLTDtRTav3CCe21TjUZzOkq1Yxi4tUb dVWA== X-Gm-Message-State: AOAM533r6eC5dikgaF8RgRvFvPLPplFzGtU9hHE8CjooEHaxkW9yNt/y Y38M3pt2HnkBsMI2JKL2GIM5Hr4iSY0JWw== X-Google-Smtp-Source: ABdhPJxjVwnnNPpFVzw/AZXAMEkhwxZxLi7zjZZ5qRNHCs8xb0748h/HgXQ2sf/UrQVhcQJFR2o/8Q== X-Received: by 2002:a63:3d0e:: with SMTP id k14mr9862099pga.484.1642982807036; Sun, 23 Jan 2022 16:06:47 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ck21sm10935350pjb.51.2022.01.23.16.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 16:06:46 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Reshma Pattan Subject: [PATCH 82/82] reorder: remove unnecessary NULL checks Date: Sun, 23 Jan 2022 16:05:18 -0800 Message-Id: <20220124000518.319850-83-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124000518.319850-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/reorder/rte_reorder.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c index 9445853b79cc..bc0241bfb3fd 100644 --- a/lib/reorder/rte_reorder.c +++ b/lib/reorder/rte_reorder.c @@ -192,10 +192,8 @@ rte_reorder_free_mbufs(struct rte_reorder_buffer *b) /* Free up the mbufs of order buffer & ready buffer */ for (i = 0; i < b->order_buf.size; i++) { - if (b->order_buf.entries[i]) - rte_pktmbuf_free(b->order_buf.entries[i]); - if (b->ready_buf.entries[i]) - rte_pktmbuf_free(b->ready_buf.entries[i]); + rte_pktmbuf_free(b->order_buf.entries[i]); + rte_pktmbuf_free(b->ready_buf.entries[i]); } }