From patchwork Mon Jan 24 17:45:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106359 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52B5DA04AD; Mon, 24 Jan 2022 18:47:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DD38427DD; Mon, 24 Jan 2022 18:47:25 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id C717140040 for ; Mon, 24 Jan 2022 18:47:23 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id c3so16311102pls.5 for ; Mon, 24 Jan 2022 09:47:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iQDMti0C/zCmytBoY0TBHcFMELXFLxnste1k0DLf55E=; b=EGjGPdC0WNWlqFujJPTs26UI4e8Uk8INGYuEny0yLmc6D8OC15X1PovK6tnVNKxPQ2 qS7ZnYvd0/1QqnJwhztoftztxW3dUPb9DgCqB74m4Wwjc/Vcspl9TeHkfObTyWZtwrcD +xbLW+CZa+dE/4F884MqkDyEB+YsemPyJK1KPB5q5Q4VRcW3Dt8zl+saLBrV+/LTi3Rp yWXj4UpdR4YZVQFhZ+TLdewCxeXaRO6vW2ambkHCE44LU+TSJvoXQ3yOsurAF3OcKS+v fvvnJvqN9YJBxkf63jwDiD+jW/rnuCheSpiiEKR2grJf1Jop1WEVgzb90L4aHjzfL+bX 7YBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iQDMti0C/zCmytBoY0TBHcFMELXFLxnste1k0DLf55E=; b=wqhfpEtKJnNjpl740l5AbViQ9Hac3G4TeMjPiSnNcSrI4BC8zJ+wbrmU8qGhWTEJtH ALjtwpT4E2aYC3OYxPdNA/Rm4ceUH+pFk80dYXLEBT1O4bHHn19Ymwc2RTIrUcHAlOWX fjmla9Apw3+S/K0TXNLSEWGWEKwGWw5a7Q2NX7qsO9yt5Q8Vp6bDuK5lQBhWEf6nJkSJ v4zcWmnMJM5kDkUnj00uEcJvjYfNmXtS9oGiSGFI5N+fWgZwVhbzvBBg4gr0pJNP57tx D8WwAZrgNLaib5R1aqGRttLSjMLkJfw0dOyaG9YapmSMYN5MfAaX2g/r9rrHlppdHqvB fpwg== X-Gm-Message-State: AOAM531QWbd/eAYalrBcO9VsoITa6I/pHwt0eUwHygW2XtzS4MXU+rBw f5BgP2YLq7nOoVnBbY2FXwsvOR79SUTDyA== X-Google-Smtp-Source: ABdhPJzMKAwupj7tHAkHxjdpuV3CC2d4kaEANp1fjuievq2ccOaDC02B41+WxU6dspsBuj/ydysxEQ== X-Received: by 2002:a17:90a:1196:: with SMTP id e22mr2964287pja.241.1643046442826; Mon, 24 Jan 2022 09:47:22 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:22 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , Olivier Matz , Andrew Rybchenko , Honnappa Nagarahalli , Konstantin Ananyev Subject: [PATCH v2 01/83] lib: update documentation of XXX_free() functions Date: Mon, 24 Jan 2022 09:45:57 -0800 Message-Id: <20220124174719.14417-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org These functions all behave like libc free() and do nothing if handed a NULL pointer. The code is already doing this, this patch just documents the behavior. Signed-off-by: Stephen Hemminger --- lib/hash/rte_hash.h | 3 +++ lib/kvargs/rte_kvargs.h | 2 ++ lib/mbuf/rte_mbuf.h | 2 ++ lib/mempool/rte_mempool.h | 2 ++ lib/ring/rte_ring.h | 2 ++ 5 files changed, 11 insertions(+) diff --git a/lib/hash/rte_hash.h b/lib/hash/rte_hash.h index 6067aad95431..94223cf81ae0 100644 --- a/lib/hash/rte_hash.h +++ b/lib/hash/rte_hash.h @@ -174,6 +174,9 @@ rte_hash_find_existing(const char *name); /** * De-allocate all memory used by hash table. + * + * If the pointer is NULL, the function does nothing. + * * @param h * Hash table to free */ diff --git a/lib/kvargs/rte_kvargs.h b/lib/kvargs/rte_kvargs.h index 359a9f5b091c..bf1732ce2b1e 100644 --- a/lib/kvargs/rte_kvargs.h +++ b/lib/kvargs/rte_kvargs.h @@ -108,6 +108,8 @@ struct rte_kvargs *rte_kvargs_parse_delim(const char *args, * Free a rte_kvargs structure previously allocated with * rte_kvargs_parse(). * + * If the pointer is NULL, the function does nothing. + * * @param kvlist * The rte_kvargs structure. No error if NULL. */ diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h index dedf83c38d1b..cb280108d3f9 100644 --- a/lib/mbuf/rte_mbuf.h +++ b/lib/mbuf/rte_mbuf.h @@ -1372,6 +1372,8 @@ rte_pktmbuf_free_seg(struct rte_mbuf *m) * Free an mbuf, and all its segments in case of chained buffers. Each * segment is added back into its original mempool. * + * If the pointer is NULL, the function does nothing. + * * @param m * The packet mbuf to be freed. If NULL, the function does nothing. */ diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h index 1e7a3c15273c..c268328b268b 100644 --- a/lib/mempool/rte_mempool.h +++ b/lib/mempool/rte_mempool.h @@ -1099,6 +1099,8 @@ rte_mempool_create_empty(const char *name, unsigned n, unsigned elt_size, * memory referenced by the mempool. The objects must not be used by * other cores as they will be freed. * + * If the pointer is NULL, the function does nothing. + * * @param mp * A pointer to the mempool structure. */ diff --git a/lib/ring/rte_ring.h b/lib/ring/rte_ring.h index da17ed6d7c04..c2faf7b3e6dc 100644 --- a/lib/ring/rte_ring.h +++ b/lib/ring/rte_ring.h @@ -176,6 +176,8 @@ struct rte_ring *rte_ring_create(const char *name, unsigned int count, /** * De-allocate all memory used by the ring. * + * If the pointer is NULL, the function does nothing. + * * @param r * Ring to free */ From patchwork Mon Jan 24 17:45:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106360 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82505A04AD; Mon, 24 Jan 2022 18:47:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FAD041181; Mon, 24 Jan 2022 18:47:27 +0100 (CET) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id C1F7641181 for ; Mon, 24 Jan 2022 18:47:24 +0100 (CET) Received: by mail-pf1-f182.google.com with SMTP id x37so12713957pfh.8 for ; Mon, 24 Jan 2022 09:47:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fx9fGBqwaJ0wCgjZtyoP2WepXlYkO+A7iATlxzyO6H0=; b=lv1NcdKoMT0PtTnorZBakcZ8V6auSgrfOSUSQ9ddSkKyEyH3m5isIfmZQYuYP+a2x3 pWK+9j7wazYrz6j7iTA7Vz7j9U8tdrPAXL3Qdz4btnV/7FvksgimYQL867fR8OCXybx5 HCA5xj2xrdliBow46Wgv5vlFLvbuGjJrIEoZi5DSHO7p6aHAqI3IoXJAdY7v/QIwqvOV KakcHDmu2+/eifqNOi5ZetNvYRfEDb+TwARhriFisTgIOzqBmsh5iuJgrZpXpHfJXn90 5fx0nA2j9laVVv6IDGTnc+l818gHjEs3fLSAoxjeeMaziSLtBJHSZ+rxTvfZX005kWwS v10A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fx9fGBqwaJ0wCgjZtyoP2WepXlYkO+A7iATlxzyO6H0=; b=hAY7xQA3ObFlGr434y05TKoh3XUbba7RtYLvmy96OZy1+Q66yYxMud3oLhca9gQjIA 4k3nAU9ZI6zJR1XZsGRJlE+xlRlmH/oe393WQFOIV9oi/NuUAQn7KB/mAYH90Ac6gyV+ RaGbnmfWXIGbdVxtrUc3N8Sm9nbszY62dGw9Xkjhm0jeqxEAuNN6+vGZ5Y5cRSd+NLO8 SrRkZGYAP/aKcZSnXSiHf1PRzcli+xgevtLO0+ipbUXIYV+skwhAM6eGZiqmIJSjmIEy a+nIQ7QPkSu+pHfnx7oVdRuDmkVMBOCZ+AgTtWyVBDe/8AxfEgJLnSFU3pF0PMgEboTl rDFQ== X-Gm-Message-State: AOAM5317FOaSbCPRoz0vVI/4apTfNyHBrBq9DUsnwkYZMzh+AynkjDyz N3K09CDIYXhzKPhZ7x0ccRU3YTPyGPwVUQ== X-Google-Smtp-Source: ABdhPJwXYT59nEu3ATpYl/Nz3EF2d/4TuPPa5o0U6bW8OHQwW4utWarAKxCnEIBcD2J2aNycaYMrUg== X-Received: by 2002:a63:9142:: with SMTP id l63mr12629374pge.476.1643046443762; Mon, 24 Jan 2022 09:47:23 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:23 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v2 02/83] devtools/cocci: add script to fix unnecessary null checks Date: Mon, 24 Jan 2022 09:45:58 -0800 Message-Id: <20220124174719.14417-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This script is based on the idea of the nullfree script in the Linux kernel. It finds cases where a check for null pointer is done, but is unnecessary because the function already handles NULL pointer. Basic example: if (x->buf) rte_free(x->buf); can be reduced to: rte_free(x->buf); Signed-off-by: Stephen Hemminger --- devtools/cocci/nullfree.cocci | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 devtools/cocci/nullfree.cocci diff --git a/devtools/cocci/nullfree.cocci b/devtools/cocci/nullfree.cocci new file mode 100644 index 000000000000..363b6149ac28 --- /dev/null +++ b/devtools/cocci/nullfree.cocci @@ -0,0 +1,33 @@ +// +// Remove unnecessary NULL pointer checks before free functions +// All these functions work like libc free which allows +// free(NULL) as a no-op. +// +@@ +expression E; +@@ +( +- if (E != NULL) free(E); ++ free(E); +| +- if (E != NULL) rte_bitmap_free(E); ++ rte_bitmap_free(E); +| +- if (E != NULL) rte_free(E); ++ rte_free(E); +| +- if (E != NULL) rte_hash_free(E); ++ rte_hash_free(E); +| +- if (E != NULL) rte_ring_free(E); ++ rte_ring_free(E); +| +- if (E != NULL) rte_pktmbuf_free(E); ++ rte_pktmbuf_free(E); +| +- if (E != NULL) rte_mempool_free(E); ++ rte_mempool_free(E); +| +- if (E != NULL) rte_kvargs_free(E); ++ rte_kvargs_free(E); +) From patchwork Mon Jan 24 17:45:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106361 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAC10A04AD; Mon, 24 Jan 2022 18:47:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58DCF427E6; Mon, 24 Jan 2022 18:47:28 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id D20AC427E3 for ; Mon, 24 Jan 2022 18:47:25 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d1so16300348plh.10 for ; Mon, 24 Jan 2022 09:47:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TNFTY4lice/dZPTBYg9Avv4Lr9A8xdw/ptuoLV9oUuo=; b=SpVxbDo5HlYr39yHDqFCbjHwphRZdbAfpUUeJ560+XPC3pLb5fn6y1FBYSP55jSAAd e3gzhzNBe94dn7/tBywA90XQQsNC9jzLUk3C17KeXj989lw6YaquFgEYNhKU/Czibpva sVTuBtxKBHPZYF5ZoUzXalfCvtsGPhlYsF7L27txBZPAh2xYI+oy630uEBBmRJVBXU5n Hn/hBM9lHZXwUKMLRlvplY9oegIwzr+Tn6nMSG3AYUpOTlDiZEPPURlYe3hsgq7VkJzy 5WhNVKcWmYnmqzA8s3IvkYUaLjSGPxcRoTuv+zXjq6ODjACx7zJ+EGvvN14Psht45r48 aKRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TNFTY4lice/dZPTBYg9Avv4Lr9A8xdw/ptuoLV9oUuo=; b=t3PTMrvSNBwYuNYQm1J51CCyZ0bv1KX+Zldx4rn1CAT8FwNxiqvdh3D7PhRelR9L8t 3Bgh6oqx74Bvn2b0aKlOD3hsgNIaPrHR3z2XRO28wmpY9HlhIwQY2KuEC63jE0a27osP bvmFgB2lmMSy9K6v92cjQ6f9W1Nc5mjyUrdxT7GlFOR994mVKQbU3CCKRQ8znyrCiMcy Yu3Suj53D9kBmQPzppQIZ2ji5Dn/7dnHi3NzUCASLeEfCOhlbBymW3QOrjjjJOaSM9Ug 1ohuB6iwngmFumfBLuM1mbc5bZZyM0O0ZWbDNPK+zibSj83Ay1u5CnaRfUz+SFq5ZOdk yDaA== X-Gm-Message-State: AOAM532QSgYUO6IZ6LT0GuIOfOWXL2hs1r9HbNlub64bxpCXj0ewFMuH KLR9d5e4u6z1yDIrUXU0zqWdfdvljmGmUg== X-Google-Smtp-Source: ABdhPJzVbLEkzS6kbyswnnIaqRMIYV1iDImA1lg5kErSIH+bjLle11Iz7VWTjw0thv4kiWeSXQLBnQ== X-Received: by 2002:a17:90a:8a02:: with SMTP id w2mr2994600pjn.177.1643046444833; Mon, 24 Jan 2022 09:47:24 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:24 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Anatoly Burakov , Jerin Jacob , Sunil Kumar Kori , Bruce Richardson Subject: [PATCH v2 03/83] eal: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:45:59 -0800 Message-Id: <20220124174719.14417-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Functions like free() already handle NULL pointer so the checks here are not necessary. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_devargs.c | 6 ++---- lib/eal/common/eal_common_memzone.c | 3 +-- lib/eal/common/eal_common_options.c | 9 +++------ lib/eal/common/eal_common_trace_ctf.c | 6 ++---- lib/eal/freebsd/eal.c | 4 +--- lib/eal/linux/eal.c | 10 +++------- 6 files changed, 12 insertions(+), 26 deletions(-) diff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c index 8c7650cf6c27..69004b0a2d2f 100644 --- a/lib/eal/common/eal_common_devargs.c +++ b/lib/eal/common/eal_common_devargs.c @@ -161,8 +161,7 @@ rte_devargs_layers_parse(struct rte_devargs *devargs, get_out: for (i = 0; i < RTE_DIM(layers); i++) { - if (layers[i].kvlist) - rte_kvargs_free(layers[i].kvlist); + rte_kvargs_free(layers[i].kvlist); } if (ret != 0) { if (allocated_data) { @@ -285,8 +284,7 @@ rte_devargs_reset(struct rte_devargs *da) { if (da == NULL) return; - if (da->data) - free(da->data); + free(da->data); da->data = NULL; } diff --git a/lib/eal/common/eal_common_memzone.c b/lib/eal/common/eal_common_memzone.c index ecde9441ee90..9a0c5309ac7e 100644 --- a/lib/eal/common/eal_common_memzone.c +++ b/lib/eal/common/eal_common_memzone.c @@ -300,8 +300,7 @@ rte_memzone_free(const struct rte_memzone *mz) rte_rwlock_write_unlock(&mcfg->mlock); - if (addr != NULL) - rte_free(addr); + rte_free(addr); rte_eal_trace_memzone_free(name, addr, ret); return ret; diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c index 1cfdd75f3b79..09b7b17ffa06 100644 --- a/lib/eal/common/eal_common_options.c +++ b/lib/eal/common/eal_common_options.c @@ -1962,12 +1962,9 @@ compute_ctrl_threads_cpuset(struct internal_config *internal_cfg) int eal_cleanup_config(struct internal_config *internal_cfg) { - if (internal_cfg->hugefile_prefix != NULL) - free(internal_cfg->hugefile_prefix); - if (internal_cfg->hugepage_dir != NULL) - free(internal_cfg->hugepage_dir); - if (internal_cfg->user_mbuf_pool_ops_name != NULL) - free(internal_cfg->user_mbuf_pool_ops_name); + free(internal_cfg->hugefile_prefix); + free(internal_cfg->hugepage_dir); + free(internal_cfg->user_mbuf_pool_ops_name); return 0; } diff --git a/lib/eal/common/eal_common_trace_ctf.c b/lib/eal/common/eal_common_trace_ctf.c index 33e419aac7fb..3b83bcdf57fd 100644 --- a/lib/eal/common/eal_common_trace_ctf.c +++ b/lib/eal/common/eal_common_trace_ctf.c @@ -52,8 +52,7 @@ meta_copy(char **meta, int *offset, char *str, int rc) return rc; free_str: - if (str) - free(str); + free(str); return -ENOMEM; } @@ -291,8 +290,7 @@ trace_metadata_create(void) return 0; fail: - if (meta) - free(meta); + free(meta); return -EBADF; } diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index a1cd2462db1b..00ba32f1d664 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -544,9 +544,7 @@ eal_parse_args(int argc, char **argv) RTE_LOG(ERR, EAL, "Could not store mbuf pool ops name\n"); else { /* free old ops name */ - if (internal_conf->user_mbuf_pool_ops_name != - NULL) - free(internal_conf->user_mbuf_pool_ops_name); + free(internal_conf->user_mbuf_pool_ops_name); internal_conf->user_mbuf_pool_ops_name = ops_name; diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 60b49248388e..f8e39b7e4277 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -730,8 +730,7 @@ eal_parse_args(int argc, char **argv) RTE_LOG(ERR, EAL, "Could not store hugepage directory\n"); else { /* free old hugepage dir */ - if (internal_conf->hugepage_dir != NULL) - free(internal_conf->hugepage_dir); + free(internal_conf->hugepage_dir); internal_conf->hugepage_dir = hdir; } break; @@ -743,8 +742,7 @@ eal_parse_args(int argc, char **argv) RTE_LOG(ERR, EAL, "Could not store file prefix\n"); else { /* free old prefix */ - if (internal_conf->hugefile_prefix != NULL) - free(internal_conf->hugefile_prefix); + free(internal_conf->hugefile_prefix); internal_conf->hugefile_prefix = prefix; } break; @@ -804,9 +802,7 @@ eal_parse_args(int argc, char **argv) RTE_LOG(ERR, EAL, "Could not store mbuf pool ops name\n"); else { /* free old ops name */ - if (internal_conf->user_mbuf_pool_ops_name != - NULL) - free(internal_conf->user_mbuf_pool_ops_name); + free(internal_conf->user_mbuf_pool_ops_name); internal_conf->user_mbuf_pool_ops_name = ops_name; From patchwork Mon Jan 24 17:46:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106362 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 995F4A04AD; Mon, 24 Jan 2022 18:47:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97DCC427EE; Mon, 24 Jan 2022 18:47:29 +0100 (CET) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id F1A9140040 for ; Mon, 24 Jan 2022 18:47:26 +0100 (CET) Received: by mail-pf1-f176.google.com with SMTP id v74so13426599pfc.1 for ; Mon, 24 Jan 2022 09:47:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OgIanIgFtHcdHoFnpNWsa8XIcvgA8wPsembFoHuQzfg=; b=YdXJ6SXhyaulL4IXSkRRXpWMolnffBjFZZPh6byh3mK9UCAbiHHXzFJZOiVsGtoLeR sRcYHccnQNSEGytuoBmu1bheZjDlObIoHMpj8E4gCpHx7MvWzv/fpcID9MeMi4k85EHn oRryCLmDcJYZcor11GNZ9/zBSl76YgXFdlEf1BkHp0SH8uPePgmHi15WW2O4Q9SlsFLu 9V6wxXq50bHqJE1Jpmf3CJOBfZ688Pa+DKZny7w110YDTijvBV+fFYHa3/mo0Kvx0G0H V29wo7oQZ/JtQWHcuiMfHN5pAZjgu4S/9Lw7xFJF5bYiD1geTIFUaxFVe76BxcSTMBbx tsRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OgIanIgFtHcdHoFnpNWsa8XIcvgA8wPsembFoHuQzfg=; b=h5SKujUT/hZ568EX2Hqg7aiIUpYedUEsJxtTPJ5l1xcxrRavx0pghqIbikeiyymf8a DDJmYE/tkGNLpo34L4V/MPdnxjYU1v0bo39Qp7quVwbNig7vJmQ9nVwYZpu6SCtPIJKj aw19CazZDN6Nt0HRVHKIrbSs3cHKMYbf8vNuPpLrXG3uYbDwgihWrft1W9hWsszttEHm QHCexZpNo0Mh9Xp1zrsFF9Fdy9UShGMhU04Vt+SGEE9+EqtESnUezhBZXFFfZfEj0kxn ix1tMawnrp3TCl8TKsnRL5x8JcipGN2oayJ+oHBdvGIGpYK6zwPZTSsZeqBbbHmCluz9 oKww== X-Gm-Message-State: AOAM533NUV4J4Y/bKLPvgyELy6Gd1ZBWRWLH5qPnbpUwuNA+2wUy3NUh 9b35R81KXU98A1s2En4DxUKMPo0B/n0UjA== X-Google-Smtp-Source: ABdhPJyC9C3UeZpavt9vyQmDfebAkdyhbMMIsaMBqlSqlkVa+HpT5Y4jDwHJF4OQ9qDVAnuUSh5qyg== X-Received: by 2002:a63:2c81:: with SMTP id s123mr7619802pgs.241.1643046445918; Mon, 24 Jan 2022 09:47:25 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:25 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Subject: [PATCH v2 04/83] eal/windows: remove unnecessary NULL checks before free Date: Mon, 24 Jan 2022 09:46:00 -0800 Message-Id: <20220124174719.14417-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Calling free/rte_free/rte_mempool_free,... with NULL pointer is allowed; so remove unnecessary NULL checks. Signed-off-by: Stephen Hemminger --- lib/eal/windows/eal_alarm.c | 3 +-- lib/eal/windows/eal_memory.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/windows/eal_alarm.c b/lib/eal/windows/eal_alarm.c index 103c1f909da3..51fe752c16d4 100644 --- a/lib/eal/windows/eal_alarm.c +++ b/lib/eal/windows/eal_alarm.c @@ -162,8 +162,7 @@ rte_eal_alarm_set(uint64_t us, rte_eal_alarm_callback cb_fn, void *cb_arg) fail: if (timer != NULL) CloseHandle(timer); - if (ap != NULL) - free(ap); + free(ap); exit: rte_eal_trace_alarm_set(us, cb_fn, cb_arg, ret); diff --git a/lib/eal/windows/eal_memory.c b/lib/eal/windows/eal_memory.c index 2fd37d97085e..215d768e2c57 100644 --- a/lib/eal/windows/eal_memory.c +++ b/lib/eal/windows/eal_memory.c @@ -190,8 +190,7 @@ eal_mem_virt2iova_init(void) ret = 0; exit: - if (detail != NULL) - free(detail); + free(detail); if (list != INVALID_HANDLE_VALUE) SetupDiDestroyDeviceInfoList(list); From patchwork Mon Jan 24 17:46:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106363 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAC82A04AD; Mon, 24 Jan 2022 18:47:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83561427F6; Mon, 24 Jan 2022 18:47:31 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 169D1427E0 for ; Mon, 24 Jan 2022 18:47:28 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id h20-20020a17090adb9400b001b518bf99ffso13901575pjv.1 for ; Mon, 24 Jan 2022 09:47:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZF5DH4WTjbSkV2F/G0r3/VYP0G2BxRN5oK/2+qTsXtY=; b=6HJoY24Bb03niKDU2vTtdgVwTW+2lg66eYbh8DzeIkolCr0vhqR0hQKc5v+txv9Dqh Es/kSms9Ysa1ENs7hV54dp6+Eky6Kb5XyeUt6wPckiF0BHT0sHn3K1YToY4S+GZgHKBj uWraOqwHqqjXxAFkY9OZypPoK1WMSMnMJ3rVqF/vNupqjq/5gYe3MZxXftbgcpGkcScT 1EJIpz5WPo3YTfBed3BFqLVbXeFJwqqF/mZghi/W97fcn4Joe+rD4KTw0Rs7B/o5knkh vhWHrYEylegMLkiJoKVtMNmJI8555gmGGR/VerBDjWBf+bWTYQrHGlFRbp7oGOJoK8E0 wwwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZF5DH4WTjbSkV2F/G0r3/VYP0G2BxRN5oK/2+qTsXtY=; b=yF8K0MRfYBHASsBd9EMPgEmtjViYNxpspALyl8gvBzbkqXwsmUrYl2mfuORkxRNhUr i5v3MguHCFGT2VOsij2kw3OrSgw89DIlraevGhNgsULmsOtkav/aU0jcnUa203Axz9WR ha255nJ6E2kR+eM0FfKVCE5WZ6Q1m/MjVnHQCGpRHa+4issooo8subG/rstd8qD7Fq1X ylV1nWVQNKFleD9i+ylz/rVILijr05dNI0CMXJt9gP+7QX3Bk4PS3T6UZkvoUst21M+l fJVoimLiWFO1QkmCnRK8XcErmwbxbHHDnaB0U8vysecSpJciNmqHTjYTiefL4iDOxtU+ c64A== X-Gm-Message-State: AOAM530XBPIO60qrxP65a1eZ9ipeuRST0kYIyBiCoPc4Lm3imN6NIkBF nMf7tbM7iDK0RozGIhurVllj9PV+49vY9A== X-Google-Smtp-Source: ABdhPJw6Gy6n9sfkyqrmHauB0Io0HvZBzmE1T+Z4jsfrWn7huuhIqqevyxlrtNrQ3Gtztd0g5zuncA== X-Received: by 2002:a17:90a:5d8d:: with SMTP id t13mr2987749pji.47.1643046447028; Mon, 24 Jan 2022 09:47:27 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:26 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Marko Kovacevic Subject: [PATCH v2 05/83] examples/fips_validation: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:01 -0800 Message-Id: <20220124174719.14417-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- examples/fips_validation/fips_dev_self_test.c | 18 ++++------ examples/fips_validation/fips_validation.c | 3 +- examples/fips_validation/main.c | 36 +++++++------------ 3 files changed, 19 insertions(+), 38 deletions(-) diff --git a/examples/fips_validation/fips_dev_self_test.c b/examples/fips_validation/fips_dev_self_test.c index b4eab05a9851..076e9de099c0 100644 --- a/examples/fips_validation/fips_dev_self_test.c +++ b/examples/fips_validation/fips_dev_self_test.c @@ -1396,8 +1396,7 @@ check_aead_result(struct rte_crypto_op *op, if (!mbuf) return -1; - if (op->sym->aead.aad.data) - rte_free(op->sym->aead.aad.data); + rte_free(op->sym->aead.aad.data); if (dir == self_test_dir_enc_auth_gen) { src = vec->output.data; @@ -1523,18 +1522,13 @@ static void fips_dev_auto_test_uninit(uint8_t dev_id, struct fips_dev_auto_test_env *env) { - if (env->mbuf) - rte_pktmbuf_free(env->mbuf); + rte_pktmbuf_free(env->mbuf); if (env->op) rte_crypto_op_free(env->op); - if (env->mpool) - rte_mempool_free(env->mpool); - if (env->op_pool) - rte_mempool_free(env->op_pool); - if (env->sess_pool) - rte_mempool_free(env->sess_pool); - if (env->sess_priv_pool) - rte_mempool_free(env->sess_priv_pool); + rte_mempool_free(env->mpool); + rte_mempool_free(env->op_pool); + rte_mempool_free(env->sess_pool); + rte_mempool_free(env->sess_priv_pool); rte_cryptodev_stop(dev_id); } diff --git a/examples/fips_validation/fips_validation.c b/examples/fips_validation/fips_validation.c index 52a7bf952d46..94253eaee8bf 100644 --- a/examples/fips_validation/fips_validation.c +++ b/examples/fips_validation/fips_validation.c @@ -344,8 +344,7 @@ fips_test_clear(void) fclose(info.fp_rd); if (info.fp_wr) fclose(info.fp_wr); - if (info.one_line_text) - free(info.one_line_text); + free(info.one_line_text); if (info.nb_vec_lines) { uint32_t i; diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c index dc40bffe7d97..e06ae37567fd 100644 --- a/examples/fips_validation/main.c +++ b/examples/fips_validation/main.c @@ -143,12 +143,9 @@ cryptodev_fips_validate_app_int(void) error_exit: rte_mempool_free(env.mpool); - if (env.sess_mpool) - rte_mempool_free(env.sess_mpool); - if (env.sess_priv_mpool) - rte_mempool_free(env.sess_priv_mpool); - if (env.op_pool) - rte_mempool_free(env.op_pool); + rte_mempool_free(env.sess_mpool); + rte_mempool_free(env.sess_priv_mpool); + rte_mempool_free(env.op_pool); return ret; } @@ -523,8 +520,7 @@ prepare_data_mbufs(struct fips_val *val) uint16_t nb_seg; int ret = 0; - if (env.mbuf) - rte_pktmbuf_free(env.mbuf); + rte_pktmbuf_free(env.mbuf); if (total_len > RTE_MBUF_MAX_NB_SEGS) { RTE_LOG(ERR, USER1, "Data len %u too big\n", total_len); @@ -598,8 +594,7 @@ prepare_data_mbufs(struct fips_val *val) return 0; error_exit: - if (head) - rte_pktmbuf_free(head); + rte_pktmbuf_free(head); return ret; } @@ -656,8 +651,7 @@ prepare_auth_op(void) if (ret < 0) return ret; - if (env.digest) - rte_free(env.digest); + rte_free(env.digest); env.digest = rte_zmalloc(NULL, vec.cipher_auth.digest.len, RTE_CACHE_LINE_SIZE); @@ -705,8 +699,7 @@ prepare_aead_op(void) if (ret < 0) return ret; - if (env.digest) - rte_free(env.digest); + rte_free(env.digest); env.digest = rte_zmalloc(NULL, vec.aead.digest.len, RTE_CACHE_LINE_SIZE); if (!env.digest) { @@ -1430,8 +1423,7 @@ fips_mct_tdes_test(void) } } - if (val.val) - free(val.val); + free(val.val); return 0; } @@ -1510,8 +1502,7 @@ fips_mct_aes_ecb_test(void) } } - if (val.val) - free(val.val); + free(val.val); return 0; } @@ -1619,8 +1610,7 @@ fips_mct_aes_test(void) memcpy(vec.iv.val, val.val, AES_BLOCK_SIZE); } - if (val.val) - free(val.val); + free(val.val); return 0; } @@ -1706,8 +1696,7 @@ fips_mct_sha_test(void) rte_free(vec.pt.val); - if (val.val) - free(val.val); + free(val.val); return 0; } @@ -1851,8 +1840,7 @@ fips_test_one_file(void) rte_free(env.digest); env.digest = NULL; } - if (env.mbuf) - rte_pktmbuf_free(env.mbuf); + rte_pktmbuf_free(env.mbuf); return ret; } From patchwork Mon Jan 24 17:46:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106364 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49D81A04AD; Mon, 24 Jan 2022 18:47:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE532427FF; Mon, 24 Jan 2022 18:47:32 +0100 (CET) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id 03C4B427EB for ; Mon, 24 Jan 2022 18:47:29 +0100 (CET) Received: by mail-pg1-f181.google.com with SMTP id j10so3881349pgc.6 for ; Mon, 24 Jan 2022 09:47:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m9Fhm5t+AxyhwGNqtgJo7EQpKlSWzjNFbTcX1SJZ86I=; b=j8i/yIKP5B+KGKvLE6GAieU+mivWHZiaKh9EYjQ51I/R7IdLYS+oS6G3QBZWYUJIJZ MHfiKrbjGlTjuj1xctPsYfZ4x0HGggoLeMIw2AtVeB8JDmmLK6vZnCNKzLc/tYPm3IsD /LW4mS0J27C1fOp2sw9GUT04Akndrqk/oSjvejPhEGuuBUpHu2B52OQd4HRy+rF7HRSQ Pkt1GzvHsrvIwxaxcodSM+N1BeBJuRzirFqzq7yNdf5USG8IUibTyX2FJiJh4fFwSyUS NNSDJYkt0eBvSJwbQMYgR2s+oOvl1tBKJ6M+jA5LxEYYoayrpuM2OZlXCMILbeNtj+ww poYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m9Fhm5t+AxyhwGNqtgJo7EQpKlSWzjNFbTcX1SJZ86I=; b=aFzJ/r6Lh1RupEEc+oWhKSfW5/8LFczjouZGWzfrscY8ZdFnj6iHq/jqkRgnuQ6eMj CmmeoeoMgAJ8ypfZEjMH5qs4qotbIAMqD3aFm2u6l/9txCE6t4whj2wvwMWc/7U1tfnC hCSgOjbX4aoZw96oqjooHbf5SevN3EMW6Ie1RdhKVrjKLze50k1iBwHQj/KZV0jMUax/ Zhm9AoPmPrNplxtElOAm3mxVf3Jtww3TZRdULUyttIagUbEg7gnoi3W8txvE/TNeMKqV XwOwuIH2d7Z8XTWVHk4rl4WHWvj1t4/kvP3UaMBju6EYeFtCBE8Mh5gPujPYr5T8wlD5 nKgA== X-Gm-Message-State: AOAM532GXJ5nrxrNgJBkVO0CwQxdj22/k26tkr01gJBemmL84QYAntDu pwJ/fea57x5xYBnUS/Ag+ciTSG7m16qRbg== X-Google-Smtp-Source: ABdhPJzOilknKgVCnm3Oj/Rwn7w7pgPrJiIIEj57+3Bls7KhALPVVwHemuvUCsJ62GPZcMx6C+dcnQ== X-Received: by 2002:aa7:928e:0:b0:4ba:fa67:d87 with SMTP id j14-20020aa7928e000000b004bafa670d87mr14790125pfa.41.1643046448047; Mon, 24 Jan 2022 09:47:28 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:27 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Cristian Dumitrescu Subject: [PATCH v2 06/83] examples/ip_pipeline: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:02 -0800 Message-Id: <20220124174719.14417-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- examples/ip_pipeline/cli.c | 12 ++++-------- examples/ip_pipeline/cryptodev.c | 6 ++---- examples/ip_pipeline/thread.c | 6 ++---- 3 files changed, 8 insertions(+), 16 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index 0c372675a919..c918f30e06f3 100644 --- a/examples/ip_pipeline/cli.c +++ b/examples/ip_pipeline/cli.c @@ -3773,10 +3773,8 @@ parse_free_sym_crypto_param_data(struct rte_table_action_sym_crypto_params *p) switch (xform[i]->type) { case RTE_CRYPTO_SYM_XFORM_CIPHER: - if (p->cipher_auth.cipher_iv.val) - free(p->cipher_auth.cipher_iv.val); - if (p->cipher_auth.cipher_iv_update.val) - free(p->cipher_auth.cipher_iv_update.val); + free(p->cipher_auth.cipher_iv.val); + free(p->cipher_auth.cipher_iv_update.val); break; case RTE_CRYPTO_SYM_XFORM_AUTH: if (p->cipher_auth.auth_iv.val) @@ -3785,10 +3783,8 @@ parse_free_sym_crypto_param_data(struct rte_table_action_sym_crypto_params *p) free(p->cipher_auth.cipher_iv_update.val); break; case RTE_CRYPTO_SYM_XFORM_AEAD: - if (p->aead.iv.val) - free(p->aead.iv.val); - if (p->aead.aad.val) - free(p->aead.aad.val); + free(p->aead.iv.val); + free(p->aead.aad.val); break; default: continue; diff --git a/examples/ip_pipeline/cryptodev.c b/examples/ip_pipeline/cryptodev.c index 9997d974563f..cd0f9c3d4eac 100644 --- a/examples/ip_pipeline/cryptodev.c +++ b/examples/ip_pipeline/cryptodev.c @@ -151,10 +151,8 @@ cryptodev_create(const char *name, struct cryptodev_params *params) return cryptodev; error_exit: - if (cryptodev->mp_create) - rte_mempool_free(cryptodev->mp_create); - if (cryptodev->mp_init) - rte_mempool_free(cryptodev->mp_init); + rte_mempool_free(cryptodev->mp_create); + rte_mempool_free(cryptodev->mp_init); free(cryptodev); diff --git a/examples/ip_pipeline/thread.c b/examples/ip_pipeline/thread.c index b2e97327052f..82d5f87c384c 100644 --- a/examples/ip_pipeline/thread.c +++ b/examples/ip_pipeline/thread.c @@ -92,11 +92,9 @@ thread_free(void) continue; /* MSGQs */ - if (t->msgq_req) - rte_ring_free(t->msgq_req); + rte_ring_free(t->msgq_req); - if (t->msgq_rsp) - rte_ring_free(t->msgq_rsp); + rte_ring_free(t->msgq_rsp); } } From patchwork Mon Jan 24 17:46:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106365 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37378A04AD; Mon, 24 Jan 2022 18:48:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B866342804; Mon, 24 Jan 2022 18:47:33 +0100 (CET) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id E985D427F1 for ; Mon, 24 Jan 2022 18:47:29 +0100 (CET) Received: by mail-pg1-f179.google.com with SMTP id f8so16019188pgf.8 for ; Mon, 24 Jan 2022 09:47:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LthoC/aG80CawrgBqgZJqzxV3JgQQrhY5x+zkNuvJwE=; b=LlfDaXCtq+hjCq6l/WWZ4SLgqu4mlwZG3SdgEmKa/iNdo+HzwfZjaCzLwWwKaoKYMc WxADQcRrlR2Kl0p4jJRLz8ojQGweJrtB+hrORU+w6KPr98/+TKRMMkXYVZmWrAPR6zHy BNKQ52iWm72Y59WWjCwbGL01+lW8dMzi8zfcXUgz3oFxrWt1WtJCe4m6SEk63OzEjcKH RVj5+FyABx46T7acuySb/mrXXxnQQVlFVAXFFg1U+GVW+nItAJW85Xba+7kdZT2JpopR 9cDqPQEi+nuhQvprIbYAye9o3Wz1FdMzfsF9YxYbRi2t11gbkihwagupA99+sDcj8ZwG Q10A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LthoC/aG80CawrgBqgZJqzxV3JgQQrhY5x+zkNuvJwE=; b=s2/nBSkPDZ6z54PHUTS/WSP8JJ5gJQoh9stfxcLxdmTaJe1v5x2rI+fAF2fnjhhvox 3cx/cFSa+Bu8bNAuqSYfQYklycMHUtD/k5FOyxXfHY3GLe2yKfvh36xgL7afD6SeSZJp sVLVLo3x4eqMlw6ZGTFegjs9T3wmafmpAX+aAjGGeBNduXXL8R55Gse0T9FDUrKU6vmR taPBCSkbpd/qooVLd4VIdK6OIdiCqV2AF56pYU58RYK43gBtY8q1JKRSwx+9AXrGH3XE zkZ7gTKwWjk9kCSFwjtgOs/TxT7wkieUtiHisVqNW495KG7VZ5tRXJOgWBmH39R8vLA2 iHcw== X-Gm-Message-State: AOAM530fPNmOZJLIiVj1VJlL0tlIzGNcKRuT2fMuKr2MFqYTW43GSLIi HtryN4aykTgZ1rd+geACG8dbRUtK1RuqJw== X-Google-Smtp-Source: ABdhPJwWqu4J55phZaHl3hdSvEVNnzyZhn7e8FVO3/S2q7jpVsvZbeIwFEzrqroO7ZMCW/01jn2fZA== X-Received: by 2002:a05:6a00:15d1:b0:4c1:e1d2:347c with SMTP id o17-20020a056a0015d100b004c1e1d2347cmr14981453pfu.29.1643046448971; Mon, 24 Jan 2022 09:47:28 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:28 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Cristian Dumitrescu Subject: [PATCH v2 07/83] examples/pipeline/thread: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:03 -0800 Message-Id: <20220124174719.14417-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- examples/pipeline/thread.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/examples/pipeline/thread.c b/examples/pipeline/thread.c index bf11e6144b75..5fe7eae00eb6 100644 --- a/examples/pipeline/thread.c +++ b/examples/pipeline/thread.c @@ -89,11 +89,9 @@ thread_free(void) continue; /* MSGQs */ - if (t->msgq_req) - rte_ring_free(t->msgq_req); + rte_ring_free(t->msgq_req); - if (t->msgq_rsp) - rte_ring_free(t->msgq_rsp); + rte_ring_free(t->msgq_rsp); } } From patchwork Mon Jan 24 17:46:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106366 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51517A04AD; Mon, 24 Jan 2022 18:48:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1FB3D42810; Mon, 24 Jan 2022 18:47:35 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id D7BCD427F5 for ; Mon, 24 Jan 2022 18:47:30 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id i1so6646559pla.0 for ; Mon, 24 Jan 2022 09:47:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FX1lbRFpgXCJQC7p1TcjAoI5WAe9NNrSSKSl+pJehBw=; b=220zs+hzdAwKr0UWsYGZ17rrW2th1M/OR9VP/D46Ms5itR29U2UGylVsQvHYvR9MUa yfJ3zG9CYsLh5jTuRaQrbZX6X0ZoiNYSExaOcO94BmmyzSPyQobcwpPo+pCLONFjbNgh EsljuRq8+ubA5PQ7hDoSFU1Y8Q/k6efrHT4FgrgOEPNB0BC7swt15NHVk2/HsnfsZZPW QEJo/NLOvuvKoW3HjU2TyINk2/N66ydBioRzYnixld6ua7Xo9LoR5/ZEiTIUZS7CsRRG oZLiqJkMeGjB4YI+ajw74c81pe37rnLFDZSbPGylcKFC7W4V4oFOgOQWNxynededsP2x m2oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FX1lbRFpgXCJQC7p1TcjAoI5WAe9NNrSSKSl+pJehBw=; b=oZfR++oxd7S5iJqgP9QD5H1E03yJaN6AwFbcd5hnG0YN4FDBWnmUpavo1neWknvZIg Yqun8BC8VkleMBd54fmrg6a2wnXq3FRnVhqqULBdDgy/j8UlnNeX237lxW2yJNY8IKtt xlw2QsUtfAqCD4QNqQcak+gqfucb6orsPeTrol72oyXP9F48cmt6RuS4IfHkgFUh5gNe RFICVpqkMLBS+HwbmO7aY4p1LU2p5Jy1J3ePDLRWCexaqjCYLgTrSjuOACBip/uveBF5 s1A4zTH0jjsZt5tNQOLtVjpxiBC/TaL6GtzYJFqKlnX9KXlos5g/gTgjaKwT4d173E6g 2liA== X-Gm-Message-State: AOAM533VP27VbdSuSKEzIVnTclE/QKEljFYdmpgvM8SIB6Lvf4W+y26G HOU0FqiefJQGcyHA9FHKfFss8Dxh9tUMdQ== X-Google-Smtp-Source: ABdhPJySXhtnmtguj/JH78Eo3RfnOjVOjky1LaTE9kSO1M20LY2s3miNNqIczM09Iv6QWFEsvHpyiQ== X-Received: by 2002:a17:90a:9c2:: with SMTP id 60mr2918897pjo.17.1643046449908; Mon, 24 Jan 2022 09:47:29 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:29 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tomasz Kantecki Subject: [PATCH v2 08/83] examples/l2fwd-cat: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:04 -0800 Message-Id: <20220124174719.14417-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- examples/l2fwd-cat/cat.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/examples/l2fwd-cat/cat.c b/examples/l2fwd-cat/cat.c index 502c6b32780e..77154c8b7e61 100644 --- a/examples/l2fwd-cat/cat.c +++ b/examples/l2fwd-cat/cat.c @@ -872,8 +872,7 @@ cat_fini(void) #if PQOS_VERSION <= 103 memset(m_sockets, 0, sizeof(m_sockets)); #else - if (m_sockets != NULL) - free(m_sockets); + free(m_sockets); #endif m_sock_count = 0; memset(m_config, 0, sizeof(m_config)); From patchwork Mon Jan 24 17:46:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106367 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7D81A04AD; Mon, 24 Jan 2022 18:48:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0899742817; Mon, 24 Jan 2022 18:47:36 +0100 (CET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id 1CB9E427FC for ; Mon, 24 Jan 2022 18:47:32 +0100 (CET) Received: by mail-pl1-f173.google.com with SMTP id z5so2412963plg.8 for ; Mon, 24 Jan 2022 09:47:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+E32WGsBAf6jw7FOSwCo+w81VRzmciXgJ29ENrL+4k0=; b=eRuGLCuRAy6fQMCpIqWkToAxIbQbwC5h9C+IWnpbMYg7ztrdcZLwHKokgrXTGEm3ju ojWovEvAo+0NPekh6dskoYFM0BntLMozveLY9WlxeZp0HTMxkOrHDyMI7DxVYINQxf4b c85p5mHszVN4yVTMMYho+LH6eK8v7A2YPX1i9nfANJD9UunSc7P08AO9SrJMYLFDF2B3 iO/axmSSKVTSqpIzzwYE64YnGB9l/77AXkQjrxoh1/OlQOx7/X09q1tlyVyUAJY2b1A1 Z/eXVpRniFA2/asFXQD57wqRxdiXrqfinrsezVALCNuOkT1T7J8Jq3ZxSDwRYQkBrozp KLnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+E32WGsBAf6jw7FOSwCo+w81VRzmciXgJ29ENrL+4k0=; b=v2LChapTLereqLVLUzp/fjbREjBvNti2aBzI8WTAufLlxzTqLLoa5VcSz57jIb5PRU 51iO5B55ZKxzGTsEMjikN6buLjvIDkfLc9IEt3KomokmwURIgz0nIcmmLW/ESDQexFJ/ Y+H+09xcf1og/Nl1j3cn0VbGSYhKFOtXPSIaiIwYLvC0OcdNjTTVUUQrEH1bX6xOjxRt 2HYkRFv5sQS19obsdQHgZg+iwcI/B2CeDtG98NhBi/nNI4emWNh3Pl7GHj5Rpgi2zJ7e 8BHtykdrdxMrtjnq55h+U/j+erEKCZN7SHVB2QPUEV/81iZAgRCrQ9H8h4exC5Gzxtzx RPcg== X-Gm-Message-State: AOAM530jeTjVhR7RsOsrpzh8azCRBcdnAuLz1WZaGkwApC4U4CTGJY9M 86NM+weYTs/h5k+uj/gx4PaofRMWhbgSvg== X-Google-Smtp-Source: ABdhPJxMxR5ILCN3hDrrtrYyteP62GHq8RS3TJiEb04xSLlX9MtRDuMAnKeK2rMaVdEVQ5KHO+HnGg== X-Received: by 2002:a17:90a:b387:: with SMTP id e7mr2942050pjr.190.1643046451080; Mon, 24 Jan 2022 09:47:31 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:30 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Maxime Coquelin , Chenbo Xia Subject: [PATCH v2 09/83] lib/vhost: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:05 -0800 Message-Id: <20220124174719.14417-10-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Chenbo Xia --- lib/vhost/iotlb.c | 3 +-- lib/vhost/vhost_crypto.c | 6 ++---- lib/vhost/vhost_user.c | 9 +++------ 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/lib/vhost/iotlb.c b/lib/vhost/iotlb.c index 82bdb84526ea..d6b8c0a396b5 100644 --- a/lib/vhost/iotlb.c +++ b/lib/vhost/iotlb.c @@ -315,8 +315,7 @@ vhost_user_iotlb_init(struct virtio_net *dev, int vq_index) /* If already created, free it and recreate */ vq->iotlb_pool = rte_mempool_lookup(pool_name); - if (vq->iotlb_pool) - rte_mempool_free(vq->iotlb_pool); + rte_mempool_free(vq->iotlb_pool); vq->iotlb_pool = rte_mempool_create(pool_name, IOTLB_CACHE_SIZE, sizeof(struct vhost_iotlb_entry), 0, diff --git a/lib/vhost/vhost_crypto.c b/lib/vhost/vhost_crypto.c index 926b5c0bd94a..012e0cefdeba 100644 --- a/lib/vhost/vhost_crypto.c +++ b/lib/vhost/vhost_crypto.c @@ -1498,10 +1498,8 @@ rte_vhost_crypto_create(int vid, uint8_t cryptodev_id, return 0; error_exit: - if (vcrypto->session_map) - rte_hash_free(vcrypto->session_map); - if (vcrypto->mbuf_pool) - rte_mempool_free(vcrypto->mbuf_pool); + rte_hash_free(vcrypto->session_map); + rte_mempool_free(vcrypto->mbuf_pool); rte_free(vcrypto); diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c index 5eb1dd681231..23a0e3fb3600 100644 --- a/lib/vhost/vhost_user.c +++ b/lib/vhost/vhost_user.c @@ -489,8 +489,7 @@ vhost_user_set_vring_num(struct virtio_net **pdev, } if (vq_is_packed(dev)) { - if (vq->shadow_used_packed) - rte_free(vq->shadow_used_packed); + rte_free(vq->shadow_used_packed); vq->shadow_used_packed = rte_malloc_socket(NULL, vq->size * sizeof(struct vring_used_elem_packed), @@ -502,8 +501,7 @@ vhost_user_set_vring_num(struct virtio_net **pdev, } } else { - if (vq->shadow_used_split) - rte_free(vq->shadow_used_split); + rte_free(vq->shadow_used_split); vq->shadow_used_split = rte_malloc_socket(NULL, vq->size * sizeof(struct vring_used_elem), @@ -516,8 +514,7 @@ vhost_user_set_vring_num(struct virtio_net **pdev, } } - if (vq->batch_copy_elems) - rte_free(vq->batch_copy_elems); + rte_free(vq->batch_copy_elems); vq->batch_copy_elems = rte_malloc_socket(NULL, vq->size * sizeof(struct batch_copy_elem), RTE_CACHE_LINE_SIZE, vq->numa_node); From patchwork Mon Jan 24 17:46:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106368 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79C8DA04AD; Mon, 24 Jan 2022 18:48:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 030DB4280B; Mon, 24 Jan 2022 18:47:37 +0100 (CET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 37DBC42802 for ; Mon, 24 Jan 2022 18:47:33 +0100 (CET) Received: by mail-pl1-f172.google.com with SMTP id d18so3622335plg.2 for ; Mon, 24 Jan 2022 09:47:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AKvZb0jmjUHFdNWvNQO2+9sswUBriBoXY4swBNrp1IM=; b=kz/thC+LSsYvtIA2/Gai0fkgn7U128bQRlk01kEcPDqErNAfVXIQVygcJ39zBB8p36 L0B2W/BbV1XaozX+obKZezIQA49zZKVhP+3ztIN6/4WKxh1f3vst8FZ64qqQuXHcvsbW pH33feZ+3fVg2PztSU0Yxk+P4QXpfO2vl2vwWJF6I4KhxqZtZNC2tbiaNJFIGCjatw51 2I3itOca9VDU1beoSrEWKsBKtZVAlzQEk1H3yQTOba1RgzxZ0fyhW1CL+XyLrdvwy/wx o01gTYw4eT+5237k7mYrKO6jpSdmn4by6LZV1PIn6W20lEoDHi1H1xq/WUVmz/Zp8B58 nfoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AKvZb0jmjUHFdNWvNQO2+9sswUBriBoXY4swBNrp1IM=; b=TpNdXCDb1b2J6qhgClo4M8JWfbZwmGGQ8LcGQ+8x+9B11b8+nCBhW+LKRJjW9O3zVW afPDHWtdnizljCOJakSdFGTAmxHp57xDmJNd0Man3t3mFi6Xd4puzlQjqlpQy6rl8+Iv 6Dd/sqCv5PH+2x8OP+4eE7pHMY/L1ZNkYwxcKQSbcEmHT8v5dU7NJadiKlsvPhYNE6Ln MCYXV3aOa69oMBvw04hluixOv4p0wiQaLGBz6Ab6J9kweTBRMisd5EWLVA32UzUTxGtB fmoDd7zYOG8Xa2kAz5j3VJ7Eav8XyleRPddSOq9YCMv8+4AA6rycSmNBrpiXqBUOGtfG YYYA== X-Gm-Message-State: AOAM5322o1/YLuu+jSrfqUeyGreDb6UN4co6HgGxRgj76PgTTbA7aw7f SUoWG8kYKPfJDJ+FHgr/N2Le/HeOD+TvMg== X-Google-Smtp-Source: ABdhPJxNh+C/heB7bbKN0QbWEwf/HcjQjL1QWu/nGb3MKli+AXdEJY/mEIvnnqdfnNxmOjh3g+dXmQ== X-Received: by 2002:a17:90b:17c8:: with SMTP id me8mr2977412pjb.105.1643046452243; Mon, 24 Jan 2022 09:47:32 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:31 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Maxime Coquelin , Chenbo Xia Subject: [PATCH v2 10/83] examples/vhost_blk: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:06 -0800 Message-Id: <20220124174719.14417-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Chenbo Xia --- examples/vhost_blk/vhost_blk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/vhost_blk.c index feadacc62ee5..2cab1e6994fe 100644 --- a/examples/vhost_blk/vhost_blk.c +++ b/examples/vhost_blk/vhost_blk.c @@ -849,8 +849,7 @@ static void vhost_blk_ctrlr_destroy(struct vhost_blk_ctrlr *ctrlr) { if (ctrlr->bdev != NULL) { - if (ctrlr->bdev->data != NULL) - rte_free(ctrlr->bdev->data); + rte_free(ctrlr->bdev->data); rte_free(ctrlr->bdev); } From patchwork Mon Jan 24 17:46:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106369 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B480A04AD; Mon, 24 Jan 2022 18:48:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D290342820; Mon, 24 Jan 2022 18:47:37 +0100 (CET) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 46B4242808 for ; Mon, 24 Jan 2022 18:47:34 +0100 (CET) Received: by mail-pj1-f54.google.com with SMTP id d12-20020a17090a628c00b001b4f47e2f51so18374745pjj.3 for ; Mon, 24 Jan 2022 09:47:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=n1kdZY9bsWP4eeWLNwDfXRD5X13ceHgxBOZuNjBt+3c=; b=tL/Bwz8/rsDUI2myPNMp45NjBn92k0mAVJTd6Z1XXSpqN7ftaaYoUYaqTulvueZ5Us 4bVbL5jToiLFOJtgdY7NVPtT1sLRppLVexZxr4Mkn28LNInkehQ4AP5dAw3YHjDL7Bwh XZkPqugpGHDr6I+qtqbMrRVi4Fr9yWztRP2S4r3fUEhRz6kikryqLWC6IVf1gxN8XQTF l0VLDG6kn6lzjT7Cmkazqn4eg0cl/vAMqalF212l4D2oujM91HAfyzcPoolOStSOCzIS YfDaNt3NVyg6GUjfFIBRa7qtegUJit/JrrGHjXnuC8FIgCZmrNFpZfipU46XjhwKsOQ2 xupw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=n1kdZY9bsWP4eeWLNwDfXRD5X13ceHgxBOZuNjBt+3c=; b=yUInCKHfwII6YQck0/3SgU6QW4nFl5Ub79XM3mNB5W6L2vWalYha4q4jM6WA/VJ2ki bMtSdPUDCzE9+7QqvW0QQwjjtuxE0tCVQHZdrkXKNhoHwulYkp9yF7v8LM8bnXjwNMNP tG33WYPGb/yOZAQvf2b3sGP7ezm3+G6ZkGSjf6cfuPeRGmGllfjv4SbVXsGvS4xz6jaw k9xOtoOcfIiffLdiNi8D79g3kKKJJ+zfc44yf8yYc31Yvac3sqoeEeQCtFRuJ33d5NWO nfONWu0GMeIWZrAZiPooiH8UZpS7/C7c6i5vO/HFr+CD5mgS9DSKLWpXow4/g78M4aph YFRg== X-Gm-Message-State: AOAM532o6asiH7Ek604Ci4qVisdLFQ8ycmTConOZMb3NOhUQNj1gHu5j RqETlwso/2kDgYFTFCujb4r3hJtn0Sugaw== X-Google-Smtp-Source: ABdhPJzXtvm1xvba9NOOrOjM25gSGPiGN+T6kJi5kgcYc6m4nYAAcgFQPEnaUYhi8XQa5J3NhanUag== X-Received: by 2002:a17:902:b083:b0:14a:f06c:aa6b with SMTP id p3-20020a170902b08300b0014af06caa6bmr15222022plr.147.1643046453254; Mon, 24 Jan 2022 09:47:33 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:32 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Reshma Pattan Subject: [PATCH v2 11/83] app/pdump: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:07 -0800 Message-Id: <20220124174719.14417-12-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- app/pdump/main.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index 46f9d25db004..04a38e891119 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -502,14 +502,11 @@ cleanup_rings(void) for (i = 0; i < num_tuples; i++) { pt = &pdump_t[i]; - if (pt->device_id) - free(pt->device_id); + free(pt->device_id); /* free the rings */ - if (pt->rx_ring) - rte_ring_free(pt->rx_ring); - if (pt->tx_ring) - rte_ring_free(pt->tx_ring); + rte_ring_free(pt->rx_ring); + rte_ring_free(pt->tx_ring); } } From patchwork Mon Jan 24 17:46:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106370 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07717A04AD; Mon, 24 Jan 2022 18:48:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D78B442826; Mon, 24 Jan 2022 18:47:38 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 99C0C42813 for ; Mon, 24 Jan 2022 18:47:35 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id z5so2413195plg.8 for ; Mon, 24 Jan 2022 09:47:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XSkqO3NWwTKO3Hpq/cbV6nAa1Tp6L+8voA8mWYxEIDQ=; b=VAoBaxXI5kN4RQZsDFk0c/xrKJSQxD7lu+Uv9vRX2iI9Vsyzi7qvq5JGQrS5pLLch3 305RPEcs7C2SNF76jr181j4LX14WxxWQzvJ60NYEO6vOoz4y1WT4AHotrdHQjO/0rRck dPq+wMf8Q7t4/jfG3iAEi3DWIPRV9wCEINLumnC+3T7HFqvMAKKCvPDWfLkHJnkWdzfa 2IHU25ts3exncV0Fjce/Y36fdthVeJyoz18JIB3OKvTSqhFsbcGuVTRLDuKSog4uORZL QWQ/+j51ctQwZdTtLySUgwLkUFq8arHQI9IilKUB1xHAuisWMimXQq/KgJO6tVKwOegH Kb1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XSkqO3NWwTKO3Hpq/cbV6nAa1Tp6L+8voA8mWYxEIDQ=; b=5belR5GaOAXEhQLL8Kn5sfCTGVvr1PimWjLbeQFM35Ch89RRj583HHUlrPpdc6o33n 3ljiVH4y7WI2sgZW0E7mdpQMQMqtYvJBM6acnFMXxQ/aEqnwUeW+eXsKlYKapvsA959L OEKKG8BIvQPoKdOcpNDwU+EPtyB2o5QFs9Lihl/llGRIrAnotqYSGRDvE8RdHnxr1lrj A+obQ1JT9/bBw8OA6/m/ERJAmDbqkG1FPHApjIe4mE/6JJtTrmwmf36SOq/16hsQzJg/ ibpCfqsrweF0jydCDtUmPH15J9k20QmXtapdS9JunnrNboBPIbo9lL5dLjJexdLaRM+w mB4g== X-Gm-Message-State: AOAM532F7SfTU0NlDnH3nyW9YtqIFzeYMwNtCF8UF3NaKKw16utgBra2 mN5umVDf1NPx7OSgg73WNLzCWxS4XfVQ/Q== X-Google-Smtp-Source: ABdhPJzsaSBb2KLFgEd0ucJDjiqcp9LCmvklprHAliTRuxiMIyqpLjfPXiCEbZTuVUDPf5uvZMtE3g== X-Received: by 2002:a17:902:6b02:b0:149:9c7d:3ae7 with SMTP id o2-20020a1709026b0200b001499c7d3ae7mr15283121plk.51.1643046454648; Mon, 24 Jan 2022 09:47:34 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:34 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ciara Power , Declan Doherty Subject: [PATCH v2 12/83] app/test-crypto-perf: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:08 -0800 Message-Id: <20220124174719.14417-13-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Ciara Power --- app/test-crypto-perf/cperf_test_latency.c | 3 +-- app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 9 +++------ app/test-crypto-perf/cperf_test_throughput.c | 3 +-- app/test-crypto-perf/cperf_test_vector_parsing.c | 6 ++---- app/test-crypto-perf/cperf_test_verify.c | 3 +-- 5 files changed, 8 insertions(+), 16 deletions(-) diff --git a/app/test-crypto-perf/cperf_test_latency.c b/app/test-crypto-perf/cperf_test_latency.c index ce49feaba9f3..4c7bc72eb5fd 100644 --- a/app/test-crypto-perf/cperf_test_latency.c +++ b/app/test-crypto-perf/cperf_test_latency.c @@ -49,8 +49,7 @@ cperf_latency_test_free(struct cperf_latency_ctx *ctx) rte_cryptodev_sym_session_free(ctx->sess); } - if (ctx->pool) - rte_mempool_free(ctx->pool); + rte_mempool_free(ctx->pool); rte_free(ctx->res); rte_free(ctx); diff --git a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c index 5842f29d43e2..6b4d09e623eb 100644 --- a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c +++ b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c @@ -79,14 +79,11 @@ cperf_pmd_cyclecount_test_free(struct cperf_pmd_cyclecount_ctx *ctx) } } - if (ctx->pool) - rte_mempool_free(ctx->pool); + rte_mempool_free(ctx->pool); - if (ctx->ops) - rte_free(ctx->ops); + rte_free(ctx->ops); - if (ctx->ops_processed) - rte_free(ctx->ops_processed); + rte_free(ctx->ops_processed); rte_free(ctx); } diff --git a/app/test-crypto-perf/cperf_test_throughput.c b/app/test-crypto-perf/cperf_test_throughput.c index 51512af2ad81..51fad5a05505 100644 --- a/app/test-crypto-perf/cperf_test_throughput.c +++ b/app/test-crypto-perf/cperf_test_throughput.c @@ -57,8 +57,7 @@ cperf_throughput_test_free(struct cperf_throughput_ctx *ctx) rte_cryptodev_sym_session_free(ctx->sess); } } - if (ctx->pool) - rte_mempool_free(ctx->pool); + rte_mempool_free(ctx->pool); rte_free(ctx); } diff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c b/app/test-crypto-perf/cperf_test_vector_parsing.c index 1e9dfcfff087..87f3a90055aa 100644 --- a/app/test-crypto-perf/cperf_test_vector_parsing.c +++ b/app/test-crypto-perf/cperf_test_vector_parsing.c @@ -551,10 +551,8 @@ parse_file(struct cperf_test_vector *vector, struct cperf_options *opts) err: if (fp) fclose(fp); - if (line) - free(line); - if (entry) - rte_free(entry); + free(line); + rte_free(entry); return -1; } diff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c index 496eb0de00f0..c031330afcfe 100644 --- a/app/test-crypto-perf/cperf_test_verify.c +++ b/app/test-crypto-perf/cperf_test_verify.c @@ -42,8 +42,7 @@ cperf_verify_test_free(struct cperf_verify_ctx *ctx) rte_cryptodev_sym_session_free(ctx->sess); } - if (ctx->pool) - rte_mempool_free(ctx->pool); + rte_mempool_free(ctx->pool); rte_free(ctx); } From patchwork Mon Jan 24 17:46:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106371 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 088BCA04AD; Mon, 24 Jan 2022 18:48:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C14BF4282E; Mon, 24 Jan 2022 18:47:39 +0100 (CET) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 233A04281D for ; Mon, 24 Jan 2022 18:47:37 +0100 (CET) Received: by mail-pf1-f181.google.com with SMTP id 192so13238951pfz.3 for ; Mon, 24 Jan 2022 09:47:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Bqx1QikgD2/KxHs/wk6/R5yXCp85ron8ncDQ9vvSGQU=; b=GbkxgaXp/fRgtcJ/RW7KltB2CwwQEUAaehPejDsnCANYdDkfphPiq8FEw4bRpPyCLE E2d6Z6Cyr4x1CtYRwHUg5Aa1D7ws6G8RcqpMNVj/QS5GB4vxRPfmED0Pr9XVdeTDG+I9 KbKT0DqOrgrgEw31OlWfNlmEvCtOSfaOw9nBSOjo4izTVFz+dX6z109i6uQVH5YBZpWd SOzAIAD96xw3mnziU9jY9+cNIjoHeGB7cUXRfL5h6WP+g+8988Zjg99EbYBwJlNhkkDs +kprbx1mpGfRxnxq//091yvviPHPRe/8FLB5Ckv/X9HvCEhBQmm8G2gMiIQf/xzs8iIk VS4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Bqx1QikgD2/KxHs/wk6/R5yXCp85ron8ncDQ9vvSGQU=; b=Gq9jp2S9VYX1P8WkTqiVsQDvkHpSjblh+GzndsiLdxgM9JmE0UIjLJBjdaueJbREzV 12u+mJu0XiVR3vHtOwI5IFmq2cVZe9jskd91XQB/jGQXpqyNc4LJFap42zWtIjziAFf5 5+B+f1TMOf6NJvrObSef4RUCX/yQh03K9GQ23YODAIYYmYWKLNScA6uUHZCXwWatwzgC j5T+JDe+VOjmCb3YEWdghIjoT7BJBVdLC5v+2wwz8tAcTtReJs4W2JCudu8L5B0r9PH0 4Cix78giIrZQnwYVqxvQe6dWnfAtfCtRq/XR0Y7AKHh3ClBwwa6tROU/vei1G70oLigq yCtw== X-Gm-Message-State: AOAM530OvT6sQ9j2ddynr6p/WSDlo2dskfMgL5yxCg2hXtw6mUAxi+YB dnGOIBT292qH97AUN/ECnOyU3DhYOdJuzQ== X-Google-Smtp-Source: ABdhPJxJfVAE6Haz6grILm1gJeYsn/fvCs+Jyxt8a23vFwY/9G08kub8BYaLmSHkLwQtwlHZMn6Gzg== X-Received: by 2002:a05:6a00:1892:b0:4c8:fdfd:a648 with SMTP id x18-20020a056a00189200b004c8fdfda648mr6032437pfh.58.1643046456145; Mon, 24 Jan 2022 09:47:36 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:35 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Xiaoyun Li , Aman Singh , Yuying Zhang Subject: [PATCH v2 13/83] app/test-pmd: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:09 -0800 Message-Id: <20220124174719.14417-14-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- app/test-pmd/cmd_flex_item.c | 3 +-- app/test-pmd/cmdline.c | 3 +-- app/test-pmd/testpmd.c | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmd_flex_item.c b/app/test-pmd/cmd_flex_item.c index 908bcb3f47f8..9050825a81d7 100644 --- a/app/test-pmd/cmd_flex_item.c +++ b/app/test-pmd/cmd_flex_item.c @@ -364,8 +364,7 @@ flex_item_create(portid_t port_id, uint16_t flex_id, const char *filename) flow_error.message ? flow_error.message : ""); } out: - if (fp) - free(fp); + free(fp); } #else /* RTE_HAS_JANSSON */ diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index e626b1c7d9ee..298a594e709b 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -14696,8 +14696,7 @@ cmd_ddp_info_parsed( ret = 0; no_print_return: - if (proto) - free(proto); + free(proto); #endif if (ret == -ENOTSUP) fprintf(stderr, "Function not supported in PMD\n"); diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 6c387bde84e5..31efa0fe61e5 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -902,8 +902,7 @@ create_extmem(uint32_t nb_mbufs, uint32_t mbuf_sz, struct extmem_param *param, return 0; fail: - if (iovas) - free(iovas); + free(iovas); if (addr) munmap(addr, mem_sz); From patchwork Mon Jan 24 17:46:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106372 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 261D0A04AD; Mon, 24 Jan 2022 18:48:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C484D42839; Mon, 24 Jan 2022 18:47:40 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 2E3DF427EB for ; Mon, 24 Jan 2022 18:47:38 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d7so16298004plr.12 for ; Mon, 24 Jan 2022 09:47:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m5u8SZbeHnKwO+LR0Tf92LX8t/vOCtPZna+YbxalHH8=; b=07YaDAlIObgqceWisJFV7mkTrQKINu8PZZTcYWbJLoPyAcZ9awsqI0gDZqW8gEdRVl hXyeppY9C9Aggg+SUc4wv83w+w6+slsAr637/AccIveoX9+hTtOkt/bnGonlq8SLC67d GaBSuYxLGrU6WjD6aAcKXVg4B7oZQUzJP2QM+jHNK9a3WlC6HJdsCKU36Kdss7X+ff55 ntXe9whWbpesdOFGC+vIt5hmpW7sWduUPR0fH0DokL2HUaRfhbE0icOIWLxoIa/r55vb cuaqcgoqg7h6A8T6Dn3JPYz5jch/UVnvV0ZfPE3QvEhKnrjqCZNDRVN+/FWJC2el9+dJ WxVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m5u8SZbeHnKwO+LR0Tf92LX8t/vOCtPZna+YbxalHH8=; b=i+wuebyY35tZbG8gvJUooBu7X28haFaU/sP2dOTAkMVCzQ1iaVHfrFZ4C81j6QwBI2 wjSm580p6V/Md+qSyQR79ZkU/5ICA/wYTPFr+XdNICzn4l8zcLzlQr6eSjCXXGJ7NMCL 99eEi+DKGDxp0aEzV8pfjaYOLZSDN2kRX2Vh4LexDOjmw2fhn1KK0SeA0hL1S00L+vXC O7x9C7Clyp6Q91G0XQJi3uK5KD83FydAUfB22KOY4QGAKK5hb1NFWxfB2eZuUhn4svUb 5DJjbT2IHfYv20Gq/xbCLTkc6c0Culrkto2unWwhzbhR5RfZtftLgCKBek2XJYP3fGHn mBHA== X-Gm-Message-State: AOAM533tz2qWcf6+JnhYBFsp/QkpNUnF/7sPZaepS/CVrUI1oroQC3v9 0sjbLxMzbi8lfL20pDguNjiInqbzTBrBSg== X-Google-Smtp-Source: ABdhPJyc4kuG3yOnPeA/0dvE49XwTL7F02CaKfyO5ONAd2duqCGGK2K7Qv0+BXG3oVi/umhmU+DJEQ== X-Received: by 2002:a17:90b:4f84:: with SMTP id qe4mr2998441pjb.24.1643046457096; Mon, 24 Jan 2022 09:47:37 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:36 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ori Kam Subject: [PATCH v2 14/83] app/test-regex: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:10 -0800 Message-Id: <20220124174719.14417-15-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- app/test-regex/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/app/test-regex/main.c b/app/test-regex/main.c index 8e665df73ce0..ab8a3e56e774 100644 --- a/app/test-regex/main.c +++ b/app/test-regex/main.c @@ -210,8 +210,7 @@ read_file(char *file, char **buf) printf("Error, can't open file %s\n, err = %d", file, res); if (fp) fclose(fp); - if (*buf) - rte_free(*buf); + rte_free(*buf); return -res; } @@ -299,8 +298,7 @@ init_port(uint16_t *nb_max_payload, char *rules_file, uint8_t *nb_max_matches, rte_free(rules); return 0; error: - if (rules) - rte_free(rules); + rte_free(rules); return res; } @@ -367,8 +365,7 @@ regex_create_segmented_mbuf(struct rte_mempool *mbuf_pool, int pkt_len, return mbuf; fail: - if (mbuf) - rte_pktmbuf_free(mbuf); + rte_pktmbuf_free(mbuf); return NULL; } @@ -612,8 +609,7 @@ run_regex(void *args) rte_free(qp->buf); qp->buf = NULL; } - if (mbuf_mp) - rte_mempool_free(mbuf_mp); + rte_mempool_free(mbuf_mp); rte_free(qps); return res; } From patchwork Mon Jan 24 17:46:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106373 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F99FA04AD; Mon, 24 Jan 2022 18:48:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A82DE4283F; Mon, 24 Jan 2022 18:47:41 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 8152E42828 for ; Mon, 24 Jan 2022 18:47:39 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id u11so16306490plh.13 for ; Mon, 24 Jan 2022 09:47:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hUi3jdycirbvMNlR/2jM4YhZ1CLXWJRlA9QQxRgryBs=; b=h5Pna2MDTOK8wd/nT60Fy709Uu76Z0ETdGGNoBNlZoY6ZvjnUfjzQuxSoYt06w+aID XoVma9sdi7pgbYP5uqMJg98D9ncxNegtDF+fpLIuu8Ki4XvZx4Wf6z+5v3OY5NdS8k89 OohQXMeinHeYDvvR1jcoi3EK8t2QkjFlgs62jlfqR8Afq44ylDf1MPsIAWHa33zGlJNd 0HE8ynKwc5bAoZKv7hOtdYKkefa0LegcMPcl3mMsOIqHYf5cMETWMyZV98ilTUTdBXlo 8jatsJuL01rgLy7fY0Oc1PptveRP49GX6LoHJxBWS6WvnI25gJos2519Qb46CBR9KwK7 WmWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hUi3jdycirbvMNlR/2jM4YhZ1CLXWJRlA9QQxRgryBs=; b=NS+ncmAg+4GRx9cm/ntM1tx23s7MuQwXxis/f52uDpLD4wgmLKjl888v0tJpdU91XS e/9AWs5hMviWN0ckK7oTBV40r2NobQZx4td++YpWELOguBK6VRLM1Usz8enRFIqIV+iC javSObusYZiqKEqluLUn2HvehWgfngJSAg9QDcfHc88twoKhWxeM1M+3NWWYbnaQ6df4 ZYPG3g010Aecavg+wA3SIUEeA92FGesJFBh6W63Wu3L7wrQY+RcMQZ2pwBeMZMPv0ilO gul810/+aztP6aIsTh+GkufigVBTHA3il/GQ/H440t1hSf2LnXSk3EhqDK5+S2bQwxb1 n3Bg== X-Gm-Message-State: AOAM533UKMLZaVjc8BGGdWM3le6m33JSCu9OZveppM/XTCQM3Iaonp6e hX+yQIS+dWHmBQgWpwkMLFfuCXlXSWOn4g== X-Google-Smtp-Source: ABdhPJyqKPuHWd8qUXKerYbvU9U1iF4am1ea6u6e4FmrSSDpGY2xh3+t5TQP9K4RF5u586NT5VFxlQ== X-Received: by 2002:a17:90b:4b42:: with SMTP id mi2mr2999364pjb.243.1643046458443; Mon, 24 Jan 2022 09:47:38 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:37 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Olivier Matz , Fan Zhang , Ashish Gupta , Akhil Goyal , Declan Doherty , Bruce Richardson , Vladimir Medvedkin , Yipeng Wang , Sameh Gobriel , Honnappa Nagarahalli , Konstantin Ananyev , Andrew Rybchenko , Anatoly Burakov , Chas Williams , "Min Hu (Connor)" , Reshma Pattan Subject: [PATCH v2 15/83] app/test: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:11 -0800 Message-Id: <20220124174719.14417-16-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- app/test/test_cksum.c | 3 +- app/test/test_compressdev.c | 3 +- app/test/test_cryptodev.h | 3 +- app/test/test_cryptodev_asym.c | 3 +- app/test/test_cryptodev_blockcipher.c | 12 +++---- app/test/test_func_reentrancy.c | 15 +++------ app/test/test_hash.c | 15 +++------ app/test/test_hash_perf.c | 7 +---- app/test/test_link_bonding.c | 9 ++---- app/test/test_link_bonding_mode4.c | 3 +- app/test/test_malloc.c | 5 ++- app/test/test_mbuf.c | 45 +++++++++------------------ app/test/test_pcapng.c | 3 +- app/test/test_reorder.c | 15 +++------ app/test/virtual_pmd.c | 3 +- 15 files changed, 47 insertions(+), 97 deletions(-) diff --git a/app/test/test_cksum.c b/app/test/test_cksum.c index cd983d7c01ce..6c15de9a9312 100644 --- a/app/test/test_cksum.c +++ b/app/test/test_cksum.c @@ -218,8 +218,7 @@ test_l4_cksum(struct rte_mempool *pktmbuf_pool, const char *pktdata, size_t len) return 0; fail: - if (m) - rte_pktmbuf_free(m); + rte_pktmbuf_free(m); return -1; } diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c index 57c566aa9229..fbecaf9aaad4 100644 --- a/app/test/test_compressdev.c +++ b/app/test/test_compressdev.c @@ -2144,8 +2144,7 @@ test_deflate_comp_decomp(const struct interim_data_params *int_data, if (stream != NULL) rte_compressdev_stream_free(0, stream); - if (all_decomp_data != NULL) - rte_free(all_decomp_data); + rte_free(all_decomp_data); /* Free compress private xforms */ for (i = 0; i < test_priv_data.num_priv_xforms; i++) { diff --git a/app/test/test_cryptodev.h b/app/test/test_cryptodev.h index 70f23a3f67d0..29a7d4db2b10 100644 --- a/app/test/test_cryptodev.h +++ b/app/test/test_cryptodev.h @@ -230,8 +230,7 @@ create_segmented_mbuf(struct rte_mempool *mbuf_pool, int pkt_len, return mbuf; fail: - if (mbuf) - rte_pktmbuf_free(mbuf); + rte_pktmbuf_free(mbuf); return NULL; } diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index 68f4d8e7a6f9..8c68a12d74b2 100644 --- a/app/test/test_cryptodev_asym.c +++ b/app/test/test_cryptodev_asym.c @@ -518,8 +518,7 @@ test_cryptodev_asym_op(struct crypto_testsuite_params_asym *ts_params, if (op != NULL) rte_crypto_op_free(op); - if (result != NULL) - rte_free(result); + rte_free(result); return status; } diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/test_cryptodev_blockcipher.c index 5688a45377b2..127e2a53d379 100644 --- a/app/test/test_cryptodev_blockcipher.c +++ b/app/test/test_cryptodev_blockcipher.c @@ -805,20 +805,16 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t, rte_cryptodev_sym_session_clear(dev_id, sess); rte_cryptodev_sym_session_free(sess); } - if (cipher_xform) - rte_free(cipher_xform); - if (auth_xform) - rte_free(auth_xform); + rte_free(cipher_xform); + rte_free(auth_xform); } if (op) rte_crypto_op_free(op); - if (obuf) - rte_pktmbuf_free(obuf); + rte_pktmbuf_free(obuf); - if (ibuf) - rte_pktmbuf_free(ibuf); + rte_pktmbuf_free(ibuf); return status; } diff --git a/app/test/test_func_reentrancy.c b/app/test/test_func_reentrancy.c index ce40c3ce9631..64f27e20370f 100644 --- a/app/test/test_func_reentrancy.c +++ b/app/test/test_func_reentrancy.c @@ -89,15 +89,13 @@ ring_clean(unsigned int lcore_id) int i; rp = rte_ring_lookup("fr_test_once"); - if (rp != NULL) - rte_ring_free(rp); + rte_ring_free(rp); for (i = 0; i < MAX_ITER_MULTI; i++) { snprintf(ring_name, sizeof(ring_name), "fr_test_%d_%d", lcore_id, i); rp = rte_ring_lookup(ring_name); - if (rp != NULL) - rte_ring_free(rp); + rte_ring_free(rp); } } @@ -152,15 +150,13 @@ mempool_clean(unsigned int lcore_id) int i; mp = rte_mempool_lookup("fr_test_once"); - if (mp != NULL) - rte_mempool_free(mp); + rte_mempool_free(mp); for (i = 0; i < MAX_ITER_MULTI; i++) { snprintf(mempool_name, sizeof(mempool_name), "fr_test_%d_%d", lcore_id, i); mp = rte_mempool_lookup(mempool_name); - if (mp != NULL) - rte_mempool_free(mp); + rte_mempool_free(mp); } } @@ -215,8 +211,7 @@ hash_clean(unsigned lcore_id) int i; handle = rte_hash_find_existing("fr_test_once"); - if (handle != NULL) - rte_hash_free(handle); + rte_hash_free(handle); for (i = 0; i < MAX_ITER_MULTI; i++) { snprintf(hash_name, sizeof(hash_name), "fr_test_%d_%d", lcore_id, i); diff --git a/app/test/test_hash.c b/app/test/test_hash.c index b99e8de1db71..d522cb7f8cbf 100644 --- a/app/test/test_hash.c +++ b/app/test/test_hash.c @@ -1654,8 +1654,7 @@ test_hash_add_delete_jhash2(void) ret = 0; fail_jhash2: - if (handle != NULL) - rte_hash_free(handle); + rte_hash_free(handle); return ret; } @@ -1689,8 +1688,7 @@ test_hash_add_delete_2_jhash2(void) ret = 0; fail_2_jhash2: - if (handle != NULL) - rte_hash_free(handle); + rte_hash_free(handle); return ret; } @@ -1754,8 +1752,7 @@ test_hash_add_delete_jhash_1word(void) ret = 0; fail_jhash_1word: - if (handle != NULL) - rte_hash_free(handle); + rte_hash_free(handle); return ret; } @@ -1789,8 +1786,7 @@ test_hash_add_delete_jhash_2word(void) ret = 0; fail_jhash_2word: - if (handle != NULL) - rte_hash_free(handle); + rte_hash_free(handle); return ret; } @@ -1824,8 +1820,7 @@ test_hash_add_delete_jhash_3word(void) ret = 0; fail_jhash_3word: - if (handle != NULL) - rte_hash_free(handle); + rte_hash_free(handle); return ret; } diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c index 76cdac5d5320..287f486316f1 100644 --- a/app/test/test_hash_perf.c +++ b/app/test/test_hash_perf.c @@ -106,12 +106,7 @@ create_table(unsigned int with_data, unsigned int table_index, ut_params.key_len = hashtest_key_lens[table_index]; ut_params.socket_id = rte_socket_id(); h[table_index] = rte_hash_find_existing(name); - if (h[table_index] != NULL) - /* - * If table was already created, free it to create it again, - * so we force it is empty - */ - rte_hash_free(h[table_index]); + rte_hash_free(h[table_index]); h[table_index] = rte_hash_create(&ut_params); if (h[table_index] == NULL) { printf("Error creating table\n"); diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index dc6fc46b9c93..82a9b8e01a82 100644 --- a/app/test/test_link_bonding.c +++ b/app/test/test_link_bonding.c @@ -1639,8 +1639,7 @@ test_roundrobin_rx_burst_on_single_slave(void) /* free mbufs */ for (i = 0; i < MAX_PKT_BURST; i++) { - if (rx_pkt_burst[i] != NULL) - rte_pktmbuf_free(rx_pkt_burst[i]); + rte_pktmbuf_free(rx_pkt_burst[i]); } @@ -1722,8 +1721,7 @@ test_roundrobin_rx_burst_on_multiple_slaves(void) /* free mbufs */ for (i = 0; i < MAX_PKT_BURST; i++) { - if (rx_pkt_burst[i] != NULL) - rte_pktmbuf_free(rx_pkt_burst[i]); + rte_pktmbuf_free(rx_pkt_burst[i]); } /* Clean up and remove slaves from bonded device */ @@ -2010,8 +2008,7 @@ test_roundrobin_verify_slave_link_status_change_behaviour(void) /* free mbufs */ for (i = 0; i < MAX_PKT_BURST; i++) { - if (rx_pkt_burst[i] != NULL) - rte_pktmbuf_free(rx_pkt_burst[i]); + rte_pktmbuf_free(rx_pkt_burst[i]); } /* Clean up and remove slaves from bonded device */ diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c index 351129de2f9b..d9b9c323c7f8 100644 --- a/app/test/test_link_bonding_mode4.c +++ b/app/test/test_link_bonding_mode4.c @@ -194,8 +194,7 @@ free_pkts(struct rte_mbuf **pkts, uint16_t count) uint16_t i; for (i = 0; i < count; i++) { - if (pkts[i] != NULL) - rte_pktmbuf_free(pkts[i]); + rte_pktmbuf_free(pkts[i]); } } diff --git a/app/test/test_malloc.c b/app/test/test_malloc.c index 6d9249f831be..d424d7808af3 100644 --- a/app/test/test_malloc.c +++ b/app/test/test_malloc.c @@ -812,7 +812,7 @@ test_zero_aligned_alloc(void) err_return: /*clean up */ - if (p1) rte_free(p1); + rte_free(p1); return -1; } @@ -865,8 +865,7 @@ test_malloc_bad_params(void) err_return: /* clean up pointer */ - if (bad_ptr) - rte_free(bad_ptr); + rte_free(bad_ptr); return -1; } diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index f54d1d7c006a..daebf09d44b7 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -304,8 +304,7 @@ test_one_pktmbuf(struct rte_mempool *pktmbuf_pool) return 0; fail: - if (m) - rte_pktmbuf_free(m); + rte_pktmbuf_free(m); return -1; } @@ -416,12 +415,9 @@ testclone_testupdate_testdetach(struct rte_mempool *pktmbuf_pool, return 0; fail: - if (m) - rte_pktmbuf_free(m); - if (clone) - rte_pktmbuf_free(clone); - if (clone2) - rte_pktmbuf_free(clone2); + rte_pktmbuf_free(m); + rte_pktmbuf_free(clone); + rte_pktmbuf_free(clone2); return -1; } @@ -572,12 +568,9 @@ test_pktmbuf_copy(struct rte_mempool *pktmbuf_pool, return 0; fail: - if (m) - rte_pktmbuf_free(m); - if (copy) - rte_pktmbuf_free(copy); - if (copy2) - rte_pktmbuf_free(copy2); + rte_pktmbuf_free(m); + rte_pktmbuf_free(copy); + rte_pktmbuf_free(copy2); return -1; } @@ -679,12 +672,9 @@ test_attach_from_different_pool(struct rte_mempool *pktmbuf_pool, return 0; fail: - if (m) - rte_pktmbuf_free(m); - if (clone) - rte_pktmbuf_free(clone); - if (clone2) - rte_pktmbuf_free(clone2); + rte_pktmbuf_free(m); + rte_pktmbuf_free(clone); + rte_pktmbuf_free(clone2); return -1; } @@ -722,8 +712,7 @@ test_pktmbuf_pool(struct rte_mempool *pktmbuf_pool) } /* free them */ for (i=0; i X-Patchwork-Id: 106374 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD1C9A04AD; Mon, 24 Jan 2022 18:48:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98B2E42842; Mon, 24 Jan 2022 18:47:43 +0100 (CET) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id 5DC2842834 for ; Mon, 24 Jan 2022 18:47:40 +0100 (CET) Received: by mail-pj1-f47.google.com with SMTP id l16so17143154pjl.4 for ; Mon, 24 Jan 2022 09:47:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Bgx/O/LgDBwfpZvv8sHETKfu+pFk8tRr98NibVIB3lI=; b=RjrYDiirJIeEqNxfCluDISacF8QhMsQLc1MAsu7MVMlk/JNgoHJh4gi6/2hQjhGCyI CRjQphpk+cM4v+Qn02seK8vx5gqsPTsQvfI3aJ6sLV2wGxPb7p4i5YO95NTMOhscRbdt 5Oh0V+sxwVutBOdPpGsbfThldkssK1rJWhc5ETzFQOlLRsVITCEsDE/TZgsS6Kl9mi/u ZdvJqKUrj0HiPWQXPaNewsVfLcDjzmwiI8m6kgT/uC/nghR/oV1hDWQBo5CccrqujnjF VoTvujkPL6XO7t1QKkbnIn4tX1sbVdQiPNB7HmhYTqmuvZtHMMf9bxoT/vGBXdCncV8Z IHJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Bgx/O/LgDBwfpZvv8sHETKfu+pFk8tRr98NibVIB3lI=; b=jUfRF0RXT5Un4J4dN8oJ8Nm7E8lw6tZIdUK6FTz8LQUv6hDB/u3bbuhn/5xXFok0pE YzpvL11V2jOGMRas44h13VP6LXONZjFwBV5YUZNkRtvONcdckw30ssC/oW6QyZxArWTK s0iGNFY45q5g15Hk5pljgnjFEgll+ZBT3JSkEmsEaaDMQxrdzFgT8DUdgHcBTx4IaVIH K+PwsKKrGnMCMOEt4lPKsC/xZpaNjzIhFwCYNIkOrApUgzPRlpo2lxQmr7qXk9R0X3PM 16810aUqclGFXM2eBmvDFcW94lO0qIglqu3GZQlB1+x9cSTVmI2lI50RzUibOK3wAThA MPnw== X-Gm-Message-State: AOAM531el5n38V1/PAY8xUhEmABu2LBSNtBKfFRTHulpw6cDVyyN0eg7 azTZcpjqX3l+muO5GddWfXEF610zCQEwag== X-Google-Smtp-Source: ABdhPJz/w5b1nUfyUxK7XjO5tttT0Pgf7+tWUC8qwsPcIxSxUO6w3H8aYfnG/SvAkd9F14ONEUQu1g== X-Received: by 2002:a17:90b:3a8b:: with SMTP id om11mr2954129pjb.176.1643046459383; Mon, 24 Jan 2022 09:47:39 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:38 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nicolas Chautru Subject: [PATCH v2 16/83] baseband/acc100 remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:12 -0800 Message-Id: <20220124174719.14417-17-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/baseband/acc100/rte_acc100_pmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c index 1c6080f2f895..f86474f7e099 100644 --- a/drivers/baseband/acc100/rte_acc100_pmd.c +++ b/drivers/baseband/acc100/rte_acc100_pmd.c @@ -4402,8 +4402,7 @@ poweron_cleanup(struct rte_bbdev *bbdev, struct acc100_device *d, } printf("Number of 5GUL engines %d\n", numEngines); - if (d->sw_rings_base != NULL) - rte_free(d->sw_rings_base); + rte_free(d->sw_rings_base); usleep(ACC100_LONG_WAIT); } From patchwork Mon Jan 24 17:46:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106375 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0069A04AD; Mon, 24 Jan 2022 18:49:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86B7442847; Mon, 24 Jan 2022 18:47:44 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 4B6FC4283D for ; Mon, 24 Jan 2022 18:47:41 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id s2-20020a17090ad48200b001b501977b23so16476762pju.2 for ; Mon, 24 Jan 2022 09:47:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P0lQGsisEIBZJwoC6iNSlGBNA3J4/Jrt6WJk9imWfdc=; b=QxQptXaKqSO0fJNnp3DQr/mOCkB5cqImnd9D53fZgzaI6noRzJ5/gPGacaj9KFOdzc 0HOwvxtT5fGV403a9WqmCr4Z2o5LGdAvMtaqCozi5TMVkINtJMVmBpglV9kuy1G/7Adk h3C9FcBMHw+Thz03RJxAcX0Oy9DSR3AyVi0p8fZs1QuST1qhUg28rBeCPkR2Sl1tr44S Pg2/mNIWkRBkK9mityfGPk6QxNWUhFAb4d+r3IwnwhSZd8+BF2LD0O9OThowwxB9Qnkz G8KOEtRLTbWMyLIlTWkoHHUKsBs3WhDF5ZRpdsxCOnzupiFzoiLsUZ95aP4t366hSc6h GbyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P0lQGsisEIBZJwoC6iNSlGBNA3J4/Jrt6WJk9imWfdc=; b=yNl259zB7ppTAVjcmVad6dL58DzCCmvhFz3uzC3HIpMJ2sbuPuu12jQ0zHxLXxU338 LW4TaaBKPuM0WUWDuev6D8Ivs5EKx4+v23Gnsam2yZm+WuDSwdvys7ZBSDqLT7Umpl2O T9aQzoEvUvNldJybA7Wll1YD0lL/czGMzkpxIPu0xQfYVGmq/QiS7+uv2/HJyFrw4F0G XvdX24F0VvZDLoUga4+cUrzaxUTz0EbBHthcz4Rnw4WxnnIWXoYSYtonITVfrNQlC878 Ya1xgOM/GyOw8otg84UJaNFwDZTTw/DHYnF2HNKgNivPKQEMg7QcJvRPfRlTh+SbfFml gPuQ== X-Gm-Message-State: AOAM532lz6YeZxxxm27hykOxzKzT+7DmcigicmhEjR4WtjLvQ4pMbbvJ gvZBe1ZAl8w/olxaIFzl9zvicJZ20d9qfg== X-Google-Smtp-Source: ABdhPJzn8nnhZz3/VPJPChlJNod4Oou47Fktxb3KLnV9Cs0us/GkNf8S18+ULG+8jIIVHVA2flx6ww== X-Received: by 2002:a17:90a:5994:: with SMTP id l20mr2933908pji.121.1643046460319; Mon, 24 Jan 2022 09:47:40 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:39 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Nipun Gupta , Nicolas Chautru Subject: [PATCH v2 17/83] baseband/la12xx remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:13 -0800 Message-Id: <20220124174719.14417-18-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/drivers/baseband/la12xx/bbdev_la12xx.c index 4b05b5d3f2a6..4d1bd16751fe 100644 --- a/drivers/baseband/la12xx/bbdev_la12xx.c +++ b/drivers/baseband/la12xx/bbdev_la12xx.c @@ -975,8 +975,7 @@ parse_bbdev_la12xx_params(struct bbdev_la12xx_params *params, } exit: - if (kvlist) - rte_kvargs_free(kvlist); + rte_kvargs_free(kvlist); return ret; } From patchwork Mon Jan 24 17:46:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106376 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC800A04AD; Mon, 24 Jan 2022 18:49:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82F044284D; Mon, 24 Jan 2022 18:47:45 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 578B042842 for ; Mon, 24 Jan 2022 18:47:42 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id z5so2413620plg.8 for ; Mon, 24 Jan 2022 09:47:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7dLcdElfzX+mIIMFYvrzIDGxa7M6PkJIWm7Sq0z15pQ=; b=cwS7FjBEah6IbysYWYejUGktKgQHyf/5CUqVuH9DRZYFihVX5cKGix/9HEeiDogaYC CZm/pPCV7GViPwAoFiLCVmgv9QSktx94M76vS6DnCSDucAHZmnUv85ZJ4fJ38yUH4lcc boW8gyRsXKnji26oNDhvaGNMskQS1TBqEvRqeUGraXE1jkMoFCP6d9jH1C/cPXmipKnE F9Iylz71+yRm0mBzByGvhP5F1nVISM4LAvidRNZwgGfIGCVHnmlykPgM/i/DGyJey70H e4bb6+8FdumRdqh5jBEdFleR2m4oYcWh4eFxdUYXjbSDVRpmkKwSgtTROwAJ4KnMs4lq 2EQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7dLcdElfzX+mIIMFYvrzIDGxa7M6PkJIWm7Sq0z15pQ=; b=abJL+KOu1ENNMcd5g6Zzy0cUezy/qdyJAqbUm5/XrlzrCbVBVQFt4I3oKmPVYt/+bc f6fOLL9VGqz8Q60HPJ7c4XqC5ZwYfBxqRFPO6E+BSzz37Ahoi2WVRO1YAbOpaG1OHqG7 ggKdy+grx1XarQoYnnz1uesWcrsGEXlMaPkwecaaS/VjAmxy1ug6oQL9LVui/49wXjTQ YzPxx3FRTJoiREGblRGpML2OcH3u9+Jw1FhDmQ3c+a3C9vroi54UvknDI/Mw6Y7L2tnD +i3L+0XKjGjHi1tixhcHEPxdv/py391KguapXSZs1SiRbRbPUAOliF9OEMNNBMqYIPor 2Dyw== X-Gm-Message-State: AOAM533ruNiSLcOXGBw7xFOBI1jdJBiftb7+jwxMdUG366zDXplSPtr5 WGhoVm7ez+MSBqqAb4Hind835UH4m7EQfQ== X-Google-Smtp-Source: ABdhPJxA7mB2kansZCMbcqgc1yvo6iu0gILHLIOAFx56bKJAGYrCQahQ6X/TQhbbK32mbh7Y2qq22Q== X-Received: by 2002:a17:903:2287:b0:149:fa57:ea87 with SMTP id b7-20020a170903228700b00149fa57ea87mr15388787plh.94.1643046461373; Mon, 24 Jan 2022 09:47:41 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:40 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nicolas Chautru Subject: [PATCH v2 18/83] baseband/null remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:14 -0800 Message-Id: <20220124174719.14417-19-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/baseband/null/bbdev_null.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/baseband/null/bbdev_null.c b/drivers/baseband/null/bbdev_null.c index 08cff582b99d..248e12987f03 100644 --- a/drivers/baseband/null/bbdev_null.c +++ b/drivers/baseband/null/bbdev_null.c @@ -251,8 +251,7 @@ parse_bbdev_null_params(struct bbdev_null_params *params, } exit: - if (kvlist) - rte_kvargs_free(kvlist); + rte_kvargs_free(kvlist); return ret; } From patchwork Mon Jan 24 17:46:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106377 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67099A04AD; Mon, 24 Jan 2022 18:49:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 630AA42852; Mon, 24 Jan 2022 18:47:46 +0100 (CET) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id 5813A42811 for ; Mon, 24 Jan 2022 18:47:43 +0100 (CET) Received: by mail-pf1-f177.google.com with SMTP id h5so8275040pfv.13 for ; Mon, 24 Jan 2022 09:47:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MpFsvUFrmqYboBcYsmcff/+YsakMY6WvobYk700vFdw=; b=LMDvU1Iym2Cjjj6pJ0/mnb5J/Zu1ydWN13YzoHjGPojmpBjsuzA5Q/AdY9BZaaBZJd 2N+BsJ7atjliIFh/EeJ4pywbllXHDtq1EKvyna2a/fJr6U4Xb/lbL7k1leJaKlm/ERU7 cmENrKJhM/fwgMozkZz7TPtvfHEFF7ODaK94zwhKy0oPI/2ZTdI65Ifbhf7tXJqchCU4 G9mnXoJvKXzm+/x22I3Tu5+yyuZ6/SzwBido004X8IvUHbKx2nTt53sPQ2MKegm+5DgO tufMujYXxeiRNghMPYqRhnLPyoSH90cB955PS0eFj1fJgxoAsksW8a2JAn1/+lAzy+Bs +CMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MpFsvUFrmqYboBcYsmcff/+YsakMY6WvobYk700vFdw=; b=ppuUj2m/cx8jsjWFuwSh8p8VPgb+kf0Fpey17WhPNpKzQsQkShWN8gilxRovtzWst+ UIM1Q4sjTl86ge/j7YIGglypaqOY8ibSQX6AL5Zu3NzjKEfUhp3+XaduUXMH126typ+S 92cU/gG1yp1TH46IV359Y6yFKCsOYl3v+AxQZchsBwKnL/vpdCzjj3NGBS4xnszCVss4 uTh+6pIpLOiSKXG9Z3eCaX75yv40L/Ih6EMhCowkTG1W41Wxv2B1tMp8mBkbfY5k5ctn gu9hfOfCmlBeH7FQc5+uA/fJRAS3Bp+WnV5fLH/zrb/K9t1RtS/Y6LTZd6lXIOjKwy3x YCWQ== X-Gm-Message-State: AOAM530IjY8VqNPXhY0POkRkcu3l7pY+SarVdf64g1rkPLWTcNZNmhrC Y3nb8V+Qrg7laL6btK/xw9DS4MOUYigxDw== X-Google-Smtp-Source: ABdhPJw72gZ1iDFShsOa3NBW1oidoGfrBBea1n70n1A+s/uVJHUDYKRHKDFcB3VPEQCmrVExWN1GeA== X-Received: by 2002:a63:81c3:: with SMTP id t186mr8125158pgd.462.1643046462286; Mon, 24 Jan 2022 09:47:42 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:41 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nicolas Chautru Subject: [PATCH v2 19/83] baseband/turbo_sw remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:15 -0800 Message-Id: <20220124174719.14417-20-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c index c6b1eb8679cb..af7bc416f92e 100644 --- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c +++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c @@ -1918,8 +1918,7 @@ parse_turbo_sw_params(struct turbo_sw_params *params, const char *input_args) } exit: - if (kvlist) - rte_kvargs_free(kvlist); + rte_kvargs_free(kvlist); return ret; } From patchwork Mon Jan 24 17:46:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106378 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FF96A04AD; Mon, 24 Jan 2022 18:49:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86CD84285E; Mon, 24 Jan 2022 18:47:47 +0100 (CET) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id 9C6594284B for ; Mon, 24 Jan 2022 18:47:44 +0100 (CET) Received: by mail-pf1-f173.google.com with SMTP id 192so13239248pfz.3 for ; Mon, 24 Jan 2022 09:47:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EQrCx0dno/N/ybIWGqGKAoHbfKSGtgncHhrQaZgaGS4=; b=yUE51ewoDk8DcKLtzVInSbci6oAEhteNR9oVWUPTNqWGmrjwcymB/e8vCOk92AQfw0 cJVEhFTv62EIU4KY4/r5gW77U9rdrsJwPBw6OeJl5XVdsqPcTauzEBX/gfp0+6awAvaO 65D/kpZWS7zeWvfbatxuMNRDI0uB4kcpT2PO2oArIl7nwrScubdjYhY0W8vdwMrUNvRk 4LR5ExK8VtR2BrmmuMBS/OW2ZcKQr7Rgs2/3OIVwtLNz2UC8D6S32nmkYQITJXOBkLQn VI2Qdqt0Mg0TwocV5UPYqG64wvpW+9EPCKluxwHv7iddFRwnFjTqCohSusn46V6SgkP8 zX4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EQrCx0dno/N/ybIWGqGKAoHbfKSGtgncHhrQaZgaGS4=; b=norpglST3TJE8EoTBm/U/P8QLC/8f7K4yUVY0ZZd5yYY7PEBBjMW36jr+H4f1xv6wP GUzvQrRuFhc6vOt0BsysnJKKpp+6xVi/Ntaq8jcOfZV8Aj1tgUcI+bFpSK9MZaJBa29I Tt51FLEuiH3E05+DVmc0bbPwf9aHton/al7cmIbn9KrpJMLcy9XpRUREyKR3eQrZtxwL jrseUX9PTSvLaSPwXbaIuRCVVZCBuXBr/2VazAJdCwhPldMYDuT78m3a8pvo5uw2voBP qfKW2PJbTFtt5dKwYewMO3rJmioXT3O6+hGB0j9y954pN6EslpfXMOg+B+LI4G9A/FRo Q/BQ== X-Gm-Message-State: AOAM530rwOiJ+9V556ejeI0eAcLN2hQaY06zqFTuT0ZtvxhXaKJ92Vm4 3ptX6waGHBZH4fH+x8x2NOuj69t915V+4Q== X-Google-Smtp-Source: ABdhPJyavRf3UCGR5/gOVaxBaGFrD7X4UOhENXN36g1odfr07nbamoKTAxOLwlwX6OwyU9A+qzCz9w== X-Received: by 2002:a63:7946:: with SMTP id u67mr12348100pgc.83.1643046463487; Mon, 24 Jan 2022 09:47:43 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:42 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH v2 20/83] bus/fslmc: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:16 -0800 Message-Id: <20220124174719.14417-21-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_bus.c | 6 ++---- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c index 53fd75539e98..30d019516b91 100644 --- a/drivers/bus/fslmc/fslmc_bus.c +++ b/drivers/bus/fslmc/fslmc_bus.c @@ -223,13 +223,11 @@ scan_one_fslmc_device(char *dev_name) insert_in_device_list(dev); /* Don't need the duplicated device filesystem entry anymore */ - if (dup_dev_name) - free(dup_dev_name); + free(dup_dev_name); return 0; cleanup: - if (dup_dev_name) - free(dup_dev_name); + free(dup_dev_name); if (dev) { rte_intr_instance_free(dev->intr_handle); free(dev); diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c index 52605ea2c32c..943fadee4816 100644 --- a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c +++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c @@ -149,8 +149,7 @@ dpaa2_affine_dpio_intr_to_respective_core(int32_t dpio_id, int cpu_id) if (!token) { DPAA2_BUS_WARN("Failed to get interrupt id for dpio.%d", dpio_id); - if (temp) - free(temp); + free(temp); fclose(file); return; } @@ -574,8 +573,7 @@ dpaa2_free_dq_storage(struct queue_storage_info_t *q_storage) int i = 0; for (i = 0; i < NUM_DQS_PER_QUEUE; i++) { - if (q_storage->dq_storage[i]) - rte_free(q_storage->dq_storage[i]); + rte_free(q_storage->dq_storage[i]); } } From patchwork Mon Jan 24 17:46:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106379 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B8E2A04AD; Mon, 24 Jan 2022 18:49:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84D4342862; Mon, 24 Jan 2022 18:47:48 +0100 (CET) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id B02F942850 for ; Mon, 24 Jan 2022 18:47:45 +0100 (CET) Received: by mail-pf1-f182.google.com with SMTP id p37so16668942pfh.4 for ; Mon, 24 Jan 2022 09:47:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JsSGuL3hE0Kx6NbddGKHLMFrZW0o8WLTr/PaEiefI4o=; b=l2wANMFaPaJ4TpN3xtBkU0FV3qfX0I9/7yvcjeqw1pIt3TDh6RxHeexsOAAyfQoF5r AMwQmIDUJJfRfqRdiGlxcKXeAA2YwMBVYY6hOlWORYS9DgbYoCfa/H1PWFKxivGyi2h9 sRhQSPRKL94O2aIpjqY5NLp/t6n6M9Fms2XYNJGR8SF2z2e0BbgTAgGbpL19znaVyF4N G3LoApRiSPAXgw95fwbCKi9XsLHtO/V8h0Dx9+TUuNQS8y6Lw1RtNWSVTnbCruKC882q wHFUfsb0UAwGxLiazTfVNcvdIQYd3oVokTExey7o577KZkNW9aTkt+jnpMlAUrDrIzBX SbAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JsSGuL3hE0Kx6NbddGKHLMFrZW0o8WLTr/PaEiefI4o=; b=DCQPoFnDtQrWt//5kNzWTTMh8w1PuVSgG9OqglZUJ5sv5eQzqlVBfDjHcSGsJG36j1 BCl570mDlEdZoBCNnFfrHQ3IeESjKhhjKbFfJgz23/57ei22nZC7/3vH8n8PRQpLfPk5 r9MU8fktcnnKTbTRcwGavN7xm0XOGq/sk3/UNp7KqIjicZ1S+rtGwQ+lEssR8OgQkBfV TCe6yg2vk5HfJDpkTpFxux8Ueu9DN5wDpk0Lm438HcnORQ+qz528+7EkzOMdA56oLek3 6HVpisNyaRHMyHjI1UYyESTMo79VFpW6SUl1LmW1uhossAx0LomvNJ2YqSaUZ8fSSSUO 0gdw== X-Gm-Message-State: AOAM532sG8PkXWIToXzN51CzjWxbtT/txJaL39y7EUKXg1FFkd+xqwNK x4oS8zYFAk40+jvQDzYKcuWOd5RKu2U56Q== X-Google-Smtp-Source: ABdhPJzaoSApZk/JWohLc+4d9ZBze09MxP9fpM4FNz+sYGXDO5+5XHoVLrf+H5c8GfdRTWJ5MLzUwA== X-Received: by 2002:a63:1f07:: with SMTP id f7mr12529347pgf.219.1643046464603; Mon, 24 Jan 2022 09:47:44 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:43 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rosen Xu Subject: [PATCH v2 21/83] bus/ifpga: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:17 -0800 Message-Id: <20220124174719.14417-22-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/bus/ifpga/ifpga_bus.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c index c5c8bbd57219..e005f2cb70b3 100644 --- a/drivers/bus/ifpga/ifpga_bus.c +++ b/drivers/bus/ifpga/ifpga_bus.c @@ -191,10 +191,8 @@ ifpga_scan_one(struct rte_rawdev *rawdev, return afu_dev; end: - if (kvlist) - rte_kvargs_free(kvlist); - if (path) - free(path); + rte_kvargs_free(kvlist); + free(path); if (afu_dev) { rte_intr_instance_free(afu_dev->intr_handle); free(afu_dev); @@ -254,10 +252,8 @@ ifpga_scan(void) } end: - if (kvlist) - rte_kvargs_free(kvlist); - if (name) - free(name); + rte_kvargs_free(kvlist); + free(name); return 0; } From patchwork Mon Jan 24 17:46:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106380 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D816FA04AD; Mon, 24 Jan 2022 18:49:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E85542843; Mon, 24 Jan 2022 18:47:50 +0100 (CET) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mails.dpdk.org (Postfix) with ESMTP id 63E104285C for ; Mon, 24 Jan 2022 18:47:47 +0100 (CET) Received: by mail-pg1-f174.google.com with SMTP id z131so5002914pgz.12 for ; Mon, 24 Jan 2022 09:47:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DgkzBQTE1eMonz+N2UqWyLc7Hrzi1Ajc+itxrE9HTe0=; b=hLCqG0/HZqdTtqepd4Hf62eb806TxOKaNSPswTVVlbnRMLgGEus7AhfnvcRdq1qaMC OL9MD6uqFKtdXS2+KVg0MYE8wlP7kQlONFqQTM3D1CccL1ji2GPUmHMkwOmYTAWoz25U i7p3HMMHRaT7zrcNlQ/NBg0Od2oTIBiFji/1D91/zxfKCL5IVOnr7T7ozBUfKiWOnJ3q YmTlL8so++1jW/ivYyyRIf5YWIIN+7Y5GXuIXO5w2L5iRjGM5m1DP0qEDSzWkAfXXjbc FIHs7MNR6BBwT4upfo1MeNcSEmU6mPRx90FzvX8xmr6vwo5IFVNWqx5DulllNAkU8cnF EQ9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DgkzBQTE1eMonz+N2UqWyLc7Hrzi1Ajc+itxrE9HTe0=; b=b9da+RqeP9NQ6truzhilbvnkb6Fjsu0tgwo2lLl0d4aVF0chz4urzkRjOyuevwENfa 8Xm3pAXBWVQ/Yf3pZsSBKcZzk1VKFv4u9aP32qvGwMxj2XkjyPKqGWKKUuAV+wElTICY RD68BX+95XhxydEPChSzZCd9/xkcyP030EHixfK1mmQXZFXXqal2Wg7enWW8oD80asJZ GwZpVIdRxAUmI4ATui6uz6BzUV2YNC8hZ25TsERFkyYCJN6to32BGAWQ25EMFhj0fj2K HJSSjub5zY+H3fst9r9I3r90DPnEranONepQ0ynq8AwuufIQ7X5JB6XjayEM6A4Is4vR enKw== X-Gm-Message-State: AOAM530o/frHzkZH8UI+tFoUN8o8urIJMBSJtQGvHSAuK9/ah+Fmr0Aq vng5MZ7FV3ZTrpyAJceJaUWVtpurfXQkSg== X-Google-Smtp-Source: ABdhPJwYdj03BhCWwkeYA1HRqWqbvEdZ9o9ku5R8n8Y6FTt/HTdeo6ST0fhY4webHpiVOd8Bm1/xVQ== X-Received: by 2002:a65:6ab3:: with SMTP id x19mr12533006pgu.416.1643046466019; Mon, 24 Jan 2022 09:47:46 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:45 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v2 22/83] bus/pci: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:18 -0800 Message-Id: <20220124174719.14417-23-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/bus/pci/pci_params.c | 3 +-- drivers/bus/pci/windows/pci.c | 3 +-- drivers/bus/pci/windows/pci_netuio.c | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/bus/pci/pci_params.c b/drivers/bus/pci/pci_params.c index 60b424b8297e..61a868707f16 100644 --- a/drivers/bus/pci/pci_params.c +++ b/drivers/bus/pci/pci_params.c @@ -117,8 +117,7 @@ rte_pci_devargs_parse(struct rte_devargs *da) rte_pci_device_name(&addr, da->name, sizeof(da->name)); out: - if (kvargs != NULL) - rte_kvargs_free(kvargs); + rte_kvargs_free(kvargs); if (ret != 0) rte_errno = -ret; return ret; diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c index 39ba31be7d38..7bf091158ba2 100644 --- a/drivers/bus/pci/windows/pci.c +++ b/drivers/bus/pci/windows/pci.c @@ -418,8 +418,7 @@ pci_scan_one(HDEVINFO dev_info, PSP_DEVINFO_DATA device_info_data) return 0; end: - if (dev) - free(dev); + free(dev); return ret; } diff --git a/drivers/bus/pci/windows/pci_netuio.c b/drivers/bus/pci/windows/pci_netuio.c index a0b175a8fca0..5460399eea5f 100644 --- a/drivers/bus/pci/windows/pci_netuio.c +++ b/drivers/bus/pci/windows/pci_netuio.c @@ -180,8 +180,7 @@ get_netuio_device_info(HDEVINFO dev_info, PSP_DEVINFO_DATA dev_info_data, CloseHandle(netuio); } - if (dev_ifx_detail) - free(dev_ifx_detail); + free(dev_ifx_detail); if (di_set != INVALID_HANDLE_VALUE) SetupDiDestroyDeviceInfoList(di_set); From patchwork Mon Jan 24 17:46:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106381 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B7C6A04AD; Mon, 24 Jan 2022 18:49:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 511E64286F; Mon, 24 Jan 2022 18:47:51 +0100 (CET) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id 25A0142862 for ; Mon, 24 Jan 2022 18:47:48 +0100 (CET) Received: by mail-pf1-f178.google.com with SMTP id e28so12223174pfj.5 for ; Mon, 24 Jan 2022 09:47:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ad25wPM5/3bGAKrapK+uGim/jbE+T1hChvcLxmfP2LM=; b=it9PB9arpCMHhn8QPBMHTVjuRs7QWvgWTXZzWiv/dYOqns/P+7fiFr6eTwCJKQHcuw P0uhiytooN80GM6RPk2r9wvFAjkk038mouzp3zzu7ZomO+ioslLJhI5/nxTUQMbEuYu5 iqWtHmd6qtjxZPgpqH0ncPhqim1DzPZcDsf31p4WO2usoKshpjXV9Eo+Gfrksaf4Ya4g 9KWjVCmyUA0xrFcQFuMqLORWcD9nKGTfNWzxnalA3mq5cdSZXDbF0A70BIs1CfFCj3cO WKafgYhzKZOSQmb4jLdDfSFomB2QbZrz3kqQ2b1NtkcqC+0fmU/n1ofNF8pIXs4R948r ynng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ad25wPM5/3bGAKrapK+uGim/jbE+T1hChvcLxmfP2LM=; b=RVmkCv2akznEdyN8ncc5DMwfa+MIdoWDzYGIu9KRAY/Yq6iRHFhERVk2s0M60PSVy7 nqyyozG8X45hJ6kFSvIdgh+trfdoElfs18porTMI24WV9gIuZnij1IjM5uRbxIGj28nc 3s/tdp5WunhO8IGwyau/jCS8Hltq7uxCcTmJCk+amrEMZIQ+td31r1SQHD7zjdaSMFeo M5ZOTptxXZwmLt52ytvWD8YTfVucJFgdBR7wO1YeC5gBbMfsRCS03ZeAmBOag+0EQJK3 XRAsnPUiSyuPLcsosS2fNtiI5iD7Tp4y0U5ULlQba0n28JQt4qWdHXbsn7YoWk8+qpxg P1Kg== X-Gm-Message-State: AOAM532fxFXdIxk6LHLpdRqfucLj6mWn8NEp0Fw2+NeNkYpXJLDGQ2hd stFZRLiWK69PBN/yVutJrva6ioaDas4tLQ== X-Google-Smtp-Source: ABdhPJyo6vm8dIed5nBtUfoNYtrIgzhKhVozg0q4tgUsVCsiEU1gu7n6XLZ6pbIiLSyvZS5Swn75yw== X-Received: by 2002:a65:6a97:: with SMTP id q23mr12815043pgu.464.1643046467202; Mon, 24 Jan 2022 09:47:47 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:46 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Anoob Joseph Subject: [PATCH v2 23/83] common/cpt: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:19 -0800 Message-Id: <20220124174719.14417-24-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/common/cpt/cpt_ucode_asym.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/common/cpt/cpt_ucode_asym.h b/drivers/common/cpt/cpt_ucode_asym.h index f0b5dddd8cdf..f5d91f2583bd 100644 --- a/drivers/common/cpt/cpt_ucode_asym.h +++ b/drivers/common/cpt/cpt_ucode_asym.h @@ -192,13 +192,11 @@ cpt_free_asym_session_parameters(struct cpt_asym_sess_misc *sess) switch (sess->xfrm_type) { case RTE_CRYPTO_ASYM_XFORM_RSA: rsa = &sess->rsa_ctx; - if (rsa->n.data) - rte_free(rsa->n.data); + rte_free(rsa->n.data); break; case RTE_CRYPTO_ASYM_XFORM_MODEX: mod = &sess->mod_ctx; - if (mod->modulus.data) - rte_free(mod->modulus.data); + rte_free(mod->modulus.data); break; case RTE_CRYPTO_ASYM_XFORM_ECDSA: /* Fall through */ From patchwork Mon Jan 24 17:46:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106382 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2D8FA04AD; Mon, 24 Jan 2022 18:49:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4984742872; Mon, 24 Jan 2022 18:47:52 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 5BB9C4286A for ; Mon, 24 Jan 2022 18:47:49 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id s2-20020a17090ad48200b001b501977b23so16477008pju.2 for ; Mon, 24 Jan 2022 09:47:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6kHUYjHGPzaVjF61Z0vG8E/yxaEieN8nyYlr8bY65z8=; b=J11p+KoyGOBrOhSlDxQ9WMwxPaaYDPsEofOLKsDOSfqGTcIuIf/gJ3lmxHlwA9j9e5 A4g0kb04ioOxzk+pijMvC7EAQRKp5yctEZ8iLFmTaT1CQQry/iZdTRsvbb9Y9ZRg2kbH cnpDqyZ9DP0X150BoCigtP2/sAK6z6Vd4p0iAYbo263j4sTXHnqyz4rTL+dObYRzpxVv nxB4aFThvXvdV1YeESgNvpd/ux3xFwG6W82UGKvjvnF4R9K5e/BtkyKitKiR8N3x7BM6 wycPTJTmKRmGRyjMATRAAkvFNo9kfcD3kAyUm9+bKv0IyHOY0u0pOii/1HKEgpIfIy06 uyOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6kHUYjHGPzaVjF61Z0vG8E/yxaEieN8nyYlr8bY65z8=; b=U4wMDQOF+5/H/pRiRdftRVuUNQ1D6woPsCKrlaoVAJMJkmGQwgwDqNofwl3JnF9dwA QDmlYhMwzL5AqSLyH48ap/cfp2kE0c0637CLd5naaKOD9+Gl8sg3SpdIeVbhGQzVLidG dm7RbxkHhNcvFQyOmfb7FO2wEs0jSBTFnOj+RKAVaZOVdrYw1voDnkhVpO5fH/074pEm 1rofstapIZ/U9bd93lYxINzvIPwGQgC0O1tX2kmMI0bsC5hxN8zGgHv365FmxGUA8LwW zdo0uq7b4Dh96NRcyviHvV/Yud6ZUAB7mcsp5hPxqe+8Ybo1hGMnomBFRL+8p1oOtqc6 bLMA== X-Gm-Message-State: AOAM531OWZ8HAKL0Y78DDvO8kSjhltLi8GZW1lBXimw9w0fdcUeVrbWn M9ux18SinY1W9w5sEMNsB9nTcn3BOIGbZQ== X-Google-Smtp-Source: ABdhPJxxYFmhNFmGRi/x2zYW84CxU1vrdAkTogR2VpnHy6rhxmbGuE06nM8rnH0oskJ4mg5q/zkEeg== X-Received: by 2002:a17:90a:ac0d:: with SMTP id o13mr1856442pjq.127.1643046468276; Mon, 24 Jan 2022 09:47:48 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:47 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH v2 24/83] common/dpaax: simplify kernel compat macros Date: Mon, 24 Jan 2022 09:46:20 -0800 Message-Id: <20220124174719.14417-25-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The compat wrapper had unnecessary NULL check and also the emulation of kzalloc() should just use equivalent rte_zmalloc(). Signed-off-by: Stephen Hemminger --- drivers/common/dpaax/compat.h | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/common/dpaax/compat.h b/drivers/common/dpaax/compat.h index 7166f8cceb41..cbabc1588b21 100644 --- a/drivers/common/dpaax/compat.h +++ b/drivers/common/dpaax/compat.h @@ -339,16 +339,9 @@ static inline void copy_bytes(void *dest, const void *src, size_t sz) /* Allocator stuff */ #define kmalloc(sz, t) rte_malloc(NULL, sz, 0) +#define kzalloc(sz, t) rte_zmalloc(NULL, sz, 0) #define vmalloc(sz) rte_malloc(NULL, sz, 0) -#define kfree(p) { if (p) rte_free(p); } -static inline void *kzalloc(size_t sz, gfp_t __foo __rte_unused) -{ - void *ptr = rte_malloc(NULL, sz, 0); - - if (ptr) - memset(ptr, 0, sz); - return ptr; -} +#define kfree(p) rte_free(p) static inline unsigned long get_zeroed_page(gfp_t __foo __rte_unused) { From patchwork Mon Jan 24 17:46:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106383 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 013E2A04AD; Mon, 24 Jan 2022 18:49:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A97E4287F; Mon, 24 Jan 2022 18:47:53 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 9355742802 for ; Mon, 24 Jan 2022 18:47:50 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id d15-20020a17090a110f00b001b4e7d27474so517166pja.2 for ; Mon, 24 Jan 2022 09:47:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XQ8I6+YgMTuR5SdNcCmgWKROtA0UZVrH8etryIV5X+o=; b=hWZWNx+GQMYuBmFnCtfrNQiJu3gn1pgz6M0CV6Vxa1+uVLo4XAoHlKH+49RIBRmne8 AplRNK0YUMgpyzfEdCOKKBn7gJNyXY/NjFrnt9VljanHvRlbNDs/j8zwFIx+aDQ3GTFU i89awZsGXgxmz/VMrflFeOc3i7b6ipWA+Otzk2iJC8pFYX58jMKlhMETcClgKaMp0lP8 L0Mb0WA9zF7myYsUZNsvcjjb0wMBiPSHwd5lBqkyHSjRhtco+nhNM7lSv/WT55o8bZ3r sMY5+mKGnpSVcq+4Uh91luOqkosc3wlgt2aAhuP8rZYqMjaqJEni0NtmbsPf3pJMAqRh UofA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XQ8I6+YgMTuR5SdNcCmgWKROtA0UZVrH8etryIV5X+o=; b=aHjgy1em68QL36JuXWEiadkQ2ul9u4z3PUYpyLvr0CeXiq/gyGKhO+AWbRqAowCuly 5R4BjTH1vYB4463ZNR1ZRiDR0wPEnnVJIWxPj7hTgqfEObDPiQ5PtkNEZ29uc6vyxWH9 nv6p9HcBcBoxGmRCNhR8SfdL4Scx2lEzxPHj1H2yIe5jiBeEdQrQhqGtr+MY+IvsFapz fnHAYIwbzKrsh5xspqhcoEJHSBMkHfVdHZvkJTLdqzSFzqDdvt9EL+C76LUZaMQAtAVW RBgXuXPzspH63TfKyep7U1D4NplxJo9+aTfHXWKPlrt1K8Wb6FfrGIC8Jm2rIpInvYQW +wrg== X-Gm-Message-State: AOAM5314ow6GZMmvg9FX/sGDSGYhq5msgIf5vOpo+gLEwpA10KjKqupa D6QvXBAGfcYsGFEzjDsm/e7vMxJ3wApWig== X-Google-Smtp-Source: ABdhPJw2LmLU+x/DtPeJW/+xB5N3rUqizYgbA/GEZnHkIkJSL3CCI4vOL1/uVBP8G9L6pthDMKcr+A== X-Received: by 2002:a17:90b:4d11:: with SMTP id mw17mr2979529pjb.100.1643046469344; Mon, 24 Jan 2022 09:47:49 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:48 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH v2 25/83] common/mlx5: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:21 -0800 Message-Id: <20220124174719.14417-26-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/common/mlx5/mlx5_common_mr.c | 3 +-- drivers/common/mlx5/mlx5_common_pci.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/common/mlx5/mlx5_common_mr.c b/drivers/common/mlx5/mlx5_common_mr.c index 1537b5d42879..07f76a10655f 100644 --- a/drivers/common/mlx5/mlx5_common_mr.c +++ b/drivers/common/mlx5/mlx5_common_mr.c @@ -516,8 +516,7 @@ mlx5_mr_free(struct mlx5_mr *mr, mlx5_dereg_mr_t dereg_mr_cb) return; DRV_LOG(DEBUG, "freeing MR(%p):", (void *)mr); dereg_mr_cb(&mr->pmd_mr); - if (mr->ms_bmp != NULL) - rte_bitmap_free(mr->ms_bmp); + rte_bitmap_free(mr->ms_bmp); mlx5_free(mr); } diff --git a/drivers/common/mlx5/mlx5_common_pci.c b/drivers/common/mlx5/mlx5_common_pci.c index 8b38091d8741..458630351cd1 100644 --- a/drivers/common/mlx5/mlx5_common_pci.c +++ b/drivers/common/mlx5/mlx5_common_pci.c @@ -97,8 +97,7 @@ pci_ids_table_update(const struct rte_pci_id *driver_id_table) updated_table[i].vendor_id = 0; mlx5_common_pci_driver.id_table = updated_table; mlx5_pci_id_table = updated_table; - if (old_table) - free(old_table); + free(old_table); return 0; } From patchwork Mon Jan 24 17:46:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106384 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3679A04AD; Mon, 24 Jan 2022 18:49:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58BA042885; Mon, 24 Jan 2022 18:47:54 +0100 (CET) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id 7B3554280E for ; Mon, 24 Jan 2022 18:47:51 +0100 (CET) Received: by mail-pg1-f172.google.com with SMTP id 187so15827018pga.10 for ; Mon, 24 Jan 2022 09:47:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X1J0QmXruFq87E8wAPFLKFy3yvEdi4WKgxvgj4zkKRs=; b=7LPk+VLgOmVVEDD05eZyrtkKqZW+ZMgj5m+CPkNguVn3brF/yfPeIwUh3TAMVlI1qC VLsDfqpsqr2booRGxhg5mdU9xqSpks6FDHkaJCnHQLndWXDVrkq8B5K4z60r3ZVNSo9u oVLBci7IxSyHhYdmwh65JxsDqShyhiv2BeZxiP8y5wGCOYeXnLUJMlpgQavi9TddSHFK 6oc2pFz9Hp2lJUHJlPExOgztsYn+9eLLPwXyyPI/EFpz4UwcR+52hKttbBsZcR3Noq3L AniqkvMbGU4h9Hd4Z5W0S5aTpwJr4DI6MCNw3fCIGay5KeerzoM9h3o8XmwGZvP+fop9 fh1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X1J0QmXruFq87E8wAPFLKFy3yvEdi4WKgxvgj4zkKRs=; b=36SIAgSmUUgs6k8znLMCNHzJDUmuZ+8bpBGSSBfUOYrU4muMHY3cRmn1lqBGKjbyWk dr1Qb1dg46pZYdw8AkdR0uhd9PqM6TznEQIxa1zCUxPkvJHtk9WXiqt6XhGRfgf4IGoh J2g3CVhST7Tmu0q9EUVHAEVrWKC4taBxeYGv6yE1UEA0voO37XQg3bfO7MdKS4A+H6Ch KwKYPrwyQYt+X33iE1kYPCvBqo4VmtKWKUzDYSN7iBQ3Z93YHUHeUKhK+A04Y9+WBXwy yhtgsmfh2Hmv781B5xEOdn0VknHgD45BCNAA8cKllR3ICWX7uk8H6nkJh1ZlcqzIdcE8 fUjA== X-Gm-Message-State: AOAM533adLjjxJu7jw0LYvV8DnE5RR70cfEds+LzN4cUqgRim7XDXGcs N3mTYrBD/9QUMyhTI7V7Km60s3W2no2B7w== X-Google-Smtp-Source: ABdhPJzMKF8+nkkkTUjc4u93X4mTH0+jDLKqD18ldJPdhttP50dWMbqMR7OhQ4GcmvmALtFQRQ/eRg== X-Received: by 2002:a63:6ac1:: with SMTP id f184mr8202313pgc.455.1643046470480; Mon, 24 Jan 2022 09:47:50 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:49 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Fiona Trahe , John Griffin , Deepak Kumar Jain Subject: [PATCH v2 26/83] common/qat: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:22 -0800 Message-Id: <20220124174719.14417-27-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/common/qat/qat_qp.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c index cde421eb7716..57ac8fefca3d 100644 --- a/drivers/common/qat/qat_qp.c +++ b/drivers/common/qat/qat_qp.c @@ -175,11 +175,9 @@ qat_qp_setup(struct qat_pci_device *qat_dev, create_err: if (qp) { - if (qp->op_cookie_pool) - rte_mempool_free(qp->op_cookie_pool); + rte_mempool_free(qp->op_cookie_pool); - if (qp->op_cookies) - rte_free(qp->op_cookies); + rte_free(qp->op_cookies); rte_free(qp); } @@ -329,8 +327,7 @@ qat_qp_release(enum qat_device_gen qat_dev_gen, struct qat_qp **qp_addr) for (i = 0; i < qp->nb_descriptors; i++) rte_mempool_put(qp->op_cookie_pool, qp->op_cookies[i]); - if (qp->op_cookie_pool) - rte_mempool_free(qp->op_cookie_pool); + rte_mempool_free(qp->op_cookie_pool); rte_free(qp->op_cookies); rte_free(qp); From patchwork Mon Jan 24 17:46:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106385 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3AC4A04AD; Mon, 24 Jan 2022 18:50:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 373C64288E; Mon, 24 Jan 2022 18:47:55 +0100 (CET) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 1A32042848 for ; Mon, 24 Jan 2022 18:47:53 +0100 (CET) Received: by mail-pg1-f173.google.com with SMTP id e16so6720934pgn.4 for ; Mon, 24 Jan 2022 09:47:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SVEXLdTcsVppg5dFgNaFR63Y9RESnOdSyfFIOefb5jw=; b=Zr0plRoNHV48AcQ31WIM6XsOu3rw38ta0xgmMOnb4WW3CN2c/7bDIkYxuOB1HK4ki7 WBdrxnrEpmJCtT5fMgq861DzrHTmwmOW8mZzB1d9tMupGMKwP67NPzPaI2lD0rwe5iLB z4VwaWk2WgXEfWgzQ884OIjnaFgG9cjpWXn3BepT9b3ld0+h1By0o7++owGSLSbMy34R pvMYWCuziF02aJzT5hCgrsoUEef4wnEV/N6CPcXUG6j3FNt1ksPrhFNKR6jfYQKoHn6h kM2No52z2jLsq/dkhzzbnmiuIvHHJASD6fXXxpvivEEXVdVGQoIVd+lPY7cGqRPhKxX2 bJIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SVEXLdTcsVppg5dFgNaFR63Y9RESnOdSyfFIOefb5jw=; b=GdOOxTrk9GGHWY4LAHuSM4pYzcJ4oIuRe1OvgFMlrnB97bROuDO/welmZoJYzRwMzV V19lmsvvYl0fFHdwY1dd+UxjwrhsL769WG6UCTSH+QGBqEBt03qWPTrtqm/lQEcMivLb gWbj4DabS4BhJ/IaK17OXD9NhpxjBWEHtVF0cM+Z9TH0wGe+t6jx/zpzuxXAHe7kS771 MUhHJZDnykA6BDuqN+iJbGfivtIHBndNW3159mnjF0x7bkUap0gmvdmnYBdvu+KRD0M5 3W931M2D1gzzuAQFnzvxMXobQnvkcGcpJ5cuMfrTveVsdl7bvch8QzKILZ1yJ1UsO22K FYrw== X-Gm-Message-State: AOAM533Tsz8VkSb4O4Ym0DI8PYYf92psZfAQANHTXGcOaHZCFUAMPtaM HMLEK77cImfs5H3Dr8T+AdmpFgOTyyc0zQ== X-Google-Smtp-Source: ABdhPJx4TyPu/gMc9HOuyTC+oLra+hMkKvYFzBb4RE4/cXJ/S8T5ySwLu0UNKV8v0wWFW9IdrTM1mA== X-Received: by 2002:a63:7202:: with SMTP id n2mr12713751pgc.254.1643046472035; Mon, 24 Jan 2022 09:47:52 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:51 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Matan Azrad , Fan Zhang , Ashish Gupta Subject: [PATCH v2 27/83] compress/mlx5: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:23 -0800 Message-Id: <20220124174719.14417-28-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/compress/mlx5/mlx5_compress.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c index 82b871bd860a..b12951da8b51 100644 --- a/drivers/compress/mlx5/mlx5_compress.c +++ b/drivers/compress/mlx5/mlx5_compress.c @@ -146,8 +146,7 @@ mlx5_compress_qp_release(struct rte_compressdev *dev, uint16_t qp_id) void *opaq = qp->opaque_mr.addr; mlx5_common_verbs_dereg_mr(&qp->opaque_mr); - if (opaq != NULL) - rte_free(opaq); + rte_free(opaq); } mlx5_mr_btree_free(&qp->mr_ctrl.cache_bh); rte_free(qp); From patchwork Mon Jan 24 17:46:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106386 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8053AA04AD; Mon, 24 Jan 2022 18:50:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C9C642891; Mon, 24 Jan 2022 18:47:56 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 00A2142882 for ; Mon, 24 Jan 2022 18:47:53 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id b15so1756787plg.3 for ; Mon, 24 Jan 2022 09:47:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XzlxU2voULKxhb3UlVmpeThkHqlmJu0fxudZRiVGg9k=; b=kmm3SuRBhUscTieHeGhXdEwgX22/uwwfb7UvSvwyUIK42DgjkjU4MdVBXW9sXyifm0 xE/QWFswz1RzhTNUATPRY1L2nYkxtgEg08wWN7SFxW6XjywMg9mEtXGGGGtQgJaPbO8u eqhDknLHYxihCXx/spNtJ+oWDr5J5SthygY6PV7S1MCtL+jyeBI7lgSbbX+WE4nN1QOl RQ/ceavXMo4+ddJLWaKGhgnA0Z0COcLdqS8L4N3t8c8eQRZkXEKCuSPmPzHSQw9kyvwH oGentxSw+LKLcs02Wxt2OfLSn/qqOobDANf/Myfhhlk1APVXvGGWCTpeGzdQUIPqZAX1 AveA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XzlxU2voULKxhb3UlVmpeThkHqlmJu0fxudZRiVGg9k=; b=vw7C572ml5MDv0S17OqHVV/TXIoLgq1LWVR3QAbRi9hltvaZAU/k2JQyMN0icSYlT3 Fm93yoM6hDBund/8UIRP1GDXT/ZmiiyuBO/LsFNflZSdY+xmma2vniuTpXqjD+t2eqsv RHaVQA1EPhMA3NIqbm1B9MVMNGvGEOCxMc9J/3tT9iXJmyyRb0qfC8z2l+5tN/m56Eqg g46jnnEpnpqRza6ex+Pe59waOOtcIu09SwnD1AeibsvfDrCYYJqT+ESeAuad+lCDUT29 p16Rya3rxlu0ynRh/pIiEBFppJAeUdhTo+vmW3h9Ugm5MRngNNdXPliQtbSwgAwHDqzL K/mg== X-Gm-Message-State: AOAM533lhxsclqPqe5JXQu+d/nhXBwCoe84pKSCSzU6sHIPQz0ttasSb RX88tF/MklXMRUbtdiaQV/JPIDDGks+KDw== X-Google-Smtp-Source: ABdhPJztXj8VUMRzZHVv3sCRkgC9QTN8vQ36eFSwIyTD62QgdGQrcppCAT4Qyvmk6NC/QEoIpJLHXg== X-Received: by 2002:a17:903:4101:b0:14a:cae5:48a with SMTP id r1-20020a170903410100b0014acae5048amr15404875pld.25.1643046473025; Mon, 24 Jan 2022 09:47:53 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:52 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ashish Gupta , Fan Zhang Subject: [PATCH v2 28/83] compress/octeontx: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:24 -0800 Message-Id: <20220124174719.14417-29-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/compress/octeontx/otx_zip_pmd.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/compress/octeontx/otx_zip_pmd.c b/drivers/compress/octeontx/otx_zip_pmd.c index dd62285b863e..26cdce60a859 100644 --- a/drivers/compress/octeontx/otx_zip_pmd.c +++ b/drivers/compress/octeontx/otx_zip_pmd.c @@ -337,8 +337,7 @@ zip_pmd_qp_release(struct rte_compressdev *dev, uint16_t qp_id) if (qp != NULL) { zipvf_q_term(qp); - if (qp->processed_pkts) - rte_ring_free(qp->processed_pkts); + rte_ring_free(qp->processed_pkts); rte_free(qp); dev->data->queue_pairs[qp_id] = NULL; @@ -423,10 +422,8 @@ zip_pmd_qp_setup(struct rte_compressdev *dev, uint16_t qp_id, return 0; qp_setup_cleanup: - if (qp->processed_pkts) - rte_ring_free(qp->processed_pkts); - if (qp) - rte_free(qp); + rte_ring_free(qp->processed_pkts); + rte_free(qp); return -1; } From patchwork Mon Jan 24 17:46:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106387 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0754EA04AD; Mon, 24 Jan 2022 18:50:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D60342899; Mon, 24 Jan 2022 18:47:58 +0100 (CET) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id E78324288B for ; Mon, 24 Jan 2022 18:47:54 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id l24-20020a17090aec1800b001b55738f633so192626pjy.1 for ; Mon, 24 Jan 2022 09:47:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Jok0KdFIe54UoJ7kfxWK/vLV88tonlqArUwM2oEm2eA=; b=Fl/PJID25Uyfj61bhGC2ZU5cZg2L1xh37j4X3PKkBrQvDAE92VHf14aOSLz27KrzMs L+FkwZeUstMKcS1M89yuSYvGV5hqfalemHfHU2Dm0NCweP1RnSS77ydSsu4MepfFBaXn GrdmA2FwDX+px3WuTF97xsq8bPhWwVHogXYiFPAZFiUkP27iH17BXyD3ya4ZPMm0knqk i8J6trMEDue4NGr9gIaruEZ4Gf4DN2oMkVmhO6v3AcmHdIMikpdUl5CvTJj+8eKBNaM2 1ZcKIrurTSUNZNJ9wc4AdqVBn05ZsDOFujYRNVCFCoElDkCtttrsoEyu/m/Wab3QzCKw nOmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Jok0KdFIe54UoJ7kfxWK/vLV88tonlqArUwM2oEm2eA=; b=Kxu/PqCg9z8d2KzDXWd+9Lu2PoceI0WS+wEkCfhXSzijWBOHEBm+4oPycG117MKyvw TLovJ34LB4rZtHlcly14es1NYI2XAZrfkz2OF02HtAwGItn4QY+66GFewXRhtSRBLJOh v+CvuaJO2hhvJZXX+JKRkWVGvHUfhan7hruIu1XkyO6f7dOdzLNn74aKMHgW46kTDDVJ ovpPt/Y/siG6tceyUkGTbyB4P6iUQgC/BAZdSuopwrCqJR7rAQ0aQl73BrgdUXHN8sqW 5Be+mVFqNVBBqQjrz4//Q/nOXrXG++IdQisO8W4AniryFW69wSwdXGQuEuWMTRWTyxfF EhWA== X-Gm-Message-State: AOAM530Q/R7/bw68QZnVcvnjZaLcp6VuXglPTCIicaKufVXzgd4/trDh VPaBlyO1XZ/6dh0JOTzSNfQhQR/H40DdZw== X-Google-Smtp-Source: ABdhPJztW2CFjaZj3Lf9hYDRH4kahoFpApTmhBF2U/PFEKX/DCckVIfeRDOOLbWFeiYoqpCy0zFWLQ== X-Received: by 2002:a17:902:ce8e:b0:14b:3589:6c30 with SMTP id f14-20020a170902ce8e00b0014b35896c30mr9563978plg.61.1643046473916; Mon, 24 Jan 2022 09:47:53 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:53 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ruifeng Wang Subject: [PATCH v2 29/83] crypto/armv8: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:25 -0800 Message-Id: <20220124174719.14417-30-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Ruifeng Wang --- drivers/crypto/armv8/rte_armv8_pmd_ops.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/armv8/rte_armv8_pmd_ops.c b/drivers/crypto/armv8/rte_armv8_pmd_ops.c index 1b2749fe62c6..c07ac0489e57 100644 --- a/drivers/crypto/armv8/rte_armv8_pmd_ops.c +++ b/drivers/crypto/armv8/rte_armv8_pmd_ops.c @@ -251,8 +251,7 @@ armv8_crypto_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, return 0; qp_setup_cleanup: - if (qp) - rte_free(qp); + rte_free(qp); return -1; } From patchwork Mon Jan 24 17:46:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106388 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F710A04AD; Mon, 24 Jan 2022 18:50:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07FEA4289E; Mon, 24 Jan 2022 18:47:59 +0100 (CET) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id B64E642891 for ; Mon, 24 Jan 2022 18:47:55 +0100 (CET) Received: by mail-pj1-f54.google.com with SMTP id d12-20020a17090a628c00b001b4f47e2f51so18375432pjj.3 for ; Mon, 24 Jan 2022 09:47:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hAtFWarg54jQoemb5xH5gxWjRimoG/VgzXzbglTnerg=; b=4+S28/vEPTHBVHG7heNDhlasPyILlVOfoRhH/wjZFS3hzo3vzPuaLzRr7OV7fBYBDh JKvI71XxHwqjTofjbmUB3O1PRzHaRT8T/0+zDj2lNNVHHuKAvmHzB5eN1BFSkYS5302D D0EEXWl4t2tqXO2nQ4IK1mCJnh5exOkEXmicjzasHyajg8zBaYkyQBLCRcyg+IUJ9h5s b3ammD3q4e435WzM2WcUMg8qN/vt8wdI9XsR7aEC/kqg3Be75uM4w4mqY6/Sd0w4O7ux qYnfaCCtTnZAU+uamxyR96bVGduGQAsSCs5I/sgW7V0KVJv/N90XDlQOQvcl/ehYQK7U 9sxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hAtFWarg54jQoemb5xH5gxWjRimoG/VgzXzbglTnerg=; b=vxjvb9M4XdxqOApTUTzxqV7MwYRNhaC65AzlzpiIXr4/8wyPgwBnz+jRj05hltwdtl WKdo3HrwvoxGnHnj4/aXXa/0h9P3cDBTMdwuxUastWOyS5v3EQ0AACw1nn4QbOl9ZbkU lQklgeFZu92YYXdW6hOSIEvEU5B9VSoyzMnTb3F1mNMfXzOXXMThlHi5MZ1MUbIklE8q cWjmqJbZGs5XSFXnzctk/gB1m3qTI+z3kOcFjHSqfS5xc6Qn/xELNyAQT7n99rLm9Bhx piwcTQUPE63ezSukvaZ1YWyc42ytfdPdThRezHwp74d1Oo+EzIuG1j9VdqfbF46knyX9 xIXg== X-Gm-Message-State: AOAM531dtZw7n8tnQAahN/jxeKxuE391nVtu7JDs7njoSjnZc89PE1Ko Re6BHag15ieadxKG+bP2810jUNNAePH8kg== X-Google-Smtp-Source: ABdhPJxGGEEHJ84b/ypXw3zHDZi31o78fiUbSopr1mYxzQNAmx0Ooc72nX7VKDL7TZZKS40zUPzsQA== X-Received: by 2002:a17:90a:9c2:: with SMTP id 60mr2920366pjo.17.1643046474789; Mon, 24 Jan 2022 09:47:54 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:54 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Chandubabu Namburu Subject: [PATCH v2 30/83] crypto/ccp: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:26 -0800 Message-Id: <20220124174719.14417-31-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/ccp/ccp_dev.c | 3 +-- drivers/crypto/ccp/ccp_pmd_ops.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ccp/ccp_dev.c b/drivers/crypto/ccp/ccp_dev.c index 0eb1b0328ef0..424ead82c3aa 100644 --- a/drivers/crypto/ccp/ccp_dev.c +++ b/drivers/crypto/ccp/ccp_dev.c @@ -673,8 +673,7 @@ ccp_probe_device(int ccp_type, struct rte_pci_device *pci_dev) CCP_LOG_ERR("CCP Device probe failed"); if (uio_fd >= 0) close(uio_fd); - if (ccp_dev) - rte_free(ccp_dev); + rte_free(ccp_dev); return -1; } diff --git a/drivers/crypto/ccp/ccp_pmd_ops.c b/drivers/crypto/ccp/ccp_pmd_ops.c index 0d615d311c9b..1b600e81ad5c 100644 --- a/drivers/crypto/ccp/ccp_pmd_ops.c +++ b/drivers/crypto/ccp/ccp_pmd_ops.c @@ -744,8 +744,7 @@ ccp_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, qp_setup_cleanup: dev->data->queue_pairs[qp_id] = NULL; - if (qp) - rte_free(qp); + rte_free(qp); return -1; } From patchwork Mon Jan 24 17:46:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106389 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03C3CA04AD; Mon, 24 Jan 2022 18:50:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D718F428A3; Mon, 24 Jan 2022 18:47:59 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id CB57A42898 for ; Mon, 24 Jan 2022 18:47:56 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id d1so16302400plh.10 for ; Mon, 24 Jan 2022 09:47:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v6oHjltU17sKMlDqBS4DiHlqms74CbqMv0yAWufZ2pE=; b=DHtL9E9tEydrGFmyQHiaqileloqf2d4r7uVauvVsqxOxZsmwrbQJQmT2U8GFA0hjkl 0t5J9kjhaM517ghK1IdjUN2aMYiRsxsR7kOJNdu8qEdBIWfCZmPR/jPj1sf7iAoTE/Kg K4tcFgZ+8/ombVRhRAtbjz+/fmZrJ5IdoLDf9IB0P8QzymSaazJ9MNmB35Yw8FhagNFs 3cLLYoxkK7BUqik4Hd9c29y7icXD6j+N3COSijBA8vdG9g7MyHq5C8/H9GquoXsLX3HZ 6C5+5AlbjQFN2UqIGsg1dUi27syPtwvFdDFxEBbi8kdyGJzt1CyBNBWusgowaWmegxP3 6Z7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v6oHjltU17sKMlDqBS4DiHlqms74CbqMv0yAWufZ2pE=; b=XZCXVM+EWqJb2g70CKobQZ8T/50WAqGr1uXFqW2XJ5fm68MnfIDqUj8fTMrdMnfOwI p6O4PJ3udxgnhF80Nwqwry7VyZMPiyaZkZDIowoA6HsOWeVausLYM239Tn8GxDvbr3ck ftFeaE5HxZ2z1Jy2BgBeVSLwZbzb8jeZjDxA6fwfh8O8QxCshKeCWBkoB6zAha8z5tVV Ug/O9zCDmw92laslmfPsfei5KmUucSidG1oV0W94dMrAdzO51H3thJzxqen8diz7DBFe 5cqlDPBrjLbcibo9FHf1pfpopjhQFfDDfeed9hY6Lp7rkioOLBu0CLrtL7eHamc1fAC3 YRnA== X-Gm-Message-State: AOAM530UFM/Xt0az4Ts46cOopK+UNYpt//uiGbyWSco/JOt/evb+2R3w g3UokEl7MGhitCw9YyeOS7YLnmUttxstOQ== X-Google-Smtp-Source: ABdhPJwqmYPE1TOHEYgJfLSy4YsSXIAoAQeeOwolZSqvsHmlN/SxAZE9++eXo1IrFPfhujOuHOOAJQ== X-Received: by 2002:a17:902:d509:b0:14b:4534:76d6 with SMTP id b9-20020a170902d50900b0014b453476d6mr7571886plg.0.1643046475820; Mon, 24 Jan 2022 09:47:55 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:55 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ankur Dwivedi , Anoob Joseph , Tejasree Kondoj Subject: [PATCH v2 31/83] crypto/cnxk: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:27 -0800 Message-Id: <20220124174719.14417-32-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/cnxk/cnxk_ae.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_ae.h b/drivers/crypto/cnxk/cnxk_ae.h index 6222171fe603..01ccfcd33432 100644 --- a/drivers/crypto/cnxk/cnxk_ae.h +++ b/drivers/crypto/cnxk/cnxk_ae.h @@ -196,13 +196,11 @@ cnxk_ae_free_session_parameters(struct cnxk_ae_sess *sess) switch (sess->xfrm_type) { case RTE_CRYPTO_ASYM_XFORM_RSA: rsa = &sess->rsa_ctx; - if (rsa->n.data) - rte_free(rsa->n.data); + rte_free(rsa->n.data); break; case RTE_CRYPTO_ASYM_XFORM_MODEX: mod = &sess->mod_ctx; - if (mod->modulus.data) - rte_free(mod->modulus.data); + rte_free(mod->modulus.data); break; case RTE_CRYPTO_ASYM_XFORM_ECDSA: /* Fall through */ From patchwork Mon Jan 24 17:46:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106390 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7F36A04AD; Mon, 24 Jan 2022 18:50:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 345C4428B1; Mon, 24 Jan 2022 18:48:01 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id C84B542898 for ; Mon, 24 Jan 2022 18:47:57 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id j16so5760224plx.4 for ; Mon, 24 Jan 2022 09:47:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NMDYOBW94oD7LiU+bA7rZElZJGIO2nROgMHnOqTiJ24=; b=nEVv/FhAmlwYC9FiOZNo7RW7HD3udoux8p6UIZL8/AzMxcbrRFC9PdvNdhIRLvX/MN rd6szlIfd01etWtvFSSMTGS/scPHr9fZS/vBU8ryWjsG/Hc6H/GEieANUcNoQ/nwxs2n nLrh9XoLQ7yt6TRxTRLvZX3Jh/lwJ+Ov5V24yzEcohfjsF4JeP9nvQMZr7B9n23guui0 2g2WfOkDGtvhQ5aybxpkeO33ohLBXkqTCntxT7/YOzZQZ6xLkFzbGAR/vzhw6Qy7PDYg o2Gj3UwJRBtkGUGjZJCLcEGGRcuUsNc4AR6+UE5TJSFkxzhCeDlJsVZkN5I+mwS6rwBJ huZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NMDYOBW94oD7LiU+bA7rZElZJGIO2nROgMHnOqTiJ24=; b=NXqobAqHVd5encHdydzMwIdYyytfp/R99jZ8ce9xGNuroEWV3yuMzhfhQT1HZdLQoX sBWNDzHCvAVx2VLIQ5GMyiadOy3TegfLoeGxV3ueUbYkKHHSYy4PbM6zi+2q4AXvUdTv uMPCnTi1x9/Gk2W2Yz1JWRFUyh2Sb3QRdIiha53z4nkOc0+LNKyH0ZNDpQQmA4SJIram kcromGvj4D/UQkJVTADL4MVqUp9g+abP+kUbUeMounKHtG6WX/2SQYIsevvX7avhuBxY L7NZEys0Gb4PJk71kbBzmMNfr2UG4SpS1LDe+nciFV3PQDOlKZC+xh6q8fXqB8aK4xp2 FVlA== X-Gm-Message-State: AOAM531iYbQgDqSQGGz+CBxQSpvKX2e42jLz0+o1NeByBpSrCZ+o6/+Z o5pj4d+xCTWL4sfzuAk3d/DEH/AvzGG+6g== X-Google-Smtp-Source: ABdhPJz0HI6bFEYcG0GwI4M7dBRS4M9DYlmC7mtlC5PtX1ocZpGytNIRRbk8Bz1DG/i1xpz7MRx0iA== X-Received: by 2002:a17:902:ab8f:b0:14a:adaa:93f2 with SMTP id f15-20020a170902ab8f00b0014aadaa93f2mr15012596plr.131.1643046476785; Mon, 24 Jan 2022 09:47:56 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:56 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Fan Zhang , Pablo de Lara Subject: [PATCH v2 32/83] crypto/ipsec_mb: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:28 -0800 Message-Id: <20220124174719.14417-33-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Fan Zhang --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c index 189262c4ad52..f808da9edf89 100644 --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c @@ -102,8 +102,7 @@ ipsec_mb_qp_release(struct rte_cryptodev *dev, uint16_t qp_id) if (qp != NULL && rte_eal_process_type() == RTE_PROC_PRIMARY) { r = rte_ring_lookup(qp->name); - if (r) - rte_ring_free(r); + rte_ring_free(r); #if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM if (qp->mb_mgr) @@ -291,8 +290,7 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, if (qp->mb_mgr_mz) rte_memzone_free(qp->mb_mgr_mz); #endif - if (qp) - rte_free(qp); + rte_free(qp); return ret; } From patchwork Mon Jan 24 17:46:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106391 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F1BEA04AD; Mon, 24 Jan 2022 18:50:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2345E42879; Mon, 24 Jan 2022 18:48:03 +0100 (CET) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id DA4AF42865 for ; Mon, 24 Jan 2022 18:47:58 +0100 (CET) Received: by mail-pj1-f52.google.com with SMTP id d5so14722729pjk.5 for ; Mon, 24 Jan 2022 09:47:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=808NQ/tNS3F0TUlEOIXG/kCrAji71oBNcGlORGKTRrQ=; b=MOWROAq67Y4VAMFcNPPYO1zI3AXX4fJt2n1tgZvwWXnfBK+aBvp/5/aCh7F//I51IP 34Jq4ZL4IAYJe/Y+rIVRF6JXPBTIp89HWm1HGsoLeIuj3jB7uTh1OKXsKi51CkUcuxgG 1Aw5qd0+oninimPJrrs+TGRiQSfTZfzRYdWqNE9qJNRhn19wWGX14JnBETcfb64Q6bEj YNEcdczLPmIm45nVz7gtomhPMMcOW7NfXwuWJvWGhee8GfmPv2GVxKSzEW//JBwc4v/b DYZlWQP3XNpsH0x7F6J+iPGiPTn70ZARobJQWgs06/ORkK/sVV/8pFr16G4VaOnIOinb kZvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=808NQ/tNS3F0TUlEOIXG/kCrAji71oBNcGlORGKTRrQ=; b=5Gz7aIdgJWW5nPpKjsjoPFpT0bCAC7BWRzQHQ/CeYl2+IKcgfMRQJ1gf1fqNGelECv K4aQticAstTFMgonLmO4JMgdXXOGiPga9WW9oaLO5eBwj6fMvUShejATX9yXRluuO1sZ oTMUuHX6E74QCm30Oby1vnVj2K9aTrXjLWxR+kCVB78i/0vsvI4a9EwoMccACRDiLwE3 WJ5ka+hAQZ+VvspDu+W7PgcaMtDoYzw9w8eLXncmTjl9TS84GEmqn+BRVB2pTaaT89T7 99oU+4TnuGoSzt+DaZdj5ZzK9zSzoY4LNBzQlsjHlLJ/tZ7dCyxe8hlsA3FCIfOpuZW7 PuVw== X-Gm-Message-State: AOAM530ayjnwhSdeWT5lU8luDQG0ugKduWSUV4poyPxYRVKUcpTPkb7l qn8e66yfuXRy3Rp5C4p7Zl2TV709zjRK/g== X-Google-Smtp-Source: ABdhPJzqxK3sfBbinRdkLZ2TN/6PlZqT+Y6mrVaS7qPCvs/nAZ6/14GGH3vUsAldJkBHcF04wE1crg== X-Received: by 2002:a17:90a:1b25:: with SMTP id q34mr3022836pjq.104.1643046477805; Mon, 24 Jan 2022 09:47:57 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:57 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Liron Himi , Michael Shamis Subject: [PATCH v2 33/83] crypto/mvsam: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:29 -0800 Message-Id: <20220124174719.14417-34-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Liron Himi --- drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c index 3064b1f136fe..f828dc9db5f6 100644 --- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c +++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c @@ -774,10 +774,8 @@ mrvl_crypto_pmd_sym_session_configure(__rte_unused struct rte_cryptodev *dev, } /* free the keys memory allocated for session creation */ - if (mrvl_sess->sam_sess_params.cipher_key != NULL) - free(mrvl_sess->sam_sess_params.cipher_key); - if (mrvl_sess->sam_sess_params.auth_key != NULL) - free(mrvl_sess->sam_sess_params.auth_key); + free(mrvl_sess->sam_sess_params.cipher_key); + free(mrvl_sess->sam_sess_params.auth_key); return 0; } From patchwork Mon Jan 24 17:46:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106392 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12616A04AD; Mon, 24 Jan 2022 18:50:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 26D8A428B8; Mon, 24 Jan 2022 18:48:04 +0100 (CET) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id 139FA4286A for ; Mon, 24 Jan 2022 18:48:00 +0100 (CET) Received: by mail-pj1-f53.google.com with SMTP id s2-20020a17090ad48200b001b501977b23so16477307pju.2 for ; Mon, 24 Jan 2022 09:47:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=llBygSanMW5E+5xDHm7JWnwIOrSI9+QEhb8JdIMleRw=; b=cIapio6lRP9Zz+bkWfUHGGnXVV5QTOGDwfatzSrT67G0K28mo7jEJnjk17cU7SxDV1 +bEII3dDzLEIf+iuG4Qa6Rk6Ykb4jrQmWmAbqHZConIWy3Fc29tUPpIF76fL2hymYc69 erkPgmQaWvr15xfOdWF2azUKRvhS9OIr3LNQusA14YmYXDQ0f15QmWKIpWT0Q4a38QJB fnslc/bQIZI/t3b9RzE2TakWFsQpZCUNp1D5VX7enPbLsuB+zj3MpOg+AhQSV8JFPdVz CpKz2GL9vBQ4+9NxA7nPXrp0uEGpokhczNuLKEbhqGa9Pdr8nVwAkfumMwSktUI0DETG Ufgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=llBygSanMW5E+5xDHm7JWnwIOrSI9+QEhb8JdIMleRw=; b=kEQeajRXJJTjm4LZ8sgQML4FMe3FWLo+BF3L+0onLGe+lyXfKr1PNGsuaEQhsQPKgq 9irnI7O5ZFfDy5hZN5o4MJ9/FntC0trMedpvruusn2VuUpVjN+156HTxRQzZrqRTQfhJ u8a+9LqIssVdh7FySNdst+ykvlY0DsLRJ4vTTPr1rkwHYXvQZqLERSnfBILIJQu9u7wT qAt984MJBsWDb5BPwvK+gmMluJUEILFKHBJPXUkM4foO+jc5NJneEyA1mRTAA+izpT52 4p4bLhe0zxN488i3vxp8XAokhns0IG+ZWqxRkbY1kRKwkZJfb3tXudYmpe2oQir96t8a sG2A== X-Gm-Message-State: AOAM530LH+u3rIkdmaPUZMoPSIuplILOTcOl/KtlHm7+dp5GCgUqwr/z Fs4WFGuDrpgmUUdOo/UJU9C6R8Bzi0qWuA== X-Google-Smtp-Source: ABdhPJw8WYovNPpqkwr77UvFidBSTdVrZTbRl29ENoM9/UYPdl/Y48Sa4YMyCZBIBZymjIGQjQfQNQ== X-Received: by 2002:a17:902:ce91:b0:14b:42a0:8adf with SMTP id f17-20020a170902ce9100b0014b42a08adfmr7982075plg.1.1643046479080; Mon, 24 Jan 2022 09:47:59 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:58 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Declan Doherty Subject: [PATCH v2 34/83] crypto/null: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:30 -0800 Message-Id: <20220124174719.14417-35-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/null/null_crypto_pmd_ops.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/null/null_crypto_pmd_ops.c b/drivers/crypto/null/null_crypto_pmd_ops.c index a8b5a06e7f4e..90a675dfffe0 100644 --- a/drivers/crypto/null/null_crypto_pmd_ops.c +++ b/drivers/crypto/null/null_crypto_pmd_ops.c @@ -135,8 +135,7 @@ null_crypto_pmd_qp_release(struct rte_cryptodev *dev, uint16_t qp_id) if (dev->data->queue_pairs[qp_id] != NULL) { struct null_crypto_qp *qp = dev->data->queue_pairs[qp_id]; - if (qp->processed_pkts) - rte_ring_free(qp->processed_pkts); + rte_ring_free(qp->processed_pkts); rte_free(dev->data->queue_pairs[qp_id]); dev->data->queue_pairs[qp_id] = NULL; @@ -241,8 +240,7 @@ null_crypto_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, return 0; qp_setup_cleanup: - if (qp) - rte_free(qp); + rte_free(qp); return -1; } From patchwork Mon Jan 24 17:46:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106393 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6221A04AD; Mon, 24 Jan 2022 18:50:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32073428BE; Mon, 24 Jan 2022 18:48:05 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 2FAB4428B0 for ; Mon, 24 Jan 2022 18:48:01 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id h20-20020a17090adb9400b001b518bf99ffso13902692pjv.1 for ; Mon, 24 Jan 2022 09:48:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tcc+pf7RWRS9XlLi6yUpiW4SL86hMusm5V+NE97dykY=; b=d8hMxypFgnYHAkFLVmpkuOVStLxyJ9UL1/cZbQZaG+LY6O9C/yLTyyjmEwV0UohE98 UOmAyXXcnUd4PDvtv8ihtaPsjs5YYyg0f9ZAPSGqT5VgPIXLfeqs2lI7MkXhUEGfJXJp fibxQ9Tbzhlq5KXV76j5zw5exHenZ09e7bVpkc+EWVJge1aWuRb/bdLk/c2dNI9SUEaz 57kkxby0OZZRGspAY3pZ6yQrryYc/tefHVVGfD/1j9Ft8maqIsUGCCYSm7vRn0SCY4sE jtFRUdOqNurCHjbZ+phB7+Bb8Cx1ZqTveErOGFH5azfhd6Ufw5nL72yGFsfM4/BfBU7q vY5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tcc+pf7RWRS9XlLi6yUpiW4SL86hMusm5V+NE97dykY=; b=cCi0RgNc5OMmXsRv8h73hL4Lqv0sELF4aPIT6Z4g1daa6FlW5PKH4ySWulX5joaX4U xz2PyMVzXEfUTCdVuB/FF2tqEDwgQdRI0TzCf2gEO4AxmKnFkd1261BVoTwH3djje5qv QTJSLvv2PfpL/DQcOfv/P3DGA7Ff2EusSyFa2bGhTY+/D7a5T9jgEwOTST4hCmcZKl4E NT1igo9D1FmHWw5jeD/pBPlC34G4zoR9x3Gr2bWIzmKKuwFnFLBS4tTmFPoHBhuqrba5 QeOIUOyYx6acWJGegDfzYe4qrQzXC3XWgiFXD733u2fwYJ1NJa7GZnwRqeiVcUgVFcnb +JqA== X-Gm-Message-State: AOAM532GkSHzcLXCFUpZlEJ6ZuWmjV4CKd0GdL+xL+2E/bldkcjR5y17 Jg/hF4PGfv2uB337feuf/bTpcdrQH5CEfw== X-Google-Smtp-Source: ABdhPJyFuJMmRoyFDBNMHjDcwhldRhx8xXUXaz5d9dvlB1t6PTUIwHKtFvPv6Sm/YHV0GZMQ61amww== X-Received: by 2002:a17:902:c213:b0:14a:f05e:278 with SMTP id 19-20020a170902c21300b0014af05e0278mr15461034pll.133.1643046480014; Mon, 24 Jan 2022 09:48:00 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:59 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Anoob Joseph Subject: [PATCH v2 35/83] crypto/octeontx: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:31 -0800 Message-Id: <20220124174719.14417-36-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/octeontx/otx_cryptodev_ops.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c b/drivers/crypto/octeontx/otx_cryptodev_ops.c index f7ca8a8a8e90..f1aae481c3c6 100644 --- a/drivers/crypto/octeontx/otx_cryptodev_ops.c +++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c @@ -335,8 +335,7 @@ sym_session_clear(int driver_id, struct rte_cryptodev_sym_session *sess) misc = priv; ctx = SESS_PRIV(misc); - if (ctx->auth_key != NULL) - rte_free(ctx->auth_key); + rte_free(ctx->auth_key); memset(priv, 0, cpt_get_session_size()); From patchwork Mon Jan 24 17:46:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106394 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5C7FA04AD; Mon, 24 Jan 2022 18:50:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 222FF428A7; Mon, 24 Jan 2022 18:48:06 +0100 (CET) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id F127B4280A for ; Mon, 24 Jan 2022 18:48:01 +0100 (CET) Received: by mail-pj1-f53.google.com with SMTP id d5so14722813pjk.5 for ; Mon, 24 Jan 2022 09:48:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hETS2FMWtkgnpp1IU7jhzCtiLY7P91TgJUmKY6LlPVg=; b=TAgEKcTO9jNmCu7fv5ayxqyGpar+oQ0Zu6+KUEWnT53kSDAXvNNLQKIx+s+iAdUsn0 pkEJ+xyadRMJ/tklX/LZCXMLZ9lpxUa5beccbaAKJRjz3A62ErS3pEjxheKqQeEQHyN8 ZAGE0qgrva9HkAXFGpWLQ1C/ueOAfSsBrKfARmwBENhZJWjfGumrm/70d17rSwVa5c44 lY7mwVULcxd32+zaSlp6p/K18fiUlkyeyFoJ3ZEYMT+EmQP6P7qm0Og7cNGzg6zOwFwO FK0IFQf0RpjaWqaaQPnrCGM+xzY0Hh1psbw/FLabNIqTRFVyARuNmq/8RnFc7FwczZR+ 4l/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hETS2FMWtkgnpp1IU7jhzCtiLY7P91TgJUmKY6LlPVg=; b=IXOro2vcd/vYAcT+jfORREvydl5ta3310E47Ekz8voXgLDRWYaW2XaI/MD0Qfn6LK6 76ffM1fB4Azgkbzfl1isFHUDU3Z/NMsr3tMiHqelLSYDkJAIyIpcK9MxAMRplk+3OmOD eOCwWT2otle0U8v5rXgPg8SYhj9+vW+08G0mfcdjrcImH92i/I3KTNpnZkNf03Smus0X uQL307PPZpoWummrpPofOxO3AcN+UVdrFcZMo91kdkX7VUUfO+QkPlInMQmw058zFaEA Kr2/kMTaIHx8m/7IsF5EA3/R+2TcM2q+ftiXPsnVZS5ihmaIqrJmPQJbOEloYHFlObiH LQwg== X-Gm-Message-State: AOAM5304PuoN5FgGisusE/DrqM9fyti/TmpCjm9bBH4gEi6voOFD/nTi 1b8i+aeJzLT1lchToFTa3zC4Wk/XyrolOA== X-Google-Smtp-Source: ABdhPJy5Nkr3eaYm9pkGcSB1H1RwYk0E3rPGnYp2ZFKbjr5/p82e2l7TvQEdB1zFjNOefge1ZymRsg== X-Received: by 2002:a17:90a:470a:: with SMTP id h10mr2971348pjg.25.1643046480997; Mon, 24 Jan 2022 09:48:00 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:00 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Declan Doherty Subject: [PATCH v2 36/83] crypto/openssl: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:32 -0800 Message-Id: <20220124174719.14417-37-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c index 52715f86f84a..b1c0b14fefd2 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c +++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c @@ -659,8 +659,7 @@ openssl_pmd_qp_release(struct rte_cryptodev *dev, uint16_t qp_id) if (dev->data->queue_pairs[qp_id] != NULL) { struct openssl_qp *qp = dev->data->queue_pairs[qp_id]; - if (qp->processed_ops) - rte_ring_free(qp->processed_ops); + rte_ring_free(qp->processed_ops); rte_free(dev->data->queue_pairs[qp_id]); dev->data->queue_pairs[qp_id] = NULL; @@ -748,8 +747,7 @@ openssl_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, return 0; qp_setup_cleanup: - if (qp) - rte_free(qp); + rte_free(qp); return -1; } From patchwork Mon Jan 24 17:46:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106395 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D55DA04AD; Mon, 24 Jan 2022 18:50:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 323E3428C6; Mon, 24 Jan 2022 18:48:07 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 0F5564280A for ; Mon, 24 Jan 2022 18:48:03 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id c3so16313695pls.5 for ; Mon, 24 Jan 2022 09:48:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F7D6wuAznDOFZ2sEbMzVSYJuoXX5dzlpWYuMPiHdWD8=; b=UVDqljV6YeMLUs5xnYMkct7YRhiDfZK2naDT0ieRXefxfdyLxwfq6RBMqItUW8YEAX ZWSFT3BKmUFW6yV5YlfgxFcqbOxE6Vr1tf9Lv/nmE5yFDTuN/KfBCMRZ3X2GbChhWC8r SJqpDTYR4OwfkeBMm7h/UHp0SgksXby1jDuweRYYri+Iey4tD3V+f/RC10cfrBuFZy1i 8XkcFVsFjpQsJv9ObIn4SzVbFeR4SLEtmPJfEmeyj8LkrUurcnmh66wTJK9Ylk1P9iWz khPk1w4FtYXVQp1B94OFVpSvV9D6yrcsXPfjqPFZSCpy4o1RjyWlh3we0ieMOCAuSpBG EDLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F7D6wuAznDOFZ2sEbMzVSYJuoXX5dzlpWYuMPiHdWD8=; b=ZIUQMsNKwVSfti+mgYea6+Je/2xD0BBblD9/kP/T1sQvoMZ5JhROYjqp4jVhc5X9wz 6Y0qiWHirinqnZ8JNGwwKEUkQd3fW79IvsJ9Za2+FqxAOkwuJTRbAHFC+GmBt8eT0+Hc dZSAKCVR/96ea2Sa9cHYbajVb+xj21TVqRVO9bLAMyLJQTs6siq52HRvyenIaimBB7zg KqA+kNLUPLKYZkU5PwwYoL+NJKeiH3foC4zs1mhR8DXKVKfiizCJ6oyvr1x/ExKQd943 LOcr0Sq9Rq7NB6ypcmlqoPCCktENOEUo/MYA6vOuRlr3sEOxAMa9RWvuNKjDqZEuoU54 cgOg== X-Gm-Message-State: AOAM530TZPfNKBNhgnrMjWEWnvbir6JZf0WQIpRVd3EBRNMmpc/gbXfW XJLiQyJz8lgS6dPrDuVHlURPpc5uFJCxpg== X-Google-Smtp-Source: ABdhPJxTL7hN64jZ1eeN49bgcwm3TWDsqH4cg7A5rncr5LGQ4mg4HZVa12ZRZa9evm4q1gxoo1ZGuA== X-Received: by 2002:a17:902:8b8b:b0:149:6d32:4b4c with SMTP id ay11-20020a1709028b8b00b001496d324b4cmr15320017plb.8.1643046481995; Mon, 24 Jan 2022 09:48:01 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:01 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Fan Zhang Subject: [PATCH v2 37/83] crypto/scheduler: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:33 -0800 Message-Id: <20220124174719.14417-38-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Fan Zhang --- drivers/crypto/scheduler/scheduler_pmd_ops.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/scheduler/scheduler_pmd_ops.c b/drivers/crypto/scheduler/scheduler_pmd_ops.c index f61640c9d646..f3a1bd626c6f 100644 --- a/drivers/crypto/scheduler/scheduler_pmd_ops.c +++ b/drivers/crypto/scheduler/scheduler_pmd_ops.c @@ -371,10 +371,8 @@ scheduler_pmd_qp_release(struct rte_cryptodev *dev, uint16_t qp_id) if (!qp_ctx) return 0; - if (qp_ctx->order_ring) - rte_ring_free(qp_ctx->order_ring); - if (qp_ctx->private_qp_ctx) - rte_free(qp_ctx->private_qp_ctx); + rte_ring_free(qp_ctx->order_ring); + rte_free(qp_ctx->private_qp_ctx); rte_free(qp_ctx); dev->data->queue_pairs[qp_id] = NULL; From patchwork Mon Jan 24 17:46:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106396 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8A9BA04AD; Mon, 24 Jan 2022 18:50:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 208F242886; Mon, 24 Jan 2022 18:48:08 +0100 (CET) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id ED5004281F for ; Mon, 24 Jan 2022 18:48:03 +0100 (CET) Received: by mail-pj1-f47.google.com with SMTP id g9-20020a17090a67c900b001b4f1d71e4fso506672pjm.4 for ; Mon, 24 Jan 2022 09:48:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6V9Q1x1ay+tYytT9xq7nAcA525Y1BSrTieqlJ955eIs=; b=PYJa6qHbukYkLdZ2qygUyFLSSRRLZkSj5kXAsCQ09ihFJHlLfX0Sf0sQhHsVPX+l0b FVhESbpFacD+LhyjkjQCep9tbpVbvYTWU3MKLuMZiBBaxd6IIfYuFagSMePFMSnfz/C+ wD7Y8gtSGOAyFlO2CLjoMbSQla9A5hTO4kELSGRzB7o2Fq3Ty9Y49S5bYQJZ/ImSD7pg lND+G9INOjibCU0IdwBVS2SC6kACQq9cCXRJPatqbO7dSt9FOIM9KM85wCbM6eaLmuUC P/U5r9fAjxCa71hdbNEKcgqog9twaJjtHaYKICqHTW7WOwOv82mKaJdfCHoesaIf3KNq zyDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6V9Q1x1ay+tYytT9xq7nAcA525Y1BSrTieqlJ955eIs=; b=nZcfodKnekhL+AK3GroT+n/mFBbwSkPbiqQ+GA8ieY6ZNv9ylX4Rvyt3mIgXan7s50 jnrD/+xuIQ2C9gep4nmVnsD7FcnDGNrTXP0k6rGDMg5wIH9oOTZSQBYkTNqPbeHlYnOX vZH981uZjT5L5HbsUNYhkisgOLEL/6W1mpUljPrFU3HlxqlIieoYlLXh3T0DgHnRwk7u LUikbq1hTiITT4sc6IHQkvtYyjGNRs8HPE/of1r5wNxeIrrLW9y9ddgHvuCUEX4GeHA4 vUdhEv24FiIUofeQ9kWXw129nKmSTVGsQeORoc8QmnBpX2sNf1HH4BNVFFK9QjESz/Hw f59w== X-Gm-Message-State: AOAM533l32AMFqylLl3U9QWqiFhDq4juKdhEoRZ3dUlb5VNOiB/y/9Uo ncMabQrV59j/CbsYsxuQDlzq2QFxEn2JWg== X-Google-Smtp-Source: ABdhPJzoelDXuFhjqBG2/xtlzMRfDrQmYwvNg+Uqqx2Xoqeh//5GwhgIke16LYj97rRKBRoVFV3vJg== X-Received: by 2002:a17:902:e750:b0:14b:5fe1:f807 with SMTP id p16-20020a170902e75000b0014b5fe1f807mr3210608plf.103.1643046482974; Mon, 24 Jan 2022 09:48:02 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:02 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jay Zhou Subject: [PATCH v2 38/83] crypto/virtio: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:34 -0800 Message-Id: <20220124174719.14417-39-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/virtio/virtqueue.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/virtio/virtqueue.c b/drivers/crypto/virtio/virtqueue.c index fd8be581c996..3e2db1ebd250 100644 --- a/drivers/crypto/virtio/virtqueue.c +++ b/drivers/crypto/virtio/virtqueue.c @@ -32,10 +32,8 @@ virtqueue_detatch_unused(struct virtqueue *vq) for (idx = 0; idx < vq->vq_nentries; idx++) { cop = vq->vq_descx[idx].crypto_op; if (cop) { - if (cop->sym->m_src) - rte_pktmbuf_free(cop->sym->m_src); - if (cop->sym->m_dst) - rte_pktmbuf_free(cop->sym->m_dst); + rte_pktmbuf_free(cop->sym->m_src); + rte_pktmbuf_free(cop->sym->m_dst); rte_crypto_op_free(cop); vq->vq_descx[idx].crypto_op = NULL; } From patchwork Mon Jan 24 17:46:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106397 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10153A04AD; Mon, 24 Jan 2022 18:51:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 168FC42858; Mon, 24 Jan 2022 18:48:09 +0100 (CET) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id 1AB2C428BB for ; Mon, 24 Jan 2022 18:48:05 +0100 (CET) Received: by mail-pf1-f178.google.com with SMTP id p37so16669776pfh.4 for ; Mon, 24 Jan 2022 09:48:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b9RGmpF2C2wCCBfC5oLCxPoLV/E07bsYUzvcP+VGLAU=; b=vujCj8mQQgKBezT49sdEjMQaV35XPiiMG/HaUVQrMZgWkRXWGv2+1jxxnTYzL0fFVR OMtVFShimaCk667I7rhhUrg4EgrejTK32unhLoy83UqjTinoRHm3oA2WxGtLDmkD90zu /00qKorO0AZoPwJvO5oQcF+7HzPRCBMinDpGcrTQaAtyXJBbJSsyzqkUXApcWZtBTmiN OVrxOkZ2fwY6AyBycJg8shNcwedjcisZirVytgJzuNeBbiDO1Sou0+JUKC55PtJVS2f/ 65evky5/Xry2c/m3Sqlxmwqkws0/gHneITwxG8VkvHHPp4m1PX1f8xvOpn92vQhZH8N3 1ELQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b9RGmpF2C2wCCBfC5oLCxPoLV/E07bsYUzvcP+VGLAU=; b=3nq96bXG8pZU0dcuLsb9TLXqWVVcLM2NS+heAX+o8j+ic+Yeyqi4BHDTc6NxIAgUQJ 6OZ8IsXskd0iHihbPq54FM89d75rj0JYIFlPDuH1NoGMA0Ie0CSmr2/0/Cqp7pGd4UCw V8tU4+ceWpxx3syrMkDaux3AhlUZ+T2kT30W/X2CqAScKo2+HtDgZpOOIYySgpO4GkK0 uEmx4uXgicKwHS+hHgH/a6jrBb8IrIp73kARxRHCBX2JrazV4FNY3+DXu3Ujmti/CeTR clPt9eOGK+qo6RAbwDt8seeS57lcUZPHXvtdn3ndYh5t9dxVp90gkjhi70Pp/aakVKlD R/1A== X-Gm-Message-State: AOAM533ZZJ6Mao5JJSXhR0ItlJ5cVFlOE1jDJBTkA5UYBuxIFeOBXE2z ENmwCNinRvpHKyF5ZSu8C7vbcr+jdiy8jw== X-Google-Smtp-Source: ABdhPJzH6TyqicpJl3VXa8MFWTYfu//crcI/Wc+ZtIkd8hr9tsNEPaKuRKhxrTHO3kSxICYptGEgBQ== X-Received: by 2002:a05:6a00:2310:b0:4c3:d3e:3667 with SMTP id h16-20020a056a00231000b004c30d3e3667mr15190721pfh.69.1643046483879; Mon, 24 Jan 2022 09:48:03 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:03 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Harry van Haaren Subject: [PATCH v2 39/83] event/sw: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:35 -0800 Message-Id: <20220124174719.14417-40-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/event/sw/sw_evdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index 6ae613e0f2e7..ba82a80385b6 100644 --- a/drivers/event/sw/sw_evdev.c +++ b/drivers/event/sw/sw_evdev.c @@ -526,8 +526,7 @@ sw_dev_configure(const struct rte_eventdev *dev) * IQ chunk references were cleaned out of the QIDs in sw_stop(), and * will be reinitialized in sw_start(). */ - if (sw->chunks) - rte_free(sw->chunks); + rte_free(sw->chunks); sw->chunks = rte_malloc_socket(NULL, sizeof(struct sw_queue_chunk) * From patchwork Mon Jan 24 17:46:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106398 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E62F8A04AD; Mon, 24 Jan 2022 18:51:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69ABB428DD; Mon, 24 Jan 2022 18:48:10 +0100 (CET) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id 7224B428C4 for ; Mon, 24 Jan 2022 18:48:06 +0100 (CET) Received: by mail-pf1-f173.google.com with SMTP id 128so16678998pfe.12 for ; Mon, 24 Jan 2022 09:48:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BLI65pAkl2Uesd7NXA66nH3tfFeFOpHNaRIG+fzMF3I=; b=ijjtXNJlMBQdC4pfoqSGgIWaLr7h9mGOhBK+YcJybXVDB10jOKEG9icIU1HuVm/ird 5A34hnljz0isUhVXwi32hA6llnTwIfUt3GCoVSJUFFIh15IEtXPD0AfbJq0qxKRo10Wu 6mSxJxVseCmVT3BcoshYRo3Z1GItJz8AMVKcHGfCVSOoRhRDzQqRE+IascuPCRmui60t V10pwZ93LIfWyl1PVOuAXMaQDtY8qudRrlJXg7061PJxw12yfIyeqO9kiDdjHLHzj7FL btXEXsLJLeYVdInKSyT9dZLE9SEqgyLT+dpz3dzDjDNby+z+47NVkRw6rTpLNARuMpll hUEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BLI65pAkl2Uesd7NXA66nH3tfFeFOpHNaRIG+fzMF3I=; b=SxGblEqajaxKBHHhZYjckYq5PosObhvgpeC6i8kF353QIhoigFao0Q/H7mop2tWKWH vL9pcbNdpyovgsNcd2IH8VP7Hr61qzHtHAygVj3cDxvnQwT2Gu2hEPt5pDsJzzfR6zjK Khvx8xp0IvJ0oXCJHxdF38P6nmIkuacT8LEbxabQ3SGY2B2J1tTnyVZhuHF9kAsrBvUg qX1N86iEaI3U81+J1D1ktxaA+1o5vrBnxeerjZEW+zkC+xv6xFlmRlm2rpUGu/1EpxAH q0zH3GD6Q9+ZG6aUMOEmUv+fQrKvv4ZmKWynYCha3Y5F38hzYi2qnUezW8pS4zKtjR+Z w6UA== X-Gm-Message-State: AOAM530FK5iqYf+SDo490F8mz6FBsBzNJN2MBqThHe/lNDOxGAdPKq4P LvFGkiFToRixgiXOv4yEubGicYTnQZ78Ug== X-Google-Smtp-Source: ABdhPJzLSSi40uAps3I6U0j8yIy4CCLZvuGG+wSDWnz9Lz1y7BRneDykgKf89x40tIhnKraBXfG6Kw== X-Received: by 2002:a05:6a00:1413:b0:4bf:a0d7:1f55 with SMTP id l19-20020a056a00141300b004bfa0d71f55mr15008624pfu.13.1643046485448; Mon, 24 Jan 2022 09:48:05 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:04 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Chandubabu Namburu Subject: [PATCH v2 40/83] net/axgbe: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:36 -0800 Message-Id: <20220124174719.14417-41-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/axgbe/axgbe_rxtx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c index 6bd41d3002bf..f38bb64fab6b 100644 --- a/drivers/net/axgbe/axgbe_rxtx.c +++ b/drivers/net/axgbe/axgbe_rxtx.c @@ -22,8 +22,7 @@ axgbe_rx_queue_release(struct axgbe_rx_queue *rx_queue) sw_ring = rx_queue->sw_ring; if (sw_ring) { for (i = 0; i < rx_queue->nb_desc; i++) { - if (sw_ring[i]) - rte_pktmbuf_free(sw_ring[i]); + rte_pktmbuf_free(sw_ring[i]); } rte_free(sw_ring); } @@ -507,8 +506,7 @@ static void axgbe_tx_queue_release(struct axgbe_tx_queue *tx_queue) sw_ring = tx_queue->sw_ring; if (sw_ring) { for (i = 0; i < tx_queue->nb_desc; i++) { - if (sw_ring[i]) - rte_pktmbuf_free(sw_ring[i]); + rte_pktmbuf_free(sw_ring[i]); } rte_free(sw_ring); } From patchwork Mon Jan 24 17:46:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106399 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F71EA04AD; Mon, 24 Jan 2022 18:51:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A133428D6; Mon, 24 Jan 2022 18:48:11 +0100 (CET) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by mails.dpdk.org (Postfix) with ESMTP id 9B4BB42886 for ; Mon, 24 Jan 2022 18:48:07 +0100 (CET) Received: by mail-pg1-f180.google.com with SMTP id q75so16026994pgq.5 for ; Mon, 24 Jan 2022 09:48:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iMkK/DcRMDPcFADA5l0+rEuzH5/Li3lybppd2h3tuz4=; b=Abc8Vz3cPTBVat7rAfJQZ+YehfmiWbb/6QAR2ZO/2lFRw5AToKPQ74xmTmj9cll3Ug dv7cuLUO/1hETonHWbC6vDQdtoon3oHFHOW6vz4luLk++6OpKLx2uPREHQdP+gBloXPa LfhavgNelWL4N2MvjJJgknnzHe3rtaMKgk7Qcay12140XDVjLBSHBgmsFAtJSUlK6db4 A0YE5TFKYjV2SaPJvJFGbE6HkCUmpyHnATMjAHHmRwIYSdOOjkb1RdZIIfYhj2kqwUOU ggmOIv80itNZybuCs5zU8gY1s4JzKqMq1/4vJICFS7aoViAVDvHd9NyjcWKEp1CbwLi9 a6vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iMkK/DcRMDPcFADA5l0+rEuzH5/Li3lybppd2h3tuz4=; b=Kyfi8fCByILi17V3UnU/nCZH5gk8MJBsEHkhNNTkPWdt7DSH8fXu4AXj/M2KoBVi0O p8aH1gomxNVDpMYz+sKFlaTAeEJF+bnxk7lx/zUSvUW7xWpF3kK2Tw0H12FvehhPva4o zTCrONdJ/opdjovj3xC+gXV9ag4A2SrSTsYrw7hgVnBzgDpaZG7cEO0/6ZDlVPtOVcUX R+RUd+bo6cKczA1bJzTz6sJu/aN3z5fqyPHe0BaQnuBTrFTc5zE6bEqO0cnY9iVXhOF2 NOyzm6+J8VvAC9SBT6JxRlKeFygiGhPUHSVpGwwIhVxSaEqXuVS+KFkvjwXjpsmVJFc9 IPmg== X-Gm-Message-State: AOAM532/sY3KrCfTfzoVM/Odht7lm10Fw6CASEg9aRHDd1yTe5By+1rC cXx6RGcBphzjeRvMwhrKituf5I8KxFA/sQ== X-Google-Smtp-Source: ABdhPJwUDWG2j7CpPVcwVROnWMaaXoJ2Uav6oVVEeq9aiPi7seZx6yzUcdRRXp8bm5Sdqrzoc967aA== X-Received: by 2002:a05:6a00:18a6:b0:4ca:38e0:400d with SMTP id x38-20020a056a0018a600b004ca38e0400dmr2055496pfh.22.1643046486638; Mon, 24 Jan 2022 09:48:06 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:06 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rasesh Mody , Shahed Shaikh Subject: [PATCH v2 41/83] net/bnx2x: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:37 -0800 Message-Id: <20220124174719.14417-42-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x_rxtx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c index 66b0512c8695..00ddccf151fd 100644 --- a/drivers/net/bnx2x/bnx2x_rxtx.c +++ b/drivers/net/bnx2x/bnx2x_rxtx.c @@ -27,8 +27,7 @@ bnx2x_rx_queue_release(struct bnx2x_rx_queue *rx_queue) sw_ring = rx_queue->sw_ring; if (NULL != sw_ring) { for (i = 0; i < rx_queue->nb_rx_desc; i++) { - if (NULL != sw_ring[i]) - rte_pktmbuf_free(sw_ring[i]); + rte_pktmbuf_free(sw_ring[i]); } rte_free(sw_ring); } @@ -172,8 +171,7 @@ bnx2x_tx_queue_release(struct bnx2x_tx_queue *tx_queue) sw_ring = tx_queue->sw_ring; if (NULL != sw_ring) { for (i = 0; i < tx_queue->nb_tx_desc; i++) { - if (NULL != sw_ring[i]) - rte_pktmbuf_free(sw_ring[i]); + rte_pktmbuf_free(sw_ring[i]); } rte_free(sw_ring); } From patchwork Mon Jan 24 17:46:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106400 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55560A04AD; Mon, 24 Jan 2022 18:51:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F9DF428E6; Mon, 24 Jan 2022 18:48:12 +0100 (CET) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id E410242858 for ; Mon, 24 Jan 2022 18:48:08 +0100 (CET) Received: by mail-pf1-f172.google.com with SMTP id i65so16674872pfc.9 for ; Mon, 24 Jan 2022 09:48:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=idSv0Xois/xOCqYAQfLwmkXZmbscIETT3rWLZhL0AOU=; b=mCODW3nn8S+H6bb+DzPnpVMGSSTLZt6038Dwq+mTJSp74iwfeMK590mr7O70FTlwMP q2xI+Y+QQBSSCDgfHBm/xIPbUduBAOdu9VOOuCPYbJvWUbOPrDhXyWa1E08JIs9luEVj IH93CBSZGKPIoR0AbmysFHl3ZEcC2+E7jIgDkv7/fPFE0UtCGjTu3MPw/oytUhVcq6VJ FX08a9rzPyzUREuOd06jwFQsD4t/Zte5e1/jnOw+zaWw6RhVBIjUUsszXVGT2bzCfz60 hOxLMQE0GXva/GGHo0xPw6S6XbYddB8gR1+TbAbH56RQPYIbNCGG2Nx9rwmRsKur6F3V pHOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=idSv0Xois/xOCqYAQfLwmkXZmbscIETT3rWLZhL0AOU=; b=M4TH3RZ8T+3CRu5hrIi9LVynfX3ANBMDAY0pOA4Uixp9RLTNemspQ2xJdz6siPhPU4 Q/hWtUgOjEDFQ/bc9Xn4kDYSCZ052nAPOZQTnfLnaYaFXWlHxlB7npQECF4+7unz+hu8 JquGptuu6p4LjyXJ/TqrmsLTDMEZHMWpYMLTq7Simj1vFheB97OD1F3jCjzSj/C5cigO l5LC0ceFK50R11UxkG8FVJi4rP3mnJS9Af+Y7Ysrxa0bJqUbn+sppkT4wgZvjz5tehEp mEwqKD1BeIQjVDAb7mWIPhQwhzhVKXqGlcxqIjIbhEwCQq56fNQA/5Nk3cHZxfd8UTeD 8HVg== X-Gm-Message-State: AOAM530rfmyTG1WHufoUnTtNERjwg0l2f7ExBCBGEb8g9390hhqjvmgp 9G5VC6Uzm8WeGjbfDcsIJ5uxFMuuerNlQA== X-Google-Smtp-Source: ABdhPJxUc9P7p6daU56guXhlN+3sVgJpL9uXqN4asUxcZPDHFFvWZ9Sb+F77ZzyXezxdEdcrKPIJcg== X-Received: by 2002:a63:6f8c:: with SMTP id k134mr12592485pgc.35.1643046487631; Mon, 24 Jan 2022 09:48:07 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:07 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ajit Khaparde , Somnath Kotur Subject: [PATCH v2 42/83] net/bnxt: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:38 -0800 Message-Id: <20220124174719.14417-43-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index f79f33ab4e17..78339d43674d 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -5833,8 +5833,7 @@ static void bnxt_free_ctx_mem_buf(struct bnxt_ctx_mem_buf_info *ctx) if (!ctx) return; - if (ctx->va) - rte_free(ctx->va); + rte_free(ctx->va); ctx->va = NULL; ctx->dma = RTE_BAD_IOVA; From patchwork Mon Jan 24 17:46:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106401 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4ADACA04AD; Mon, 24 Jan 2022 18:51:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E3F8428EC; Mon, 24 Jan 2022 18:48:13 +0100 (CET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id E7929428D4 for ; Mon, 24 Jan 2022 18:48:09 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id p37so16669988pfh.4 for ; Mon, 24 Jan 2022 09:48:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zkr0ICvLVL2t/HP9KwQdbKbxig7p/kOYPIjwjT/68u8=; b=S7ZYATxw7Trng5NDXta7z7kdds2n5J/MXj+OD2/MkoLooGB7ZbBtVmwsTpY2u0gnSl j/4AollHsmZghEbtDzFDfjUSODgcFvulsIVlkeDHw+9q/cFm7ClipaWHfP0nGqWnYV02 24Te++IFmlalPO/MoVwKpbax7f2ll7Ii4rBlcQv/JkODcccIxnieTzNxp3NDxnlbVZMG JSUMcKPW2owWYZne/YNaPmg6HuaZ/G9JjkptHDni0H2hlBBHqH0huE1Ihir0op8Xjzqv W79rYWN5E3b3bHtO+YYr4KEH/tHdGQaAJrxJjZRcMsCFaF/D1eFOToW/nHkRJZpM7GHL FlqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zkr0ICvLVL2t/HP9KwQdbKbxig7p/kOYPIjwjT/68u8=; b=tICyTZeECQJ4+7v2daCguSF4G8sa93kjTXzqEtJ4OwpvlReFnR/+rMoXNYMkpGdw9N yIsvwszoPAJ/ujHQdiIriJa4YYQudjzfrdN+Etkk15u6oiVVqT8U+Fjzxg6QdXRe/c5t eKLnTNG8PqKryGMVND4pN1kPqOG7qxvAs5dXyFtAcGyrZSNG9iPgflPBdYDxS8aLU3ks kQg4YkdwPhlaQw42VTRI/LywAxMPNhGaAegHklF2Q0o+ShyGWMUmT8UPqzZNxbja1UU5 8yJ1i/kz53Xoa6A0zoo5RTRvBRFspyPvmPAaz5fRLSrYdC+UNhfiYbtqCWOFl0Mk2mHu P70w== X-Gm-Message-State: AOAM532syIcCk0viKrGwxvBkMK01+ZZIVTV7m58p2o+zJPXydCXI/rqD Rj3S3+8o+VCR+c9StspHlIhjf75zPAxUQw== X-Google-Smtp-Source: ABdhPJyLPeKKIqZTFBHu+r++BDobSlSq0zbRn997iQo88n1de8PMrPUN4SKvlgiBNYpRip6ZRuLWjA== X-Received: by 2002:a63:2b01:: with SMTP id r1mr5312505pgr.182.1643046488934; Mon, 24 Jan 2022 09:48:08 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:08 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Chas Williams , "Min Hu (Connor)" Subject: [PATCH v2 43/83] net/bonding: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:39 -0800 Message-Id: <20220124174719.14417-44-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Min Hu (Connor) --- drivers/net/bonding/rte_eth_bond_pmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 84f4900ee52c..963280828a65 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -2148,8 +2148,7 @@ bond_ethdev_close(struct rte_eth_dev *dev) */ rte_mempool_free(internals->mode6.mempool); - if (internals->kvlist != NULL) - rte_kvargs_free(internals->kvlist); + rte_kvargs_free(internals->kvlist); return 0; } From patchwork Mon Jan 24 17:46:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106402 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60A8AA04AD; Mon, 24 Jan 2022 18:51:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F29D428F3; Mon, 24 Jan 2022 18:48:14 +0100 (CET) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mails.dpdk.org (Postfix) with ESMTP id EE9C3428E1 for ; Mon, 24 Jan 2022 18:48:10 +0100 (CET) Received: by mail-pg1-f170.google.com with SMTP id e16so6721724pgn.4 for ; Mon, 24 Jan 2022 09:48:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wDg5SMDcUa1LIz/hXRZsYHoriVWc+RGAiy3a0kXoYGQ=; b=ZfLJOA78jIUIxJzvG7dGt7krh+GeSQhYfCuBvnKDBqnPeszicRoZMFEjgT3llqLK/I 2aL/O5UXq8PRrknW18XurogKGhR/qi/5cv4P/hnSB8kficLIL8NSuy0yTH9T/OztWVzl Pviv9VuBj06YGSAQ7NbIdw+R3CsoQuUs67SUJ8NeqqIw8ZKkNYa8HeCdw3/ED3Ztm/qX HSL/A/nffhfiqPLFI4jMeF3nU8NVw5TXepoO7ktuLyspZ6qN9ADw9Hr0h37Hhyq5fl++ 0/hV2/GzakmyTWdtcH8k0oNnolMQSGgK5PHkg7Pp2KI3VmxelMFeH3Mn4XT4fhrWNzio P8Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wDg5SMDcUa1LIz/hXRZsYHoriVWc+RGAiy3a0kXoYGQ=; b=PTcKvcHy+KeabNJrl4KvtfAnfncXdyu1sy/mhKo5YJx/rRq/sgEK6lo9PPxbTyiH/B qMFcIeTFhNVB9+x7ZM9SibkLRl+Ar4obfjhORBZUIxreNJFcA8KSd5HRgf0P2CP8ycfN lxqVBb8zDdLFZrtcg6RZ1Ti3V4guTpZXFaP+egG3V3Kk4flQWe2VgRV4kCgZAOY3KNmZ Ybyy23qd+no0jwplwvmeP9OYokS5KYGRHmsmfq6PK58SDzL3CJ6PkGkbH8ksQDJelv60 zGJAjLdvC4t3wMtWTqV6TdQN3EkKKqsVXf/0LQcbHbCGchcmVQUJ0iy0o0Ub7JbuamWU ALLA== X-Gm-Message-State: AOAM531G+p+ZkX7rWErkXsVZCpVsD9W2HHY6QSwKbSt3kunBGMtWN0rl O+gatsQY0QHVoKofPIT/fhHTtdaUX35m2g== X-Google-Smtp-Source: ABdhPJx6xXPM4C6ImYywys16HP4jCv4+YIfU8vRMtLTo4qhoG+8pmVRSKMT0mIFsMUJS9k0J0EndPQ== X-Received: by 2002:a63:1ca:: with SMTP id 193mr12342395pgb.497.1643046490033; Mon, 24 Jan 2022 09:48:10 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:09 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Subject: [PATCH v2 44/83] net/cnxk: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:40 -0800 Message-Id: <20220124174719.14417-45-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cnxk/cnxk_ethdev.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c index 74f625553df4..d679a1f78501 100644 --- a/drivers/net/cnxk/cnxk_ethdev.c +++ b/drivers/net/cnxk/cnxk_ethdev.c @@ -934,10 +934,8 @@ nix_restore_queue_cfg(struct rte_eth_dev *eth_dev) for (i = 0; i < eth_dev->data->nb_tx_queues; i++) dev_ops->tx_queue_release(eth_dev, i); fail: - if (tx_qconf) - free(tx_qconf); - if (rx_qconf) - free(rx_qconf); + free(tx_qconf); + free(rx_qconf); return rc; } From patchwork Mon Jan 24 17:46:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106403 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB278A04AD; Mon, 24 Jan 2022 18:51:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27E69428F7; Mon, 24 Jan 2022 18:48:15 +0100 (CET) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id 4013B42838 for ; Mon, 24 Jan 2022 18:48:12 +0100 (CET) Received: by mail-pf1-f180.google.com with SMTP id v74so13428537pfc.1 for ; Mon, 24 Jan 2022 09:48:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ePoBxhFnXpor/e/eN5ziI+XeClUhfT+oxa/W25G3HY0=; b=uxSVdgQ07isHk/XpV7+CASeU9GG2QH/vHViss142XyKfbkwrYAfRNCFZ8NcxsyYlBa ellF4l15uESZOpsPOf1PL8iKUjfuMtfScHD5RbtZlT3TH3Ka++OfzQZau36LZy6x6r8g bzS2PCw9pSZ7en3IIkbQnybtv7SpO9CCMCnqlH6aQLuwvITN82MHgKB4WLCWmNuNkI4W Lp+yWT/PJQ5/opN1DqyxU2H6ARV/CiiRD8vHWFD2J5eYuRuPvaftHF1AbcEaXl3FFg4S YETCfC8ntvnmxhSIJaEqZvSivDirSXVjdU6nrKjJ3cIng7f2srvi9xh+UwMdryPqnFwF YVIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ePoBxhFnXpor/e/eN5ziI+XeClUhfT+oxa/W25G3HY0=; b=NbKQc+7S4Ag4gRg2INMxCGW5MMr6E90XB1W2WvrmX8Z6r/KCT35CDjMDiu3yW1BMaq ReeU+x58bPOsnkRqW7f5mkx/pLYePK4RXO82/uuM1nNUGz3BWABI5pGLvNPft8XNzscM YhG2V0CjpD40EPk9+kIsmkHMNtYvdybl3Q8jaX5dOBy3h2IAEs8kb+yqOD+r6yZHu+YX gZ+Vqc3gIlL52s10n6+F5O+KQ4v5Qvj3IzlwmS8yF64PFdgBPXy38S4kkMxtkHHj4MDS nHR4FRt6o4PDyB1vlwGBPud2WBUKu2+AgyKcc2+/qifag4XaeNoiiqRtY/6LbsTy6Ws7 QU9A== X-Gm-Message-State: AOAM533oG6a+vm9GUMj5GzxZ03f/2rsp/ne/BbMHteiVRoB4fT0BfBZY B97NM8gJpeqDFVAx2q0C1PxePUxly+A1lQ== X-Google-Smtp-Source: ABdhPJyVt3/PHjWYPeL6R7BcoT5KPQPGhFOBXEBvMBOc8+icdSzj74H3QSPTviFCvYgFwkC+QHIWGA== X-Received: by 2002:a63:9142:: with SMTP id l63mr12631306pge.476.1643046491201; Mon, 24 Jan 2022 09:48:11 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:10 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rahul Lakkireddy Subject: [PATCH v2 45/83] net/cxgbe: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:41 -0800 Message-Id: <20220124174719.14417-46-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/cxgbe_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c index f1ac32270961..ab06e30a5e0f 100644 --- a/drivers/net/cxgbe/cxgbe_main.c +++ b/drivers/net/cxgbe/cxgbe_main.c @@ -463,8 +463,7 @@ void cxgbe_insert_tid(struct tid_info *t, void *data, unsigned int tid, static void tid_free(struct tid_info *t) { if (t->tid_tab) { - if (t->ftid_bmap) - rte_bitmap_free(t->ftid_bmap); + rte_bitmap_free(t->ftid_bmap); if (t->ftid_bmap_array) t4_os_free(t->ftid_bmap_array); From patchwork Mon Jan 24 17:46:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106404 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36809A04AD; Mon, 24 Jan 2022 18:51:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E53B42900; Mon, 24 Jan 2022 18:48:16 +0100 (CET) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id 37A3F428EA for ; Mon, 24 Jan 2022 18:48:13 +0100 (CET) Received: by mail-pf1-f173.google.com with SMTP id e28so12224189pfj.5 for ; Mon, 24 Jan 2022 09:48:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gcywuAvsRBzYcqxW8NyRl7w7+GW1d4SBgXQVz1wk4c8=; b=IZOGnyFRVeovGbbnhmeMS6XJkGES7QA7H4shnzgYfWEITZBp0O3O7CfPERPAJ3Neth 71QE6HH+HXiKyYq4PUH11Y/O4Vi0fABuHZxbXxFXtJOwSY/7G7ChSSgkNjG7xtUkcjOs cfIZtynG/dA8pnVfT4U2nw35/pnBe4NgaIkLI4sXyk8Cni7sl+5mtxqkSgwv4unqLKL4 WXI5TLsBGB8HKQnS09BXt6EOnut4qBIiIgemkqQeNDvIlsOmbmgdZLnZ8XUZO4KqVqyV Sav8grcwBWCyRGpYlZ519E7olCIs1zH0TggRBxwXKyiL4nMkfUHPB3M4f/MzhvozdGvK YJwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gcywuAvsRBzYcqxW8NyRl7w7+GW1d4SBgXQVz1wk4c8=; b=Fa5JQvSxnUy5jBriXNSxW7+zKKhgY/eAc2WwgL4O8+6krueRffvrc31rERnpOzxmKu vv/JncHTqPd87vCc8eYG/YyqFzQco8n7rrb6Eu4ChbJK/PfSwZI6WXOSvNpodJAo0qJ2 v1LzkRnA+034sovz/JAU0Lciog315dFK3fbraVoMUAweocdVlPyGcsxUl6yIGf1gGS1m pJXF9bNsfNCDa3djNaIfCM20LWV6CftKimdGr9eJmYcG4vA064iiC08Tt4mTfBElgUDT ptTGfxr634asg7Yrrq70KLM1GzRGz+amao/EquFYwTGYh4SSBLoBY2GWisveoOKnC56y eK1w== X-Gm-Message-State: AOAM533FEPBBU4RU5kLGPSyZnPwa6RahYt8tKKImonV7HhcYP2ZTpj74 Q36x2ih/OfFfP16ZGrMU81H04hAZxwUvIA== X-Google-Smtp-Source: ABdhPJyxWSuxQsl9udgwV5Kas6MBODAddCgKh52ocpa3vsyeWawnRIxhobKFbvFCUMjLvsm6jU+MdQ== X-Received: by 2002:a63:8a42:: with SMTP id y63mr12678336pgd.251.1643046492228; Mon, 24 Jan 2022 09:48:12 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:11 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH v2 46/83] net/dpaa: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:42 -0800 Message-Id: <20220124174719.14417-47-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/dpaa/dpaa_ethdev.c | 3 +-- drivers/net/dpaa/fmlib/fm_lib.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 2c2c4e4ebb5d..90208a31de26 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -463,8 +463,7 @@ static int dpaa_eth_dev_close(struct rte_eth_dev *dev) } /* release configuration memory */ - if (dpaa_intf->fc_conf) - rte_free(dpaa_intf->fc_conf); + rte_free(dpaa_intf->fc_conf); /* Release RX congestion Groups */ if (dpaa_intf->cgr_rx) { diff --git a/drivers/net/dpaa/fmlib/fm_lib.c b/drivers/net/dpaa/fmlib/fm_lib.c index 0d1ca12378d8..1d6816050c2f 100644 --- a/drivers/net/dpaa/fmlib/fm_lib.c +++ b/drivers/net/dpaa/fmlib/fm_lib.c @@ -408,8 +408,7 @@ fm_port_close(t_handle h_fm_port) _fml_dbg("Calling...\n"); close(p_dev->fd); - if (p_dev->h_user_priv) - free(p_dev->h_user_priv); + free(p_dev->h_user_priv); free(p_dev); _fml_dbg("Finishing.\n"); From patchwork Mon Jan 24 17:46:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106405 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23777A04AD; Mon, 24 Jan 2022 18:51:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4535742902; Mon, 24 Jan 2022 18:48:17 +0100 (CET) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 39A3C428F1 for ; Mon, 24 Jan 2022 18:48:14 +0100 (CET) Received: by mail-pj1-f44.google.com with SMTP id s61-20020a17090a69c300b001b4d0427ea2so21160923pjj.4 for ; Mon, 24 Jan 2022 09:48:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2b55N7bXSpRzSFdGI25U4RUzQpLVPxW/BVtkfhv0RJ0=; b=fNRy0S9ODPv9GdESYjGkrpbcoLsPpxvFiIrwlU1oyR/lAsGtp4/Zzb6MwDuo2KIvck /1O2Fnn6dZt2GD1Ua97BTA0kaon2oREza4UKGTbVxfLLCtqGzk6arsN3LEwg0wYTJEcm N5sJfnGqwR32I3fzJAg+VeoMLb9pB7TVhu5U0PHrNASLESvH0G++VTUSmX6TBCCIJaF5 +/lBqyTlm0K9Y0Ersi/kFLr6RRbf8v9VWKnl9I0DKKJQAZU3qe8DPWOb1ROD/toBHcqk Boja9w7K6pz+58ZNqo3tglTo7cTtZ0vV1atZMQe3xkNOjqPHdX/ajZzZrpwf6JWKFbOB A1tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2b55N7bXSpRzSFdGI25U4RUzQpLVPxW/BVtkfhv0RJ0=; b=dqpjNF2Nu0S758X1KR3lIeZiB2dTfYNBUvvE9nVvbtNk1DqQOEr9CUaXtKThVWsRVE R+402PutnQys3jefM2LCv4LuaUJ1p1dOBMz7dx1GIePI2L+TcV8sbjmtk10DY15gjcA2 J+inA2lQSEzDcB6scmea0/TJk9nOJkK6sNgFItSLJ+qRL/+eFlOgNzQ9Wx1T7/LCeRuC yCnMAtodeVNN6GjcldH6DJZWaaT2TDNhPzbZ284JyqlpDWp+hutY8T3NQS1s2IhWFxhN V3L8OqoGPgaQ1SMMGGUFvll5zEIJD40P+UlWBo/PPTmZ9Gry1ZwoW0+nEkgBbcmIC6rs f1jg== X-Gm-Message-State: AOAM532Aa2JzPonecNQAnBhLC2Vg1fKdtOGUVUr3JxBSB6S7DNBLgiLc UingDH/sGUHf0S6/5tVStmx6pQ52AdWPRw== X-Google-Smtp-Source: ABdhPJxTlu/GetJoekYpCLDbd/W//FDLxGurmI9mqNLqy1Lgl931yiRpLo6t1fOR7GLsKDMB0YkDog== X-Received: by 2002:a17:903:4101:b0:14a:cae5:48a with SMTP id r1-20020a170903410100b0014acae5048amr15406036pld.25.1643046493260; Mon, 24 Jan 2022 09:48:13 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:12 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH v2 47/83] net/dpaa2: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:43 -0800 Message-Id: <20220124174719.14417-48-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 3 +-- drivers/net/dpaa2/dpaa2_mux.c | 3 +-- drivers/net/dpaa2/dpaa2_ptp.c | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 2b04f1416853..6b85b7740cfa 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -504,8 +504,7 @@ dpaa2_free_rx_tx_queues(struct rte_eth_dev *dev) /* cleaning up queue storage */ for (i = 0; i < priv->nb_rx_queues; i++) { dpaa2_q = (struct dpaa2_queue *)priv->rx_vq[i]; - if (dpaa2_q->q_storage) - rte_free(dpaa2_q->q_storage); + rte_free(dpaa2_q->q_storage); } /* cleanup tx queue cscn */ for (i = 0; i < priv->nb_tx_queues; i++) { diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/net/dpaa2/dpaa2_mux.c index cd2f7b8aa544..bd4596b89149 100644 --- a/drivers/net/dpaa2/dpaa2_mux.c +++ b/drivers/net/dpaa2/dpaa2_mux.c @@ -353,8 +353,7 @@ dpaa2_create_dpdmux_device(int vdev_fd __rte_unused, return 0; init_err: - if (dpdmux_dev) - rte_free(dpdmux_dev); + rte_free(dpdmux_dev); return -1; } diff --git a/drivers/net/dpaa2/dpaa2_ptp.c b/drivers/net/dpaa2/dpaa2_ptp.c index 8d79e392445a..5fcc36abe7b0 100644 --- a/drivers/net/dpaa2/dpaa2_ptp.c +++ b/drivers/net/dpaa2/dpaa2_ptp.c @@ -168,8 +168,7 @@ dpaa2_create_dprtc_device(int vdev_fd __rte_unused, return 0; init_err: - if (dprtc_dev) - rte_free(dprtc_dev); + rte_free(dprtc_dev); return -1; } From patchwork Mon Jan 24 17:46:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106406 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 917F9A04AD; Mon, 24 Jan 2022 18:51:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E2FB42910; Mon, 24 Jan 2022 18:48:18 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 28D9E428F9 for ; Mon, 24 Jan 2022 18:48:15 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id c3so16314508pls.5 for ; Mon, 24 Jan 2022 09:48:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EEz+Js5g3V8LrOBQCU9G8QIGXyNA7B4fE0VPNx667uo=; b=4UesXO07yNibrHG+BVwvOJrZzgxzGnzchcWm3A4MJiJU+x51FyyVJpiS555u4eVK49 ImoY9lNG6g7UBV4apa9UnCSs7+yFAb4nIcdt+C2GYcPO6v5ersG7WjMa47ftRi4TuAMp JMCW+YelF/5YSfJr0RXjc3QFVwP0uMwQzFQfXSlUzSROVFVDdZztrTt1SEosc7hua7RM oecNVIerMjTeo2ww585wHiVTFLh5gkLhMy6s3xVG8psa5XUwYRyBnmLtbfkOkI4IR8rQ IHT00f3fQNVxIuJNifWaeIdNK5pANA4gyVlD0D2S+h3gRIuMcrJbDkEjiyv0gKxr4tXo dzmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EEz+Js5g3V8LrOBQCU9G8QIGXyNA7B4fE0VPNx667uo=; b=nalYaK7C8TJwFZHy0WGil9WgCysfp/Z0SM4+eZJumABccBKqctSDdWgTaAWbVy+2BO cp1+riybBYsrZH9r0joIwr/emqrTDf3lTwmPS5UGWY1P7KJGtfVMypSxTHmJXM7vG2TQ I6W16iU0z/eFh6VjZVJV5gl++/Q/tyYOGNrPNaaJoYv8vsNog589PNwhEmRr9vc8weWc H7IeiY7qyS4GQpKQ/4vqiOu0lTWGpTjbPnYB5pg3+1VcXAsxw/iviZkxqWHlYub7rcYP 3/ze+eNGCAke00/twEGYKTDSESQs4sDj95afcuT++MRD1KPp0EgjjxipbTKmn97jZKGn CKqg== X-Gm-Message-State: AOAM532Ab/hNh5Cwiy2IAQ0Awa8DGskNJRpFluE2/Dd9+mLvviI9m6L8 VXmyyN/VpzCiKSImLIXlPbByEPR8em3CqA== X-Google-Smtp-Source: ABdhPJxcidqLAofM5cRtwNOM1EFaZzfKAP+B4Sr9ij45xOcicWO3IeXHdvJ/2nT6HiAzIJod+BYlHg== X-Received: by 2002:a17:902:b586:b0:14b:6bab:55e3 with SMTP id a6-20020a170902b58600b0014b6bab55e3mr1166493pls.43.1643046494183; Mon, 24 Jan 2022 09:48:14 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:13 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin Subject: [PATCH v2 48/83] net/ena: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:44 -0800 Message-Id: <20220124174719.14417-49-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ena/ena_ethdev.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index dce26cfa48cf..db2b5ec8e77b 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -567,16 +567,13 @@ static void ena_rx_queue_release(struct rte_eth_dev *dev, uint16_t qid) struct ena_ring *ring = dev->data->rx_queues[qid]; /* Free ring resources */ - if (ring->rx_buffer_info) - rte_free(ring->rx_buffer_info); + rte_free(ring->rx_buffer_info); ring->rx_buffer_info = NULL; - if (ring->rx_refill_buffer) - rte_free(ring->rx_refill_buffer); + rte_free(ring->rx_refill_buffer); ring->rx_refill_buffer = NULL; - if (ring->empty_rx_reqs) - rte_free(ring->empty_rx_reqs); + rte_free(ring->empty_rx_reqs); ring->empty_rx_reqs = NULL; ring->configured = 0; @@ -590,14 +587,11 @@ static void ena_tx_queue_release(struct rte_eth_dev *dev, uint16_t qid) struct ena_ring *ring = dev->data->tx_queues[qid]; /* Free ring resources */ - if (ring->push_buf_intermediate_buf) - rte_free(ring->push_buf_intermediate_buf); + rte_free(ring->push_buf_intermediate_buf); - if (ring->tx_buffer_info) - rte_free(ring->tx_buffer_info); + rte_free(ring->tx_buffer_info); - if (ring->empty_tx_reqs) - rte_free(ring->empty_tx_reqs); + rte_free(ring->empty_tx_reqs); ring->empty_tx_reqs = NULL; ring->tx_buffer_info = NULL; From patchwork Mon Jan 24 17:46:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106407 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92B79A04AD; Mon, 24 Jan 2022 18:51:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E17E42915; Mon, 24 Jan 2022 18:48:19 +0100 (CET) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id 25CD8428FD for ; Mon, 24 Jan 2022 18:48:16 +0100 (CET) Received: by mail-pf1-f172.google.com with SMTP id 192so13240556pfz.3 for ; Mon, 24 Jan 2022 09:48:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PtGwKFlFN1UZntsSRkxw8yKwwbyOM2mNPtc3IrzMgQk=; b=GWYtmGvr8I+eFupl/ZJm3Js05nDhy+J8NDGtH4hdYaDHlFZHEtJx0Ygir6omvMwQNZ 7Xfnea8r5j7mxowg8H6DLYxbNJXPJRljZ9Xb12fGN+C9+JKhs3CEHnigQGwUEsQXTnDE X+QapG1qfnwlR4SmUApe9siD18x5o6ZvldQclswnr3Pwpt8QOVFNP4iEMZG1+E4F7ByO XwCmOMtZb8SbhOWcpb9vN5l0CZaUHeoVB46KSchaPPuY9PZrvm9z4BD7vYoCnacaruOg ZLL9pmiVkYxLHGi8YCrIt/kLBVIlJDVcmnyuC4K+TGRiRNd/sCB6YZX394PDb2eiqCEo fuIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PtGwKFlFN1UZntsSRkxw8yKwwbyOM2mNPtc3IrzMgQk=; b=fZWG1MUa3ojOU0A9gNPpHwPSvAP4sYb40YQxGF69W2zjZZH9vOUKVmjwkXe1YoqmDE iiInjNZLR0OsTZiXp7JR2CObeKBSVttDItQgrGI5hKtkqF/nbl2yv6feM8JsRtQkncLQ f6doo2lFAfCV32QhYA6MLAdv0RcJXTPm7sXS8QOgyW12Vy0U6AWtz8a6YREuQjuBovXQ OO1kExJJYKuk1CjsX5GMCTOGspuVXrf+AbI5ophBD6nytxZp6Ge7fiinwTkGn1c4aZUe 3Qbzg2vpf+MkYMcWqW3bTIX2qlKwIOrHWyLFZSLMN9dFzt18587uaMtX2ewLrDKw0qS+ 8F5Q== X-Gm-Message-State: AOAM5322oHhfYsdNNm9mBPU5ZzOUOfVE4wYxjatZ4QSPYE9Rs4fgC8Iz ysKrcC5Gw3hL0E3H42EtB6I9HV7UiXRczA== X-Google-Smtp-Source: ABdhPJzDgWIuArd3tT3yl+UHBg0ZIvK+LLGytpDKFZYXsXZAO7JGBc+j0ar1PK00jIiVKa3M49rnAQ== X-Received: by 2002:a63:a745:: with SMTP id w5mr12476659pgo.374.1643046495126; Mon, 24 Jan 2022 09:48:15 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:14 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou Subject: [PATCH v2 49/83] net/hinic: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:45 -0800 Message-Id: <20220124174719.14417-50-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/hinic/hinic_pmd_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c index e8d9aaba84a6..35788f46eb4c 100644 --- a/drivers/net/hinic/hinic_pmd_ethdev.c +++ b/drivers/net/hinic/hinic_pmd_ethdev.c @@ -2662,8 +2662,7 @@ static int hinic_copy_mempool_init(struct hinic_nic_dev *nic_dev) static void hinic_copy_mempool_uninit(struct hinic_nic_dev *nic_dev) { - if (nic_dev->cpy_mpool != NULL) - rte_mempool_free(nic_dev->cpy_mpool); + rte_mempool_free(nic_dev->cpy_mpool); } static int hinic_init_sw_rxtxqs(struct hinic_nic_dev *nic_dev) From patchwork Mon Jan 24 17:46:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106408 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 934ADA04AD; Mon, 24 Jan 2022 18:51:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFECB4291B; Mon, 24 Jan 2022 18:48:20 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 46C4742903 for ; Mon, 24 Jan 2022 18:48:17 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id u11so16309011plh.13 for ; Mon, 24 Jan 2022 09:48:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uq4mzrlmF3RpJdeURax9LN0/y4tfKaEL8B92rJsdSgA=; b=FDzTxkbGPQ+JWE8WEeSc3tkROCpolkjmlU3pBPWSRxz8DGUIwxterJb2Fi+hbFD5AX c/qie9pvx2hWkqPuD69IZJuaI4+S9iBg+F2KDworP9viJ0ppM8jOuQ9soHqWRQMijCu5 4V3MzM+90Ept94W9bWciS37n2OeBdPWLLoDDoyhSpc0suTAq6B+eSIut1kRo0oalb3rM FaXSiUpeLIEIM824QmEd7wv9+B6/JUPApF2m1j75xOZps07pgauadouDbIfcwmpJPMDr GwWeetC50gTzckVMiMq/Kasc2NPqvEHwdvblFCPaZiVO9GutuPZYP1AslqZtUAfhGiPp mVDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uq4mzrlmF3RpJdeURax9LN0/y4tfKaEL8B92rJsdSgA=; b=MNxVss1YyxB2bAOTYe8BJhEYhu51cu8y1sesTNFww/MDMSzXw06ehb4YXURJbV0+jO Win9PhCuJV7HCQ6Sbfy0hg8Z6lDxwHyhaz1qGZb5NIkm7Y5R6ysrjACJIw9b2yZtm9qK biDWb1WrXMGUWScAmwPPrfNVmE4FiWRUmE/oox05J7+f8TeE5FIdNctEaoJuw8owsB5g ug2bhZOsQ6qlKXPA1ykeCyF9goUeQKSvtmRDvMNQPERC4WJsg1i+AGGaRlH7geR5UKA0 fb2/tQkTXTupzQ87KRlPqKDQVKcbE2CX9zT2pNw+JSbcOHqHYypzrt6B6rFnVL3EbTw0 iFkg== X-Gm-Message-State: AOAM531/eucJS1UbxMRWmwzcCUONmS64MYaeYCso175DHGOSWwAw4OHz DqewL+nQjpE5e1oj1yzpnyPmY1JbCImpVQ== X-Google-Smtp-Source: ABdhPJwUB6RAfd94ZloIAA92wF+V39eYYFmiRzJ8ReMEnpqLU16AfxXKzQo8ogE4lzgo0JVMIJkr1Q== X-Received: by 2002:a17:902:8494:b0:149:8a72:98bb with SMTP id c20-20020a170902849400b001498a7298bbmr14701950plo.0.1643046496323; Mon, 24 Jan 2022 09:48:16 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:15 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou Subject: [PATCH v2 50/83] net/hns3: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:46 -0800 Message-Id: <20220124174719.14417-51-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index d240e36e6a86..8a428f88f48e 100644 --- a/drivers/net/hns3/hns3_rxtx.c +++ b/drivers/net/hns3/hns3_rxtx.c @@ -86,8 +86,7 @@ hns3_rx_queue_release(void *queue) hns3_rx_queue_release_mbufs(rxq); if (rxq->mz) rte_memzone_free(rxq->mz); - if (rxq->sw_ring) - rte_free(rxq->sw_ring); + rte_free(rxq->sw_ring); rte_free(rxq); } } @@ -100,10 +99,8 @@ hns3_tx_queue_release(void *queue) hns3_tx_queue_release_mbufs(txq); if (txq->mz) rte_memzone_free(txq->mz); - if (txq->sw_ring) - rte_free(txq->sw_ring); - if (txq->free) - rte_free(txq->free); + rte_free(txq->sw_ring); + rte_free(txq->free); rte_free(txq); } } From patchwork Mon Jan 24 17:46:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106409 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81264A04AD; Mon, 24 Jan 2022 18:52:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C9B042920; Mon, 24 Jan 2022 18:48:21 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 623C14290D for ; Mon, 24 Jan 2022 18:48:18 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id x11so10534288plg.6 for ; Mon, 24 Jan 2022 09:48:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OUYCORe2vUmTo5U+aHVAc4mtCYCEHhtpbL/FAZv929Y=; b=pR0uSRjNnCE7I67VOzslu34RwLNeFeAOfvJKfSh1swOLnUHSH5biY14Id1qbe9u4tT N8ujmotK6DvSwuvMtVmLcTYmjCFseWg49JSNypX3YFCm0tqXEZSJDEn4busd+Lhozkdh vfMZz4fZ1iPE9FocuCfaQk0qzENhTMlicKiQ/l0cGGZdEWfFZfgQGrMSnbHN8YUZAwNO PBaNVEAVT/M8CfljJNDqrasv8uQZAFffW1h3kn/bWJ+Xz0mLn3TGX2solYpwMPADxbfu YRBIgxXc227k97KnfoTizWQfq5omXCV2MqlrERyt/A0GBkCyhSKHPk9dRr5+bdxBxwHr ps4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OUYCORe2vUmTo5U+aHVAc4mtCYCEHhtpbL/FAZv929Y=; b=swKxaMJkX0MMZaAWYswchKIFw9fdY49VqTkXv01E9dB272A157K2rCblPBhmXUXycN lwPpIQw7q4E7mYORNHACS3YA81diRj0v/K6kB0VtIXa1+PHEqGugYjkeU9ZAkkv7WDm7 /y55/nS0lckKjoWH/ZG3fJ3lsxJtR9Z127Byyl1FV/td3OlymJc/UwCrBVQQRR0hKNYH 9x85+Feo2VgACMSXT0uqxDCsbAhuRDPasIn9m2ACHBkWQtgt6tNNlzSuzak7JwNRRGSm z52yFTuRmvlKhJD8AVgbY2+fFg883Ep+gw5DOhBQqNH9npepO/ErjhI2g+2bZBJ5MtuE Qglw== X-Gm-Message-State: AOAM531Pcd2IaeFXAbRxW2FIzCmMCVqWVGOvasbLI7JTC3tDVBYpM/Pe qAtzN4tHwNfFtcnaaxEqiqHStE3GiQaMxQ== X-Google-Smtp-Source: ABdhPJzLbxSwJZzhlUGkIpZ+EZkfuSPjcN2e4+icuYgFyqommokaMuRYjNoEX9dUNrWL61/xqbAI+Q== X-Received: by 2002:a17:90b:4f84:: with SMTP id qe4mr3000824pjb.24.1643046497241; Mon, 24 Jan 2022 09:48:17 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:16 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Beilei Xing Subject: [PATCH v2 51/83] net/i40e: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:47 -0800 Message-Id: <20220124174719.14417-52-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_ethdev.c | 27 +++++++++------------------ drivers/net/i40e/i40e_rxtx.c | 3 +-- 2 files changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 1d417dbf8ad7..ecfa3c94db44 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -1781,10 +1781,8 @@ i40e_rm_ethtype_filter_list(struct i40e_pf *pf) ethertype_rule = &pf->ethertype; /* Remove all ethertype filter rules and hash */ - if (ethertype_rule->hash_map) - rte_free(ethertype_rule->hash_map); - if (ethertype_rule->hash_table) - rte_hash_free(ethertype_rule->hash_table); + rte_free(ethertype_rule->hash_map); + rte_hash_free(ethertype_rule->hash_table); while ((p_ethertype = TAILQ_FIRST(ðertype_rule->ethertype_list))) { TAILQ_REMOVE(ðertype_rule->ethertype_list, @@ -1801,10 +1799,8 @@ i40e_rm_tunnel_filter_list(struct i40e_pf *pf) tunnel_rule = &pf->tunnel; /* Remove all tunnel director rules and hash */ - if (tunnel_rule->hash_map) - rte_free(tunnel_rule->hash_map); - if (tunnel_rule->hash_table) - rte_hash_free(tunnel_rule->hash_table); + rte_free(tunnel_rule->hash_map); + rte_hash_free(tunnel_rule->hash_table); while ((p_tunnel = TAILQ_FIRST(&tunnel_rule->tunnel_list))) { TAILQ_REMOVE(&tunnel_rule->tunnel_list, p_tunnel, rules); @@ -1833,16 +1829,11 @@ i40e_fdir_memory_cleanup(struct i40e_pf *pf) fdir_info = &pf->fdir; /* flow director memory cleanup */ - if (fdir_info->hash_map) - rte_free(fdir_info->hash_map); - if (fdir_info->hash_table) - rte_hash_free(fdir_info->hash_table); - if (fdir_info->fdir_flow_pool.bitmap) - rte_free(fdir_info->fdir_flow_pool.bitmap); - if (fdir_info->fdir_flow_pool.pool) - rte_free(fdir_info->fdir_flow_pool.pool); - if (fdir_info->fdir_filter_array) - rte_free(fdir_info->fdir_filter_array); + rte_free(fdir_info->hash_map); + rte_hash_free(fdir_info->hash_table); + rte_free(fdir_info->fdir_flow_pool.bitmap); + rte_free(fdir_info->fdir_flow_pool.pool); + rte_free(fdir_info->fdir_filter_array); } void i40e_flex_payload_reg_set_default(struct i40e_hw *hw) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index 9a00a9b71e2c..25a28ecea22c 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -2573,8 +2573,7 @@ i40e_reset_rx_queue(struct i40e_rx_queue *rxq) rxq->rx_tail = 0; rxq->nb_rx_hold = 0; - if (rxq->pkt_first_seg != NULL) - rte_pktmbuf_free(rxq->pkt_first_seg); + rte_pktmbuf_free(rxq->pkt_first_seg); rxq->pkt_first_seg = NULL; rxq->pkt_last_seg = NULL; From patchwork Mon Jan 24 17:46:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106410 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B3FFA04AD; Mon, 24 Jan 2022 18:52:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96ACE42927; Mon, 24 Jan 2022 18:48:22 +0100 (CET) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id B48444291A for ; Mon, 24 Jan 2022 18:48:19 +0100 (CET) Received: by mail-pj1-f46.google.com with SMTP id q63so12481723pja.1 for ; Mon, 24 Jan 2022 09:48:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DQv7enFJ6ztV7XCoRJU9M8z1Krc32VCDmmDK8E4865I=; b=TUiUOlsaZaZctEtDskylav8EhMrScoEpL+u4Lmga9ypOoj05MXEuZRY2qu4IbXJNQc d2CpaYEkdWLyRaAj5kbqRZbN1+D/1N09cj2HupLdXgZU8du90/BrWWELz3JZ/nMrGDss KksP3xD/ZJNybTcNhEG3EM/M7ppCR6LYRXZoGaNhwd5hJIPVzcZWrSc65PlmVRVK901a FOBV0LevQU7Cn/Qkm+lqk8OOYAGN5xZ+DSNz34gxbCizxkd3Hjo3ITlJe28wudPiTe2k F3VQTITQBx90kJ84YHCS/FINcDnseHQkKMeekqIkm4jf/sBwIHiVZf8IdF26hrGe0ehG BFPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DQv7enFJ6ztV7XCoRJU9M8z1Krc32VCDmmDK8E4865I=; b=yKZgJY+H92dNG6ZL9Bhdk4xKuLP3QpjbVwo5R3dXhKvl9hfiNLYBIY8CxehmVRIgpp oovr3RGYZ5cO/DfsVn2CAEhyprG6cwT+UGEKWE4b3Qilkoh9h55F7x1a0vVhTnXlUCgh Z2jIAJmnaNhqMWKMRXcikgMLqnzlVbzn2kQ7bONZir5zFODDL+fT6r0F2/sGvjHzN3l2 k8Lu3BzZL+2MY8Kvfb2RWyl/O/ScUxEHxAQEu58TFICku1Z8FPIgTh6CLUjrNMYVdEOt jFcOzP5iYjTbaX3YKBiDvlrlUM+W50qXdmPN7Ui0A8+1pRIz9g+B+3DjYrV/lmOZn1b1 JYRg== X-Gm-Message-State: AOAM532wWGYt2oKagxC677wcZElUiI9MuKtgXTeQR+dADvuuh+pIyvfk GbCRUtx/0N65Y/Cl8yvbZWpUNT2upO6TWA== X-Google-Smtp-Source: ABdhPJwTdXi4EaKTfE/VT0ycaSVFcRUV0Y3FIX0zyhpruYm51NviCwDCW16j7ptzSTKAeOYGs2WRgw== X-Received: by 2002:a17:90b:3a8b:: with SMTP id om11mr2956462pjb.176.1643046498746; Mon, 24 Jan 2022 09:48:18 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:18 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jingjing Wu , Beilei Xing Subject: [PATCH v2 52/83] net/iavf: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:48 -0800 Message-Id: <20220124174719.14417-53-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/iavf/iavf_rxtx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 59623ac82094..dabe8cba7561 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -230,8 +230,7 @@ reset_rx_queue(struct iavf_rx_queue *rxq) rxq->rx_tail = 0; rxq->nb_rx_hold = 0; - if (rxq->pkt_first_seg != NULL) - rte_pktmbuf_free(rxq->pkt_first_seg); + rte_pktmbuf_free(rxq->pkt_first_seg); rxq->pkt_first_seg = NULL; rxq->pkt_last_seg = NULL; From patchwork Mon Jan 24 17:46:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106411 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 166A5A04AD; Mon, 24 Jan 2022 18:52:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83ED84292E; Mon, 24 Jan 2022 18:48:23 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id BB8C04291C for ; Mon, 24 Jan 2022 18:48:20 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id c3so16314890pls.5 for ; Mon, 24 Jan 2022 09:48:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=skn4RezxA6fzdblvvu4Dbyud7yUiw8Oo0uSoBCpx7wE=; b=u4oHCG5R05wvD5y9aGwjo9lGvUfIB0SllTrQhNQICSnl3sH3ZbIG0/CtuUAa2n/4ju AjTp+yIaQDVX2FGVnnbOSIKZTnOe4SkTKTRNUUe/xMzy80ipPXD3foLM1rZcMmMWe+aL OywLfuTS5sQz9Ag6WtuJt0a4baSIIJdujbN3Llk9SwGhcQMzXnzi1p+yYrMmeYbx7INi 70v5b260LSt6cO2Lr3ppn1tjhVv26lJpv7WLdWcj3ubp/OIKl5ihufDjid8olF9UQgSZ 6rmNJpU2T/+Zbcn3KqsaRXmC2H9TtFsRKEfNqcx+6acAaLxoBHPxapAegC0LMak9iuhe SjJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=skn4RezxA6fzdblvvu4Dbyud7yUiw8Oo0uSoBCpx7wE=; b=WJam9lLOPCCZxJmfVMuKC9Ah4DpFkR6ADeVimuXuMg/X6K0PiUsVxPlL9VIh++gbBT CdKNNvOjJ+brhX9DSPWFlHjxJJYYplWBy2VPLNlzqLvHA+LTWxzE46VWLtXOcVZm1lPK R7U7pyH94+pq0KOvqHiwmRW9O26pgBNbf2zWYVNieXfKnDQw6E1M61ePNGWSRNNffKyK +xha7qmr4vT0dxrjMUneB8kMjcCDiLZjLPLDn6ghxytHfcrYQd8DbNON3z9jqZlr4BYp BkaL/+x9odezsMzUzDVmBEv3UpZNKQjPDdhYhKip/mj44D8+WHnEMnoAPZ/nfqoZgw3w uVRQ== X-Gm-Message-State: AOAM532eLPTe1kwsgil9PqZ63sCOb7DFJsiv14p3Rbn1lVcR/vtZa3ei ggej7t66OrRm5D4S345L3by7cTsZkc5JVA== X-Google-Smtp-Source: ABdhPJzPwzUrtT45ZabmsuQBkv1kzPXoNpWMLJUL6atfWF0KwT3m9zsnj/R/CzGQLpKoZjhRr3ODqw== X-Received: by 2002:a17:90a:156:: with SMTP id z22mr2942706pje.191.1643046499796; Mon, 24 Jan 2022 09:48:19 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:19 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Qiming Yang , Qi Zhang Subject: [PATCH v2 53/83] net/ice: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:49 -0800 Message-Id: <20220124174719.14417-54-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ice/ice_fdir_filter.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c index 13a2ac42df87..3fce8e1e6253 100644 --- a/drivers/net/ice/ice_fdir_filter.c +++ b/drivers/net/ice/ice_fdir_filter.c @@ -421,10 +421,8 @@ ice_fdir_release_filter_list(struct ice_pf *pf) { struct ice_fdir_info *fdir_info = &pf->fdir; - if (fdir_info->hash_map) - rte_free(fdir_info->hash_map); - if (fdir_info->hash_table) - rte_hash_free(fdir_info->hash_table); + rte_free(fdir_info->hash_map); + rte_hash_free(fdir_info->hash_table); fdir_info->hash_map = NULL; fdir_info->hash_table = NULL; From patchwork Mon Jan 24 17:46:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106412 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39421A04AD; Mon, 24 Jan 2022 18:52:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85C5E42934; Mon, 24 Jan 2022 18:48:24 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 1F4B342925 for ; Mon, 24 Jan 2022 18:48:22 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id g11-20020a17090a7d0b00b001b2c12c7273so212067pjl.0 for ; Mon, 24 Jan 2022 09:48:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lqEmHHbt20bwHdbrFxnlIeL+a+rOHfMeJHOWjp0QSw8=; b=B/FLWy/gsFnEx2z0Sfx3Dxnkmz4k9qwk7lhueo5L3Et4Wd1sYP54x12RyI4ycmBkWs msnAycuBTgXl7U329Dq5GzdwlypkimC+A4uD8HyAgEC41bqr7gs/MqbCbHk88g50Et5r YA3Bz/O5WygOkvtmfuPixBM5OA87Pz091yHb7ojYW9BCW20T9nFVGLFwNMyLXP94wlIq 0vGlJls3c+pQ1fuskCKubWekwSNoUFtqavvazgQDXWNV7UnIl1dj5n+4goBEEfb4qSbK 9gkJoHlQidWsf86kI4sCd31kfYeIcUdhM7xbo7zNPrEPdrXRYfQ6NlzJ5HSzdoxYzl7S l7Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lqEmHHbt20bwHdbrFxnlIeL+a+rOHfMeJHOWjp0QSw8=; b=S/3WqDW2uFKACGBBxWXSjKXoczSI5zuzfIog35cjzvEh69OdbfHrKSVRwelwI3VwJu 5/oMBNJOaDYRw2jTwecc7vzbf3Ubg2xozRlMwWwoJY3smvO5vfxi7Syx9lQ4PNjR/iYN ZWtbjGzwBb55wGE+tx7IBDtsZse6c2ZJsvSfHWEKsvkcNu12V/DN1M/B+iep11N3rZYO 7MpAzLjMMRvXhlQo8Dgz0vO7a9I6Hs7UVBwlbyMyvb3Hxx5Pt1lzh+8utLGC4z2F7mGN 3lIxJWjIoC38VHvnzVUpM4qMI2hkDStHm8d+YdtoVZpavM/Mf6cKlAObkIhPzSSnmPNh WmaQ== X-Gm-Message-State: AOAM5313WxNdC/XQuauebrKAIddnm+YL0ihU7hyCAxq1CZy2+25j7Mjq 4Ytf9JuxnHH39ER+g1pLJGowkyjW5S1AiQ== X-Google-Smtp-Source: ABdhPJwcWkUZZWf7i8aZfPbOw75OptzyH47Lr65QXPVVl3+knPmGdPw0AIHany/Vmfc0yXzrpJzWNg== X-Received: by 2002:a17:90a:8045:: with SMTP id e5mr2932081pjw.97.1643046500820; Mon, 24 Jan 2022 09:48:20 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:20 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Haiyue Wang Subject: [PATCH v2 54/83] net/igc: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:50 -0800 Message-Id: <20220124174719.14417-55-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Haiyue Wang --- drivers/net/igc/igc_flow.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/igc/igc_flow.c b/drivers/net/igc/igc_flow.c index 66053060af5a..58a6a8a539c6 100644 --- a/drivers/net/igc/igc_flow.c +++ b/drivers/net/igc/igc_flow.c @@ -775,10 +775,7 @@ igc_flow_create(struct rte_eth_dev *dev, } if (ret) { - /* check and free the memory */ - if (flow) - rte_free(flow); - + rte_free(flow); rte_flow_error_set(error, -ret, RTE_FLOW_ERROR_TYPE_HANDLE, NULL, "Failed to create flow."); From patchwork Mon Jan 24 17:46:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106413 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CD2FA04AD; Mon, 24 Jan 2022 18:52:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C916542940; Mon, 24 Jan 2022 18:48:25 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 359954292C for ; Mon, 24 Jan 2022 18:48:23 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id l16so17144598pjl.4 for ; Mon, 24 Jan 2022 09:48:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kegOLYze++Xnm+zOpzwGCtqkwOqKgTQ0qLsVr01AXRs=; b=ON8comOMQMgQf4s+532IvVnvsXrd+W9mu2lVWop4augJIs3eSrEkGid+33mmpPEuul wBeriMNpX0YlpGSXim6G/vhPSZPwl1gbz8bttBS/rqhM+DC0kyAa6r6ekh32YdaZp/bV ZfPrguZYh6+B3FwA/yxJijq0a6wpvU1FkHJwOQhXgioPWJPfUiKGEEmzkhkjINtvtwex 8p/eMKdKGanGmxpCzSSmDKp4DFzrmu/0rwgiRhFCI6aKGQEUxmQqZ43E/4SaS6Lu7api uDrK/uxc4HSDVc4HYwHL0OC1PICcii/Ia/AVqnZq0mp3WcgX/WjfMVr3Jdsi9fw2jzXI krcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kegOLYze++Xnm+zOpzwGCtqkwOqKgTQ0qLsVr01AXRs=; b=vdBNk0u5zWVAxjUytAF0dC4PaY5xMRRs2+PNVmfHNVf10NinvYTk1f3Uvn5VdRLXt1 LdjgtLQs1/lOiqRX7ZezeJkHSUbyJLUlwNmS6aQuW1xVdLeRT4PaucjcrLhS+Vauu/HJ JPICRcM832U8jDv3Zsn3kOdTwlOPtSzvN+QzymHcsldnDa+glQDw+m2ZFXLFAe90k/oA aLQIqPckEzihPjX2vOcl3mnWCZe2U87QlPSFYr57Gikh1XcJP/5ruiPUX9lOOLbBrEGv H3gMAp9/V5g9LEtiXVBjHucZ1cOCxDWtN86++DwesOkMbfidJbLbXstob3hnuZkJMA/1 Ya1A== X-Gm-Message-State: AOAM530TYdw6w/NH2niq9PaPWVxtvJA28vXuLk7yEumhH7pCIbTyMPiK +g281tXR3enijJ7lqxNfNTXPPOJXugNHOw== X-Google-Smtp-Source: ABdhPJyln6OG7t8vh5k4dInQ+Fn/Ndqqwn7+neu6ZAHALAl3g05vy8diSWCmXus/g482WIGYS+WcKw== X-Received: by 2002:a17:902:e8c9:b0:149:b88d:5980 with SMTP id v9-20020a170902e8c900b00149b88d5980mr15175818plg.171.1643046502273; Mon, 24 Jan 2022 09:48:22 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:21 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Haiyue Wang Subject: [PATCH v2 55/83] net/ixgbe: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:51 -0800 Message-Id: <20220124174719.14417-56-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Haiyue Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 12 ++++-------- drivers/net/ixgbe/ixgbe_rxtx.c | 3 +-- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index c8f0460440c0..d7efe5c6d753 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -1322,10 +1322,8 @@ static int ixgbe_fdir_filter_uninit(struct rte_eth_dev *eth_dev) IXGBE_DEV_PRIVATE_TO_FDIR_INFO(eth_dev->data->dev_private); struct ixgbe_fdir_filter *fdir_filter; - if (fdir_info->hash_map) - rte_free(fdir_info->hash_map); - if (fdir_info->hash_handle) - rte_hash_free(fdir_info->hash_handle); + rte_free(fdir_info->hash_map); + rte_hash_free(fdir_info->hash_handle); while ((fdir_filter = TAILQ_FIRST(&fdir_info->fdir_list))) { TAILQ_REMOVE(&fdir_info->fdir_list, @@ -1343,10 +1341,8 @@ static int ixgbe_l2_tn_filter_uninit(struct rte_eth_dev *eth_dev) IXGBE_DEV_PRIVATE_TO_L2_TN_INFO(eth_dev->data->dev_private); struct ixgbe_l2_tn_filter *l2_tn_filter; - if (l2_tn_info->hash_map) - rte_free(l2_tn_info->hash_map); - if (l2_tn_info->hash_handle) - rte_hash_free(l2_tn_info->hash_handle); + rte_free(l2_tn_info->hash_map); + rte_hash_free(l2_tn_info->hash_handle); while ((l2_tn_filter = TAILQ_FIRST(&l2_tn_info->l2_tn_list))) { TAILQ_REMOVE(&l2_tn_info->l2_tn_list, diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index 99e928a2a971..9e8ea366a506 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -2983,8 +2983,7 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter, struct ixgbe_rx_queue *rxq) rxq->rx_tail = 0; rxq->nb_rx_hold = 0; - if (rxq->pkt_first_seg != NULL) - rte_pktmbuf_free(rxq->pkt_first_seg); + rte_pktmbuf_free(rxq->pkt_first_seg); rxq->pkt_first_seg = NULL; rxq->pkt_last_seg = NULL; From patchwork Mon Jan 24 17:46:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106414 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56160A04AD; Mon, 24 Jan 2022 18:52:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CEA6F42945; Mon, 24 Jan 2022 18:48:26 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 2AA6142932 for ; Mon, 24 Jan 2022 18:48:24 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id d7so16301087plr.12 for ; Mon, 24 Jan 2022 09:48:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8uCh2fmiVJ0Fv7CxbxcyCYgCxrp8a63KW8vHU+YPmcU=; b=xC2OyXQawY7EVtvdipT4/76i2rbeq+V5ac3lR8o4WDjiHMzTl1eQBq9R+lJxL/0V9q XfcbasCN2mf3FTERHtg2Q7C7VQcSZOIWzsjYUFg5akIZExnw9MMZKd8PddsiwdTabSoM lnoXn1ZCTswWpsK8afegYvsBqdR/ohVc60Zo9N8V57AlNNmsBOUlWVYi+tq0lv5cp0/B NZnafEVILWlJc1Hc1qpOP2eEV9IfztSAOYoznxAqRuyguOWmAdzyo5PKZP9MkNGTqzcj nAvRsBYUaMjsgaa5V4Kl3o6k4W2vMrkjMv7gD6O0LTtCVaa7UleI9m4sAs0NgE7ehnAR lf2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8uCh2fmiVJ0Fv7CxbxcyCYgCxrp8a63KW8vHU+YPmcU=; b=EoSEwCCRSzQhViOOS6bqRh6O1ZZx/9twjKArpfYXfiqtQTUjvQPIAOoLyP5gbjbNZB DoWonK8moPmGt2BBtm85oCNmBbW0BiDB4BrPusiKNnC/CVcGA0H6VdvbeMlewqTVRo0s O7Kq0rm6b/J8KllPePE/IahFtdkJ6efgzqxr1qnUYgefHtea8ELkLkP+5GDFnf1tjdRm wgKcpz1ocLIoTxr231Lhsp71jQNbLt2X4SI21Yh3mPAC9Elld/OhG8fm7S9mDRKmsXS1 xZI93VMfSlam9b9DOPYglcJGPorcA+6JVi0I3sjffIUvMFn72123GifBx7xd+Ri0uy1y rkLQ== X-Gm-Message-State: AOAM530+0f+1g6S6p3rVCmqvHeKqvE1blm/yCuMlf4hQ7Dl612+qloTG 9qTByG7pa/wD8A2WWE4r9dwkxocTzWsuqA== X-Google-Smtp-Source: ABdhPJwDhJTDp7fXOoTZWWGeYngiRTQu7ECKkatG6IQzGIxLKICgUG3rhfLVaArb213IKjKtq891Sg== X-Received: by 2002:a17:902:bd05:b0:148:a2f7:9d87 with SMTP id p5-20020a170902bd0500b00148a2f79d87mr15319090pls.166.1643046503186; Mon, 24 Jan 2022 09:48:23 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:22 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jakub Grajciar Subject: [PATCH v2 56/83] net/memif: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:52 -0800 Message-Id: <20220124174719.14417-57-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/memif/rte_eth_memif.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index 59cb5a82a23f..5c2203f5270b 100644 --- a/drivers/net/memif/rte_eth_memif.c +++ b/drivers/net/memif/rte_eth_memif.c @@ -1731,8 +1731,7 @@ memif_check_socket_filename(const char *filename) ret = -EINVAL; } - if (dir != NULL) - rte_free(dir); + rte_free(dir); return ret; } @@ -1903,8 +1902,7 @@ rte_pmd_memif_probe(struct rte_vdev_device *vdev) log2_ring_size, pkt_buffer_size, secret, ether_addr); exit: - if (kvlist != NULL) - rte_kvargs_free(kvlist); + rte_kvargs_free(kvlist); return ret; } From patchwork Mon Jan 24 17:46:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106415 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01BDCA04AD; Mon, 24 Jan 2022 18:52:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA71142948; Mon, 24 Jan 2022 18:48:27 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 1E2C642937 for ; Mon, 24 Jan 2022 18:48:25 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id t18so16301228plg.9 for ; Mon, 24 Jan 2022 09:48:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7hhwjPnMALvxaQCfeixtjfBr7PvHCUrqcbBPLp2YFe4=; b=HmC5NdotHUYnSgYfeoqlnM4fgFAgXDyYrZ6okjMfPQoby75sSGV8fOiqpk2QfR7lEv MmxTXjP88qGMSrJSEqlQ5PeBWjXKHYvT06euWD0kj4YVIX4Wl6OQNVJq3XWwOza6EPlB 7uRGlw/hzMfI7xiALinViyGZd3bQGrXrPVfZcXTbHq2z+ygsBH6YVEj9DsxHB+t4FS52 5hjNLeENrnTq808GN0/HhD7ypxQ6tiwndcncZpHugF1kzZKsGiS/MmVTl19AH1Ebu2Xn 2wtx5cBIKa1BARmwQGcL59GrKVo49wfoq9VIrlQADJE/r71w/D2LUVCybusBaNDnKMwz IrdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7hhwjPnMALvxaQCfeixtjfBr7PvHCUrqcbBPLp2YFe4=; b=gc7/iChi9yIOb/JkvMDI7AzxgNw0onGHwlQG3YhBBbTbdd8LsPjLpmy3nzCcrT5Frz l3oEPzPVXR/2lQ6LC3L7VhNdDGaBNP87Jwv0TMKWiZQXnJ4Z8KLxsXfn3DfnQzdIMxCL i1EqTv/tIqIMHCiu7x0B3PFtSOu/h/Yys1xydHyz0toKKCpTPhtcU42xBvaEWRewtM1U FDHpgvMsuWc6tfTeBV4IotfIt5ItAh4TbYAUiQ+7Xp7wKyW/boV+ULN8l+b5+VrXG0rY nv3UE5K+xMSgw1bIhtFc1DxYxjggmLfOJITriRAXEF6Wz5iNbyPUOkUL59SnIuS9PYrZ IG2w== X-Gm-Message-State: AOAM530vMwABResGiBtL9u5igbLYaSLL2/5pV52XXgu4DxhW5Xts3RqM MXnLffUys+o7zKgLRESzhzmEyUOl4TZ07Q== X-Google-Smtp-Source: ABdhPJx1X1kp/JVxPOpia/cymB6S/6O6f+6HtBjPIYl+rRPyop/fdtt7yCMMZpGBtJPzqDfxCXhBbw== X-Received: by 2002:a17:902:9893:b0:14b:4d5e:de0c with SMTP id s19-20020a170902989300b0014b4d5ede0cmr5799194plp.117.1643046504110; Mon, 24 Jan 2022 09:48:24 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:23 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH v2 57/83] net/mlx4: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:53 -0800 Message-Id: <20220124174719.14417-58-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx4/mlx4_mr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mlx4/mlx4_mr.c b/drivers/net/mlx4/mlx4_mr.c index 2274b5df1950..e95f45aa3e95 100644 --- a/drivers/net/mlx4/mlx4_mr.c +++ b/drivers/net/mlx4/mlx4_mr.c @@ -471,8 +471,7 @@ mr_free(struct mlx4_mr *mr) DEBUG("freeing MR(%p):", (void *)mr); if (mr->ibv_mr != NULL) claim_zero(mlx4_glue->dereg_mr(mr->ibv_mr)); - if (mr->ms_bmp != NULL) - rte_bitmap_free(mr->ms_bmp); + rte_bitmap_free(mr->ms_bmp); rte_free(mr); } From patchwork Mon Jan 24 17:46:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106416 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EDC8A04AD; Mon, 24 Jan 2022 18:52:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA9164292C; Mon, 24 Jan 2022 18:48:28 +0100 (CET) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id 226F242813 for ; Mon, 24 Jan 2022 18:48:26 +0100 (CET) Received: by mail-pf1-f175.google.com with SMTP id 192so13240959pfz.3 for ; Mon, 24 Jan 2022 09:48:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dlkTRiPlJteixPbAsLxpIIe6vqw6XBxuk3//t0LHTFA=; b=lBffr9O6qTZnazUzitz2IBZxd7IwvLwHlnDOyKu62Rg3qJZeYAhPtTt+WRop/zIqQr sLnZKlXbYYGGUVDZjTSs8o3jg5IGDhMKmmfuf21ygMgKre1+Xl5+dd71fpctht5KwGEO J+61K4572H0PTwr4qq1RpR4QUnHq6TBcRj4+SLo5lfEimo6ikkBW/fzR978kaI4vfg4B VWP2/mEGFegBUL8aDJONBWHSpbmQlCTJ2C979h6jwfo9uuKcvPVQWoX5tS/7DC8cOEkW Js92W4YYcZjYDtjW63sQZwmxI4hDZ/KkYIUHqR0LfgEkzwVNj2Lme1speLXjBSL99ly/ Ypcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dlkTRiPlJteixPbAsLxpIIe6vqw6XBxuk3//t0LHTFA=; b=vNgKEHAgRJ1ztBdYdmEdHT/SJ5V8KYvG/YctZtjTRUEK0rUPJ6JXUCSnHwP5aYYO8L 9myOPMlMOcsp+8AlDjTVznRIn/mp1JYq34UVEjW3+D3Po5g1egOVezkLZK0q4TRSSNdy +I2r69TYwHc/hr9ALIz/mqcDb28QWmS2OHOMtIifdtdD+BsFtcSZZ17t4N06tWXOhsDq iP7lVWSrm/z9RMNyIcr/u3J+0ea9pfA4xOjlxiZ3EHrDH8+qeGSQzSes+2BtDSUPXfXF 3SlgmDulBIFr9BvSu/dp/fA2oGi7YxQnc3Fb6okk9vGKSJ+l2TQAOCzAL7Ds9chp97mD 4Hdg== X-Gm-Message-State: AOAM532KsewFjuqxYqVF19geFA7PXuWCSMg9GB11p+wuZ/78nEyClk0x sRWNIl2KduD2g8S/tfSoPfJKZaLfuTaWvw== X-Google-Smtp-Source: ABdhPJwIdlxC8XE0G0MSsaoqyvPj3/zjVWvso8dYN4buy0r+TXUAVV/pYHvdpGNdUMT2HP9VE+dn/g== X-Received: by 2002:a63:2b03:: with SMTP id r3mr12506735pgr.201.1643046505171; Mon, 24 Jan 2022 09:48:25 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:24 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH v2 58/83] net/mlx5: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:54 -0800 Message-Id: <20220124174719.14417-59-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index b7cf4143d5a1..c718dbdb3dc7 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -6990,8 +6990,7 @@ flow_alloc_thread_workspace(void) data->rssq_num = MLX5_RSSQ_DEFAULT_NUM; return data; err: - if (data->rss_desc.queue) - free(data->rss_desc.queue); + free(data->rss_desc.queue); free(data); return NULL; } From patchwork Mon Jan 24 17:46:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106417 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3D56A04AD; Mon, 24 Jan 2022 18:52:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C76A442952; Mon, 24 Jan 2022 18:48:29 +0100 (CET) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by mails.dpdk.org (Postfix) with ESMTP id 2B54442846 for ; Mon, 24 Jan 2022 18:48:27 +0100 (CET) Received: by mail-pg1-f175.google.com with SMTP id p125so16057613pga.2 for ; Mon, 24 Jan 2022 09:48:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+lBew+vQ8GiprD0cERtvMyixcRwPweW7PYK/ERegOkM=; b=s4ZrFG3PDQp13/2MF6pyLNOd/723HwcHpSLI2bbBUrYiBGgHksCd5fb1Lg7T2IdJij Vd/hTmq6WqwqfBlqx0m5+tZapdmU1ZLMC8d7aqgcm/S5ty6B/bsiR9UKFEsjPoawCO/P /lLMVBRZ6B+bv8qpSye1M1BtUdn69QFkc7hFz4Ddg+BjMd4nd0Z43T5DScBBKCG2arct KU4VE1skxTFVcucHUZhqkLsBwRCbywlQDOzK9h+Q+lub6J1IFlytDWcU/cxmEsN6ZVU1 Z0y8lQGBi6Ge1PYbUWf7hV6mBlY9BtRBJXTyQ8Blp1Zr+VPzmszfbNTP36H7yzBncJwI Jalg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+lBew+vQ8GiprD0cERtvMyixcRwPweW7PYK/ERegOkM=; b=EVwWcaSWwlSD+pfNHV6xPDciEjLumciWlGsPUXJanTvKcJx0f2p0Jbd86btYX87dtd WxNItdsdGOFbOij8qE4AwgJcvny/BATrz0RFe6mmPy8dZpSmYWkdfR6uYIKAoWzTGzkx GlxcDVwrSFDtteL2LVI65O1x1yUrqKRivZ/ZRdojTQgXfw6chndWtZe3jGDQt7VDydOw 0Y9S2EeGk1ynzXn/IhN20AhU5mhfzx1iT1MjP+Vg07MNioY481/2BZf2Z2jyZTnRsnKQ WgVyrKf7izG429VQenzQnVp3zDLIxady6whHE1fIIK3YX0Q6zs4ZELDV5fctb7IpIrcl mC+A== X-Gm-Message-State: AOAM53242hejZMQp3bgzXSXkL31krrp8MRv+AZDwERUxp7m5HbLLqwrB zIlBtc15aws6WyhyzPWTu0LGf//Gbf+7Jw== X-Google-Smtp-Source: ABdhPJwxfKhFR7h0NGDBKe1EQPSdHKw3TKM9dHKRmEiQoyNmhLgHa7SqZ1OHdt5WYHaxwm8kQc+Lgw== X-Received: by 2002:a63:6948:: with SMTP id e69mr6951099pgc.16.1643046506204; Mon, 24 Jan 2022 09:48:26 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:25 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Liron Himi Subject: [PATCH v2 59/83] net/mvpp2: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:55 -0800 Message-Id: <20220124174719.14417-60-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_qos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c index 99f0ee56d1a7..f43217bc589c 100644 --- a/drivers/net/mvpp2/mrvl_qos.c +++ b/drivers/net/mvpp2/mrvl_qos.c @@ -945,8 +945,7 @@ setup_tc(struct pp2_ppio_tc_params *param, uint8_t inqs, param->num_in_qs = inqs; /* Release old config if necessary. */ - if (param->inqs_params) - rte_free(param->inqs_params); + rte_free(param->inqs_params); param->inqs_params = inq_params; From patchwork Mon Jan 24 17:46:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106418 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD3B8A04AD; Mon, 24 Jan 2022 18:52:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD53442955; Mon, 24 Jan 2022 18:48:30 +0100 (CET) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mails.dpdk.org (Postfix) with ESMTP id 268874292C for ; Mon, 24 Jan 2022 18:48:28 +0100 (CET) Received: by mail-pg1-f174.google.com with SMTP id t32so16018381pgm.7 for ; Mon, 24 Jan 2022 09:48:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Gr9VBJf1wriPszZUgTxGzBXtWstZYad04nolY1GAl+k=; b=E4F+V+71mbCQELNFSVEJT7iqPUH+on0SLbGzFHFKYuGj88ffKQlCpzEcI9NId8nBDv wifMmof8BwurLesqe99RQXzie3Fzwu6quGzxhYe0Kh5iJtpaUAD35BSb/ZDxBElJB88Q VwKAtCuIWbeaSacgLtPtU7zrklLCz2N/5bJA3rF2FGpRTD62YeJBouw8qH7WctxlHiIo 9Zf+xENu/tTOPppY9nNW1LU46d7RiItlZ+YiyyA/wpJ35d+dN+/khgNsMj0wFYuA+F2s WJUwsxNYkYoZdXjy0Ps8AOiXV7+R0ucWP49ARMTMyJCthJFdAYNw9TJzTaeOHor8eVcL uZwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Gr9VBJf1wriPszZUgTxGzBXtWstZYad04nolY1GAl+k=; b=va8I4xrQuS/nII79iorleWQvORGiNBuJ/HmH7FjRUg8nOLhocQQmqE8A5AbZImirAL BlVhi7DSJwGMRKgnbNu76zVbJhPhRiPbITiG7Vly3FUQfKKf5g6kBZJ4sIG9rs6Bll2H 0yoHQpR24VSZwkQHUGTguF4aMICzteVs5m/vPBEZjtNQSWGzgQDB0YhEKngmUts7XQBa LrYTz94f9sKog87oLfpN6dUPotCIPS8M2eMene5D3U6wB4vOKHwtq4wcUWPBtYE/Qak5 yznR1TG32u0jZaaECQi6JpcM2ywRRk6IwrpvRoyHN81kXcm/ripGDh9Y6NJPzRL1ntwU 5wCA== X-Gm-Message-State: AOAM5337hIXKd+Pw3io0eNEd2R6BfirNUYk9eMvcpl2BjRUtcBz23ho2 Rm6gAX2cb9digbxyT3qgzu4aNxy1rGopVA== X-Google-Smtp-Source: ABdhPJwBRYecEDkP+YMsY1pLXZ0EtWJUk+WibzbN7NiFdFBEhsLAKEXXKlOrgLFVBlT10wxl2OEQBA== X-Received: by 2002:a62:cdc2:0:b0:4c7:f9a5:ebc6 with SMTP id o185-20020a62cdc2000000b004c7f9a5ebc6mr8928525pfg.34.1643046507116; Mon, 24 Jan 2022 09:48:27 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:26 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Stephen Hemminger , Long Li Subject: [PATCH v2 60/83] net/netvsc: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:56 -0800 Message-Id: <20220124174719.14417-61-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Long Li --- drivers/net/netvsc/hn_rxtx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c index 50ca1710ef3e..3e3488f1b87a 100644 --- a/drivers/net/netvsc/hn_rxtx.c +++ b/drivers/net/netvsc/hn_rxtx.c @@ -315,8 +315,7 @@ hn_dev_tx_queue_setup(struct rte_eth_dev *dev, } error: - if (txq->txdesc_pool) - rte_mempool_free(txq->txdesc_pool); + rte_mempool_free(txq->txdesc_pool); rte_memzone_free(txq->tx_rndis_mz); rte_free(txq); return err; @@ -365,8 +364,7 @@ hn_dev_tx_queue_release(struct rte_eth_dev *dev, uint16_t qid) if (!txq) return; - if (txq->txdesc_pool) - rte_mempool_free(txq->txdesc_pool); + rte_mempool_free(txq->txdesc_pool); rte_memzone_free(txq->tx_rndis_mz); rte_free(txq); From patchwork Mon Jan 24 17:46:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106419 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A25AA04AD; Mon, 24 Jan 2022 18:52:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA7A64295A; Mon, 24 Jan 2022 18:48:31 +0100 (CET) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by mails.dpdk.org (Postfix) with ESMTP id 456434294F for ; Mon, 24 Jan 2022 18:48:29 +0100 (CET) Received: by mail-pg1-f180.google.com with SMTP id z131so5004712pgz.12 for ; Mon, 24 Jan 2022 09:48:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pmG6yMayEtiph+FrBafMWrazhYRcXID3b2Oxjkc6Zrs=; b=8OVoHj3HmGkZKF1Z/IAYfTeCLuBN56zV5tU0C28qUvYWqQoIwEoPcEjK9QpF9j+pWE iROrIn/1CRRedRKJfKRpsio4OTxUFMovpVzmX3BpI0gOD1Usedl42CyV7dHjAOylMxO5 MXsfPkUzL0zOLhK8/mN8yz9rDERQOkt/SCZMWsMiOrqrRpnygozsB1t5O8eLNflR76e3 7MwVAzt0MZcEaDonFbl1iPhPWuMjxuJh1PIjmfH2ezH7z/mQyZ21ONHI1O6vSvso56zb l85XLpVRVrUCNbr4SGriMSd+yH14Hkxbcxs5E6OElkGhg0BKWPshYicpLRt3QjWfGZi1 GJcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pmG6yMayEtiph+FrBafMWrazhYRcXID3b2Oxjkc6Zrs=; b=jK2KBNJ2XVvHs69hr+fqijN9Qj9ZAAwCgfi4D14aN20KX2S4iSwtRDPaUySnFopE6Y uPq+8f7jiDStfBlLJGO1Y9C6ovZ4M6dcVujSd606j0S38FZOCSFr5qkQIoWwJME/Cpfo U9B+nKuFUlMdQ7hQlcjoyD/Mx5Joz4LDRnRhcVxlG8ZMgAGBL4+/hf3sdj5gqWZekFFh YCO3ely3DuIrlYGDHn7zf3PcjIeFFhkEq7+BZNYjlujJ8JJROBAFIjrnuXG2qkv63xfC /0ltfb7+KZV9rRVWSxU0iCYOCOGVX6EVB+cGUU5OplTNEkKETV9D8peeyAfvXRNl2gpy xRYg== X-Gm-Message-State: AOAM532GpII3DnzOFG/ZLrM1f6XBMl0DS5hJZSeW9JNanrC4HQWwZ2+7 nImKol1Sa9q0aVufNL6rOXUKY4XwKlkQWg== X-Google-Smtp-Source: ABdhPJwT4BNVL8Ap8tNX7W+PmLt/HrxiIhM3D20cnJ7636hZyPOHTwIhjxPGinlEx4IXswsFxcmOVQ== X-Received: by 2002:a05:6a00:1905:b0:4a8:2f86:3f18 with SMTP id y5-20020a056a00190500b004a82f863f18mr15005754pfi.52.1643046508369; Mon, 24 Jan 2022 09:48:28 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:27 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tetsuya Mukawa Subject: [PATCH v2 61/83] net/null: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:57 -0800 Message-Id: <20220124174719.14417-62-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/null/rte_eth_null.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index ca03469d0e6d..bb89c1abc4a2 100644 --- a/drivers/net/null/rte_eth_null.c +++ b/drivers/net/null/rte_eth_null.c @@ -717,8 +717,7 @@ rte_pmd_null_probe(struct rte_vdev_device *dev) ret = eth_dev_null_create(dev, &args); free_kvlist: - if (kvlist) - rte_kvargs_free(kvlist); + rte_kvargs_free(kvlist); return ret; } From patchwork Mon Jan 24 17:46:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106420 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6F89A04AD; Mon, 24 Jan 2022 18:53:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F38242961; Mon, 24 Jan 2022 18:48:33 +0100 (CET) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id 62344428D0 for ; Mon, 24 Jan 2022 18:48:30 +0100 (CET) Received: by mail-pf1-f177.google.com with SMTP id v74so13429222pfc.1 for ; Mon, 24 Jan 2022 09:48:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aM7tNyASPlh+DnGyAiA3m15Y+BufQ2gncxDDkMNTg48=; b=J0gx84RziL88YGt3wf5FAQ2c0Z7Q7r28Qn0LNtq+gAcs7B37oDAXTNs1l7TDmU3YFe RWZe89Z/MjDpxLN2dch4m8cvQVf93KV/J24zfatzObiwL85pkRTFEZYrXaoZ1WYiZYVf xfguq7qEdsEMinDswlffeP1J8bfvk5MBg3FttJ7Ln6dRk7K6MMP00U0f+ASnRlwjHAg1 7dN01q3FRafhUQ9J81wVFV/BM5F/sB+eHe0gPyUflX1cjM4iYz/+Q12DIriG/BG3LJsS kKvBJkWmO5ePcyCZYezSU0woe1LolLjmUgPKuATH3+wbv/CnKaBNZ5IX0m9Ck+2AX/LJ 78mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aM7tNyASPlh+DnGyAiA3m15Y+BufQ2gncxDDkMNTg48=; b=lCGqHOm5e+vZOqzUvqfQX08MH1crpjovHfYbmacTq+G71mKaU3+LjHTRQ6MZEILRuG H9hGER7vB7LDhe9XAcVoK0TrXEuCgjCJZfwnR+V2ZjjB83wvoHz67+lAi/+yOZ+jdcAX T59yDI3GSP/HLS5fUO7XhyyldQOldPJAE4UnkTbaXK9/ALcT25nt06eGlPl6R1dIWqaU 5X+zRdgCw5vP1AnV+VYKJ/Rs4ByIuTpjVp9IR/smRtNvu2wWj97lwsvobBeehx03rqpC uTlgOibKVwSFAT62GldeC2pthKlDc8N6i9OxOKfOvaSO51zh4dj1tE4mG74iP2Ae2b5a pj5A== X-Gm-Message-State: AOAM532IMtziV6ZDOiX/FZYykMcBQbbUz9YgzERDGBBMrOuGNudIQFMo PUDuf503Kl8Hyek3OzJY3q97ECU37JO4xg== X-Google-Smtp-Source: ABdhPJyY6Wp0Gv9E7LulxgHlYSvuCFefINqh0bMvrrf0WWRwMJrIYB3flJZB2ksxMF/f01QKo3vtaA== X-Received: by 2002:a05:6a00:853:b0:4c0:3e77:22ea with SMTP id q19-20020a056a00085300b004c03e7722eamr14900972pfk.74.1643046509328; Mon, 24 Jan 2022 09:48:29 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:28 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Harman Kalra Subject: [PATCH v2 62/83] net/octeontx: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:58 -0800 Message-Id: <20220124174719.14417-63-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/octeontx/octeontx_ethdev.c | 3 +-- drivers/net/octeontx/octeontx_ethdev_ops.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c index b47472ebbd93..f5ea9de8efe5 100644 --- a/drivers/net/octeontx/octeontx_ethdev.c +++ b/drivers/net/octeontx/octeontx_ethdev.c @@ -1037,8 +1037,7 @@ octeontx_dev_tx_queue_setup(struct rte_eth_dev *dev, uint16_t qidx, return res; err: - if (txq) - rte_free(txq); + rte_free(txq); return res; } diff --git a/drivers/net/octeontx/octeontx_ethdev_ops.c b/drivers/net/octeontx/octeontx_ethdev_ops.c index 6ec2b71b0672..0b22e28a5625 100644 --- a/drivers/net/octeontx/octeontx_ethdev_ops.c +++ b/drivers/net/octeontx/octeontx_ethdev_ops.c @@ -108,8 +108,7 @@ octeontx_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on) if (rc != 0) { octeontx_log_err("Fail to configure vlan filter entry " "for port %d", nic->port_id); - if (entry) - rte_free(entry); + rte_free(entry); goto done; } From patchwork Mon Jan 24 17:46:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106421 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46A55A04AD; Mon, 24 Jan 2022 18:53:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8078D42963; Mon, 24 Jan 2022 18:48:34 +0100 (CET) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mails.dpdk.org (Postfix) with ESMTP id 66FBA42909 for ; Mon, 24 Jan 2022 18:48:31 +0100 (CET) Received: by mail-pg1-f174.google.com with SMTP id q75so16028054pgq.5 for ; Mon, 24 Jan 2022 09:48:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ge/FJhu17ijyXcd3XG2ocB4hhvAimFOCzaaCeUqhKgw=; b=swlnxKPBqw236qAVfwKJtQZcw9Mj6sszKcPfrx36wu+jc+tvTW8c7hNIlxs8TpSgLE uYGXKmZONMrZxwCvv7+AJe1baW5t4gMRZvhW+6k+6m0jEiAaqEubY6qjeXSFAFDHZZ4w FCwJXgsORwhFLQVM8236RKMTmX3pCQpmetgeUcswvZIc2lAOt0wE+EvFaXb9QCFZ0Lds E+ETONeJwq18dx2b/5Lr9Q0BGNW/g42+uZkO4ifsPJ+PDiSxZGTPvNCqsWFxXJvM6p+p 2d6emSUk2MwwUGBavJoxUGEGXdHAfk3BkdjcM0eTCxxvZwmrH4Tx3mPEY1yTXgYG9t8U TIdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ge/FJhu17ijyXcd3XG2ocB4hhvAimFOCzaaCeUqhKgw=; b=Ig9qOOvMXoAGHyFj8VBSEKC+kXcQLF47OwlpMnd5lb9dd9FjKAx239YfGd8MTdwbhi f0RZnB5e5melhvrSX7m9fDQ2bi3fhlLCt4jJuRSK2Xdmc3NITIhTlQu02JdU1NoLqHi9 nQGrN8DQrCmPP2jS5YYW9dYBcVXsCBsHkCHIr2q2omidiE+1ugfIlVSLIYbIZuUasy/o D6PtlEBg9WISpg1fMGOvYL2CnJzzX6JWj3ZFToEIJYRNOQ/UPPia9jd72k2z6F3TlSoF SgryV3oG05Pe2B3ZnX9fsFgUREAWuBnRnAIz8uWRVwawjAcE1Do0NLcP5/K1kJSJQbFt p7oA== X-Gm-Message-State: AOAM532d3RLNEF2I0BQ37X1QZskisCSQa6fO2DlWqCLR1HIunytjHGGt DZO6amdplVjAOLWcRC5r2EVQSK8yQUYEQg== X-Google-Smtp-Source: ABdhPJwGWvJnr92bD6BJTZmBkvkEsYH48GAlYMihz2xmlPd4IpN48oYcurJwDj/s/L0ESU+FqusBPw== X-Received: by 2002:a05:6a00:be5:b0:4c7:f615:41de with SMTP id x37-20020a056a000be500b004c7f61541demr9471074pfu.34.1643046510478; Mon, 24 Jan 2022 09:48:30 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:29 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rasesh Mody , Devendra Singh Rawat Subject: [PATCH v2 63/83] net/qede: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:46:59 -0800 Message-Id: <20220124174719.14417-64-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Devendra Singh Rawat --- drivers/net/qede/qede_main.c | 3 +-- drivers/net/qede/qede_rxtx.c | 6 ++---- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c index 2d1f70693a3d..ad101194d613 100644 --- a/drivers/net/qede/qede_main.c +++ b/drivers/net/qede/qede_main.c @@ -335,8 +335,7 @@ static int qed_slowpath_start(struct ecore_dev *edev, err: #ifdef CONFIG_ECORE_BINARY_FW if (IS_PF(edev)) { - if (edev->firmware) - rte_free(edev->firmware); + rte_free(edev->firmware); edev->firmware = NULL; } #endif diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index 7088c57b501d..1c0a6ba5f1bf 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -706,12 +706,10 @@ void qede_dealloc_fp_resc(struct rte_eth_dev *eth_dev) } } - if (qdev->fp_array) - rte_free(qdev->fp_array); + rte_free(qdev->fp_array); qdev->fp_array = NULL; - if (qdev->fp_array_cmt) - rte_free(qdev->fp_array_cmt); + rte_free(qdev->fp_array_cmt); qdev->fp_array_cmt = NULL; } From patchwork Mon Jan 24 17:47:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106422 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68C7EA04AD; Mon, 24 Jan 2022 18:53:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B3844296B; Mon, 24 Jan 2022 18:48:35 +0100 (CET) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mails.dpdk.org (Postfix) with ESMTP id A5EA842960 for ; Mon, 24 Jan 2022 18:48:32 +0100 (CET) Received: by mail-pg1-f177.google.com with SMTP id e9so16048510pgb.3 for ; Mon, 24 Jan 2022 09:48:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lx2bqkBQ3SPk3ET4LLPF+ZmKB1ZAk6/Mtv2wfAKRtr0=; b=omHZXJ04mKWsg43e3BBg+A3Y3CxG4tXnDR6MDeQLu3+bfPvbYd8x8PdbUj6abR0tok ZEru+kZ7RZw7BlTc4bnTaIDavfV3zh0hsfAj9oYVrP0ABc6cw7x+1XENs5d8Cg6x2cUl SMrUQ21St0oJ363XXTgsobLIAK7VazFXbWS/6ibW4ff/t6HJo9lHDZSLuLHbIf7bknko aNUu9w9S9E9yML42E8Kxfj3Mnf/wD9zqSh6lj8XPp4x9Tz+3Twlryi1YBacpeN9l3YNQ Coe1Lk7x/0iTf1svgNGLHN38wysXXkhPRDMxPd7gM/1RJSDgt9yb5zmtCqLnLRWaCR8Q cG5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lx2bqkBQ3SPk3ET4LLPF+ZmKB1ZAk6/Mtv2wfAKRtr0=; b=xcDqMvG1/6xyYufpNpWSJlYdO6xlHCLgmShd7NBaT2kQNMqflu2SAyY8N1NPfEGsZC VjXJeJzKu9rrakYw2kaWgqf9+TvEIEB1CNHcKOsFZZaHuVABYJRMBEl4iLM9ONIqCHPS G/x2odEjoAh+gqTbRRR5yqORT+6qhx9/l4O2IjmbYvNCyrIkiyRkBEh1wwBCsYUZFs2t fn+1Mp2423P0xbO0y/O6/vO/nTToisic42XiKeRfqO+aIfGSg2/y7M8YNiixtv1nbS5P yn8pGEC2kLFof48eAv3sEcspFbatCMWsWnUxeG6PyrjkPJLxNlcdpJt54XSPotKHa1K8 0e4Q== X-Gm-Message-State: AOAM5323rrGVlJIopZVdxeSDuScLVPhSClS0/Ioo6VNZHUwlslXQttWH 06LfcSxNicnKJm9rKf6ZwtHK8XXkPTUpDw== X-Google-Smtp-Source: ABdhPJyrtm0MwdDk42SBl4GQWqLu5G8CZLYWiNQz3fwktlPnEaJcrxn+ql+Dcoh7jWFwg3dYkMSr2Q== X-Received: by 2002:a05:6a00:2186:b0:4c6:50ea:6701 with SMTP id h6-20020a056a00218600b004c650ea6701mr14752204pfi.12.1643046511670; Mon, 24 Jan 2022 09:48:31 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:31 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jasvinder Singh , Cristian Dumitrescu Subject: [PATCH v2 64/83] net/softnic: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:00 -0800 Message-Id: <20220124174719.14417-65-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/softnic/rte_eth_softnic_cli.c | 12 ++++-------- drivers/net/softnic/rte_eth_softnic_cryptodev.c | 6 ++---- drivers/net/softnic/rte_eth_softnic_thread.c | 6 ++---- 3 files changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/net/softnic/rte_eth_softnic_cli.c b/drivers/net/softnic/rte_eth_softnic_cli.c index b04e78c6e0af..7acbeecae7a2 100644 --- a/drivers/net/softnic/rte_eth_softnic_cli.c +++ b/drivers/net/softnic/rte_eth_softnic_cli.c @@ -4482,10 +4482,8 @@ parse_free_sym_crypto_param_data(struct rte_table_action_sym_crypto_params *p) switch (xform[i]->type) { case RTE_CRYPTO_SYM_XFORM_CIPHER: - if (p->cipher_auth.cipher_iv.val) - free(p->cipher_auth.cipher_iv.val); - if (p->cipher_auth.cipher_iv_update.val) - free(p->cipher_auth.cipher_iv_update.val); + free(p->cipher_auth.cipher_iv.val); + free(p->cipher_auth.cipher_iv_update.val); break; case RTE_CRYPTO_SYM_XFORM_AUTH: if (p->cipher_auth.auth_iv.val) @@ -4494,10 +4492,8 @@ parse_free_sym_crypto_param_data(struct rte_table_action_sym_crypto_params *p) free(p->cipher_auth.cipher_iv_update.val); break; case RTE_CRYPTO_SYM_XFORM_AEAD: - if (p->aead.iv.val) - free(p->aead.iv.val); - if (p->aead.aad.val) - free(p->aead.aad.val); + free(p->aead.iv.val); + free(p->aead.aad.val); break; default: continue; diff --git a/drivers/net/softnic/rte_eth_softnic_cryptodev.c b/drivers/net/softnic/rte_eth_softnic_cryptodev.c index 9a7d006f1a09..e4754055e90b 100644 --- a/drivers/net/softnic/rte_eth_softnic_cryptodev.c +++ b/drivers/net/softnic/rte_eth_softnic_cryptodev.c @@ -159,10 +159,8 @@ softnic_cryptodev_create(struct pmd_internals *p, return cryptodev; error_exit: - if (cryptodev->mp_create) - rte_mempool_free(cryptodev->mp_create); - if (cryptodev->mp_init) - rte_mempool_free(cryptodev->mp_init); + rte_mempool_free(cryptodev->mp_create); + rte_mempool_free(cryptodev->mp_init); free(cryptodev); diff --git a/drivers/net/softnic/rte_eth_softnic_thread.c b/drivers/net/softnic/rte_eth_softnic_thread.c index a8c26a5b2377..1b3b3c33c175 100644 --- a/drivers/net/softnic/rte_eth_softnic_thread.c +++ b/drivers/net/softnic/rte_eth_softnic_thread.c @@ -29,11 +29,9 @@ softnic_thread_free(struct pmd_internals *softnic) struct softnic_thread *t = &softnic->thread[i]; /* MSGQs */ - if (t->msgq_req) - rte_ring_free(t->msgq_req); + rte_ring_free(t->msgq_req); - if (t->msgq_rsp) - rte_ring_free(t->msgq_rsp); + rte_ring_free(t->msgq_rsp); } } From patchwork Mon Jan 24 17:47:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106423 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCFB8A04AD; Mon, 24 Jan 2022 18:53:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E4544296F; Mon, 24 Jan 2022 18:48:36 +0100 (CET) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by mails.dpdk.org (Postfix) with ESMTP id DBB6342859 for ; Mon, 24 Jan 2022 18:48:33 +0100 (CET) Received: by mail-pg1-f175.google.com with SMTP id q75so16028136pgq.5 for ; Mon, 24 Jan 2022 09:48:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SgZdxQ/v/3DIRfFsYYu4kKYbFgzbBEnlT/pyFLbih4s=; b=K+fGgQ3O8aV7+hM8AS0pGVHlsj/aTe5cWmbynvdDUej6Iasq7B8om1Zz2SgJiGzoTL sITILDDp9q5tavMqQYbaDxYrzRIkcUMGMW0nLHIdOvfv5jSNmYyHi6/6mN+aSVX8MT9L KTopVRTPJI9YiFFxmdW+hPzh4GQ0VBfcsTq40cj9aCj2V+vyzk5/wkGoBf18BBNUkIul xxU5YNnlVplaF7+s/3LpRny/0zvEllAGbzJc4VHPTlSkDBfB9AYwQ6g6ppzKYF3w0Cos HwRzCA/hQFUXOKDZMpaberyzupUf2HIAMrGbhscKarbdr4DRKL6GyaADvZSWG0KWTRh0 YVRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SgZdxQ/v/3DIRfFsYYu4kKYbFgzbBEnlT/pyFLbih4s=; b=VA9hv9qDHqcBK3UUCbcK/ZToBFKwlVB8hfT7RnD23sJZ3zmiLHelt2b7UJSOogKKwP 6+/YYugELsx+OEB6BS3OGhUAKh2/JZPz8GP9qA5uLAdINYoXtb8DNPxgmCVECzft3hij ftHmEbvJYWqeJLrq6HkaFw9dNdoBmBnrPWHPgQwcaIIwDjMzsLsNQ+omLVGtEktSzmHz vKDqsOlqkhsXjwzRPHGCQdI7jBTRd0niTldNzcWdFwftvZltr0V/ufjgCEvx64lCggSd gf7DtNaBPfbYm2qpE0QmLBYoNfvv3wJKD5S453PIX5Q4lQPvudDaAhGAtZ78N0w9n0eF 0DQg== X-Gm-Message-State: AOAM532JAHQ1bEoudbwXS/6aowSWXwMXGlxJC8AVCNMfkyIwqz+ft3RO rxLPwNLXZmQwb2w6og3UnBBtRk+BfQw23Q== X-Google-Smtp-Source: ABdhPJwn4ZNLMZCQGtJC4eRy1LDi1LnQBugxHiO0iulJDtSQYq+/wlXGRHy627xrXnJt593+e4i4rw== X-Received: by 2002:a05:6a02:20a:: with SMTP id bh10mr9710108pgb.544.1643046512964; Mon, 24 Jan 2022 09:48:32 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:32 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Keith Wiles Subject: [PATCH v2 65/83] net/tap: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:01 -0800 Message-Id: <20220124174719.14417-66-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_flow.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index 76738239458a..a9a55e439efc 100644 --- a/drivers/net/tap/tap_flow.c +++ b/drivers/net/tap/tap_flow.c @@ -1465,8 +1465,7 @@ tap_flow_create(struct rte_eth_dev *dev, } return flow; fail: - if (remote_flow) - rte_free(remote_flow); + rte_free(remote_flow); if (flow) tap_flow_free(pmd, flow); return NULL; @@ -1541,8 +1540,7 @@ tap_flow_destroy_pmd(struct pmd_internals *pmd, } } end: - if (remote_flow) - rte_free(remote_flow); + rte_free(remote_flow); tap_flow_free(pmd, flow); return ret; } @@ -1764,8 +1762,7 @@ int tap_flow_implicit_create(struct pmd_internals *pmd, success: return 0; fail: - if (remote_flow) - rte_free(remote_flow); + rte_free(remote_flow); return -1; } From patchwork Mon Jan 24 17:47:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106424 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62A25A04AD; Mon, 24 Jan 2022 18:53:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66FFD42975; Mon, 24 Jan 2022 18:48:37 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 070E042969 for ; Mon, 24 Jan 2022 18:48:35 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id c3so16315980pls.5 for ; Mon, 24 Jan 2022 09:48:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E96ft4qyO/eqoKsfrx/yiUbkbGpU8voQmEFSYUalvxw=; b=z1pLjzhASBAMWjPj63GMzngvme8dwDwU3Ceb+W2fXyZE+x7ghcK75JHVNW7G4RCBDW WIjTfAdg+yAxAl+kU+ug0zB4GsPYFGGlboHKCGoqaFcrLlUtDg68mdcLydXq8pBGZ0Et W9Z5YSfaWY1VyMS//JBM7+9TeU6Z+DVaSAtGihUuWUrQd+6ZwndsFcWkfYWjn2mXG5TN A3r3ERJWRGMzomzpcOoCkMMUJ41r0IvCJs3zGpONelP+RoCYelMO0wjUyW30DOamxTCT WWaNf40uz/l3X/INmKkhTiNv9bDA4tTcU1spMugdyiL2levlONJjUKmLhB6LZlvCLhFJ YHNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E96ft4qyO/eqoKsfrx/yiUbkbGpU8voQmEFSYUalvxw=; b=siPmrJL328Szi2kdSFZpdvCOXg9f9z4QXL+dMiNgFumh7fK3U4U0eon6zr1V6sC8u/ 0zYPBSMrEGuCzfT5yjqEGUBXaTnAQNLrLSD33VrvW3qPdCegi7R0M9dGo19f5WqCnQZz oFwMgRYwIO8qzHzeQF9fULIr8ic1p9ur6tdYm4jpm0eR9OoGsNVDwmHGC3MB2lLcSeZv Vzeu6L7MtE6NanFix2LnOdSOBxQVeMxo8b2VKe6n1O3o/qS5m+9gxP7UM8xS32XnpbG+ 0Y2He+WkBUS6zb+sBco7kvfTQJsDymPw386yHuGoJaThS770CYezprHmBgfxKpcEFaOT FDbQ== X-Gm-Message-State: AOAM530aUiS7AzZnEXwxfzl2dqd2VJjw6u2wzqa6GtD4h7ovZyA5b5DH ESgfIMAR7tj+DEdoJvDkPIox7MKvQLhHCQ== X-Google-Smtp-Source: ABdhPJzckJkoP/KkEvsthtGBasXgSmeuW7c/NHALB9jwHPdlV1fhuJ37/AR8UHx36g5f1dSYRRqDog== X-Received: by 2002:a17:902:7c97:b0:14a:62ed:c296 with SMTP id y23-20020a1709027c9700b0014a62edc296mr15192102pll.42.1643046514027; Mon, 24 Jan 2022 09:48:34 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:33 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jiawen Wu , Jian Wang Subject: [PATCH v2 66/83] net/txgbe: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:02 -0800 Message-Id: <20220124174719.14417-67-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/txgbe/txgbe_ethdev.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index ac4d4e08f407..6024397072c8 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -821,10 +821,8 @@ static int txgbe_fdir_filter_uninit(struct rte_eth_dev *eth_dev) struct txgbe_hw_fdir_info *fdir_info = TXGBE_DEV_FDIR(eth_dev); struct txgbe_fdir_filter *fdir_filter; - if (fdir_info->hash_map) - rte_free(fdir_info->hash_map); - if (fdir_info->hash_handle) - rte_hash_free(fdir_info->hash_handle); + rte_free(fdir_info->hash_map); + rte_hash_free(fdir_info->hash_handle); while ((fdir_filter = TAILQ_FIRST(&fdir_info->fdir_list))) { TAILQ_REMOVE(&fdir_info->fdir_list, @@ -841,10 +839,8 @@ static int txgbe_l2_tn_filter_uninit(struct rte_eth_dev *eth_dev) struct txgbe_l2_tn_info *l2_tn_info = TXGBE_DEV_L2_TN(eth_dev); struct txgbe_l2_tn_filter *l2_tn_filter; - if (l2_tn_info->hash_map) - rte_free(l2_tn_info->hash_map); - if (l2_tn_info->hash_handle) - rte_hash_free(l2_tn_info->hash_handle); + rte_free(l2_tn_info->hash_map); + rte_hash_free(l2_tn_info->hash_handle); while ((l2_tn_filter = TAILQ_FIRST(&l2_tn_info->l2_tn_list))) { TAILQ_REMOVE(&l2_tn_info->l2_tn_list, From patchwork Mon Jan 24 17:47:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106425 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5DCBA04AD; Mon, 24 Jan 2022 18:53:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D24E4297E; Mon, 24 Jan 2022 18:48:38 +0100 (CET) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id DFC1D4290A for ; Mon, 24 Jan 2022 18:48:35 +0100 (CET) Received: by mail-pf1-f175.google.com with SMTP id i65so16675961pfc.9 for ; Mon, 24 Jan 2022 09:48:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cJ0M+HCDv986gQbgz0ZRF2GNeTtogQcsh34js/wezAs=; b=b+T2If+JYfX/gof9i7S1ClinBmZuYH+COLQs0xEZTkIlpxPJj/elFJbmScSviFZD0V jKVDHXztNf2bw/Q2W2Ma9BFcxOdwbNyjnQiK1e3mgviztrhGAAFbAhqYrYcpYbgQaNFa Sd3Zub4oSpbIkDMeP3f87iLHHUi6v/gpX250CPOW0Iy5yLy8UdOCFHe/Z6UPAJkOqwv+ 50A1PCNRcGKMCfw1LhXt555Po8oS7UAWWsqOOv0YWNk54MqcRn+vhiW3QiE6nOrHrk4P cr1+b39EfnDmg3OdS2qi/t3C+KMayiV8ogPkPF54j05KtuMQDo3sXlb4LzMvEPvCodNK ypsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cJ0M+HCDv986gQbgz0ZRF2GNeTtogQcsh34js/wezAs=; b=H9tZxrypucK0VZRQoKBYGhJvOMv38lGHtvsyA7PwonnVcpy1auO3yc9HN77ZNOTwho tizlnDbck87wji+TBJQbnUJl5O0o/HoGrrHCRecfQtEKSttqhs8mH01UfGI4kzujbdf5 u23DpxHb46hG9WsnqN7bHjGjBItY/RXazm3uBdiY8kETWUwuD9H42tlWhJJ3lpBjLrGu tZYuIpR4L84OLDHdM4hgHHjHhiP6xzpFvzr6L/DvJaj+bFyXKwxdNUbjbVPGqQ/eEkZ5 qMFzhCtDcgkUfw7Ei3ioXk0/OzFao31UHdrLL0dhNmpiI7b75PYm0qfV9sM2mQRqbrvg bZiQ== X-Gm-Message-State: AOAM530oxq/Eq0Not0M2xQJvNlyxhUzUd4LVszxthY+afNYJCx9hhgTR 3BGo3IpXISybq0cBnWc1nuW9G/unNrpiMw== X-Google-Smtp-Source: ABdhPJywdNIHb6vnmh57PFAfmeF02DAbo4WyYqTmJT5nlZ5haXQeMb5sZ5H9mT87Hk3eQwDaoTh8bQ== X-Received: by 2002:a63:69c4:: with SMTP id e187mr12799551pgc.442.1643046514954; Mon, 24 Jan 2022 09:48:34 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:34 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Matan Azrad Subject: [PATCH v2 67/83] net/vdev_netvsc: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:03 -0800 Message-Id: <20220124174719.14417-68-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/vdev_netvsc/vdev_netvsc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index 55f2a342c5ae..25871951685c 100644 --- a/drivers/net/vdev_netvsc/vdev_netvsc.c +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c @@ -717,8 +717,7 @@ vdev_netvsc_vdev_probe(struct rte_vdev_device *dev) error: ++vdev_netvsc_ctx_inst; ignore: - if (kvargs) - rte_kvargs_free(kvargs); + rte_kvargs_free(kvargs); /* Reset alarm if there are device context created */ if (vdev_netvsc_ctx_count) { ret = rte_eal_alarm_set(VDEV_NETVSC_PROBE_MS * 1000, From patchwork Mon Jan 24 17:47:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106426 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C70BAA04AD; Mon, 24 Jan 2022 18:53:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55CB34297C; Mon, 24 Jan 2022 18:48:39 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id C58C14288F for ; Mon, 24 Jan 2022 18:48:36 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id y17so5961641plg.7 for ; Mon, 24 Jan 2022 09:48:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JoXl9Uk1M4K/Z8qQv8SBHuUcSVhoJbVr0MBB/3TJed4=; b=cKNI0zU2yejr9/+O/fjWYcAeRzynfjo0rtq31AGwDdtSyVKyfnOv3VEAtLYaV04Idh OprDsYeQYakt7UqpudHnxmhm3D4SbnjCOPyW4u6uwSueUkb6zNnsUyNYKNPIX9rRlejK nmUCYR1+iFdSR1oa/uzwUiX8reMSevFJQZx0t07R+MpOBRnUnYp/ij7ZWEr6VNVgaThW z4R3/6kNkDFpA1QPFgcgrW/OfspAYjDP4BWv7qHfyhOZjP2odEEnOC3QwU1AR3wHL2qm UVZTgtC/cI53P4fwuL+g0GXAI1xR35JGX+ON6p94tsMivuGLy0sunU/Axsly7cwywLWl yFzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JoXl9Uk1M4K/Z8qQv8SBHuUcSVhoJbVr0MBB/3TJed4=; b=N5vUuavkEeoe4hmWuqslm559+NsOsfbOyrZAfVWbL7iUzli8eZiuIca/Fp1W2a6ERR PBqfkfPE9taofMvJw1PIiohnQ37EzH+XeGZihZu2sieiic9LchhOWOk/5NcYux5dXtoR Fj1whxKkC9vsjOVl3nj6LiTT+B39/mq58lrcy6mCH493865770iFk4xykIsz3/cQRNiw 7Ct/x3hfaC7LmEmJJgDtTouS9/5EDIHMJkK08QSfYKqyNHR387xRGMVj0kgIUcFiIapW DjP07cUcVXiYIEKjmo9gH7IYGCBTLpncHITpA9aP7YrbmgZwsf+CMbN5g2BP0LfJg3Uz zjdw== X-Gm-Message-State: AOAM530Dw0184iKbXH3ZAlvdC0Cyhw+jlwnxxtGgEHzxa+XcIhIT4ZuL 471I2+DIYJYYVS8LRrmfahWx25cjNZfOig== X-Google-Smtp-Source: ABdhPJx6CdavDVfWu6bIxh1PzNncMUt0tyw3jDSsZ6rvMr5NUFGRXWweD1aGZNxUAH1An1M1kP/1ag== X-Received: by 2002:a17:903:2287:b0:149:fa57:ea87 with SMTP id b7-20020a170903228700b00149fa57ea87mr15391807plh.94.1643046515847; Mon, 24 Jan 2022 09:48:35 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:35 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Maxime Coquelin , Chenbo Xia Subject: [PATCH v2 68/83] net/virtio: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:04 -0800 Message-Id: <20220124174719.14417-69-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_user_ethdev.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index 0271098f0da0..f6288fd0c492 100644 --- a/drivers/net/virtio/virtio_user_ethdev.c +++ b/drivers/net/virtio/virtio_user_ethdev.c @@ -688,14 +688,10 @@ virtio_user_pmd_probe(struct rte_vdev_device *vdev) ret = 0; end: - if (kvlist) - rte_kvargs_free(kvlist); - if (path) - free(path); - if (mac_addr) - free(mac_addr); - if (ifname) - free(ifname); + rte_kvargs_free(kvlist); + free(path); + free(mac_addr); + free(ifname); return ret; } From patchwork Mon Jan 24 17:47:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106427 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9AF4DA04AD; Mon, 24 Jan 2022 18:53:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A26B4298B; Mon, 24 Jan 2022 18:48:40 +0100 (CET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id CF4E142979 for ; Mon, 24 Jan 2022 18:48:37 +0100 (CET) Received: by mail-pl1-f173.google.com with SMTP id d1so16305211plh.10 for ; Mon, 24 Jan 2022 09:48:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GlREKbjXyKAwHax47U0uz3XIHjJfrZMl9DEn8u7nkFU=; b=Q6w0PO9wi10sk2WyvZNR9ESTdUJutVDmao0QyL43tDGLClrQGPaVwZ9o0NYPPzcFjG QchYBaJB0W1r7vRmvaLMyj89nbVUJJVLC9ggk8BC+9JogrSNu7AqHyqbyQ8qV4mD6534 c+Jp7GJYfBURiOs/KGgJVyY7zYGXfyl07E6GERrE/3DN6xUkAKV3GXVN3usBFisWxIYr qt7SPg3Xn6NsWFh78n2dnc60hpc5ZlafxprPK+hUxBcmFjFebQ7ipbnNdEbrX6Dedcyp 7rFzEEfusU2TFXyu7Pvruyj+e7o7FioX4TwVkOi/LRmBTvDDVFOpvOvxlYXBAfbNX79N 2MJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GlREKbjXyKAwHax47U0uz3XIHjJfrZMl9DEn8u7nkFU=; b=bg2viaVYXSaG4q3qvBBy5XWdxXrLZZkC4n1ajbiqjh6d12YqpYIbMgdoUSPFIajDes sadS3wyRI+NZ84EbuQ+tM169Ayomn8s1P8SnKvAJJofvqYCi4yRXmt8a25GIuo0jybZc enm8GkZl+JsCbG7D4K8vnJpbaedMAOoIB++3uuv3Is1Jthgkvb4Fc0ecoAQ+XCJf0Jrl vkoZlJxnVP3uWHZ1xtG3FEYFv75zDoZFor6e78Eg150NMxsqBvXwk7HnbEceUzMyTtZ4 m9rhzmmRFuCKl9CkReeQk7JvibiirFVPH1A8v+nHzpYNFd9SDnldUoaGiZV6giahMVhj JAjA== X-Gm-Message-State: AOAM530cf4tnCWukBaAB4lPqKdSLS71aecUgrUwUruuTAQ69f2GZeGIq an7vKRLTFKFvsznz5BLG4PmBDnsRw54YTA== X-Google-Smtp-Source: ABdhPJxwlcK7Erm5qzS5QM35V566cXjUeFriF6GhZS5Fg3SFXfHnoXaBCk3Gpv6h7iILYeTNbtEMDQ== X-Received: by 2002:a17:90a:b791:: with SMTP id m17mr2956363pjr.239.1643046516876; Mon, 24 Jan 2022 09:48:36 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:36 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jakub Palider , Tomasz Duszynski Subject: [PATCH v2 69/83] raw/cnxk_bphy: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:05 -0800 Message-Id: <20220124174719.14417-70-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c index 0b694e1c03c3..169cbc785531 100644 --- a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c +++ b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c @@ -233,8 +233,7 @@ cnxk_bphy_cgx_fini_queues(struct cnxk_bphy_cgx *cgx) unsigned int i; for (i = 0; i < cgx->num_queues; i++) { - if (cgx->queues[i].rsp) - rte_free(cgx->queues[i].rsp); + rte_free(cgx->queues[i].rsp); } cgx->num_queues = 0; From patchwork Mon Jan 24 17:47:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106428 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6AB9A04AD; Mon, 24 Jan 2022 18:53:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 993DD42993; Mon, 24 Jan 2022 18:48:41 +0100 (CET) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id AE9FF42984 for ; Mon, 24 Jan 2022 18:48:39 +0100 (CET) Received: by mail-pj1-f50.google.com with SMTP id h12so17131940pjq.3 for ; Mon, 24 Jan 2022 09:48:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3xQB82pDVCLStvS40zRK/t4hyC32t5+bJoM1P8wqznc=; b=pchJ3Hqlv9DKAjpfXlTqmfDWM/i2PajLu8RkO/PaJ+ll/9V5pPp971o4JXjrFlh2vR CK/ofMMSKeH4KZh98JSw4PJQup/SxIdNsrMlTR1hW5/AmB4ySfdp0KgVpaq24S6JioPh 3SSWgPCuQOIs1PW7r2Ax3jyCpb+5e8B5+O5yNGzuGoYngBafnaIko4nQnWpbZA33kHY4 JjovWLJaPemTPTI5+ue4xLSmt6+E1Y240suf30V7SRFyf37ws+OrfR0cZmjiGU2ttNlT p/ZGLKSeK4DdWC4Qfkhp9AeLieHrQKJ41NUS9RPgzwC7I15qsYqIozVS04KSri5LFTv0 B8hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3xQB82pDVCLStvS40zRK/t4hyC32t5+bJoM1P8wqznc=; b=OI6VeGsGfgzTB6Q/XwZG+FZQ1FAMiMo5/gTs/8T9f/5Ho0G78R6hsNpGAdNC09Zj1P LaHRBkAfC5AYj0iYAkR/QkKxsxO+dUvOHCs/jp6rwb6sWH4wsTT9OWskuY39Dj0KxSXl TgaNo4zJBhv/OsNnK7P+TZpDD8Jywz1MH/15KozPwawGnqs2N/RQdzWDzuvb7NSNvL1U N7JwUDVvr32Al8VZ9FdaLaXfPIqxoAYBAv8F+fGNLXkoveQ49Fwy2YZkv2NcUJ2hgGo5 UMJra2c0PPzcLiVNDZOEEC+EmXThHv82ANgS6uJgrIKbHw2T41bDlrV39GXYpxJ2K/B5 8/ng== X-Gm-Message-State: AOAM532oE3ou9ryNyRP4MkRwhTuiH4+shU7LbdW9FxnOqpWYzVcEYMa2 7vmBcxyNk2cd3VwCS82mb/qplOT+nDxGvQ== X-Google-Smtp-Source: ABdhPJxSBTqhbG2bnHgyK/2kA5Va1odhU1+drZrApso7Uq75LrpODWvxm417mf3wZe5FY4i8mz461w== X-Received: by 2002:a17:902:d482:b0:14b:4181:abfb with SMTP id c2-20020a170902d48200b0014b4181abfbmr8007981plg.106.1643046518702; Mon, 24 Jan 2022 09:48:38 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:38 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nipun Gupta Subject: [PATCH v2 70/83] raw/dpaa2_qdma: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:06 -0800 Message-Id: <20220124174719.14417-71-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Nipun Gupta --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c index ebc2cd5d0ddc..b2260439a4ef 100644 --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c @@ -1115,11 +1115,9 @@ dpaa2_qdma_reset(struct rte_rawdev *rawdev) /* Reset and free virtual queues */ for (i = 0; i < qdma_dev->max_vqs; i++) { - if (qdma_dev->vqs[i].status_ring) - rte_ring_free(qdma_dev->vqs[i].status_ring); + rte_ring_free(qdma_dev->vqs[i].status_ring); } - if (qdma_dev->vqs) - rte_free(qdma_dev->vqs); + rte_free(qdma_dev->vqs); qdma_dev->vqs = NULL; /* Reset per core info */ @@ -1314,8 +1312,7 @@ dpaa2_qdma_queue_setup(struct rte_rawdev *rawdev, if (qdma_dev->vqs[i].hw_queue == NULL) { DPAA2_QDMA_ERR("No H/W queue available for VQ"); - if (qdma_dev->vqs[i].status_ring) - rte_ring_free(qdma_dev->vqs[i].status_ring); + rte_ring_free(qdma_dev->vqs[i].status_ring); qdma_dev->vqs[i].status_ring = NULL; rte_spinlock_unlock(&qdma_dev->lock); return -ENODEV; @@ -1516,14 +1513,12 @@ dpaa2_qdma_queue_release(struct rte_rawdev *rawdev, if (qdma_vq->exclusive_hw_queue) free_hw_queue(qdma_vq->hw_queue); else { - if (qdma_vq->status_ring) - rte_ring_free(qdma_vq->status_ring); + rte_ring_free(qdma_vq->status_ring); put_hw_queue(qdma_vq->hw_queue); } - if (qdma_vq->fle_pool) - rte_mempool_free(qdma_vq->fle_pool); + rte_mempool_free(qdma_vq->fle_pool); memset(qdma_vq, 0, sizeof(struct qdma_virt_queue)); From patchwork Mon Jan 24 17:47:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106429 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46B72A04AD; Mon, 24 Jan 2022 18:53:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6CD34299D; Mon, 24 Jan 2022 18:48:42 +0100 (CET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id B0BAE4298F for ; Mon, 24 Jan 2022 18:48:40 +0100 (CET) Received: by mail-pl1-f172.google.com with SMTP id u11so16310597plh.13 for ; Mon, 24 Jan 2022 09:48:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PVNto2xv4wjyh/dpNuE2+eGz0mBChs+YqMwWd+Xh0h4=; b=ISC9xgPa4xpnDbJdiyzvJcuRCL6fkiLJZQ9/yJT1A4THJ4bQEvjwDZ9rJMNtO72TCy rBRU5piqHJzDNB+Mitr7+0JUk8JPKhiHin9t1hQ9zHDGIrSnpAWpo0N8i9vxbSq4ClYJ NkJQKUbq4eta10AowcDSWZSJrUsTIO4X+GEc2mkjYyNR3UPDZxxuYO+4wEGT0ovquxje u+ssKJ3EYV9ObZQ69iJEgmDw6gqa2Y8wWr3quG60Z0zkCjqA2ZrPris6fKwDzUDySImp z5Sv5AG7ClNl2ZVXj01DuCZt1sXvGKNuiOj2cmwDhQnh/oHkQP0qL9XofsDvvZlOnNqR nz0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PVNto2xv4wjyh/dpNuE2+eGz0mBChs+YqMwWd+Xh0h4=; b=nT6DauSZ8MRYPZP25KpG4oJ+kPhAUiBHyiHDEPFiUoh+/OklHceE4mbA/4PLhlUzEq 06HSnpFdjG5H4w3XHsYkg9Rt3izYl61UfGPaDgiElvlESEGG++8TuVr2H75Ln3Pk9g6B MWazQWtQEI8mqMW1J4pZFQEDaHC1oidzlZCaSgco4mPp6gGmzfpYRyhmjoxBa82khUWf oiUf9C2Fmo6qmRgqNw2p/uYxVRks5xxNg7CpqcFgp9QPHv8+jVy8DQqK5Sv/kRvPpCC4 Cl0sHYguvXFzU6EU48QxyazL/6ZqiO3Fx4zswE92N6f13C+UoN0fCmSGtUcb/qyp0rRJ Yl3g== X-Gm-Message-State: AOAM530U2G9SC81nQU6VC9QRp0kFF0JQvxjedW0rmj0dPU6zELcvIaFx MyvajjGXG5XT8iyco3nafFztnPH5P34beQ== X-Google-Smtp-Source: ABdhPJz7g/o4dQ4NYSDaoXmgxwCf/n+QCFc41Xe7N314bUsDQFwm1whGkQMN/UyOUw0m95ALSx8xrQ== X-Received: by 2002:a17:902:ce8e:b0:14b:3589:6c30 with SMTP id f14-20020a170902ce8e00b0014b35896c30mr9566532plg.61.1643046519726; Mon, 24 Jan 2022 09:48:39 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:39 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rosen Xu , Tianfei zhang Subject: [PATCH v2 71/83] raw/ifpga: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:07 -0800 Message-Id: <20220124174719.14417-72-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/raw/ifpga/ifpga_rawdev.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c index 0eae0c9477b6..c68e378dc3ce 100644 --- a/drivers/raw/ifpga/ifpga_rawdev.c +++ b/drivers/raw/ifpga/ifpga_rawdev.c @@ -836,8 +836,7 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int port_id, } free_buffer: - if (buf_to_free) - rte_free(buf_to_free); + rte_free(buf_to_free); close_fd: close(file_fd); file_fd = 0; @@ -1739,10 +1738,8 @@ ifpga_cfg_probe(struct rte_vdev_device *dev) ret = rte_eal_hotplug_add(RTE_STR(IFPGA_BUS_NAME), dev_name, devargs->args); end: - if (kvlist) - rte_kvargs_free(kvlist); - if (name) - free(name); + rte_kvargs_free(kvlist); + free(name); return ret; } From patchwork Mon Jan 24 17:47:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106430 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7734DA04AD; Mon, 24 Jan 2022 18:53:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E60B4429A4; Mon, 24 Jan 2022 18:48:44 +0100 (CET) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id A6FB542995 for ; Mon, 24 Jan 2022 18:48:41 +0100 (CET) Received: by mail-pf1-f173.google.com with SMTP id a8so11337680pfa.6 for ; Mon, 24 Jan 2022 09:48:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=03M1MWvWwhaB58zM0RugVldTl0wx6UK9otpxRcdPWnA=; b=BDT/84OvAVrArJMWgTla8iyhwPTHRF+El2iqUAr3+3wOGLaJ+WoImd9pBsMAYRvBiQ 7lpMiZySIzkDLF7dumpesDfaROvcLEHsWkc/+3AuobSkSCLg4X5nL+2NOZT7VhEx9QAo hBv1fW2H+bhBQadRAfEmY2vYFRLN+41uXDon0gnJ8i7RJFNUGTrS7bYbFzlEmFJJFean PFoh/Fxmd/buSrp6kOKu4AvWWr/2/j2UlQc7STrTyvkGvH5kCJWw7E/nBOhhLOLQwf8s sIZKFT/7pR0+9PIfNfKR+9rce1RJ2inLWFBDv8hphNjPc56lDbjpT24Qhu25OnTJPEB/ /s6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=03M1MWvWwhaB58zM0RugVldTl0wx6UK9otpxRcdPWnA=; b=4Ct98m1YuUQW10uXlUB86IVRz641uHefSKDspiMotNO30qR/jy/qcV/hydHZriS1AL C85KqQcSRxuoQpZBtR+YeWBMJbTPj8ypOhcuhi1woz6d0ZVCvZmwzvh3+nc7RY6nWO5Z p5AIHlkV0dfvUmWYK1vo3xRGxZwtGqYx5IqYR9OBiKLV5xwQU/4pqSDHSCy8HNUk0kVB OLghzOMHXKJexqpirTYxbf/SPiL/aYrtVHU733YExsCS2H37SUAbYHDHeTsxlx6WTLeM f3Qoy3Um2fhKYPHu0+oiLOyogh9vd3lwPOmSxeLQjKLaWpviZve3dvsY8lMxnK5Ni2A/ wgqQ== X-Gm-Message-State: AOAM53206jkWnFbapetf39hDT59UiCb19+WXHKkt2FAkhV+cfyuRUtsl I3dD9vERJwgqHel9TUU0CshSwSw5eS88lw== X-Google-Smtp-Source: ABdhPJyUC9p+7EswA5f1MxZCaMIk+1TalcIF9wiNeWNgX2bB3FCofP4TOr7+md+hXv5Y0R4DNtg/nQ== X-Received: by 2002:a65:6a97:: with SMTP id q23mr12817163pgu.464.1643046520657; Mon, 24 Jan 2022 09:48:40 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:40 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Nipun Gupta Subject: [PATCH v2 72/83] raw/skeleton: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:08 -0800 Message-Id: <20220124174719.14417-73-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/raw/skeleton/skeleton_rawdev_test.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/raw/skeleton/skeleton_rawdev_test.c b/drivers/raw/skeleton/skeleton_rawdev_test.c index 484468eeb460..693b24c415de 100644 --- a/drivers/raw/skeleton/skeleton_rawdev_test.c +++ b/drivers/raw/skeleton/skeleton_rawdev_test.c @@ -395,13 +395,11 @@ test_rawdev_enqdeq(void) RTE_TEST_ASSERT_EQUAL((unsigned int)ret, count, "Unable to dequeue buffers"); - if (deq_buffers) - free(deq_buffers); + free(deq_buffers); return TEST_SUCCESS; cleanup: - if (buffers[0].buf_addr) - free(buffers[0].buf_addr); + free(buffers[0].buf_addr); return TEST_FAILED; } From patchwork Mon Jan 24 17:47:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106431 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 491DDA04AD; Mon, 24 Jan 2022 18:54:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DAF824282B; Mon, 24 Jan 2022 18:48:45 +0100 (CET) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id 9871F4299C for ; Mon, 24 Jan 2022 18:48:42 +0100 (CET) Received: by mail-pj1-f50.google.com with SMTP id n16-20020a17090a091000b001b46196d572so502549pjn.5 for ; Mon, 24 Jan 2022 09:48:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c1GrRG4Ck4OMo8G1Us6LuPxeEg45k1bVfZwOqYl58ec=; b=2kPNr/ZmOaasnfU9wMCe1+tJNqcNOOqhUGpd51CCmM52MWblhdnKtQeFgTOzkbBs/O WJ2jSB0E+XkZRzo3VHRXh7pVA6IIRPdZIjcv3yq3DCADbg79VrF1cUsuuyhinC8ne6cS dAFWRV0g0ipFjdXDMB/kryF2Xv/YkOKHInO38tipzzKRawsOVN1AW11DzBuZKq4WK3xK Yw0N24faNkbezIIPWtHzan3/eWFbPbMaGKCsu50Vb0bLwSfwLwM48RqlLyEIOCkU2PJ9 KfugLlGYXQjLDkANMHNnP0bNZb26hlHOqxtLr4Ebn+mA3KiKd04tjxms39bfDqLy0C+y qAQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c1GrRG4Ck4OMo8G1Us6LuPxeEg45k1bVfZwOqYl58ec=; b=dgZ8117fY+eExRn//0xlG38EQ7qLclUh6imnA/GPaD+yl/I2mQFbrFmUG0tVy/kLAx W1ZZuSEvRFgABqqkE10miV2x7fYOy96WhOE0UYnmIrOkFkOEgSm8mD2Lm9p6MaitVZH/ NRleaLrQ36cblKpPZK2iLuuTRlil9lCmQgvH4JCozuZ3ye/n6bEbYIJtHhIC+WwRvhkW YcP9ujpGWz9D06rIb4v7AG2VF/1ade/ALgTubDnxQbxnYICGnxXox3gPkrV+P5lZGmlK +eNZJVjxCQE7d2fc5KyUpjXF3AMdHPLLQntWq/48PYsxycafVn5eDXSaMzxIyAYSU0Ow KWNQ== X-Gm-Message-State: AOAM533XHbPsplCEscW2awL9TCAJuM27orLyWtee8jLSvpGRAoQ7z2Xk faAuLIEz0k5qxuKI9tooDTgbQ7ZUxK+zow== X-Google-Smtp-Source: ABdhPJzNgaeFkPs+YTNmGvcQwCk6OLlxHr/24t/bKga+3lqxW2U/fEqmq2fPD5EJ9+QTJIhZ9YK13Q== X-Received: by 2002:a17:902:b586:b0:14b:6bab:55e3 with SMTP id a6-20020a170902b58600b0014b6bab55e3mr1167993pls.43.1643046521647; Mon, 24 Jan 2022 09:48:41 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:41 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Liron Himi Subject: [PATCH v2 73/83] regex/cn9k: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:09 -0800 Message-Id: <20220124174719.14417-74-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Liron Himi --- drivers/regex/cn9k/cn9k_regexdev.c | 6 ++---- drivers/regex/cn9k/cn9k_regexdev_compiler.c | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/regex/cn9k/cn9k_regexdev.c b/drivers/regex/cn9k/cn9k_regexdev.c index 32d20c1be82b..56c862c5a76c 100644 --- a/drivers/regex/cn9k/cn9k_regexdev.c +++ b/drivers/regex/cn9k/cn9k_regexdev.c @@ -256,10 +256,8 @@ ree_dev_fini(struct rte_regexdev *dev) cn9k_err("Could not detach queues"); /* TEMP : should be in lib */ - if (data->queue_pairs) - rte_free(data->queue_pairs); - if (data->rules) - rte_free(data->rules); + rte_free(data->queue_pairs); + rte_free(data->rules); roc_ree_dev_fini(vf); diff --git a/drivers/regex/cn9k/cn9k_regexdev_compiler.c b/drivers/regex/cn9k/cn9k_regexdev_compiler.c index 935b8a53b459..60f1c1b4c4d8 100644 --- a/drivers/regex/cn9k/cn9k_regexdev_compiler.c +++ b/drivers/regex/cn9k/cn9k_regexdev_compiler.c @@ -214,8 +214,7 @@ cn9k_ree_rule_db_compile_prog(struct rte_regexdev *dev) rxp_free_structs(NULL, NULL, NULL, NULL, NULL, &rof, NULL, &rofi, NULL, 1); - if (rule_db) - rte_free(rule_db); + rte_free(rule_db); return ret; } From patchwork Mon Jan 24 17:47:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106432 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19BB0A04AD; Mon, 24 Jan 2022 18:54:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 121A6429AD; Mon, 24 Jan 2022 18:48:47 +0100 (CET) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id 858DF4285D for ; Mon, 24 Jan 2022 18:48:43 +0100 (CET) Received: by mail-pf1-f170.google.com with SMTP id x37so12717228pfh.8 for ; Mon, 24 Jan 2022 09:48:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FoY92Tvbw9/KTzBEb5Yi+2WvocRLnZaw6NxOxkmY39I=; b=EM1cqdMQ1u9gG3pjIVdUfQtMs7ZWB4TYgLbqaqx401tB1Oo6UvrH/zgizmEfhj5pmK Gn+bapTxtbjCQPvdFn5PYG/7ZsJqVCQyooRmcLyTt1MJhOyjCGOw0jkrTlpMCHVA7Cqf nsVRh8CeO5EMV/CevhghRFjFuSCeInPtm0zdkMWg0rxWQMG4A71YioKrYjiMVEgaSY6k kC+jh3Q+kBPu2v0uidQHF63/FbrtM8WFjVGbU7A2xGk4mUpthhahgHuzMH4kBALWr9n1 MfwXKw5X9FEhEJOy3Bj/t0Qv3WTjcZ+ExiTW90Ur0Y1gtXZbouDQJIt94etFubVIuMp3 D+Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FoY92Tvbw9/KTzBEb5Yi+2WvocRLnZaw6NxOxkmY39I=; b=nbtEsb0d41fRrcerOXEPp5hdMarVB8ou6UQU0aLH7gZRrAkrBsu9K5k0c/13LC78zU tvM/iQrpMy4IXL2Q2vDgM1uELy1NdsjkQmwJUM1l0LOkD/gJYySM/MFjhJqTtRiXN8Jo dzgl0XkFlxJ342DMyQmFfEDemq04ydl8E53cAtAnRYQiQ9dHUsQQmAl1Fn4xZ0OvNWBv BR4S/1otCwTUjF+1yiludMm2jsDGCDI1d/QoFPwd/OnfkzEnbHpfUawfPxZ+NkiRlyfS EPIKiw59gfyShvPBsIuzBjuP72kv9KCxkg3UPFhdhnz5CtqN9QW5h0hE7iHTuXyK4+wh thZg== X-Gm-Message-State: AOAM530Cc6CYNTPs9QDpY7EBjJ+6hItiZPHYJVGy3cjuQl/WWXdiEuqW yEIY04fgXYSpJP7CosD6JdOC+rhgjwDjtQ== X-Google-Smtp-Source: ABdhPJyiDrl8q2VLBP/8muXenUgsi4sQSJbHLj9azLN+uiVy9OvOEQikHsHpE7hlLHpf50e3OOpE7w== X-Received: by 2002:a63:6e45:: with SMTP id j66mr5555523pgc.81.1643046522575; Mon, 24 Jan 2022 09:48:42 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:42 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ori Kam Subject: [PATCH v2 74/83] regex/mlx5: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:10 -0800 Message-Id: <20220124174719.14417-75-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/regex/mlx5/mlx5_regex.c | 3 +-- drivers/regex/mlx5/mlx5_rxp.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c index e5a12fb3cc4d..48e39f6b8844 100644 --- a/drivers/regex/mlx5/mlx5_regex.c +++ b/drivers/regex/mlx5/mlx5_regex.c @@ -127,8 +127,7 @@ mlx5_regex_dev_probe(struct mlx5_common_device *cdev) if (priv->regexdev) rte_regexdev_unregister(priv->regexdev); dev_error: - if (priv) - rte_free(priv); + rte_free(priv); return -rte_errno; } diff --git a/drivers/regex/mlx5/mlx5_rxp.c b/drivers/regex/mlx5/mlx5_rxp.c index 5ead3ca341ad..99db1e4a865c 100644 --- a/drivers/regex/mlx5/mlx5_rxp.c +++ b/drivers/regex/mlx5/mlx5_rxp.c @@ -166,7 +166,6 @@ mlx5_regex_configure(struct rte_regexdev *dev, DRV_LOG(DEBUG, "Regex config without rules programming!"); return 0; configure_error: - if (priv->qps) - rte_free(priv->qps); + rte_free(priv->qps); return -rte_errno; } From patchwork Mon Jan 24 17:47:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106433 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C69B6A04AD; Mon, 24 Jan 2022 18:54:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E30A42984; Mon, 24 Jan 2022 18:48:48 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 848104285D for ; Mon, 24 Jan 2022 18:48:44 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id x11so10536050plg.6 for ; Mon, 24 Jan 2022 09:48:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5EQ9EclMKZF7bm0DCKVP8jt8Ph49KzbE4XPBP6y6DqU=; b=w3Qv0EMaZz9IfrQKqMZi4WjX8R22Z91Igg70/HPTeB73JZC1BxQ0Pl55p5kDVL4Ae6 SxI8EGXYw+uTWfWpsjnq3km1nO6i+FgfOKr+V8kBCthp6HuCmMQlhjnVAbffdVzpI/m/ f1jSA1/XgKSz9jphfcvFL70OEK92rlDfQy+rmO3ZYFPzn2+QKI9cvSrpEegJImk4J/mZ 404HMhOrakobwIirMp9/w6szabgmNi8bgAuh+eotcrIHs9lpAPIUxy0tCGGEaFjTH5sb FAsMEkeIvlqN1zenmqi8ftffNCislMTuLM67tPucwb+DjuJBkafwfmEXvU5DHH43PfJJ Q7qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5EQ9EclMKZF7bm0DCKVP8jt8Ph49KzbE4XPBP6y6DqU=; b=u9F6Lv4tirpPgOW2GVMLxTOOgljLjzKJWm/+XMt68IqaTnQZLpzQZeDWkJwK9/wBRJ 7IlXFiVJbV0ZW5BCPPhzUvBombYZkSIJwNB83MmCGzrhww0qCJ2Pqb+kveJrm975+8kr TW966RfAeKywULrhZoK3Th+IqbulJM9Inp+tN/yGJ9fWTgvuAMyuOsKPMrxkI/6DJXc6 H6J+CMYqiEHCb3LEo7sYF5dtDRnTYxv/cdq0gp//lnzJCXqdKyyBfdjbp6YGv3rhcbUu t4CHyuSS5igg32GAdIDz/w8keR0+3BmvbfA827zWPPpaGYeFK4wKXnurmHzKkT4wgEYV rpUQ== X-Gm-Message-State: AOAM532KpG+I5qPLoqjSq5GQHZoZEK1ykQWO/dT1Gb4iYZb8poX7yChw uYryIZbylNm7AnnrDlZ8jbAJaal7S1D8iw== X-Google-Smtp-Source: ABdhPJwXLN0VQvjgH+plREr6RLX74zjfnuxwNyhqyk6ZrXkZnAogoM/VPC3HxSzO2a+Cp6tXa3iYVQ== X-Received: by 2002:a17:902:ab8f:b0:14a:adaa:93f2 with SMTP id f15-20020a170902ab8f00b0014aadaa93f2mr15015183plr.131.1643046523546; Mon, 24 Jan 2022 09:48:43 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:43 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Xiao Wang Subject: [PATCH v2 75/83] vdpa/ifc: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:11 -0800 Message-Id: <20220124174719.14417-76-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/ifcvf_vdpa.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c index 3853c4cf7e85..9f05595b6b34 100644 --- a/drivers/vdpa/ifc/ifcvf_vdpa.c +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c @@ -226,8 +226,7 @@ ifcvf_dma_map(struct ifcvf_internal *internal, bool do_map) } exit: - if (mem) - free(mem); + free(mem); return ret; } @@ -253,8 +252,7 @@ hva_to_gpa(int vid, uint64_t hva) } exit: - if (mem) - free(mem); + free(mem); return gpa; } @@ -661,8 +659,7 @@ m_ifcvf_start(struct ifcvf_internal *internal) error: for (i = 0; i < nr_vring; i++) - if (internal->m_vring[i].desc) - rte_free(internal->m_vring[i].desc); + rte_free(internal->m_vring[i].desc); return -1; } From patchwork Mon Jan 24 17:47:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106434 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3649A04AD; Mon, 24 Jan 2022 18:54:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2ED9B429BA; Mon, 24 Jan 2022 18:48:49 +0100 (CET) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id A8F15429A8 for ; Mon, 24 Jan 2022 18:48:45 +0100 (CET) Received: by mail-pg1-f173.google.com with SMTP id z131so5005382pgz.12 for ; Mon, 24 Jan 2022 09:48:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GRDAuxuSBVGu0f5cksd8Yr7OU7H6KcL7WM0YksWYbK0=; b=nZKo+7rwiu7g9lcXAmSb4yEC2D+rOInbcVI120R//0vjBKclX9d9HExlMY3sIaqBge gW/A0RX+acE6SzL+mbUDCzcb0Gw8KTvg9dzb0Ma2VgD3wCKUYPMQHT7uFnoOHuecbprf mD6ELXVhHlqP7Khixm/ppA0LtTyqatJX3Z+9gw4gwloH8+5k1YPabeaI+efc2ih7YMqS rCwBhfjn7o5AdIT9yCZbGSr3EZDibtLsRRKp3AGHFZUjkjXp3k1oLVHRGVEOxWgbm8nd y8mtx/JCTj8w8HppXgd9Aex0TRJgFRB1fKs6U+3ycPz7HKIKz5HlT6DysJYi5iQUqJBi BxXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GRDAuxuSBVGu0f5cksd8Yr7OU7H6KcL7WM0YksWYbK0=; b=BUFU1rvAoQQuHmYKfAjMwfZ6G7c5tXUXACARv9ePCRylGDWahYm2EJ3MrtE9oXETYY 37pfPPlYQnu6mTj/22zXsNgtGuTXUm/W1FYnMXyCH5Cc5uX86wmNSdV7m28KHkISDMku JzN0ixNVala/0jMTECSHoWBC8Atp0IhJBJd+6CwCRFYFW5PgL6Qky2RdOxyUI1TPFLXQ +MEVAVP4iJmHseMRDJEcyFhMfBoFawWJmk/NdXPRzQrd7xFzu8KxjEWUk2aCobsI4p7f C3Q+15dbckeMkSgTV4hQOGkEODPCZESZqUMMUBMynWGuNieKT49I3Xeqg2vJl/p8D52r X9jg== X-Gm-Message-State: AOAM531vyahwSKW91OWmYEp3bV35YZ4qH1jGItOxxG5bi3LipK+aMcXX MtNhRNHUfNfS+xJ1iEqf2TsT/k9FCiGuug== X-Google-Smtp-Source: ABdhPJyBX+p4PMXy+KLmSid+3iTMmlugj+HtzloV1TTzlevyixsfjyCifSD0f6a2UeHpJzz32BDtEA== X-Received: by 2002:a63:6ac1:: with SMTP id f184mr8204479pgc.455.1643046524707; Mon, 24 Jan 2022 09:48:44 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:44 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH v2 76/83] vdpa/mlx5: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:12 -0800 Message-Id: <20220124174719.14417-77-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/vdpa/mlx5/mlx5_vdpa_mem.c | 3 +-- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_mem.c b/drivers/vdpa/mlx5/mlx5_vdpa_mem.c index 130d201a85f5..599079500b03 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa_mem.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa_mem.c @@ -283,8 +283,7 @@ mlx5_vdpa_mem_register(struct mlx5_vdpa_priv *priv) priv->gpa_mkey_index = entry->mkey->id; return 0; error: - if (entry) - rte_free(entry); + rte_free(entry); mlx5_vdpa_mem_dereg(priv); rte_errno = -ret; return ret; diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c index 2f32aef67fbc..3416797d289c 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c @@ -91,8 +91,7 @@ mlx5_vdpa_virtq_unset(struct mlx5_vdpa_virtq *virtq) if (virtq->umems[i].obj) claim_zero(mlx5_glue->devx_umem_dereg (virtq->umems[i].obj)); - if (virtq->umems[i].buf) - rte_free(virtq->umems[i].buf); + rte_free(virtq->umems[i].buf); } memset(&virtq->umems, 0, sizeof(virtq->umems)); if (virtq->eqp.fw_qp) From patchwork Mon Jan 24 17:47:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106435 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BDF2A04AD; Mon, 24 Jan 2022 18:54:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E7C642905; Mon, 24 Jan 2022 18:48:53 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 9221242848 for ; Mon, 24 Jan 2022 18:48:46 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id b15so1760282plg.3 for ; Mon, 24 Jan 2022 09:48:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1DAoQzlpVAiLi7M5ZMRpDmNBblIj0lzrgX6o7y42vtw=; b=EoOdNKlRzkc0BMt32TCxbzH9xboRBGjWfEzSjQtC5AhmPAfTw76euU0ZeUiQlYi+5d IHJqwV45P01ud6tZ5fNJEqZmTViTlvOk3km2Ie6+LJwarCa+gvmbX13nh20dfiHOJX5M YsRo60d9n2PFOeOG2jqh9/XP1BaXbk+8ZmeTUNZGcFOmhM2AZjQRvhzC8l+7VCO8nhxZ SxsuctzrKoN20S8X3CciMGkPjK9GcjmPMZnWBgZBLteFHI8QsUBRNImNMm3dfvs2LkPg kWq0iAwYPr6bIyvgBmnd0Nn4rwNJjuG5ygzqIBI0SHiP6/2c+ZscyoVKTtUbv5DPLajg EPPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1DAoQzlpVAiLi7M5ZMRpDmNBblIj0lzrgX6o7y42vtw=; b=R46Ve3+6zleLbTOs/9jskmp3xFB0vE8nuqw73dNtfICXIlyuXqK65Ndq4cqPIp1BkY kSergIrmfVCX3ikp1fx0gQiBmn4oJuRDNfcp81RcQNNnB4qEPWPZvTUhgJYbMLeLF2Ru O0iFoxz2dHUHhsK6zt7kF8fsNjroFp0O83bzVbzlXHjoINdrdt/b+1WMhl9yxx5Pgdle Wlq5mOj9Ou4AojgoGqJG3iVhxm6A9ONYrE5EYj7d73STwD4SfiEUNwLpFQIKTdSogVKC C0Gce9IWXePchrYhoVqmM1cmqMlh4kpLgBu3J6wJYdzPcl1xdrcBFQ6vMFldG0DtT9Hp 5JOg== X-Gm-Message-State: AOAM533dpk/lPA6fYZmItyMGv1sYBtlNIxg7PBV9U9OnraqhevbuO2aR 565q89/mD6J49scBDDRKg8JjrIkMd+6J2A== X-Google-Smtp-Source: ABdhPJy+054LUdJM4aUHVR7+J4OtnOCdwyguYG1ewdtf1YpJo/SJ6w5/G/9gvxIIZg45JtHSwYcY8w== X-Received: by 2002:a17:90a:9c2:: with SMTP id 60mr2923323pjo.17.1643046525662; Mon, 24 Jan 2022 09:48:45 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:45 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Fan Zhang , Ashish Gupta Subject: [PATCH v2 77/83] compressdev: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:13 -0800 Message-Id: <20220124174719.14417-78-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Fan Zhang --- lib/compressdev/rte_compressdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/compressdev/rte_compressdev.c b/lib/compressdev/rte_compressdev.c index 2e9218af68f6..d4f7d4d3daf2 100644 --- a/lib/compressdev/rte_compressdev.c +++ b/lib/compressdev/rte_compressdev.c @@ -405,8 +405,7 @@ rte_compressdev_queue_pairs_release(struct rte_compressdev *dev) return ret; } - if (dev->data->queue_pairs != NULL) - rte_free(dev->data->queue_pairs); + rte_free(dev->data->queue_pairs); dev->data->queue_pairs = NULL; dev->data->nb_queue_pairs = 0; From patchwork Mon Jan 24 17:47:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106436 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0086A04AD; Mon, 24 Jan 2022 18:54:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A03DD42991; Mon, 24 Jan 2022 18:48:54 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 7036F429B1 for ; Mon, 24 Jan 2022 18:48:47 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id d7so16302666plr.12 for ; Mon, 24 Jan 2022 09:48:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KiInXPZrusCXymjxT5rHhqr72dWr3KdKDt0AAlYKOgg=; b=gkiqaqZyXYBz+RJmQmok02O/3H3Uo4QZDgy5TxOh/ona4FyBMuRDaiyUi5OV3AALYc Shkm5VINUwM/kUP3SnGyCrbgycOrvaORdL8dDTr0LdXucBDoRP8zgHnQNxX0rch/Qee0 oX2L0xYeM8fmhOWpJXfa9veRA9rB4Uv0xAWIquqiktw5LJ7xeU3csVZzalFIEqKTdC6R oZhiMtsxYUDjdyh+V3QbDK+81m7MBs5FIwHtFqcBp1QbykxqkE0DxemDzvV52iOhbBac L6K7Am453yhXoqwQnZ5OacDxdJYrQvb9A63HcbrHraoQKFTzYwUClihHCUTrMoM1ynwj yw1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KiInXPZrusCXymjxT5rHhqr72dWr3KdKDt0AAlYKOgg=; b=qve45hrMtEk/Ot2xoGPCl2ktXcMf3esEAnpaMBg31wkK+9qHufoPfh2/XxiI0WBOHs zWpiYfF9T1NheB5nDfHH/T63OyqRoRq96aTpgXTnJGkL5FIyoSIQ6I/L16+Inhav5yfe YFxP0bUIQzOPg+pHlG2l/Ben3bd1SqRIPh7dypVtZWp/hlyVQzfAGgMrFqlfVGWTuf/R +C8B+5UFlfpZQipIJJO1RCyPcd0el7vYiRKoShEGSkTPC0plx3XG8+5C0Jhnf1wpD3hn pJvuCNmzQ4qwEo2ZLXLp9LU9sUWmXC85t7U69O5mxsdhSI4MjC663k8zNKto27lfkdUP 3Tsw== X-Gm-Message-State: AOAM531hRN9MZF6p6H5O5aBWG5OKOUZ6akgWABpX9dPrMpIpCV69cjev FZE5unmQ0BjroRf+mv7RCEhUz4clzF+XdA== X-Google-Smtp-Source: ABdhPJxh9uBMuG1G20wI6aUNBL7iJrZS4/m4wp6TxfE7d2YFkHdeUHrsO6iRGqCUrY/DsS+LOjS6aQ== X-Received: by 2002:a17:902:bd05:b0:148:a2f7:9d87 with SMTP id p5-20020a170902bd0500b00148a2f79d87mr15320384pls.166.1643046526550; Mon, 24 Jan 2022 09:48:46 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:46 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko Subject: [PATCH v2 78/83] ethdev: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:14 -0800 Message-Id: <20220124174719.14417-79-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/ethdev/rte_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index a1d475a29295..98312fa157f6 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -6036,8 +6036,7 @@ rte_eth_devargs_parse(const char *dargs, struct rte_eth_devargs *eth_da) } parse_cleanup: - if (args.str) - free(args.str); + free(args.str); return result; } From patchwork Mon Jan 24 17:47:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106437 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21ECEA04AD; Mon, 24 Jan 2022 18:54:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABB1B429CD; Mon, 24 Jan 2022 18:48:55 +0100 (CET) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id 51EE7429AE for ; Mon, 24 Jan 2022 18:48:48 +0100 (CET) Received: by mail-pj1-f42.google.com with SMTP id s61-20020a17090a69c300b001b4d0427ea2so21162109pjj.4 for ; Mon, 24 Jan 2022 09:48:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SNwpG3frGNXXYttKmqH6tfoJ/7BWDNsqwVHnDJXpTaM=; b=hGR57Jld5T448uz7SQnriJh4YMypc7VZAx2h5lqx31YPEBKhO4UwIF7TLzbn3oHs4/ /NsUmjZQtSbwZT2FKbz1IUhNwD1PUS5+njsdUYN1cYszzrqA1Q3LOPjZLreHCUOVf8cb KYZcM+irOY6KCNWCf3mhO8r9ouJQ91SRU4vrn2CcOlIv1ReuBp5ljI4bREzK3eMUZGct VPXLWBmNeH+hSJ4CgLdMhHqWgmyq4BIG/XXPlGZ4aEdVI/VGm6WelaCc3gSh1nRW3TsR g7iSFEdRkTkZEuG/JMJb2YEPK+bb1nN28Uj+qD7Jh7AgDyvY6AjCz5qPT8WEXBMZmPL4 zW9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SNwpG3frGNXXYttKmqH6tfoJ/7BWDNsqwVHnDJXpTaM=; b=nbVJ/nqtPTznnwpGOOCGjrT+Iv+hxME6p35nVSH7Bo3EsqOVoumeJhErFvWWzcl3ls VI2seNL5jBqVkkH8ltmYWA9XgIwmAlg6zBwOswb1XHKDwMOB9bOLrtwjvjZ35DNKt+Rj zZLrd8GzKhhMWs30u6Gz4+nJg82bJfeNvwi+0KB7e7A46h3PPSPPrCMTkLIqhL4cpXdi AKnIubH0LpzyIuY6+sxvVuWu8uNJHa2AVkoBtarBwEKaB1xuqELIGlKg0ZUQJEVEehTB DexFzVQ3SeDyj23J1W1WhiHuCKx7II1tBTGDLsYToZHSfpLObnVfOmhR3/hVoLKKvbHM T6Jw== X-Gm-Message-State: AOAM532hN8QluLeMd3A51cUqskMVzPl4zL8h3M1+A9/2pMXbKT+32Is+ o2Kvpg7DCjajCRuEPx9o86t1PNj0kFN2MQ== X-Google-Smtp-Source: ABdhPJxPb0KNOzt5ayPQn2hhhwEvkeY1FdjDP8zDG7zjAzUHtHXVrDc/CKebHt3aBpoSonPXMBCh1A== X-Received: by 2002:a17:90a:5d13:: with SMTP id s19mr2946827pji.117.1643046527390; Mon, 24 Jan 2022 09:48:47 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:47 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram Subject: [PATCH v2 79/83] graph: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:15 -0800 Message-Id: <20220124174719.14417-80-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/graph/graph_stats.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c index aa70929dc32e..65e12d46a313 100644 --- a/lib/graph/graph_stats.c +++ b/lib/graph/graph_stats.c @@ -233,8 +233,7 @@ cluster_add(struct cluster *cluster, struct graph *graph) static void cluster_fini(struct cluster *cluster) { - if (cluster->graphs) - free(cluster->graphs); + free(cluster->graphs); } static int From patchwork Mon Jan 24 17:47:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106438 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5F03A04AD; Mon, 24 Jan 2022 18:54:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98790429D0; Mon, 24 Jan 2022 18:48:56 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 54807429BD for ; Mon, 24 Jan 2022 18:48:49 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id u11so16311198plh.13 for ; Mon, 24 Jan 2022 09:48:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ACG2GULbo70icFSXGiZ3Z6qsdoKq1S0d5ObGSsVkXTs=; b=sCjI6hzMkG30zBh8ZgGEvm+ByVzeMx3DRScX145cf2NPfkzqVwkqgTFpvQzYYYvPfm KOrPKmCz656ALXh7FXGZVq2panuANy0skHwkhygARB+MpBctGeqKFN3AB60rRgTbjrza 4xC1E1eLuj2KMdyZjJrSxXrLx9SIhAmu7jfv94GQPsJlh7NyxEcjKEqY2Ehm5VSgt0bc g2vCjY5zh6RBGAddh8Az0t8PaHbz6ru42L60Jzv/+kzZbKF7BWjDj4e10zGsRM7BrnA1 cH49k9pQ5lS8+ySMomgGNAAzskTKEKlfWF14ICmfT7OEYArt1/R+D8HKE93pYw425WUK R+og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ACG2GULbo70icFSXGiZ3Z6qsdoKq1S0d5ObGSsVkXTs=; b=M4qkeIvCwmLA7Hx3ulEkKsx8NkhHPDjkoUHynAl0+aPjStIlsW4kof+muiSEyzHFqO f8P1cFA1RxKe01QBJIt9F5YU5hWKg1nCMCD/qMrg/ezDV0cAessQW2k0FDdqNqNAtYUK NY0fmJi5J0wHhxSbbx22LUcucbwc6skhL/aWlBVL9tUY5+Y4miZvJz20o+xHraq9Cc6h 6MXFZ2XncN1ExtPJ9qoFoyqMC/vYFOWCh9mRsjy4pomf5o59rh1us57GOxnS3FgQlL3W wPq98fDAe2tgqjOP6m5d77CB7fU10lwRfzar2WvWjh6N+xJU8z2PutJf6xdgjc15NKJO TjKg== X-Gm-Message-State: AOAM53113z+d7uKIzzKE8QlrF8oWmyM3n/4+B++NzxqnE3Yp1ZGJNO9O Ir8ix5BCJFKVBLPlmKOu2AFzsKc1BkGyKA== X-Google-Smtp-Source: ABdhPJzj9EpP4ll3uCNUZ+yDPlDeGokb65i9WJ9PjtnPiWYDruD8qgnHwXajf6uSm2BYqtbnUXAiSw== X-Received: by 2002:a17:902:ce91:b0:14b:42a0:8adf with SMTP id f17-20020a170902ce9100b0014b42a08adfmr7984842plg.1.1643046528390; Mon, 24 Jan 2022 09:48:48 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:47 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Konstantin Ananyev , Bernard Iremonger , Vladimir Medvedkin Subject: [PATCH v2 80/83] ipsec: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:16 -0800 Message-Id: <20220124174719.14417-81-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/ipsec/ipsec_sad.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/ipsec/ipsec_sad.c b/lib/ipsec/ipsec_sad.c index 531e1e323cdc..af4b1ce757d2 100644 --- a/lib/ipsec/ipsec_sad.c +++ b/lib/ipsec/ipsec_sad.c @@ -440,8 +440,7 @@ rte_ipsec_sad_destroy(struct rte_ipsec_sad *sad) rte_hash_free(sad->hash[RTE_IPSEC_SAD_SPI_DIP]); rte_hash_free(sad->hash[RTE_IPSEC_SAD_SPI_DIP_SIP]); rte_free(sad); - if (te != NULL) - rte_free(te); + rte_free(te); } /* From patchwork Mon Jan 24 17:47:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106439 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C164A04AD; Mon, 24 Jan 2022 18:54:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C6BD429D5; Mon, 24 Jan 2022 18:48:57 +0100 (CET) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id 3DFA3429C0 for ; Mon, 24 Jan 2022 18:48:50 +0100 (CET) Received: by mail-pj1-f53.google.com with SMTP id g9-20020a17090a67c900b001b4f1d71e4fso508352pjm.4 for ; Mon, 24 Jan 2022 09:48:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=su+2iWKTkbFtsNLGM+VLfZiV8t8YMaoSIC5oWYs3dcg=; b=2VkdmQo5crYaOImBNKVhgCegi8tJOjt+WIV+jgQ4T9avbrhWwmGwfrm1MN5giTF7oj Q9Cw7uaeYYqZkk7ENNE/U13JAOLZQSwMR55OxkZVJy3LzejRvuVn7Bi5timRDme0EmL1 gfps76N+Jsyh095Xkpl4ZtS2ExpAeg7h/RJ1tNdzQy1Hqwb/7wxjHtuvQhhUu8OUUdS5 Zf/wC0H7DupBPfdjLJXotiqCc9roUskuM5aJK06LIe6cHH1/zqFNMxqNjktjEtsbi2QK nIfqAVylXT5gNpiWKo6ygvePJ9/fxKxUF2OfZFe6YFsYgUzUmuZ2bIFOlwXkl6CBNF/q owOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=su+2iWKTkbFtsNLGM+VLfZiV8t8YMaoSIC5oWYs3dcg=; b=Sea2wMtZikISJ8LWHpMqKWIXfSZ6uvt7xs+SHJF/rYiiTkuwlvdvV+G3ilzFWIOYs8 7VqTT+mFrhLy2D8BzPqCXtzY1VxmIP9Tk1ou1ACUXS99Dx/YeL5q6vfqJlxU4O5qaFhX GqiLoIoUPFy6ov7zi4vh0pZX6Z9bB3VvRzE+0Yr3Qb6m4EFFgpHyDthTpczDwVIgxqCy U9jvpPiwfuBuIS0BMaK+YbSWxcfzJDsoUdxKMz3DvVCvK7sG9GuS2qXukX6LZThCUP73 u7eSEuq6ztQA9jHgqwTC3OnfFRknm0pztNWndrYQ9pO7LbcXtSLZD7EzCBP7xlPiCOA4 AnQw== X-Gm-Message-State: AOAM531jKeu1rV8YYUs/TPEvRWW1OQgkI0PjihOAVccs/WVLPaY3FuDC KrzJIKaIkqNoUa5kEBtqZyCWvzVHBrsofw== X-Google-Smtp-Source: ABdhPJxrdbS2/syqjTgYEUFt/yoAFnQPbJMC9y93LMAqbwjaYUEgafvwZZU6vWsHVJP6AWJh194OPA== X-Received: by 2002:a17:902:c213:b0:14a:f05e:278 with SMTP id 19-20020a170902c21300b0014af05e0278mr15463837pll.133.1643046529311; Mon, 24 Jan 2022 09:48:49 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:48 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Cristian Dumitrescu Subject: [PATCH v2 81/83] port: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:17 -0800 Message-Id: <20220124174719.14417-82-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/port/rte_port_source_sink.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/lib/port/rte_port_source_sink.c b/lib/port/rte_port_source_sink.c index 68575c98338d..79042d13ff66 100644 --- a/lib/port/rte_port_source_sink.c +++ b/lib/port/rte_port_source_sink.c @@ -163,14 +163,10 @@ pcap_source_load(struct rte_port_source *port, return 0; error_exit: - if (pkt_len_aligns) - rte_free(pkt_len_aligns); - if (port->pkt_len) - rte_free(port->pkt_len); - if (port->pkts) - rte_free(port->pkts); - if (port->pkt_buff) - rte_free(port->pkt_buff); + rte_free(pkt_len_aligns); + rte_free(port->pkt_len); + rte_free(port->pkts); + rte_free(port->pkt_buff); return -1; } @@ -242,12 +238,9 @@ rte_port_source_free(void *port) if (p == NULL) return 0; - if (p->pkt_len) - rte_free(p->pkt_len); - if (p->pkts) - rte_free(p->pkts); - if (p->pkt_buff) - rte_free(p->pkt_buff); + rte_free(p->pkt_len); + rte_free(p->pkts); + rte_free(p->pkt_buff); rte_free(p); From patchwork Mon Jan 24 17:47:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106440 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15B1CA04AD; Mon, 24 Jan 2022 18:54:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96E2F429B8; Mon, 24 Jan 2022 18:48:58 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 41CF142905 for ; Mon, 24 Jan 2022 18:48:51 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id u11so16311354plh.13 for ; Mon, 24 Jan 2022 09:48:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BD/62vUpe6M1CCDtT9zTuTpgci3yYRAHi5TUuvAGKPg=; b=YZzJGOGnTkJTgesU4GlOejKFxuup+zNHYOIhVR9Gf7vsupG9QI7/oWoom9ua5Tw9EQ 81aoYh01svJ44xTsFvTx0lF6BMHVXujK1aFbHeYHn4ZBz6oZdf4epVou7WQE2f2QRsT9 P5+DtMHKH7yw9Yo5WguTh7eBUfAAPWPZr+g4GzUP8FL6NdKp6bqzF2n4yBQ+BuphM+Tx pbFe+TObmedHgDOmTekwsm13rNnYN5ZyryCSxCFtE7qq7eZBx7ZS8Da9sMePVwrStBwR GSU8hLtML37P4WTFE5Uo36Iuhz6d2qaNLYWLjtVisU3xl7Hgji5Mhl5qyPe9V2S2AEz3 HpKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BD/62vUpe6M1CCDtT9zTuTpgci3yYRAHi5TUuvAGKPg=; b=CYKiK9YzAFujqTamxouTZUihGnOKK3fQNGtxjea/BcE6BJ3INIK7881EPt505tZKKU k0dMSyTSNDIztDVYUWxBuYUCHpzEjPPMcJb9p0e8Az71HwVeZA/M8dnWrTeqboA3QQls m0jM4QOlMg+dhT5q9f9kWufUrZqj2S77cyRS2GqL0F1lXs1y2/Qf3RhwShW5lsK30Q/k PZhWgL/ry4QIkHv0Jw55RBJjyaUWlwsczemt1FiwbXvQ+6rEyMqopqSpFjUbUj4l6A5S UPuIRXnC8UQpVvtQJ6/Wf1RQmJ6HxU1yPnnrsTkaFm80vG02uWxbc9Y3DoYJ8SMkZeci pAmQ== X-Gm-Message-State: AOAM531oarQ/TYv+avoOG3KlBJ5vvi5x25+76Tmk8gpPqiXNnjzDmOPd zpz0R5l6w1jduIeG6p5VXw6i7GTkzL7RQA== X-Google-Smtp-Source: ABdhPJyfI8PfyOdryc+6RCtFc6k1RxEKfMwHtUP00aidaZV0dH1sf5ol/ZsvwsUZy1V3wZCvBQyAbA== X-Received: by 2002:a17:902:6b02:b0:149:9c7d:3ae7 with SMTP id o2-20020a1709026b0200b001499c7d3ae7mr15287321plk.51.1643046530231; Mon, 24 Jan 2022 09:48:50 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:49 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , David Hunt Subject: [PATCH v2 82/83] power: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:18 -0800 Message-Id: <20220124174719.14417-83-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: David Hunt --- lib/power/rte_power_empty_poll.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/power/rte_power_empty_poll.c b/lib/power/rte_power_empty_poll.c index c4b5de9601cf..2261ce7820f6 100644 --- a/lib/power/rte_power_empty_poll.c +++ b/lib/power/rte_power_empty_poll.c @@ -457,8 +457,7 @@ rte_power_empty_poll_stat_free(void) RTE_LOG(INFO, POWER, "Close the Empty Poll\n"); - if (ep_params != NULL) - rte_free(ep_params); + rte_free(ep_params); } int From patchwork Mon Jan 24 17:47:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106441 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02A16A04AD; Mon, 24 Jan 2022 18:54:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABC16429E9; Mon, 24 Jan 2022 18:48:59 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 25AEA42939 for ; Mon, 24 Jan 2022 18:48:52 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id b15so1760695plg.3 for ; Mon, 24 Jan 2022 09:48:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4JbSYjjocmCv0cQNMjUL6E2+zoHDau5GvbwOfL56L7k=; b=renMYIsk25bwaPlvr2xmVjV9PhcOIVPwn32i+8xZ55Z1yl3vo/PZBxbPyj7gJoAANz wfkeWeQuxM1jIvspRoTMIiIDFU8NJ5krwdUtoAD+dRzMDwR7hugXBFEfj0IbsVGiP5JE x2T4YWapOzdjPEjogw/w33n48R2E7H+LDCFqV1JOo3FrpdLv+0Y333lpNwA+h4UsmWeT TBqEYB5QTPhnqVbvXZgZThw+P3oNxHTxH+Nlw6+K90Y8JlJvVN4nB1u9+pBStdgR0l3w otDGJ3Ngc8w1BMU0rPRykehul0eC2/T9ncHCB//Bqp2pFM482AumxvPyz/OUCdqPyzFN X5pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4JbSYjjocmCv0cQNMjUL6E2+zoHDau5GvbwOfL56L7k=; b=M75GPIFq7sGjjYYutVGix3WQZg5ogsm+XD9pXwhWsT3IFJAQ68qvTz66PZSz6dsS02 DfrDWebGcE8jO26rX8XcVX/KVoX0zbQHWGeIV60c21iieABUkjxhufvDi+Sf8GyRS35p tH9hDuL+p1MWluJ0fOr+8voA4ja5TMM+Dnixd8n72m5PSAWdr50A1CBbZ0Hpr6JMi40u 1xYZ2qdEocQnUYN5NM4n2evNtsNyCxLlXYxN9Qr9OnLV27tyvAC7F1wi4MBIwgWp9fXm nzjD013+zJ2lJR8W7c5Qc7OPv99rWDJ9gVFaJBPFHEwWLhLYe5XeUbLdCxlAnzUnjLmT Fidg== X-Gm-Message-State: AOAM532SRB902wBnnr6HNBUAlrbzlRrjeU+HXGa29hyXUqLgfWV+++FM dUX572bHDVe5gstrgSGU7QxjN84EfbW2lg== X-Google-Smtp-Source: ABdhPJxkN/+TrvtLMfXKdVD4Ttsui6t7eggzIgEumN2C3lzmBL7RSS2yHU08TpvH+66gU4PCyD3NXw== X-Received: by 2002:a17:902:f681:b0:14a:2a1e:4692 with SMTP id l1-20020a170902f68100b0014a2a1e4692mr15051096plg.99.1643046531225; Mon, 24 Jan 2022 09:48:51 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.48.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:48:50 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Reshma Pattan Subject: [PATCH v2 83/83] reorder: remove unnecessary NULL checks Date: Mon, 24 Jan 2022 09:47:19 -0800 Message-Id: <20220124174719.14417-84-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/reorder/rte_reorder.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c index 9445853b79cc..bc0241bfb3fd 100644 --- a/lib/reorder/rte_reorder.c +++ b/lib/reorder/rte_reorder.c @@ -192,10 +192,8 @@ rte_reorder_free_mbufs(struct rte_reorder_buffer *b) /* Free up the mbufs of order buffer & ready buffer */ for (i = 0; i < b->order_buf.size; i++) { - if (b->order_buf.entries[i]) - rte_pktmbuf_free(b->order_buf.entries[i]); - if (b->ready_buf.entries[i]) - rte_pktmbuf_free(b->ready_buf.entries[i]); + rte_pktmbuf_free(b->order_buf.entries[i]); + rte_pktmbuf_free(b->ready_buf.entries[i]); } }