From patchwork Tue Jan 25 14:23:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Weiguo Li X-Patchwork-Id: 106524 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBFA4A00C3; Tue, 25 Jan 2022 15:24:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A34F8429E6; Tue, 25 Jan 2022 15:24:03 +0100 (CET) Received: from out162-62-57-49.mail.qq.com (out162-62-57-49.mail.qq.com [162.62.57.49]) by mails.dpdk.org (Postfix) with ESMTP id 15F76429E6 for ; Tue, 25 Jan 2022 15:24:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1643120640; bh=d9/IPUPFdcKR2pInuMDXZB7AaJ/SVolplluBchljZFU=; h=From:To:Cc:Subject:Date; b=uK+iWf68g50SBHH0tpp3JrfuFfKKCUpAgcxh7j0g1PG2VjrKdEjmNVXeUcuPti/5u SOH+pqbWC/FGSX8hSpLZ8YhV9pBLGjHa9g4WYHbjup8zYq9jJshySdGSrMZRrXpbsy 2BCrF9FLXrM2fidk4/ua7yoUePsQ6Z7UYsBkmlv0= Received: from localhost.localdomain ([111.193.130.237]) by newxmesmtplogicsvrszc8.qq.com (NewEsmtp) with SMTP id 5F084854; Tue, 25 Jan 2022 22:23:48 +0800 X-QQ-mid: xmsmtpt1643120628tim1d2xv7 Message-ID: X-QQ-XMAILINFO: Nb6LX7dsrQEkuy33z9/jJv2a4Lgs1NqfoMFVHqFOeHD43JWM3Ti6d5dmV1Oado jzaFtznw9yaV2u+ZymPwhJUFJdgNdU1t1kuzRdtCj/6C4877CdXVj2GFcG1nZAVdHL33b7uOvrjB PaGaF1M5nDzClrAhrjagDgAfqL7wJOfr1QY0//OqFWGR3bc4VWyygrv9QAfDYZaMwFb7JRVM895E ZdMiSo1Ytgh5c7WDkpgbH5dGxkwUAqsBVr7q8zyFk82Hm9FBm2O6R0iSPQOr7bcsPMB7FEOc54f+ n93Dpr4UI0ZLc2et9pJWn1hVTbMPhQU+hLHRrn0TT4MvM75hQ+EOoCVCsizngg8LS8cCaEJMXFwz N6MSO9ozI88wru6I+/H/zjHh5Q1f7GQY5vrNXgqzytK/B+jnp8ed1G8/xS9zSDKEhqJvJ0JIS0SK q3UMMjKFXjn3N7Q9uP8C15au3bedDwVREApT+7EkcXVxcIZk9s9jnUSuw1KsHl+Fkk6sG9mlHIgX dplyglWdxFa1ZqQ222jYpHABXF98Dc/ltg3N5B+tbB4hHmpvz6GjnAcmTTaqvul0kN9/D6WK4YXk TioJYuZVX+pk2F99vPlIHotM6tG9nGfiIrLAiYLBjLqk6ed/oiMxVmIdRwUqmekz8vu6krxJaf9r FK+l0YovQyBr5RlXe+mp/db1iIdEGVSM9JjkJRddI7B9N141Ii9gUNGa4TRLaG+Z9e+niqPvmjqH L0fE7SxXj8HWDqxhAiq3gmudLp8g2oGy6/ga3zhnidY6+ek22FskiwSwuE4QPc2G0dB8CUbnMdMS 2uIZ9s/FkvMZ3bLdWFhso1ZHGf4E2bldnXGgq2iNcT3zhhI1+lhjSDAuHWhwJfDrMQ0fU2A43Pww == From: Weiguo Li To: hemant.agrawal@nxp.com Cc: nipun.gupta@nxp.com, dev@dpdk.org Subject: [PATCH] net/dpaa2: fix null pointer dereference Date: Tue, 25 Jan 2022 22:23:48 +0800 X-OQ-MSGID: <20220125142348.32249-1-liwg06@foxmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Check for memory allocation failure is added to avoid null pointer dereference. Fixes: 4690a6114ff6 ("net/dpaa2: enable error queues optionally") Signed-off-by: Weiguo Li Reviewed-by: Ferruh Yigit --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 09105f049e..379daec5f4 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -399,6 +399,8 @@ dpaa2_alloc_rx_tx_queues(struct rte_eth_dev *dev) if (dpaa2_enable_err_queue) { priv->rx_err_vq = rte_zmalloc("dpni_rx_err", sizeof(struct dpaa2_queue), 0); + if (!priv->rx_err_vq) + goto fail; dpaa2_q = (struct dpaa2_queue *)priv->rx_err_vq; dpaa2_q->q_storage = rte_malloc("err_dq_storage",