From patchwork Mon Feb 7 15:48:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dariusz Sosnowski X-Patchwork-Id: 106981 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02D03A0352; Mon, 7 Feb 2022 16:49:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9567410F6; Mon, 7 Feb 2022 16:49:31 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2054.outbound.protection.outlook.com [40.107.237.54]) by mails.dpdk.org (Postfix) with ESMTP id 0A36B410FC; Mon, 7 Feb 2022 16:49:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aZXrrkWsJXPLYSPAMkiWvQt1tufBbomg3nz99W0D0vZflarKbNy1zDmaSo3xXG9n2lnXidzxQYkLHd12OYOnVQEEQvZi28QSIKx89aleb0qBPOWQrwdnsHEI6Ql4aMamjyQQNq7aK62Xpfnoyr08UGLqohysrwnSZ5fev60O82KIMSe1D54LYJpJCANczgstIFBNT3o2qN/ZNy9PD65b2y2nxo1gxYXRhgMmmAImECPUAlPuqG7jCR9feHZju/EzfKyag8My51Wz1S2pfMxKjLgXjy3iFrvUMs2lzpp1sa7AO491s+K/6TTv69tAE7L5k9qtbWvDpZMTEoxhWMXJ6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rfd5nqMF8H+HcEFTggmeSzb+YJN3OOaCJdsR9Y9r5tg=; b=Bl36M3a6Eo+KXOEvbAXVUWSFgx3eOqPEJzztjnLXHEtFmQu7Z1HC/FU8bCngFtuNEVROnJ9EMy5SrKp1od1XOSxnzkRD+141YSvI0nUnun7rYNrMkBjIFlQ1ZpGruXxPRZT141Rg5xLpZ8V+3riLDEnOhScJLuNVcy7lrc/QGAiAyCS5Yy+2ea5qaBM9qbp4Tpp+vO14gs/btvvONSWX1ePCefzWIqkiyZ2y3evZ8zczzTR/20HGgmt+t3S5jDJ9YRXLwpozbyILz19NPGV/6ZC/MxJ7T9CMSWJz5MhxFivOceCL21Dgm4xAWEwSQM/AO5plXt004XFpGJqIL1jkOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.238) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rfd5nqMF8H+HcEFTggmeSzb+YJN3OOaCJdsR9Y9r5tg=; b=YOz2PF8DN8l2NmDdBDa5eHDg8PFhyHrpXxPgilbMqFS7/iyeIYWr1U8uMaB+TqJYrJLH5AT6e9tnUSYi4Nixu68GEvF5dV6DwQLTnRLp0WuUiRcT92v6eO7SYl3/e9LhBsu6LWi9LH5VTvnDpRfAiSvcnfAOYgRJPk/M2GWyHWHeiVGrcfDcOPECOYovR4IkD/0D5nE/m1HmzrthI/4Amt0pv9WpxhVwgDAkkUu/jPkUuuH5RypnDJpWmxaZdo17Tno+kKVHNJLeDwrEX6oPJYAGmRyZMi2z6jj3GxfguYQWp5FxRlPvxsFsMEmu+1uZYwlg0mdqJuW4tLpSTtJIhA== Received: from DS7PR05CA0074.namprd05.prod.outlook.com (2603:10b6:8:57::22) by MN2PR12MB3151.namprd12.prod.outlook.com (2603:10b6:208:d1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Mon, 7 Feb 2022 15:49:29 +0000 Received: from DM6NAM11FT016.eop-nam11.prod.protection.outlook.com (2603:10b6:8:57:cafe::17) by DS7PR05CA0074.outlook.office365.com (2603:10b6:8:57::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.5 via Frontend Transport; Mon, 7 Feb 2022 15:49:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.238) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.238 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.238; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.238) by DM6NAM11FT016.mail.protection.outlook.com (10.13.173.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4951.12 via Frontend Transport; Mon, 7 Feb 2022 15:49:29 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL105.nvidia.com (10.27.9.14) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 7 Feb 2022 15:49:26 +0000 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9; Mon, 7 Feb 2022 07:49:24 -0800 From: Dariusz Sosnowski To: Matan Azrad , Viacheslav Ovsiienko CC: , Raslan Darawsheh , Subject: [PATCH] net/mlx5: fix inline length for multi-segment TSO Date: Mon, 7 Feb 2022 17:48:56 +0200 Message-ID: <20220207154856.574542-1-dsosnowski@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c73ef063-4b20-4d3e-b80e-08d9ea516d05 X-MS-TrafficTypeDiagnostic: MN2PR12MB3151:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6YhAdwuOVydtXyR3rhtlAhausJuTVN3dnfuWUc6HTHUfQDh3dsX86t462uGFu5oatZw3DpE2EXwLBoR/6ofNA54oh+nbU4DaubVJ9oe2pDstxYDdrkT3Qf/fkNAr27TkhuP4vb8LGWgDCZdx9tIfDMEzZ3d9IlVDUPXEQXd2utXR/OV8RepusBNcNCXb0UPyPufdkdYlKFDeolaFQfCk7y1XzXJp0jJ5IERf4aDahNk1wUFTYatAhZlb/0h4CZ2TryVtyppXjJuaVUPimYH7HX0r08RfWhOkzXZj3ja+6SuY0OGU5NUMBLbYaVhGDVji/jM+Q03gkMXYf3jXfzpjs9UTRjIfZ37vT73H1p8BloDOejtBYuuNUDqjaNDxicohoyAGFpHmFHLE7S2E60GzwMti0f74yAMBRtsFHmN/k7N45ZnR3C1xRbCaYSMwEaWnxRvHRK1do9EyrfFpWg1IdJoV4LvG4FnS6nROTAjUd1jbU448O8BBvZJ0YjlKFfLRpQZ57ZPDHfHIvIl0PeF6cI4j71rkDwlCcZ6cMw+Fz2q6qaJZiDq/30JoEy73ORzmMYTy+dFsmc7XpwO8FprFgtIAXeqTZYCtTh6n5DOicHW2piXmK1HHcr30uBp/4a1gybSRKTJQnsokp8BcC8K27a9JXuZT/wNeIqJLkqS2dK40oxMumb+eKdqZALHqs4daQifx4mE0oaeVCCt74782KQ== X-Forefront-Antispam-Report: CIP:12.22.5.238; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(26005)(186003)(16526019)(6286002)(1076003)(55016003)(336012)(426003)(70206006)(4326008)(110136005)(54906003)(316002)(83380400001)(70586007)(8676002)(6636002)(450100002)(8936002)(36756003)(36860700001)(40460700003)(7696005)(5660300002)(6666004)(82310400004)(2616005)(508600001)(81166007)(356005)(47076005)(2906002)(86362001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 15:49:29.0571 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c73ef063-4b20-4d3e-b80e-08d9ea516d05 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.238]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT016.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3151 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch removes a redundant assert in mlx5_tx_packet_multi_tso(). That assert assured that the amount of bytes requested to be inlined is greater than or equal to the minimum amount of bytes required to be inlined. This requirement is either derived from the NIC inlining mode or configured through devargs. When using TSO this requirement can be disregarded, because on all NICs it is satisfied by TSO inlining requirements, since TSO requires L2, L3, and L4 headers to be inlined. Fixes: 18a1c20044c0 ("net/mlx5: implement Tx burst template") Cc: viacheslavo@nvidia.com Cc: stable@dpdk.org Signed-off-by: Dariusz Sosnowski Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_tx.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_tx.h b/drivers/net/mlx5/mlx5_tx.h index 099e72935a..398cadfeaa 100644 --- a/drivers/net/mlx5/mlx5_tx.h +++ b/drivers/net/mlx5/mlx5_tx.h @@ -1710,7 +1710,6 @@ mlx5_tx_packet_multi_tso(struct mlx5_txq_data *__rte_restrict txq, inlen <= MLX5_ESEG_MIN_INLINE_SIZE || inlen > (dlen + vlan))) return MLX5_TXCMP_CODE_ERROR; - MLX5_ASSERT(inlen >= txq->inlen_mode); /* * Check whether there are enough free WQEBBs: * - Control Segment