From patchwork Sun Feb 27 07:57:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 108372 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E44FBA00C3; Sun, 27 Feb 2022 08:58:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A8944068A; Sun, 27 Feb 2022 08:58:07 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2081.outbound.protection.outlook.com [40.107.220.81]) by mails.dpdk.org (Postfix) with ESMTP id BE1A640683 for ; Sun, 27 Feb 2022 08:58:05 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lowLu0+AplpdRQSe8IRyuohh4HFC5esRZYBnHyDKwSKnAPW3EHudXa2z/E9WTLYBKi8HAt4qFolfAnInVajeQNV9UTrtNGBxCXOzRFdliQk4uE3R4O0vdU5IY+G8Bz2YkWRpBxAHrTx47yMeet+bVjO1iVGZ743FDWu9VwCoLhHsX781npijPOUGDegD942OFCYCJLNk4LusDj3MCwHr+wRTgfdAhyRlPELcX6zZfCjIHyF7lKo/epZL2H0yfYrDXVkYDc9TswV0sFOYfQTENx+taP6ZCSZtb1LYTw/fRSqpSD9/rHdTvXAH3QQWVOHIlHAHbcACIOHvDOjngx2Hbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LQbujCN61UbiKRMCRNUgv1n8+LehAazrfsjIjJy6104=; b=j0k4yAIpCcLmgO1oyfurDtWKnTylD0brsJt7fAdknu/RjspSRfwJ5VegFc4c4+t31K7vHNC1touqy1AgUJnWVnlfj0JA6dxXXco5q5FrAf70TaB2eWzSOkQ+n7g+zUU1aiGbGKzdMqWAlanMo3jWgSl9ra3eAHqCkCQcktUJWyDZ5aJRmc9EbTQTq8SVd7yFIDciToiiyj5VGEj1Bbz0odchul+FoTTeLGiKNupuNha/+fDtRu75kwh7wtduM7+ldJGkuIwJQQPs4rzdsit2Bbhgb/nil909bxsa4J9GkruybJtYAF8ubm8RV2vF5D27xpnGFd/hpw5sPkIGfq8r2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.235) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LQbujCN61UbiKRMCRNUgv1n8+LehAazrfsjIjJy6104=; b=ODYqThSJpwLe6Da/zyVKh+p8f947PPceJlkuu/e3idVbfXLPGhPevzlvdcpcizEk7kkxcJQneHWnF1wI3sRoNuYYXs3LGHxbJ1TY8iPSwyZAKi2xeH80aGE4fQFRgxYRNg0y36agT4ZAn80HxvRvg7Acl2mPv11BjwhLX5/FYBVxB0v79gAhaTDZPL5YKPkLgi2N+kwHCpJXXuDD/mgMam3W5NeGgMpshb/ZO5lllTqtvHsYJVfdlssfKBPDgLivMJkAua0bhOge6UrO2d1LEwEsSX+XIFIeTgcGL3J9m8wchhTDfgZzonog0Hl9CLO2i5hpiydyMw0SnGnaDG3I5g== Received: from MWHPR10CA0002.namprd10.prod.outlook.com (2603:10b6:301::12) by BY5PR12MB4322.namprd12.prod.outlook.com (2603:10b6:a03:20a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Sun, 27 Feb 2022 07:58:03 +0000 Received: from CO1NAM11FT020.eop-nam11.prod.protection.outlook.com (2603:10b6:301:0:cafe::d1) by MWHPR10CA0002.outlook.office365.com (2603:10b6:301::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21 via Frontend Transport; Sun, 27 Feb 2022 07:58:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.235) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.235 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.235; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.235) by CO1NAM11FT020.mail.protection.outlook.com (10.13.174.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5017.22 via Frontend Transport; Sun, 27 Feb 2022 07:58:02 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sun, 27 Feb 2022 07:58:02 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9; Sat, 26 Feb 2022 23:58:01 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9 via Frontend Transport; Sat, 26 Feb 2022 23:58:00 -0800 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko Subject: [PATCH] common/mlx5: fix missing default devargs initialization Date: Sun, 27 Feb 2022 09:57:53 +0200 Message-ID: <20220227075753.3466574-1-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 73a8a68e-8ad4-4659-9e0a-08d9f9c6e13e X-MS-TrafficTypeDiagnostic: BY5PR12MB4322:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gKP7K2+HVB1Gz7XDgYidWnGVsiz+G1gykDfQkxdWiMhDoDdP6UhSMsUZCFpbLl6eBFA3yZbtnFGKQTYquU2EvJ8G0WFsqT8QKI9CX1x3c5FGX3RMhRx58AOy0GsWNOXwUE9z5eQhC5LjLFvj19zMbX12dfUeOtSEjmy9EZ6PqsC24KHYY8Sgwl6DPaiFh16pYRbrF/V1v8w7HEVsOdql2ai8ecg61fWFCnriRSnYkfsW7PtRAFAbVW7YWH6PgsRC3UoF8xgOjzMajnQYlpZL8fUYJEyickoAdTEgb1liq/FeTRNwIQM0H3fvpyhHlO3HbCAkPpjh3pTTD4yhzaFiyWbRvahVXIisMS7tspiXsKNmJlAFOwOLm9qHLvsOw5AJoOZbORbkJ8ojCmnSGMbyd/nYqnXORz8BmkaP/DlLH7fgqYzgxKF5iPtcBvTqtYxTie6q/O/YZPpIoTGUENFnFjkVBh26bGoSuQb3KyrKx8NsRmV6wChvx2q8zAeBSiVapjOqVzjtY45ZxxePZfQLGWl+FgTsEOryNrrwRu9oWaXlP584f57WuhOqNADJiIzkN9KfRSeqgIWg1yqhxPv1iKdKuwrMZ5o4OHe+qYK8h+OCmeOgwPzFWKSBXt+YVO1AH5GyV1L8bQcSA3KNjnc0dqBnBNPlWG1cvid7BdS+zA+YspEZlo4ApTuB0UPL40FLKYD0hKuuVLEDgUkiqi+T2A== X-Forefront-Antispam-Report: CIP:12.22.5.235; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(81166007)(86362001)(186003)(40460700003)(8676002)(26005)(54906003)(6916009)(1076003)(2616005)(36860700001)(316002)(70206006)(70586007)(2906002)(82310400004)(47076005)(4326008)(107886003)(6286002)(356005)(55016003)(6666004)(8936002)(508600001)(5660300002)(83380400001)(336012)(36756003)(7696005)(426003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2022 07:58:02.6360 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 73a8a68e-8ad4-4659-9e0a-08d9f9c6e13e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.235]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT020.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4322 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Device arguments list is provided along with its identifier as part of EAL arguments. The arguments specified in the list are taken from it, and the rest is initialized to the default values. When no list is provided at all, all arguments should have been initialized to their default values. However, they are mistakenly initialized to zero which may be a valid value for some. This patch initializes the default values before checking whether arguments have been specified. Fixes: 04054be4331c ("common/mlx5: refactor devargs management") Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/mlx5/mlx5_common.c b/drivers/common/mlx5/mlx5_common.c index 94c303ce81..ef1604d223 100644 --- a/drivers/common/mlx5/mlx5_common.c +++ b/drivers/common/mlx5/mlx5_common.c @@ -326,8 +326,6 @@ mlx5_common_config_get(struct mlx5_kvargs_ctrl *mkvlist, }; int ret = 0; - if (mkvlist == NULL) - return 0; /* Set defaults. */ config->mr_ext_memseg_en = 1; config->mr_mempool_reg_en = 1; @@ -335,6 +333,8 @@ mlx5_common_config_get(struct mlx5_kvargs_ctrl *mkvlist, config->dbnc = MLX5_ARG_UNSET; config->device_fd = MLX5_ARG_UNSET; config->pd_handle = MLX5_ARG_UNSET; + if (mkvlist == NULL) + return 0; /* Process common parameters. */ ret = mlx5_kvargs_process(mkvlist, params, mlx5_common_args_check_handler, config);